[Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 15752 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15752action=edit Bug 9722: Allow users to add notes when placing a hold in opac The option of adding a note is controlled by new pref OpacShowHoldNotes. This development is part of a larger one (see umbrella report 9721). Test plan: 1 Verify if new pref is disabled by default. Place a hold. You can't add a note. 2 Enable the pref. Place a hold and add a note. Check in staff if you can see the note in Catalogue Detail/Holds tab. 3 Toggle SingleBranchmode, AllowHoldDateInFuture/OPACAllowHoldDateInFuture, OPACShowHoldQueueDetails, or OPACItemHolds. Check the display of columns when placing a hold from opac. 4 Place a few holds with notes from opac search results in one run (enable DisplayMultiPlaceHold). Check results in staff again. Remark: A few lines already refer to mandatory note reasons. This is handled in a subsequent report. No reason to worry. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #2 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 15753 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15753action=edit Bug 9722: Allow users to add notes when placing a hold in opac Database revision for report 9722, adding new pref OpacShowHoldNotes. This development is part of a larger one (see umbrella report 9721). Test plan: Run [your server]/cgi-bin/koha/installer/install.pl?step=3op=updatestructure Optionally, run a new install to test sysprefs.sql. Or: Edit sysprefs.sql, leave at least the last few lines including the new one. And run from command line: mysql -p [yourdatabase] [your-clone]/installer/data/mysql/sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9726] New: XISBN service throttle not initialized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9726 Bug ID: 9726 Summary: XISBN service throttle not initialized Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: fridolyn.som...@biblibre.com CC: gmcha...@gmail.com For limiting XISBN API use, XISBNDailyLimit syspref is used to compare with daily use count of the API. This count is stored in services_throttle table. But this table content is never initialized, not in installer nor in updatedatabase. So count is never increased and API is used without limit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6281] Bug in LCC sort routine
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6281 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- I set the rule Default filing rules for LCC for the classification source with the 'lcc' code. I created some items for one biblio with different callnumbers, run the maintenance script with the --where param (biblionumber=XXX). I created an inventory with callnumber from QC100 .U57 NO. 555 1986 to QC995 .E29 1997 and it returns items with the following order: QC100 .U57 NO. 555 1986 QC145.45 .H4 D65 1998 QC145 .A57 V.12 1980 QC20.45 .H4 D65 1998 QC995 .E29 1997 It seems that QC145.45 .H4 D65 1998 and QC145 .A57 V.12 1980 are inverted. What I missed? Perhaps I didn't understand what you meant by setting the classification sort to 'lccl'. 'lccl' is a typo ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- There is a typo in the first patch: 6380 A -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9726] XISBN service throttle not initialized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9726 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |fridolyn.som...@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 15754 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15754action=edit Proposed patch See commit comment -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9726] XISBN service throttle not initialized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9726 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9520] Update default LOC Z39.50 target
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9520
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|Signed Off |Failed QA
CC||jonathan.dru...@biblibre.co
||m
--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:
The query is not the good one, mysql raises a warning:
Data truncated for column 'type' at row 4
type is an enum (cf kohastructure: `type` enum('zed','opensearch') NOT NULL
default 'zed')
Marked as Failed QA.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5333] Undefined value stops import from z39.50
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5333 --- Comment #7 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Nice work, I was about to do a similar fix when I found you'd already implemented it.. and it's even been signed off to boot! Great work guys! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9505] acqui/invoices.pl contains an unnecessary loop
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9505 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Patch does not apply: CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt CONFLICT (content): Merge conflict in acqui/invoices.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5333] Undefined value stops import from z39.50
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5333 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #15723|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5333] Undefined value stops import from z39.50
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5333 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m QA Contact|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: Looks good to me (but I am not a MARC21 user). According to the comment, the author normalization is unimarc specific. Marked as Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5333] Undefined value stops import from z39.50
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5333 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #15734|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 15755 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15755action=edit Bug 5333 - z3950 normalization should apply only on UNIMARC It's been a while since this bug is around. This normalization is only used for UNIMARC and yields a fatal error when those variables are set on (at least) MARC21 setups. Regards To+ Signed-off-by: Chris Cormack chr...@catalyst.net.nz Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Amended patch: update comment -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9663] Individual bibliographic record Save option requires export permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9663 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: Since this export script is only accessible from the catalogue/detail.pl page (which has the catalogue permission), I see no reason not to accept this patch. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9663] Individual bibliographic record Save option requires export permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9663 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #15652|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 15756 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15756action=edit Bug 9663 - Individual bibliographic record Save option requires export permission This patch corrects permission on the export option available on catalogue pages in the staff client (detail.pl, MARCdetail.pl, etc) so that users no longer require export_catalogue permission. export_catalogue permission is required only for tools/export.pl. This patch also corrects some crazy nearby indentation. Sorry, couldn't resist. To test, visit a page like detail.pl with and without export_catalogue permission. It should be possible to save the record as MODS, MARCXML, MARC, etc. without error. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9663] Individual bibliographic record Save option requires export permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9663 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Trivial patch QA Contact||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9665] Staff client bibliographic record export missing some options available in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9665 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- The order is different between both interfaces. I think it would be more ergonomic to have the same order. Owen, don't you think that? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9727] New: Typo in code causes compilation failure with Solr enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9727 Bug ID: 9727 Summary: Typo in code causes compilation failure with Solr enabled Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: colin.campb...@ptfs-europe.com With searchengine set to Solr typo in Koha::Searchengine::Solr::Index causes compilation failure you can test by running rebuild_solr.pl -i thus: misc/migration_tools/rebuild_solr.pl -i Global symbol $record_type requires explicit package name at /home/cc/kohaclone/Koha/SearchEngine/Solr/Index.pm line 43. Compilation failed in require at /usr/lib64/perl5/vendor_perl/Class/MOP/Method.pm line 125. Fixing the typo allows the command to run: misc/migration_tools/rebuild_solr.pl -i SolrAPI = http://localhost:8983/solr/koha Solr is Down -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9727] Typo in code causes compilation failure with Solr enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9727 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |colin.campbell@ptfs-europe. ||com --- Comment #1 from Colin Campbell colin.campb...@ptfs-europe.com --- Created attachment 15757 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15757action=edit Proposed patch To test see example in bug description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9656] fines.pl creating a log file should be optional
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: If the -o parameter is given, there is no logfile created, I think it is not consistent. To keep a consistency with current configuration, isn't it better just to produce a log file if the -o parameter exists? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9685] Allow sort baskets by number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: The patch submitted by Owen does not apply (fatal: cannot convert from UTF-8utf-8 to UTF-8). Furthermore before this patch, the table is sorted on the basket name by default, after by basketno. We have to keep the same order. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9656] fines.pl creating a log file should be optional
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 --- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I think we should not be consistent here. Libraries are most probably not aware of those files being created at all. So there might be quite a lot where all those files are still in temp, without anyone noticing or using them. In terms of data privacy this is quite horrible. Also, there is not really a need for those files apart from testing/debugging. All information is also available in Koha using action_log and fineslog system preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9656] fines.pl creating a log file should be optional
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hm, I think I might have misunderstood your comment... digging around a bit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3549] Framework sorting in addbook
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3549 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: This patch changes the order only for 1 page. It is easy to change the sort order for all pages changing the sql query in C4::Koha::getframeworks Marked as Failed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3549] Framework sorting in addbook
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3549 --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Forget that, the routine returns a hashref! However the sort order is not case insensitive (uppercases are sorted before lowercase). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- Srikanth and Melia, Do you think my proposal solves the problem or not? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3503] Automatic rollover of patron category codes based on birth date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3503 --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- See bug 7157 or ask Liz :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9656] fines.pl creating a log file should be optional
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 --- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Oh ok - no opinion on the -o :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9394] Use reserve_id where possible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 --- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Please don't limit testing to running the test suite, but also check the test plan in comment 3 and beyond. This is quite a big change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9381] Add Catalan language
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9381 --- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Bernardo, thank you a lot for your patch! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9727] Typo in code causes compilation failure with Solr enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9727 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9727] Typo in code causes compilation failure with Solr enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9727 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #15757|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 15758 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15758action=edit Bug 9727: Fix typo in variable name Variable is passed as recordtype not record_type correct name Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com before applying the patch $ perl -wc Koha/SearchEngine/Solr/Index.pm Global symbol $record_type requires explicit package name at Koha/SearchEngine/Solr/Index.pm line 43. Koha/SearchEngine/Solr/Index.pm had compilation errors. after Koha/SearchEngine/Solr/Index.pm syntax OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9456] Add callnumber column to the cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: Works great. I don't know if it is relevant to sort on the first value (if there are others one) but I don't have other idea. A followup could be to move javascript code into the datatable.js file. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9456] Add callnumber column to the cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #15727|0 |1 is obsolete|| Attachment #15728|0 |1 is obsolete|| --- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 15759 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15759action=edit Bug 9456 [Alternate] Add callnumber column to the cart This patch adds call-number sorting to the staff client cart on a title-by-title basis. Item information (library, shelving location, and call number) is moved to a table nested in each row. Location and call number columns in this table are sortable. The patch converts table sorting to DataTables (in a race with Bug 9449). The patch does not attempt to make the larger table of titles sortable by call number. To test, add multiple titles to the staff client cart which have multiple items each. The table of titles should still be sortable by title and item type. The table of items in each row should be sortable by location and call number. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9456] Add callnumber column to the cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #20 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 15760 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15760action=edit Bug 9456 [Alternate] Add callnumber column to the cart - Followup - Sort by callnumbers This patch removes the sub-tables for callnumber/location, and simply surrounds them with a span tag. Sorting is enabled on the 'Items' column which uses a custom sorting routine to sort the callnumbers. If the sort is ascending, each column will be sorted by the highest ordered callnumber for that row. Likewise, if the sort is descending the table will be sorted by the lowest valued callnumber for that row. Signed-off-by: Delaye Stephane stephane.del...@biblibre.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3549] Framework sorting in addbook
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3549 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #15594|0 |1 is obsolete|| --- Comment #9 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 15761 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15761action=edit Bug 3549 -[Revised]- Framework sorting in addbook Reviewing Bug 9649, this bug comes up. This patch correctly sort frameworks by description. To test: 1) Go to Cataloguing home, button 'New record' shows unordered list of frameworks 2) Apply the patch 3) refresh, the list must be correctly sorted. Revised to sort using uppercase. Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3549] Framework sorting in addbook
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3549 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #10 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Silly mistake. Fixed -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8917] Track clicks to links external to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 --- Comment #37 from Jonathan Druart jonathan.dru...@biblibre.com --- Comment on attachment 15713 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15713 [SIGNED-OFF] Bug 8917 : Adding link tracking to the opac detail page, without xslt Review of attachment 15713: -- (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=8917attachment=15713) - ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt @@ +716,4 @@ br /[% END %] !-- here you might do a tmpl_if name=toc and use greybox or equivalent for table of contents -- +[% IF ( MARCurl.OPACurlOpenInNewWindow ) %] This is always false. The variable to test is OPACurlOpenInNewWindow. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8917] Track clicks to links external to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917
--- Comment #38 from Jonathan Druart jonathan.dru...@biblibre.com ---
Comment on attachment 15714
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15714
[SIGNED_OFF] Bug 8917 : Script to log link clicks
Review of attachment 15714:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=8917attachment=15714)
-
::: opac/tracklinks.pl
@@ +65,5 @@
+print $cgi-redirect(/cgi-bin/koha/errors/404.pl);# escape early
+exit;
+}
+
+sub trackclick {
Don't we want to have this routine into a new module (in order to prevent sql
code into pl file)?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8917] Track clicks to links external to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #39 from Jonathan Druart jonathan.dru...@biblibre.com --- Marked as Failed QA for the test on the wrong variable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3549] Framework sorting in addbook
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3549 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch QA Contact|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- Thanks Bernardo. Simple patch, it sorts framework by description. I am convinced that a rewrite of C4::Koha::getframeworks would be a good thing. It would return a arrayref (instead of a hashref) with a sorted frameworks list. But it is a bigger patch than this one. Marked as Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3549] Framework sorting in addbook
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3549 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3549] Framework sorting in addbook
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3549 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #15761|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 15762 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15762action=edit Bug 3549 -[Revised]- Framework sorting in addbook Reviewing Bug 9649, this bug comes up. This patch correctly sort frameworks by description. To test: 1) Go to Cataloguing home, button 'New record' shows unordered list of frameworks 2) Apply the patch 3) refresh, the list must be correctly sorted. Revised to sort using uppercase. Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9728] New: XISBN use simple search instead of SQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9728 Bug ID: 9728 Summary: XISBN use simple search instead of SQL Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: fridolyn.som...@biblibre.com CC: gmcha...@gmail.com XISBN API uses normalized ISBN of a biblio to get a list of ISBNs, then searches via SQL in database for notices with those ISBNs. I noticed that if input ISBN has hyphens then returned ISBNs have hyphens else they don't have. So SQL query will not find if ISBNs have hyphens in database. Also, if biblio has several ISBN, only first one can be found with actual SQL query (isbn LIKE '$xisbn%'). So I propose to use a simple search nb=$xisbn. This will find biblio from ISBN with or without hyphen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9728] XISBN use simple search instead of SQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9728 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |fridolyn.som...@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 15763 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15763action=edit Proposed patch See commit comment -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9728] XISBN use simple search instead of SQL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9728 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9520] Update default LOC Z39.50 target
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9520
--- Comment #4 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
(In reply to comment #3)
QA comment:
The query is not the good one, mysql raises a warning:
Data truncated for column 'type' at row 4
type is an enum (cf kohastructure: `type` enum('zed','opensearch') NOT NULL
default 'zed')
Marked as Failed QA.
Sorry but.. did the comment applies to this bug?
bgkriegel@sentey:~/kohaclone$ mysql -uUUU -pPPP kohadev --verbose -e UPDATE
z3950servers SET host = 'lx2.loc.gov', port = 210, db = 'LCDB', type =
'USMARC', encoding = 'utf8' WHERE name = 'LIBRARY OF CONGRESS'
--
UPDATE z3950servers SET host = 'lx2.loc.gov', port = 210, db = 'LCDB', type =
'USMARC', encoding = 'utf8' WHERE name = 'LIBRARY OF CONGRESS'
--
No warnings :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #15010|0 |1 is obsolete|| --- Comment #9 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 15764 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15764action=edit Bug 9254: Problem with EnhancedMessagingPreferences First I don't know the right component to this bug. The problem is the following: - when enabling EnhancedMessagingPreferences, the staff client if able to set the messaging preferences for the patrons categories, and then for the patron (normally the messaging preferences are the same for everyone) - when enabling EnhancedMessagingPreferences, the patrons can set in the OPAC their messaging preferences, which can be against the library rules Solution: - enabling EnhancedMessagingPreferences, should allow the the staff client to set the patrons messaging preferences - enabling EnhancedMessagingPreferences, should't allow patrons to set their messaging preferences (the link doesn't appear in the usermenu.inc) - should be another preference to allow the patrons to set their messaging preferences. Test plan: - apply the patch - enable EnhancedMessagingPreferences, the messaging page should appear in OPAC - disable OPACEnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC - disable EnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC Sponsored-by: KEEP SOLUTIONS Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Rebased on master (2013-02-01) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #15011|0 |1 is obsolete|| --- Comment #10 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 15765 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15765action=edit Bug 9254 - Problem with EnhancedMessagingPreferences - Followup - Rename pref to EnhancedMessagingPreferencesOPAC If the new pref is named EnhancedMessagingPreferencesOPAC, it will show up adjacent to EnhancedMessagingPreferences Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Comment: Works as described. But the patch only hides the link, not disable the feature. If you refresh OPAC after unset EnhancedMessagingPreferencesOPAC, you can still change your messaging preferences. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #11 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- (In reply to comment #8) There is a typo in the first patch: 6380 A Ouch! My mistake. Fixed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9685] Allow sort baskets by number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #15684|0 |1 is obsolete|| --- Comment #4 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 15766 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15766action=edit Proposed patch (revised) Added default sort on basket name. Please re-signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9685] Allow sort baskets by number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9685] Allow sort baskets by number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9520] Update default LOC Z39.50 target
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9520
--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #4)
Sorry but.. did the comment applies to this bug?
Yes!
mysql show create table z3950servers;
[...]
`type` enum('zed','opensearch') NOT NULL DEFAULT 'zed',
[...]
mysql UPDATE z3950servers SET host = 'lx2.loc.gov', port = 210, db = 'LCDB',
type = 'USMARC', encoding = 'utf8' WHERE name = 'LIBRARY OF CONGRESS';
Query OK, 0 rows affected, 1 warning (0.06 sec)
Rows matched: 1 Changed: 0 Warnings: 1
mysql show warnings;
+-+--+---+
| Level | Code | Message |
+-+--+---+
| Warning | 1265 | Data truncated for column 'type' at row 4 |
+-+--+---+
1 row in set (0.00 sec)
mysql select type from z3950servers where name='LIBRARY OF CONGRESS';
+--+
| type |
+--+
| |
+--+
1 row in set (0.00 sec)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9520] Update default LOC Z39.50 target
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9520 --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Bug 9494 does not update the type column. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: (In reply to comment #10) Comment: Works as described. But the patch only hides the link, not disable the feature. If you refresh OPAC after unset EnhancedMessagingPreferencesOPAC, you can still change your messaging preferences. For me this behevior is blocker. If you introduce a restriction for a page, you have to display an error message if the user try to access directly to this page. The issue existed before your patch but it is the good time to do it (a simple test in the pl file and 3 lines in the template file should fix the issue). Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9656] fines.pl creating a log file should be optional
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9656 --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 15767 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15767action=edit Bug 9656: Followup Make logging to a file optional (for fines) The -log option become optional if the -output_dir is given. Test plan: call the script with 1/ no one parameter : no log file 2/ -l : log file will be created in /tmp 3/ -o=/home/koha/var/log : log file with be created in the specified 4/ -o=/home/koha/var/log -l: Same as 3/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #2) Created attachment 15605 [details] [review] Bug 9040 - uninitialized value in concatenation error in Opac-detail.tt Hello Nuño, Is this patch only for 3.8.x? I didn't reproduce the issue on master and the patch does not apply on 3.8.x. In all cases, I think the patch is not good. The test would be on each td: td class=date_due[% IF ( ITEM_RESULT.datedue ) %][% ITEM_RESULT.datedue | $KohaDates %][% END %]/td not on the tr element. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9397] Error Messages hard to find for Visually Impaired Users (Accessibility) [Returning Items]
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9397
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Attachment #14610|0 |1
is obsolete||
--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 15768
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15768action=edit
bug 9397 - Error Messages hard to find for Visually Impaired Users
(Accessibility) [Returning Items] {REVISION 1.1}
testing procedure:
1. Check in Invalid Item
2. See that new header has been added. Can't Check in
Signed-off-by: Liz Rea l...@catalyst.net.nz
A followup may come that makes this text invisible, but this helps
accessibility a great dea, and passes validation.
Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Amended patch: replace Can't Check in with Cannot check in and
delete a h3 element with the same text in order to avoid duplicated
messages.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9397] Error Messages hard to find for Visually Impaired Users (Accessibility) [Returning Items]
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9397 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m Patch complexity|--- |String patch Assignee|koha-b...@lists.koha-commun |agent@gmail.com |ity.org | QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: String modification. I don't see any reason to reject this patch. Marked as Passed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Could you rebase once again please (and perhaps squash these 2 patch into 1) ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 --- Comment #5 from Nuño López Ansótegui nu...@masmedios.com --- (In reply to comment #4) (In reply to comment #2) Created attachment 15605 [details] [review] [review] Bug 9040 - uninitialized value in concatenation error in Opac-detail.tt Hello Nuño, Is this patch only for 3.8.x? I didn't reproduce the issue on master and the patch does not apply on 3.8.x. In all cases, I think the patch is not good. The test would be on each td: td class=date_due[% IF ( ITEM_RESULT.datedue ) %][% ITEM_RESULT.datedue | $KohaDates %][% END %]/td not on the tr element. Marked as Failed QA. This patch is for the master. I have done this as was done in other cases, for example in barcode. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9192] UNIMARC_sync_date_created_with_marc_biblio.pl field creation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192 --- Comment #8 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Is this what you meant Jared ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9520] Update default LOC Z39.50 target
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9520 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #15004|0 |1 is obsolete|| --- Comment #7 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 15769 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15769action=edit Bug 9520 -[Revised] - Update default LOC Z39.50 target This patch updates (if present) target settings of Library of Congress Z39.50 server. Revision: Was trying to update wrong column 'type', now correct column 'syntax'. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9669] Replace YUI buttons on staff client cart toolbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9669 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m Patch complexity|--- |Medium patch QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: Looks good, no regression found, All works great. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9669] Replace YUI buttons on staff client cart toolbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9669 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #15563|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 15770 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15770action=edit Bug 9669 - Replace YUI buttons on staff client cart toolbar This patch converts the toolbar on the staff client cart page to Bootstrap, replacing YUI button code with Bootstrap markup. To test, view the staff client cart and confirm that all buttons look correct and work correctly. Functions to test include: Full/brief display Send Download (various options) Print Empty and close Hide window Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Comment: Tested all buttons, works very well. No errors Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9520] Update default LOC Z39.50 target
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9520 --- Comment #8 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- (In reply to comment #6) Bug 9494 does not update the type column. It doesn't need to. The correct column to update is 'syntax'. I was fooled by the name. I'm sorry (again). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9040] uninitialized value in concatenation error in Opac-detail.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9040 --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- In which cases do you see warning messages? On opac-detail.pl, I just get some warnings about $ccode (Use of uninitialized value $ccode in exists at /home/koha/src/opac/opac-detail.pl line 534). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9729] New: Unable to use IT search terms such as C#, .NET, C++ in searching
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9729 Bug ID: 9729 Summary: Unable to use IT search terms such as C#, .NET, C++ in searching Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: david.w.hart...@disney.com Type in the phrase C# in a search field, and search results has every record with a c. Type in the phrase C++ in a search field, and search results has every record with a c. Type in .NET, and you get more results than .NET books. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9520] Update default LOC Z39.50 target
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9520 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Passed QA Patch complexity|--- |Trivial patch QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #8) (In reply to comment #6) Bug 9494 does not update the type column. It doesn't need to. The correct column to update is 'syntax'. I was fooled by the name. I'm sorry (again). Don't worry, thanks for your quick revised patch! Now it is good. This patch updates the LOC z3950 server for current installations. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9520] Update default LOC Z39.50 target
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9520 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #15769|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 15771 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15771action=edit Bug 9520 -[Revised] - Update default LOC Z39.50 target This patch updates (if present) target settings of Library of Congress Z39.50 server. Revision: Was trying to update wrong column 'type', now correct column 'syntax'. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Amended patch: add the SetVersion call -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5791] Robust handling of deleted biblios/authorities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5791 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=2283 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2283] Poor use of Not Found redirect in response to corrupt MARC record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2283 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=5791 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2283] Poor use of Not Found redirect in response to corrupt MARC record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2283 --- Comment #3 from Tomás Cohen Arazi tomasco...@gmail.com --- This was addressed in bug 5791, I think this should be marked as RESOLVED - FIXED. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9730] New: The sub 'AnonymiseIssueHistory' fails quietly if 'AnonymousPatron' is not a valid entry
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9730 Bug ID: 9730 Summary: The sub 'AnonymiseIssueHistory' fails quietly if 'AnonymousPatron' is not a valid entry Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: christophe.croulleb...@biblibre.com it fails also if 'AnonymousPatron' = 0 With the patch in this case the borrowernumber becomes NULL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9730] The sub 'AnonymiseIssueHistory' fails quietly if 'AnonymousPatron' is not a valid entry
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9730 Christophe Croullebois christophe.croulleb...@biblibre.com changed: What|Removed |Added Assignee|oleon...@myacpl.org |christophe.croullebois@bibl ||ibre.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9731] New: Remove changelanguage.pl in favor of (already present) opac-changelanguage.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9731 Bug ID: 9731 Summary: Remove changelanguage.pl in favor of (already present) opac-changelanguage.pl Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9731] Remove changelanguage.pl in favor of (already present) opac-changelanguage.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9731 --- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 15772 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15772action=edit Bug 9731 - Remove changelanguage.pl in favor of (already present) opac-changelanguage.pl Remove that file that duplicates the behaviour of the correct opac-changelanguage.pl file and fix references to it in the templates. To+ Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9731] Remove changelanguage.pl in favor of (already present) opac-changelanguage.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9731 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9731] Remove changelanguage.pl in favor of (already present) opac-changelanguage.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9731 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9732] New: timestamp not updated when modifying biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9732 Bug ID: 9732 Summary: timestamp not updated when modifying biblio Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: fridolyn.som...@biblibre.com CC: m.de.r...@rijksmuseum.nl When modifying a biblio, biblio.timestamp and biblioitems.timestamp are not updated. Isn't it the main purpose of those fields ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7146] Update timestamps when deleting a biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7146 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9732 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9732] timestamp not updated when modifying biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9732 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=7146 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9617] Replace YUI menu on catalog pages with Bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9617 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m Patch complexity|--- |Medium patch QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: Woow, great patch. cat-toolcar.inc burned eyes so much! :) All works perfectly, I didn't find any regression. I think that a form element with an id='f' and name='f' is not really a good idea since it is an include file, but it was already present before this patch. However, one remark (because I don't know if it is wanted): the div#toolbar has a margin-top: 10px; added by the .btn-toolbar. So the toolbar is 10px under its previous position. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9617] Replace YUI menu on catalog pages with Bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9617 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #15591|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 15773 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15773action=edit Bug 9617 - Replace YUI menu on catalog pages with Bootstrap This patch converts the toolbar include file used by catalog detail pages (detail.pl, MARCdetail.pl, etc.) replacing YUI button and menu code with Bootstrap. Minor change to staff client CSS fixes issue with language footer. Minor change to doc-head-close.inc corrects error in logic for handling cart and lists js discovered in testing. To test, view any page which uses cat-toolbar.inc. Buttons and menus should look correct and work correctly. Functions to test include: New record New item New subscription New child record Edit record Edit items Edit items in a batch Delete items in a batch Attach item Edit as new (duplicate) Replace record via Z39.50 Delete record Delete all items Save (various formats) Add to cart Add to list Print Place hold (including with search-to-hold active). Testing should be done by users with varying permissions including with and without: CAN_user_serials_create_subscription CAN_user_editcatalogue_edit_catalogue CAN_user_editcatalogue_edit_items CAN_user_tools_items_batchmod CAN_user_tools_items_batchdel Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Comment: All buttons tested. Works as described. No Errors. Looks good. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9732] timestamp not updated when modifying biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9732 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |fridolyn.som...@biblibre.co ||m --- Comment #1 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 15774 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15774action=edit Proposed patch See commit comment -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9617] Replace YUI menu on catalog pages with Bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9617 --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #3) However, one remark (because I don't know if it is wanted): the div#toolbar has a margin-top: 10px; added by the .btn-toolbar. So the toolbar is 10px under its previous position. Owen, If is not wanted, we can redefine the margin-top property for div#toolbar ( margin-top: 0;). Could be done in a followup. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9733] New: opac-changelanguage.pl should redirect to OPAC home if no referer (instead of 404 error)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9733 Bug ID: 9733 Summary: opac-changelanguage.pl should redirect to OPAC home if no referer (instead of 404 error) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9428] Use DataTables in Authority MARC frameworks page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9428 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Owen, Is there a reason you didn't keep my changes (aLengthMenu key) in your new patch? I can re add it in my sign off patch if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9733] opac-changelanguage.pl should redirect to OPAC home if no referer (instead of 404 error)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9733 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Depends on||9731 Resolution|--- |INVALID --- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com --- This is an invalid bug! I made a mistake in my tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9731] Remove changelanguage.pl in favor of (already present) opac-changelanguage.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9731 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Blocks||9733 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9511] DOM indexing problem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9511 --- Comment #9 from Paul A pau...@aandc.org --- (In reply to comment #8) For those who are seeing this bug, could you paste the results of running the command zebraidx -V Zebra 2.0.44 (C) 1994-2010, Index Data ApS Zebra is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. SHA1 ID: 419ad759807269fdfa379799a051ed3a551c6541 Using ICU -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9734] New: String::Random is marked as optional, but C4::Members requires it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9734 Bug ID: 9734 Summary: String::Random is marked as optional, but C4::Members requires it Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P2 Component: Installation and upgrade (command-line installer) Assignee: m...@software.coop Reporter: m...@software.coop jcamins confirmed on IRC it is not optional. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9444] Use DataTables in system preferences editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9444 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- This patch breaks the collapse/expand action. The datatable plugin adds a div element around the table :-/ Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m Patch complexity|--- |Trivial patch QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: Add datatable on the systempreferences.pl page (local use only). Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9445] Use DataTables in local use system preferences editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9445 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #15744|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 15775 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15775action=edit Bug 9445 [Revised] Use DataTables in local use system preferences editor Replace the tablesorter plugin with the DataTables plugin in the local use system preferences editor. This patch moves embedding of the toolbar and table-sorting JS from within the body of the page to the head for sake of consistency. To test, open the system preferences editor to the Local Use tab. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Comment: Tab sorting works. No errors. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9734] String::Random is marked as optional, but C4::Members requires it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9734 --- Comment #1 from MJ Ray (software.coop) m...@software.coop --- Created attachment 15776 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15776action=edit Bug 9734 - String::Random is marked as optional, but C4::Members requires it jcamins confirmed on IRC it is not optional. To test: 1) perl koha_perl_deps.pl -a |grep String::Random 2) notice the No in the last column - it should be Yes 3) apply patch and repeat same steps, looking for Yes. Sponsored-by: software.coop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9734] String::Random is marked as optional, but C4::Members requires it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9734 MJ Ray (software.coop) m...@software.coop changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9735] New: Choose OPAC language in links to any page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9735 Bug ID: 9735 Summary: Choose OPAC language in links to any page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: tomasco...@gmail.com The key idea was pointed by kf on Bug 7514: having a 'language' parameter parsed to circumvent cookies and browser detection for language selection. On that bug it was provided a way to have a URL for retreiving the OPAC's homepage in the desired language (http://OPAC_FQDN/cgi-bin/koha/changelanguage.pl?language=LANG_CODE) [1] This bugs ask for the implementation of this OPAC-wide, not just for the homepage. Regards To+ [1] After 9731 is applied http://OPAC_FQDN/cgi-bin/koha/opac-changelanguage.pl?language=LANG_CODE should be used -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
