[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #30 from Katrin Fischer --- Hm, reading through the bug this morning, the functionality sounds a bit similar to RefundLostItemFeeOnReturn (except for the part about the replacement price). Kyle, could you check the new pref in master and that ForgiveFineWhenLost is still needed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8215] Add Course Reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Katrin Fischer changed: What|Removed |Added Version|3.12|3.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #57 from Mason James --- Created attachment 17374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17374&action=edit Bug 8033 - add print receipt option to Koha self-check (edit) 4 misc follow-up fixes 1/ fixed printslip.tmpl typo 2/ fixed display bug 3/ moved hardcoded text string from script to template. 4/ delete unused receipt.tt file To Test: - Sign in to self checkout. - Enter a barcode and click submit. - Click the finish button - You should be prompted with a message asking if you would like a receipt. If you click OK you should be taken to the page with the receipt. If you click Cancel you should not see the reciept and you should be logged out. fyi: you should no longer see a " Print Receipt for..." line in chrome/IE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Mason James changed: What|Removed |Added Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #56 from Mason James --- (In reply to comment #55) > Created attachment 17373 [details] [review] > Bug 8033 [Follow-up] add print receipt option to Koha self-check > > This follow-up makes some corrections to JavaScript, most importantly > by enabling translation of strings embedded in the script. Other > corrections: Trailing whitespace, proper
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Mason James changed: What|Removed |Added Attachment #14498|0 |1 is obsolete|| --- Comment #55 from Mason James --- Created attachment 17373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17373&action=edit Bug 8033 [Follow-up] add print receipt option to Koha self-check This follow-up makes some corrections to JavaScript, most importantly by enabling translation of strings embedded in the script. Other corrections: Trailing whitespace, proper
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Mason James changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #54 from Mason James --- (In reply to comment #53) > (In reply to comment #51) > > (In reply to comment #50) > > > Could someone confirm this file (sco/receipt.tt) can be removed? > > > > I've searched in my text editor and grepped the files within the sco > > directories in cgi-bin and htdocs, and I cannot see any reference to > > sco/receipt.tt > > interesting... > > despite sco/receipt.tt being added to the repo in commit a0b220f8551 > it looks like it's probably never been used/referred to? > > so, delete this file for sure :) ah, i see now... the orig. file was opac/sco/receipt.tmpl and was used by opac/sco/printer.pl opac/sco/printer.pl was removed, but its tmpl/tt file was not the file can still be removed safely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #53 from Mason James --- (In reply to comment #51) > (In reply to comment #50) > > Could someone confirm this file (sco/receipt.tt) can be removed? > > I've searched in my text editor and grepped the files within the sco > directories in cgi-bin and htdocs, and I cannot see any reference to > sco/receipt.tt interesting... despite sco/receipt.tt being added to the repo in commit a0b220f8551 it looks like it's probably never been used/referred to? so, delete this file for sure :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9250] Provide commands to allow handling of SIP servers in the packages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9250 Robin Sheat changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #8 from Robin Sheat --- Passing QA as it doesn't touch anything outside the packaging directory. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8684] Duplicate check for creating items on order broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8684 --- Comment #3 from Katrin Fischer --- Merging with duplicate bug 9185: Settings: AcqCreateItem = on receive UniqueItemFields = barcode 1) Create a new order with one or more order lines 2) Close basket 3) Create a new invoice/shipment 4) Receive one item, use existing barcode Problem: - on saving, no warning appears - item creation silently fails Log: ... [Sat Dec 01 23:11:05 2012] [error] [client 127.0.0.1] [Sat Dec 1 23:11:05 2012] finishreceive.pl: Indicator in 952 is empty at /home/katrin/kohaclone/C4/Biblio.pm line 2285., referer: http://localhost:8080/cgi-bin/koha/acqui/orderreceive.pl?ordernumber=25&invoiceid=3 [Sat Dec 01 23:11:05 2012] [error] [client 127.0.0.1] [Sat Dec 1 23:11:05 2012] finishreceive.pl: DBD::mysql::st execute failed: Duplicate entry '3' for key 'itembarcodeidx' at /home/katrin/kohaclone/C4/Items.pm line 2105., referer: http://localhost:8080/cgi-bin/koha/acqui/orderreceive.pl?ordernumber=25&invoiceid=3 [Sat Dec 01 23:11:05 2012] [error] [client 127.0.0.1] [Sat Dec 1 23:11:05 2012] finishreceive.pl: DBD::mysql::st execute failed: Column 'itemnumber' cannot be null at /home/katrin/kohaclone/C4/Acquisition.pm line 1094., referer: http://localhost:8080/cgi-bin/koha/acqui/orderreceive.pl?ordernumber=25&invoiceid=3 ... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8684] Duplicate check for creating items on order broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8684 --- Comment #2 from Katrin Fischer --- *** Bug 9185 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9185] Duplicate barcode check broken on order receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9185 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 8684 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10030] MaxFines checks against amount, not amount outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10030] MaxFines checks against amount, not amount outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 --- Comment #1 from Kyle M Hall --- Created attachment 17372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17372&action=edit Bug 10030 - MaxFines checks against amount, not amount outstanding If a patron has over time accumulated fines greater than the amount defined in MaxFine, the patron will never get more fines even if they have previously paid off those fines. This bug was introduced by the patch for Bug 7420. Test Plan: 1) Create a patron 2) Create a fine of 10.00 for that patron 3) Pay off the fine 4) Set MaxFines to 5.00 5) Check out an item to the patron, backdate the due date so the item should generate fines. 6) Run fines.pl, observe that no fine was created 7) Apply the patch 8) Rerun fines.pl 9) Observe that the fine was created correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10030] New: MaxFines checks against amount, not amount outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 Bug ID: 10030 Summary: MaxFines checks against amount, not amount outstanding Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle.m.h...@gmail.com CC: gmcha...@gmail.com, kyle.m.h...@gmail.com If a patron has over time accumulated fines greater than the amount defined in MaxFine, the patron will never get more fines even if they have previously paid off those fines. This bug was introduced by the patch for Bug 7420. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9534] No way to get back to bib detail from edit record screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9534 Chris Nighswonger changed: What|Removed |Added CC||cnighswon...@foundations.ed ||u --- Comment #9 from Chris Nighswonger --- I think 'BiblioDefaultDisplay' should read 'BiblioDefaultView' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10025] star ratings aren't saving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10025 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel --- Works for me (master) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9452] C4::Letters does not function under Plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 Colin Campbell changed: What|Removed |Added CC||colin.campbell@ptfs-europe. ||com --- Comment #3 from Colin Campbell --- The location of the problem generating the state db handles was identified on bug 9138 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10029] CAS authentication fails in OPAC reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10029 Fridolyn SOMERS changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |fridolyn.som...@biblibre.co ||m --- Comment #1 from Fridolyn SOMERS --- Created attachment 17371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17371&action=edit Proposed patch See commit message. Patch maybe does not cover the whole problem. Help will be warmly welcomed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9834] Should reverting a waiting hold keep the item number?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834 Mickey Coalwell changed: What|Removed |Added CC||mcoalw...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10029] New: CAS authentication fails in OPAC reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10029 Bug ID: 10029 Summary: CAS authentication fails in OPAC reserve Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: gmcha...@gmail.com Reporter: fridolyn.som...@biblibre.com CC: dpav...@rot13.org If OPAC reserve page is accessed without being logged-in, login form is displayed as well as a CAS authentication link (if enabled). A click on this link will lead to CAS server but one comming back to Koha, page shows an error : "ERROR: No biblionumber received". This is because CAS link only contains the query path "/cgi-bin/koha/opac-reserve.pl", not the query parameters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10028] ModReceiveOrder unexpectedly works
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10028 Jonathan Druart changed: What|Removed |Added Patch complexity|String patch|Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10028] ModReceiveOrder unexpectedly works
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10028 Jonathan Druart changed: What|Removed |Added Patch complexity|--- |String patch Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10028] ModReceiveOrder unexpectedly works
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10028 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10028] ModReceiveOrder unexpectedly works
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10028
--- Comment #1 from Jonathan Druart ---
Created attachment 17370
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17370&action=edit
Bug 10028: ModReceiveOrder unexpectedly works.
In C4::Acquisition::ModReceiveOrder, a call to NewOrder is badly used.
NewOrder returns ($basketno, $ordernumber) but in ModReceiveOrder the
ordernumber is got with
my $ordernumber = NewOrder( $args );
It works because:
sub t{
return ("a", "b");
}
my $a = t();
say $a;
Will display 'b'.
But it is not really clear.
Test plan:
Check that there is no regression for partial receives.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10028] New: ModReceiveOrder unexpectedly works
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10028 Bug ID: 10028 Summary: ModReceiveOrder unexpectedly works Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@biblibre.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #81 from Julian Maurice --- Created attachment 17369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17369&action=edit Bug 6874: Add dependency to Test::CGI::Multipart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #80 from Julian Maurice --- Created attachment 17368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17368&action=edit Bug 6874: Add unit tests for C4::UploadedFiles and move a variable declaration at subroutine level instead of file level. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9414] Fix sample letters for German and Norwegian
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9414 --- Comment #7 from Katrin Fischer --- Thx for letting me mess up your patch with German :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9414] Fix sample letters for German and Norwegian
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9414 --- Comment #6 from Magnus Enger --- (In reply to comment #5) > Assume that Katrin gave you the German translations.. Gah, forgot to mention that. Sorry, Katrin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9414] Fix sample letters for German and Norwegian
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9414 M. de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA CC||m.de.r...@rijksmuseum.nl QA Contact||m.de.r...@rijksmuseum.nl --- Comment #5 from M. de Rooy --- QA Comment: Not much to say. Looks good to me. Speak little bit German, and no Norwegian.. Ran this on a empty db. Went fine. Assume that Katrin gave you the German translations.. Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9414] Fix sample letters for German and Norwegian
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9414 M. de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9414] Fix sample letters for German and Norwegian
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9414 M. de Rooy changed: What|Removed |Added Attachment #17270|0 |1 is obsolete|| --- Comment #4 from M. de Rooy --- Created attachment 17367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17367&action=edit Bug 9414 - Fix sample letters for German and Norwegian Some letters were missing or not translated in the German and Norwegian data for the webinstaller. This patch adds them. German - RENEWAL (present, but not translated) - OPAC_REG_VERIFY (missing) Norwegian - RENEWAL (present, but not translated) - ISSUESLIP (missing) - ISSUEQSLIP (missing) - RESERVESLIP (missing) - TRANSFERSLIP (missing) - OPAC_REG_VERIFY (missing) To test: - Install Norwegian and German* translations - Run through the web installer in German, making sure that the sample letters are selected - Check that there are no errors in the web installer - Check /cgi-bin/koha/tools/letter.pl - that the letters look OK, and are translated - Repeat the process for Norwegian * = I had some problems with installing the German translations that are in master, but now I can't reproduce it. If you run into a problem where only some of the subdirectories of koha-tmpl/intranet-tmpl/prog/de-DE/modules/ are cerated, try downloading and installing the 3.10 .po files from Pootle. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9414] Fix sample letters for German and Norwegian
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9414 M. de Rooy changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9780] Deleting a record suppress bibliographic info in orders using that record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 M. de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #16 from M. de Rooy --- Applying: Bug 9780: Add unit test and a new condition in GetOrdersByBiblionumber /usr/share/koha/testclone/.git/rebase-apply/patch:56: trailing whitespace. ok( scalar (@listorders) >0,'GetOrdersByBiblionumber : result contains at least one element' ); fatal: sha1 information is lacking or useless (C4/Acquisition.pm). Repository lacks necessary blobs to fall back on 3-way merge. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 --- Comment #17 from M. de Rooy --- (In reply to comment #14) > Please wait: still found something else.. Replaced \D in the adjusted regex by a better [,;\s] Back to Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 --- Comment #16 from M. de Rooy --- Created attachment 17366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17366&action=edit Bug 8896 QA Followup for regex Making sure that the regex does not kill more than it should. Here are my test results when removing serialseq 3 :) 3 => 3 => 3; => 1;3 => 1 1; 3 => 1 1; 3; => 1 3;1 => 1 3; 1 => 1 3 ;1 => 1 3 ; 1 => 1 1;3;31 => 1;31 1;3 ;31 => 1;31 1;3; 31 => 1;31 1; 3;31;3A => 1;31;3A 2;3;31;; ;,, ;;,, ,;,;,;4 => 2;31;4 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 --- Comment #15 from M. de Rooy --- Created attachment 17365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17365&action=edit Bug 8896: Delete serials no more missing from missinglist When manual history is disabled in subscription history section if a serial has been previously set as missing and is received or set as expected, late or claimed, it will be deleted from missinglist Signed-off-by: Marcel de Rooy Regex needs a followup. More comments on Bugzilla. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy changed: What|Removed |Added Attachment #17363|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy changed: What|Removed |Added Attachment #17364|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #14 from M. de Rooy --- Please wait: still found something else.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #13 from M. de Rooy --- QA Comment: Thanks for adjusting. I unfortunately still had some issues: 1) Your regex removes $serialseq from the missing list. Say that it is 1. This will remove also all other ;1\d+ from the list like 10 or 11 etc. I had some fun with regexes and sent a QA followup for them. 2) Could you send a followup for marking Not available and back? Please test. Had some funny effects with it: Like Missing issues:5; not issued 5 Delete 5 now: 5 is removed from missinglist, but "; not issued 5" remains there. Point 2 does not block this patch however. No problems with qa tools. Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy changed: What|Removed |Added Attachment #17362|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 --- Comment #12 from M. de Rooy --- Created attachment 17364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17364&action=edit Bug 8896 QA Followup for regex Making sure that the regex does not kill more than it should. Here are my test results when removing serialseq 3 :) 3 => 3 => 3; => 1;3 => 1 1; 3 => 1 1; 3; => 1 3;1 => 1 3; 1 => 1 3 ;1 => 1 3 ; 1 => 1 1;3;31 => 1;31 1;3 ;31 => 1;31 1;3; 31 => 1;31 1; 3;31 => 1;31 2;3;31;; ;,, ;;,, ,;,;,;4 => 2;31;4 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 --- Comment #11 from M. de Rooy --- Created attachment 17363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17363&action=edit Bug 8896: Delete serials no more missing from missinglist When manual history is disabled in subscription history section if a serial has been previously set as missing and is received or set as expected, late or claimed, it will be deleted from missinglist Signed-off-by: Marcel de Rooy Regex needs a followup. More comments on Bugzilla. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy changed: What|Removed |Added Attachment #17275|0 |1 is obsolete|| --- Comment #10 from M. de Rooy --- Created attachment 17362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17362&action=edit Bug 8896 QA Followup for regex Making sure that the regex does not kill more than it should. Here are my test results when removing serialseq 3 :) 3 => 3 => 3; => 1;3 => 1 1; 3 => 1 1; 3; => 1 3;1 => 1 3; 1 => 1 3 ;1 => 1 3 ; 1 => 1 1;3;31 => 1;31 1;3 ;31 => 1;31 1;3; 31 => 1;31 1; 3;31 => 1;31 2;3;31;; ;,, ;;,, ,;,;,;4 => 2;31;4 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 --- Comment #9 from M. de Rooy --- QA: Working on this now.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7295] list of librarian managing a basket
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #33 from Julian Maurice --- This last patch should fix problems raised by Katrin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7295] list of librarian managing a basket
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice changed: What|Removed |Added Attachment #17358|0 |1 is obsolete|| --- Comment #32 from Julian Maurice --- Created attachment 17361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17361&action=edit Bug 7295 [follow-up] More granular permissions for baskets - updatedatabase.pl now fills the new aqbasket.branch with branchcode of basket owner (aqbasket.authorisedby). So the behavior is unchanged if you have set your syspref AcqViewBaskets to 'branch' - If AcqViewBaskets='branch', prevent librarian to add users that are not from the same branch than the basket. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7295] list of librarian managing a basket
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice changed: What|Removed |Added Attachment #16498|0 |1 is obsolete|| --- Comment #31 from Julian Maurice --- Created attachment 17360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17360&action=edit [SIGNED-OFF] Bug 7295: Follow-up: Several fixes Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7295] list of librarian managing a basket
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice changed: What|Removed |Added Attachment #16497|0 |1 is obsolete|| --- Comment #30 from Julian Maurice --- Created attachment 17359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17359&action=edit [SIGNED-OFF] Bug 7295: More granular permissions for baskets Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7295] list of librarian managing a basket
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 --- Comment #29 from Julian Maurice --- Created attachment 17358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17358&action=edit Bug 7295 [follow-up] More granular permissions for baskets - updatedatabase.pl now fills the new aqbasket.branch with branchcode of basket owner (aqbasket.authorisedby). So the behavior is unchanged if you have set your syspref AcqViewBaskets to 'branch' - If AcqViewBaskets='branch', prevent librarian to add users that are not from the same branch than the basket. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #33 from Fridolyn SOMERS --- I noticed that some changes in opac-user.pl seems to be not directly related to this bug purpose. Some lines concerns OPACDisplayRequestPriority and NotifyBorrowerDeparture syspref behaviors. Could this be explained is patch comment ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS changed: What|Removed |Added Attachment #16072|0 |1 is obsolete|| --- Comment #32 from Fridolyn SOMERS --- Created attachment 17357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17357&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup Rebased patch. Also made a change : Calling $query->param() into $template->param() is a bad idea, because $query->param() result type depends on context (normal or array contexts) and $template->param() is an array context. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS changed: What|Removed |Added Attachment #16071|0 |1 is obsolete|| Status|Patch doesn't apply |Needs Signoff Assignee|k...@bywatersolutions.com |fridolyn.som...@biblibre.co ||m --- Comment #31 from Fridolyn SOMERS --- Created attachment 17356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17356&action=edit Bug 6739 - expired patrons not blocked from opac actions (revised) Revised main patch to rebase master and also remove all changes only related to code format (white-spaces, new lines, folding ...). There where a lot ; such changes must not be in main patch because it makes the rebase much more difficult. Can you re-signoff Kyle ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9075] Show material type and item type on staff detail (with xslt)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 M. de Rooy changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
