[Koha-bugs] [Bug 10283] Hide many items on second tab when using OpacSeparateHoldings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10283] Hide many items on second tab when using OpacSeparateHoldings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18246 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18246action=edit Bug 10283: Hide many items on second tab when using OpacSeparateHoldings If there are over 50 items in the holdings or Other holdings tab, the warning and link 'This record has many physical items. Click here to view them all.' is only shown for the first tab. Test plan: - Switch on the OpacSeparateHoldings pref. - Go on a biblio detail page at the OPAC with more than 50 items - Check that the 'view all' link appears on the second tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10283] Hide many items on second tab when using OpacSeparateHoldings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Patch complexity|--- |Trivial patch Assignee|oleon...@myacpl.org |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9833] New virtual shelves/lists permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833
M. de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Status|Signed Off |Failed QA
Summary|New shelves permissions |New virtual shelves/lists
||permissions
QA Contact||m.de.r...@rijksmuseum.nl
--- Comment #6 from M. de Rooy m.de.r...@rijksmuseum.nl ---
I like this patch since we really need some permissions for shelves!!
But I think that we must not add manage shelves under editcatalogue.
Managing shelves should have its own permission (if we allow it in the first
place). If this patch adds an entry for shelves/lists, I would also have the
idea of adding/allowing Change ownership for instance. Note also the privacy
issue here as noted in related reports (should a staff user be able to view
these lists at all?).
So, you could remove manage_shelves from this patch or add a root entry like
lists and start a discussion on how we should view the underlying manage. What
we do need e.g. is a permission to manage shelves that do no longer have an
owner (after deleting user).
Merge from shelves is another story: this indeed fits better under
edit_catalogue.
A technical detail: To know member-userid you use GetMemberDetails: Isn't that
quite overkill?
Also please watch operator priority in $user $shelf-{owner}==$user) ||
C4::Auth::haspermission... Place parentheses?
A test plan should be added too.
Thanks for your attention.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5763] Add users private list management functionality for administrators
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5763 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Version|3.4 |master See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9833 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9833] New virtual shelves/lists permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=5763 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9833] New virtual shelves/lists permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #16360|0 |1 is obsolete|| --- Comment #7 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18247 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18247action=edit Bug 9833: Refine shelves permissions. - This patch adds two new permissions for shelves: - manage_shelves: allows to manage shelves - merge_from_shelves: allows to merge records from shelves Signed-off-by: Pierre Angot tredok.pie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #18209|0 |1 is obsolete|| --- Comment #4 from Owen Leonard oleon...@myacpl.org --- Created attachment 18248 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18248action=edit Bug 10261 [Revised] Link to patron files missing from circ-menu.tt The link to patron files doesn't appear on some pages. That's because the link was added to circ-menu.inc but not circ-menu.tt. Each is used by different patron-related pages. This patch adds the missing link. To test, enable the EnableBorrowerFiles system preference and view members/pay.pl or members.paycollect.pl. The Files tab should appear in the left-hand sidebar menu. Other patron pages should show the same. Edit: Corrected scope of template variables which shouldn't have been copied directly from circ-menu.inc without changing scope. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7718] Remove itemnumber column from serials table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #18248|0 |1 is obsolete|| --- Comment #5 from Nicole C. Engard neng...@gmail.com --- Created attachment 18249 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18249action=edit [SIGNED-OFF]Bug 10261 [Revised] Link to patron files missing from circ-menu.tt The link to patron files doesn't appear on some pages. That's because the link was added to circ-menu.inc but not circ-menu.tt. Each is used by different patron-related pages. This patch adds the missing link. To test, enable the EnableBorrowerFiles system preference and view members/pay.pl or members.paycollect.pl. The Files tab should appear in the left-hand sidebar menu. Other patron pages should show the same. Edit: Corrected scope of template variables which shouldn't have been copied directly from circ-menu.inc without changing scope. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com all tests pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10163] batch-mod items tool fails on files over 1000 lines long
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added CC||colin.campbell@ptfs-europe. ||com --- Comment #2 from Colin Campbell colin.campb...@ptfs-europe.com --- Just confirmed with a customer that this seems to have been caused by the changes introduced under bug 5521 caused the problem - reverting that change got this working again ( but reintroduced the 5521 bug) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] New: UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Bug ID: 10289 Summary: UT: Reserves.t needs to create its own data Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: gmcha...@gmail.com Reporter: jonathan.dru...@biblibre.com t/db_dependent/Reserves.t depends on the Jenkins database. We should create the data we want and delete them at the end. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||10273 Depends on|10273 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks|10274, 10275| Depends on||10274, 10275 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10275] UT: OrderFromSubscription.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10275 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||10273 Depends on|10273 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED Blocks||10273 Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Depends on||10289 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18250 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18250action=edit Bug 10289: UT: Reserves.t needs to create its own data Try before the patch: prove t/db_dependent/Reserves.t And after, it should produce: t/db_dependent/Reserves.t .. 1/4 # # Creating biblio instance for testing. # Creating item instance for testing. # Deleting item testing instance. # Deleting biblio testing instance. # Deleting borrower. t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=4, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18197|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18251 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18251action=edit Bug 10274: UT: Acquisition.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition.t And after, it should produce: t/db_dependent/Acquisition.t .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.03 usr 0.00 sys + 0.42 cusr 0.02 csys = 0.47 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10275] UT: OrderFromSubscription.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10275 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18201|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18252 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18252action=edit Bug 10275: UT: OrderFromSubscription.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition/OrderFromSubscription.t And after, it should produce: t/db_dependent/Acquisition/OrderFromSubscription.t .. ok All tests successful. Files=1, Tests=12, 2 wallclock secs ( 0.02 usr 0.00 sys + 0.46 cusr 0.02 csys = 0.50 CPU) Result: PASS And some warnings... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #5 from Nicole C. Engard neng...@gmail.com --- (In reply to comment #0) typo in help/reports/guided_reports.tt : CreditXXX should be credit/li M. Saby Actually it's right - it's going to say Credit and then the XX is the value after it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #6 from Nicole C. Engard neng...@gmail.com --- (In reply to comment #2) in the same file, probably an other typo, but I am not sure : 6 = Delete should be 6 = Deleted Nope, that's the value that's stored in the DB. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10290] New: UT: VirtualShelves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 Bug ID: 10290 Summary: UT: VirtualShelves.t needs to create its own data Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: gmcha...@gmail.com Reporter: jonathan.dru...@biblibre.com t/db_dependent/VirtualShelves.t depends on the Jenkins database. We should create the data we want and delete them at the end. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED Blocks||10273 Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Depends on||10290 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10186] Typo in subscription-add.tt (years vs year)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10186 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #6 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10191] 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #4 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18253 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18253action=edit MT10290: UT: VirtualShelves.t needs to create its own data Try before the patch: prove t/db_dependent/VirtualShelves.t And after, it should produce: t/db_dependent/VirtualShelves.t .. ok All tests successful. Files=1, Tests=82, 6 wallclock secs ( 0.03 usr 0.00 sys + 0.46 cusr 0.03 csys = 0.52 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #7 from Nicole C. Engard neng...@gmail.com --- Created attachment 18254 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18254action=edit Bug 10250: Fix typos in guided reports help file This is a string patch that fixes typos in the guided reports help file. To test: * Go to the guided reports page * Click help * Confirm text is right -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #9 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Bernardo! The typo fixes aside, because of the April 2013 updates to the 006 for music, this patch should be backported to stable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10251] typos in help/members/member-flags.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10251 --- Comment #1 from Nicole C. Engard neng...@gmail.com --- Created attachment 18255 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18255action=edit Bug 10251: Fix typos in Patron Permissions Help This is a string patch that fixes the typos in the patron permission help file. To test: * go to a patron record * click 'set permissions' under more * click 'help' * confirm that text is right -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10251] typos in help/members/member-flags.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10251 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #5 from M. de Rooy m.de.r...@rijksmuseum.nl --- Changing status to reflect need for clarification. Why C4::Koha? Are there specific functions in that module you recommend to use? If so, maybe add this in the pod lines? Typo replated. Use Template::Plugin not needed? Use base seems enough. Leaving the name as-is.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10163] batch-mod items tool fails on files over 1000 lines long
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |colin.campbell@ptfs-europe. ||com --- Comment #3 from Colin Campbell colin.campb...@ptfs-europe.com --- Created attachment 18256 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18256action=edit proposed patch This patch corrects the logic while preserving the test from bug 5521 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6399] tooltip for tags that says 'separate by comma'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #5 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Owen! I agree with Katrin's comment that we should consider adjusting the text at the other three places where a tag can be added. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 --- Comment #6 from Galen Charlton gmcha...@gmail.com --- Created attachment 18257 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18257action=edit bug 10170: expose more managed staged MARC strings to translation This commit makes it possible to translated the 'staged' and 'error' record statuses as well as the 'auto_match' overlay status. Also takes out a bit of HTML cruft in one string that is not needed for translation. Signed-off-by: Galen Charlton g...@esilibrary.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #7 from Galen Charlton gmcha...@gmail.com --- Adrien's patch is fine as far as it goes, but I've attached a follow-up that addresses Marcel's observation about the 'auto_match' overlay status and 'staged' and 'error' record status -- for simple stuff like this, I prefer to push a patch or a patch series that completely addresses the problem. I've intentionally not supplied anything for the 'manual_match' and 'items_reverted' statuses, as there's at present no code that will set them. Hopefully this can be fixed in time for 3.14. For the record, the intention was that 'manual_match' would signify that a user had performed a search and manually identified a matching bib record, while 'items_reverted' would signify an operation that would remove items added during a previous commit without reverting the bib record as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #12654|0 |1 is obsolete|| Attachment #13050|0 |1 is obsolete|| Attachment #13089|0 |1 is obsolete|| --- Comment #29 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 18258 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18258action=edit Bug 8773 - Start per-instance koha-index-daemon in .deb setup Short: Launch a koha-index-daemon (from Koha::Contrib::tamil) process for each enabled instance. Enabling/disabling the use of the indexer is handled using a new(ly introduced) /etc/default/koha-common config file that can be used for other stuff too, and is the Debian way of handling init scripts control variables[1]. Long: Using an indexing daemon avoids launching a new interpreter each time the cron triggers the indexing, and also allows sub-minute incremental reindexing, a requirement from our librarians.[2] Using the indexer daemon should remain experimental so is disabled by default. To enable the use of the indexer the user has to tweak the /etc/default/koha-common config file (introduced by this patch). Specifically the USE_INDEXER_DAEMON variable, which is clearly explained in the file. Update frecquency defaults to 30 sec, and can be changed by tweaking the /etc/default/koha-common config file too. This patch relies on Koha::Contrib::Tamil's koha-index-daemon script [3], but could be easily adjusted to use another if we got a new one (SolR?). As Robin proposed it check for availability of the relevant files before trying to spawn the daemon. If there's something I could change to make this patches better just let me know. Note: there was a problem Robin found regarding the spawned processes forgetting the PERL5LIB and/or KOHA_CONF env variables, this is fixed in this version with the inclusion of the 'export' keyword for the relevant variables. Regards To+ [1] Section 9.3.2 of http://www.debian.org/doc/debian-policy/ch-opersys.html [2] This is the .deb version of http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519 [3] The default cronjob that is set using the debian/koha-common.cron.d file is being disbaled by this patch to avoid collision. Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Component|Command-line Utilities |Packaging Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored Assignee|tomasco...@gmail.com|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 --- Comment #30 from Tomás Cohen Arazi tomasco...@gmail.com --- Forgot to mention that lavamind helped me with his ideas and testing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10291] New: Misleading Variable names in batchMod.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10291 Bug ID: 10291 Summary: Misleading Variable names in batchMod.pl Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: colin.campb...@ptfs-europe.com batchMod,pl has two variables with names of the form x_hashref but both are actually references to an array of hashrefs. It passes the contents of one to the templares under the name itemnumbers_hashref but the use of it belies that name. For the sake of future maintainers lets clean up these names -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10291] Misleading Variable names in batchMod.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10291 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |colin.campbell@ptfs-europe. ||com --- Comment #1 from Colin Campbell colin.campb...@ptfs-europe.com --- Created attachment 18259 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18259action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9508] the dateformat variable is not standardized in template files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9508 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #14 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Paul and Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #0) The owner can 'unshare' the list and remove all shares for that list. I am having second thoughts about this part of the functionality. I would rather opt now for copy and delete without unsharing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #2 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18260 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18260action=edit Bug 9032: Share a list: OPAC foundation Adds a Share button for OPAC private lists Adds template and script for further development Test plan: Toggle the pref OpacAllowSharingPrivateList. If enabled, you should see the Share button in OPAC/Private lists. Click on the Share button. You should get Share a list. Logout and try to go back to opac/opac-shareshelf.pl It should now present you the login form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Depends on||10206 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Blocks||9032 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9032] Share a list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl --- Please wait for some more patches :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Patch complexity|Small patch |Medium patch Severity|critical|normal --- Comment #11 from Galen Charlton gmcha...@gmail.com --- (In reply to comment #10) (In reply to comment #9) This looks good to me, but I am bumping it to 3.14 because I am concerned about the number of files it changes. hmm, i might bump the severity to 'critical', so this bug gets noticed more... i hope no-one objects to this? I do. From http://wiki.koha-community.org/wiki/Bug_Reporting_Guidelines#Severity, the critical severity is defined as Koha or component crashes and/or there is a potential loss of data. While this definition is a guideline, not an absolute rule, this bug simply does not qualify as a critical bug by that definition. If you want to call attention to a bug, please do so by (for example) discussing it on the IRC channel or koha-devel. Setting the severity of a bug higher than necessary would be a bad habit for us to get into, as it reduces the utility of that BZ field. Consequently, I am setting the severity back to normal. This should not be construed as a statement that I am not going to review the patch; I will, in due course. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10292] New: XSLT files always taken from 'prog' theme for English
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10292 Bug ID: 10292 Summary: XSLT files always taken from 'prog' theme for English Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: gmcha...@gmail.com The commit for bug 8947 has the side-effect of (when the language is English) causing the theme syspref to be ignored when looking for an XSLT stylesheet for bib details or search result display. To reproduce the bug: [1] Make sure OPAC XSLT details is turned on and that English is the OPAC language. [2] Create a new OPAC theme, including copying the XSLT files. [3] Set opactheme to the new theme. [4] Make a change to koha-tmpl/opac-tmpl/NEWTHEME/en/xslt/MARC21slim2OPACDetail.xsl [5] View a bib record in the OPAC. The change made in the previous step is not reflected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8884] opacheader is not in the header on CCSR
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8884] opacheader is not in the header on CCSR
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 --- Comment #5 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 18261 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18261action=edit Bug 8884: opacheader is not in the header on CCSR In CCSR the opacheader preference isn't really in the header it's to the right of the search box (see attached). I'm okay with a customizable region over there, but we should have a new preference for that and header should be above the search box as it implies. To test: 1) Put something in the OpacHeader syspref. Preferably something large and header-like for maximum effect. 2) Select CCSR theme. 3) View OPAC. Notice placement of header content. 4) Apply patch. 5) View OPAC. Notice placement of header content. 6) Sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #8 from mathieu saby mathieu.s...@univ-rennes2.fr --- Not sure CreditXXX is right : - HTML closing Tag /li missing - I don't know how to translate CreditXXX in french Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8884] opacheader is not in the header on CCSR
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 --- Comment #6 from Ed Veal ed.v...@bywatersolutions.com --- Jared, I am going to test this but would like to make a suggestion. There are a few sites I am already working with and will be using the opacheader to place a library logo to the right of the search bar as it is functioning now. So if this passes QA and gets patched it will affect these sites. Might we be able to add a new system preference to work like the opacheader is working now on CCSR to accomodate this desired look? Just a thought. Ed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10292] XSLT files always taken from 'prog' theme for English
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10292 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10292] XSLT files always taken from 'prog' theme for English
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10292 --- Comment #1 from Galen Charlton gmcha...@gmail.com --- Created attachment 18262 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18262action=edit bug 10292: improve fallback logic for picking XSLT This patch fixes a bug whereby XSLT files from the prog theme would be used (for English OPACs and staff interfaces) even if the user had created and enabled a custom theme that provided override XSLT files. This patch provides a clearer implementation of the fallback logic and adds test cases. To reproduce the bug: [1] Set OPACXSLTDetailsDisplay to 'default' and English as the OPAC language. [2] Create a new OPAC theme, including copying the XSLT files. [3] Set opactheme to the new theme. [4] Make a change to koha-tmpl/opac-tmpl/NEWTHEME/en/xslt/MARC21slim2OPACDetail.xsl [5] View a bib record in the OPAC. The change made in the previous step is not reflected. To test after applying the patch: [6] Reload the bib record in the OPAC. The change made in step 4 should now be reflected. [7] (To be thorough) Go through the test plan for bug 8947 and verify that there is no regression. Signed-off-by: Galen Charlton g...@esilibrary.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Depends on||10292 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10292] XSLT files always taken from 'prog' theme for English
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10292 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Blocks||2774 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 --- Comment #12 from Galen Charlton gmcha...@gmail.com --- I've added bug 10292 as a dependency -- not so much because it is directly related to the patch that was submitted, but because it touches on the specific issue that was originally reported by Doug Dearden. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10186] Typo in subscription-add.tt (years vs year)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10186 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 --- Comment #13 from Galen Charlton gmcha...@gmail.com --- I've pushed Owen's patch to master. Thanks, Owen! I'm also setting this back to In Discussion, as there are some places that still make hard-coded references to prog. Here is a list of potential candidates for replacing references: ./C4/Record.pm ./C4/Templates.pm ./C4/Koha.pm ./C4/Items.pm ./C4/XSLT.pm ./misc/translator/translate ./misc/translator/LangInstaller.pm ./installer/InstallAuth.pm ./admin/systempreferences.pl ./koha-tmpl/intranet-tmpl/prog/en/includes/error-messages.inc ./koha-tmpl/intranet-tmpl/prog/en/includes/installer-doc-head-close.inc ./koha-tmpl/intranet-tmpl/prog/en/css/blue.css ./koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css ./koha-tmpl/intranet-tmpl/prog/en/css/mainpage.css ./koha-tmpl/intranet-tmpl/prog/en/js/ajax.js ./koha-tmpl/intranet-tmpl/prog/en/modules/help/labels/spinelabel-home.tt ./koha-tmpl/intranet-tmpl/prog/en/modules/help/mainpage.tt ./koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt ./koha-tmpl/intranet-tmpl/prog/en/modules/installer/step2.tt ./koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt ./koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt ./koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt ./koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl ./koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl ./koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetDetail.xsl ./koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARC_compact.xsl ./koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xsl ./koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl ./koha-tmpl/opac-tmpl/prog/en/xslt/NORMARCslim2OPACDetail.xsl ./koha-tmpl/opac-tmpl/gmc/en/xslt/NORMARCslim2OPACDetail.xsl ./koha-tmpl/opac-tmpl/gmc/en/xslt/MARC21slim2OPACDetail.xsl ./opac/unapi ./opac/opac-showmarc.pl ./opac/oai.pl ./catalogue/cardview.pl ./cataloguing/value_builder/marc21_field_008.pl ./cataloguing/value_builder/marc21_field_006.pl ./cataloguing/addbiblio.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Attachment #17611|0 |1 is obsolete|| --- Comment #14 from Galen Charlton gmcha...@gmail.com --- Comment on attachment 17611 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17611 Bug 2774 - Path to theme is hard-coded in many places Marking patch attachment obsolete now that it's been pushed to master, because bug should remain open for additional followup. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10083] In Transit string doesn't get translated in the staff interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Pushed to Master|ASSIGNED Version|master |3.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10083] In Transit string doesn't get translated in the staff interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Pushed to Master|ASSIGNED Version|master |3.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10293] New: Bug 9930 needs to be reverted for 3.10.x
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293 Bug ID: 10293 Summary: Bug 9930 needs to be reverted for 3.10.x Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: kyle.m.h...@gmail.com The patch for bug 9930 needs to be reverted for 3.10.x, as the patron self registration feature is not part of 3.10.x. With the patch applied, the OPAC patron details link redirects to a non-existent page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10293] Bug 9930 needs to be reverted for 3.10.x
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9930 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9930] can't update patron info in ccsr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9930 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10293 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8884] opacheader is not in the header on CCSR
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 --- Comment #7 from Owen Leonard oleon...@myacpl.org --- (In reply to comment #6) There are a few sites I am already working with and will be using the opacheader to place a library logo to the right of the search bar as it is functioning now. Is that because that's where they really want it, or because that's where they can put it? I would certainly prefer to fix the placement of opacheader and have any library customizations be corrected later. There will be plenty of notice before any such change arrives on customers' installations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7067] allow patron self registration via the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10293 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10293] Bug 9930 needs to be reverted for 3.10.x
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=7067 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8884] opacheader is not in the header on CCSR
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 --- Comment #8 from Ed Veal ed.v...@bywatersolutions.com --- Owen, Yes, I agree and that is what I was trying to say. I would like to opacheader work as it should and then add a new preference or just figure out a way to move the logos there. I was just bouncing around the idea. Ed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10293] Bug 9930 needs to be reverted for 3.10.x
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18263 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18263action=edit Bug 10293 - Bug 9930 needs to be reverted for 3.10.x The patch for bug 9930 needs to be reverted for 3.10.x, as the patron self registration feature is not part of 3.10.x. With the patch applied, the OPAC patron details link may redirect to a non-existent page ( opac-memberentry.pl ). This reverts commit e5186d6d784c1fdd8d12c6e93e163d0b9e10cc0e. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10293] Bug 9930 needs to be reverted for 3.10.x
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10293] Bug 9930 needs to be reverted for 3.10.x
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18263|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18264 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18264action=edit Bug 10293 - Bug 9930 needs to be reverted for 3.10.x The patch for bug 9930 needs to be reverted for 3.10.x, as the patron self registration feature is not part of 3.10.x. With the patch applied, the OPAC patron details link may redirect to a non-existent page ( opac-memberentry.pl ). Test Plan: 1) Set OPAC to use CCSR theme. 2) Log into the OPAC. 3) Click the link for your username. 4) Click the my personal details tab. 5) Note the error page you get 6) Apply this patch 7) Refresh the page 8) You should now see the user details update page This reverts commit e5186d6d784c1fdd8d12c6e93e163d0b9e10cc0e. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10293] Bug 9930 needs to be reverted for 3.10.x
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |kyle.m.h...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10251] typos in help/members/member-flags.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10251 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10251] typos in help/members/member-flags.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10251 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10251] typos in help/members/member-flags.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10251 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #2 from Galen Charlton gmcha...@gmail.com --- Trivial and visibly correct string patch; pushing directly to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10251] typos in help/members/member-flags.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10251 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10288] Tiny typo on Pending offline circulation actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10288 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10288] Tiny typo on Pending offline circulation actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10288 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10288] Tiny typo on Pending offline circulation actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10288 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #2 from Galen Charlton gmcha...@gmail.com --- Trivial string patch; pushed directly to master. Thanks, Magnus! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10277] Add C4::Context-IsSuperLibrarian()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||gmcha...@gmail.com --- Comment #2 from Galen Charlton gmcha...@gmail.com --- I agree with the notion that the method for checking whether a session has superlibrarian privileges should be more clear. The patch is problematic, however: - I'm pretty sure terminating (via confess) is not the right thing to do if the userenv isn't set up yet; in particular, this has the potential to break command-line scripts for no good reason. - Doing it via confess() without loading the Carp module is wrong regardless. - A patch that introduces a new C4::Context method but never uses it is untestable. It should, at the very least, attempt to replace some of the opaque userenv flags tests, and ideally should aim to replace them all. In other words, if we're going to refactor this, let's refactor this all the way. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688 --- Comment #12 from Galen Charlton gmcha...@gmail.com --- I think a feature to add support for recalls needs more fleshing out before being committed to master, since most other implementations I know of have additional components. The most important one is doing something to keep track of to whom the recalled item should be given. Other ILSs do this by treating a recall as a special kind of hold request. Note that if the feature were to allow patrons to place recall requests directly, that is something that is typically not offered to all patron categories -- for example, in an academic library, often it's only professors and maybe grad students who are allowed to recall books. Secondarily, I feel that there should be a related permission on whether a staff member is allowed to place recalls in the first place. Next, consideration should be given to whether recalls are allowed to shorten the loan period for the originally borrower. In addition, I know that some libraries impose higher fines if a recalled items is not returned promptly enough. Tying recalls into the holds system (or perhaps creating a separate class of recall request) should be considered a sine qua non, in my opinion. I have doubts that a feature that simply sends recall notices at (staff) will is going to be sufficient. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10294] New: when the word user is included in default in framework, surname of login creating record inserted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10294 Bug ID: 10294 Summary: when the word user is included in default in framework, surname of login creating record inserted Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: dr...@bywatersolutions.com CC: m.de.r...@rijksmuseum.nl When the word user is included in a default value in a MARC subfield structure of a tag in a framework, the surname of he user login creating record is inserted in the place of the word user. Create the deafualt value in the framework -In MARC frameworks. -Select a MARC structure of any framework to edit. -Select the subfields to edit. -Select the Edit Subfields button. -Select Display more constraints of any subfield tab. -Include user in the default value. (make sure hidden is st to 0). -Save Changes. Create a new record -In Cataloging, select New Record with the edited framework -Go to the tag with the default value. -The surname of the user with which you create the new record will be in the tag in the place of user. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #9 from Nicole C. Engard neng...@gmail.com --- The closing li is after the /ul as it should be. And the way the data is stored is Credit and then a code - all one word with no spaces. How would be a better way to denote this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #10 from mathieu saby mathieu.s...@univ-rennes2.fr --- Oh, I looked to quickly. I did not understand the structure of the code. Of course you are right! We'll find a way to translate CreditXXX (I translated in french as Credit /li - SHAME ON ME!) Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #34 from Galen Charlton gmcha...@gmail.com --- (In reply to comment #33) This brings me to a more important question: Should we encourage Koha users to allow login for apache user to make use of the Task Scheduler? Note that is a general Apache hardening measure to not allow interactive login for the apache user. IMO we (as Koha developers) should not stimulate Koha users to lower security barriers to enable Koha functionality. I agree: we should not be asking users to grant special privileges to the user that Apache runs as, Another approach to the Task Scheduler could be to have a specific cronjob, look for Koha reports to run at specified times without allowing apache to add generic jobs with all security risks attached.. I think writing a cronjob (and abandoning Schedule::At) is the way to go. In particular, I suggest the following implementation: - create a database table to store a queue of reports to run (or maybe generalize it a bit and call it a job queue table) - the current report scheduling functionality would just add rows to the queue with a run start time set by the user - the cronjob would periodically check the queue and run any pending reports whose run start time has passed This would be pretty light-weight, but would allow us to get fancier in the future. For example, adding functionality to schedule reports to run periodically could be done by writing code to add entries into the job queue. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
