[Koha-bugs] [Bug 10411] Add cache control headers to static resources in the apache config

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10411] Add cache control headers to static resources in the apache config

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Assignee|koha-b...@lists.koha-commun |ro...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9549] Local Cover are not displayed in the Shelf Browser.

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9549

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9549] Local Cover are not displayed in the Shelf Browser.

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9549

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #16700|0   |1
is obsolete||

--- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 18654
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18654action=edit
Bug 9549 Fix localcovers not shown in shelves browser.

I had to add some css to align to center the span containing the images.

Add the ability to view local cover images in the shelf browser.

To test:
1. Add a local cover image to a record. Set OPACLocalCoverImages sys pref to
display.
2. Search for the record, go to the Details page, and click on Browse Shelf.
3. Verify that the local cover image appears in the shelf browser.

Sponsored-by: CCSR

Signed-off-by: Melia Meggs me...@bywatersolutions.com
Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9747] sort issue for the z3950 results

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9747] sort issue for the z3950 results

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #16461|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 18655
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18655action=edit
Bug 9747: Fix sorting issues on z3950 search results

At least the BNF server returns results containing non-sorting
characters (NSB SNE).
In order to sort results according these characters, this patch adds a
new Datatable function.

Test plan:
- search 'tintin' on the z3950 search (cataloguing/z3950_search.pl)
- sort on title (default sort) and check that results are not well
  sorted.
- apply this patch
- do the same search and check that the first result is Hergé. Les
  Aventures de Tintin...
  The value of the cell is:
  tdˆHergé. Les ‰Aventures de Tintin.../td

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332

--- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #9)
 When I do this kind of testing, I do it within a transaction, and rollback
 at the end. That way I do not need to think about a proper cleanup. Has
 there been any thoughts on that subject?

Yes we should look deeper into this way. The t/db_dependent/HoldsQueue.t
already use a roolback.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9747] sort issue for the z3950 results

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #18655|0   |1
is obsolete||

--- Comment #11 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 18656
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18656action=edit
Bug 9747: Fix sorting issues on z3950 search results

At least the BNF server returns results containing non-sorting
characters (NSB SNE).
In order to sort results according these characters, this patch adds a
new Datatable function.

Test plan:
- search 'tintin' on the z3950 search (cataloguing/z3950_search.pl)
- sort on title (default sort) and check that results are not well
  sorted.
- apply this patch
- do the same search and check that the first result is Hergé. Les
  Aventures de Tintin...
  The value of the cell is:
  tdˆHergé. Les ‰Aventures de Tintin.../td

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

Works as advertised and doesn't break existing searching

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9747] sort issue for the z3950 results

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9747] sort issue for the z3950 results

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #18656|0   |1
is obsolete||
 Status|Passed QA   |Needs Signoff
   Assignee|jonathan.dru...@biblibre.co |fridolyn.som...@biblibre.co
   |m   |m

--- Comment #12 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 18657
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18657action=edit
Bug 9747 - sort issue for the z3950 results

Rebased patch.
Datatable sorting is now very different, I really have rewritten this part.
I also applied this sort on acquisition page using z3950 search.

There are many changes so I set bug to Needs Signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9747] sort issue for the z3950 results

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747

--- Comment #13 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
You may test with Tolkien as author, you get :
The Lord of the rings, The Two towers, The Return of the king, ...

Note that NSB and NSE are not visible in MARC popup view, but if you copy/paste
the title in an advanced editor (like Geany), you will see them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #16272|0   |1
is obsolete||

--- Comment #7 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 18658
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18658action=edit
Bug 9576 - Enable or disable issue limit confirmation

Rebased master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #18250|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 18659
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18659action=edit
Bug 10289: UT: Reserves.t needs to create its own data

Try before the patch:
prove t/db_dependent/Reserves.t

And after, it should produce:
  t/db_dependent/Reserves.t .. 1/4 #
  # Creating biblio instance for testing.
  # Creating item instance for testing.
  # Deleting item testing instance.
  # Deleting biblio testing instance.
  # Deleting borrower.
  t/db_dependent/Reserves.t .. ok
  All tests successful.
  Files=1, Tests=4,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.39 cusr  0.02
csys =  0.44 CPU)
  Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
Jared, thank you for testing.

I confirm the tests pass here :-/
Could you retry with the last patch please? It replaces ok with is. We should
have a more readable failure.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #18659|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 18660
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18660action=edit
Bug 10289: UT: Reserves.t needs to create its own data

Try before the patch:
prove t/db_dependent/Reserves.t

And after, it should produce:
  t/db_dependent/Reserves.t .. 1/4 #
  # Creating biblio instance for testing.
  # Creating item instance for testing.
  # Deleting item testing instance.
  # Deleting biblio testing instance.
  # Deleting borrower.
  t/db_dependent/Reserves.t .. ok
  All tests successful.
  Files=1, Tests=4,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.39 cusr  0.02
csys =  0.44 CPU)
  Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #18251|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 18661
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18661action=edit
Bug 10274: UT: Acquisition.t needs to create its own data

Try before the patch:
prove t/db_dependent/Acquisition.t

And after, it should produce:
  t/db_dependent/Acquisition.t .. ok
  All tests successful.
  Files=1, Tests=41,  2 wallclock secs ( 0.03 usr  0.00 sys +  0.42 cusr
  0.02 csys =  0.47 CPU)
  Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #3)
 I am not sure this one is right. It looks like the DelOrder calls are
 hardcoded to expect the bib records to have biblionumbers 1-3, which doesn't
 make sense to me. Should it perhaps be DelOrder($biblionumber1,
 $ordernumber1) ... etc.?

Yes, of course! I will provide a new patch. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10015] UniqueItemFields could have link to database documentation

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10015

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10015] UniqueItemFields could have link to database documentation

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10015

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #17347|0   |1
is obsolete||

--- Comment #4 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 18662
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18662action=edit
Bug 10015 - UniqueItemFields could have link to database documentation

Other system preferences which require entry of database column names
include a link to the scheme for reference. The UniqueItemFields should
do the same. This patch rewords the preference description to
incorporate a link.

To test, open the acquisitions tab in system preferences and confirm
that the UniqueItemFields description looks correct and links to the
right page in the schema.

Signed-off-by: Frederic Durand frederic.dur...@unilim.fr
Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8584] Improve cleanup_database.pl to only purge emails older than X days.

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8584

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8584] Improve cleanup_database.pl to only purge emails older than X days.

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8584

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #17396|0   |1
is obsolete||

--- Comment #4 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 18663
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18663action=edit
cleanup_database.pl : Add a DAYS parameter for email purges.

You can now specify a number of DAYS with the --mail parameter. Only
mails older than DAYS days will be deleted.

http://bugs.koha-community.org/show_bug.cgi?id=8584
Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #18550|0   |1
is obsolete||

--- Comment #6 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 18664
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18664action=edit
Bug 766 Remove CGI::scrolling_list from request.pl

Let the template take care of generating the display.
Lets at least part of request.pl be more succinct.

To test, place a hold and search for the patron using a partial name.
You should get a dropdown select list of patrons and be able to select
the patron to hold for from there.

The functionality should remain unimpaired after this patch is applied.

Signed-off-by: Owen Leonard oleon...@myacpl.org
Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10412] New: The ability to update Acquisitions with credit notes, with the option to link to an existing invoice

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412

Bug ID: 10412
   Summary: The ability to update Acquisitions with credit notes,
with the option to link to an existing invoice
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: amitddng...@gmail.com

The ability to update Acquisitions with credit notes, with the option to link
to an existing invoice

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10412] The ability to update Acquisitions with credit notes, with the option to link to an existing invoice

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412

Amit amitddng...@gmail.com changed:

   What|Removed |Added

 CC||colin.campbell@ptfs-europe.
   ||com
   Assignee|koha-b...@lists.koha-commun |amitddng...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10249] Untranslatable strings in Javascript on OPAC detail page

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10249] Untranslatable strings in Javascript on OPAC detail page

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #18646|0   |1
is obsolete||

--- Comment #4 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 18665
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18665action=edit
Bug 10249: Fix untranslatable strings in OPAC detail page

Star ratings feature:
- Your CGI session cookie is not current. Please refresh
  the page and try again.
- average rating:
- your rating:

Browse results feature:
- Click to rewind the list to
- See biblio
- with biblionumber
- by (between title and author)
- Click to forward the list to
- Go to detail

To test:
- Update the po file using 'perl translate update langcode'
- Translate all new strings, maybe mark them with XX to make it easier
  to find them
- Install the updated translation file using 'perl translate install
  langcode'
- Test the ratings and browse results features in the OPAC detail page
- Verify everything is still working/displaying like it should
- Check that you don't find any unstranslated strings/terms

Some hints where the changes are:
- Change an existing rating - the average and your rating will change
- Browse result list and check mouse over tooltips for all links

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com
Strings are now translated, and no emergent JS errors have revealed
themselves.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10413] New: French staff po file is not translatable

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10413

Bug ID: 10413
   Summary: French staff po file is not translatable
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: 3.12
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: translate.koha-community.org
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@biblibre.com
CC: frede...@tamil.fr

In 3.12 and master, I get an error on translate update fr-FR.

It is caused by

/misc/translator/po/fr-FR-i-staff-t-prog-v-3006000.po l.103798 (in 3.12):
#: intranet-tmpl/prog/en/modules/help/members/moremember.tt:18
#, c-format
msgid 
 
msgstr 
 

The error is (in french of course...):
AVERTISSEMENT : Il manque le jeu de caractères dans l'en-tête.
La conversion vers le jeu de caractères de l'utilisateur ne fonctionnera pas.
fr-FR-i-staff-t-prog-v-3006000.po:103800: Double définition de message...
fr-FR-i-staff-t-prog-v-3006000.po:21: ...voici l'endroit de la première
occurence
msgmerge: 1 erreur fatale trouvée


It means a duplicate message definition errors line 103800 of the header.

The po file is not regenerated!

I will provide a patch, but maybe it is not the right place.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7892] on staged marc record management open in tab

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7892

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7892] on staged marc record management open in tab

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7892

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #17490|0   |1
is obsolete||

--- Comment #4 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 18666
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18666action=edit
Bug 7892: Open link to imported record in new tab

Change links to imported records to open in a new window/tab
on the staged records management page.

To test:
1) Go to Tools  Staged MARC record management
2) Open an imported batch by clicking on the file name
3) Click on bib# in the record column
4) Verify links open in a new window/tab now

Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com
All tests pass

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10413] French staff po file is not translatable

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10413

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 18667
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18667action=edit
Bug 10413: FIX translate update for french translation files

For 3.12.x branch

./translate update fr-FR will raise an error without this patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10413] French staff po file is not translatable

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10413

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10413] French staff po file is not translatable

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10413

--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 18668
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18668action=edit
Bug 10413: FIX translate update for french translation files

For master branch

./translate update fr-FR will raise an error without this patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9747] sort issue for the z3950 results

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747

--- Comment #14 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Oups, we both worked on this bug.
I revert my patch, I will add it in a new bug since it adds features.
So I set PassedQA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9747] sort issue for the z3950 results

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #18656|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9747] sort issue for the z3950 results

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #18657|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9747] sort issue for the z3950 results

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9747] sort issue for the z3950 results

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9579] Incorrect display of UNICODE symbols in 'Refine Search Results'

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579

--- Comment #15 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Hi,
this is no more in current master, fixed by Bug 10176.
I did test using Karam records, for me facets are working.
Could someone else test?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9579] Incorrect display of UNICODE symbols in 'Refine Search Results'

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579

--- Comment #16 from Tigran tig...@flib.sci.am ---
(In reply to comment #15)
 Hi,
 this is no more in current master, fixed by Bug 10176.
 I did test using Karam records, for me facets are working.
 Could someone else test?

my Koha version is 3.12.00 and the problem exist.
See the ? mark for Cyrillic and Armenian scripts.
Tigran

Cyrillic script
Topics
Астрофизик...
Вселенная
Солнечная �...

Armenian script
 Series
Գյուղական �...
Ժողովրդակա...
Նյութեր Հա�...

Authors
Գօգօլ
Խաչատրյան, ...
Հովնանյան, ...
Պապոյան, Ել...
Ռոզանով, Սե...
Show more
Places
Շաղատ գյու�...
Topics
Գեղարվեստա...
Հայ գրական�...
Հայ ժողովր�...
Ռուս գրակա�...
Ռուս մանկա�...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10413] French staff po file is not translatable

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10413

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Frédéric Demians frede...@tamil.fr ---
.po files should be modified directly on http://translate.koha-community.org
where there are pulled from the Translation Manager, and send to Release
Manager for inclusion to Koha Git repository.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9579] Incorrect display of UNICODE symbols in 'Refine Search Results'

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579

--- Comment #17 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Hi Tigran,
you can have two problems: wrong display and wrong links,
10176 fixes the link, not the display :-)

To fix the display we need to rewrite how facets are trimmed,
at this moment it use preference FacetLabelTruncationLength,
that truncates facet text at that lenght, which is alright 
but only for scripts that use latin or not ligate chars.
It needs to be rewritten so it cut facet text on   (space)
position = FacetLabelTruncationLength.

A workaround is set FacetLabelTruncationLength to a bigger 
value, 50 for example, then facets will not show those ?.

The test I was talking about involves the links :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9747] sort issue for the z3950 results

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747

--- Comment #15 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 18669
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18669action=edit
Bug 9747 - sort issue for the z3950 results - Followup

Finally I created a follow-up just to add the new sort in z3950 in acquisition
module.
Also adds default sorting on title column.

This feature is really usefull I bet.
Thanks all for your work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #45 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Small problem : 
Second query in updatedatabase is not executed.
This second query added by followup patch is not mandatory, so maybe correcting
updatedatabase.pl is enough.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898

--- Comment #46 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 18670
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18670action=edit
Bug 6898 - updatedatabase second query not executed

Patch to correct updatedatabase.
I created it on the bug branch but it applies on a master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10413] French staff po file is not translatable

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10413

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m

--- Comment #4 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
On http://translate.koha-community.org, I do not see the misgid=, I think it
is hidden.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #47 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Fridolyn:
Are you sure that this will really fix your problem?
Just updating an older dbrev will not help someone that never comes back to
that piece of code..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Created attachment 18671
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18671action=edit
Bug 10409 - Do not show course entry form if no departments are found

The course reserves entry form should not be shown if there are no
DEPARTMENT authorized values, since this prevents the form from being
submitted. This patch replaces the form with an error message when no
DEPARTMENT authorized values are found.

Also corrected:

- Corrected grid structure for more standard display
- Converted labels with no corresponding inputs to span class=label
- Closed unclosed tags
- Corrected incorrect capitalization

This patch contains whitespace changes, so please ignore whitespace when
examining changes.

To test, delete any DEPARTMENT authorized values, if present. Create a
new course in Course Reserves. You should see a warning that no
DEPARTMENT values were found.

If you are logged in with the correct permission, the warning should
contain a link to the correct authorized value page. If you do no, the
warning should refer the problem to an administrator.

After creating one or more DEPARTMENT values, the form should display
and submit correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10414] New: Course Reserves should be Course reserves in global More menu

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10414

Bug ID: 10414
   Summary: Course Reserves should be Course reserves in
global More menu
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org

Koha coding guidelines as of 2012 (Bug 2780) state that only the first letter
of titles, headings, buttons, etc. should be capitalized. Course Reserves in
the global More menu is incorrect.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10414] Course Reserves should be Course reserves in global More menu

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10414

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10414] Course Reserves should be Course reserves in global More menu

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10414

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Created attachment 18672
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18672action=edit
Bug 10414 - Course Reserves should be Course reserves in global More menu

The global More menu lists Course Reserves, which is incorrectly
capitalized. This patch changes it to Course reserves.

To test, apply the patch and view any page in the staff client. When you
click the More menu item the link should read Course reserves.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10415] New: Add course reserves to staff client home page

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10415

Bug ID: 10415
   Summary: Add course reserves to staff client home page
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: oleon...@myacpl.org
CC: gmcha...@gmail.com

If course reserves is an important enough module to list in the global More
menu then it should follow that it is important enough to include on the staff
client home page. The menu choices in the header menu (with the exception of
Cart mirror the main module links on the staff client home page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10415] Add course reserves to staff client home page

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10415

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Some possible choices for a course reserves icon for the home page:

http://thenounproject.com/noun/stack-of-books/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898

--- Comment #48 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
(In reply to comment #47)
 Fridolyn:
 Are you sure that this will really fix your problem?
 Just updating an older dbrev will not help someone that never comes back to
 that piece of code..

I know but this query adds the new permission to some borrowers.
Now that this permission in not new, I think it whould be dangerous to add it
to borrowers.
This was only a way to ease the set of the new permission.
For libraries that have already used updatedatabase, they will easily see for
who the permission is missing and set it manually.

Rather less permissions than to much no ? ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7718] Remove itemnumber column from serials table

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #14 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to comment #3)
 Yes, serials:items is a 1:many relationship. It seems to me that the correct
 solution here is not to populate serial.itemnumber, but rather to remove it
 so that no one thinks that they should be using it.

Jared:
Could you tell me how I can create more than one item for one serial record?
It just looks like a 1:1 relationship.

Note that the table name serial is somewhat misleading. It actually is some
kind of subscription item.
The relation between calling AddItem2Serial and NewIssue is not very clear in
the current Koha code.

If this is just 1:1, it would not have been a bad idea to remove the
serialitems table? If it is not, I am even more interested..

Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824

--- Comment #83 from Pierre Angot tredok.pie...@gmail.com ---
Is it possible to push this patch to 3.10.x ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10416] New: Correct template markup problems on course detail page

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10416

Bug ID: 10416
   Summary: Correct template markup problems on course detail page
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/course_reserves/course-details.pl?course
_id=X
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org

There are issues with validity and consistency on the course reserves course
detail page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10417] New: keep deleted authorities

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10417

Bug ID: 10417
   Summary: keep deleted authorities
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: neng...@gmail.com
CC: m.de.r...@rijksmuseum.nl

We keep deleted bibs and items, but not authorities. There should be a deleted
authorities table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7419] Add authority deduplication script

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419

--- Comment #27 from Jared Camins-Esakov jcam...@cpbibliography.com ---
I tested this script and found that it did not work at all with MARC21 because
of the way it was retrieving authid. I am working on a counter-patch which I
hope to upload tomorrow which incorporates the matching options from your
script but should work properly with both UNIMARC and MARC21.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10416] Correct template markup problems on course detail page

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10416

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10416] Correct template markup problems on course detail page

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10416

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Created attachment 18673
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18673action=edit
Bug 10416 - Correct template markup problems on course detail page

This patch corrects several problems with the course reserves course
detail page:

- Unescaped ampersands
- Extra /div
- Incorrect text in title tag
- Use of a table to display information which is more consistently
  displayed as a list.
- More accurate alert message, Are you sure you want to remove this
  item from the course? rather than Are you sure you want to delete
  this item?
- Missing icons from toolbar buttons

To test, apply the patch and view the details of an existing
course (Course reserves - [Course name]). Confirm that these changes
are present and look like an improvement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10418] New: Correct template markup problems on course reserves add item page

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10418

Bug ID: 10418
   Summary: Correct template markup problems on course reserves
add item page
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/course_reserves/add_items.pl
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org

There are issues with validity and consistency on the course reserves add item
page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5636] clean borrowers run from command line

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5636

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 CC||jonathan.dru...@biblibre.co
   ||m
 Resolution|--- |DUPLICATE

--- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com ---
This patch add a script which allow to
1/ Anonymize patron history = Done in misc/cronjobs/batch_anonymise.pl (bug
6572)
2/ Delete patrons = I will open a new report for that

*** This bug has been marked as a duplicate of bug 6572 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6572] Need a script to allow cronning of patron history deletion

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6572

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
*** Bug 5636 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 18674
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18674action=edit
Bug 10382 - collection not returning to null when removed from course reserves

Test Plan:
1) Create an item, do not set a collection code
2) Add the item to a course, and choose to set a collection code
3) Ensure the course is enabled, and the collection code is now visible
4) Disable the course, ensure the collection code is no longer visible

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10418] Correct template markup problems on course reserves add item page

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10418

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10418] Correct template markup problems on course reserves add item page

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10418

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Created attachment 18675
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18675action=edit
Bug 10418 - Correct template markup problems on course reserves add item page

This patch corrects several problems with the course reserves add item
pages:

- Non-standard grid markup.
- Extra /div.
- Incorrect styling of errors and messages.
- Redundant JS for adding focus to a field (use focus class).
- Invalid use of label with no corresponding input (use span
  class=label instead).
- Incorrect capitalization.

To test, apply the patch and examing both steps of the process of adding
an item to an existing course: The initial scan barcode form, and the
form for editing details of a scanned item.

Some cases to check:

- Scan an invalid barcode.
- Scan a barcode which has already been added to a course.
- Scan a barcode wihch has already been added to the course you're
  working with.

Forms should look correct and work correctly.

This patch contains whitespace changes, so please ignore whitespace when
examining changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

--- Comment #14 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 18676
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18676action=edit
Bug 9011 - Add the ability to store the last patron to return an item -
Followup - Remove foreign key constrant

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10015] UniqueItemFields could have link to database documentation

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10015

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #5 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7892] on staged marc record management open in tab

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7892

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #5 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5656] Add Checked only adding first checked item to batch

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5656

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
This issue is not present in master.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6293] Add a button to the intranet for registering with the Koha community

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6293

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

Version|3.6 |master

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8584] Improve cleanup_database.pl to only purge emails older than X days.

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8584

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #5 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Frédérick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10249] Untranslatable strings in Javascript on OPAC detail page

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10249] Untranslatable strings in Javascript on OPAC detail page

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

--- Comment #5 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5764] not for loan message in staff client repeated

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5764

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
The template displays Not for loan by default, followed by the actual text of
the not for loan authorized value. In the staff client that text is from the
'lib' column:

+--+--+---+
| authorised_value | lib  | lib_opac  |
+--+--+---+
| -1   | Ordered  | OPAC Ordered  |
| 1| Not for Loan | OPAC Not for Loan |
+--+--+---+

I agree that Not for Loan (Not for Loan) is redundant, but since the text in
parentheses is editable by the library, perhaps it should be left up to them to
change it to something which clarifies their own definition of Not for loan?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=5636

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5636] clean borrowers run from command line

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5636

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10419

--- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com ---
A script for deleting patron will be on bug 10419

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |ASSIGNED

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

  Attachment #18664|0   |1
is obsolete||

--- Comment #7 from Galen Charlton gmcha...@gmail.com ---
Comment on attachment 18664
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18664
Bug 766 Remove CGI::scrolling_list from request.pl

Latest patch pushed to master.  Thanks, Colin!

Resetting bug status; only a few left.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 18677
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18677action=edit
Bug 10419: Script for deleting patrons

This patch provides a cronjob script for deleting patrons.

It takes 3 options:
-not_borrowered_since
-expired_date
-category_code

See the perldoc misc/cronjobs/delete_patrons.pl
use the -v flag for a verbose mode.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766

--- Comment #8 from Galen Charlton gmcha...@gmail.com ---
Few is a relative term, I suppose:

./C4/Reports.pm:return CGI::scrolling_list(
./C4/Input.pm:$CGISort= CGI::scrolling_list(
./C4/Items.pm:$subfield_data{marc_value} =
CGI::scrolling_list(
./acqui/fetch_sort_dropbox.pl:$ret_html = CGI::scrolling_list(
./admin/marc_subfields_structure.pl:$row_data{tab} =
CGI::scrolling_list(
./admin/marc_subfields_structure.pl:$row_data{kohafield}=
CGI::scrolling_list(
./admin/marc_subfields_structure.pl:$row_data{authorised_value} =
CGI::scrolling_list(
./admin/marc_subfields_structure.pl:$row_data{value_builder} =
CGI::scrolling_list(
./admin/marc_subfields_structure.pl:$row_data{authtypes} =
CGI::scrolling_list(
./admin/marc_subfields_structure.pl:$row_data{tab} =
CGI::scrolling_list(
./admin/marc_subfields_structure.pl:$row_data{kohafield}=
CGI::scrolling_list(
./admin/marc_subfields_structure.pl:$row_data{value_builder} =
CGI::scrolling_list(
./admin/marc_subfields_structure.pl:$row_data{authorised_value} =
CGI::scrolling_list(
./admin/marc_subfields_structure.pl:$row_data{authtypes} =
CGI::scrolling_list(
./admin/marctagstructure.pl:my $authorised_value  =
CGI::scrolling_list(-name='authorised_value',
./admin/authorised_values.pl:   my $tab_list =
CGI::scrolling_list(-name='searchfield',
./admin/aqplan.pl:my $tab_list = CGI::scrolling_list(
./admin/aqplan.pl:my $CGIextChoice = CGI::scrolling_list(
./admin/aqplan.pl:my $CGIsepChoice = CGI::scrolling_list(
./admin/auth_subfields_structure.pl:$row_data{tab} =
CGI::scrolling_list(-name='tab',
./admin/auth_subfields_structure.pl:$row_data{ohidden} =
CGI::scrolling_list(-name='ohidden',
./admin/auth_subfields_structure.pl:#$row_data{ihidden} =
CGI::scrolling_list(-name='ihidden',
./admin/auth_subfields_structure.pl:#$row_data{ehidden} =
CGI::scrolling_list(-name='ehidden',
./admin/auth_subfields_structure.pl:$row_data{kohafield}=
CGI::scrolling_list( -name=kohafield,
./admin/auth_subfields_structure.pl:$row_data{authorised_value}  =
CGI::scrolling_list(-name='authorised_value',
./admin/auth_subfields_structure.pl:$row_data{frameworkcode}  =
CGI::scrolling_list(-name='frameworkcode',
./admin/auth_subfields_structure.pl:$row_data{value_builder}  =
CGI::scrolling_list(-name='value_builder',
./admin/auth_subfields_structure.pl:$row_data{tab} =
CGI::scrolling_list(-name='tab',
./admin/auth_subfields_structure.pl:$row_data{ohidden} =
CGI::scrolling_list(-name='ohidden',
./admin/auth_subfields_structure.pl:#$row_data{ihidden} =
CGI::scrolling_list(-name='ihidden',
./admin/auth_subfields_structure.pl:#$row_data{ehidden} =
CGI::scrolling_list(-name='ehidden',
./admin/auth_subfields_structure.pl:$row_data{kohafield}=
CGI::scrolling_list( -name='kohafield',
./admin/auth_subfields_structure.pl:$row_data{frameworkcode}  =
CGI::scrolling_list(-name='frameworkcode',
./admin/auth_subfields_structure.pl:$row_data{authorised_value}  =
CGI::scrolling_list(-name='authorised_value',
./admin/auth_subfields_structure.pl:$row_data{value_builder}  =
CGI::scrolling_list(-name='value_builder',
./admin/auth_tag_structure.pl:  my $authorised_value  =
CGI::scrolling_list(-name='authorised_value',
./admin/koha2marclinks.pl:my $marclist = CGI::scrolling_list(
./admin/koha2marclinks.pl:tablename = CGI::scrolling_list(
./circ/circulation.pl:$CGIselectborrower = CGI::scrolling_list(
./tools/batchMod.pl:  $subfield_data{marc_value} =CGI::scrolling_list( 
# FIXME: factor out scrolling_list
./authorities/authorities.pl:return CGI::scrolling_list(
./catalogue/labeledMARCdetail.pl:my $framework=CGI::scrolling_list( -name
= 'Frameworks',
./cataloguing/value_builder/unimarc_field_225a.pl:my $collection =
CGI::scrolling_list(
./cataloguing/value_builder/unimarc_field_4XX.pl:my $CGIitemtype =
CGI::scrolling_list(
./cataloguing/value_builder/unimarc_field_4XX.pl:my $CGIpublisher =
CGI::scrolling_list(
./cataloguing/value_builder/marc21_linking_section.pl: my
$CGIitemtype = CGI::scrolling_list(
./cataloguing/value_builder/marc21_linking_section.pl:  my
$CGIpublisher = CGI::scrolling_list(
./cataloguing/addbiblio.pl:return CGI::scrolling_list(
./cataloguing/additem.pl:$subfield_data{marc_value}
=CGI::scrolling_list(  # FIXME: factor out scrolling_list
./members/memberentry.pl:$CGIorganisations = CGI::scrolling_list( -id =
'organisations',
./reports/catalogue_stats.pl:#  my $CGIlccn=CGI::scrolling_list( -name =
'Filter',
./reports/serials_stats.pl: my $CGIextChoice=CGI::scrolling_list(
./reports/issues_stats.pl:my 

[Koha-bugs] [Bug 10420] New: Standardize spelling of authorized

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10420

Bug ID: 10420
   Summary: Standardize spelling of authorized
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org

There are instances of both authorized and authorised in Koha's templates.
With all due respect to the rest of the world, the default en templates do
stick to American spelling.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10419] New: There is no cronjob script for deleting patrons

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

Bug ID: 10419
   Summary: There is no cronjob script for deleting patrons
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@biblibre.com
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10421] New: Add cron script to delete deleted records

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421

Bug ID: 10421
   Summary: Add cron script to delete deleted records
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10421] Add cron script to delete deleted records

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #54 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Just some advance remarks:

In total this is a larger patch. It could be advantageous if Paul as the one
signing off, could further elaborate on what he exactly tested. Did you test
various numbering patterns, how much data was converted in the upgrade, etc.
etc. In this way we can build up some more confidence in this development.

I just had a quick look:

The upgrade reports lines like : NUMBERING METHOD: '{X}' Does not seem to be
very informative?
The label X, etc with Appears in numbering formula as {XL} do not seem very
easy to understand on Edit subscription? [This already held for numbering
patterns, but life is not simpler now..]
Funny date in next issue publication date: 02/00/0 Do not know what happened
here, but could be an existing problem..

Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10421] Add cron script to delete deleted records

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 18678
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18678action=edit
Bug 10421 - Add cron script to delete deleted records

This script will batch delete all records where the leader's record
status ( position 5 ) is set to 'd' ( Deleted ).

Test Plan:
1) Edit a few records, set the leader 05 to 'd' for deleted
2) Run delete_deleted_records.pl
3) Records that are deletable should be deleted!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10421] Add cron script to delete deleted records

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10400] Text::CSV_XS error-checking should be standardized

2013-06-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10400

--- Comment #2 from Galen Charlton gmcha...@gmail.com ---
Testing shows that if you pass an invalid field list to _get_text_fields(), the
result is:

$VAR1 = [
  {
'desc' = undef,
'code' = undef
  }
];

That seems a bit untidy; I think it ought to return either undef or a ref to an
empty list in that case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >