[Koha-bugs] [Bug 10368] Added price in overdue report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10368 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added CC||srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10368] Added price in overdue report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10368 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10368] Added price in overdue report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10368 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #18601|0 |1 is obsolete|| --- Comment #2 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 18721 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18721action=edit [SIGNED-OFF] Bug 10368 - Added price in overdue report Signed-off-by: Srdjan srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #18658|0 |1 is obsolete|| --- Comment #8 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 18722 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18722action=edit [SIGNED-OFF] Bug 9576 - Enable or disable issue limit confirmation Adds a new system preference AllowTooManyOverride to control whether a librarian can override the 'Too many checked out' message which is currently always overridable. Signed-off-by: Srdjan srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added CC||srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 --- Comment #5 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- (In reply to comment #4) Well if it is in circulation rules (where it should be), maybe the syspref is redundant. It is in circulation rules indeed but I think the syspref is used to temporary reduce reserves for all users, for holidays for example. Changing a syspref is much more easy that all circulation rules. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10376] Printing cart does not work under IE9
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10376 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #18464|0 |1 is obsolete|| --- Comment #2 from Marc Véron ve...@veron.ch --- Created attachment 18723 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18723action=edit [SIGNED-OFF] Bug 10376: Printing cart does not work under IE9 Test plan: 1) Test with Firefox (or any other browser except IE): Add biblio to cart Go to Cart and click Print Does the Cart window come back to its original state after confirm/cancel Print? 2) Test with Internet Explorer (I used IE9; testing another version is fine) Do the same as above. Is behavior now more or less the same? Signed-off-by: Marc Veron ve...@veron.ch 1) Test without patch: IE 10: Does not show print dialog IE 9 (Developer Emulation in IE 10): Does not show print dialog (as expected) FF 21.0 OK Chrome 27.0.1453.110 m: OK 2) Test with patch: IE 10: OK IE 9 (Developer Emulation in IE 10): OK IE 8 (Developer Emulation in IE 10): OK IE 7 (Developer Emulation in IE 10): OK FF 21.0 OK Chrome 27.0.1453.110 m: OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10376] Printing cart does not work under IE9
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10376 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10424] Search against order numbers and pull up the related invoice to see when the item was receipted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10424 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Sorry for the misunderstanding :) I think there is a patch pending somewhere to add this column, but I am not sure about the bug. Adding Jonathan to this bug in CC, maybe he knows as this is probably a Biblibre development. There is also a bug report about the filters in invoices not working correctly: bug 8854 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10424] Search against order numbers and pull up the related invoice to see when the item was receipted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10424 --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- The aqorders.branchcode is added by Bug 5336 - Acq history search (needs QA) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10424] Search against order numbers and pull up the related invoice to see when the item was receipted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10424 --- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Cool, thx Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8854] invoice filters don't all work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Galen, in fact the aqorders.branchcode field is added by bug 5336 (needs QA). So with this patch, the 2 join will become useless. It seems there has been a mistake in bug's relations :-/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10428] New: undefined check in add additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10428 Bug ID: 10428 Summary: undefined check in add additem.pl Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: fridolyn.som...@biblibre.com CC: m.de.r...@rijksmuseum.nl In additem.pl, in the code that generates item form you find : @values = $itemrecord-field($tag)-subfield($subtag) if ($itemrecord defined($itemrecord-field($tag)-subfield($subtag))); This code is missing the check of $itemrecord-field($tag) undef. I did not found a way to test it because item tag is always defined when editing an item, but it would be safer/prettier to add this check. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10428] undefined check in add additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10428 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |fridolyn.som...@biblibre.co ||m --- Comment #1 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 18724 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18724action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10428] undefined check in add additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10428 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18677|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18725 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18725action=edit Bug 10419: Script for deleting patrons This patch provides a cronjob script for deleting patrons. It takes 3 options: -not_borrowered_since -expired_date -category_code See the perldoc misc/cronjobs/delete_patrons.pl use the -v flag for a verbose mode. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Srdjan, yep, you are right! I don't know at all why I wrote that this way, not really readable... :) Thanks for the catch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9507] Some code used to prevent form from being unexpectedly submitted is duplicated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507 --- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18726 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18726action=edit Bug 9507: prevent submit: refactor some code in a js file This patch refactors some code in a js file. Test plan: On acqui/neworderempty.pl, acqui/orderreceive.pl and serials/serials-edit.tt try to scan a barcode (or press enter) on the form and check that it is not sent. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Have to note that the code for IE9 does not work. Before and after this patch. If we refactor code, it would have been nice to resolve this too. But I do not oppose pushing this patch. The test uses 'an ancient Netscape property' window.Event (uppercase!) to make the distinction between browers and event models. Some more documentation here would be welcome too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9507] Some code used to prevent form from being unexpectedly submitted is duplicated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18726|Bug 9507: prevent submit: |[3.8.x] Bug 9507: prevent description|refactor some code in a js |submit: refactor some code |file|in a js file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9507] Some code used to prevent form from being unexpectedly submitted is duplicated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507 --- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #16) Hi Chris, this last patch applies on 3.8.x branch. js/cataloguing.js is not needed for this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10363] There is no package for authorised values.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363
--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #4)
Srdjan,
I'm not sure if there's a consensus re constructors in the Koha namespace
and use of Class::Accessor. I believe it is rarely necessary to provide
new() in those cases.
Class:Accessor is already used in many places in the Koha namespace.
I suggest:
* remove new() constructors all together, Koha::AuthorisedValue-new({av =
$av}) is unnecessary cause it is equivalent to
Koha::AuthorisedValue-new($av}
The Koha::AuthorisedValue-new can be called directly with the $av (which
contains all values) or just with an id or category/value. These different ways
to build an object forced me to have a new routine. But maybe I don't see
concretely what you say :-/
* upgrade fetch(key) to constructors, passing the key values; this way
Koha::AuthorisedValues-new() becomes Koha::AuthorisedValues-fetch()
Yes but, like as before, sometimes we don't want to do a select in DB (when the
object is called from Koha::AuthorisedValues).
* if you need to reload(), make those methods, and make reload() and fetch()
call _fetch(key)
I think I don't have the need to reload.
In general, has there been a discussion on using DBIx::Class or similar?
Yes, but it seems that nobody strongly supports the integration into Koha.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |In Discussion CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Kyle, what do you think about the Owen's proposition? Owen, what do you suggest? Switch to in discussion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10376] Printing cart does not work under IE9
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10376 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Marcel, why do you use the obscure IEprint variable? A user will not be able to print twice the basket? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10370] Adding barcode on circulation print page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10370 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA URL||members/moremember-print.pl CC||jonathan.dru...@biblibre.co ||m Patch complexity|--- |Trivial patch QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: This patch adds a new column containing the barcode on the circulation print page. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10370] Adding barcode on circulation print page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10370 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18720|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18727 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18727action=edit Bug-10370-Adding barcode on circulation print page. Signed-off-by: Srdjan srd...@catalyst.net.nz Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: Looks good to me too. I will provide a patch for qa tools in order to avoid another intranet-tmpl or opac-tmpl. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18718|0 |1 is obsolete|| --- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18728 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18728action=edit Bug 2774 - Path to theme is hard-coded in many places This patch corrects serveral more places in the templates where the path to the prog theme is hard-coded. To test, apply the patch and view the following cases: - When a database update is triggered the login page loads login.css. This path should be correct. (Reference to wizard.css is removed as per Bug 10422). - The course reserves home page should load datatables-related assets correctly. - Help pages for the Quick spine label creator and the staff client home page should show the correct paths where they reference the Koha file system. - The web installer pages should correctly load the Koha logo. - The label creator manage pages (layouts, templates, etc.) should correctly load datatables-related assets. Signed-off-by: Liz Rea l...@catalyst.net.nz Checked all 5 - look good. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 k...@univ-lyon3.fr changed: What|Removed |Added Attachment #18507|0 |1 is obsolete|| --- Comment #46 from Koha Team Lyon 3 k...@univ-lyon3.fr --- Created attachment 18729 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18729action=edit Bug 8236 Block renewing for overdue items oups, squeezed some lines that had to be kept; Problem corrected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 k...@univ-lyon3.fr changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 --- Comment #17 from Koha Team Lyon 3 k...@univ-lyon3.fr --- ?! I redid tests and it's ok for me. I have first the 'is now debarred until' message and then the 'Reminder: Patron was earlier restricted until' message for the following checkin with shorter late. Are you sure of your test ? Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10346] Add multiple copies should be labelled Add multiple items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10346 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m Patch complexity|--- |String patch QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: String patch. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10346] Add multiple copies should be labelled Add multiple items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10346 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18694|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18730 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18730action=edit Bug 10346 - Add multiple copies should be labelled Add multiple items The Koha interface standardizes on the term item instead of copy, so the Add multiple copies button would be more correctly labeled Add multiple items. To test, view the add item screen for an existing or new record. You should see a button labeled Add multiple items. Signed-off-by: Cedric Vita cedric.v...@dracenie.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10396] Catalog stats shows calendar in callnumber field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10396 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: The patch does not work: both from and to inputs (for publication year) are changed when I choose a date. To reproduce: 1/ Go on reports/catalogue_stats.pl 2/ Choose a from date OK 3/ Choose a to date KO: The from date is changed too Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9300] filtering export.pl by accession date does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9300 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m Patch complexity|--- |Trivial patch QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Typo fix. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9300] filtering export.pl by accession date does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9300 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18698|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18731 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18731action=edit Bug 9300 - filtering export.pl by accession date does not work Small typo in query construction, fixed. To test: 1) Try filtering a MARC export using Start date 2) Notice the lack of filtering 3) Apply patch 4) Try export again, records are filtered by dateaccessioned Signed-off-by: Cedric Vita cedric.v...@dracenie.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m Patch complexity|--- |Trivial patch QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: Simple patch. Works as described. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18593|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18732 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18732action=edit Bug 10354 - Don't show optgroup Libraries when no search groups are defined In the OPAC, if there are no search groups defined, there's no reason to embed library choices inside an optgroup. optgroup should only be used to differentiate the list of individual libraries from search groups. This patch removes the optgroup when no search groups are enabled. To test, apply the patch and: - Enable OpacAddMastheadLibraryPulldown. - Create a library search group in Administration - Libraries and Groups and enable it by checking the show in search pulldown box. - View the library pulldown in the OPAC search bar. Libraries and groups should be separated into optgroups. - Disable your library search group and refresh the OPAC page. The pulldown of libraries should now display libraries with no optgroup. Signed-off-by: Srdjan srd...@catalyst.net.nz Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10245] OPAC items table CSS classes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10245 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #18146|0 |1 is obsolete|| --- Comment #3 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 18733 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18733action=edit Bug 10245 adding OPAC detail items table classes Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com Classes now appear on th as well for easy styling. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10245] OPAC items table CSS classes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10245 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9871] Quiet warns when logging into Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9871 Pablo AB pablo.bian...@gmail.com changed: What|Removed |Added CC||pablo.bian...@gmail.com --- Comment #1 from Pablo AB pablo.bian...@gmail.com --- I think this bug is related to bug #9611, it may be a duplicate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #18671|0 |1 is obsolete|| --- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 18734 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18734action=edit Bug 10409 - Do not show course entry form if no departments are found The course reserves entry form should not be shown if there are no DEPARTMENT authorized values, since this prevents the form from being submitted. This patch replaces the form with an error message when no DEPARTMENT authorized values are found. Also corrected: - Corrected grid structure for more standard display - Converted labels with no corresponding inputs to span class=label - Closed unclosed tags - Corrected incorrect capitalization This patch contains whitespace changes, so please ignore whitespace when examining changes. To test, delete any DEPARTMENT authorized values, if present. Create a new course in Course Reserves. You should see a warning that no DEPARTMENT values were found. If you are logged in with the correct permission, the warning should contain a link to the correct authorized value page. If you do no, the warning should refer the problem to an administrator. After creating one or more DEPARTMENT values, the form should display and submit correctly. Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com After this patch has been applied, I get an error message and no form if I don't have any DEPARTMENTs defined, which makes sense given that the form can't be submitted without a DEPARTMENT. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
CC||jonathan.dru...@biblibre.co
||m
--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Marcel, Does the following code fix the problem?
-my $member = GetMember(borrowernumber = $loggedinuser);
-if ($basket-{closedate} haspermission({ acquisition = 'group_manage'}
)) {
+my $member = GetMember(borrowernumber = $loggedinuser)-{userid};
+if ($basket-{closedate} haspermission($uid, { acquisition =
'group_manage'} )) {
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354 --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18735 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18735action=edit [ALT] Bug 10354: Remove erroneous call to haspermission in basket.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18735|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Comment on attachment 18735 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18735 [ALT] Bug 10354: Remove erroneous call to haspermission in basket.pl Wrong report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18736 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18736action=edit [ALT] Bug 10354: Remove erroneous call to haspermission in basket.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com --- There is a conflict between the bug description and the test plan that leaves me rather confused. The bug report talks about removing an item from course reserves, but the test plan talks about disabling the course while leaving the item in the course reserves. Are item fields supposed to get set back to what they were before being put on reserve if they are removed from course reserves, or is that functionality that has not been implemented? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10426] Remove unused sub GetCcodes from C4::Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||kyle.m.h...@gmail.com --- Comment #3 from Kyle M Hall kyle.m.h...@gmail.com --- In addition to Srdjan's comment, this sub is used in misc/cronjobs/stats/monthly_circulation_statistics.pl To remove the GetCcodes sub, this script will need to be refactored or deleted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10428] undefined check in add additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10428 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18724|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18737 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18737action=edit Bug 10428 - undefined check in add additem.pl In additem.pl, in the code that generates item form you find : @values = $itemrecord-field($tag)-subfield($subtag) if ($itemrecord defined($itemrecord-field($tag)-subfield($subtag))); This patch adds the check of $itemrecord-field($tag) undef. I did not found a way to test it because item tag is always defined when editing an item, but it would be safer/prettier to add this check. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10428] undefined check in add additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10428 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added CC||kyle.m.h...@gmail.com --- Comment #3 from Kyle M Hall kyle.m.h...@gmail.com --- Agreed. Not easy to test, but this is a completely sensible additional test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10428] undefined check in add additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10428 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10418] Correct template markup problems on course reserves add item page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10418 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10418] Correct template markup problems on course reserves add item page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10418 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #18675|0 |1 is obsolete|| --- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 18738 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18738action=edit Bug 10418 - Correct template markup problems on course reserves add item page This patch corrects several problems with the course reserves add item pages: - Non-standard grid markup. - Extra /div. - Incorrect styling of errors and messages. - Redundant JS for adding focus to a field (use focus class). - Invalid use of label with no corresponding input (use span class=label instead). - Incorrect capitalization. To test, apply the patch and examing both steps of the process of adding an item to an existing course: The initial scan barcode form, and the form for editing details of a scanned item. Some cases to check: - Scan an invalid barcode. - Scan a barcode which has already been added to a course. - Scan a barcode wihch has already been added to the course you're working with. Forms should look correct and work correctly. This patch contains whitespace changes, so please ignore whitespace when examining changes. Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com The add item screen continues to work as before. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10425] Help page missing for Local Use preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10425 --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18739 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18739action=edit Bug 10425 - Help page missing for Local Use preferences When viewing Local Use system preferences tab, the help button will lead to an error page. This is because Local Use tab uses not the same script has other tabs : systempreferences.pl. This patch simply copies help/prefences.tt as help/systemprefences.tt Test plan : - Go to Local Use preferences : /cgi-bin/koha/admin/systempreferences.pl - Click on Help link (at right top) - See you get the same page as other preferences tab help Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10425] Help page missing for Local Use preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10425 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10429] New: branch filter not working in serial claims
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Bug ID: 10429 Summary: branch filter not working in serial claims Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: fridolyn.som...@biblibre.com CC: colin.campb...@ptfs-europe.com In serial claims page, the branch code is displayed in table instead of branch name and branch filter does not work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10425] Help page missing for Local Use preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10425 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Attachment #18695|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10420] Standardize spelling of authorized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10420 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18680|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18740 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18740action=edit Bug 10420 - Standardize spelling of authorized This patch corrects instances of the non-[American]-standard spelling authorised when used in text. The following instances are corrected: - In Administration - Funds, the error message displayed if you do not have permission to edit a fund. - In Administration - Authorized values, the instructions linked to the Libraries limitation field. - In Administration - MARC bibliographic framework test, instructions related to linking to authorized values. - In the course reserves add form, error messages referring to missing authorized values. - In guided reports, error messages shown when an authorized value chosen as a report parameter doesn't exit. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10416] Correct template markup problems on course detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10416 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #18673|0 |1 is obsolete|| --- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 18741 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18741action=edit Bug 10416 - Correct template markup problems on course detail page This patch corrects several problems with the course reserves course detail page: - Unescaped ampersands - Extra /div - Incorrect text in title tag - Use of a table to display information which is more consistently displayed as a list. - More accurate alert message, Are you sure you want to remove this item from the course? rather than Are you sure you want to delete this item? - Missing icons from toolbar buttons To test, apply the patch and view the details of an existing course (Course reserves - [Course name]). Confirm that these changes are present and look like an improvement. Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com The course details screen looks much more consistent with other parts of Koha now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10420] Standardize spelling of authorized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10420 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||kyle.m.h...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10416] Correct template markup problems on course detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10416 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10221] hold expiration doesn't show on patron's list of holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10221 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m Patch complexity|--- |Trivial patch QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: The patch adds a expiration column for holds tables on moremember and circulation pages. Works as expected. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10221] hold expiration doesn't show on patron's list of holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10221 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18120|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18742 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18742action=edit Bug 10221 - hold expiration doesn't show on patron's list of holds When viewing the list of a patron's holds on the circulation page or the patron detail page the table of holds doesn't display the holds expiration date, if present. This patch adds display of the hold expiration date. To test, place a hold for a patron and set an expiration date for it. View the patron's existing holds on both circulation.pl and moremember.pl. The expiration date you chose should appear in the table of information about existing holds. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com works great Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 --- Comment #6 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #4) Jared, thank you for testing. I confirm the tests pass here :-/ Could you retry with the last patch please? It replaces ok with is. We should have a more readable failure. I'm still getting failures: jcamins@kohadev:~/kohaclone$ prove t/db_dependent/Reserves.t t/db_dependent/Reserves.t .. 1/4 # # Creating biblio instance for testing. # Creating item instance for testing. INSERT INTO borrowers SET borrowers.firstname = ? , borrowers.dateenrolled = ? , borrowers.userid = ? , borrowers.categorycode = ? , borrowers.surname = ? , borrowers.dateexpiry = ? , borrowers.password = ? , borrowers.cardnumber = ? , borrowers.branchcode = ? my firstname,2013-06-07,myfirstname.mysurname,S,my surname,2021-09-07,!,CARDNUMBER42,CPL at /home/jcamins/kohaclone/C4/SQLHelper.pm line 182. SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE borrowernumber = ? 78 at /home/jcamins/kohaclone/C4/Members.pm line 556. SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE borrowernumber = ? 78 at /home/jcamins/kohaclone/C4/Members.pm line 556. # Failed test 'CheckReserves Test 1' # at t/db_dependent/Reserves.t line 67. # got: '' # expected: 'Reserved' SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE borrowernumber = ? 78 at /home/jcamins/kohaclone/C4/Members.pm line 556. t/db_dependent/Reserves.t .. 3/4 # Failed test 'CheckReserves Test 2' # at t/db_dependent/Reserves.t line 70. # got: '' # expected: 'Reserved' SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE borrowernumber = ? 78 at /home/jcamins/kohaclone/C4/Members.pm line 556. # Failed test 'CheckReserves Test 3' # at t/db_dependent/Reserves.t line 73. # got: '' # expected: 'Reserved' # Deleting item testing instance. # Deleting biblio testing instance. # Deleting borrower. # Looks like you failed 3 tests of 4. t/db_dependent/Reserves.t .. Dubious, test returned 3 (wstat 768, 0x300) Failed 3/4 subtests Test Summary Report --- t/db_dependent/Reserves.t (Wstat: 768 Tests: 4 Failed: 3) Failed tests: 2-4 Non-zero exit status: 3 Files=1, Tests=4, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.60 cusr 0.06 csys = 0.70 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18725|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18743 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18743action=edit Bug 10419: Script for deleting patrons This patch provides a cronjob script for deleting patrons. It takes 3 options: -not_borrowered_since -expired_date -category_code See the perldoc misc/cronjobs/delete_patrons.pl use the -v flag for a verbose mode. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #6 from Jared Camins-Esakov jcam...@cpbibliography.com --- This looks better, but the bookseller is not getting deleted at the end of the run. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #6 from Kyle M Hall kyle.m.h...@gmail.com --- Looks good, but I've a few suggestions: 1) I'd switch from --dry-run to --confirm. This seems to be a more standard way to do things ( in so far as a number of scripts have --confirm and none have --dry-run ). 2) The script has first person style output, whereas no other Koha cli scripts do. It might be better to remove the Is from the script output 3) The use of the date program in the example output, while clever and a great idea, makes the help a bit confusing and hard to read. It would be better to juse put hard dates in the example usage, and a short explanation on how to use `date` to autogenerate the dates. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10414] Course Reserves should be Course reserves in global More menu
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10414 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10429] branch filter not working in serial claims
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |fridolyn.som...@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 18745 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18745action=edit Proposed patch See commit message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10414] Course Reserves should be Course reserves in global More menu
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10414 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18672|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18744 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18744action=edit Bug 10414 - Course Reserves should be Course reserves in global More menu The global More menu lists Course Reserves, which is incorrectly capitalized. This patch changes it to Course reserves. To test, apply the patch and view any page in the staff client. When you click the More menu item the link should read Course reserves. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10430] New: status filter not working in serial claims when translated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Bug ID: 10430 Summary: status filter not working in serial claims when translated Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: fridolyn.som...@biblibre.com CC: colin.campb...@ptfs-europe.com Whis a translated intranet (ie fr-FR) the status filter does not work for Late status. It is because status in combobox filter is translated Retard and status in table is translated En retard. We could change translation but it would be better if filter did not work on status name. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10430] status filter not working in serial claims when translated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 --- Comment #1 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- [With] a translated intranet. Sorry :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10430] status filter not working in serial claims when translated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10429 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10430] status filter not working in serial claims when translated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 --- Comment #2 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- I also created Bug 10429 for branch filter -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10429] branch filter not working in serial claims
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10430 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #112 from Serhij Dubyk du...@library.lviv.ua --- In Koha 3.12 some encoding problems was returned. Currently found in 3 locations: http://localhost:/cgi-bin/koha/members/members-home.pl (main screen) http://localhost:/cgi-bin/koha/members/member.pl (search) http://localhost:/cgi-bin/koha/circ/circulation.pl (search and menu) http://localhost:/cgi-bin/koha/admin/preferences.pl (search for non-latin) Screenshots attached. Search by members completely can not be used in 3.12.0. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10420] Standardize spelling of authorized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10420 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- I am certainly not in the best position to take a part in this debate (...) but why do you choose the American spelling as standard? http://grammarist.com/spelling/authorise-authorize/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #113 from Serhij Dubyk du...@library.lviv.ua --- Created attachment 18746 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18746action=edit Search for preferences in Cyrillic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #114 from Serhij Dubyk du...@library.lviv.ua --- Created attachment 18747 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18747action=edit Search for circulation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10430] status filter not working in serial claims when translated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |fridolyn.som...@biblibre.co |ity.org |m --- Comment #3 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 18748 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18748action=edit Proposed patch See commit message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10429] branch filter not working in serial claims
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #115 from Serhij Dubyk du...@library.lviv.ua --- Created attachment 18749 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18749action=edit Members Home -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10430] status filter not working in serial claims when translated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #116 from Serhij Dubyk du...@library.lviv.ua --- Created attachment 18750 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18750action=edit Search for members -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10399] rebuild_zebra.pl should reset the indexes with -r even if zebraqueue empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10399 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||kyle.m.h...@gmail.com --- Comment #2 from Kyle M Hall kyle.m.h...@gmail.com --- Test plan please. I cannot find a situation that triggers the new sub! I tried misc/migration_tools/rebuild_zebra.pl -b -v -r -s -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10378] Enable checked out items to be transferred without returning them
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10378 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |kyle.m.h...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10420] Standardize spelling of authorized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10420 --- Comment #5 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #4) I am certainly not in the best position to take a part in this debate (...) but why do you choose the American spelling as standard? http://grammarist.com/spelling/authorise-authorize/ Because the rest of Koha already uses US spelling (cataloging, authorized in most places, check out, etc.). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10378] Enable checked out items to be transferred without returning them
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10378 --- Comment #5 from Kyle M Hall kyle.m.h...@gmail.com --- That's not a bad idea. However, another issue is that Koha has simply not been written with the idea an item can be checkout out and in transit at the same time. It appears that there are parts of Koha that will assume a checked out item isn't being transferred and not display the in transit message. I think this idea only half-baked and needs some followups, if it is to be pushed. (In reply to comment #4) Exploring the consequences a bit ... the libraries in question are OK with the possibility that the loan might incur overdue fines while in transit back to the owning library? And they *always* want manual transits to not check the item in? If the answer to the second question is along the lines of on a case-by-case basis, I wonder if the syspref should simply enable the _option_ of transiting without returning, in conjunction with a checkbox (and possibly a user permission) for a circ staffer to indicate that a particular loan should not be checked in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #6) This looks better, but the bookseller is not getting deleted at the end of the run. :-/ Did you get an error? It should be deleted, DelBookseller is called into the END block. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10363] There is no package for authorised values.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #8 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18753 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18753action=edit Bug 10363: Adds unit tests for Koha::AuthorisedValue[s] packages Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10363] There is no package for authorised values.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18430|0 |1 is obsolete|| Attachment #18431|0 |1 is obsolete|| Attachment #18432|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18751 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18751action=edit Bug 10363: Add 2 packages for authorised values Currently, the authorised values are anarchically managed :) We have to have a better way to manage them. I propose 2 packages in order to execute the sql queries into a package instead of directly into the pl script. This development adds: - A new unique key (category and authorised values) for the authorised_values table. - 2 new packages Koha::AuthorisedValue and Koha::AuthorisedValues - 1 new unit test file in order to test these 2 packages. It is a code source evolution, but there is no change for the final user. Test plan: 1/ Apply the patches 2/ Check that existing authorised values is displayed on your admin page (admin/authorised_values.pl). 3/ Update an existing one 4/ Create a new category 5/ Create a new AV for this category 6/ Create another one with the same value, an error should be occur. 7/ Delete one AV. 8/ Click everywhere on the authorised values admin page and try to find a bug. 9/ Launch t/db_dependent/AuthorisedValues.t and check that all tests pass (1 sql error appears, it is normal). Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10363] There is no package for authorised values.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10363] There is no package for authorised values.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #7 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18752 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18752action=edit Bug 10363: DB Changes: Adds a unique key for the authorised values table. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #3 from Kyle M Hall kyle.m.h...@gmail.com --- (In reply to comment #2) There is a conflict between the bug description and the test plan that leaves me rather confused. The bug report talks about removing an item from course reserves, but the test plan talks about disabling the course while leaving the item in the course reserves. Are item fields supposed to get set back to what they were before being put on reserve if they are removed from course reserves, or is that functionality that has not been implemented? Yes, disabling all courses an item is attached to and removing an item from all courses it is attached to are functionally equivalent ( as far as the `items` table is concerned ). I wrote the test plan to make it quicker to test. In both cases fields should revert to the original values. Nobody including mysql thought of a scenario where a field would go from not having a value to having a value and back. It was always switching values, or not modifying the field at all. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18754 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18754action=edit Bug 10419: Followup - Script for deleting patrons This followup adds: - execute flag (+x) for the cronjob script. - replaces --dry-run with --confirm (according with existing scripts). - changes output text (remove 'first person' style). - updates the doc and simplifies the dates parameters. - changes flags PrintError and RaiseError for the dbh in order to catch something if an error occurs... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Thanks for testing Kyle. I provide a new patch in order to apply your suggestions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10420] Standardize spelling of authorized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10420 --- Comment #6 from Owen Leonard oleon...@myacpl.org --- And the point isn't that American spelling is standard, just that it is the convention for Koha templates. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
