[Koha-bugs] [Bug 10457] New: Export selected items data doesn't work when using checkall checkbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10457 Bug ID: 10457 Summary: Export selected items data doesn't work when using checkall checkbox Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au CC: colin.campb...@ptfs-europe.com Currently, if you use the check all checkbox next to the Vendor table header, and try to Export selected items data, you'll experience the following SQL error: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'on ORDER BY title' at line 12 at /kohawebs/prod38/lib/C4/Serials.pm line 1828. This is because the Javascript that produces the re-direct URL is including the value of the checkall checkbox, which is on, as a serialid. We need to only take checkboxes with a name of serialid when crafting the re-direct link. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10457] Export selected items data doesn't work when using checkall checkbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10457 David Cook dc...@prosentient.com.au changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | --- Comment #1 from David Cook dc...@prosentient.com.au --- Created attachment 18911 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18911action=edit Bug 10457 - Export selected items data doesn't work when using checkall checkbox Test Plan: Before applying the patch: 1) Go to Serials Claims (found on the left navigation bar of Serials) 2) Choose a vendor that has serials to claim (or create some late serials for a vendor so that they will show up) 3) Click on the checkbox to the left of the Vendor table heading. 4) Click Export selected items data at the bottom of the page 5) Notice that you'll get a SQL error like the one in the message above. Apply the patch. Repeat Steps 1-4. Note that you should now have a CSV file downloading rather than getting a SQL error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10456] z3950NormalizeAuthor and z3950AuthorAuthFields cause problems for MARC21 (and are sloppily written)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10456 --- Comment #1 from David Cook dc...@prosentient.com.au --- Silly me...I should've checked master more thoroughly. There is already a check to make sure that the marcflavour is UNIMARC. However, I think it would still be a good idea to re-visit this bit of code. There are no checks to make sure that $field is initialized as a MARC object before creating it. It seems to be a bizarre bit of code... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8988] item status uses authorized value description for intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8988 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8988] item status uses authorized value description for intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8988 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #16126|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8988] item status uses authorized value description for intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8988 --- Comment #12 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Forget about 3.6 patch, 3.10 and 3.8 are enough now that we have 3.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8988] item status uses authorized value description for intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8988 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Version|3.6 |3.8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8988] item status uses authorized value description for intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8988 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7163] BibLibre acquisitions omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7163 Bug 7163 depends on bug 5355, which changed state. Bug 5355 Summary: add volumedesc in order line http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5355 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5355] add volumedesc in order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5355 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Julian Maurice julian.maur...@biblibre.com --- Bug description does not correspond to given branch number BibLibre development corresponding to branch number 6522 is already in master (integrated into Bug 7583) Bug description does not correspond to any BibLibre development. Closing. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10458] New: Remove obsolete Z3950 module and test
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10458 Bug ID: 10458 Summary: Remove obsolete Z3950 module and test Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: m.de.r...@rijksmuseum.nl Reporter: m.de.r...@rijksmuseum.nl CC: m.de.r...@rijksmuseum.nl Removes a dead module and test. Not used and lots of FIXME's in there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10458] Remove obsolete Z3950 module and test
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10458 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10458] Remove obsolete Z3950 module and test
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10458 --- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18912 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18912action=edit Bug 10458: Remove obsolete Z3950 module and test Are not used. Contain several FIXMEs. Removing them makes life easier. Test plan: Actually, you cannot test this. But for confidence: do a Z3950 search in cataloguing and acquisition. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 --- Comment #19 from Koha Team Lyon 3 k...@univ-lyon3.fr --- Bonjour Cédric, No there's no syspref to activate nor updatedatabase to do, but I repeat it works on our test instance. Anyhow you should have at least the already existing message 'is now debarred until'. Do you have this one without the patch ? Olivier -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7933] Fields in marc display not the same
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7933 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #16231|0 |1 is obsolete|| --- Comment #21 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 18913 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18913action=edit Bug 7933: Fields in marc display not the same Small doc correction -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7933] Fields in marc display not the same
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7933 --- Comment #22 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 18914 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18914action=edit Bug 7933: Unit test for C4::Biblio::RemoveHiddenSubfields Whooo, my first unit-test. I hope it is correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7933] Fields in marc display not the same
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7933 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9665] Staff client bibliographic record export missing some options available in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9665 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9665] Staff client bibliographic record export missing some options available in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9665 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9665] Staff client bibliographic record export missing some options available in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9665 --- Comment #10 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 18916 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18916action=edit Bug 9665 : QA follow up fixing tabs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9665] Staff client bibliographic record export missing some options available in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9665 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #18829|0 |1 is obsolete|| --- Comment #9 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 18915 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18915action=edit Bug 9665 [Revised] Staff client bibliographic record export missing some options available in the OPAC The OPAC offers RIS and BIBTEX as choices for bibliographic downloads, but the staff client is missing these options. This patch adds them. To test, view a record in the staff client (detail.pl, MARCdetail.pl, etc.) and click the Save... toolbar button. BIBTEX and RIS should be available and functional. Revision reimplements the changes on the new Bootstrap version of the menu. Signed-off-by: David Cook dc...@prosentient.com.au Signed-off-by: Chris Cormack chr...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9740] using XSLT modifies record authorized values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9740 --- Comment #16 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- (In reply to comment #15) No question that the code is poor, but surely it can be fixed without breaking functionality? Just in case : I do not speak about the authorized value conversion in the block displayed by the XSLT. I think no one add noticed that side effect and used it has a functionality. If you wan, I create a follow-up that replaces in Description tab the authorized values by there description. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8662] Remove unused famfamfam icons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8662] Remove unused famfamfam icons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #18548|0 |1 is obsolete|| --- Comment #15 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 18917 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18917action=edit Bug 8662 - Remove unused famfamfam icons This patch removes images in the famfamfam directory which are unused by Koha. Files to delete were chosen based on a search of the Koha source. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Chris Cormack chr...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8662] Remove unused famfamfam icons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9072] Add CheckValidity option to Linker
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9072 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Pushed to Stable|CLOSED Resolution|--- |FIXED --- Comment #20 from Julian Maurice julian.maur...@biblibre.com --- Ok in master, 3.12.x and 3.10.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #109 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #108) Hi Chris, The point of my counter proposal was that we do not need another module, we can add some lines to context.pm using Log4perl and not have another module to maintain ourselves. Humm, I don't think it is a good argument. A module with unit tests is easiest to maintain than a module like C4::Context (~1000l) :) Pushing this now as it is, would mean we would just have to remove it again if we wanted to do it the Log4perl way. IE if people think that is a good idea, then I can write a working patch for that, however if this is pushed, I won't. I also won't be happy that we have yet another module we have to maintain instead. I maintain we dont need a new logging module, we just need to add logging to C4::Context. There is no problem to propose an alternative working patch, but don't loose sight of the fact that the module we propose here does something else more than just logging: - a called by trace is displayed for some levels - a get_messages method allows to return all logged messages - messages are thrown to the stdout if the logger is not defined (ie. no filepatch defined or a bad configuration somewhere) - a parameter allows to dump a variable (using Data::Dumper or something else. e.g. $logger-debug($hashref, dump_me);) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10444] In advanced search(more), [+] and [-] should behave like links on hover
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18906|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10444] In advanced search(more), [+] and [-] should behave like links on hover
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #11) I disagree with how the QA modification was implemented. Rather than adding onclick attributes, the existing jQuery click handlers should be modified to return false. Doing it that way is more consistent with our current push for unobtrusive Javascript. Yes of course, but nodes are generated after the load of the page. So I thought it would be difficult. But in fact no, I will resubmit patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10444] In advanced search(more), [+] and [-] should behave like links on hover
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18851|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10444] In advanced search(more), [+] and [-] should behave like links on hover
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18851|0 |1 is obsolete|| Attachment #18902|0 |1 is obsolete|| --- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18918 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18918action=edit Bug 10444 - In advanced search(more), [+] and [-] should behave like links on hover This patch add href=# to the [+] and [-] links for adding and removing search terms. It also defines its style so it doesn't show underlined. To test: - Browse your OPAC to Advanced Search and then More options. - The [+] and [-] don't change the cursor on hover - Apply the patch, reload and see the cursor changes - Functionality should remain unchanged Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10444] In advanced search(more), [+] and [-] should behave like links on hover
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 --- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18919 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18919action=edit Bug 10444: Fix prevent the default action on click -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10444] In advanced search(more), [+] and [-] should behave like links on hover
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10459] borrowers should have a timestamp
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 Laurence Lefaucheur laurence.lefauch...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=8926 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8926] deletedborrowers should have a timestamp
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8926 Laurence Lefaucheur laurence.lefauch...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10459 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10459] New: borrowers should have a timestamp
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 Bug ID: 10459 Summary: borrowers should have a timestamp Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcha...@gmail.com Reporter: laurence.lefauch...@biblibre.com We have a Drupal portal related with a Koha, with new borrowers exported from koha to Drupal every night It would be great if borrowers table had a timestamp, so that only modified borrowers can be exported to portal during update process. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #69 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #68) Actually, I'm wrong, the database updated is needed to change it to a 'choice' with the choice values, but the actual preference value should not be updated. I think the simple solution would be to remove the database update, which is superfluous, and breaks the functionality. Yes! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #70 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18920 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18920action=edit Bug 7825: Updatedatabase should only change the type and options values. The value field should not be change. We have to keep '1' for 'yes' and '' for 'no'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #71 from Jonathan Druart jonathan.dru...@biblibre.com --- Switch back to NSO but maybe it is not necessary to retest of the feature just for the DB change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #110 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #109) (In reply to comment #108) The point of my counter proposal was that we do not need another module, we can add some lines to context.pm using Log4perl and not have another module to maintain ourselves. Humm, I don't think it is a good argument. A module with unit tests is easiest to maintain than a module like C4::Context (~1000l) :) Chris, I think that Jonathan has a point here. Maintaining a small and clear coded module will not be a pain. The maintenance problems will not be in this kind of module, but in complex modules and scripts dealing with circulation among others. But if Log4Perl is a better choice, it sounds like that it could replace LogLite rather easy? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #111 from Chris Cormack ch...@bigballofwax.co.nz --- (In reply to comment #109) (In reply to comment #108) Hi Chris, The point of my counter proposal was that we do not need another module, we can add some lines to context.pm using Log4perl and not have another module to maintain ourselves. Humm, I don't think it is a good argument. A module with unit tests is easiest to maintain than a module like C4::Context (~1000l) :) We still have to maintain C4::Context, and now a new module, it feels hugely like reinventing the wheel for the 13th time and I still don't like it. We probably will have to agree to disagree on this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 --- Comment #8 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 18921 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18921action=edit Bug 8868: ILS-DI: CancelHold needs to take a reserve_id (follow-up) - Fix the text in the ilsdi.pl?service=Describeverb=CancelHold page - Unit tests for CancelReservedFromId and GetReserve - Do not delete row in reserves table if insert in old_reserves fails -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #9 from Julian Maurice julian.maur...@biblibre.com --- 1, 2, and 3 fixed ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #16527|Bug 8868: ILS-DI: |[SIGNED-OFF] Bug 8868: description|CancelHold needs to take a |ILS-DI: CancelHold needs to |reserve_id |take a reserve_id -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10272] CheckReserves returns not respecting ReservesControlBranch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18907|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18922 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18922action=edit Bug 10272 - CheckReserves returns not respecting ReservesControlBranch CheckReserves is using the CircControl system preference to determine what patrons an item can fill a hold for. It should be using ReservesControlBranch instead. Test Plan: 1) Create an item at Library A, place holds for it for patrons at Library B, Library C, and Library A in that order, for pickup at the patrons home library. 2) Make sure the holds policy for Library A is set to Hold Policy = From home library and Return Policy = Item returns home. Make sure the holds policies for the other libraries are set to Hold Policy = From any library. 3) Check the item in at Library C, the hold for the patron at Library B should pop up, even though it's in violation of the circulation rules. Don't click the confirm button! 4) Apply this patch, and reload the page, now the hold listed should be for the last hold, the hold for the patron at Library A, which is correct. This patch adds the subroutine C4::Reserves::GetReservesControlBranch as an equivilent to C4::Circulation::_GetCircControlBranch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10272] CheckReserves returns not respecting ReservesControlBranch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272 --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Last patch changes the expected number of tests (4 to 6). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10458] Remove obsolete Z3950 module and test
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10458 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Patch complexity|--- |Trivial patch Severity|normal |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8064] Merge several biblio records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 --- Comment #12 from mathieu saby mathieu.s...@univ-rennes2.fr --- I applied 9755, then 8064. I launched perl updatedatabase.pl for creating the new syspref. I put 20 records in a list and merge them. Everything works fine : - all items are moved, - holds and checkouts are not lost, - I could move some fields of merged records in destination record - I could remove some fields of reference record from destination record - the report table is nice Ex : with Syspref MergeReportFields 200af,210a,600 the result is : Biblionumber 200$a 200$f 210$a 606$2 606$3 606$9 606$a 606$x 606$y 606$z I have only one comment, regarding the syspref and its description : example: '001,245ab,600' displays: value of 001 subfields a and b of fields 245 all subfields of fields 600 Maybe the mention of 001 should be removed, as your report table always contains a first column with biblionumber. (I assume here 001 always contains biblionumber. Maybe it is not the case everywhere?) But this is a detail, so I sign off. M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #5 from Kyle M Hall k...@bywatersolutions.com --- I'm afraid I cannot reproduce your issue with this patch. I've tested it using both location and ccode, and checked the revert by 1) Disabling the course the item is part of 2) Deleting the item reserve from the course 3) Deleting the course itself ( and thus all reserves for the course ). Kyle (In reply to comment #4) Okay, in that case the fix doesn't work for me. I changed ccode to non-fiction when putting the item into course reserves, and when I removed it from course reserves, ccode remained non-fiction. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8064] Merge several biblio records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added Attachment #18840|0 |1 is obsolete|| --- Comment #13 from mathieu saby mathieu.s...@univ-rennes2.fr --- Created attachment 18923 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18923action=edit [SIGNED OFF] Bug 8064: Merge several biblios -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8064] Merge several biblio records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #72 from Kyle M Hall k...@bywatersolutions.com --- The db change does not alter the behavior of the patch set, so I don't believe it needs to be signed off separately. It's more of a qa followup. (In reply to comment #71) Switch back to NSO but maybe it is not necessary to retest of the feature just for the DB change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18878|0 |1 is obsolete|| Attachment #18879|0 |1 is obsolete|| Attachment #18920|0 |1 is obsolete|| --- Comment #73 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18924 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18924action=edit bug_7825: Sign off Changed OPACItemHolds syspref to be no|tes|force choice Amended opac-reserve.tt accordingly Signed-off-by: Delaye Stephane stephane.del...@biblibre.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18924|0 |1 is obsolete|| --- Comment #74 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18925 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18925action=edit Bug 7825: Followup prevent submission without choosing an item + Fix some ergonomic issues in opac-reserve Signed-off-by: Delaye Stephane stephane.del...@biblibre.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #76 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18927 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18927action=edit Bug 7825: Followup prevent submission without choosing an item + Fix some ergonomic issues in opac-reserve Signed-off-by: Delaye Stephane stephane.del...@biblibre.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #77 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18928 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18928action=edit Bug 7825: Updatedatabase should only change the type and options values. The value field should not be change. We have to keep '1' for 'yes' and '' for 'no'. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18925|0 |1 is obsolete|| --- Comment #75 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18926 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18926action=edit bug_7825: Sign off Changed OPACItemHolds syspref to be no|tes|force choice Amended opac-reserve.tt accordingly Signed-off-by: Delaye Stephane stephane.del...@biblibre.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #78 from Kyle M Hall k...@bywatersolutions.com --- Everything looks good, though we still have a lack of a decent commit message. Perhaps this will do: Currently, the Koha system preference OPACItemHolds allows a library system to choose to allow patrons to place bib and item level holds from the OPAC, or to allow patrons only to place bib level holds only from the opac. This patch set adds a third option, force, which *requires* that patrons place item level holds from the opac, with no option of making a bib level hold. This patch modifies the system preference OPACItemHolds to be of the type Choice, with the choices being no, yes, force. The patch does not alter the currently set value of OPACItemHolds for database updates, only adding the additional option. Test Plan: 1) Set OPACItemHolds to no. Check that OPAC holds behave as it is now (no Place On column, no Select a specific copy table, making a reserve is successful) 2) Set OPACItemHolds to yes. Check that OPAC holds behave as it is now ( Place On column is there, Select a specific copy table shows when A specific copy is selected, making a reserve is successful) 3) Set OPACItemHolds to force. Check that OPAC holds behave as follows: - no Place On column is present - Select a specific copy table is opened - making a reserve is successful -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10460] New: wait to stop a run away report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10460 Bug ID: 10460 Summary: wait to stop a run away report Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcha...@gmail.com Reporter: neng...@gmail.com Right now the only way to stop a runaway report is to go in to the command line. It would be great if there were a button that the librarian could hit on the reports page to kill a report that's taking too long to run. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10461] New: tax not taken in to account in the acq budget summaries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461 Bug ID: 10461 Summary: tax not taken in to account in the acq budget summaries Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All URL: acqui-home.pl OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com On acqui-home.pl the budget summary is not taking in to account tax rate at all. The code looks something like this: SELECT SUM( COALESCE(unitprice, ecost) * quantity ) AS sum FROM aqorders WHERE budget_id = ? AND quantityreceived 0 AND datecancellationprinted IS NULL Plus SELECT SUM(shipmentcost) AS sum FROM aqinvoices WHERE shipmentcost_budgetid = ? AND closedate IS NOT NULL Tax rate should be included in this to give an accurate count of what has been spent/ordered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #16729|0 |1 is obsolete|| --- Comment #33 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18929 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18929action=edit Bug 7639 - system preference to forgive fines on lost items Forgive fine when an item is set to lost status, fines are forgiven only when syspref ForgiveFineWhenLost is set to yes. Item can be set to lost status from: catalogue/moredetail.pl cataloguing/additem.pl tools/batchMod.pl misc/cronjobs/longoverdue.pl Changed sub C4::Circulation::LostItem to forgive fines on the item depending on the value of syspref ForgiveFineWhenLost. This sub is currently used to return an item and charge a replacement cost. Also added a new syspref in C4::Circulation::LostItem - ChargeReplFeeWhenLost. Replacement fee will now be charged only if this syspref is set to yes. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #16730|0 |1 is obsolete|| --- Comment #34 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18930 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18930action=edit Bug 7639 - system preference to forgive fines on lost items - QA Followup Test Plan: 1) Apply the patch 2) Run updatedatabase.pl 3) Set WhenLostForgiveFine to Forgive WhenLostChargeReplacementFee to Charge 4) Issue an item to a borrower, then set to lost from catalogue/moredetail.pl 5) Observe the replacement fee has been charged 6) Return the item 7) Observe the charged fee has been forgiven 8) Set WhenLostForgiveFine to Don't Forgive 9) Repeat 4-6 10) Observe the charged fee has not been forgiven 11) Set WhenLostChargeReplacementFee to Don't Charge 12) Repeat 4 13) Observe that a fee was not charged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5349] Moving an order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #16499|0 |1 is obsolete|| --- Comment #62 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 18931 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18931action=edit [SIGNED-OFF] Bug 5349: Order line transfers Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5349] Moving an order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #16500|0 |1 is obsolete|| --- Comment #63 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 18933 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18933action=edit [SIGNED-OFF] Bug 5349 follow-up: run transferorder.pl in a popup Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5349] Moving an order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #65 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 18935 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18935action=edit Bug 5349: Add unit tests for TransferOrder -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5349] Moving an order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #16501|0 |1 is obsolete|| --- Comment #64 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 18934 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18934action=edit [SIGNED-OFF] Bug 5349: Fix a logical test in TransferOrder Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #16731|0 |1 is obsolete|| --- Comment #35 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18932 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18932action=edit Bug 7639 tiny QA follow-up no need to create a variable just to call to send it as parameter the line after -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5349] Moving an order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7308] new column in admin/aqbudgets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 --- Comment #18 from Julian Maurice julian.maur...@biblibre.com --- I do not reproduce these errors. Here's what I've done: $ git checkout -b bug/7308 git fetch origin git reset --hard origin/master $ git bz apply 7308 Bug 7308 - new column in admin/aqbudgets Bug 7308: Show ordered amount in aqbudgets.pl Apply? [yn] y Applying: Bug 7308: Show ordered amount in aqbudgets.pl Bug 7308: rework aqbudgets.pl table Apply? [yn] y Applying: Bug 7308: rework aqbudgets.pl table $ perl -cw admin/aqbudgets.pl admin/aqbudgets.pl syntax OK $ git log --oneline -3 ebd30fe Bug 7308: rework aqbudgets.pl table 72e2c0a Bug 7308: Show ordered amount in aqbudgets.pl acd4b21 Bug 10311 - Holds queue ignores item-level holds where only one items exists $ perl -v | head -n2 This is perl, v5.10.1 (*) built for x86_64-linux-gnu-thread-multi Looking at the source file, the code looks good too. Could you retry please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10462] New: Some optimizations in Z3950 search paving the way for enhancements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 Bug ID: 10462 Summary: Some optimizations in Z3950 search paving the way for enhancements Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: m.de.r...@rijksmuseum.nl Reporter: m.de.r...@rijksmuseum.nl CC: m.de.r...@rijksmuseum.nl In order to achieve the goals of the older bug 6536, this proposed patch refactors some code in Z3950 search. Behavior does not change; should be somewhat faster though. This patch also disables batch record counts for Z3950 search records; these counts are not used anywhere in Koha. It prepares removal of the z3950random column, which also is of no use. This report should be followed by SRU targets, and XSLT processing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #18896|0 |1 is obsolete|| --- Comment #21 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 18937 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18937action=edit Bug 9312: whitespace cleanup for picture-upload.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #18895|0 |1 is obsolete|| --- Comment #20 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 18936 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18936action=edit Bug 9312: strict perl for picture-upload.pl use of Modern::Perl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #18897|0 |1 is obsolete|| --- Comment #22 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 18938 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18938action=edit Bug 9312: fix a couple more uninitialized variable warnings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Enhancements: SRU targets, MARC conversion, additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10462 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 --- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18939 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18939action=edit Bug 10462: Some optimizations in Z3950 search paving the way for enhancements Refactors Z3950Search. Disable batch record counts for z3950 records. Test plan: Do various Z3950 searches on multiple targets from Cataloging and Acquisition. Behavior should not have changed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |ASSIGNED See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=6536 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Enhancements: SRU targets, MARC conversion, additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #6924|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Enhancements: SRU targets, MARC conversion, additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #6920|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Enhancements: SRU targets, MARC conversion, additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #6919|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Enhancements: SRU targets, MARC conversion, additional XSLT processing (umbrella report)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Summary|Z3950 Enhancements: SRU |Z3950 Enhancements: SRU |targets, MARC conversion, |targets, MARC conversion, |additional XSLT processing |additional XSLT processing ||(umbrella report) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Enhancements: SRU targets, MARC conversion, additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #13462|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Enhancements: SRU targets, MARC conversion, additional XSLT processing (umbrella report)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #26 from M. de Rooy m.de.r...@rijksmuseum.nl --- Bug 10462 paves the way for reviving this development. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10463] New: Quote of the day feature not selecting random quotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10463 Bug ID: 10463 Summary: Quote of the day feature not selecting random quotes Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: dr...@bywatersolutions.com When the Quote of the Day tool selects a new new quote, it updates the timestamp and does not take the timezone into account. Thus the time is set to +4 hours (e.g. 2013-06-11 13:33:48 when the time is 2013-06-11 09:33:48). It then repeats the same quote every day. To replicate: set Administration System preferences OPAC preferences Features QuoteOfTheDay to Enable In Home Tools Quote Editor, add several quotes. In the opac, refresh the home page. You should get a quote of the day at the top. mysql select * from quotes; note the timestamp of the quote selected by the tool. It will not match the date on the machine. If you change the date to the previous date and refresh the opac, the tool wlill select another quote, which will not change unless forced. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10463] Quote of the day feature not selecting random quotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10463 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18940 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18940action=edit Bug 10463 - Quote of the day feature not selecting random quotes When the Quote of the Day tool selects a new new quote, it updates the timestamp and does not take the timezone into account. Thus the time is set to +4 hours (e.g. 2013-06-11 13:33:48 when the time is 2013-06-11 09:33:48). It then repeats the same quote every day. To replicate: set Administration System preferences OPAC preferences Features QuoteOfTheDay to Enable In Home Tools Quote Editor, add several quotes. In the opac, refresh the home page. You should get a quote of the day at the top. mysql select * from quotes; note the timestamp of the quote selected by the tool. It will not match the date on the machine. If you change the date to the previous date and refresh the opac, the tool wlill select another quote, which will not change unless forced. Test Plan: 1) Remove all your quotes and import a fresh set 2) Enable the quote of the day and view the opac 3) Look at your quotes table and note the timestamp is incorrect 4) Repeat steps 1 and 2 5) Look at your quotes table and note the timestamp is now correct -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10463] Quote of the day feature not selecting random quotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10463 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10463] Quote of the day feature not selecting random quotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10463 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|oleon...@myacpl.org |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10463] Quote of the day feature not selecting random quotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10463 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC||k...@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8991] Add a script to delete old orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8991 --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #7) Hi Marcel and Galen, I only wonder if you should only delete from aqorders and if receiveddate should be the date to trigger the action. It is the request from our customer. Why not delete baskets? Now we can be stuck with empty baskets. Would you really want to delete orders from an open basket or a basket that has not been received fully? I will provide a new patch in order to delete empty closed baskets. Personally, I would go for a job that deletes inactive baskets (closed and all received) with creationdate as trigger. E.g. I could annually delete all inactive baskets, created more than one year ago or something. It could be a great improvement. (In reply to comment #9) I agree that if one is deleting from acqorders, one should also delete the relevant baskets. Yep, will be done. The original bug report said: We need a script to delete old orders To which I ask: why? Is there a specific way in which the old orders are getting in the way? Is there a regulatory requirement that's satisfied by purging old orders? It is a need for some customers to delete old orders. I suppose it is to avoid to have too many orders. After a time, it becomes useless to keep all of them. I'm not trying to be difficult, but I do think that sometimes it's better for this sort of maintenance to be done via SQL rather than a script. At least when you're staring at the 'mysql' prompt, you likely know that you're about to do something potentially dangerous. Yes but with a cronjob, it is easily to call a script rather than execute a sql query. I suggest that the purge job should produce an output file with the complete contents of the rows it deletes. The following patch will add a 'confirm' flag. Maybe it fixes this problem? All of that said, ultimately, somebody who runs a script called 'purge_orders.pl' presumably will have an idea of what they're in for, so I will push this patch in a day or two, though with a follow-up to add a dry run mode. However, I would appreciate it if the original patch submitter could respond to Marcel's and my questions and comments. I hope I answered to all of your questions. (In reply to comment #10) Also, I question the notion of this script existing as a _cronjob_. Is the idea really to run it automatically? I think misc/maintenance is a better home for this script. The idea is to run the job all nights (or weeks/months/...), so yes it is a cronjob. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8991] Add a script to delete old orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8991 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18603|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18941 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18941action=edit Bug 8991: New cronjobs script: purge_orders The script takes a '-until' parameter and deletes all orders received before this date. If baskets exist without order, they will delete too. If the script is called without the confirm flag, nothing is done and the output contains all actions to do. Execute purge_orders.pl -h for more details. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8991] Add a script to delete old orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8991 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Passed QA |Needs Signoff --- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com --- Since I completely rewrite this patch, I switch back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8662] Remove unused famfamfam icons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #16 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7441] search results showing wrong branch?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #51 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18942 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18942action=edit Bug 7441 - search results showing wrong branch? - Followup - Fix XSLT for option homebranch + syspref description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10010] Use jQueryUI Accordion to display constraints in MARC subfield editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10010] Use jQueryUI Accordion to display constraints in MARC subfield editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #17382|0 |1 is obsolete|| --- Comment #6 from Owen Leonard oleon...@myacpl.org --- Created attachment 18943 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18943action=edit [SIGNED-OFF] Bug 10010 - Use jQueryUI Accordion to display constraints in MARC subfield editor The jQueryUI Accordion widget, included by default in Koha, is well-suited to handle the kind of show/hide actions which are used in the MARC subfield editor. This patch replaces the custom-writted JS with jQueryUI JS and markup. To test, load the tag subfield editor: Admin - MARC frameworks - MARC structure - Subfields - Edit. Confirm that basic, advanced, and other contraints panels are show/hidden correctly. Confirm that tabs work, and that edit operations are not disrupted. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 al...@cctexas.com changed: What|Removed |Added CC||al...@cctexas.com --- Comment #36 from al...@cctexas.com --- I have tested this and it works as planned. I would like to sign this patch off in my name. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
