[Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Magnus Enger from comment #15) I started testing this, but never got very far. Here are a couple of observations, though: - After clicking on Built-in offline circulation interface for the very first time I get: You have records in the offline circulation database on this computer, but they may not be current: Patron records were last synced on: (never) Item records were last synced on: (never) Circulation records were last synced on: (never) You have transactions in the offline circulation database on this computer that have not been uploaded. which seems to indicate I have used these features before, which I have not. I confirm I got this message for the first time too! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9757] Make staff client list contents view more like search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18945|0 |1 is obsolete|| Attachment #19231|0 |1 is obsolete|| --- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 19240 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19240action=edit Bug 9757 [Revised] Make staff client list contents view more like search results This patch revises the staff client list contents view to better match staff client search results, showing more information and offering more ways to interact with the contents than before. - List contents output has been modified so that the staff client can use XSLT-formatted data just as the OPAC can. As in the OPAC it depends on XSLTResultsDisplay being enabled. - A toolbar has been added which is similar to that in search results, offering the option to add items to a Cart, add them to a different list, place multiple holds, remove items from the list, or merge records. - This toolbar has been made to float on scroll like the one on the MARC edit page. - Library and shelving location have been added to the display of call numbers. Call numbers are linked to a search as they are in search results. - Edit links are included just as they are in search results. - Automatic focus on the add by barcode form has been removed so that the page doesn't jump to the bottom unnecessarily. - basket.js's addMultiple function has been modified so that it receives an array of checkboxes rather than looking for checkboxes in a specific form. This helps abstract its functionality for use on both search results and lists. results.tt is modified accordingly. - The page layout has been widened to make room for the increased amount of information on the page. - A new merge icon has been added to the default Bootstrap sprite. To test: - View both public and private lists in the staff client. - View lists with and without contents. - Test the functionality of options in the toolbar: Add to cart, add to lists, place multiple holds, remove items, merge items. - Test with users with and without cataloging privileges to confirm that catalog-related controls are correctly shown or hidden. - Test with XSLTResultsDisplay set both to default and empty. - Since the staff client and OPAC use some of the same code, test that lists in the OPAC have not broken. - Since JavaScript was modified which affects both lists and search results, confirm that adding items to the Cart and Lists from search results hasn't been broken by this patch. Revision corrects conditional display of hold link, hiding it in cases where there are no items or the record's itemtype is not for loan. Also corrected is the behavior of the Cart/List save button in order to prevent it from submitting the remove items action which is the default for the form. Signed-off-by: jmbroust jean-manuel.bro...@univ-lyon2.fr Edit: Patch rebased against current master and hard-coded paths to /prog/ corrected. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9757] Make staff client list contents view more like search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 --- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 19241 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19241action=edit Bug 9757: Remove duplicated action buttons. Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9757] Make staff client list contents view more like search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #24 from Jonathan Druart jonathan.dru...@biblibre.com --- Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10237] Enforce authorized value character limitations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10237
--- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Jonathan Druart from comment #8)
(In reply to comment #5)
Hm, thinking more about this - there are values where this won't work so
nicely - one of them is MANUAL_INV. The code is the value that will be shown
for your custom fee type and therefore enforcing upper case, no spaces and
no umlauts would not be good.
I confirm that many values contain spaces (I found '|', '(', ')', '-', '/'
too).
Marked as Failed QA.
Hum... forget that, I don't know how I found that...
On my side, I found SUGGEST and LOC:
installer/data/mysql/fr-FR/marcflavour/unimarc_lecture_pub/Obligatoire/framework_DEFAULT.sql:INSERT
INTO `authorised_values` (`id`, `category`, `authorised_value`, `lib`) VALUES
(144, 'SUGGEST', 'Pas assez de budget', 'Pas assez de budget');
installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql:INSERT INTO
`authorised_values` ( `category`, `authorised_value`, `lib`) VALUES ( 'LOC',
'Salle de lecture', 'Salle de lecture');
I think it is not correct and the authorised_value field should be a code. But
they exist as it in sample data.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10508] New: UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Bug ID: 10508 Summary: UT: C4::Branch.pm needs unit tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: gmcha...@gmail.com Reporter: kenza.z...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 kenza kenza.z...@biblibre.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |kenza.z...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 kenza kenza.z...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 kenza kenza.z...@biblibre.com changed: What|Removed |Added CC||kenza.z...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10509] New: Using updates instead of inserts in translated mysql files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 Bug ID: 10509 Summary: Using updates instead of inserts in translated mysql files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl CC: gmcha...@gmail.com Currently, all languages in installer/data/mysql contain a few subfolders with .sql files mostly containing insert statements. There is a lot of redundancy and maintaining this construction is more work. I propose to use en (English) as a global folder, or even a separate folder global (with English just being one of the languages). The global folder should contain inserts; these sql files should be run first. The translation folder should update only the descriptions etc. This is based on a recent discussion on the dev list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10509] Using updates instead of inserts in translated mysql files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | --- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl --- I am attaching two example patches (they are not completely ready for signoff yet, but they already work). The first patch uses en as global folder and updates the de-DE/mandatory sql files as an example. The second patch uses a new global folder next to the en folder. I will ask for some feedback on the dev list about both approaches. The second approach has a maintenance drawback: we need to maintain updates in the en folder, but the advantage is: it is simpler to add a new language. And it is easier to do specific 'English language' stuff without disturbing the global approach. (Stopwords is obsolete?, but could be an example of it.) The work is done in such a way that we can progressively update all files in the language folders without breaking the current installation process. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7368] General staff client typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Blocks||10509 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10509] Using updates instead of inserts in translated mysql files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Depends on||7368 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10509] Using updates instead of inserts in translated mysql files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 --- Comment #2 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 19242 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19242action=edit Bug 10509: Using updates instead of inserts in translated mysql files This patch makes changes to C4/Installer to allow running global (English) sql inserts before updating them from the specific language file. This patch touches only de-DE/mandatory to illustrate the concept. All language installs should proceed as usual. Test plan: Test the English install and test the German install. If you do not feel confident, check another one too :) Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Verified that the German install still functions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10509] Using updates instead of inserts in translated mysql files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 --- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 19243 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19243action=edit Bug 10509: Introducing a global folder next to the English folder Adds a global subfolder in installer/data/mysql. The sql files in that folder are used as inserts. The language folder will be moved to update-style (incl. English). The English folder will be a translation basis. Test plan: Repeat your install now with English and German. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Verified that English and German still work with global folder. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10471] Global search input box and button geometry not always consistent (browsers, translations)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10471 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10491] Blank PDF export
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10491 Chris Nighswonger cnighswon...@foundations.edu changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #11 from Chris Nighswonger cnighswon...@foundations.edu --- No problem. I think we've all been there at least once and probably many times! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl --- From a glance through code, I feel that this routine fixup_cardnumber is still quite confusing and complicated. Should it really be done this way? With compliments for your hard work, but is it true that we spend so much effort on this only because we want to see a cardnumber already before hitting the Save button? Why not simplify it by disabling the cardnumber and probably also the login code fields for Insert Patron, generating them when saving the record and just displaying them after that? Note that e.g. we do not have a biblionumber too before saving a biblio record, etc. (Some other fields like 001, 005 are also finalized only when saving.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10509] Using updates instead of inserts in translated mysql files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509
Zeno Tajoli z.taj...@cineca.it changed:
What|Removed |Added
CC||z.taj...@cineca.it
--- Comment #4 from Zeno Tajoli z.taj...@cineca.it ---
Hi to all,
after thinking about, I prefer the second approch.
But in the language-specific files you can't have only update.
We need to permitt also delete and insert.
For example in italian sql setup we don't want those two classification
('sudocs', 'SuDoc Classification (U.S. GPO)', 0, 'generic')
('anscr', 'ANSCR (Sound Recordings)', 0, 'generic')
And we also will add this one
('indire', 'Classificazione INDIRE', 0, 'generic')
But I think it is still possible with this patch
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10509] Using updates instead of inserts in translated mysql files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 --- Comment #5 from M. de Rooy m.de.r...@rijksmuseum.nl --- Zeno, it will still be possible to do that (with both methods). jcamins mentioned on irc that we have also 'en' in the templates, why create global here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10509] Using updates instead of inserts in translated mysql files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509
--- Comment #6 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Other points from irc discussion:
Why not use SOURCE in the sql files to refer to english?
Or use a file like 'usesupdates' in the lang folder to tell the installer to
run english first?
-- idea borrowed from Evergreen
CREATE FUNCTION i18n(str TEXT) RETURNS TEXT DETERMINISTIC
RETURN str;
-- then mark up insert statements with the strings we want to translate
INSERT INTO `userflags` VALUES(9,'editcatalogue',i18n('Edit Catalog (Modify
bibliographic/holdings data)'),0);
-- the i18n() bit is just syntactical sugar to make it easy to extract strings
for a POT file
-- then code (to be written) would create the language-specific inserts from
the PO files
INSERT INTO `userflags` VALUES(9,'editcatalogue','Katalogdaten ändern (Titel-
und Bestandsdaten ändern)',0);
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10509] Using updates instead of inserts in translated mysql files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 --- Comment #7 from Zeno Tajoli z.taj...@cineca.it --- Well, theoreticaly I prefer a neutral 'global' dir with all standard setup and many different dirs (en, en-US, it-IT, etc) with oly translation and little specific changes. But it si only a preference, I can use every solution. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 --- Comment #11 from M. Tompsett mtomp...@hotmail.com --- (In reply to M. de Rooy from comment #10) Apologies for the reordering of your commentary. :) With compliments for your hard work, but is it true that we spend so much effort on this only because we want to see a cardnumber already before hitting the Save button? No, the reason I did this is because of FIXME comments in places like C4::Input.pm and because the gap is larger in some places (like the above example) than others. Any chance of duplicates, no matter how small (in my opinion), is bad. Why not simplify it by disabling the cardnumber and probably also the login code fields for Insert Patron, generating them when saving the record and just displaying them after that? I suppose we could disable or not display them if they are auto-generated, but if there is no auto-generation, we need to field visible and able to be entered. This would solve the skip generation problem, and make me much happier. But isn't whether to display or disable outside the scope of the initial problem? That is, limiting cardnumber generation to just before save is different than preventing duplicates, though it does overlap. Note that e.g. we do not have a biblionumber too before saving a biblio record, etc. (Some other fields like 001, 005 are also finalized only when saving.) And I think that this idea of limiting in the case of auto-generation is a good one. It solves the fake skip problem (out of boredom hitting refresh). From a glance through code, I feel that this routine fixup_cardnumber is still quite confusing and complicated. Should it really be done this way? However, this patch (or something that at least serializes) is still necessary, because of the time gap between generation and insertion. Even if we shrink that gap, we don't eliminate the possibility of duplicates. This patch does. The reason this patch is complicated is to deal with the off-chance that someone attempts to generate a number, but the server crashes, before the calculated next value is inserted back into the sequence table. That would leave the previous value not calculated. This is why there is the loop, before returning the calculated value for the my_UID record. You will also note that this particular number (it's really a string for the 'katipo' value of checkdigit), can't be generalized as hoped for in bug 10478, because checkdigit is a cardnumber system preference. I really appreciate the feedback. I hope this reply makes sense. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9113] batch modification removes +
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9113 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added CC||fridolyn.som...@biblibre.co ||m --- Comment #2 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- I'm on a patch. See http://stackoverflow.com/questions/1373414/ajax-post-and-plus-sign-how-to-encode And http://www.w3schools.com/jsref/jsref_encodeuricomponent.asp -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10510] New: OPAC's renew selected link has glitchy icon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 Bug ID: 10510 Summary: OPAC's renew selected link has glitchy icon Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org Created attachment 19244 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19244action=edit Screenshot of the affected image The OPAC image sprite lacks enough whitespace between the renew selected image and the following image to display correctly, resulting in a glitchy-looking image. The sprite should be modified to make more room. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10379] koha-rebuild-zebra gets noisy if no instances are defined
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10379 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #7 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Robin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9113] batch modification removes +
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9113 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9113] batch modification removes +
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9113 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |fridolyn.som...@biblibre.co ||m --- Comment #3 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 19245 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19245action=edit Proposed patch See commit comment. (very tricky bug :D ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10502] Add independent branches option for sql reports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- Odd, I had no problems applying this patch to the latest master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9757] Make staff client list contents view more like search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9757 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #25 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Owen! Here's a thought for a possible enhancement (or possibly bugfix, if there's anybody who was relying on the default focus prior to this change): would it make sense to move the add item by barcode form to the floating toolbar? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454
--- Comment #12 from Galen Charlton gmcha...@gmail.com ---
(In reply to M. Tompsett from comment #11)
From a glance through code, I feel that this routine fixup_cardnumber is
still quite confusing and complicated. Should it really be done this way?
However, this patch (or something that at least serializes) is still
necessary, because of the time gap between generation and insertion. Even if
we shrink that gap, we don't eliminate the possibility of duplicates. This
patch does.
The reason this patch is complicated is to deal with the off-chance that
someone attempts to generate a number, but the server crashes, before the
calculated next value is inserted back into the sequence table. That would
leave the previous value not calculated. This is why there is the loop,
before returning the calculated value for the my_UID record.
I too am suspicious of the complexity of this approach. I fully agree that
improving concurrency is a worth goal, but I think the task of get a reliable
sequentially-assigned integer can be *much* simpler.
Here's a bit of code that provides an example. It runs with the MySQL's
documented suggestion for emulating sequences [1]. If you create the table as
per the script's prep() function, then run as many multiple copies of the
script as you care to simultaneously, you won't get any repeats.
If this is wrapped up in a module, and possibly tweaked a bit to allow more
than one sequence to be defined, it could be nicely generalized.
I don't feel that we should be concerned about false skips ... if a staff user
gets a cardnumber value but doesn't use it... so what?
[1]
http://dev.mysql.com/doc/refman/5.5/en/information-functions.html#function_last-insert-id
___BEGIN___
#!/usr/bin/perl
use Modern::Perl;
use C4::Context;
my $dbh = C4::Context-dbh();
### only need to run prep() once
###prep();
$dbh-{AutoCommit} = 0;
my $max = $ARGV[0] || 10;
foreach my $i (0..$max) {
my $val = fetch_next();
print got $val\n;
}
sub prep {
$dbh-do('DROP TABLE IF EXISTS sequence');
$dbh-do('CREATE TABLE sequence (id INT NOT NULL) ENGINE myisam');
$dbh-do('INSERT INTO sequence VALUES (0)');
}
sub fetch_next {
$dbh-do('UPDATE sequence SET id=LAST_INSERT_ID(id+1)');
my $sth = $dbh-prepare('SELECT LAST_INSERT_ID()');
$sth-execute();
my @val = $sth-fetchrow_array();
return $val[0];
}
___END___
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10510] OPAC's renew selected link has glitchy icon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 19246 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19246action=edit Bug 10510 - OPAC's renew selected link has glitchy icon The renew selected link on the list of a user's checkouts looks bad because the next icon in the sprite shows through. This patch modifies the sprite to give it proper spacing and corrects the CSS to accommodate the change. To test, apply the patch, clear your browser cache, and view the following pages to confirm that the change works: - With TagsEnabled and TagsInputOnList enabled, view a search results page when logged in and when not logged in. Tag links should be styled correctly. - With OpacBrowseResults enabled, open the detail page for any record and click the browse shelf link. The forward and back arrows should be styled correctly. - With OpacRenewalAllowed enabled, log in to the OPAC and view your checked out items. The renew selected and renew all links should look correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10510] OPAC's renew selected link has glitchy icon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454
--- Comment #13 from Galen Charlton gmcha...@gmail.com ---
Here's a version that shows that one can store multiple sequences in a single
table and add new ones at will:
___BEGIN
#!/usr/bin/perl
use Modern::Perl;
use C4::Context;
my $dbh = C4::Context-dbh();
### only need to run prep() once
###prep();
$dbh-{AutoCommit} = 0;
my $max = $ARGV[0] || 50;
foreach my $i (0..$max) {
my $val = fetch_next('id1');
print got $val for sequence 1\n;
next unless 0 == ($i % 3);
$val = fetch_next('id2');
print got $val for sequence 2\n;
}
sub prep {
$dbh-do('DROP TABLE IF EXISTS sequence');
$dbh-do('CREATE TABLE sequence (id INT NOT NULL, seq varchar(10) NOT NULL)
ENGINE myisam');
$dbh-do('INSERT INTO sequence VALUES (0,id1)');
$dbh-do('INSERT INTO sequence VALUES (0,id2)');
}
sub fetch_next {
my $seq = shift;
$dbh-do('UPDATE sequence SET id=LAST_INSERT_ID(id+1) WHERE seq = ?', {},
$seq);
my $sth = $dbh-prepare('SELECT LAST_INSERT_ID()');
$sth-execute();
my @val = $sth-fetchrow_array();
return $val[0];
}
___END___
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #17999|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 19247 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19247action=edit Bug 10215 - Increase the size of opacnote and librariannote for table subscriptionhistory We have librarians that are regularly hitting the maximum number of characters for the note fields in subscription history. They would like to be able to store at least 1000 characters here. Converting the varchar(150) to text should do it. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add public and private notes to a subscription history entry where each note is greater than 150 characters. 4) Save and view the notes, the notes should not be truncated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 --- Comment #14 from Galen Charlton gmcha...@gmail.com --- As a point of information, I also tried using DBIx::Sequence. Pros of using DBIx::Sequence: - It works, in the sense that using a bunch of concurrent processes to fetch sequence values will get unique IDs. - It appears to be DBMS-agnostic Cons: - Under high simultaneous load, it is *significantly* slower to retrieve sequence values because of the way it implements spin-locking. - It doesn't expose a way to explicitly initialize a sequence to a given value. - The semantics of its Currval method are wrong -- ideally Currval() should stay stable within a session, but DBIx::Sequence-Currval() can change if another process fetches a value from the sequence. On balance, I prefer a roll-our-own because of the first two cons. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215
--- Comment #7 from Galen Charlton gmcha...@gmail.com ---
Comment on attachment 19247
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19247
Bug 10215 - Increase the size of opacnote and librariannote for table
subscriptionhistory
Review of attachment 19247:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=10215attachment=19247)
-
::: C4/Serials.pm
@@ +483,4 @@
$subs-{startdate} = format_date( $subs-{startdate} );
$subs-{histstartdate} = format_date( $subs-{histstartdate} );
$subs-{histenddate} = format_date( $subs-{histenddate} );
+$subs-{opacnote} . q{} =~ s/\n/\br\/\/g;
$ perl -c C4/Serials.pm
Can't modify constant item in substitution (s///) at C4/Serials.pm line 486,
near s/\n/\br\/\/g;
C4/Serials.pm had compilation errors.
A patch that causes a module to fail to compile is an automatic Failed QA.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8798] Add the use of DBIx::Class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #82 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 19249 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19249action=edit DBIx::Class Branch.pm implementation This package, and the test implement CRUD for Branches table. Very basic, but proves we can do many things in a few lines ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8798] Add the use of DBIx::Class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #83 from Paul Poulain paul.poul...@biblibre.com ---
Created attachment 19250
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19250action=edit
DBIx::Class tests: replacing GetBranchName by it's DBIx::Class equivalent
In this patch, I choose to overload the C4/Branch.pm/GetBranchName by it's
DBIx::Class equivalent
It's just a POC, no need to commit this patch.
the question behind the patch is: should we
* REMOVE GetBranchName by replacing all the calls by
Koha::BusinessLogic::Branch-read({'branchcode' =
$branchcode})-first-branchname;
* overload the sub and make it die later
I think the 1st will require more effort, but better, while the second requires
less effort, but result in much less code cleaning
My preference would go to the 1st option.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8798] Add the use of DBIx::Class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #19137|0 |1 is obsolete|| Attachment #19138|0 |1 is obsolete|| Attachment #19139|0 |1 is obsolete|| Attachment #19140|0 |1 is obsolete|| Attachment #19141|0 |1 is obsolete|| --- Comment #81 from Paul Poulain paul.poul...@biblibre.com --- Created attachment 19248 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19248action=edit Added base class files for all tables in koha using the DBIx::Class::Schema::Loader Added a (very basic) test file for C4::Context Also added dependencies in required files. [Update]: changed dependencies fron dbic to dbix moved generation shell script to a perl script wtih arguments in misc/devel To Test: Install patch Make sure you can still connect to Koha you may optionally run the test script in comment 12 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798#c12 If you run this file you should get a DBIx dump of the borrowers table Done! Ammeded Dep version Signed-off-by: wajasu matted-34...@mypacks.net Signed-off-by: Chris Cormack chr...@catalyst.net.nz Bug 8798 - Add the use of DBIx::Class - Rename schema class updater updateDatabase.pl is a bit too close to updatedatabase.pl in installer and may cause some confusion. I would suggest update_dbix_class_files.pl as a unambiguous and descriptive name for this file. Signed-off-by: wajasu matted-34...@mypacks.net Signed-off-by: Chris Cormack chr...@catalyst.net.nz Bug8798 Updated to remove tabs Signed-off-by: wajasu matted-34...@mypacks.net Signed-off-by: Chris Cormack chr...@catalyst.net.nz Bug 8798 - Add the use of DBIx::Class - Followup - Update schema files Signed-off-by: Chris Cormack chr...@catalyst.net.nz Bug 8798 - Moving code to Koha::Database and adding tests - Fixing a bug .. ping does not exist we need to use connected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8798] Add the use of DBIx::Class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #84 from Paul Poulain paul.poul...@biblibre.com ---
Created attachment 19251
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19251action=edit
Testing DBIx::Class, continued
I tried to replace the GetBranchesLoop() call in C4/Auth.pm
In my database, there is a branchname with a diacritic. Unfortunately, it's not
properly handled:
Institut Protestant de Th�ologie appears instead of Institut Protestant de
Théologie
If I force the page encoding to latin1, it appears correctly.
Investigating DBIx::Class documentation, I find a Using Unicode chapter in
DBIx::Class::Manual::Cookbook
which says:
MySQL supports unicode, and will correctly flag utf8 data from the
database if the mysql_enable_utf8 is set in the
connect options.
my $schema = My::Schema-connection('dbi:mysql:dbname=test',
$user, $pass,
{ mysql_enable_utf8 = 1} );
When set, a data retrieved from a textual column type (char, varchar,
etc) will have the UTF-8 flag turned on if
necessary. This enables character semantics on that string. You will
also need to ensure that your database / table /
column is configured to use UTF8. See Chapter 10 of the mysql manual for
details.
See DBD::mysql for further details.
This patch also adds the
+mysql_enable_utf8 = 1,# REQUIRED to handle properly utf8
line, but unfortunately, it does not fix the problem. ideas welcomed...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8798] Add the use of DBIx::Class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #85 from Paul Poulain paul.poul...@biblibre.com --- OK, I gave this patch a try, because DBIx::Class is where we want to go in the long term, so it's worth the effort (plus, I'm stuck in a train that is 2 hours late, soon 3 hours, so I will have 9 hours in a train...) QA comments : * I've squashed the 4 previous patches, it's much easy to read the code, the authorship is still here * I think the C4/Context.pm |1 - should be removed, it's just removing an empty line * unless i'm wrong, the t/Context.t | 10 + is not related to DBIx::Class. It's a good idea to have it, but please put it in another patch But's theres more: I wrote a patch to implement a 1st version of Branch.pm (BusinessLogic, DataObject, DB), then made 2 other patches to see how it behaves. It's nice handy. BUT : there's some diacritics in my database, and they're not properly handled. I thought I had found the solution, but got no success. This problem must be fixed before the initial patch is pushed. HTH -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10511] Odd behavior for messaging preferences with Talking Tech enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10511 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 19252 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19252action=edit Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled An error in the onclick for phone notices causes the Do not notify checkbox to be checked when the phone checkbox is checked. Also, checking Do not notify does not uncheck the phone checkbox. Test plan: 1) Enable TalkingTechItivaPhoneNotification 2) Browse to the new patron screen ( memberentry.pl ) 3) In the patron messaging preferences check the Phone checkbox 4) Not the do not notify checkbox is then checked 5) Uncheck the do not notify checkbox, and check the Email checkbox as well 6) Now check the do not notify checkbox, note the Phone checkbox remains checked 7) Apply this patch 8) Repeat steps 3-6, noting the odd behavior is no longer present -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10511] Odd behavior for messaging preferences with Talking Tech enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10511 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10511] Odd behavior for messaging preferences with Talking Tech enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10511 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10511] New: Odd behavior for messaging preferences with Talking Tech enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10511 Bug ID: 10511 Summary: Odd behavior for messaging preferences with Talking Tech enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com CC: gmcha...@gmail.com, kyle.m.h...@gmail.com An error in the onclick for phone notices causes the Do not notify checkbox to be checked when the phone checkbox is checked. Also, checking Do not notify does not uncheck the phone checkbox. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8798] Add the use of DBIx::Class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798
--- Comment #86 from Galen Charlton gmcha...@gmail.com ---
I'm not seeing UTF8-releated breakage -- try running this program after
applying the squashed patch. The output (not counting a DBIx::Class::Carp
about the nullability of borrowers.cardnumber that should be addressed at some
point) is correct:
Institut Protestant de Théologie
#!/usr/bin/perl
use Modern::Perl;
use Koha::Database;
my $database = Koha::Database-new();
my $schema = $database-schema();
my @branches = $schema-resultset('Branch')-search({ branchcode =
'IPT'})-all();
binmode(STDOUT, ':encoding(UTF-8)');
print $branches[0]-branchname();
print \n;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8798] Add the use of DBIx::Class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Attachment #19249|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8798] Add the use of DBIx::Class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Attachment #19250|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8798] Add the use of DBIx::Class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Attachment #19251|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10509] Using updates instead of inserts in translated mysql files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- I was working on another sql file and was tempted to introduce i18n() function to enable translation (in the near future I hope), but as I don't know when or where in the install process this function will be defined, do you think that as an interim solution it's possible to write something like drop function if exists i18n; create function i18n( str TEXT) returns text deterministic return str; in the file? BTW, I think that 'en' works as our global, so no need to add a new dir and less things to change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10488] New MARC21 authority tags and subfields should be propagated to non-default frameworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10488 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #19160|0 |1 is obsolete|| Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |bgkrie...@gmail.com --- Comment #4 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 19253 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19253action=edit Bug 10488 - New MARC21 authority tags and subfields should be propagated to non-default frameworks As proposed by the report creator, this patch rewites authorities_normal_marc21.sql using default authority framework to build all current authtypes. Then proceed to delete not relevant tags. It also updates default authority framework to last update (April 2013) adding new or updated tags/subtags. All new tags/subtags from Bug 9826 and this one are included in all authtypes. Deleted tags reflect current situation except for 7XX tags that I was tell must be present on all authtypes. Only for new installs To test: 1) Apply patch 2) Delete all authtypes exec in database delete from auth_types; delete from auth_tag_structure; delete from auth_subfield_structure; 3) Insert new auth framework 4) Verify absent tags. This can be done running select tagfield as from auth_tag_structure where authtypecode ='' and tagfield not in (select tagfield from auth_tag_structure where authtypecode = 'AUTH_TYPE') for each authtype ( UNIF_TITLE, TOPIC_TERM, etc.) The attached PDF could be used as a reference, all that is white or green for each authtype must be in the list (except for white 7XX tags) 5) Sign :) (can't upload using git-bz) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10512] New: Label PDF Export Corrupted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10512 Bug ID: 10512 Summary: Label PDF Export Corrupted Change sponsored?: --- Product: Koha Version: 3.12 Hardware: PC OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Label printing Assignee: cnighswon...@foundations.edu Reporter: d.ly...@thebeijingcenter.org Created attachment 19254 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19254action=edit Corrupted PDF I created a batch of 40 spine labels, but when I export it as a PDF the PDF is corrupted (see attached. I believe its a bad header, but I'm not certain). If I remove any item and export 39 items instead of 40, the PDF has no problems. At first I thought this was because one item was incorrectly formatted, but it appears to be arbitrary which item I remove. Is there a cache that needs to be cleared in the command line or something? I deleted all existing batches and redid the same batch and still had the same problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] False no items in search results [intranet]
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 --- Comment #9 from Doug Kingston d...@randomnotes.org --- This is an interesting observation Fridolyn. We are running 3.10.6. BIB_INDEX_MODE=dom. We have recently started seeing problems again with item records disappearing when the biblio record is updated. If you do a search, you will get back the matching biblios, and the modified one will show No items., but if you drill into the result, the item *is* displayed, so its in the Koha system. This happens with biblios that have a single item record. If I reindex with rebuild_zebra.pl -b -v -x then the item reappears in catalog searchs. Could it be that after the biblio change, an incomplete MARC record is exported for update? We are using the koha-index-daemon. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
