[Koha-bugs] [Bug 5766] Add configuration for excluding articles from jQuery table sorter

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5766

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5766] Add configuration for excluding articles from jQuery table sorter

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5766

--- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
After giving this some more thought it would be nice if this
could be in the configuration. Being able to translate the string
and influence sorting this way is a good start, but maybe not flexible
enough. For libraries with records in multiple languages they will
want to have a longer list they can adjust and not only a translation
for one language.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5766] Add configuration for excluding articles from jQuery table sorter

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5766

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #19438|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 19463
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19463action=edit
[PASSED QA] Bug 5766 - Add configuration for excluding articles from DataTables
sorting

Client-side table sorting should exclude articles like a, an, and
the when sorting by title. This patch adds a custom sorting plugin for
use by DataTables and a configuration line to the DataTables string
configuration file which can be translated for any language.

As an example, this patch modifies the patron checkout history template
to use the new sort on the title column.

To test, apply the patch and clear your browser cache to ensure the
revised JavaScript file is loaded. Sort the table by title. Titles
should be sorted regardless of the presences of a, an, or the at
the beginning of the title.

Signed-off-by: Chris Cormack chr...@catalyst.net.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Passes all tests and is a good improvement.
I have added German articles to the list for testing purposes
and it worked nicely.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9755] Record merge code needs to be refactored

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755

--- Comment #36 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I found a little something: For non-repeatable subfields, no warning is
triggered. I tested with 245$a and was able to create a record with 2 245$a
subfields without problems or warnings.
Warnings for control fields and non repeatable fields fields work nicely. Also
if a field is not existant in the new record and you want to add one of the
subfields you are warned.

I made sure I was using the default framework and 245$a was configured
correctly.

This is also on master but should be fixed - either here as a follow-up or on a
separate bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9755] Record merge code needs to be refactored

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755

--- Comment #39 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 19466
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19466action=edit
[PASSED QA] Bug 9755 QA follow-up: fix template compliance

Fix the following test failure:
* koha-tmpl/intranet-tmpl/prog/en/includes/merge-record.incFAIL
forbidden patterns  OK
tt_validFAIL
lines 10, 24
valid_template  OK

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Passes all tests and QA script.
Found a pre-existing problem with non-repeating subfields
that i noted on the bug report.
All other tests were ok and merging records worked nicely.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9755] Record merge code needs to be refactored

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9755] Record merge code needs to be refactored

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755

--- Comment #38 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 19465
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19465action=edit
[PASSED QA] Bug 9755 QA follow-up: move MARC-specific functionality to utility
class

This follow-up moves all the MARC-specific functionality of Koha::Record
(now renamed to Koha::MetadataRecord) to a Koha::Util::MARC utility class.

To test, run relevant unit tests:
 prove t/Koha_MetadataRecord.t t/Koha_Util_MARC.t 
 t/db_dependent/Koha_Authority.t
and optionally try to merge a record.

Signed-off-by: Mathieu Saby mathieu.s...@univ-rennes2.fr
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9755] Record merge code needs to be refactored

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #18446|0   |1
is obsolete||
  Attachment #18910|0   |1
is obsolete||
  Attachment #19038|0   |1
is obsolete||

--- Comment #37 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 19464
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19464action=edit
[PASSED QA] Bug 9755: Refactor record merge functionality

This patch refactors the merge record interface and code a little bit
in preparation for making it possible to merge authority records.

To test:
1) Apply patch.
2) Try merging two records:
a) Create a list.
b) Add two records you would like to (or be willing to) merge
   to said list.
c) View said list.
d) Check the checkboxes next to the two records you added.
e) Click Merge selected records.
f) Choose a merge reference.
g) Choose fields from each record that you want to keep.
h) Click Merge.
3) Confirm that your merged record has the fields and subfields you
   wanted.
4) Run the unit tests for the two files that were changed:
prove t/Koha_Record.t t/db_dependent/Koha_Authority.t
5) Sign off.

Signed-off-by: Mathieu Saby mathieu.s...@univ-rennes2.fr
Signed-off-by: Chris Cormack chr...@catalyst.net.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6588] Choose to delete some items on merge

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6588

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|merging records loses item  |Choose to delete some items
   |records!|on merge

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I am changing the bug report's title to make it less scary :) I just tested on
master and items moved over nicely.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10551] New: Merging records allows duplicaton of non-repeatable subfields

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10551

Bug ID: 10551
   Summary: Merging records allows duplicaton of non-repeatable
subfields
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: katrin.fisc...@bsz-bw.de
CC: jcam...@cpbibliography.com, m.de.r...@rijksmuseum.nl

To test:

- Add 2 records to a list
- Go to the list, select those 2 and merge them using the button on top
- Select either record as the destination record
- Select 245$a from the second tab to be also added to the record
- Verify no warning is given.
- Finish merge process.
- Verify that the new record shows 2 245$a subfields.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10551] Merging records allows duplicaton of non-repeatable subfields

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10551

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9755

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9755] Record merge code needs to be refactored

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10551

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10551] Merging records allows duplicaton of non-repeatable subfields

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10551

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hm and related to this... you can also save records with no 245$a at all, so no
checks on mandatory subfields are performed.

This is only related to 9755 as it appears on current master and after applying
the patches, there is no regression, but problemes should be fixed after the
refactoring patch has gone in.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10125] Babeltheque star image must use sprite

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10125

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA Comment:
This patch supposes that the Babeltheque ratings depends on OpacStarRatings. It
is false. I will provide a followup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10125] Babeltheque star image must use sprite

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10125

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 19468
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19468action=edit
Bug 10125: Babeltheque does not depend on OpacStarRatings.

We have to load star ratings js and css file if Babeltheque is enabled
and OpacStarRatings is disabled.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10125] Babeltheque star image must use sprite

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10125

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #19451|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 19467
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19467action=edit
Bug 10125 - Babeltheque star image must use sprite

When I removed images from the OPAC in favor of sprites I didn't take
into account the display of star ratings from Babeltheque. This patch
copies the star ratings display from Koha's own ratings display,
though it is not dependent on JavaScript.

I'm sure testing would be easy for someone with access to the
Babeltheque service, but I do not. I temporarily modified the template
to set some variables for testing purposes:

[% SET SEARCH_RESULT.score_int = 3 %]
[% SET SEARCH_RESULT.score_avg = 3 %
[% SET SEARCH_RESULT.num_scores = 87 %]

This enabled the display of the ratings, allowing me to confirm that
stars display correctly. Ratings should work with and without
OpacStarRatings enabled.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

I also fudged the template to test, so QA would need to be done with
someone with Babeltheque access

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10125] Babeltheque star image must use sprite

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10125

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com ---
These patchs can be test on
http://catalogue.master33-dev.biblibre.com/cgi-bin/koha/opac-search.pl?q=lila

Babeltheque is on and OpacStarRatings is off.

Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9410] Formatting of the discount field when doing a new order from new empty record is not correct

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
Ok, switch back to Signed Off and let someone else qa this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8360] Author facet not working

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8360

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m

--- Comment #6 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
I think this patch is not a solution.

We know the search with phrase structure (witch in implicit for Zebra)
sometimes does not work.

But using word list is wrong because it performs a search of words without
order. There can be problems with some facets, for example authors Pierre
JUSTE and Juste PIERRE. A click on a facet au,wrld=Pierre JUSTE will
return results with both authors.

Problems must be fixed in search engine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

--- Comment #35 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to Katrin Fischer from comment #34)
 Should we carry the existing typo to another column? wthdrawn - wthdrawn_on?

Yes, absolutely! I think it would be far more confusing to have one field named
correctly and one not. At least this way we have consistency. And, when I or
someone else get around to renaming the wthdrawn column, we can rename both at
once.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9252] Add option to send patron's home branch in AF field

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252

--- Comment #18 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19469
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19469action=edit
Bug 9252 - Add option to send patron's home branch in AF field - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9252] Add option to send patron's home branch in AF field

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7441] search results showing wrong branch?

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7441] search results showing wrong branch?

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #18942|0   |1
is obsolete||
  Attachment #19089|0   |1
is obsolete||
  Attachment #19090|0   |1
is obsolete||
  Attachment #19091|0   |1
is obsolete||

--- Comment #58 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19470
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19470action=edit
Bug 7441 - search results showing wrong branch

When you search in the OPAC it shows you the HOME branch on the location in
XSLT,
but if you click through to the detail page it shows you the HOLDING branch in
the holdings table which is very confusing to patrons.

Fixed by adding a system preference to choose whether to display the holding
branch or the home branch on the XSLT OPAC search results page.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

Rebased on current master (2013-01-31).

Signed-off-by: Chris Rohde cro...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7441] search results showing wrong branch?

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

--- Comment #59 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19471
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19471action=edit
Bug 7441: Followup search results showing wrong branch [UNIMARC]

Unimarc modifications

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Signed-off-by: Chris Rohde cro...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7441] search results showing wrong branch?

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19470|0   |1
is obsolete||
  Attachment #19471|0   |1
is obsolete||

--- Comment #60 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19472
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19472action=edit
Bug 7441 - Part 1 - search results showing wrong branch

When you search in the OPAC it shows you the HOME branch on the location in
XSLT,
but if you click through to the detail page it shows you the HOLDING branch in
the holdings table which is very confusing to patrons.

Fixed by adding a system preference to choose whether to display the holding
branch or the home branch on the XSLT OPAC search results page.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

Rebased on current master (2013-01-31).

Signed-off-by: Chris Rohde cro...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7441] search results showing wrong branch?

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

--- Comment #61 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19473
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19473action=edit
Bug 7441 - Part 2 - Followup search results showing wrong branch [UNIMARC]

Unimarc modifications

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Signed-off-by: Chris Rohde cro...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7441] search results showing wrong branch?

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

--- Comment #63 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19475
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19475action=edit
Bug 7441 - Part 4 - search results showing wrong branch? - Followup - Fix XSLT
for option homebranch + syspref description

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7441] search results showing wrong branch?

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

--- Comment #62 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19474
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19474action=edit
Bug 7441 - Part 3 - search results showing wrong branch? - Followup - Use
syspref for XSLT and non-XSLT

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

Comment: Applied all patches. Tested with and without XLST display.
Works as described. No errors.
Not tested with UNIMARC

Signed-off-by: Chris Rohde cro...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7441] search results showing wrong branch?

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

--- Comment #64 from Kyle M Hall k...@bywatersolutions.com ---
At some point the patches got out of order. I've reuploaded them in the
corrected order and added numbering to the patch titles.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10543] false mandatory warning in additem

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543

--- Comment #4 from Kyle M Hall k...@bywatersolutions.com ---
Test plan from patch:

Test plan :
- In a framework, make sure you have in item field :
  An optionnal subfield (without authorised value) then a mandatory subfield
then an optional subfield next to mandatory subfield
  For example : $i (optional), $r (mandatory) and $s (optional)
- Open a biblio record and create a new item
- Enter more than 100 characters in $i, fill $r and $s
- Click Add item
- Edit this item
= You get a textarea for $i
- Empty $s and Save
= Without patch, you get a warning and form is not saved and you see that $s
is yellow while it should be $r
= With patch, form is saved
- Re-edit this item
- Empty $r and save
= You get a warning and form is not saved

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973

--- Comment #36 from acow...@daviscollege.edu ---
Sorry for the delay, extended holiday break and just getting back into the
swing of things. Here's my koha-conf.xml that is working after reverting this
patch. 

useldapserver1/useldapserver!-- see C4::Auth_with_ldap for extra configs
you must add if you want to turn this on --
 ldapserver id=ldapserver listenref=ldapserver

hostnameldap://SERVER NAME/IP/hostname

baseDC=DOMAIN,DC=DOMAIN EXT/base

userCN=Users name,OU=Sub OU,OU=Sub OU,OU=Sub
OU,OU=Sub OU,dc=DOMAIN,dc=DOMAIN EXT/user  !-- DN, if not
anonymous --

passUSERS PASSWORD/pass !-- password, if not anonymous --

replicate1/replicate !-- add new users from LDAP to Koha database
--

update1/update !-- update existing users in Koha database --

auth_by_bind1/auth_by_bind !-- set to 1 to authenticate by binding
instead of password comparison, e.g., to use Active Directory --

principal_name%s/principal_name !-- optional, for auth_by_bind: a
printf format to make userPrincipalName from koha userid --

mapping !-- match koha SQL field names to your LDAP record field
names --

  firstname is=givenname/firstname

  surname is=sn /surname

  address is=streetAddress/address

  city is=l/city

  state is=st/state

  country is=c/country

  branchcode is=BRANCH CODE ATTRIBUTE IN ADDEFAULT BRANCH
CODE/branchcode

  userid is=userPrincipalName/userid

  password is=/password

  email is=mail/email

  categorycode is=DEFAULT CATEGORY CODE ATTRIBUTEDEFAULT
CATEGORY CODE/categorycode

  cardnumber is=CARD NUMBER ATTRIBUTE/cardnumber
/mapping

  /ldapserver


---

To note, we authenticate by using email addresses, so for the userid, I used
the userPrincipalName and changed the principle_name to
principal_name%s/principal_name instead of what most talk about doing
principal_name%s@domain name  ext/principal_name. I did try the common
way of using the sAMAccountName for the userid attribute and using
%s...@domain.ext for principal_name and that way worked as well.

I also started testing under LDAP:// to be able to sniff out the problem, but
will be testing under LDAPS://, but don't expect a problem, will update if it
doesn't work after testing.

Thanks for your attention to this matter!

Aaron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973

acow...@daviscollege.edu changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9288] Add a script to test SIP from the command line

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288

--- Comment #14 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19476
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19476action=edit
Bug 9288 - Add a script to test SIP from the command line - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9288] Add a script to test SIP from the command line

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #15 from Kyle M Hall k...@bywatersolutions.com ---
Galen, is this what you are looking for? I have no idea why strictures weren't
enabled, my bad! I've also made the message terminator configurable from the
command line, defaulting to CRLF.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9411] Multiple uses of javascript eval on ajax responses in acq.js

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9411

--- Comment #11 from Kyle M Hall k...@bywatersolutions.com ---
Since the patch in question doesn't change the behavior of Koha ( at least in
theory ) it would be as simple as 
1) Perform some action that tests the code to be modified
2) Apply this patch
3) Perform the same action, ensure everything still works the same.

What that the action or actions are, is up to you.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10311] Holds queue ignores item-level holds where only one items exists

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10311

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #8 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Pushed to 3.10.x, will be in 3.10.8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10125] Babeltheque star image must use sprite

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10125

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #8 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks Owen and Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9519] Wrong language code for Italian in the advanced search language limitations

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9519

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #4 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Sonia!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6281] Bug in LCC sort routine

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6281

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #20 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Pushed to 3.10.x, will be in 3.10.8

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

--- Comment #13 from Galen Charlton gmcha...@gmail.com ---
(In reply to Jonathan Druart from comment #10)
 (In reply to comment #9)
  (In reply to comment #8)
   (In reply to comment #6)
I'm still getting failures:
   
   Are these tests pass with the master's ut file?
  
  No. Isn't that the point of the patch, that the unit tests should pass even
  if there isn't any data for them?
 
 Yes of course, but in fact the only data I create is the borrower. So if the
 DB contains at least 1 borrower, this patch is useless.

That's a little too strong of a requirement, IMO, as I, for one, and I suspect
most developers, would like to be able to run the DB-dependent tests in our
normal testing databases.

I rather suspect what Jared is running into is that his test database already
has a patron whose cardnumber is CARDNUMBER42.

I think that the requirement that tests should create their own data has a
more general expression: tests should make as few assumptions about the state
of the database as possible.  What this means in this specific case is that
the cardnumber for the patron created for this test should be set in such a way
as to be guaranteed unique for that test run.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #14 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Jonathan!

I've also pushed two follow-ups, one to wrap the tests in a transaction and
another to remove the hard-coded patron cardnumber, which doesn't need to be
set to any specific value for the tests to work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10552] New: OpacAddMastheadLibraryPulldown preference missing from OPAC login page

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10552

Bug ID: 10552
   Summary: OpacAddMastheadLibraryPulldown preference missing from
OPAC login page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org

If you have the OpacAddMastheadLibraryPulldown system preference enabled the
library pulldown does not show on the OPAC login page. The preference is made
available by Auth.pm to all other pages in the OPAC but not login.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10552] OpacAddMastheadLibraryPulldown preference missing from OPAC login page

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10552

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Also missing: UseCourseReserves, reviewson, LibraryNameTitle, and
OpacShowRecentComments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289

--- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Galen Charlton from comment #13)
  Yes of course, but in fact the only data I create is the borrower. So if the
  DB contains at least 1 borrower, this patch is useless.
 That's a little too strong of a requirement, IMO, as I, for one, and I
 suspect most developers, would like to be able to run the DB-dependent tests
 in our normal testing databases.

Currently nobody is able to launch them, and the goal is to launch tests with
sample data.
They don't insert patron, so I think we have to have some prerequisites.

 I rather suspect what Jared is running into is that his test database
 already has a patron whose cardnumber is CARDNUMBER42.

Yes, it was maybe to generic :)

(In reply to Galen Charlton from comment #14)
 Pushed to master.  Thanks, Jonathan!
 
 I've also pushed two follow-ups, one to wrap the tests in a transaction and
 another to remove the hard-coded patron cardnumber, which doesn't need to be
 set to any specific value for the tests to work.

Thanks for the followups!
But now tests fail if a borrower exists with a cardnumber == NULL (and I don't
have any idea how it's happen, but I got 1 in my DB :))

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10552] Several preferences missing from OPAC login page

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10552

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

Summary|OpacAddMastheadLibraryPulld |Several preferences missing
   |own preference missing from |from OPAC login page
   |OPAC login page |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289

--- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Jonathan Druart from comment #15)
 But now tests fail if a borrower exists with a cardnumber == NULL (and I
 don't have any idea how it's happen, but I got 1 in my DB :))

Forget that, they pass!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #45 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Bernardo and Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10522] Javascript error on acquisition pages: YAHOO is not defined

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10522

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #7 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4907] Suggestions organize by menu doesn't reflect current choice

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4907

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #8 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Katrin!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10549] ILS-DI should not use ISO-8851-9 encoding

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10549

--- Comment #1 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 19477
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19477action=edit
Bug 10549 ILS-DI should not use ISO-8851-9 encoding

This patch changes a few occurences of ISO-8859-1 to UTF-8 within the XML
generation of the ILS-DI module.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10448] Changing framework when cataloguing clears all fields

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10448

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #7 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, David!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10549] ILS-DI should not use ISO-8851-9 encoding

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10549

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

  Attachment #19477|0   |1
is obsolete||

--- Comment #2 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 19478
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19478action=edit
This patch changes a few occurences of ISO-8859-1 to UTF-8 within the XML
generation of the ILS-DI module.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5766] Add configuration for excluding articles from jQuery table sorter

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5766

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #6 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Owen!

However, I agree with Katrin that the translation subsystem isn't necessarily
the best place to configure this, for a couple reasons.  First, the language of
the catalog interface does not necessarily reflect all of the languages that
may be present in the bib data, and I can see a translator not getting the
point of translating a list of articles in Pootle.

I would lean towards either a system preference or even a separate table that
contains a list of articles (which would be useful in other contexts, e.g., a
bib editor plugin that sets the non-filing indicator automatically).

However, since such configuration hooks can readily be put in later, I've
decided to push the patch as is.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10552] Several preferences missing from OPAC login page

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10552

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10552] Several preferences missing from OPAC login page

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10552

--- Comment #2 from Owen Leonard oleon...@myacpl.org ---
Created attachment 19479
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19479action=edit
Bug 10552 - Several preferences missing from OPAC login page

Several system preference variables are unavailable to the OPAC login
template because they are not explicitly enabled for that page. Instead
of adding them to Auth.pm using the old method this patch uses the new
system preference check syntax using the Koha TT plugin.

The following preferences are now checked using this syntax in
masthead.inc:

OpacAddMastheadLibraryPulldown
UseCourseReserves
reviewson
OpacShowRecentComments

In order for the call in masthead.inc to the new plugin to work on all
OPAC pages [% USE Koha %] must be added to any template which
includes it (most of them).

Also in this patch: A change to Auth.pm to enable correct display of the
LibraryName in the title of the OPAC login page.

To test, turn on the above system preferences and confirm that the
relevant links appear under the OPAC's main search bar on all pages
including the login page.

Confirm that the text specified in the LibraryName system preference is
shown as the title of the login page.

Confirm that course reserves and comments are displayed correctly on the
biblio detail page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

--- Comment #36 from Galen Charlton gmcha...@gmail.com ---
(In reply to Kyle M Hall from comment #35)
 (In reply to Katrin Fischer from comment #34)
  Should we carry the existing typo to another column? wthdrawn - 
  wthdrawn_on?
 
 Yes, absolutely! I think it would be far more confusing to have one field
 named correctly and one not. At least this way we have consistency. And,
 when I or someone else get around to renaming the wthdrawn column, we can
 rename both at once.

I can't say I'm keen on a patch that intentionally adds a typo, even for the
sake of consistency.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

--- Comment #37 from Kyle M Hall k...@bywatersolutions.com ---
Ok, I'll file a bug to rename wthdrawn, update this patch, and make it depend
on the new bug. That should resolve all the issues at once.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10550] Fix database typo wthdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

  Attachment #19453|0   |1
is obsolete||

--- Comment #97 from Galen Charlton gmcha...@gmail.com ---
Comment on attachment 19453
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19453
Bug 7143: Updating history and about page

Pushed latest update to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10550] Fix database typo wthdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10550] Fix database typo wthdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19480
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19480action=edit
Bug 10550 - Fix database typo wthdrawn

This patch updates the wthdrawn field in items and deleteditems to be withdrawn
instead. No functional changes are made.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10550] Fix database typo wthdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19480|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19481
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19481action=edit
Bug 10550 - Fix database typo wthdrawn

This patch updates the wthdrawn field in items and deleteditems to be
withdrawn instead. No functional changes are made.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Depends on||10550

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10550] Fix database typo wthdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Blocks||9673

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #98 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 19482
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19482action=edit
Bug 7143 - Updating history and about page

First commit from Silvia Simonetti, went into the 3.12.x branch.

Regards
To+

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19120|0   |1
is obsolete||

--- Comment #38 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19483
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19483action=edit
Bug 9673 - Track when items are marked as lost or withdrawn

Add date fields to track when an item was marked as lost or withdrawn.
Display those fields on catalogue/moredetail.pl

Test Plan:
1) Apply patch
2) Run updatedatabase.pl
3) Pick a record with items, browse to the 'items' tab ( moredetail.pl )
4) Mark an item as lost, verify the field Lost on: displays below
   the Lost status field with todays date.
5) Mark the item as not lost, verify the field no longer displays
6) Repeat steps 4 and 5 with the Withdrawn field.

Signed-off-by: Mathieu Saby mathieu.s...@univ-rennes2.fr
Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19121|0   |1
is obsolete||

--- Comment #39 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19484
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19484action=edit
Bug 9673 - Track when items are marked as lost or withdrawn - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10550] Fix database typo wthdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Blocks|9673|
 Depends on||9673

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Blocks||10550
 Depends on|10550   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

--- Comment #40 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19485
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19485action=edit
Bug 9673 - Track when items are marked as lost or withdrawn - QA Followup 2 -
Change wthdrawn_on to withdrawn_on

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Blocks|10550   |
 Depends on||10550

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10550] Fix database typo wthdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Blocks||9673
 Depends on|9673|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19484|0   |1
is obsolete||

--- Comment #42 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19487
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19487action=edit
Bug 9673 - Track when items are marked as lost or withdrawn - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19485|0   |1
is obsolete||

--- Comment #43 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19488
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19488action=edit
Bug 9673 - Track when items are marked as lost or withdrawn - QA Followup 2 -
Change wthdrawn_on to withdrawn_on

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19483|0   |1
is obsolete||

--- Comment #41 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19486
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19486action=edit
Bug 9673 - Track when items are marked as lost or withdrawn

Add date fields to track when an item was marked as lost or withdrawn.
Display those fields on catalogue/moredetail.pl

Test Plan:
1) Apply patch
2) Run updatedatabase.pl
3) Pick a record with items, browse to the 'items' tab ( moredetail.pl )
4) Mark an item as lost, verify the field Lost on: displays below
   the Lost status field with todays date.
5) Mark the item as not lost, verify the field no longer displays
6) Repeat steps 4 and 5 with the Withdrawn field.

Signed-off-by: Mathieu Saby mathieu.s...@univ-rennes2.fr
Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19486|0   |1
is obsolete||

--- Comment #44 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19489
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19489action=edit
Bug 9673 - Track when items are marked as lost or withdrawn

Add date fields to track when an item was marked as lost or withdrawn.
Display those fields on catalogue/moredetail.pl

Test Plan:
1) Apply patch
2) Run updatedatabase.pl
3) Pick a record with items, browse to the 'items' tab ( moredetail.pl )
4) Mark an item as lost, verify the field Lost on: displays below
   the Lost status field with todays date.
5) Mark the item as not lost, verify the field no longer displays
6) Repeat steps 4 and 5 with the Withdrawn field.

Signed-off-by: Mathieu Saby mathieu.s...@univ-rennes2.fr
Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19487|0   |1
is obsolete||
  Attachment #19488|0   |1
is obsolete||

--- Comment #45 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19490
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19490action=edit
Bug 9673 - Track when items are marked as lost or withdrawn - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19489|Bug 9673 - Track when items |[SIGNED-OFF] Bug 9673 -
description|are marked as lost or   |Track when items are marked
   |withdrawn   |as lost or withdrawn

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10553] New: Public lists not available from OPAC login page

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553

Bug ID: 10553
   Summary: Public lists not available from OPAC login page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org

If as a non-logged-in user you try to access public lists from the lists button
on the OPAC login page it will say there are no public lists. In fact the list
of public lists is not made available to the login page by Auth.pm.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10553] Public lists not available from OPAC login page

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10553] Public lists not available from OPAC login page

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10553

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Created attachment 19491
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19491action=edit
Bug 10553 - Public lists not available from OPAC login page

If you are not logged in to the OPAC, looking at the login page, and you
click the Lists button to see public lists it says there are none. This
patch corrects Auth.pm so that it loads the list of public lists in this
situation.

To test you must have at least one public list. Make sure you are logged
out of the OPAC and visit the login page (/cgi-bin/koha/opac-user.pl).
Clicking the Lists button should show you a list of public shelves.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19490|0   |1
is obsolete||

--- Comment #46 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19492
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19492action=edit
Bug 9673 - Track when items are marked as lost or withdrawn - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5342] Serial claiming improvements

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

--- Comment #49 from Owen Leonard oleon...@myacpl.org ---
*** Bug 8186 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8186] Form structure problem in serials claims filter

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8186

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #5 from Owen Leonard oleon...@myacpl.org ---


*** This bug has been marked as a duplicate of bug 5342 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320

--- Comment #12 from Jesse Weaver jwea...@bywatersolutions.com ---
Created attachment 19493
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19493action=edit
Bug 10320 followup - Fix translation/CSS issues

This switches to the alternate method of displaying stars, and makes
the strings in the OverDrive JS translatable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133

--- Comment #4 from Jesse Weaver jwea...@bywatersolutions.com ---
Created attachment 19494
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19494action=edit
Followup to bug 8133 - fix JS escaping in data literals

There was some unescaped data being put into JS literals, which could
cause the calendar interface to fail to load.

Note for testing: Template::Plugin::JavaScript must be installed, either
from CPAN or libtemplate-plugin-javascript-perl.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

--- Comment #47 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Should we also be nice and update saved reports using wthdrawn?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10550] Fix database typo wthdrawn

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Should we also be nice and update saved reports using wthdrawn?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10554] New: Add more options to 'AllowSelfCheckReturns' syspref

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554

Bug ID: 10554
   Summary: Add more options to 'AllowSelfCheckReturns' syspref
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Self checkout
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m...@kohaaloha.com

This patch modifies the options of AllowSelfCheckReturns syspref

from a 2 option selection
 - 'allow patrons', dont allow patrons'

to a 3 option selection
 - 'allow all patrons', 'allow non-blocked patrons' , allow no patrons'


currently, a problem with the syspref behavior in Koha is that enabling the
'AllowSelfCheckReturns' syspref does *not* allow patrons with a 'block' to
return items via the SCO. (this is apparently by design, and not a bug)

however, some libraries do want to allow patrons to return items via the SCO
even if they have a 'block'

this patch adds this additional behavior, by adding a new option to the
syspref, but also retaining the existing syspref behavior

after the patch, there are 2 allow options
 - 'Allow all' allows all patrons to return items (including blocked patrons)
 - 'Allow non-blocked' allows only non-blocked patrons to return items 
 (note: this is the current 'allow' behavior)

the patch correctly 'upgrades' existing 'allow' selection to the new 'Allow
non-blocked' value. so, any existing 'allow' selection works as before

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns' syspref

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554

--- Comment #1 from Mason James m...@kohaaloha.com ---
to test these 3 syspref options...

1/
- set syspref to 'dont allow'
- issue an item to a patron
- attempt to return item via SCO,  return should FAIL

2/ 
- set syspref to 'allow all'
- issue an item to a patron
- attempt to return item via SCO, return should SUCCEED

3/
- set syspref to 'allow nonblocked'
- issue an item to a patron
- attempt to return item via SCO, return should SUCCEED

- issue an item to a patron, with a returndate of '2001-01-01'
(important: this will create an overdue item, that will put a 'block' on this
patron's account)
- attempt to return item via SCO, return should FAIL

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns' syspref

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554

--- Comment #2 from Mason James m...@kohaaloha.com ---
Created attachment 19495
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19495action=edit
Bug 10554 - Add more options to 'AllowSelfCheckReturns' syspref

This patch modifies the options of AllowSelfCheckReturns syspref

from a 2 option selection
 - 'allow patrons', dont allow patrons'

to a 3 option selection
 - 'allow all patrons', 'allow non-blocked patrons' , allow no patrons'

currently, a problem with the syspref behavior in Koha is that enabling the
'AllowSelfCheckReturns' syspref does *not* allow patrons with a 'block' to
return items via the SCO. (this is apparently by design, and not a bug)

however, some libraries do want to allow patrons to return items via the SCO
even if they have a 'block'

this patch adds this additional behavior, by adding a new option to the
syspref, but also retaining the existing syspref behavior

after the patch, there are 2 allow options
 - 'Allow all' allows all patrons to return items (including blocked patrons)
 - 'Allow non-blocked' allows only non-blocked patrons to return items
 (note: this is the current 'allow' behavior)

the patch correctly 'upgrades' existing 'allow' selection to the new 'Allow
non-blocked' value. so, any existing 'allow' selection works as before

--

to test these 3 syspref options...

1/
- set syspref to 'dont allow'
- issue an item to a patron
- attempt to return item via SCO,  return should FAIL

2/
- set syspref to 'allow all'
- issue an item to a patron
- attempt to return item via SCO, return should SUCCEED

3/
- set syspref to 'allow nonblocked'
- issue an item to a patron
- attempt to return item via SCO, return should SUCCEED

- issue an item to a patron, with a returndate of '2001-01-01'
(important: this will create an overdue item, that will put a 'block' on this
patron's account)
- attempt to return item via SCO, return should FAIL

http://bugs.koha-community.org/show_bug.cgi?id=10544

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns' syspref

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns' syspref

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Blocks||10358

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10358] add a syspref to allow BLOCKED patrons to return items, via the SCO

2013-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10358

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 Status|Needs Signoff   |RESOLVED
 Depends on||10554
 Resolution|--- |MOVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/