[Koha-bugs] [Bug 10735] koha-dump not working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10735 --- Comment #3 from Bert Burgemeister tre...@googlemail.com --- (In reply to Robin Sheat from comment #2) The best solution would be a fallback for the backup path. The fallback is already sort of implemented. It just doesn't work because xmlstarlet returns non-zero which kills koha-dump immediately due to its set -e setting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added QA Contact|paul.poul...@biblibre.com |katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10748] New: Add option to block return of lost items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748 Bug ID: 10748 Summary: Add option to block return of lost items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com It seems there is currently no way to block users from returning an item that has been marked as lost. We already have BlockReturnOfWithdrawnItems to block the return of withdrawn items, so something similar for lost items would make sense. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3849] Acq Permissions unclear
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849 --- Comment #5 from Nicole C. Engard neng...@gmail.com --- (In reply to Katrin Fischer from comment #4) order_manage Manage orders basket order_receive Manage orders basket Looks all the same? I just got a report of this from a library - they were confused - this is still an issue. Nicole -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10749] New: patron permissions typos
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10749
Bug ID: 10749
Summary: patron permissions typos
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Templates
Assignee: oleon...@myacpl.org
Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org
In Home Patrons Set permissions for {staff member}, it says
edit_patronsPerform
batch modifivation of patrons which should be edit_patronsPerform batch
modification of patrons
It also says budget_add_delAdd and delete budgets (but cant modify budgets)
which should be budget_add_delAdd and delete budgets (but can't modify
budgets)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #19654|0 |1 is obsolete|| Attachment #19655|0 |1 is obsolete|| Attachment #19656|0 |1 is obsolete|| Attachment #19657|0 |1 is obsolete|| --- Comment #46 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20436 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20436action=edit [PASSED QA] Bug 7639 - system preference to forgive fines on lost items Forgive fine when an item is set to lost status, fines are forgiven only when syspref ForgiveFineWhenLost is set to yes. Item can be set to lost status from: catalogue/moredetail.pl cataloguing/additem.pl tools/batchMod.pl misc/cronjobs/longoverdue.pl Changed sub C4::Circulation::LostItem to forgive fines on the item depending on the value of syspref ForgiveFineWhenLost. This sub is currently used to return an item and charge a replacement cost. Also added a new syspref in C4::Circulation::LostItem - ChargeReplFeeWhenLost. Replacement fee will now be charged only if this syspref is set to yes. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Alex Hatley al...@cctexas.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Testing notes on last patch in series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 --- Comment #47 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20437 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20437action=edit [PASSED QA] Bug 7639 - system preference to forgive fines on lost items - QA Followup Test Plan: 1) Apply the patch 2) Run updatedatabase.pl 3) Set WhenLostForgiveFine to Forgive WhenLostChargeReplacementFee to Charge 4) Issue an item to a borrower, then set to lost from catalogue/moredetail.pl 5) Observe the replacement fee has been charged 6) Return the item 7) Observe the charged fee has been forgiven 8) Set WhenLostForgiveFine to Don't Forgive 9) Repeat 4-6 10) Observe the charged fee has not been forgiven 11) Set WhenLostChargeReplacementFee to Don't Charge 12) Repeat 4 13) Observe that a fee was not charged Signed-off-by: Alex Hatley al...@cctexas.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 --- Comment #49 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20439 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20439action=edit [PASSED QA] Bug 7639 - system preference to forgive fines on lost items - QA Followup - Fix update description Signed-off-by: Katrin Fischer katrin.fischer...@web.de With these patches we now have 3 preferences that deal with fines/fees and lost items: Replacement price - On marking lost: WhenLostChargeReplacementFee - On return: RefundLostItemFeeOnReturn (preexisting) Overdue fines - On marking lost: WhenLostForgiveFine System preferences work according to their description. Further notes: - Patches pass all tests and QA script. - LostItem is changed and needs unit tests. All occurrences of LostItem have been changed. - Database update is ok. I had to fix the sysprefs.sql file that has been recently rewritten and alphabetized. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 --- Comment #48 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20438 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20438action=edit [PASSED QA] Bug 7639 tiny QA follow-up no need to create a variable just to call to send it as parameter the line after Signed off by: Alex Hatley al...@cctexas.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 --- Comment #50 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I couldn't find any problems with these patches, but I would _really_ like to see some unit tests/regression tests for LostItem before setting this to 'Passed QA'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10734] Add Publication Date Facet in Searching
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10734 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi David, the publication date range search on the advanced search page I think is based on 008 Date1 - so using 008 for the facet would make sense to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5202] Merge authority records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added QA Contact|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5202] Merge authority records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 --- Comment #15 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 20440 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20440action=edit Bug 5202: quiet warning $mergereference is not always defined, so we should check it is defined before checking its value. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5202] Merge authority records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 --- Comment #16 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 20441 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20441action=edit Bug 5202 QA follow-up: improve merge reference selection The link on the merge reference had been wrong, and framework types were not indicated when you were merging records of two types. This patch fixes those problems. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5202] Merge authority records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #20441|0 |1 is obsolete|| --- Comment #17 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 20442 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20442action=edit Bug 5202 QA follow-up: improve merge reference selection The link on the merge reference had been wrong, and framework types were not indicated when you were merging records of two types. This patch fixes those problems. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5202] Merge authority records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 --- Comment #18 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 20443 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20443action=edit Bug 5202 QA follow-up: correct license and POD errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5202] Merge authority records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5202] Merge authority records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20099|0 |1 is obsolete|| Attachment #20100|0 |1 is obsolete|| Attachment #20101|0 |1 is obsolete|| Attachment #20440|0 |1 is obsolete|| Attachment #20442|0 |1 is obsolete|| Attachment #20443|0 |1 is obsolete|| --- Comment #19 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20444 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20444action=edit [PASSED QA] Bug 5202: merge authorities from the authority file and reservoir This patch gives Koha the ability to merge authority records using the same interface used by bibliographic records, though slightly different methods for selecting which records to merge. The two ways to select records are as follows: 1) Records can be selected from authority search results by clicking the Merge link for two records. 2) Authority records can be merged from the reservoir by clicking the merge-related links in the Manage staged MARC batch screen. To test: 1) Apply patch. 2) Do a search for an authority record that will turn up multiple identical records (or at least two records that you don't mind merging). 3) Click the Merge link for the first record. 4) Click the Merge link for the second record. 5) Choose which fields from which record you want to appear in the resulting record. 6) Confirm that those are the fields that exist in the resulting record. 7) Stage an authority record (for example, an authority record you saved from your catalog. 8) Search for a record to merge with it using the Search for a record to merge in a new window link. 9) Merge these records, confirming that the resulting record (after going through the entire merging process) matches your expectations. 10) Set up a matching rule for authorities, and export an authority from your catalog that will match based on that rule. For MARC21, the following is a good choice for a rule: Matching rule code: AUTHPER Description: Personal name main entry Match threshold: 999 Record type: Authority record [Match point 1:] Search index: mainmainentry Score: 1000 Tag:100 Subfields: a 11) Stage the record you just exported, choosing the matching rule you just created. 12) Merge the record using the Merge link, confirming that the resulting record (after going through the entire merging process) matches your expectations. 13) Sign off. Signed-off-by: Chris Cormack chr...@catalyst.net.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de Testing notes on last patch in series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5202] Merge authority records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 --- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20445 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20445action=edit [PASSED QA] Bug 5202 QA follow-up: quiet warnings Due to massively incorrect data in the default authority frameworks, we were getting warnings about undefined values and spaces from checking which tab subfields/fields were displayed in. This patch eliminates those warnings. Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5202] Merge authority records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 --- Comment #22 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20447 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20447action=edit [PASSED QA] Bug 5202: Quiet warning $mergereference is not always defined, so we should check it is defined before checking its value. Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5202] Merge authority records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 --- Comment #21 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20446 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20446action=edit [PASSED QA] Bug 5202 QA follow-up 2: fix overeager error message When rebasing the patch for this, I accidentally moved the line setting the mergereference when merging from breeding to *before* I checked whether we were merging from breeding. Needless to say, this caused problems. This patch fixes that, and: * Makes the error translatable. * Adds a missing authtypesloop argument for the template. Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5202] Merge authority records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 --- Comment #23 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20448 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20448action=edit [PASSED QA] Bug 5202 QA follow-up: improve merge reference selection The link on the merge reference had been wrong, and framework types were not indicated when you were merging records of two types. This patch fixes those problems. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5202] Merge authority records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 --- Comment #24 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20449 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20449action=edit [PASSED QA] Bug 5202 QA follow-up: correct license and POD errors Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3134] Ability to selelct multiple reports to delete at once
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Owen, could you rebase your patch please? I tried but might have gone wrong somewhere. Would it be possible that you provide a unit test for the changed sub delete_report? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10750] New: Correct capitalization on suggestion form in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10750 Bug ID: 10750 Summary: Correct capitalization on suggestion form in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org There are a few strings not capitalized according to our rules in the OPAC suggestion form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10750] Correct capitalization on suggestion form in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10750 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10750] Correct capitalization on suggestion form in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10750 --- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20450 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20450action=edit Bug 10750: Correct capitalization on suggestion form in OPAC Create a new suggestion from your patron account in the OPAC. Verify that all strings are correctly capitalized on the form and submit buttons. - Copyright date - Standard number ... and other - Submit your suggestion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10751] New: Title should be mandatory for creating suggestions in staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10751 Bug ID: 10751 Summary: Title should be mandatory for creating suggestions in staff Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org When creating a suggestion in the staff interface, Title is not a mandatory field like in the OPAC. If you try to add a suggestion without a title it won't be saved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10752] New: Impossible to add 2 identical suggestions, but without any explanation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Bug ID: 10752 Summary: Impossible to add 2 identical suggestions, but without any explanation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org To reproduce: - Create a new suggestion, chose a short term as your title and copy it. - Leave all other fields of the suggestion form untouched. - Save your first suggestion. - Enter a second suggestion with the same title. It won't save and there is no error message or explanation given. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Fridolyn, it might be a separate bug, but it means that your follow-up does not
work - there is currently no way to have a suggestion which an empty
branchcode. When you don't allow the patron to pick the branch in the OPAC the
homelibrary will be used. When you create a suggestion for any library in
staff, the branchcode is _ANY_ - so your change to the SQL query will currently
have no effect:
+$query .= q{ AND (branchcode='' OR branchcode=?) };
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10753] New: Creating suggestions for 'Any library' uses _ANY as branchcode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Bug ID: 10753 Summary: Creating suggestions for 'Any library' uses _ANY as branchcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: fridolyn.som...@biblibre.com The staff interface allows creating suggestions for Any library. In this case the branchcode used in the suggestions table is _ANY_. I think this creates a few problem. I think one will be that we can't create a FK constraint on the branchcode for the suggestions table. It would also be more consistent with other code in Koha to use an empty branchcode for any library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Depends on||10753 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Blocks||10449 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10754] New: HomeOrHoldingBranch and CircControl are described identically in the system preference editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754 Bug ID: 10754 Summary: HomeOrHoldingBranch and CircControl are described identically in the system preference editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Created attachment 20451 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20451action=edit screenshot of system preference editor We have 2 system preferences that from their description in the system preferences editor do exactly the same thing, but offer different options: CircControl: Use the checkout and fines rules of ... - the library the item is from - the library the patron is from - the library you are logged in at HomeOrHoldingBranch: Use the checkout and fines rules of ... - the ibrary the item is from - the library the item was checked out from In the systempreferences table the description is different: CircControl: Used by Circulation to determine which branch of an item to check with independent branches on, and by search to determine which branch to choose for availability HomeOrHoldingBranch: Specify the agency that controls the circulation and fines policy Both preferences are used a multiple times in the code. I am currently not sure what the difference is. Bug 5159 also claims that CircControl is not only used when independentbranches is turned on. Can someone clarify and help updating the documentation? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9093] 008 forgetting what material type was chosen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 bondiurbano cost...@gmail.com changed: What|Removed |Added CC||cost...@gmail.com --- Comment #1 from bondiurbano cost...@gmail.com --- This happens in 3.12.3 too. Issue very claimed by staff users. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10078] show location facet for all
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10078 --- Comment #5 from David Cook dc...@prosentient.com.au --- (In reply to Katrin Fischer from comment #4) I am not sure every library will be happy about this change. If I am not mistaken combining the branches and the location facet will give you 'wrong' results as always all items are taken into account for the search result. So if you your items look like this: Item 1: Branch A, location C Item 2: Branch B, location D And you limit on Branch A and location D, the record will still be found. This will always happen when you combine item related facets. Maybe we need a way to hide this facet for libraries who don't want to offer it. It could be as simple as having ids for CSS or a pref that lets you specify which facets you want to show. I think the search could probably be improved using DOM, but I am not sure this has been done yet and it would also still not work for libraries using GRS-1. I'm not sure that I understand your example, Katrin. 1) If you limit on Branch A and location D, you should get no results in your scenario. 2) In what scenario would you be able to use both those facets? (Using the Advanced Search, you could, but that's unrelated to the facets.) If you choose Branch A from the Libraries facet, you would only be presented with location C as a Locations facet. If you choose location D, you would only be presented with Branch B as a Libraries facet. The only time where that would be different is if you had: Item 1 (Bib #1): Branch A, location C Item 2 (Bib #2): Branch B, location D Item 3 (Bib #1): Branch A, location D In that case, you could limit on Branch A and location D, and you would get a search result for Bib #1 showing item availability for Item 1 and Item 3. In that sense, I suppose that could be a type of wrong result, because you would only want to show availability for Item 3. I don't think it's an indexing issue though. From what I've seen so far, it seems to me that DOM and GRS-1 fill the same indexes, they just do it in different ways. In this case, I think the issue would be with how we're displaying items. If we want to limit what item availability shows up in the search results, we would need to start checking our limits when building item displays in the searchResults sub. I don't think that's really a blocker for this bug though, as I mentioned, that same incorrect item availability would still occur by doing a Branch + Location query in the Advanced Search. I think that would be a separate issue. That said, I'm certainly in favour of including facet IDs for CSS and/or using a system preference so that libraries can choose which facets to show. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10078] show location facet for all
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10078 --- Comment #6 from David Cook dc...@prosentient.com.au --- Jared did an excellent job just now in IRC of clarifying your example, Katrin :). I think the best option will probably be to hide the Location facet in some way (probably CSS). The problem I see with hiding Location based on singleBranch mode is that some libraries with a single physical branch might use several virtual branches, thus not wanting to use singleBranch mode, but still wanting to have the Location facet. I've actually just looked at the code, and all the facets already have IDs. Location's is location_id. Shall we set this back to Passed QA? Perhaps it might be an idea to open another bug report to look at building facets better? Perhaps we could pass the @limits into the getRecords sub, or extract limits from the query within the sub...perhaps by testing against existing limits our search/facets would narrow rather than presenting all options (even ones that might not be make sense/that are incorrect). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10734] Add Publication Date Facet in Searching
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10734 --- Comment #2 from David Cook dc...@prosentient.com.au --- (In reply to Katrin Fischer from comment #1) Hi David, the publication date range search on the advanced search page I think is based on 008 Date1 - so using 008 for the facet would make sense to me. Good point. I wonder how we should handle dates like or 190u or 19uu. Maybe it makes sense just to include definite completely numeric dates? Or maybe do a label for like Unknown and change the u to a question mark for other cases like 190? or 19??, perhaps? I wrote a little TT plugin a while ago to change codes into nice labels for the facets, which I think I mentioned to you, but the problem was that it had hardcoded strings :/. Is there a way of maybe using the language_descriptions table to use translated strings? We would run into the same problem with a record type facet. Actually...with record type...we could probably use authorized values like we have for item type and shelving location. I suppose that's not hardcoded but I suppose that probably still presents translation issues. Any ideas? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10755] New: Add Keyword as Phrase to staff client advanced search indexes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 Bug ID: 10755 Summary: Add Keyword as Phrase to staff client advanced search indexes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org Currently, there are ...as Phrase indexes for title, author, subject, corporate name, personal name, and conference name in the staff client. At the request of several librarians, this patch adds one for Keyword. While we have had some discussion/debate about the best way to go forward with the available indexes in the OPAC, there's really no reason not to include this one in the staff client, especially since your more advanced searchers are (possibly) going to be librarians using the staff interface. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10755] Add Keyword as Phrase to staff client advanced search indexes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 --- Comment #1 from David Cook dc...@prosentient.com.au --- Created attachment 20452 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20452action=edit Bug 10755 - Add Keyword as Phrase to staff client advanced search indexes This patch adds a Keyword as Phrase index to the search options in the staff client. Test Plan: 1) Go to the Advanced Search in the staff client and click on the Keyword drop-down list. 2) Note that there is only a Keyword not a Keyword as Phrase option 3) Apply the patch 4) Reload the Advanced Search 5) Note that there is now a Keyword as Phrase option as well If you want to test the functionality...it will depend on your catalogue data. Basically, a phrase search will allow you to find Keyword Adjacent To Keyword rather than a more scattershot search that finds the keywords regardless of their position to each other. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10755] Add Keyword as Phrase to staff client advanced search indexes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 David Cook dc...@prosentient.com.au changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10755] Add Keyword as Phrase to staff client advanced search indexes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10755 David Cook dc...@prosentient.com.au changed: What|Removed |Added Assignee|oleon...@myacpl.org |dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8752] Log circulation renewal
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8752 David Cook dc...@prosentient.com.au changed: What|Removed |Added CC||dc...@prosentient.com.au Assignee|amit.gu...@osslabs.biz |dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8752] Log circulation renewal
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8752 David Cook dc...@prosentient.com.au changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8752] Log circulation renewal
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8752 --- Comment #1 from David Cook dc...@prosentient.com.au --- Created attachment 20453 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20453action=edit Bug 8752 - Log circulation renewal Currently, circulation renewals are not being logged. This patch logs renewals under the Circulation module with an action of RENEW. At the moment, it relies on the IssueLog preference, but we could add a new syspref for RenewLog. Personally, I figure it's just a re-issue so I don't know that we need another preference, but system preferences are cheap, so if people think a follow-up is necessary, I'm open to the idea. Test Plan: 0) Turn on IssueLog and ReturnLog in the system preferences 1) Checkout an item 2) Note that there is a CIRCULATION ISSUE log entry 3) Renew that item 4) Note that there is NOT a log entry 5) Return that item 6) Note that there is a CIRCULATION RETURN log entry 7) Apply patch 8) Repeat Step #3 (i.e. renew that item). 9) Note that there is now a CIRCULATION RENEW log entry N.B. Logs can be viewed by directly querying the database, viewing the Modification Log for the patron attached to the checkout/renew/ return, or by viewing the logs in the Tools module using the item's itemnumber as the Object. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #19201|0 |1 is obsolete|| Attachment #20276|0 |1 is obsolete|| --- Comment #13 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 20454 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20454action=edit Bug 10333: Labels/t_Batch.t needs to create its own data prove t/db_dependent/Labels/t_Batch.t db_dependent/Labels/t_Batch.t .. 1/33 # Testing Batch-new() method. db_dependent/Labels/t_Batch.t .. ok All tests successful. Files=1, Tests=33, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.34 cusr 0.00 csys = 0.37 CPU) Result: PASS Signed-off-by: Srdjan srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 --- Comment #14 from Srdjan Jankovic srd...@catalyst.net.nz --- C4::Items::AddItemBatchFromMarc was failing (no records returned), I had no CPL branches. You may wish to add some check there, but om if you don't (it's that testing data bug request that is still being discussed). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10734] Add Publication Date Facet in Searching
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10734 --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Good point. I wonder how we should handle dates like or 190u or 19uu. Maybe it makes sense just to include definite completely numeric dates? Or maybe do a label for like Unknown and change the u to a question mark for other cases like 190? or 19??, perhaps? I think the second would make a bit more sense to me. I wrote a little TT plugin a while ago to change codes into nice labels for the facets, which I think I mentioned to you, but the problem was that it had hardcoded strings :/. Hm, not sure I remember. If the strings can be in an include or similar, we can translate them. Is there a way of maybe using the language_descriptions table to use translated strings? I think that would probably be the best option for a language facet. We would run into the same problem with a record type facet. I think it is solvable especially when the options and descriptions you want to have are somehow limited by the standard. Actually...with record type...we could probably use authorized values like we have for item type and shelving location. I suppose that's not hardcoded but I suppose that probably still presents translation issues. I always prefer template translation over using authorised values because the latter are one language only currently. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
