[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #36 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Kenza, I see a problem running the QA script - could you take a look at that? QA SCRIPT testing 1 commit(s) (applied to b341d4e 'Bug 10629 : Inappropriate uses of $st') FAILt/db_dependent/Branch.t OK pod OK forbidden patterns FAIL valid Using a hash as a reference is deprecated OK critic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #37 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Ah, I should mention, that I applied 10629 before this patch, following the dependency note. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #21 from Katrin Fischer katrin.fisc...@bsz-bw.de --- All the tests pass nicely, but there are a lot of warnings when you run the test with prove: Use of uninitialized value $calculated in substitution (s///) at /home/katrin/kohaclone/C4/Serials.pm line 985. Use of uninitialized value $pattern in numeric eq (==) at /home/katrin/kohaclone/C4/Serials.pm line 988. Maybe something for another bug? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #19953|0 |1 is obsolete|| --- Comment #22 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20585 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20585action=edit [PASSED QA] C4::Bookseller.pm need unit tests The tests are wrap in a transaction. NOTE: some tests should pass but doesn't because of incoherences in the code. These tests are in comments and preceded by FIXME Test plan: prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. 15/53 [Some warnings about uninitialised values] t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=53, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.46 cusr 0.03 csys = 0.51 CPU) Result: PASS http://bugs.koha-community.org/show_bug.cgi?id=10528 Signed-off-by: Srdjan srd...@catalyst.net.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de The new tests pass nicely, as do all old tests and the QA script. All patches marked as dependencies have been pushed to master already. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10630] DelBookseller's return value needs to be more explicit in C4::Bookseller.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10630] DelBookseller's return value needs to be more explicit in C4::Bookseller.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20203|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20586 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20586action=edit [PASSED QA] Bug 10630: DelBookseller's always returns undef in C4::Bookseller.pm This patch makes DelBookseller returns the number of supplier it has deleted or undef if nothing has been deleted. It also fixes a test which doesn't pass before in t/db_dependent/Bookseller.t To test: prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. 1/54 All tests successful. Files=1, Tests=54, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.48 cusr 0.02 csys = 0.52 CPU) Result: PASS Signed-off-by: Chris Cormack chr...@catalyst.net.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de Logical change and makes another test pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10630] DelBookseller's return value needs to be more explicit in C4::Bookseller.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Tested with patch for 10528 applied. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10640] ModBookseller needs more explicit return values in C4::Bookseller.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10640 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10640] ModBookseller needs more explicit return values in C4::Bookseller.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10640 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #19990|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20587 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20587action=edit [PASSED QA] ModBookseller needs more explicit return values in C4::Bookseller.pm Before, ModBookseller always returns undef. This patch modifies it in order to be more explicit. Now it returns : 1 - If a modification has been done 0E0 - If the given id doesn't exist undef - If no id given It also fix one of the tests which didn't pass before in t/db_dependent/Bookseller.t To Test: prove t/db_dependent/Bookseller.t Bookseller.t .. 1/54 [Some warnings about uninitialized values] t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=54, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.46 cusr 0.04 csys = 0.53 CPU) Result: PASS http://bugs.koha-community.org/show_bug.cgi?id=10640 Signed-off-by: Srdjan srd...@catalyst.net.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de Change is logical and passes new and old tests. Fixed the author line to have Kenza's correct email address. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10430] status filter not working in serial claims when translated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 --- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de --- This patch works nicely and the classes are correct, as every status can show up multiple times in this table. But I am a bit confused about Arrived and Stopped showing up in this list. I checked the code and I think the pull down of filters should only have: Missing, Expected, Late, and Claimed. - =head2 GetLateOrMissingIssues ... AND (serial.STATUS = 4 OR ((planneddate now() AND serial.STATUS =1) OR serial.STATUS = 3 OR serial.STATUS = 7)) From the reports help: 1 = Expected 2 = Arrived 3 = Late 4 = Missing 5 = Not Available 6 = Delete 7 = Claimed 8 = Stopped This patch only adds 'Stopped', the other status have been there before. I think this can be fixed in a follow up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10430] status filter not working in serial claims when translated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10766] Cataloging reservoir search broken if UseQueryParser is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10766 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20551|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20589 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20589action=edit [PASSED QA] Bug 10766: unbreak reservoir search when UseQueryParser is OFF To test: [1] Turn UseQueryParser off. [2] Ensure that your database has records in the reservoir. Performing a Z39.50 search will do this. [3] Perform a broad cataloging (i.e., cataloguing/addbooks.pl search). Note that results are returned from the main catalog but that no reservoir results are returned. [4] Apply the patch. [5] Perform the search again. This time, there should be both catalog and reservoir results. [7] Enable QueryParser. Perform the search again, and verify that the catalog and reservoir results are the same. Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de Patch works nicely, passes all tests, and the QA script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10766] Cataloging reservoir search broken if UseQueryParser is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10766 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9603] Fix layout of Patron Card Creator Layout screen for display in IE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de QA Contact||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Attachment #20542|0 |1
is obsolete||
--- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 20590
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20590action=edit
[PASSED QA] Bug 9924 - Simplify and rename patron card creator error message
include
The patron card creator error message include uses a non-standard method
for displaying error messages, and is poorly-named.
This patch converts the method of displaying error messages for various
patron card creator options to the standard one ('div class=dialog
alert') and renames the include file to make it clear that it relates
only to patron card creator operations.
To test, perform various operations:
- Go to 'manage images' and try to upload a file which exceeds the
500KBfile size limit
- Go to the edit batch page and manually append an error code to the
URL: /cgi-bin/koha/patroncards/edit-batch.pl?op=newerror=403
- Go to one of the manage pages and manually append an error code to the
URL:
/cgi-bin/koha/patroncards/manage.pl?card_element=profileerror=201
Correct display of an error message indicates that the include file is
being found.
Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Passes test plan, test suite and QA script.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9820] Missing space between 100/700 $a and $c (MARC21/XSLT)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9820 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9820] Missing space between 100/700 $a and $c (MARC21/XSLT)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9820 --- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20592 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20592action=edit [PASSED QA] Bug 9820 follow-up: fix a typo Although the XSLT template was renamed to nameABCQ, one instance of the old name (nameABCDQ) was not corrected. This patch corrects that. To test: Follow test plan on previous patch Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9820] Missing space between 100/700 $a and $c (MARC21/XSLT)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9820 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20117|0 |1 is obsolete|| Attachment #20118|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20591 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20591action=edit [PASSED QA] Bug 9820: display titles in MARC21 name headings better in XSLT mode Prior to this patch, if a 100/700 had a $c, it would be displayed with no space between the contents of $a and $c in XSLT mode. For example, 100 1#$aSeuss,$cDr. would be displayed as SeussDr The problem was caused by the original version of the stylesheets drawing a bit too much from the MARC21 to MODS transformation. To test: [1] In a MARC21 database, turn on XSLT display mode for staff and OPAC. [2] Create or identify a bib that has a 100 or 700 field with both a $a and a $c. [3] Before applying the patch, verify that the name is displayed in bib details and search results with the name and title squashed together. For example, SeussDr [3] After applying the patch, verify that the name displays in bib details and search results with a space and intervening punctuation between the name and the title. For example, Seuss, Dr. Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes test plan, works nicely. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10766] Cataloging reservoir search broken if UseQueryParser is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10766 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton gmcha...@gmail.com --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20454|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20593 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20593action=edit [PASSED QA] Bug 10333: Labels/t_Batch.t needs to create its own data prove t/db_dependent/Labels/t_Batch.t db_dependent/Labels/t_Batch.t .. 1/33 # Testing Batch-new() method. db_dependent/Labels/t_Batch.t .. ok All tests successful. Files=1, Tests=33, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.34 cusr 0.00 csys = 0.37 CPU) Result: PASS Signed-off-by: Srdjan srd...@catalyst.net.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10665] koha-index-daemon-ctl.sh dependency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10665 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Looks like a small change - is there an easy way to verify the effect? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10619] sco.css missing for CCSR OPAC templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10619] sco.css missing for CCSR OPAC templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20594 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20594action=edit [PASSED QA] Bug 10619 - sco.css missing for CCSR OPAC templates sco.css is not missing from CCSR, but some image paths in the CSS are incorrect, resulting in some missing images. This patch corrects those broken paths. This patch also hides the Cart/Lists/login region of the template which should not be visible in self checkout. To test, enable self-checkout and switch to the CCSR theme. Load a patron for self-checkout and confirm that images associated with buttons appear correctly: By the help link in the upper-right, on the 'Finish' button, etc. Try checking out an item which is already checked out to that patron to see more examples. Signed-off-by: Srdjan srd...@catalyst.net.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de CSS changes only, works nicely. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10619] sco.css missing for CCSR OPAC templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20054|0 |1 is obsolete|| Attachment #20594|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20595 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20595action=edit [PASSED QA] Bug 10619 - sco.css missing for CCSR OPAC templates sco.css is not missing from CCSR, but some image paths in the CSS are incorrect, resulting in some missing images. This patch corrects those broken paths. This patch also hides the Cart/Lists/login region of the template which should not be visible in self checkout. To test, enable self-checkout and switch to the CCSR theme. Load a patron for self-checkout and confirm that images associated with buttons appear correctly: By the help link in the upper-right, on the 'Finish' button, etc. Try checking out an item which is already checked out to that patron to see more examples. Signed-off-by: Srdjan srd...@catalyst.net.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de CSS changes only, works nicely. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10692] UT: Routines about transfers in C4::Circulation.pm need unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10692 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20158|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20596 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20596action=edit [PASSED QA] Bug 10692: Routines about transfers in C4::Circulation.pm need unit tests The tests are wrap in a transaction. NOTE: Currently, some tests should pass but don't because of incoherences in the code. These tests are in comments and preceded by FIXME. To test: prove t/db_dependent/Circulation_transfers.t t/db_dependent/Circulation_transfers.t .. ok All tests successful. Files=1, Tests=12, 18 wallclock secs ( 0.02 usr 0.01 sys + 0.37 cusr 0.06 csys = 0.46 CPU) Result: PASS Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10692] UT: Routines about transfers in C4::Circulation.pm need unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10692 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10699] DeleteBranchTransferLimits in C4/Circulation.pm needs return value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10699 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20198|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20597 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20597action=edit [PASSED QA] Bug 10699:DeleteBranchTransferLimits in C4/Circulation.pm needs return value This patch adds return values to DeleteBranchTransferLimits: 1 if a Transfer Limit is deleted undef if no parameters is given 0E0 if a wrong parameter is given More, it fixes and adds some tests in t/db_dependent/Circulation_transfers.t To test : prove t/db_dependent/Circulation_transfers.t t/db_dependent/Circulation_transfers.t .. ok All tests successful. Files=1, Tests=14, 19 wallclock secs ( 0.02 usr 0.01 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS Signed-off-by: Chris Cormack chr...@catalyst.net.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de Tested with patch for bug 10692 applied. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10699] DeleteBranchTransferLimits in C4/Circulation.pm needs return value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10699 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20599 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20599action=edit [PASSED QA] Bug 10710: (follow-up) perltidy new code Also, I prefer the use of parentheses for function calls, even when no arguments are being passed. One missed comma turns is(GetOfflineOperation, ...) into is(GetOfflineOperation ...) Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20349|0 |1 is obsolete|| Attachment #20350|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20598 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20598action=edit [PASSED QA] Bug 10710: add unit tests for OfflineOperation's routines in C4/Circulation.pm This patch test AddOfflineOperation,GetOfflineOperation and DeleteOfflineOperation in C4/Circulation.pm. The tests are wrapped in a transaction. Note: Currently, GetOfflineOperations is not tested because we cannot mock C4::Context-userenv in unit tests To test: prove t/db_dependent/Circulation_OfflineOperation.t t/db_dependent/Circulation_OfflineOperation.t .. ok All tests successful. Files=1, Tests=7, 19 wallclock secs ( 0.01 usr 0.01 sys + 0.33 cusr 0.02 csys = 0.37 CPU Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10718] items with no checkouts report does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de --- This patch doesn't seem to fix the translation problems fixed by 7478 - so I think we need both. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10718] items with no checkouts report does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20570|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20600 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20600action=edit [PASSED QA] Bug 10718 - items with no checkouts report does not work Bug 8124 has commented the option to download results items with no checkouts report into a file. But the perl code of this page uses the export into a file has default behavior since the input output is no more present. The consequence is that there are never results in page. This patch removes the code concerning file output from template and perl. Such a feature exists in guided reports. Test plan : Play with cgi-bin/koha/reports/catalogue_out.pl form and see if you get results Bug 10718 - select user branch as default In cgi-bin/koha/reports/catalogue_out.pl report, select in library filter the user logged-in. Test plan : - Log into intranet with a normal user - Got to Items with no checkouts reports = Your branch is selected - Run report = You see Filtered on : Branch = your branch - Come back to report - Select Any library - Run report = You do not see Filtered on : Branch Bug 10718 - items with no checkouts report permission is execute_reports This report only executes SQL to change reports/catalogue_out.pl permissions from all reports subpermissions to reports/execute_reports. Test plan : Test you can access and run this report with only execute_reports subpermission into reports permission. Bug 10718 - redefine limit input In reports/catalogue_out.pl form, the limit input is by defaut none. So by default the report queries all the catalogue. This may take a very long time (fall into timeout) and since now the results are displayed in page, the page may be huge. This patch modifies limit input to removes the none option. Also reduces the number of options (same options as guided reports results per page). Test plan: - Go to reports/catalogue_out.pl = first value 10 is selected - Launch report = You see Filtered on: limit = 10 Bug 10718 - perltidy on reports/catalogue_out.pl Signed-off-by: Liz Rea l...@catalyst.net.nz Tested all of these things, all ok - squashed patch for neatness. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests and QA script. Fixed a tab in one of the comments. Improves script, but more work needed. Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10718] items with no checkouts report does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7478] Template/translation problem in catalogue_out.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20238|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20601 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20601action=edit [SIGNED OFF] Bug 7478 - Template/translation problem in catalogue_out.tt The items with no checkouts template has a sections that uses DEFAULT to set some strings: [% DEFAULT loopro.itemcallnumber=No Call Number %] This appears to be untranslatable with our current translation tool. This patch changes the template so that it uses a simple [% IF %] block to display the default text if no value is set. Added is use of the Branches template plugin to show library name instead of code. This patch also fixes an error introduced in my fix for Bug 8124 causing the page to default to CSV download instead of output to screen. To test, apply the patch and confirm that the default text appears onscreen in reports which include results that have a missing barcode, title, or call number. Results should be displayed on screen correctly. Run perl translate update for any language and confirm that the newly generated po file includes No call number, No barcode, and NO TITLE for catalogue_out.tt Signed-off-by: Katrin Fischer katrin.fischer...@web.de Works nicely, thx Owen! Applied on top of 10718 for testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7478] Template/translation problem in catalogue_out.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20103|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20602 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20602action=edit [PASSED QA] Bug 10588 - opac-topissues first branch always selected in filters In OPAC most popular items page: With user is logged-in his branch should be selected. When a branch is manually selected and form is submitted, this branch should be selected in results page. When looking at HTML, you see that all options are selected in combobox. This patch corrects by using the hidden input 'do_it' to distinguish form display and no branch filter selected. Test plan : - Make sure there are issues on records created in the past 3 month - Go to OPAC not logged-in - Click on Most popular = You get to page with results, All libraries is selected - Select a branch and submit = You get to page with results, the branch is selected [testing opac-topissues.inc from] - Select a branch and perform a search that does not have results (for example an item type never issued) = You get to page without results, the branch is selected [testing opac-topissues.tt form] - Log-in with a user - Click on Most popular = You get to page with results, user's branch is selected - Select All libraries and submit = You get to page with results, All libraries is selected [testing opac-topissues.inc from] - Select All libraries and perform a search that does not have results (for example an item type never issued) = You get to page without results, All libraries is selected [testing opac-topissues.tt form] Signed-off-by: Srdjan srd...@catalyst.net.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de Works nicely and passes all tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I like this version a lot better, thx Fridolyn. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9943] Pay fines page Pay selected button give invalid amount when nothing is selected
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9943 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20429|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20603 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20603action=edit [PASSED QA] Bug 9943 - Pay fines page Pay selected button give invalid amount when nothing is selected If you select no fines but click the pay selected button the resulting screen offers to let you pay against all fines, which is confusing. To simplify things this patch disables the pay selected button if no lines are selected. To test, apply the patch and find a patron with outstanding fines. From the pay fines page (members/pay.pl) try selecting and deselecting checkboxes and using the select all and clear all links. When no item is selected the Pay selected button should become disabled. Confirm that the form submits correctly when one or more fines is selected. Signed-off-by: Melia Meggs me...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests and QA script. Works nicely in my tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9943] Pay fines page Pay selected button give invalid amount when nothing is selected
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9943 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10572] Add phone to message_transport_types table for new installs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 --- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Kyle, could you address comment 3 please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10719] UT GetUpcomingDueIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10719 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Assignee|gmcha...@gmail.com |tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10349] Don't show empty Descriptions/Title notes tabs in OPAC and staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10349 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #19967|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20604 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20604action=edit [PASSED QA] Bug 10349 - Don't show empty Descriptions/Title notes tabs in OPAC and staff The descriptions/title notes tab appears on the detail page in both staff client and OPAC even if there are no notes. This is probably a relic of the pre-T:T days when it wasn't possible to use || in an IF. This patch adds a check for the various variables which might trigger the display of the tab. To test, apply the patch and view records in the OPAC and staff client which do and do not have title notes attached (whether that be in the MARC reocrd or in the biblio.notes column). In the OPAC Syndetics content should also be tested if possible. The descriptions/title notes tab should only appear if there is content. Signed-off-by: Mirko Tietgen mi...@abunchofthings.net Signed-off-by: Katrin Fischer katrin.fischer...@web.de That's better - thx Owen! Works nicely and passes all tests. Tested in staff and OPAC, also in combination with NotesBlacklist hiding all notes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10349] Don't show empty Descriptions/Title notes tabs in OPAC and staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10349 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10719] UT GetUpcomingDueIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10719 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10719] UT GetUpcomingDueIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10719 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20421|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20605 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20605action=edit [PASSED QA] Bug 10719 - UT GetUpcomingDueIssues Some unit tests related to Bug 9362. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com http://bugs.koha-community.org/show_bug.cgi?id=10606 Signed-off-by: Katrin Fischer katrin.fischer...@web.de New and old tests pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10566] Improve OPAC course reserves pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10566 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10566] Improve OPAC course reserves pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10566 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #19689|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20606 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20606action=edit [PASSED QA] Bug 10566 - Improve OPAC course reserves pages This patch makes various improvements to the OPAC course reserve pages: - Descriptive page titles for both pages. - More compact display of course information on course detail page (a list instead of a table, consistent with other displays of similar information in Koha). - Correct capitalization. - Added label and fieldset to course reserve search form. - Added breadcrumb navigatio nto course reserve detail page as a path back to course reserves main page. To test, apply the patch and confirm that the changes haven't broken anything and are an improvement. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests and improves the display. Tested with only 1 course, 2 courses, courses with and without items selected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Owen, there is a small conflict in basketgroup.tt, but I am not sure how to solve it - could you rebase and switch back to signed off please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10626] Remove doubled up TT plugins
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Kyle - view_holdsqueue.tt is still using 'USE KohaAuthorisedValues' - circulation.tt is still using 'USE KohaBranchName' after applying your patches. Could you add 2 follow ups please? Maybe we should also add a test to the QA script? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9782] Cancel button doesn't work when importing MARC bibliographic frameworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9782 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9782] Cancel button doesn't work when importing MARC bibliographic frameworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9782 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20522|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20607 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20607action=edit [PASSED QA] Bug 9782 - Cancel button doesn't work when importing MARC bibliographic frameworks When importing frameworks the cancel button should be hidden once an import is initiated since it is not possible to cancel the import in progress. This patch uses this bug as an excuse to replace the old import/export pop-ups with modal dialogs for all import/export functions. To test: - Try exporting both the default framework and at least one other framework. - Try importing both a default framework and at least one other framework. - When importing, observe that the modal dialog controls are hidden as soon as the import is initiated. Signed-off-by: David Cook dc...@prosentient.com.au Signed-off-by: Katrin Fischer katrin.fischer...@web.de Works nicely, passes all tests and QA script. Also the modal works better on smaller screens. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10690] Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10690 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10690] Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10690 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20190|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20608 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20608action=edit [PASSED QA] Bug 10690 - Warn about trailing slashes in description of OPACBaseURL and staffClientBaseURL The descriptions for OPACBaseURL and staffClientBaseURL are not explicit about including a trailing slash or not. This patch makes it explicit that the trailing slash should *not* be included. To test: - Apply the patch - Search for baseurl in the system preferences - Check that the description of both sysprefs includes a warning about not including a trailing slash. - Sign off If you want to check that the trailing slash is in fact superfluous you can do something like 'grep -r BaseURL *' and check that these sysprefs are usually concatenated with some string that starts with a slash. Signed-off-by: Mirko Tietgen mi...@abunchofthings.net Signed-off-by: Katrin Fischer katrin.fischer...@web.de Changes to the description appear correctly on both system preferences. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10645] Missing zebra languages in koha-create manpage
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10645 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Tomas, I applied your patch but the change doesn't show up in the man page - I know I am missing something. Do you have some hints for me? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10742] simple search to z39.50 search keeps index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10645] Missing zebra languages in koha-create manpage
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10645 --- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com --- (In reply to Katrin Fischer from comment #3) Hi Tomas, I applied your patch but the change doesn't show up in the man page - I know I am missing something. Do you have some hints for me? Katrin, on bug 10622 Magnus posts a command to recreate man page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20422|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20610 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20610action=edit [PASSED QA] Bug 10606: Remove MySQLism in GetUpcomingDueIssues To test: [1] Arrange to have at least one loan in your test database due one day from now. [2] Run misc/cronjobs/advance_notices.pl -c -n -v -m=2 and note the number of loans reported. [3] Apply the patch. [4] Run misc/cronjobs/advance_notices.pl -c -n -v -m=2 again and verify that the number of loans reported remains the same. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de All tests and QA script pass. Also tested with unit tests from bug 10719. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10780] New: Updatedatabase updates permission labels incorrectly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10780 Bug ID: 10780 Summary: Updatedatabase updates permission labels incorrectly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: l...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The stock descriptions of permissions are correct, but an updatedatabase stanza updates two of them to be identical when they shouldn't be. Patch incoming. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10645] Missing zebra languages in koha-create manpage
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10645 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20066|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20611 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20611action=edit [PASSED QA] Bug 10645: Missing zebra languages in koha-create manpage There where some missing zebra language options in the man page for koha-create. Trivial string change. To+ Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Tested using the following commands: $ xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \ debian/docs/koha-list.xml $ man -l koha-list.8 Also: prove -v xt/verify-debian-docbook.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10645] Missing zebra languages in koha-create manpage
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10645 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10668] Improve suggestion detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20072|0 |1 is obsolete|| Attachment #20102|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20612 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20612action=edit [PASSED QA] Bug 10668 - Improve suggestion detail page This patch makes several improvements to the suggestions template: - Improved breadcrumbs and page title. - Fixed a JavaScript error which appeared when viewing or editing a suggestion. - Added an 'Edit' and a 'Delete' button to the suggestion detail page. - Corrected capitalization. To test: - Perform various operations with suggestions management and confirm that page titles and breadcrumbs are correct. - View the detail page for an individual suggestion and confirm that the edit and delete buttons work correctly. - Confirm that there are no JavaScript errors when viewing or editing a suggestion, in particular when changing Acquisition information (quantity, currency, price). Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests, nice improvement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10668] Improve suggestion detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668 --- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 20613 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20613action=edit [PASSED QA] Bug 10668 - Improve suggestion detail page - QA Followup Signed-off-by: Srdjan srd...@catalyst.net.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10668] Improve suggestion detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10682] Inappropriate uses of finish() in C4::Reserve.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10682 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #20108|0 |1 is obsolete|| --- Comment #2 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 20614 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20614action=edit Bug 10682 : Inappropriate uses of finish() in C4::Reserves This patch gets rid of finish. From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to finish after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Comment: Similar to other patches from the same author I run prove t/db_dependent/Reserves.t without errors don't know if more tests are needed. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10682] Inappropriate uses of finish() in C4::Reserve.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10682 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10685] Inappropriate uses of finish() in C4::Accounts.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #20110|0 |1 is obsolete|| --- Comment #2 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 20615 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20615action=edit Bug 10685: Inappropriate uses of finish in C4::Accounts.pm This patch gets rid of finish. From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to finish after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Comment: Similar to other patches from the same author. Run prove t/db_dependent/Accounts.t without errors No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10685] Inappropriate uses of finish() in C4::Accounts.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10698] DeleteTransfer in C4::Circulation.pm needs return value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #20160|0 |1 is obsolete|| --- Comment #4 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 20616 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20616action=edit Bug 10698: DeleteTransfer in C4::Circulation.pm needs return value This patch adds return values to DeleteTransfer: Undef if no parameters are given 1 if a Transfer is deleted 0E0 if a wrong parameter is given It also fixes some unit tests in t/db_dependent/Circulation_transfers.t To test: prove t/db_dependent/Circulation_transfers.t t/db_dependent/Circulation_transfers.t .. ok All tests successful. Files=1, Tests=14, 20 wallclock secs ( 0.03 usr 0.00 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Comment: Applied 10681 and 10692 before 10698 Run prove t/db_dependent/Circulation_transfers.t without errors No koha-qa errors on all 3 patches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10698] DeleteTransfer in C4::Circulation.pm needs return value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10711] GetOfflineOperation in C4/Circulation.pm should returns $sth-fetchrow_hashref instead of $result
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #20269|0 |1 is obsolete|| --- Comment #2 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 20617 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20617action=edit Bug 10711: GetOfflineOperation in C4/Circulation.pm should returns $sth-fetchrow_hashref instead of $result To test : prove t/db_dependent/Circulation_OfflineOperation.t t/db_dependent/Circulation_OfflineOperation.t .. ok All tests successful. Files=1, Tests=7, 19 wallclock secs ( 0.02 usr 0.01 sys + 0.24 cusr 0.02 csys = 0.29 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Comment: applied 10681 and 10710 before 10711 prove t/db_dependent/Circulation_OfflineOperation.t run without errors koha-qa reports only 2 tabulations, fixed in a follow-up -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10711] GetOfflineOperation in C4/Circulation.pm should returns $sth-fetchrow_hashref instead of $result
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10711] GetOfflineOperation in C4/Circulation.pm should returns $sth-fetchrow_hashref instead of $result
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 --- Comment #3 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 20618 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20618action=edit Bug 10711: (follow-up) removing tabs Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10767] UT: Routines which interact with the table issuingrules in C4/Circulation need unit test
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10767 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #20496|0 |1 is obsolete|| --- Comment #2 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 20619 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20619action=edit Bug 10767: UT:Routines which interact with the table issuingrules in C4/Circulation need unit tests The test are wrap in a transaction. NOTE: Some tests (in comment) don't pass, the routines have to be fixed To test: prove t/db_dependent/Circulation_Issuingrule.t t/db_dependent/Circulation_Issuingrule.t .. ok All tests successful. Files=1, Tests=9, 17 wallclock secs ( 0.02 usr 0.00 sys + 0.34 cusr 0.04 csys = 0.40 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Comment: No koha-qa errors prove t/db_dependent/Circulation_Issuingrule.t run without errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10767] UT: Routines which interact with the table issuingrules in C4/Circulation need unit test
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10767 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10781] New: Remove C4::ILSDI::Utility
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 Bug ID: 10781 Summary: Remove C4::ILSDI::Utility Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: srd...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org C4::ILSDI::Utility is not really required. It contains only two routines: * BorrowerExists() which is not used * Availability(), used only in C4::ILSDI::Services I propose we move Availability() to C4::ILSDI::Services and remove C4::ILSDI::Utility -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10781] Remove C4::ILSDI::Utility
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10781] Remove C4::ILSDI::Utility
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 --- Comment #1 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 20620 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20620action=edit bug_10781: Removed ILSDI::Utility Test: This should be a noop. Regression testing required: /cgi-bin/koha/ilsdi.pl functioanality, in particuler: GetAvailability - ?service=Describeverb=GetAvailability AuthenticatePatron - ?service=Describeverb=AuthenticatePatron ILS-DI syspref must be turned on -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2500] Standing enhancement request for adding/updating call number splitting algorithms in C4/Labels.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2500 David Cook dc...@prosentient.com.au changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #18 from David Cook dc...@prosentient.com.au --- So I've recently encountered a call number like this: 361.250994 REP NO. 11/10 The section 361.250994 is DDC, I believe. However, REP NO. 11/10 is entirely local. When printing labels and splitting call numbers, the slash between 11 and 10 gets removed using _split_ddcn. This isn't desirable, so I opted to use a different splitting sub. However, if I use _split_ccn, REP NO. 11/10 gets turns into REP NO. 11 /10, which is also undesirable, as that means 11 gets printed on one line and /10 gets printed on the next. This is due to some regexp found in _split_ccn, which pulls apart the last element in the @parts array. Is there are a reason why the last element in the array is being pulled apart like this? I used git blame but the original 2009 commit message from Chris Nighswonger didn't really tell me much. I'm sure there is a reason, but it might make more sense for this - or another - sub to just split on spaces. -- Another thought...currently there is no way to associate splitting subs with call number classification schemes. The only way I see is to hardcode it into Label.pm. Perhaps it would be an idea to specify the call number splitting rule in the Classification sources part of the Administration module. This could be useful in several contexts. For instance, we're currently using the _split_lccn sub for LCC and NLM, but it could also be useful for the KF Modified classification scheme (which is a legal scheme based on LCC) and other schemes. KDC (Korean Decimal Classification) would also probably use DDC. Admittedly, since the behaviours are likely the same, people using KF Modified or KDC should probably just use LCC or DDC as classification sources rather than making new ones, so perhaps I don't actually have a good point there :p. However...there might be times when a library wants to use the DDC filing rules but have call number splitting just on spaces. Like in the above case where they want to preserve those local slashes. I don't know. Just a thought. I've already set up z to use _split_ccn in the past. I might adjust it so that it uses a different sub which just split on spaces... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Kenza, I think this would be a bit better as 2 patches - one for the changes Booksellers.pm and one for the tests, so you can compare the results of the tests before and after the change. Could you split the patch up? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Failed QA always gets a bit more attention :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
