[Koha-bugs] [Bug 10720] Substitution term in overdue notices shouldn't be removed even if they don't match

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10720

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #20320|0   |1
is obsolete||

--- Comment #2 from Srdjan Jankovic srd...@catalyst.net.nz ---
Created attachment 20756
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20756action=edit
Bug 10720 : substitution term in overdue notices shouldn't be removed if they
don't match. It prevents use of html in notices to use with css

Test plan :
- define an overdue notice containing some valid substitution terms +
some valid html tags (strong or div class=my class to use with a css
- find a borrower with overdues that trigger this notice
- run overdue_notices.pl -html directory

Without patch, your html tags are missing in your html file
With the patch, they are present and can be used with a css to generate
a formatted pdf file.

If you add some invalid substitution term, with the patch, they are
still in the final letter, but the warn in the log helps you to correct your
notice template.

Signed-off-by: Srdjan srd...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10720] Substitution term in overdue notices shouldn't be removed even if they don't match

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10720

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10720] Substitution term in overdue notices shouldn't be removed even if they don't match

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10720

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

 CC||srd...@catalyst.net.nz

--- Comment #3 from Srdjan Jankovic srd...@catalyst.net.nz ---
I've removed those lines, this script should use GetPreparedLetter anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7021] patron category in the statistics table

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021

--- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Some of the information proposed by Mathieu is or might be a bit critical - so
it would be nice to have a system preference to determine which fields are
going to be saved into the statistics table. Maybe we could add the patron
category as a first step.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #3 from David Cook dc...@prosentient.com.au ---
Created attachment 20757
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20757action=edit
Bug 10662 - Build OAI-PMH Harvesting Client

N.B. This feature is still a work in progress. This commit represents
my work to date on the OAI-PMH harvester, but it's not complete. While
the core classes are operational, I still need to improve the cronjob,
the DC to MARC21 XSLT, and the internal workings of the classes (mostly
in terms of error handling, edge cases, and reporting).

This patch adds several new files to Koha:

Overview:
1) C4/OAI/Harvester.pm: This contains 2 classes. The Harvester class
sets up the 6 OAI-PMH verbs (2 of which harvest records) and imports
records into Koha. The Harvester::Record class is a helper class for
processing records, transforming metadata, etc. At the moment, this is
hardwired for MARC21 but it's easy enough to expand it out to other
flavours (provided there are XSLTs there for the metadata transforms).

2) koha-tmpl/intranet-tmpl/prog/en/xslt/DC2MARC21slim.xsl: This is a
XSLT which transforms oai_dc into MARC21. This is a lightweight XSLT
based on one I found from the Library of Congress. I improved the
Leader and I will endeavour to improve the 008 and map more fields in
a more orderly way than this. However, it's a good start.

3) koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MARC21enhanced.xsl:
This simply strips 999 fields from incoming records, adds the OAI-PMH
unique identifier, and adds a 999 field if that unique identifier has
already been imported in the past (the 999 is added so that automatic
matching and replacement can take place on import).

4) misc/cronjobs/oai_harvester.pl: At the moment, this script takes
database config for a OAI-PMH repository to create a Harvester object,
then tries each OAI-PMH verb and imports the resulting records into
Koha.

5) t/db_dependent/OAI_harvester.t: This is a unit test which uses
Koha as the OAI-PMH repository and client in a circular loop. It
should test the high level methods and go from retrieving database
config to importing records. It uses the rollback method so you
won't have a bunch of records imported into your database (although
your autoincrement will probably go up anyway).

Test Plan (For MARC21 users):
0) Apply the patch and run updatedatabase.pl (it will add two new
tables to your database: oai_harvest and oai_harvest_repositories).
I've documented them in kohastructure.sql.

1) For starters, run the OAI_harvester.t test. It should cycle
through all the tests without any problems. If you there are problems,
let me know on Bugzilla, in IRC, or via email.

2a) Next, if you feel safe importing records into your database, use the
config from the unit test as an example and create an entry in your
oai_harvest_repositories table. Be careful with the import_mode.
Automatic will automatically stage and import any records
harvested via OAI-PMH. Manual will stage them but not import them.

2b) Once you're somewhat sure of your config, run oai_harvester.pl. The
default is not to use automatic token resumption (so you should only
have 50 records in your import batch most likely). You can change this
in the cronjob itself.

If you fully import this batch, try running oai_harvester.pl again.
You shouldn't get any results (as you've already imported that batch
of records). To try out the replace/update feature: update one of
the original records you imported (out of that first 50), re-index,
and re-run oai_harvester.pl. You should now get 1 record in your
batch which should automatically match the original. In automatic
mode, it would automatically replace the record (although this can
still be reverted in the Manage Staged MARC Records). In manual
mode, you'll notice in the management interface that there has
been a match for that record with the original.

3) To more fully explore: Examine C4/OAI/Harvester.pm. I wrote the POD
at the end of August, so it's a bit out of date but it should be
mostly accurate. I've tried to include as many comments as possible
along the way as well.

It's not a very sophisticated module. However, there are a lot of
different scenarios that I'm trying to account for. I might've missed
some use/edge cases, implemented bad code, or error handling. A place to
start might be any FIXME or TODO messages.

--

As I said at the top, this is still a work in progress, but I'd be
happy to get any feedback or advice on how to proceed with this
feature.

I'll continue working on it and post updates.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

  Attachment #20757|0   |1
is obsolete||

--- Comment #4 from David Cook dc...@prosentient.com.au ---
Created attachment 20758
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20758action=edit
Bug 10662 - Build OAI-PMH Harvesting Client

N.B. This feature is still a work in progress. This commit represents
my work to date on the OAI-PMH harvester, but it's not complete. While
the core classes are operational, I still need to improve the cronjob,
the DC to MARC21 XSLT, and the internal workings of the classes (mostly
in terms of error handling, edge cases, and reporting).

This patch adds several new files to Koha:

Overview:
1) C4/OAI/Harvester.pm: This contains 2 classes. The Harvester class
sets up the 6 OAI-PMH verbs (2 of which harvest records) and imports
records into Koha. The Harvester::Record class is a helper class for
processing records, transforming metadata, etc. At the moment, this is
hardwired for MARC21 but it's easy enough to expand it out to other
flavours (provided there are XSLTs there for the metadata transforms).

2) koha-tmpl/intranet-tmpl/prog/en/xslt/DC2MARC21slim.xsl: This is a
XSLT which transforms oai_dc into MARC21. This is a lightweight XSLT
based on one I found from the Library of Congress. I improved the
Leader and I will endeavour to improve the 008 and map more fields in
a more orderly way than this. However, it's a good start.

3) koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MARC21enhanced.xsl:
This simply strips 999 fields from incoming records, adds the OAI-PMH
unique identifier, and adds a 999 field if that unique identifier has
already been imported in the past (the 999 is added so that automatic
matching and replacement can take place on import).

4) misc/cronjobs/oai_harvester.pl: At the moment, this script takes
database config for a OAI-PMH repository to create a Harvester object,
then tries each OAI-PMH verb and imports the resulting records into
Koha.

5) t/db_dependent/OAI_harvester.t: This is a unit test which uses
Koha as the OAI-PMH repository and client in a circular loop. It
should test the high level methods and go from retrieving database
config to importing records. It uses the rollback method so you
won't have a bunch of records imported into your database (although
your autoincrement will probably go up anyway).

Test Plan (For MARC21 users):
0) Apply the patch and run updatedatabase.pl (it will add two new
tables to your database: oai_harvest and oai_harvest_repositories).
I've documented them in kohastructure.sql.

1) For starters, run the OAI_harvester.t test. It should cycle
through all the tests without any problems. If you there are problems,
let me know on Bugzilla, in IRC, or via email.

2a) Next, if you feel safe importing records into your database, use the
config from the unit test as an example and create an entry in your
oai_harvest_repositories table. Be careful with the import_mode.
Automatic will automatically stage and import any records
harvested via OAI-PMH. Manual will stage them but not import them.

2b) Once you're somewhat sure of your config, run oai_harvester.pl. The
default is not to use automatic token resumption (so you should only
have 50 records in your import batch most likely). You can change this
in the cronjob itself.

If you fully import this batch, try running oai_harvester.pl again.
You shouldn't get any results (as you've already imported that batch
of records). To try out the replace/update feature: update one of
the original records you imported (out of that first 50), re-index,
and re-run oai_harvester.pl. You should now get 1 record in your
batch which should automatically match the original. In automatic
mode, it would automatically replace the record (although this can
still be reverted in the Manage Staged MARC Records). In manual
mode, you'll notice in the management interface that there has
been a match for that record with the original.

3) To more fully explore: Examine C4/OAI/Harvester.pm. I wrote the POD
at the end of August, so it's a bit out of date but it should be
mostly accurate. I've tried to include as many comments as possible
along the way as well.

It's not a very sophisticated module. However, there are a lot of
different scenarios that I'm trying to account for. I might've missed
some use/edge cases, implemented bad code, or error handling. A place to
start might be any FIXME or TODO messages.

--

As I said at the top, this is still a work in progress, but I'd be
happy to get any feedback or advice on how to proceed with this
feature.

I'll continue working on it and post updates.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Koha-bugs] [Bug 10221] hold expiration doesn't show on patron's list of holds

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10221

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #18742|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20759
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20759action=edit
[3.10.x] Bug 10221 - hold expiration doesn't show on patron's list of holds

When viewing the list of a patron's holds on the circulation page or the
patron detail page the table of holds doesn't display the holds
expiration date, if present. This patch adds display of the hold
expiration date.

To test, place a hold for a patron and set an expiration date for it.
View the patron's existing holds on both circulation.pl and
moremember.pl. The expiration date you chose should appear in the table
of information about existing holds.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 Status|NEW |In Discussion
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #5 from David Cook dc...@prosentient.com.au ---
Thoughts on things to include:

1) Add a preference/config for using identifier + datestamp OR identifier +
datestamp + metadataPrefix as the indicator of the highest order of uniqueness.

2) Add an email feature that tells library staff to check a report which
enumerates the status of records imported via OAI-PMH. These can be create (new
records), replace (updated records), deleted (for incoming records with a
status of deleted), or ambiguous (essentially a new record but linked to
multiple existing bib records. These are almost certainly duplicates but
require manual merging since it's tough to know which is the real authoritative
record).

I was thinking perhaps of sending an email containing a link to a Template
Toolkit page (so that translation would be possible), which would contain the
import/history log.

3) Improving error handling

4) Make the import options more configurable? Although I think the hardcoded
options for always replacing a bib match, adding for no match, and ignoring
items are probably pretty good. There might be other use cases where people
want something different though, so configuration might be a good idea
(although ignoring items is fairly essential, as you could duplicate items if
you're importing updated records with items). Perhaps the MARC21 XSLT should
also strip 952 fields.

5) When using the cronjob, if the from date for a repository is null, check
for existing records in Koha, and use the latest datestamp? This way we're
able to do selective harvesting automatically without having to update our
configuration. (I'll probably add this one soon.)

6) Matching rules: a) Check what MARC field that system uses for its
biblionumber. Check if there is a matching rule for that field in Koha. If not,
create one? Having this matching rule is essential for matching updated
records.

7) Improving the DC = MARC conversion (might look at this soon too...it will
always be a best guess but it has room for a lot of easy improvement)

8) Make an OAI-PMH harvesting web UI. This would allow people to plug in the
baseURL for a remote OAI-PMH repository and use the 6 verbs on it.

I imagine it being a good way of people getting used to what a OAI-PMH repo
has, so that they can set up the automatic cronjob configuration. It could also
be a good idea to allow the ImportRecordsIntoKoha method for selective
harvesting.

That said, if it's too easy to use, it might also be abused by someone who
doesn't know what they're doing. If there were a GUI, it would need a
permission and/or system preference most likely.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #5 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Hello Mathieu,
I glance your test in http://pro.test2.biblibre.com/, for the budget spent in
the summary home page, it's normal you see 9 because it take the actual price
for the invoice. So with the preference invoiced price includes tax, it means
the atcual price on the invoice printed by the vendor includes tax, the price
spent is really 9.

So for me, the patch is working as it's excepted.
Can you check it ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #6 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Well, well, I fear I am still lost...

In reception Koha tells me the unit cost is 9.49 (so, I suppose price
including tax). But I don't find again this 9.49 in Acq home page.
For me, Budget spent must not take the raw price of the invoice, if this raw
price does not include tax. In this case, budget spent must add tax to this raw
price.

Or maybe there is a bug in reception page?
What is the meaning of the unit cost when we receive item : does it mean 
1/ cost actually written by the vendor on his invoice (with or without tax,
depending of invoiceincgst value) ?
or
2/ price actually paid by the library (so always WITH tax), based on the cost
written by the vendor on the invoice ?

Maybe Nicole could help me on this point?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

Viktor Sarge viktor.sa...@regionhalland.se changed:

   What|Removed |Added

 CC||viktor.sarge@regionhalland.
   ||se

--- Comment #6 from Viktor Sarge viktor.sa...@regionhalland.se ---
I'm excited to see this functionality being developed as we will work with just
the scenario you initially mentioned with a union catalogue providing quality
records that we import automatically as our book vendor add them to our account
in the union catalogue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10490] Overdue fines cap (amount) in circulation rules is saved incorrectly (rounded)

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10490

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Chris Hall from comment #10)
 Pushed to 3.8.x, will be in 3.8.17

Chris, This patch produces an error (see
http://lists.koha-community.org/pipermail/koha-devel/2013-September/039649.html)
updating the database. Since bug 7420 is not pushed in 3.8.x, I think this fix
should not be pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10490] Overdue fines cap (amount) in circulation rules is saved incorrectly (rounded)

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10490

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||7420

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7420] Add max fines to circulation matrix

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7420

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||10490

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #60 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Katrin Fischer from comment #59)
 I think this change might be in conflict with the big serials pattern patch
 that has reached 'Passed QA' already (bug 7688).

I already talk about this possible problem with Julian (author of the feature
7688). On a functional point of view the 2 features are not in conflict but,
inevitably, the patches will not apply cleanly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4823] Raw Socket interface failing to accept connections

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4823

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #1 from Colin Campbell colin.campb...@ptfs-europe.com ---
Closing as resolved. This may have been caused by a configuration issue. If
spare servers is set to zero the server will not ensure that a server is
available to answer incoming connections. When a unit attempts to reconnect all
existing servers may be sitting on old connections they still think are valid
(waiting for the next request that never comes), as no spare has started up the
connection is refused

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10812] New: new check-ou warning:

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10812

Bug ID: 10812
   Summary: new check-ou warning:
 Change sponsored?: ---
   Product: Koha
   Version: 3.12
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: blac...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Created attachment 20760
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20760action=edit
warning example

Our patrons very often want to check if selected books they already read. Can
we add custom warning for item which patrad already had some time ago? Message
can looks like example attached file or similar. 
Very useful can be setting for:
- some types of items don't generate this warning (ofter loaned items for
example some CD-ROMs, maps or special documents)
- some patrons don't want to be inform about it (checkbox in their detail?)


Thank You

Mike

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10812] new check-ou warning:

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10812

Mike blac...@gmail.com changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10812] new check-ou warning:

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10812

Mike blac...@gmail.com changed:

   What|Removed |Added

   Priority|P5 - low|P2

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8605] cs-CZ: Filesystem sent error: No such file or directory

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8605

Mike blac...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1633] Add ability to take book cover images from local img db

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633

Manos PETRIDIS egpetri...@yahoo.com changed:

   What|Removed |Added

 CC||egpetri...@yahoo.com

--- Comment #88 from Manos PETRIDIS egpetri...@yahoo.com ---
The bug you're looking for, the one where local cover images fail to show, is
#9737.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7813] Add ability to delete local cover images

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7813

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7813] Add ability to delete local cover images

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7813

--- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 20761
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20761action=edit
Bug 7813: Ability to delete local cover images

This patch adds the ability to delete local cover images from the detail page.
It adds a 'x' button to trigger the deletion. It occurs using a new SVC script
called cover_images that accepts the following parameters:
 - action
 - biblionumber (used for checking imagenumber validity)
 - imagenumber (repeatable)
It then deletes all valid images passed and returns a JSON object containing
the imagenumbers and the deletion status (1/0). The operation is triggered
using jQuery.ajax, and with the response the corresponding images get deleted.

Note: currently one image is deleted at a time, but the code is there to be
used.

To test:
- Open the detail page fr a biblionumber containing one or more cover images,
go to its images tab.
- Apply the patch, reload the page, go to the images tab.
- Thumbnails should look better than before ;-)
- An 'X' button should show below each cover.
- Clicking the 'X' button should trigger an alert message asking for
confirmation.
 a) Cancel: nothing happens, reload the page and check nothing got deleted.
 b) Accept: the deleted image should be gone, reload the page to check it
doesn't exist anymore and is not a browser/DOM manipulation trick.
- Signoff

Note: check having more cover images than those that fit the width and see it
wraps fine.

Any comments are welcome, this is WIP.
Thanks
To+

P.S. I chose not to implement every possible action on the svc script, but
another bug could be filled for more improvements.

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9288] Add a script to test SIP from the command line

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Setting to failed to get Kyle's attention to comment#18

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10813] New: changing sort on tag results shows more results

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10813

Bug ID: 10813
   Summary: changing sort on tag results shows more results
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

I have a report that when you click a tag in the tag cloud and then change the
sort option on the top right it shows no results found in koha 3.10.10 when I
test this in master I get results, but too many - I get results for a keyword
search instead of the tag search. Either way there is a problem with being able
to change the sort on a tag search results page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9093] 008 forgetting what material type was chosen

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093

Pablo López Liotti palio...@mdp.edu.ar changed:

   What|Removed |Added

 CC||palio...@mdp.edu.ar

--- Comment #2 from Pablo López Liotti palio...@mdp.edu.ar ---
This issue was reported today to me by my library staff.
If the procedure of change field 008 values is repeated sometimes, finally it´s
possible save the record with correct values.

There is any patch o tip to prevent this?

We are using 3.12.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

 CC||srd...@catalyst.net.nz

--- Comment #4 from Srdjan Jankovic srd...@catalyst.net.nz ---
DDL statements ( ALTER TABLE ) cannot be rolled back, and should not be part of
transaction. In that respect the update transaction makes no sense, and should
be removed. If some kind of failure rollback needs to be implemented, it has to
be done in some other way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240

--- Comment #31 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 20762
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20762action=edit
Bug 10240 follow-up: fix display

Fix the following two issues:
1) After paying a fine when offline the fine amount becomes NaN.
2) For previous checkouts for a pratron the title and barcode
   fields have the wrong infomation in them (i.e. they have been swapped)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539

Srdjan Jankovic srd...@catalyst.net.nz changed:

   What|Removed |Added

 CC||srd...@catalyst.net.nz

--- Comment #7 from Srdjan Jankovic srd...@catalyst.net.nz ---
A philosophical question - changes like this, consisting of only removing
unused/unwanted code, can those be self-signed, and go to QA directly?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7813] Add ability to delete local cover images

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7813

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7813] Add ability to delete local cover images

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7813

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

  Attachment #20761|0   |1
is obsolete||

--- Comment #7 from David Cook dc...@prosentient.com.au ---
Created attachment 20763
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20763action=edit
Bug 7813: Ability to delete local cover images

This patch adds the ability to delete local cover images from the detail page.
It adds a 'x' button to trigger the deletion. It occurs using a new SVC script
called cover_images that accepts the following parameters:
 - action
 - biblionumber (used for checking imagenumber validity)
 - imagenumber (repeatable)
It then deletes all valid images passed and returns a JSON object containing
the imagenumbers and the deletion status (1/0). The operation is triggered
using jQuery.ajax, and with the response the corresponding images get deleted.

Note: currently one image is deleted at a time, but the code is there to be
used.

To test:
- Open the detail page fr a biblionumber containing one or more cover images,
go to its images tab.
- Apply the patch, reload the page, go to the images tab.
- Thumbnails should look better than before ;-)
- An 'X' button should show below each cover.
- Clicking the 'X' button should trigger an alert message asking for
confirmation.
 a) Cancel: nothing happens, reload the page and check nothing got deleted.
 b) Accept: the deleted image should be gone, reload the page to check it
doesn't exist anymore and is not a browser/DOM manipulation trick.
- Signoff

Note: check having more cover images than those that fit the width and see it
wraps fine.

Any comments are welcome, this is WIP.
Thanks
To+

P.S. I chose not to implement every possible action on the svc script, but
another bug could be filled for more improvements.

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: David Cook dc...@prosentient.com.au

Works as described. This is a nice addition!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7813] Add ability to delete local cover images

2013-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7813

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #8 from David Cook dc...@prosentient.com.au ---
Alas, when I try in 3.8.0 (after manually merging the patch with the code), I
get this error:

Uncaught Syntax error, unrecognized expression:
[{imagenumber:13,deleted:1}] jquery.js:19

F.filter jquery.js:19
F jquery.js:19
F jquery.js:19
o.fn.o.find jquery.js:12
jQuery.fn.find jquery.hotkeys.min.js:1
o.fn.o.init jquery.js:12
l.jQuery.l.$ jquery.js:12
$.ajax.success detail.pl?biblionumber=179:102
I jquery.js:19
N jquery.js:19

Maybe I made a mistake doing the merge? Or maybe an older version of jQuery has
a harder time processing JSON but that seems strange...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/