[Koha-bugs] [Bug 10924] Contact note not updating via opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10924 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #21306|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21307 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21307action=edit [PASSED QA] Bug 10924 - Contact note not updating via opac If you update your Contact note via the OPAC that change doesn't appear in the staff client's Update patron records interface. The field is missing from members-update.tt To test, log in to the OPAC and update your details (opac-memberentry.pl), modifying the Contact note in the Alternate address section. In the staff client, view Patrons requesting modifications (members/memgers-update.pl). The changed contact note field should appear in the list of field awaiting approval for that patron. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Comment: Work as described. No koha-qa errors Signed-off-by: Katrin Fischer katrin.fischer...@web.de One line change - contact note now updates perfectly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10924] Contact note not updating via opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10924 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10911] Records with 880 fields have broken details links in intranet search results using XSLT.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10911 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10911] Records with 880 fields have broken details links in intranet search results using XSLT.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10911 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #21305|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21308 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21308action=edit [PASSED QA] Bug 10911 - Records with 880 fields have broken details links in intranet search results using XSLT. Koha intranet search results using XSLT for records with 880 fields have the details link created by a code path that incorrectly links to some opac pages. Test Plan: 1) Enable XSLT for intranet search results 2) Upload or create a record with at least one 880 field 3) Search for the item ( must have multiple hits to avoid redirection ) 4) Click the title link, note it is broken 5) Apply this patch 6) Click the title link, note it is correct Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Comment: Work as described, no koha-qa errors. Test 1) imported two times sample record 2) reindex 3) search, find example record, broken links 4) applied patch 5) refresh, good links NOTE: A similar (invalid references) problem is present on UNIMARC and NORMAC files I'll file a new bug for those cases. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Works nicely, tested with a different set of sample records with Hebrew 880 fields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10901] Filters is needed on the add item page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10901 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21309 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21309action=edit Screenshot showing withdrawn is not sortable Hi Jonathan, I really like the idea of this :) Just 2 things: 1) My withdrawn column was the only column not being sortable and a search for withdrawn brought up no results. Could you check what's going wrong there? 2) Having one general search box makes the search not very exact. For example if you wanted to check for old items by acquisitions date or last seen date the other date columns will interfere with the search. Maybe we could also add a search box for each column? Failing for 1). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10465] Reference to fields 780 and 785 in UNIMARC XSLT should be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10465] Reference to fields 780 and 785 in UNIMARC XSLT should be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #21151|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21310 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21310action=edit [PASSED QA] Bug 10465 : remove useless reference to fields 780 and 785 in UNIMARC XSLT files UNIMARCslim2OPACDetail.xsl and UNIMARCslim2intranetDetail.xsl contains references to 780 and 785 fields, that exist in Marc21 but not in UNIMARC. This patch remove the code related to 780 and 785 fields. No effect should be visible. To test : in a UNIMARC Koha 1. be sure that OPACXSLTDetailsDisplay , OPACXSLTResultsDisplay , XSLTDetailsDisplay and XSLTResultsDisplay sysprefs are set to default 2. apply the patch 3. search some records in staff interface : the list view and the detail view must be exacty the same as before you apply the patch. 4. search some records in OPAC : the list view and the detail view must be exacty the same as before you apply the patch. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Comment: No diplay change, no koha-qa errors. Removes what can't be displayed. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Checked detail pages in OPAC and intranet still display correctly and without errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10901] Filters is needed on the add item page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10901 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Assignee|oleon...@myacpl.org |m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Mason, I am sorry, but I can't reproduce the wrong display. I am wondering where the date and serialseq should be pulled from? Can you please clarify? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added QA Contact||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #65 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, the QA script points out some things, I would have fixed the tabs, but I think deciding about the license is up to you: FAILserials/lateissues-export.pl OK pod FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 7) OK valid OK critic OKkoha-tmpl/intranet-tmpl/prog/en/modules/acqui/csv/lateorders.tt OK forbidden patterns OK tt_valid OK valid_template FAILkoha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt FAIL forbidden patterns forbidden pattern: tab char (line 220) OK tt_valid OK valid_template FAILkoha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt FAIL forbidden patterns forbidden pattern: tab char (line 45) OK tt_valid OK valid_template Could you take a look? I will continue testing the functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #66 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Some additional notes from code review: - GetBasketGroupAsCSV could use some unit tests as the SQL statement has been altered quite a bit. - lateissues-export.pl could use Modern::Perl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10931 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10931] CSV for serial claims contains untranslatable strings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10931 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=7298 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10931] New: CSV for serial claims contains untranslatable strings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10931 Bug ID: 10931 Summary: CSV for serial claims contains untranslatable strings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr To reproduce: - Make sure you have some late issues for your subscriptions - Install an updated po file for another language - Activate that language - Search for late issues using the claims functionality in serials - Verify that you can export issue data for one or more issues - Verify that the CSV created contains English strings - Verify that your updated po file doesn't contain those strings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10618] Acq claim email not formatting correctly and missing information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10618 --- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de --- This is still a problem on current master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #67 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, we are almost there - it works really nicely, but we got one bigger problems with translating the CSV. Posting my testing notes here: Testing notes: - CSV header row is now translatable. Tested by updating the German po files and checking for the line. - Tested that claiming for late serial issues still works as expected, as one file has been renamed. Filed 10931 for untranslatable CSV contents. - Tested that claiming late orders still works: * Table searching and sorting Works nicely, but some columns could be split up for better searching and sorting: * Order date: 20/01/2013 (245 days) * Total cost: 10.00x1 = 10.00 Books = item type should be separate * Basket: 10 MPL = Library and basket number could be separate columns * Filters * Combined various filters, search results look correct. * Selecting order for claiming * Limiting by vendor makes it possible to check/uncheck all * With no vendor limit, entries for other vendors will be locked after the first checkbox is checked for one vendor * Exporting as CSV * Exported single line CSV appears correct. * Exporting multiple lines CSV appears correct. PROBLEM: Translated CSV don't work correctly, as line breaks are lost in the translation process. * Sending serial claim email * No regressions found - there are some problems with the email contents noted on bug 7298. In order to reproduce the problem with translated CSV files make sure you test with updated po files containing a translated version of the header row or a copy of it. I think we already ran into this problem with the templates for the cart email, which are plain text and not HTML. Not sure how to solve this, but currently it seems not to work for translated templates at all as you will get all data on one single line. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Ketan Kulkarni ke...@carvingit.com changed: What|Removed |Added CC||ke...@carvingit.com --- Comment #121 from Ketan Kulkarni ke...@carvingit.com --- Yes, I see this problem in 3.12.4. (In reply to Serhij Dubyk from comment #112) In Koha 3.12 some encoding problems was returned. Currently found in 3 locations: http://localhost:/cgi-bin/koha/members/members-home.pl (main screen) http://localhost:/cgi-bin/koha/members/member.pl (search) http://localhost:/cgi-bin/koha/circ/circulation.pl (search and menu) http://localhost:/cgi-bin/koha/admin/preferences.pl (search for non-latin) Screenshots attached. Search by members completely can not be used in 3.12.0. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10724] Search by basket group on the parcel page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10724 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Looking at this now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10724] Search by basket group on the parcel page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10724 --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, this works as described. I think it would be a nice addition, if the basket group name was visible in the table of pending orders - it's a bit hard to see if you got correct results right now :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10724] Search by basket group on the parcel page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10724 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10724] Search by basket group on the parcel page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10724 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20326|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21311 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21311action=edit [PASSED QA] Bug 10724: Pending orders: add basket group name in filters This patch adds a new filter basket group name for pending orders searches. Test plan: Try different filters and check that results are consistent. Try to filter by basket group name. Signed-off-by: Pierre Angot tredok.pie...@gmail.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Applied on top of patches for bug 10723. Passes all tests and QA script. Tested combining different search options and checking results for correctness. Note: It's a bit irritating that the basket name is not shown in the list of pending orders, so there is no way to check the results are correct without checking from another page. Also, with a lot of pending orders in the system this page is very slow - I think it's a candidate for server side processing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10725] Add filters on the pending orders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10725 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, could you rebase? I applied it on top of 10723+24 and there was a small conflict. I tried fixing it, but it doesn't look right - the table headers are doubled up now for me. Could you take a look and retest? Thx! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #75 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, I am sorry, there are a couple of new conflicts now in this patch: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 8367: Add more granular level for ReservesMaxPickUpDelay Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging opac/opac-user.pl CONFLICT (content): Merge conflict in opac/opac-user.pl Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Reserves.pm CONFLICT (content): Merge conflict in C4/Reserves.pm Failed to merge in the changes. Patch failed at 0001 Bug 8367: Add more granular level for ReservesMaxPickUpDelay When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Patch left in /tmp/Bug-8367-Add-more-granular-level-for-ReservesMaxPi-BWSyFY.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added QA Contact|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #76 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Working on this now... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #77 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Happy to say that it applied cleanly and passed the automatic tests :) Continueing testing... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #20641|0 |1 is obsolete|| Attachment #20642|0 |1 is obsolete|| Attachment #20643|0 |1 is obsolete|| Attachment #20644|0 |1 is obsolete|| Attachment #20645|0 |1 is obsolete|| --- Comment #78 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21312 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21312action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a patron, note the patron's category 5) Issue an item to this patron 4) Edit that category, set Block expired patrons to Block 5) Verify the patron cannot renew or place holds in the opac 6) Edit the category again, set Block expired patrons to Don't block 7) Verify the patron *can* renew and place holds in the opac 8) Edit the category again, set Block expired patrons to Follow system preference BlockExpiredPatronOpacActions 9) Set the system preference BlockExpiredPatronOpacActions to Block 10) Verify the patron cannot renew or place holds in the opac 11) Set the system preference BlockExpiredPatronOpacActions to Don't block 12) Verify the patron *can* renew and place holds in the opac Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Melia Meggs me...@bywatersolutions.com Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de Testing notes on last patch in series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #79 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21313 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21313action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions - Followup Signed-off-by: Melia Meggs me...@bywatersolutions.com Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #82 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21316 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21316action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions - Followup 4 Some corrections : - opac-reserve.tt : opening p instead of closing - opac-user.tt : warnexpired was in database format, adds the use of KohaDates template plugin - opac-user.tt : duplicated TT test : [% IF ( BORROWER_INF.warnexpired ) %] and [% ELSIF ( BORROWER_INF.warnexpired ) %], maybe a merge error - opac-user.tt : string instead of strong, maybe for HTML 6 :-) - opac-user.pl : adding dateformat var to template is already done by Auth.pm Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests and QA script. Testing notes: - Database update * Changes to kohastructure match changes done by the updatedatabase statement. Feature is activated by default. Fixing 'yes' to be '1' in a follow up. * Ran database update succesfully. * Note: Patrons are now blocked by default in new installations AND in updated installations. - System preference * Verified system preference shows up correctly. - Category configuration * Add new patron category * Edit existing patron category * Delete patron category * Check patron category summary table. = Verified all actions work as expected. = Verified chosen value for BlockExpiredPatronOpacActions' is always displayed and saved correctly. * Note: The new value is missing from the summary table. * Note: The new value is also not shown when deleting a patron category. - Check functionality * Renew and place a hold for an NOT EXPIRED patron with a) category: use syspref (default) syspref: block (default) b) category: use syspref (default) syspref: don't block c) category: block syspref: don't block d) category: block syspref: block e) category: don't block sypref: block * Verified renewals and placing holds were never blocked. * Also verified that the warning from NotifyBorrowerDeparture still shows up correctly. * Renew and place a hold for an EXPIRED patron with a) category: use syspref (default) syspref: block (default) = OK, both actions are blocked. b) category: use syspref (default) syspref: don't block = OK, both actions possible. c) category: block syspref: don't block = OK, both actions are blocked. d) category: block syspref: block = OK, both actions are blocked. e) category: don't block sypref: block = OK, both actions possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #80 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21314 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21314action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions - Followup 2 * Hide renewal column, buttons and links * Fixes minor bug where upper-right table links would show even if renewal impossible * Cleans up some of the template formatting ( whitespace changes only ) Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #81 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21315 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21315action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions - Followup 3 Installer fixes : - in kohastructure.sql, category.BlockExpiredPatronOpacActions default value is -1, sets the same in updatedatabase.pl - in syspref comment, replaces opac actions such as placing a hold or reserve by opac actions such as placing holds or renrw books - A 'YesNo' does not have 'yes' as value in database, it is '1'. - corrects small typo categori and syspref name case Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #83 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21317 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21317action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 5 - Fixes a typo in one of the OPAC messages: you account - Fixes the updatedatabase script to use 1 instead of yes for the system preference default matching the sysprefs.sql file. - Fixes capitalization Don't Block in system preference description. - Adding . to the end of the warning, when renewals are blocked. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10932] New: Add BlockExpiredPatronOpacActions to summary table of categories and delete confirmaton
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10932 Bug ID: 10932 Summary: Add BlockExpiredPatronOpacActions to summary table of categories and delete confirmaton Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The new column BlockExpiredPatronOpacActions added by bug 6739 should show up on the summary when deleting a patron category and on the summary table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Blocks||10932 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10932] Add BlockExpiredPatronOpacActions to summary table of categories and delete confirmaton
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10932 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Depends on||6739 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #84 from Katrin Fischer katrin.fisc...@bsz-bw.de --- This is something that is quite annoying for some libraries and I feel like I have tested thoroughly (which probably means I missed something). So some automated regression tests would be very much appreciated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10530] PO number search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10530 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |BLOCKED Depends on||4456 --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I am marking this as BLOCKED, as it seems to depend on 4456, which doesn't apply - please set back if I am mistaken. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4456] Enable addition of PO Number to order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4456 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Blocks||10530 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10807] OPAC: There is no authority search history
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | --- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, could you take a look at the license and check if you want to update to GPL3? FAILC4/Search/History.pm OK pod FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 261) OK valid OK critic Continueing testing... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10807] OPAC: There is no authority search history
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #12 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, I wonder if PurgeSearchHistory should be moved into the new module, what do you think? It was introduced by bug 10361. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10807] OPAC: There is no authority search history
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA CC||gmcha...@gmail.com --- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Some more notes: 1) The subs in Search:History.pm don't seem to follow our usual naming conventions. I am a bit unsure about this. 2) Shouldn't Search_SearchHistory.t be Search_History.t? 3) Search_SearchHistory.t also fails for me: [~/kohaclone (52-10807-authoritysearchhistory)] prove t/db_dependent/Search_SearchHistory.t t/db_dependent/Search_SearchHistory.t .. 1/6 # Failed test 'use C4::Search;' # at t/db_dependent/Search_SearchHistory.t line 24. # Tried to use 'C4::Search'. # Error: AddSearchHistory is not exported by the C4::Search module # Can't continue after import errors at (eval 26) line 2 # BEGIN failed--compilation aborted at (eval 26) line 2. t/db_dependent/Search_SearchHistory.t .. 2/6 Undefined subroutine main::AddSearchHistory called at t/db_dependent/Search_SearchHistory.t line 39. # Looks like you planned 6 tests but ran 2. # Looks like you failed 1 test of 2 run. # Looks like your test exited with 255 just after 2. t/db_dependent/Search_SearchHistory.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 5/6 subtests Failing for 3), but please check with Galen about 1) if possible and take a look at the other comments. Thx! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8798] Add the use of DBIx::Class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10493] Add renewal script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10503] incorrect initialization parameters passed to Memoize::Memcached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10503 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10857] Add facets cancellation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Mathieu, did you have a chance to test? I would really like to see this happen :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #124 from Katrin Fischer katrin.fisc...@bsz-bw.de --- We have 12 people on the CC list for this bug, which makes me think it's kinda important :) Can someone weigh in about the perlcritic issues please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10837] Checkboxes are missing in Serial Claims 'Late Selections list'' . So I cannot do Exported selected items in my installations(v 3.12.0 and 3.12.3)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10837 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de --- It looks like that for me too - Harsha, could you upload a screenshot of your installation? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 --- Comment #32 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Kyle, could you take a look? I am not sure if I tested correctly and would like to know if the flag is supported by Koha in general or not :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10862] Add an search history for the staff interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10565] Add a Patron List feature for storing and manipulating collections of patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7710] multiple holds per title
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10493] Add renewal script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10857] Add facets cancellation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #12 from mathieu saby mathieu.s...@univ-rennes2.fr --- I made some tests : I was not satisfied, and had probably not related problems (I crashed my browers 3 times because of too big http header or something like that). I doubt it is related to this bug. So, I prefer someone else to test it. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10857] Add facets cancellation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #13 from mathieu saby mathieu.s...@univ-rennes2.fr --- And sandbox 3 crashed to, but probably for another reason... Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10503] incorrect initialization parameters passed to Memoize::Memcached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10503 --- Comment #10 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to Jonathan Druart from comment #8) Looks good to me, the patch works as expected on Debian Wheezy. This patch also corrects SQLHelper so that it no longer tries to use the deprecated (and removed) memcached_servers setting in koha-conf.xml; Why do you say that? it is still in used by Koha/Template/Plugin/Cache.pm and appears in debian/templates/koha-conf-site.xml.in. Should we remove these occurrences too? That would be a good idea, yes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Ketan Kulkarni ke...@carvingit.com changed: What|Removed |Added Status|In Discussion |Needs Signoff Assignee|dpav...@rot13.org |ke...@carvingit.com --- Comment #122 from Ketan Kulkarni ke...@carvingit.com --- Created attachment 21318 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21318action=edit An update to Templates.pm The patch is made against tag v3.12.04. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #21136|0 |1 is obsolete|| Attachment #21137|0 |1 is obsolete|| Attachment #21211|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21319 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21319action=edit [PASSED QA] Bug 10856: Improve the previous and next items on the shelf browser The next and previous links should completely refresh the shelf. For example: [] [1] [2] [3] [4] [5] [6] [] Before this patch, the next and previous links were the same as the 1 and 6. With this patch, after clicking on next, we will get: [] [7] [8] [9] [10] [11] [12] [13] [] This patch adds a new ajax script to get the shelf browser block. Test plan: - On a detail biblio page, click on a Browse shelf link. - Play with the next and previous links. - Deactivate Javascript (using NoScript for example) and check that you get the same behavior (but the page is reloaded). - Launch the unit tests: prove t/db_dependent/ShelfBrowser.t Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856 --- Comment #18 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21320 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21320action=edit [PASSED QA] Bug 10856: If callnumbers are equals, order should be on itemnumbers If a lot of items has the same callnumber, the order should be on the itemnumbers. Otherwise the left side is always filled with the same items. + Fix a bad c/p for the next link (when js is disabled). Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856 --- Comment #19 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 21321 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21321action=edit [PASSED QA] Bug 10856 [Follow-up] Improve the previous and next items on the shelf browser In Firefox at least, the shelf browser cannot be reopened after hiding it with the close shelf browser link. This followup improves the behavior of the close shelf browser link so that the shelf browser can be redisplayed. To test, open a bibliographic detail page in the OPAC and click a browse shelf link. Click the close shelf browser link--the shelf browser should be hidden. Click the original browse shelf link and the shelf browser should reappear without reloading the page. Test with Firefox and Chrome (at least). Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de All tests and QA script pass. Testing notes: - New unit tests in t/db_dependent/ShelfBrowser.t pass. - System preference OPACShelfBrowser still works as expected. - Closing and opening the shelf browser works as expected. - Next and Previous links show new and nicer behaviour. - Logs are clean. Tested with Firefox and Chromium under Ubuntu. Notes: The currently displayed record could maybe be highlighted a bit better. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9288] Add a script to test SIP from the command line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #23 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Kyle, it works now - using this line: misc/sip_cli_emulator.pl --a localhost --port 6001 --sip_user xxx --sip_pass xxx --location CPL --patron xxx --password xxx But I see 2 warnings, could you please fix those? main::help() called too early to check prototype at misc/sip_cli_emulator.pl line 46. Use of uninitialized value $terminator in string eq at misc/sip_cli_emulator.pl line 50. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7710] multiple holds per title
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Patch doesn't apply QA Contact|koha.sek...@gmail.com | --- Comment #52 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Kyle, could you please give feedback? (comment 50 and comment 51) There are also a couple of conflicts - I was not sure how to resolve the one in reserve.pl. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 7710 - multiple holds per title Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging reserve/request.pl CONFLICT (content): Merge conflict in reserve/request.pl Auto-merging opac/opac-reserve.pl Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging C4/Reserves.pm Failed to merge in the changes. Patch failed at 0001 Bug 7710 - multiple holds per title When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Patch left in /tmp/Bug-7710---multiple-holds-per-title-KL3g2b.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10853] Create CSV profiles with sql fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10853 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I see 2 problems with this: 1) The new SQL based CSV profiles show up in the OPAC download list, but they don't seem to work there. I think we probably need something to differentiate where the CSV profiles are offered - maybe similar to the 'module' of letters? 2) When editing a CSV profile, it redirects to the 'empty' form after saving. It would be better if it remained on the edited CSV profile, so the changes can be checked. Continueing testing with the dependent bugs/patches to see which changes those include. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10853] Create CSV profiles with sql fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10853 --- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de --- 3) Biggest question of all - I think we need some kind of documentation which tables can be used where? The examples refer to fields related to issues and subscriptions, but so far we only had CSV profiles in context of downloading bibliographic information from OPAC and staff search results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5031] CSV export profile form doesn't indicate that profile marcfields are required
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5031 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |In Discussion CC||katrin.fisc...@bsz-bw.de, ||oleon...@myacpl.org --- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, moving on from bug 10853 to this one. The highlighting of the required fields is a good addition, but the formatting seems a bit non-standard. Maybe check Owen's work on bug 6209? Putting 'In Discussion' and adding Owen in CC in hope for some feedback. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial claims
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Some notes: 1) This will conflict with bug 7298 which is close to pass QA but currently failed qa for serials/lateissues-excel.pl being renamed. 2) As noted on 10853 I think we need a way to prevent this CSV profile from showing up in OPAC and the staff client where it does not work. One solution I could think of is adding a 'module' column or similar to indicate where the profile should be displayed. 3) There is an error in the databaseupdate SQL statement: [Sun Sep 22 22:15:20 2013] updatedatabase.pl: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'SUPPLIER=aqbooksellers.name|TITLE=subscription.title|ISSUE NUMBER=serial.serial' at line 1 at /home/katrin/kohaclone/installer/data/mysql/updatedatabase.pl line 7175. Applying the SQL directly to my database worked - not sure what's wrong here. INSERT IGNORE is not needed, but instead we'd need another way to prevent duplicates - the profile column is not unique. Failing QA to get some feedback about 2) and 3). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10853] Create CSV profiles with sql fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10853 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I think we need to solve 1) before we can start making wide use of this feature - showing non-functional CSV profiles in the OPAC could cause quite a lot of confusion. (It shows in the cart download option list) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #37 from Katrin Fischer katrin.fisc...@bsz-bw.de --- (In reply to Jonathan Druart from comment #36) ping Kyle, we are close to finish! Is a rebased code from Tamil or the first patch contains a bad c/p of the license? Kyle, we need your feedback on this! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and upgrade
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Colin, can you explain what difference this will make in using Koha with ICU indexing? What is the problem and how can I reproduce it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10626] Remove doubled up TT plugins
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Blocks||8004 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8004] Items on hold lose transfer after being scanned twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA Depends on||10626 Severity|enhancement |normal --- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Kyle, I am afraid this conflicts with 10626 - could you check please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10773] Replace item-level codes with names/descriptions for Label Printing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 --- Comment #5 from David Cook dc...@prosentient.com.au --- (In reply to Kyle M Hall from comment #4) One question, might it not still be useful to be able to print the codes directly for terseness? Since printing the code is the current default, perhaps these should be ccode_description, homebranch_description, etc instead? I have no idea if or how these codes are used in practice, so I do not feel qualified to make such a call, but I think it's a pertinent question at least. Certainly a pertinent question, Kyle! I was pondering it last week a little bit. I was wondering if any libraries print their branch code on their spine label or on other labels they might apply to resources. I would think that printing on the spine label would be a bizarre choice, but I suppose one never knows... I like the idea of ccode_description, homebranch_description, etc., although I can't remember how straightforward those would be to implement. Still, as you say, since the code is the current default, it might make more sense to add a new option rather than changing the default. If this change were pushed, we might find some libraries quite surprised that their labels suddenly are very different. As far as I know, I only have one library using the branch code, and they're the ones who wanted the description, but like I was saying...you never know. I'll have to ponder this one some more at some point... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
