[Koha-bugs] [Bug 11057] New: Bootstrap theme: Don't hide language chooser below the fold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057 Bug ID: 11057 Summary: Bootstrap theme: Don't hide language chooser below the fold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: mag...@enger.priv.no QA Contact: testo...@bugs.koha-community.org Depends on: 10309 Created attachment 22008 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22008action=edit The chosen language is displayed above the other text in the language chooser With the (beautiful!) new theme based on Bootstrap, even if there is not a lot of stuff on the front page of the OPAC, the language chooser is hidden below the fold, so you have to scroll to see it. I needed to have it pointed out to me by someone who was already aware of this, so I think there is a good chance more people will be confused by it. Also, the chosen language is displayed a bit wonky, see attached screenshot. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added Blocks||11057 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Attachment #21974|0 |1 is obsolete|| --- Comment #7 from Colin Campbell colin.campb...@ptfs-europe.com --- Created attachment 22009 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22009action=edit Amended patch Changed test to be definedness only so it meets the case Galen spotted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996
--- Comment #8 from Colin Campbell colin.campb...@ptfs-europe.com ---
(In reply to Galen Charlton from comment #6)
Comment on attachment 21974 [details] [review]
Bug 10996 Allow numeric subfields to be stripped on export
Review of attachment 21974 [details] [review]:
-
::: tools/export.pl
@@ +365,5 @@
+my $subfield = $2;
+
+# skip if this record doesn't have this field
+next if not defined $record-field($field);
+if ($subfield) {
This is not the right test -- consider somebody who wants to exclude a
subfield $0 (zero) from export.
Amended patch to cover this case.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11058] New: Compile time warning issued by C4/Record.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11058 Bug ID: 11058 Summary: Compile time warning issued by C4/Record.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: colin.campb...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org Compile time warning in C4/Record.pm: perl -wc C4/Record.pm my variable $stylesheet masks earlier declaration in same scope at C4/Record.pm line 313. similar with anything using C4::Record there are two lexical variable $stylesheet in the same sub. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11058] Compile time warning issued by C4/Record.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11058 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |colin.campbell@ptfs-europe. ||com --- Comment #1 from Colin Campbell colin.campb...@ptfs-europe.com --- Created attachment 22010 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22010action=edit Proposed Patch Simple renaming of second stylesheet variable. To test without the patch perl -wc C4/Record.pm issues a warning with the patch perl -wc C4/Record.pm issues mo warning -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11059] New: Not possible to sort staged dates in metric format
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Bug ID: 11059 Summary: Not possible to sort staged dates in metric format Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: k...@univ-lyon3.fr QA Contact: testo...@bugs.koha-community.org Created attachment 22011 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22011action=edit Not possible to sort staged dates in metric format In 'Add order to basket' page, when importing from staged file, it was not possible to sort the dates if the metric format is used. The reason is that dt_add_type_uk_date function and call to it were missing. I set no default sorting in datatable parameters. Anyhow the sorting is made on staged date desc by perl and I suppose it's what users are expecting ? I suppressed a split of timestamp data in addorderiso2709.pl because it seems to me that it's useless (but not sure of it.) Olivier Crouzet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric format
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Koha Team Lyon 3 k...@univ-lyon3.fr changed: What|Removed |Added Status|NEW |Needs Signoff CC||k...@univ-lyon3.fr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric format
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Koha Team Lyon 3 k...@univ-lyon3.fr changed: What|Removed |Added Attachment #22011|0 |1 is obsolete|| --- Comment #1 from Koha Team Lyon 3 k...@univ-lyon3.fr --- Created attachment 22012 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22012action=edit Bug 11059 not possible to sort staged dates in metric format -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11058] Compile time warning issued by C4/Record.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11058 --- Comment #2 from M. Tompsett mtomp...@hotmail.com --- Created attachment 22013 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22013action=edit [SIGNED OFF] Bug 11058: make variable name unique within its scope routine declares two lexical variables named $stylesheet rename the second to keep code clearer and avoid propagating compile time warnings Signed-off-by: Mark Tompsett mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11058] Compile time warning issued by C4/Record.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11058 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11058] Compile time warning issued by C4/Record.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11058 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #22010|0 |1 is obsolete|| CC||mtomp...@hotmail.com --- Comment #3 from M. Tompsett mtomp...@hotmail.com --- Comment on attachment 22010 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22010 Proposed Patch This is now obsolete. mtompset@ubuntu:~/kohaclone$ git checkout -b bug_11058 origin/master Branch bug_11058 set up to track remote branch master from origin. Switched to a new branch 'bug_11058' 1) Confirmed Problem. mtompset@ubuntu:~/kohaclone$ perl -wc C4/Record.pm my variable $stylesheet masks earlier declaration in same scope at C4/Record.p m line 313. C4/Record.pm syntax OK 2) Looked at code: mtompset@ubuntu:~/kohaclone$ vi C4/Record.pm The code has a parameter passed named stylesheet, and a variable declared stylesheet. The parameter is used to set other variables which feed into this secondary declaration. So, renaming this variable is a good solution and should not cause any problems. 3) Applied patch mtompset@ubuntu:~/kohaclone$ git bz apply 11058 Bug 11058 - Compile time warning issued by C4/Record.pm 22010 - Proposed Patch Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11058: make variable name unique within its scope 4) Confirmed problem solved. mtompset@ubuntu:~/kohaclone$ perl -wc C4/Record.pm C4/Record.pm syntax OK 5) Decided to run koha-qa.pl on it for kicks. mtompset@ubuntu:~/kohaclone$ ~/qa-test-tools/koha-qa.pl -v 2 -c 1 testing 1 commit(s) (applied to 0f5dc60 'Bug 10309: (follow-up) restore settin') OK C4/Record.pm OK pod OK forbidden patterns OK valid 0 OK critic 6) Signed it off. mtompset@ubuntu:~/kohaclone$ git so 1 Rewrite ffff1071b4a14251d5ecd80bfad07f567e4b (1/1) Ref 'refs/heads/bug_11058' was rewritten mtompset@ubuntu:~/kohaclone$ git commit --amend [bug_11058 72c273c] [SIGNED OFF] Bug 11058: make variable name unique within its scope Author: Colin Campbell colin.campb...@ptfs-europe.com 1 file changed, 3 insertions(+), 3 deletions(-) 7) Attached it. mtompset@ubuntu:~/kohaclone$ git bz attach 11058 HEAD Bug 11058 - Compile time warning issued by C4/Record.pm 72c273c [SIGNED OFF] Bug 11058: make variable name unique within its scope Attach? [yn] y Attached SIGNED-OFF-Bug-11058-make-variable-name-unique-wit.patch 8) And now obsolete the old one, and make sure the status is right. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #29 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Fridolyn SOMERS from comment #28) What is missing to pass QA ? Please see comment 26 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11060] New: Bootstrap theme: Incorrect rendering for R2L languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060 Bug ID: 11060 Summary: Bootstrap theme: Incorrect rendering for R2L languages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: bgkrie...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 22014 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22014action=edit opac-bootstrap-l2r New bootstrap theme do not render correctly for R2L languages like Arabic. Good: Search bar Not good: Advance search, auth search etc, are rendered correctly but there is too much space from the right Bad: Top (black) bar, Main result box, language chooser (hidden below as noted on Bug 11057) Attached bootstrap screen capture and ccsr for comaparison. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11060] Bootstrap theme: Incorrect rendering for R2L languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060 --- Comment #1 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 22015 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22015action=edit opac-ccsr-l2r -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11060] Bootstrap theme: Incorrect rendering for R2L languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Depends on||10309 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Blocks||11060 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added CC||colin.campbell@ptfs-europe. ||com --- Comment #30 from Colin Campbell colin.campb...@ptfs-europe.com --- Comment 27 is misleading you cant use a string as a hash_ref in any release of perl. A variable called $results suggests theres a bit of confusion here. Meaningless variable names should be avoided, and we should be more explicit as to what we are testing. Another reason for failing QA is that a lexical dirhandle is replaced by the global DIR. That's surely a backward move -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11061] New: Koha::Calendar::_mock_init is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11061 Bug ID: 11061 Summary: Koha::Calendar::_mock_init is unused Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: jonathan.dru...@biblibre.com QA Contact: testo...@bugs.koha-community.org Bug 9209 removes the only occurrence to Koha::Calendar::_mock_init The routine can be removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #26 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 22016 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22016action=edit Bug 7376 - Transfer limits should be checked at check-in Extended UseBranchTransferLimits-check to the check-in case. Made it possible to override the check-in with circulation-permission if BranchTransfer is denied. Made unit tests for the C4/Circulation.pm and C4/SIP/t/08checkin.t *Also added override-functionality to Circulation::AddReturn() to override BranchTransferLimits. (+unit tests) *Renamed CanBookBeReturned to CanItemBeReturned since that function was referenced from AddReturn only. --This is because function name misguidingly references to a book/Biblio/Title-level, even if the functionality is strictly --Item dependent. *Removed duplicating code by making CheckBranchTransferAllowed() call IsBranchTransferAllowed(). *Made a unit test library out of CheckBranchTransferAllowed.t's environment initialization parts, so these need not be duplicated whenever UseBranchTransferLimits-related functionality is tested. *Documented SIP-testing hardships to C4/SIP/README -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #21715|0 |1 is obsolete|| Attachment #21805|0 |1 is obsolete|| --- Comment #27 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 22017 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22017action=edit Manual test cases -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9209] Mocked Koha::Calendar tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9209 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||11061 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11061] Koha::Calendar::_mock_init is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11061 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Depends on||9209 Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11061] Koha::Calendar::_mock_init is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11061 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 22018 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22018action=edit Bug 11061: Koha::Calendar::_mock_init is unused Bug 9209 removes the only occurrence to Koha::Calendar::_mock_init The routine can be removed. Test plan: prove t/Calendar.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7288] Invoice improvements - Show only subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 --- Comment #7 from Paola Rossi paola.ro...@cineca.it --- The applying (against master 031) of the patch is OK. I've created some invoices for subscriptions' orders and some invoices not. When the checkbox Show only subscriptions is not checked, the patch works well and all the invoices are shown in the invoices table. On the contrary, when the checkbox Show only subscriptions is checked, no invoice is shown in the invoices table. Is it OK? This is the part of the patch about selecting only subscription' invoices: resultst.fnFilter( [0-9]+, 0, true ) Can I create the situation with [0-9+] and see the list of the subscriptions' invoices shown? Thanks. When I see an invoice (from column Invoice no. of the invoices table) and the invoice is not a subscription' one, I see Invoice details with a following table full of dates (Summary Publisher etc). When I see an invoice (from column Invoice no. of the invoices table) and the invoice is a subscription' one, I see Invoice details followed by No orders yet. On the contrary the order is present in bd: it is listed by Orders-search' results table of Acquisitions, and is linked to the subscripted serial. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8074] Define default library for holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074 --- Comment #3 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 22019 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22019action=edit Bug 8074 - Define default library for holds to pull report Modified the BIG SQL in pendingreserves.pl to limit the hold requests shown by the items.holdingbranch. The behaviour mimics IndependentBranches behaviour. Also added a branch picker to circ/pendingreserves.tt with an optional Show all requests-option. Changed the form from post to get so librarians can bookmark the page. Made stuff localizable! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8074] Define default library for holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff CC||olli-antti.kivila...@jns.fi --- Comment #4 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- xx x TEST CASES x xx No prerequisites By default the requested list is calculated based on the current staff client branch set. (Circulation - Set Library) xx cgi-bin/koha/circ/pendingreserves.pl TEST CASE1: 1. Change branch limiter from the select-list. 2. Clear the date fields, Start date and End date. 3. Press Submit. 4. Enjoy! 5. Bookmark the url. If Date-fields are empty, defaults are calculated and url can be reused on some future day. TEST CASE2: 1. Select the Show all requests. 2. Submit. 3. Behold all holds pull requests across all branches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8074] Define default library for holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9721] Umbrella report for hold changes to meet special library needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9721 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff CC||olli-antti.kivila...@jns.fi --- Comment #6 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Sponsored by the Joensuu Regional Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8074] Define default library for holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Assignee|fridolyn.som...@biblibre.co |olli-antti.kivila...@jns.fi |m | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9721] Umbrella report for hold changes to meet special library needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9721 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #7 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Not sponsored! I made an error since bugzilla throws me to another bug every time I make changes to existing bugs and that is distracting! Can delete this comment and my previous one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8074] Define default library for holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074 --- Comment #5 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Sponsored by the Joensuu Regional library. Sorry for stealing this bug, but it was so easy to fix and our librarian is complaining about this issue, so I needed to get it solved asap to convince our team that Koha is superior! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9721] Umbrella report for hold changes to meet special library needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9721 --- Comment #8 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Olli-Antti Kivilahti from comment #7) Not sponsored! I made an error since bugzilla throws me to another bug every time I make changes to existing bugs and that is distracting! Can delete this comment and my previous one. No, that is not possible. So be very careful :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9224] acqui/finishreceive.pl is not Plack-compatible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9224 Jacek Ablewicz a...@biblos.pk.edu.pl changed: What|Removed |Added Status|NEW |ASSIGNED CC||a...@biblos.pk.edu.pl Assignee|koha-b...@lists.koha-commun |a...@biblos.pk.edu.pl |ity.org | --- Comment #1 from Jacek Ablewicz a...@biblos.pk.edu.pl --- Created attachment 22020 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22020action=edit [PATCH] Bug 9224: Make acqui/finishreceive.pl Plack-compatible -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9224] acqui/finishreceive.pl is not Plack-compatible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9224 --- Comment #2 from Jacek Ablewicz a...@biblos.pk.edu.pl --- Under Plack/mod_perl wrapping, sub update_item() will become a closure, so after the 1st run it will retain it's own private instances of the following variables: $booksellerid, $datereceived, $unitprice, $rrp, $biblionumber. I.e., in case update_item() gets invoked 2nd+ time (inside the same process, but for different-subsequent receives) it may incorrectly flag the (old, wrong) biblionumber for Zebra reindexing, and erronously modify the current item[s] with the previously used (wrong) values. This simple patch should make acqui/finishreceive.pl Plack-compatible. Test plan: Test patched acqui/finishreceive.pl script (create and receive some orders w/ items, etc.). Ensure items are gettting added and/or modified correctly during receiving process. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11062] New: Invoice's shipment/shipping cost should be included PRE-gst tax (as an option)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062
Bug ID: 11062
Summary: Invoice's shipment/shipping cost should be included
PRE-gst tax (as an option)
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Acquisitions
Assignee: koha-bugs@lists.koha-community.org
Reporter: philippe.blo...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
Here in Canada, invoices items should be included in the following order:
Price
Shipment
Taxes
Subtotal
Total
At least, as an option. Right now, our library gets the wrong Total since
shipping is added to the subtotal, not including the taxes.
I looked for preferences, but the code seemed very clear in acqui/invoice.pl:
my $total_gsti_shipment = $total_est_gsti + $details-{shipmentcost};
Unless a nice solution already exists, I think this ordering should be
customizable.
Comments and input (on what else should be affected) are very welcomed.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11062] Invoice's shipment/shipping cost should be included PRE-gst tax (as an option)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 Blou philippe.blo...@inlibro.com changed: What|Removed |Added CC||eric.be...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #31 from Srdjan Jankovic srd...@catalyst.net.nz --- Yes, sorry I misread the comment, I thought it was about if(%hash) vs if( keys %hash) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7214] can't change framework when editing record as duplicate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7214 --- Comment #2 from Nicole C. Engard neng...@gmail.com --- This is an issue that came up at KohaCon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11064] New: batch import ignoring framework choice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11064 Bug ID: 11064 Summary: batch import ignoring framework choice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl When importing batches of bib records if you choose a framework and no matter what you choose it imports as default. Your choice is ignored. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10906] Reimported records into Koha are imported only as DEFAULT frameworks, not what they were originally
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added CC||neng...@gmail.com --- Comment #1 from Nicole C. Engard neng...@gmail.com --- I want to add to this that the problem is also a language issue - the text says Add new bibliographic records into this framework but the records in question aren't 'new' so that's where part of the confusion occurs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11065] New: List of imported biblios is too small - increase to a larger number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11065
Bug ID: 11065
Summary: List of imported biblios is too small - increase to a
larger number
Change sponsored?: ---
Product: Koha
Version: 3.12
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Tools
Assignee: gmcha...@gmail.com
Reporter: d...@randomnotes.org
QA Contact: testo...@bugs.koha-community.org
Usability fix to MARC importing:
When importing biblios using the MARC importing tools, the list of imported
MARC records are display in pages of 25 biblios each. This means on larger
imports (100s or 1000s of biblios) you have to page through way too many pages
to find import issues. This process can be facilitated by returning much
larger lists. We have changed this to 500 entries and its much easier to work
with large imports with this size of returned results.
Steps to reproduce:
1. Create a MARC import file with 1000 unique MARC records
2. Upload the file
3. Import the file to the reservoir.
4. You are now looking at the import results page displayed by
manage-marc-import.pl with 25 results displayed, and a total of 40 pages to
view to see all the import success/failures.
Desired
Reviewing all these pages is tedious. Less pages will be much better.
Fixing this is a one line change to
library:/usr/share/koha/intranet/cgi-bin/tools# diff
tools/manage-marc-import.pl*
50c52
my $results_per_page = $input-param('results_per_page') || 25;
---
my $results_per_page = $input-param('results_per_page') || 500;
(This was also the consensus of the Cataloging roundtable at KohaCon2013. I
volunteered to submit the bug and a formal fix.)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #2 from mathieu saby mathieu.s...@univ-rennes2.fr --- Created attachment 22021 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22021action=edit [PATCH] Bug 9807 : Make possible to view a basketgroup without reopening it This patch make possible to view an individual closed basketgroup without reopening it. - It adds a new View button on closed basketgroup list - It creates a view for closed basketgroups, with 3 buttons (reopen, print, export) - It adds a delete button on standard edit view (for open basketgroup) To test : 1/ regression test : - create some empty basketgroups - create some basketgroups by closing baskets - in the list of basketgroups closed and opened, check you can use the buttons that existed before the patch (close and print, delete, export, print, reopen) - click on Edit to edit a opened basketgroup : check everything is like before : -- change the billing and delivery places, -- add a note, -- put some new baskets in the bg, -- remove baskets from it -- save it without checking close box = it must be save but kept open -- edit it again, and make other some changes (define a free delivery place for example) -- save it with checking close = it must be saved but closed 2/ new feature test - click on view button on top right column of some closed basketgroup - check all the displayed informations are correct (places, free place, note, list of baskets) - check you can not change anything - click on print button = check a pdf is created - click on export button = check a csv is created - click on reopen button = you must stay on the same basketgroup, but it is now open and you can make some changes - go back to the basketgroup list of the vendor. Check the reopened bg is in open tab - click on edit - click on new delete button = the bg must be deleted, and you are redirected to the bg list of the vendor. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11066] New: Export Citations not RDA compatible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11066 Bug ID: 11066 Summary: Export Citations not RDA compatible Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: j...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Exporting citations does not include the 264 tag for publisher information. Bibtex uses 260 tag, subfields $a address, $c Year, $b Publisher $f Editor Endnote uses 206$a City 260$c Year 710$a Publisher RIS uses 260 for publisher data. For Marc records that are RDA records, the publisher information is contained in the 264 tag.Can we update the export parameters to pull from the 264 and/or the 260? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
