[Koha-bugs] [Bug 10451] Firefox prints only first page of table with shrink to fit option
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10451 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10451] Firefox prints only first page of table with shrink to fit option
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10451 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #19007|0 |1 is obsolete|| --- Comment #9 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 24049 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24049action=edit Bug 10451 - Firefox prints only first page of table with shrink to fit option According to Firefox bug tracker, versions up to 21 doesn't print tables correctly when using shrink to fit option. See: https://bugzilla.mozilla.org/show_bug.cgi?id=684622 However, even with v21 or newer, we still need to add css to print media which instruct it not to break table tag to print all pages of table. This has a side-effect that table starts always on next page, wasting some space on first printed page (but only in Firefox since CSS selector is specific to it). Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10845] Multi transport types for holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 --- Comment #13 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Reading your test cases, and good job with the description! There is one concern! What if a patron defines to his own messaging preferences sms and email, but has no sms notification number defined nor email. This can easily be done accidentally. This might needlessly bloat our print notifications queue and cause lots of extra costs. Would it be possible to add a check that; if email or sms is succesfully sent, even if the other email or sms has failed, no print notice is generated. This is slightly problematic to implement but shouldn't be too difficult. Also a patron can request email and sms, buth have no such contact details. In this case the email is sent via print notice + the sms replaced with another print notice! In addition there should be a check in place to enforce that a patron cannot set his messaging preferences if sms or email is missing, but that is not in this bug's scope. Or is it the only way to send HOLD notifications via print? What if our patrons don't have sms or email? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10845] Multi transport types for holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845 --- Comment #14 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- BTW Could apply this patch now! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10845] Multi transport types for holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845
--- Comment #15 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
If I have had email and sms defined, but subsequently removed those contact
details, I suspect this condition brings falsehood:
if ( ($mtt eq 'email' and not $to_address) or ($mtt eq 'sms' and not
$borrower-{smsalertnumber}) ) {
$to_address and $borrower-{smsalertnumber} are defined as empty Strings and
validate true in Perl.
Thus I have been unable to trigger the double print notification bug, but
instead got sms and email notifications with destination of '' == empty String
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11504] New: Untranslatable Item Type or Collection Code in branch transfer limits
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11504 Bug ID: 11504 Summary: Untranslatable Item Type or Collection Code in branch transfer limits Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kalli...@pttk.fi QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr The string Item Type or Collection Code shows up in branch transfer limits, eg. in the text For all Item Types:, and does not come via the i18n toolchain. The text is hard-coded in admin/branch_transfer_limits.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 --- Comment #25 from Fridolin SOMERS fridolyn.som...@biblibre.com --- (In reply to mathieu saby from comment #23) I did not read all the comments, but for some libraries, what is needed in statistical table is BOTH items.itype and biblioitems.itemtype, and maybe a clear indication (a 3rd column circulation_type ?) of which type is was used for circulation rights. Very good idea. I think more information will be better for many libraries. But in another bug because it will be an enhancement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11505] New: Untranslatable table headers in Label batch manager
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11505 Bug ID: 11505 Summary: Untranslatable table headers in Label batch manager Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kalli...@pttk.fi QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr In Label Batch manager, after adding the items to the batch, you're presented with a table showing information about the items. The table column headers are in English, and cannot be translated. The texts are hard-coded in $display_columns in labels/label-edit-batch.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11506] New: Untranslatable table headers in several perl files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11506 Bug ID: 11506 Summary: Untranslatable table headers in several perl files Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kalli...@pttk.fi QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr html_table headers are hard-coded (and therefore untranslatable) in label/label-item-search.pl, label/label-manage.pl, patroncards/edit_batch.pl, patroncards/manage.pl, patroncards/image-manage.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11397] Displaying itemnumber list on the Acquisition detail tab is useless
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11397 --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24050 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24050action=edit Itemnumbers are display without the patch Hi Nicole, Here a screenshot of a detail page (acquisition details tab). You can see that itemnumbers are displayed, without the patch. If you apply the patch, they disappear. See comment 30 and comment 32 from bug 8230. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8007] Discharge management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #45 from Jonathan Druart jonathan.dru...@biblibre.com --- Thanks all 3 of you for your looks! The idea of Service and DataObject was to separate methods for a discharge object from others routines which are not directly linked to the object (Manager). Don't you think if we put all the code in a Koha::Discharge package we will get back to a new Koha namespace with big files where responsibilities are not enough separated? What is the problem with having a simple business object? I don't understand where the complexity is added, to me it is simplified. Should I put all methods/routines from Service::Discharge and DataObject::Discharge to Koha::Discharge? I personally think we should not call Koha::Database in pl files, do we agree with that? If you think it is not the way to do, where can I find a RFC / consensus on how developers should develop using oop into Koha? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11141] Filters are not kept on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #22412|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24051 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24051action=edit Bug 11141: Filters are not kept on receiving. On receiving orders, the librarian has to filter again the pending orders list. This patch stores the filters in a cookie in order to apply them when the librarian finish a receive and come back on the pending orders list. Test plan: 1/ choose a vendor with several baskets and orders. 2/ start to receive an item. 3/ on the pending orders page, add some relevant filters. 4/ receive an item. 5/ you are back on the pending orders page and filters are directly applied. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11141] Filters are not kept on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141 --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Last patch is just a rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11507] New: add the possibility to filter order by parent_ordernumber in receipt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11507 Bug ID: 11507 Summary: add the possibility to filter order by parent_ordernumber in receipt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: k...@univ-lyon3.fr QA Contact: testo...@bugs.koha-community.org After a transfer of order in a new basket, the ordernumber is changing. Sometimes, we keep a track the old ordernumber so it can be usefull to be able to retrieve the order by the old ordernumber. This patch add the possibility, when receiving shipment, to enter the old ordernumber and to retrieve the order. Test plan : - choose an order and notes its ordernumber - transfer it to a new a basket and notes the new ordernumber _ in receipt page, in the filter box, enter the older ordernumber or the new ordernumber: you can find the order -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #144 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24053 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24053action=edit Bug 7180: FIX getAuthValueDropbox should display the selected value If the no AV match the name/category or if no category is defined, the input field should contain the value. Signed-off-by: Pierre Angot tredok.pie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #145 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24054 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24054action=edit Bug 7180: Add UT for C4::Budgets::GetBudgetByCode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #22546|0 |1 is obsolete|| Attachment #22547|0 |1 is obsolete|| Attachment #22548|0 |1 is obsolete|| Attachment #22549|0 |1 is obsolete|| Attachment #22550|0 |1 is obsolete|| Attachment #22551|0 |1 is obsolete|| Attachment #22552|0 |1 is obsolete|| Attachment #22553|0 |1 is obsolete|| Attachment #22554|0 |1 is obsolete|| Attachment #22555|0 |1 is obsolete|| Attachment #22556|0 |1 is obsolete|| Attachment #22557|0 |1 is obsolete|| Attachment #22558|0 |1 is obsolete|| Attachment #22559|0 |1 is obsolete|| --- Comment #143 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24052 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24052action=edit Bug 7180: Order from staged file improvements This patch adds: - 1 syspref MarcFieldsToOrder - 1 ajax script acqui/ajax-getauthvaluedropbox.pl - 1 routine C4::Budgets::GetBudgetByCode Before this patch you were not able to order 1 or all the records from your staged file. You were allowed to specify some information (Import All and Accounting details areas) for the order. With this patch, the previous behaviours still exist. But now you can *select* which records you want to ordered. For these ones you can specify independently informations (Quantity, price, budget, sort1 and sort2). The cherry on the cake is that you can pre-fill these information with values Test plan: 1. Fill the new syspref MarcFieldsToOrder with something like: ==BEGIN== price: 947$c quantity: 969$h budget_code: 922$a rrp: 010$d discount: 969$d sort1: 923$a sort2: 924$a ==END== The empty line at the end is mandatory! The budget (corresponding to your budget_code) can be filled with authorized value categories (statistic 1 and 2). The sort1 and sort2 values can be filled with the an authorized value (of the category previously selected) 2. Choose randomly one or more biblio(s) and fill fields with what is relevant. 3. Export the biblio and import it (with the Stage MARC records for import tool). 4. Go on a basket and add an order from a staged file. Select your staged file. 5. Well. Now you can see your biblio (or biblios if your had exported more than one). For each one, informations should be pre-filled with the biblio values. The budget should be selected on the budget corresponding to the budget_code (in the field 922$a) and the planning values too (with fields 923$a and 924$a). You can modify these values (or not) and choose a default value for budget and planning values (in the Accounting details area). 6. Save and check the prices values. Modify the order and check that budget and sort* are good Prices are calculated following some parameters: if there is no price = listprice = 0 else = - the gstrate value for your order is the gstrate value of the bookseller - discount = if filled : the discount value / 100 else: the discount value of the bookseller - if the bookseller includes tax( List item price includes tax: Yes ) if a discount exists: ecost = price rrp = ecost / ( 1 - discount ) else: # a discount does not exist ecost = price * ( 1 - discount ) rrp = price else # the bookseller does not include tax if a discount exists: ecost = price / ( 1 + gstrate ) rrp = ecost / ( 1 - discount ) else: # a discount does not exist rrp = price / ( 1 + gstrate ) ecost = rrp * ( 1 - discount ) - in all cases: listprice = rrp / currency rate unitprice = ecost total = ecost * quantity 7. Retry with different parameters 8. Check the 'Import all' action still works -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #150 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24059 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24059action=edit Bug 7180: Adapt neworderempty code (js function moved). The js function fetchSortDropbox has been deleted in previous patch. The new function is getAuthValueDropbox. Test plan: - link some av to some funds - open an existing order and verify value are correctly filled in the sort1 and sort2 values - create a new order and verify behavior is the same as before Note: This patch generates 2 ajax queries (max) if the budget is linked to 2 av categories for sort1 and sort2. This could be improved using a template plugin for values display on load. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #146 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24055 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24055action=edit Bug 7180: QA followup Ergonomic improvements: - Remove the green color the selected record. - Use fieldset.rows (and legend). - Use the required css class for quantity inputs. - Replace budget with fund. - fix the undefined string - Add a show MARC link - replace no_match with a text. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #148 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24057 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24057action=edit Bug 7180: Follow-up fixing minor issues - Fixed some labels from Budget to Fund - Added the system preference to sysprefs.sql - Fixed some untranslatable Javascript strings Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #147 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24056 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24056action=edit Bug 7180: The default quantity is 1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #149 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24058 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24058action=edit Bug 7180: Change syspref description - the blank line is now useless - add an example for the syspref value -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #153 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24062 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24062action=edit Bug 7180 - QA Followup - Correct minor language issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #151 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24060 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24060action=edit Bug 7180: FIX License version Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #154 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24063 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24063action=edit Bug 7180: Restore the Add order link -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #152 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24061 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24061action=edit Bug 7180: QA followup - fix unit tests (use a transaction). - add 3 tabs on the page in order to be more understandable. - fix a warn in logs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #157 from Jonathan Druart jonathan.dru...@biblibre.com --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #156 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24065 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24065action=edit Bug 7180: FIX: discount was divided by 100 twice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #155 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24064 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24064action=edit Bug 7180: Remove useless rrp variable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580
--- Comment #11 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 16778
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16778
Proposed patch (v2)
Review of attachment 16778:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=9580attachment=16778)
-
::: koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
@@ +305,5 @@
+[% IF ( CoceProviders ) %]
+KOHA.coce.getURL('[% CoceHost %]', '[% CoceProviders %]');
+[% END %]
+
This disappeared.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580
--- Comment #10 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 15203
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15203
Proposed patch
Review of attachment 15203:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=9580attachment=15203)
-
::: koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
@@ +305,5 @@
+[% IF ( CoceProviders ) %]
+KOHA.coce.getURL('[% CoceHost %]', '[% CoceProviders %]');
+[% END %]
+
This was here from the beginning.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #12 from M. Tompsett mtomp...@hotmail.com --- Comment on attachment 21162 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21162 Proposed patch (v3 rebased on master) Review of attachment 21162: -- (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=9580attachment=21162) - ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt @@ +333,4 @@ [% IF OPACLocalCoverImages %]KOHA.LocalCover.GetCoverFromBibnumber(false);[% END %] [% IF ( GoogleJackets ) %]KOHA.Google.GetCoverFromIsbn();[% END %] + HEAD I think a rebase didn't quite work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged MARC records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477 --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24067 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24067action=edit Bug-10477-Alter table import_batches Added overlay_action to appendmarctag and new column marctag -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged MARC records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- Rebased patches. I did not test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged MARC records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #22536|0 |1 is obsolete|| Attachment #22537|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24066 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24066action=edit Bug-10477 Increased flexibility for upload of Staged When uploading bulk MARC records against existing records need further option to allow the process to just add/merge extra MARC tags rather than having to completely overwrite an existing record or just leave the existing record unchanged. Test Plan: 1. Click on Tools-Stage MARC records for import. 2. Upload the MARC file for ex: first.mrc 3. Click on upload button. 4. Choose Record matching rule: 020$a ISBN. 5. Choose Action if matching record found: Append or update MARC21/UNIMARC tag a text box will appear after choosing enter MARC tag for ex: 700a which you want to merge. 6. Click on Stage for import button. 7. On the next screen click on Manage staged records. 8. You can also edit the record matching rule in manage record screen. 9. Click on Import this batch on catalog button. 10. Next screen will give no of record updated. 11. It will check duplicate field record for ex: 700$aamit is already in record it will skip the tag and move to next. Signed-off-by: Amit Gupta amitddng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11023] Toggle new status for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #22386|0 |1 is obsolete|| Attachment #22734|0 |1 is obsolete|| Attachment #22735|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24068 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24068action=edit Bug 11023: Toggle new status This patch adds: - a new DB field items.new. - a new page to configure this new status (tools/toggle_new_status.pl). - a new cronjob script (misc/cronjob/toggle_new_status.pl). Why this status is useful for some libraries ? The use cases are: - to know easily what are the new items (with a simple sql query). - to display an icon in the search results. - issuing rules can be adapt for new items. Automatically (using the cronjob script), the status change (depending the configuration) and the item can be issued, for example. - a RSS/Atom feeds can be created on these new items. Test plan: - log in with a librarian having the tools items_batchmod permission. - navigate to Home Tools Toggle new status - click on the edit button - there are 3 blocks: * duration: the duration during an item is considered as new. * conditions: the status will change only if the conditions are meet. * substitutions: if there is no substitution, no action will be done. You can add some change to apply to the matching items. E.g. ccode=3 new='' If the value is an empty string (in other words, the input does not contain anything), the field will be deleted. You can create as many rules as you want. - test the interface : add/remove rule, conditions, substitutions, submit the form, edit, etc. (There is a looot of JS everywhere, so certainly a looot of bugs...). - when you have your rules defined, you can now launch the cronjob script without any parameter. A report will be displayed with the matching itemnumber and the substitutions to apply. Verify results are consistent. - launch the script with the -c argument and verify values have been modified depending the substitution rules. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11023] Toggle new status for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24069 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24069action=edit Bug 11023: Add the ability to specify fields from biblioitems table. Test plan: Same as before but try with fields from the biblioitems table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11023] Toggle new status for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com --- rebased patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11023] Toggle new status for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24070 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24070action=edit Bug 11023: Add UT for C4::Items::ToggleNewStatus Test plan: prove t/db_dependent/Items/ToggleNewStatus.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11508] New: Untranslatable pull-down in auth_subfields_structure.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11508 Bug ID: 11508 Summary: Untranslatable pull-down in auth_subfields_structure.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kalli...@pttk.fi QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr The pull-down for Select to display or not: contains strings Show All and Hide All, these are hard-coded in admin/auth_subfields_structure.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10646] mod_rewrite should be enabled by the postinst script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #23013|0 |1 is obsolete|| --- Comment #8 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 24072 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24072action=edit Bug 10646 - warn if mod_rewrite is not enabled Koha requires mod_rewrite. If it's not enabled in Apache, then koha-create will now abort with a helpful error message. Also adds a warning when not run as root to avoid confusing errors. Test plan: * apply the patch * a2dismod rewrite * run koha-create without sudo, note the error about being root * run koha-create with sudo, note the error about rewrite * a2enmod rewrute * repeat test above, note that it works Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com Works as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10646] mod_rewrite should be enabled by the postinst script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10646 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6113] enhancement to keep previous ids
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #21703|0 |1 is obsolete|| --- Comment #26 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 24073 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24073action=edit Bug 6113 [ENH] - enhancement to keep previous ids Modified the C4::Biblio::_koha_add_biblioitem() _koha_add_biblio() to support INSERTing biblionumbers and biblioitemnumbers to the Koha DB. Created validators to make sure the primary keys are positive integers and well below the Perl's LONG_MAX threshold to keep Koha from getting crazy. Duplicate id's are the users responsibility and in normal use conditions they are non-existing, unless the Koha to MARC mapping to biblionumber is a user-modifiable MARC field, which is TROUBLE! MySQL takes care of the primary key sequence refreshing. Updated the bulkmarcimport.pl -script to copy the desired legacy id MARC field to the biblionumber- and biblioitemnumber-fields designated in Koha to MARC mapping, eg. copy field 001 to 999c and 999d. This is handy if you have the legacy id in just 001 and need to populate 999c and 999d to push them to DB. No need to make an extension to the existing migration scripts. Documented the new functionality in bulkmarcimport.pl Created test cases for C4::Biblio.pm modifications. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- Rebased patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #12842|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24074 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24074action=edit Bug 8438: Followup Set the superserials permission for all users with the claim_serials permission -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7162] Factorize code for order cancellation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #22720|0 |1 is obsolete|| --- Comment #51 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 24076 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24076action=edit [SIGNED-OFF] Bug 7162 [Follow-up] Fix referrer URL when coming from parcel.pl Signed-off-by: Corinne Bulac corinne.ha...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7162] Factorize code for order cancellation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #22721|0 |1 is obsolete|| --- Comment #52 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 24077 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24077action=edit Bug 7162; Factorize code for order cancellation (QA fixes) * Remove tab characters in acqui/addorder.pl * Remove FIXME in acqui/cancelorder.pl * Fix typos: canceled - cancelled, occured - occurred * Replace Click here link by OK * Add a column to aqorders to store cancellation reason instead of having it in aqorders.notes, to avoid having untranslatable strings in database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7162] Factorize code for order cancellation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #22719|0 |1 is obsolete|| --- Comment #50 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 24075 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24075action=edit [SIGNED-OFF] Bug 7162: Factorize code for order cancellation Some code was duplicated, all is now in cancelorder.pl Added possibility to provide a reason for cancellation (or other things, this is saved in aqorders.notes) Signed-off-by: Corinne Bulac corinne.ha...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7162] Factorize code for order cancellation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #53 from Julian Maurice julian.maur...@biblibre.com --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8064] Merge several biblio records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #23708|0 |1 is obsolete|| --- Comment #33 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 24078 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24078action=edit Bug 8064: Merge several biblios Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8064] Merge several biblio records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #23710|0 |1 is obsolete|| --- Comment #35 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 24080 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24080action=edit Bug 8064: Fix issues with control fields and non-repeatable check Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8064] Merge several biblio records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #23709|0 |1 is obsolete|| --- Comment #34 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 24079 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24079action=edit Bug 8064: Change the way target record is built. Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10857] Add facets cancellation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #36 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24082 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24082action=edit Bug 10857: Encode 'limit' parameter values to allow facets with '' character. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10857] Add facets cancellation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #20946|0 |1 is obsolete|| Attachment #22746|0 |1 is obsolete|| --- Comment #35 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24081 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24081action=edit Bug 10857: Add facets cancellation When searching (at the OPAC or pro), facets can be enabled but never disabled. So a user is obliged to relaunch the search. This patch adds a new link [x] at the right of each selected facet. This link relaunch the search without this facet. Test plan: - Launch a search (OPAC and pro) - Enable some facets - Disable some facets -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11509] New: koha-create should print better usage information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11509 Bug ID: 11509 Summary: koha-create should print better usage information Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz The usage information is not helpful as-is. It can be refactored a bit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10857] Add facets cancellation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #37 from Jonathan Druart jonathan.dru...@biblibre.com --- rebased patch. Only available for the prog theme (for now). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10212] Columns configuration for tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #21583|0 |1 is obsolete|| --- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24083 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24083action=edit Bug 10212: Columns configuration for tables - Add Colvis files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10212] Columns configuration for tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #21584|0 |1 is obsolete|| --- Comment #24 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24084 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24084action=edit Bug 10212: Columns configuration for tables This development introduces ColVis into Koha and provides a configuration page for columns visibility. ColVis is a plugin for DataTables. It allows to change the visibility of the columns in the table. * This development adds: - the js and css file for ColVis - a new DB table 'columns_settings' - a new template plugin 'ColumnsSettings' - a new package C4::Utils::DataTables::ColumnsSettings - a new admin page admin/columns_settings.pl * How it works: A yaml file is created (admin/columns_settings.yml) in order to take an inventory of all tables where ColVis is implemented. This file is read to create the list of modules, pages and tables in the configuration page. There are 3 possible keys in the yml: - is_hidden: default is 0 The column will be hidden. - cannot_be_toggled: default is 0. ColVis will allow to hide/show the column. - cannot_be_modified: default is 0 Default values (in the yml) won't be modifiable. When a user changes (or saves) the configuration for one module, all columns are added to the DB table. The values in the DB get the upper hand on the yaml values. * Humm, strange? It seems weird to have 2 storages for the same values. But I think it will be easy to add an entry and maintain the yaml rather than adding a new row (and new entry in updatedatabase script) in the DB. * Test plan: 1/ Execute the updatedatabase in order to create the new table. 2/ Take a look to the yml structure. 3/ Go on the checkouts page (circ/circulation.pl). 4/ Check that you cannot hide the 3 last columns on the issues table. 5/ Check that you cannot hide the 2 last columns on the holds table. 6/ Try to hide/show columns. 7/ Go on the columns configuration page (admin/columns_settings.pl). 8/ Only the last tab are filled with data. Check/uncheck checkboxes and save. 9/ Go on the checkouts/holds page and check that the behavior is what you expected. 10/ Give me some feedback :) * To go further: We can imagine that the configuration is saved for each user (and not globally like it is made with this patch). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10212] Columns configuration for tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #21585|0 |1 is obsolete|| --- Comment #25 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24085 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24085action=edit Bug 10212: Make the table names translatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10212] Columns configuration for tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #26 from Jonathan Druart jonathan.dru...@biblibre.com --- Rebased patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #23580|0 |1 is obsolete|| --- Comment #56 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24086 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24086action=edit Bug 9593 Prices not imported correctly from a staged file Initial bug : When there's a round price with no decimals after it, or when the symbol is after the digits, the price is not captured by regular expression in MungeMarcPrice routine and the variable is not initialized. Enhancement : The MungeMarcPrice routine had been widely modified. It 's still possible to priority pick the active currency but unlike the previous mechanism that worked only for prices preceded by the currency sign, it's now valid wherever the symbol is situated. As symbol you may enter a pure currency sign as well as a string including it like '$US'. Moreover, an 'isocode' column had been added in currency table (editable in the pro interface from Administration/Currencies and exchange rates). So the active currency can be picked either through its symbol or through its iso code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #57 from Jonathan Druart jonathan.dru...@biblibre.com --- rebased patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #23625|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24087 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24087action=edit Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= amp;$value in the function body. Also use URI::Escape instead of custom regexps. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACHideOpenURLForItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are not in OPACHideOpenURLForItemTypes) 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to default 9/ Repeat steps 5 to 7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #23627|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24089 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24089action=edit Bug 8995: Show OpenURL links in bootstrap theme -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com --- rebased patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #23626|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24088 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24088action=edit Bug 8995: Use uri_escape_utf8 instead of uri_escape -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11509] koha-create should print better usage information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11509 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11482] new reservation syspref PickupHoldOnlyFromItemBranches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11482 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||jonathan.dru...@biblibre.co ||m --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- fatal: sha1 information is lacking or useless (C4/Reserves.pm). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11509] koha-create should print better usage information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11509 --- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 24090 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24090action=edit Bug 11509: koha-create should print better usage information This patch makes koha-create print better and more descriptive usage information. Also adds the --help and -h switches. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11509] koha-create should print better usage information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11509 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865 --- Comment #15 from Petter Goksøyr Åsen boutrosboutrosbout...@gmail.com --- Created attachment 24091 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24091action=edit [SIGNED-OFF] Sorry about the confusion. I forgot to start the SIP server manually, using the koha-start-sip command instead. So naturally then I couldnt see any effect. But now I did it the right way! And I can confirm that this patch solves all issues with mangled characters in SIP messages. Confirmed that it looks good with Norwegian characters in patron name and in book titles. Signed-off-by: Petter Goksoyr Asen boutrosboutrosbout...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11507] add the possibility to filter order by parent_ordernumber in receipt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11507 Koha Team Lyon 3 k...@univ-lyon3.fr changed: What|Removed |Added Status|NEW |Needs Signoff CC||k...@univ-lyon3.fr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11507] add the possibility to filter order by parent_ordernumber in receipt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11507 --- Comment #1 from Koha Team Lyon 3 k...@univ-lyon3.fr --- Created attachment 24092 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24092action=edit Bug 11507 - add the possibility to filter order by parent_ordernumber in receipt After a transfer of order in a new basket, the ordernumber is changing. Sometimes, we keep a track the old ordernumber so it can be usefull to be able to retrieve the order b Test plan : - choose an order and notes its ordernumber - transfer it to a new a basket and notes the new ordernumber _ in receipt page, in the filter box, enter the older ordernumber or the new ordernumber: you can find the order -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11507] add the possibility to filter order by parent_ordernumber in receipt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11507 Koha Team Lyon 3 k...@univ-lyon3.fr changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11486] Show renewal count on 'check out' and 'details' tabs in patron record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11486] Show renewal count on 'check out' and 'details' tabs in patron record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #23982|0 |1 is obsolete|| --- Comment #4 from Nicole C. Engard neng...@gmail.com --- Created attachment 24093 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24093action=edit [SIGNED-OFF] Bug 11486 - Show renewal count on 'check out' and 'details' tabs in patron record This patch adds the renewal count to the 'Check out' and Details' tabs of the patron record. This information already exists in the OPAC view of the patron record. Since librarians might be serving patrons in person who want to know this information without looking it up online, it makes sense to show it in the staff client. There may also be times where librarians want to see how many renewals a patron has left, how many they've used already, etc. when making other decisions. _TEST PLAN_ Before applying: 1) Go to Check out with a patron that has some check outs before today 2) Add some check outs for today *Ensure that all issues are for items that can be renewed* 3) Note that the Renew column just says '0' followed by a check box 4) Check the 'Detail' tab. It should say the same. Apply the patch. 5) View the Details and Check out tabs again 6) Note that the renewal count now appears in the form resembling: 5 of 5 renewals remaining Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com All tests pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11486] Show renewal count on 'check out' and 'details' tabs in patron record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11486 --- Comment #5 from Nicole C. Engard neng...@gmail.com --- Signed off! I'll report another bug - I think that just cause you can't renew doesn't mean you shouldn't see that you did renew :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11397] Displaying itemnumber list on the Acquisition detail tab is useless
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11397 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11397] Displaying itemnumber list on the Acquisition detail tab is useless
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11397 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #23569|0 |1 is obsolete|| --- Comment #4 from Nicole C. Engard neng...@gmail.com --- Created attachment 24094 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24094action=edit [SIGNED-OFF] Bug 11397: Remove the itemnumber list on the Acquisition detail tab Test plan: - verify this patch does not introduce regression on the enhancement introduced by bug 8230. - verify the itemnumber list does not appears anymore. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com The acquisitions details tab on the holdings table in the staff client no longer shows the links to the items. Tests pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9811] Patrons search improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #23261|0 |1 is obsolete|| --- Comment #74 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24095 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24095action=edit Bug 9811: Patron search improvement This patch add DataTables using server-side processing for the patrons search. It adds: - 1 module C4/Utils/DataTables/Members.pm - 2 services svc/members/search and svc/members/add_to_list - 1 template members/tables/members_results.tt - 1 new practice which is to add template for DataTables in a subdirectory named 'tables'. Impacted scripts: members/members-home.pl and members/members.pl To go further: We can imagine that all patrons searches use the same service with no big changes: 1 little template creates a JSON file and to implement DataTables on the template page, that's all. Amended patch: Since bug 10565 has been pushed, these patches don't apply cleanly. I had to rewrite a part of the patron list feature. I removed the choice to add all resultant patrons from a search. I think this choice is useless with this patch: we are able to display the number of patrons we want and to select all of them. Test plan: - Check that there is no regression on searching patrons. - Try filters on the left of the screen. - Try to sort each column. - Try the Browse by last name links. - Check that the Clear button clears yours filters. - Try with IndependantBranches ON and OFF. - Verify this feature does not break the patron list feature (cf bug 10565). Signed-off-by: Cedric Vita cedric.v...@dracenie.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests and QA script, couldn't find any regressions or problems. Some notes left on the bug. Bug 9811: Add unit tests for C4::Utils::DT::Members Signed-off-by: Katrin Fischer katrin.fischer...@web.de Bug 9811: QA followup - removes 2 tabs - removes mysqlisms - add sort on borrowernotes - fix wrong capitalization - cat = Category Signed-off-by: Katrin Fischer katrin.fischer...@web.de Thx for fixing these! Bug 9811 - multilines notes brakes JSON In new patron search feature, the search results are fetched using Ajax and returned in JSON format. The JSON is created by TT using koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt. One of the fields is the borrower notes. When this notes contains several lines, the JSON is broken. This patch uses TT fileters to consert in notes linefeeds into HTML line break (html_line_break) and then remove linefeeds (collapse). Test plan : - perform a member search that does not return a borrower with a circ note - edit one of the borrowers returned by this search - enter serveral lines of text in Circulation note and save - reperform the member search = circ note is well displayed on several lines Bug 9811: use count(primary_key) instead of count(*) Bug 9811: A limit clause should be always added. By default, we want to retrieve 20 first results. Bug 9811: Load the page without any data. Displaying the first 20 patrons is not useful. With this patch, the table is hidden and no record is retrieved by default. On the same way, the existing side effect on redirect disappears. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9811] Patrons search improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #75 from Jonathan Druart jonathan.dru...@biblibre.com --- Rebased patch. Fix conflicts with bug 10834 and add support for search on sort1 and sort2 fields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11507] add the possibility to filter order by parent_ordernumber in receipt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11507
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
CC||jonathan.dru...@biblibre.co
||m
--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
Hello,
I am something like that in my patches queue.
The way you do that will work but will certainly introduce side effect.
For ex. in acqui/orderreceive.pl:
$results = SearchOrders({
ordernumber = $ordernumber
}) if $ordernumber;
The search on the parent ordernumber has to be done explicitly.
Marked as Failed QA.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11507] add the possibility to filter order by parent_ordernumber in receipt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11507 --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- You can have a look at the Matthias's work in the BibLibre repository: http://git.biblibre.com/?p=kohac;a=shortlog;h=refs/heads/paris-sud/ft/MT13320 See the 3 patches on top (Marked MT13320). It is not validated in our side for the moment, so I don't submit a patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10942] Provide a way for package upgrades to update template translations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10942 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #21461|0 |1 is obsolete|| --- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 24096 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24096action=edit Bug 10942: Provide a way for package upgrades to update template translations This patch adds a new config variable AUTOMATIC_TRANSLATIONS_UPDATE at /etc/default/koha-common that is used to control whether the upgrade process should trigger a $ koha-translate --update lang_code command for each installed template translation language. To test: - Have a koha-common setup with some languages installed (e.g. koha-translate --install es-ES) - Apply the patch and build a package for it. - Install it. - A new AUTOMATIC_TRANSLATIONS_UPDATE config variable should be in place at /etc/default/koha-common - Set AUTOMATIC_TRANSLATIONS_UPDATE to 'yes' - Re-install the package to trigger the post-install script - Verify that translations get updated. Edit: added a warning message for the case AUTOMATIC_TRANSLATIONS_UPDATE=no and there are translations installed (so they need to get updated). Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11510] New: Typo in koha-translate usage message
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11510 Bug ID: 11510 Summary: Typo in koha-translate usage message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz The koha-translate's usage message has a couple of inconsistencies: '--all' should be '--available' and '--help' is missing from the usage examples. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11510] Typo in koha-translate usage message
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11510 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11502] Branch filter in Holds To Pull is too fuzzy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11502 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Hi David, Could you explain why you match the and ? The ^$ are not enough? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11510] Typo in koha-translate usage message
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11510 --- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 24097 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24097action=edit Bug 11510: koha-translate usage message fixes The koha-translate's usage message has a couple of inconsistencies: '--all' should be '--available' and '--help' is missing from the usage examples. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11510] Typo in koha-translate usage message
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11510 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11509] koha-create should print better usage information
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11509 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #24090|0 |1 is obsolete|| --- Comment #2 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 24098 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24098action=edit Bug 11509: koha-create should print better usage information This patch makes koha-create print better and more descriptive usage information. Also adds the --help and -h switches. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11511] New: Keep stats on opac logins
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11511 Bug ID: 11511 Summary: Keep stats on opac logins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Would be nice to be able to keep stats on the number of times users are logging in to the opac. Maybe a table (or part of the stats table) that stores borrowernumber (so we could query patron categories and branches) and the number of times they clicked the 'login' button on the opac? or if in the stats table the date/time of the login so it can be counted in a report? Just an idea - I often get asks about the number of logins to the opac. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11130] Change pl Place-publication index for Marc21
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11130 --- Comment #3 from Mirko Tietgen mi...@abunchofthings.net --- (In reply to mathieu saby from comment #2) Maybe it is in ccl.properties, but I believe it would be a bad idea to follow it on this point ;-) The 2 information should be in different indexes. In Unimarc, we use pl for 210 (the same as 260) and Country-publication for 102$a field (if I remember well) for the country. At the moment, it is 008/15-17 and ALL 260 subfields. I'm not trying to make it worse but better, but based on what is in that file. ;) And I would like to get 260$e (Place of manufacture) out of the index. But perhaps you are right, ignoring what ccl.properties says and instead setting up an index just for 260$a would be a better idea. Maybe others have an opinion on that? By the way, the pl index is completely useless for the average user in an academic or public library, at least according to my experience. Because I've never seen a reader looking for a book published in London, or All the books published in Paris. I think it's more a librarian-centered information. We have a lot of video material and a search for »movies from $country« is very likely. »movies published in London« not so much I guess. ;D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Matthias Meusburger matthias.meusbur...@biblibre.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Matthias Meusburger matthias.meusbur...@biblibre.com changed: What|Removed |Added Attachment #20537|0 |1 is obsolete|| --- Comment #17 from Matthias Meusburger matthias.meusbur...@biblibre.com --- Created attachment 24099 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24099action=edit proposed patch This patch solves the problems previously discussed: - The 3 new fields (origin, domain and ccode) that had an unclear use-case and were too specific were removed from the patch, as Bug 10855 will do the job in a more generic way. - The hardcoding for 995$l was replaced by a marc-agnostic version (as Fridolin suggested in his last comment). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10845] Multi transport types for holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845
--- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Olli-Antti Kivilahti from comment #13)
Reading your test cases, and good job with the description!
There is one concern!
What if a patron defines to his own messaging preferences sms and email, but
has no sms notification number defined nor email.
This can easily be done accidentally.
This might needlessly bloat our print notifications queue and cause lots of
extra costs.
If no sms and email are defined, a print notice will be generated.
Feel free to fix the preferences or not to sent the notification :)
What do you propose ?
Would it be possible to add a check that;
if email or sms is succesfully sent, even if the other email or sms has
failed, no print notice is generated. This is slightly problematic to
implement but shouldn't be too difficult.
The behavior I developed is the behavior needed by our customer.
Maybe a syspref could be let the choice, but it is out of the scope of this
patch.
Also a patron can request email and sms, buth have no such contact details.
In this case the email is sent via print notice + the sms replaced with
another print notice!
No, normally only 1 print notice is generated.
(In reply to Olli-Antti Kivilahti from comment #15)
If I have had email and sms defined, but subsequently removed those contact
details, I suspect this condition brings falsehood:
if ( ($mtt eq 'email' and not $to_address) or ($mtt eq 'sms' and not
$borrower-{smsalertnumber}) ) {
$to_address and $borrower-{smsalertnumber} are defined as empty Strings and
validate true in Perl.
Thus I have been unable to trigger the double print notification bug, but
instead got sms and email notifications with destination of '' == empty
String
1 sms and 1 email have been generated with and empty to_address?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11457] t/db_dependent/Bookseller.t can fail when subscription table is not empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11457 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #23890|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24100 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24100action=edit Bug 11457 : Clearing subscription table so tests pass correctly To test 1/ Add a subscription in the serials module, with an end date before 2013-08-01 2/ run prove -v t/db_dependent/Bookseller.t Notice tests 22 and 23 fail 3/ Apply patch 4/ run test again 5/ Notice tests succeed Signed-off-by: Katrin Fischer katrin.fischer...@web.de Tests now clean the subscription table before running the tests, so that the will always pass. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11457] t/db_dependent/Bookseller.t can fail when subscription table is not empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11457 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #41 from MJ Ray (software.coop) m...@software.coop --- (In reply to Paola Rossi from comment #38) Kind Paul, I wanted to say: I don't sign off the patch because the master was already OK without applying the patch: the master didn't show diacritics badly. That diacritic was o-umlaut which is character F6 in the latin-1 character set, wasn't it? Therefore, I think it wouldn't trigger both aspects of this bug. You're correct that the test case isn't great in that regard. I'm still getting Wide character in compress at /usr/share/perl5/PDF/Reuse.pm line 819 when attempting to print a record containing a stroked-l (B3 from latin-2, whatever that is in utf8). I will investigate further soon but would really appreciate any thoughts from the wise heads here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11432] 404.pl redirect for single, hidden result makes no sense.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m QA Contact|testo...@bugs.koha-communit |jonathan.dru...@biblibre.co |y.org |m --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- I added a followup in order to hide the facets block if no result is displayed. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11432] 404.pl redirect for single, hidden result makes no sense.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #23879|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 24101 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24101action=edit Bug 11432 - 404.pl redirect for single, hidden result makes no sense. In bug 10584, when searching for something in OPAC and a single, hidden result is returned, the default automatic redirect to the details/MARCdetails/ISBDdetails page triggers a 404.pl error page. This makes no sense. The correct behaviour would be to give no results. TEST PLAN - 1) OPAC Search for something (I started with stupid) 2) Narrow it to one item (I tweaked it to stupid things) 3) Detail page comes up 4) Staff client - home - administration - global system preferences - OPAC 5) OpacHiddenItems add homebranch: [MAL,DAV,PAP], changing MAL, DAV, PAP to the branches for items for this single biblio. 6) Search for the one item again in OPAC -- 404.pl is triggered. 4) Apply patch 5) Search again for the one item search -- No results is triggered (as expected) Signed-off-by: Christopher Brannon cbran...@cdalibrary.org Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
