[Koha-bugs] [Bug 11334] Add facet for home library

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334

--- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 24191
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24191action=edit
[PASSED QA] Bug 11334 [QA Followup] - Add facet for home library

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11334] Add facet for home library

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #24007|0   |1
is obsolete||
  Attachment #24008|0   |1
is obsolete||
  Attachment #24191|0   |1
is obsolete||

--- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 24192
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24192action=edit
[PASSED QA] Bug 11334 - Add facet for home library

The current Library facet is somewhat ambiguous for Koha installations
with multiple libraries. It refers to the holdingbranch, but does not
explicitly state this. It would be beneficial to allow the administrator
to choose to show facets for the holding library, home library, or both.
In addition, the facets should be more explicitly labeled.

Test plan:
1) Apply this patch
2) Check that the facets label Libraries now reads Holding libraries
3) Update the system preference DisplayLibraryFacets to home library
4) Check that the facet now reads Home libraries
5) Update the preference again to both home and holding library
6) Check that both the facets for home and holding library are now
   displayed.

Signed-off-by: Jen DeMuth jdem...@roseville.ca.us
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Passes all tests and QA script.
Changes apply to both prog and bootstrap OPAC and staff client.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11334] Add facet for home library

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11334] Add facet for home library

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334

--- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 24193
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24193action=edit
[PASSED QA] Bug 11334 [QA Followup] - Add facet for home library

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11334] Add facet for home library

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334

--- Comment #12 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I am not sure if the change in the label could be confusing to patrons - it
might be an idea to still show Libraries when only home or holding library
are displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11495] i18n toolchain misses one instance of text Select titles to: in bootstrap

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11495] i18n toolchain misses one instance of text Select titles to: in bootstrap

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11495] i18n toolchain misses one instance of text Select titles to: in bootstrap

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 24194
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24194action=edit
Bug 11495: Make Select titles to:  translatable

Fixes translation of Select titles to:  on the Bootstrap
OPAC result page.

Test plan:
- Update one of the po files running:
  perl translate update langcode
- Verify that Select titles to:  is only listed once for
  search-results.tt
Apply patch
- Verify addings titles to lists and cart from the result list
  still works as expected
- Rerun the po file update
- Verify the string is now listed twice for search-results.tt

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Now Kyle was faster with doing QA:) Welcome JaTara!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126

--- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 24195
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24195action=edit
test case home library/pickup library

Kyle, I have double checked everything, but the test case described in the
attached PDF doesn't seem to give the correct result to me. Could you please
take a look?

When I turn off LocalHoldsPriority the hold for R is triggered.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11520] Invoice isn't really an invoice

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11520

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I am not sure about the replacement cost - do you mean the RRP column? I think
this is recommended retail price.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

--- Comment #88 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Comment on attachment 22877
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22877
Bug 7825: Changed OPACItemHolds syspref to be no|tes|force choice

Review of attachment 22877:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=7825attachment=22877)
-

Hi Jonathan,

in your comment you wrote:
The value field should not be change. We have to keep '1' for 'yes' and ''
for 'no'.

But I still see the yes/no in the database update and syspref part?

::: installer/data/mysql/sysprefs.sql
@@ +228,4 @@
  ('OpacHiddenItems','','','This syspref allows to define custom rules for 
 hiding specific items at opac. See docs/opac/OpacHiddenItems.txt for more 
 informations.','Textarea'),
  ('OpacHighlightedWords','1','','If Set, then queried words are higlighted in 
 OPAC','YesNo'),
  ('OpacHoldNotes','0','','Show hold notes on OPAC','YesNo'),
 +('OPACItemHolds','yes','no|yes|force','Allow OPAC users to place hold on 
 specific items. If No, users can only request next available copy. If Yes, 
 users can choose between next available and specific copy. If Force, users 
 *must* choose a specific copy.','Choice'),

Should be 0 and 1?

::: installer/data/mysql/updatedatabase.pl
@@ +7745,5 @@
  
 +
 +$DBversion = 3.13.00.XXX;
 +if ( C4::Context-preference(Version)  TransformToNum($DBversion) ) {
 +$dbh-do(UPDATE systempreferences SET type = 'Choice', options = 
 'no|yes|force' WHERE variable = 'OPACItemHolds');

Should be 0 and 1?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #89 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I will wait for a follow-up and then continue on this as soon as I can.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11476] Opac self registration title pull down offers 2 empty options

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11476

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11476] Opac self registration title pull down offers 2 empty options

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11476

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #24190|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 24197
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24197action=edit
[PASSED QA] Bug 11476 - Opac self registration title pull down offers 2 empty
options

If you have patron titles enabled, the OPAC patron details form lists 2
empty spaces instead of 1. An empty option is passed by the script, so
the template does not need to include one.

To test you must have at least one patron title set in BorrowersTitles
system preference and OPACPatronDetails must be set to allow.

1. Apply the patch
2. Log in to the OPAC
3. Click the personal details tab.
4. Click the salutation dropdown. There should be only one blank line
   preceding the existing titles.

Test in both prog and bootstrap.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Works as described for existing and creating new accounts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11182] Warnings in circulation

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182

--- Comment #11 from Jesse Weaver jwea...@bywatersolutions.com ---
Created attachment 24198
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24198action=edit
Bug 11182 - Warnings in circulation

This deals with the warning when Circulation system preference
'WaitingNotifyAtCheckin' is set to 'Notify' and an overdue item
is checked in.

TEST PLAN
-
 0) Feel free to backup your koha-error_log file, and then toast it.
 $ echo  ~/koha-dev/var/log/koha-error_log
 1) Log into staff client
 2) Koha administration
 3) Global system preferences
 4) Circulation
 5) Make sure WaitingNotifyAtCheckin is set to Notify.
 6) Check out tab
 7) Type patron's name
 8) Select patron if required
 9) Check out an item, but set the due date to be overdue.
10) Check in the overdue item.
11) Check the error log
 $ cat ~/koha-dev/var/log/koha-error_log | grep 284
 NOTE: the returns.pl one that will be fixed by this.
12) Apply this patch
13) Repeat steps 6 through 7, there should no new line 284 entries.

Signed-off-by: Jesse Weaver pianohac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11182] Warnings in circulation

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182

Jesse Weaver jwea...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11381] IDreamBooks too close to title on bootstrap

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11381

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11381] IDreamBooks too close to title on bootstrap

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11381

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #24189|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 24199
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24199action=edit
[PASSED QA] Bug 11381 - IDreamBooks too close to title on bootstrap

Styling of IDreamBooks elements is not correct in the bootstrap theme
because the relevant CSS was not transferred from the prog theme. This
patch adds it back.

To test, switch to the bootstrap theme and enable IDreamBooks system
preferences in the OPAC, particularly IDreamBooksReadometer. Find a book
in the OPAC which shows IDreamBooks review data and confirm that
everything looks correct.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Works as described. Tested with The help.

http://bugs.koha-community.org/show_bug.cgi?id=11281

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11505] Untranslatable table headers in Label batch manager

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11505

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11505] Untranslatable table headers in Label batch manager

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11505

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #24185|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 24200
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24200action=edit
[PASSED QA] Bug 11505 - Untranslatable table headers in Label batch manager

The label batch manager script hard-codes the table header cell labels
in order to pass them to an HTML-building function. This obviously isn't
the best solution for internationalization, but picking the whole scheme
apart would be very complicated.

Instead this patch uses a SWITCH statement to check for each possible
case and outputs the correct translatable string for each.

To test, apply the patch and run perl translate update for any
translation. Check the revised po file and confirm that the new strings
are present. View the label batch edit page and confirm that the table
headings look correct: Tools - Labels - Manage batches - Edit batch.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Works as described, passes all tests.
Similar fixes are probably needed for other pages of the labels
modules.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10451] Firefox prints only first page of table with shrink to fit option

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10451

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion
 CC||katrin.fisc...@bsz-bw.de,
   ||oleon...@myacpl.org

--- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I tried this with Firefox 26 in Ubuntu for a result page in staff and a very
full cart. Without the patch, the pages prints nicely. With the patch, we have
the navigation on the first page and the rest on the second.

This is quite a regression in newer Firefox versions.

I hesitate to pass QA on this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11524] New: Strange URL parameters in OPAC

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11524

Bug ID: 11524
   Summary: Strange URL parameters in OPAC
 Change sponsored?: ---
   Product: Koha
   Version: 3.14
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

While testing some patches, I noticed that the OPAC will generate 'strange'
URLs when you repeat the following steps:

- Log into the OPAC
- Do a search for any search term in simple search
- Change the sorting

The resulting URL is:
http://localhost/cgi-bin/koha/opac-search.pl?idx=kwq=dersort_by=pubdate_dscaddto=Add+to...biblionumber=2loggedinuser=biblionumber=4loggedinuser=biblionumber=7loggedinuser=biblionumber=8loggedinuser=biblionumber=9loggedinuser=biblionumber=10loggedinuser=biblionumber=11loggedinuser=biblionumber=13loggedinuser=biblionumber=14loggedinuser=biblionumber=18loggedinuser=biblionumber=19loggedinuser=biblionumber=23loggedinuser=biblionumber=32loggedinuser=biblionumber=35loggedinuser=biblionumber=38loggedinuser=biblionumber=40loggedinuser=biblionumber=47loggedinuser=biblionumber=50loggedinuser=biblionumber=58loggedinuser=biblionumber=60loggedinuser=

I think this could be an unwanted side effect of the search history patches
that were recently pushed (bug 10952).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10857] Add facets cancellation

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #24125|0   |1
is obsolete||
  Attachment #24126|0   |1
is obsolete||
  Attachment #24163|0   |1
is obsolete||

--- Comment #45 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 24201
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24201action=edit
[PASSED QA] Bug 10857: Add facets cancellation

When searching (at the OPAC or pro), facets can be enabled but never
disabled. So a user is obliged to relaunch the search.

This patch adds a new link [x] at the right of each selected facet.
This link relaunch the search without this facet.

Test plan:
- Launch a search (OPAC and pro)
- Enable some facets
- Disable some facets

Signed-off-by: sonia bouis sonia.bo...@univ-lyon3.fr
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Patches pass all tests and QA script. Nice feature!

Tested in Boostrap and Prog, adding end removing multiple
facets in different sequences, adding and removing the
availability limit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10857] Add facets cancellation

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10857] Add facets cancellation

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

--- Comment #47 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 24203
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24203action=edit
[PASSED QA] Bug 10857: Add facets cancellation - bootstrap theme.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10857] Add facets cancellation

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

--- Comment #46 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 24202
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24202action=edit
[PASSED QA] Bug 10857: Encode 'limit' parameter values

to allow facets with '' character.

Signed-off-by: sonia bouis sonia.bo...@univ-lyon3.fr
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10857] Add facets cancellation

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11524

--- Comment #48 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I think maybe the little x could be formatted a bit differently to be more
obvious, but that is not enough for failing QA on this :)

I discovered bug 11524 while testing this, which could be related to bug 10952
this depends on.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11524] Strange URL parameters in OPAC

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11524

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10857

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9288] Add a script to test SIP from the command line

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288

--- Comment #35 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
The QA script passes now for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11510] Typo in koha-translate usage message

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11510

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #24097|0   |1
is obsolete||

--- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 24204
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24204action=edit
Bug 11510: koha-translate usage message fixes

The koha-translate's usage message has a couple of inconsistencies:

'--all' should be '--available'
and '--help' is missing from the usage examples.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11510] Typo in koha-translate usage message

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11510

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #23112|0   |1
is obsolete||

--- Comment #29 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 24206
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24206action=edit
Bug 10486 - Allow external Z39.50 targets to be searched from the OPAC

This adds a new page to the OPAC that can search several Z39.50 targets
using Pazpar2.

Test plan:
1) Apply patches.
2) Update database.
3) Add one or more Z39.50 targets, using the Administration - External
   targets screen. Note that not all targets support keyword search, but
   here are some that do:
 * Library of Congress: lx2.loc.gov, 210, LCDB, none, none, MARC21, UTF-8
 * BNF2: z3950.bnf.fr, 2211, TOUT, Z3950, Z3950_BNF, UNIMARC, UTF-8
4) Perform a search on the OPAC, check to see if the external targets
   notice pops up at the top.
5) Click on the results link near that message.
6) This should bring back results from all enabled targets, all of which
   should be clickable to bring up a detailed view of the record.

(This version fixes some typos and accidental changes.)

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

Fixing some conflicts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #24036|0   |1
is obsolete||

--- Comment #31 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 24208
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24208action=edit
Bug 10486 QA followup: Fix license headers, add tests

XSLT.t is the only one modified, so to run the tests, just do:

prove t/XSLT.t

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #23113|0   |1
is obsolete||

--- Comment #30 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 24207
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24207action=edit
Bug 10486 followup - fix pazpar2 configuration file

This removes some deprecated elements and changes the name of some
others. For an existing install, you will need to make the following
changes to your installed pazpar2.xml configuration file:

  1. Remove the sortkey/ and index/ tags from relevance, sort
 and mergekey.
  2. Change the normalize ... tags to transform 

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

--- Comment #32 from Chris Cormack ch...@bigballofwax.co.nz ---
Seems to work fine, last thing needed is the bootstrap templates. Then I'm
happy to sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11509] koha-create should print better usage information

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11509

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11509] koha-create should print better usage information

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11509

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #24098|0   |1
is obsolete||

--- Comment #3 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 24205
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24205action=edit
Bug 11509: koha-create should print better usage information

This patch makes koha-create print better and more descriptive usage
information. Also adds the --help and -h switches.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11182] Warnings in circulation

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #24181|0   |1
is obsolete||

--- Comment #12 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 24209
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24209action=edit
Bug 11182 - get rid of some warnings

After fuller testing, there were five problems found:
circulation.pl:273
borrower_debarments.inc:65
returns.pl:269
returns.pl:284
returns.pl:540

This patch catches returns.pl:269 and returns.pl:540
Oops. Cut-and-paste error. Corrected step 5. :)

TEST PLAN
-
 1) Log into staff client
 2) Koha administration
 3) Global system preferences
 4) Circulation
 5) Make sure FineNotifyAtCheckin is set to Notify.
 6) Check out tab
 7) Type patron's name and click 'Submit'
 8) Select patron if required
 9) Check out an item, but set the due date to be overdue.
10) Check in the overdue item.
11) Check the error log
 $ cat ~/koha-dev/var/log/koha-error_log
 NOTE: only the warnings from lines 269 and 540 in returns.pl
   are the ones to note.
12) Apply this patch
13) Repeat steps 6 through 11, there should no new
warnings related to lines 269 or 540 from returns.pl.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11254] breeding search must normalize ISBN

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11254

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #2 from M. Tompsett mtomp...@hotmail.com ---
This eyeballs well, but step-by-step instructions would really help.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11136] action_logs should be a MyISAM table, not InnoDB

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|Trivial patch   |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11136] action_logs should be a MyISAM table, not InnoDB

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #22426|0   |1
is obsolete||

--- Comment #5 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 24210
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24210action=edit
[SIGNED OFF] Bug 11136 - action_logs should be a MyISAM table, not InnoDB

The table action_logs is written too at a higher rate than practically
any other table. Additionally, action_logs has no foreign key
constraints. It seems that this would be a somewhat unique situation
where using MyISAM would provide quite a performance boost for large
sites with many transactions that use the Action Logs.

TEST PLAN
-

NOTE: These instructions toast the database, so backup as needed!

1) open mysql client
2) use the koha database
3) show create table action_logs;
-- This should currently be InnoDB listed as the engine.
4) close mysql client
5) apply patch
6) ./installer/data/mysql/updatedatabase.pl
-- This should apply the update.
7) open mysql client
8) use the koha database
9) show create table action_logs;
-- The engine should now be MyISAM.
10) drop the koha database
11) create the koha database
12) close mysql client
13) go to the staff client and do the web installation
14) open mysql client
15) use the koha database
16) show create table action_logs;
-- The engine should now be MyISAM.
   Also, the AUTO_INCREMENT won't be shown, since the log file
is currently empty.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11136] action_logs should be a MyISAM table, not InnoDB

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #6 from M. Tompsett mtomp...@hotmail.com ---
I agreed with Kyle's reasoning, noted that both the fresh install and update
are done. This will need a number tweak before being pushed to master, as it is
3.13 instead of the expected 3.15, but that's not really an issue I think.
Signed off! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11489] OPAC search results in 404 error when the only search result is supressed

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11432

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11432] 404.pl redirect for single, hidden result makes no sense.

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11489

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11432] 404.pl redirect for single, hidden result makes no sense.

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432

--- Comment #9 from M. Tompsett mtomp...@hotmail.com ---
Galen, is 11489 the type of patch you were talking about on the IRC channel? If
so, perhaps Jonathan Druart's patch combined with 11489 would be the proper
solution?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #2 from M. Tompsett mtomp...@hotmail.com ---
To be honest, I'm confused by the description. I'm a non-librarian. So there is
order entry and order receiving, right? When do these fields get set? I didn't
go read the code.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148

--- Comment #11 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 23092
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23092
Bug 11148: Two routines are useless in Koha::DateUtils

Review of attachment 23092:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=11148attachment=23092)
-

::: t/DateUtils.t
@@ -68,5 @@
  cmp_ok $date_string, 'eq', '16/06/2011', 'metric output (date only)';
  
 -$date_string = output_pref({ dt = $dt, dateformat = 'metric', timeformat 
 = '24hr' });
 -cmp_ok $date_string, 'eq', '16/06/2011 12:00',
 -  'output_pref_due preserves non midnight HH:SS';

Why did you cut this test? The text is wrong, but the function call is
output_pref, which is still used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2014-01-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #122 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 24211
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24211action=edit
Bug 7143 : Updating about page and history

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/