[Koha-bugs] [Bug 12182] Koha installation problem in Ubuntu
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12182 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #6 from M. Tompsett --- mtompset@ubuntu:~/kohaclone$ prove -v t/QueryParser.t t/QueryParser.t .. ok 1 - use Koha::QueryParser::Driver::PQF; ok 2 - Successfully created empty QP object ok 3 - Loaded QP config ok 4 - Initialized 4 search classes ok 5 - Correct number of search fields for 'keyword' class not ok 6 - super simple keyword query # Failed test 'super simple keyword query' # at t/QueryParser.t line 22. # got: '@or @or @attr 1=1016 @attr 4=6 "smith" @attr 2=102 @attr 9=20 @attr 4=6 "smith" @attr 9=34 @attr 2=102 @attr 4=6 "smith"' # expected: '@or @or @attr 1=1016 @attr 4=6 "smith" @attr 9=20 @attr 2=102 @attr 4=6 "smith" @attr 9=34 @attr 2=102 @attr 4=6 "smith"' ok 7 - simple author query ok 8 - fielded publisher query ok 9 - phrase query not ok 10 - relevance-bumped query # Failed test 'relevance-bumped query' # at t/QueryParser.t line 26. # got: '@attr 1=4 @attr 2=102 @attr 9=20 @attr 4=6 "smith"' # expected: '@attr 1=4 @attr 9=20 @attr 2=102 @attr 4=6 "smith"' ok 11 - query with boolean && ok 12 - query with boolean && ok 13 - keyword search with pubdate limited to -2008 ok 14 - keyword search with pubdate limited to 2008- ok 15 - keyword search with pubdate limited to 2008 ok 16 - keyword search with pubdate limited to 1980, 2008 not ok 17 - keyword search sorted by acqdate descending # Failed test 'keyword search sorted by acqdate descending' # at t/QueryParser.t line 33. # got: '@or @attr 7=1 @attr 1=32 0 @attr 1=1003 @attr 4=6 "smith"' # expected: '@or @attr 1=32 @attr 7=1 0 @attr 1=1003 @attr 4=6 "smith"' ok 18 - retrieve field by attr ok 19 - retrieve field by attrstring ok 20 - clear all mappings returns self ok 21 - clear all configuration returns self ok 22 - All mapping erased ok 23 - serialized YAML valid ok 24 - Mappings serialized correctly to YAML ok 25 - serialized JSON valid ok 26 - Mappings serialized correctly to JSON ok 27 - TEST_SETUP returns self ok 28 - Initialized 4 search classes in test setup 1..28 # Looks like you failed 3 tests of 28. Dubious, test returned 3 (wstat 768, 0x300) Failed 3/28 subtests Test Summary Report --- t/QueryParser.t (Wstat: 768 Tests: 28 Failed: 3) Failed tests: 6, 10, 17 Non-zero exit status: 3 Files=1, Tests=28, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.11 cusr 0.01 csys = 0.14 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
--- Comment #42 from M. Tompsett ---
(In reply to David Cook from comment #41)
> ::: C4/Biblio.pm
> > +my $rv = $sth->execute($frameworkcode);
>
> Why is there a "my $rv" here? It shouldn't be needed.
It was debugging code that I forgot to strip. :)
> > +if (!$show || $show==0) {
>
> $show should always be 1 or undefined, so I wouldn't think $show==0
> would be necessary.
Actually, 1, 0, or undefined. Someone could put => 0 into the hash checked.
I'll confirm if I can simplify the logic.
> @@ +1334,5 @@
> > +my $show = $display->{$interface}->{
> > $data->{$fullfield}->{$tag}->{'hidden'} };
> > +if (!$show || $show==0) {
> > +$shouldhidemarc{ $field } = 1;
> > +}
> > +elsif ( !exists($shouldhidemarc{ $field }) ) {
>
> It shouldn't be necessary to add fields that aren't hidden to this hash.
> Plus, since the value is 0, you'll most likely get the same end result you
> would if you didn't have this block of code.
I don't like having undefined values. Those tend to generate annoying floody
errors when some comparison works but was expecting a number, for example.
> @@ +1493,5 @@
> > +# LDR field is excluded from $record->fields().
> > +# if we hide it here, the MARCXML->MARC::Record->MARCXML
> > +# transformation blows up.
> > +#}
> > +foreach my $fields ($record->fields()) {
>
> Should probably use $field rather than $fields, as this incorrect
> pluralization gets confusing lower down.
Okay, that makes sense.
> @@ +1495,5 @@
> > +# transformation blows up.
> > +#}
> > +foreach my $fields ($record->fields()) {
> > +my $tag = $fields->tag();
> > +my $hidden;
>
> This $hidden variable isn't really necessary. If it should be hidden, you
> should just hide/delete it upon detection. The code looks like it would work
> either way, but it would be easier to read with less needless code.
If you look at the hidden value setting that would be inside an if/else. I
scoped it wider, so there was no need to have two lines of code. Fine, two
lines of code it is.
> > +my $visibility =
> > $marcsubfieldstructure->{$tag}->{$subtag}->{hidden};
> > +$visibility //= 0;
>
> Is there are a reason to have this extra line instead of "my $visibility =
> $marcsubfieldstructure->{$tag}->{$subtag}->{hidden} // 0"?
Yes, because otherwise visibility is undef. It should be a valid number (-7 to
+7) reflecting valid values set in the Advanced Constraints screen.
> @@ +1670,4 @@
> > $oauthors .= "&rft.au=$au";
> > }
> > }
> > +$title = $record->subfield( '245', 'a' ) // '';
>
> Why is this in this patch?
This fixes a floody error I had during testing. I suppose it could be another
patch. I'll confirm.
> @@ +2122,4 @@
> > push @marcsubjects, {
> > MARCSUBJECT_SUBFIELDS_LOOP => \@subfields_loop,
> > authoritylink => $authoritylink,
> > +} if $authoritylink || @subfields_loop;
>
> Why is this in this patch?
This properly hides the subjects.
> ::: C4/XSLT.pm
> @@ +93,5 @@
> > +@new_subfields
> > +) );
> > +}
> > +else {
> > +$record->delete_fields($field);
>
> What is this doing here, and why is it in this patch?
If you try to delete the last subfield of a field, you need to delete the
field. If I recall, deleting the last subfield fails. Fields/subfields are
deleted (from memory) to hide them from being displayed.
> ::: opac/opac-detail.pl
> @@ +683,4 @@
> > my $marcseriesarray = GetMarcSeries ($record,$marcflavour);
> > my $marcurlsarray= GetMarcUrls($record,$marcflavour);
> > my $marchostsarray = GetMarcHosts($record,$marcflavour);
> > +my ($st_tag,$st_subtag) =
> > GetMarcFromKohaField('bibliosubtitle.subtitle',$dat->{'frameworkcode'});
>
> I think that this section is a mistake.
GetRecordValue, which is what was there initially, does not grab values from
marc_subfield_structure, but rather fieldmapping. This means the subtitle is
not properly hidden.
> What is bibliosubtitle.subtitle? Also, why would this be in this patch?
The value in the marc_subfield_structure table. Subtitles are a mess in Koha.
> ::: opac/opac-showmarc.pl
> @@ +55,4 @@
> >
> > if ($view eq 'card' || $view eq 'html') {
> > my $xmlrecord= $importid? $record->as_xml():
> > GetXmlBiblio($biblionumber);
> > +if (!$importid && $view eq 'html') {
>
> I haven't looked at the context, but why not filter for all cases here?
I think this is related to the save as exports. This is what worked for me.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lis
[Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
--- Comment #41 from David Cook ---
Comment on attachment 28480
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28480
Bug 11592 - MARC Visibility settings not respected
Review of attachment 28480:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11592&attachment=28480)
-
Overall, I really want to see this patch get into Koha. However, I think there
is some unnecessary code, some potentially incorrect code, and some code that
probably belongs in a different bug/patch.
::: C4/Biblio.pm
@@ +1322,5 @@
> +my $display = ShouldDisplayOnInterface();
> +
> +my $dbh = C4::Context->dbh;
> +my $sth = $dbh->prepare("SELECT kohafield AS field, tagfield AS tag,
> hidden FROM marc_subfield_structure WHERE kohafield>'' AND frameworkcode=?
> ORDER BY field, tagfield;");
> +my $rv = $sth->execute($frameworkcode);
Why is there a "my $rv" here? It shouldn't be needed.
@@ +1331,5 @@
> +my @tmpsplit = split(/\./,$fullfield);
> +my $field = $tmpsplit[-1];
> +foreach my $tag (keys %{$data->{$fullfield}}) {
> +my $show = $display->{$interface}->{
> $data->{$fullfield}->{$tag}->{'hidden'} };
> +if (!$show || $show==0) {
$show should always be 1 or undefined, so I wouldn't think $show==0 would be
necessary
@@ +1334,5 @@
> +my $show = $display->{$interface}->{
> $data->{$fullfield}->{$tag}->{'hidden'} };
> +if (!$show || $show==0) {
> +$shouldhidemarc{ $field } = 1;
> +}
> +elsif ( !exists($shouldhidemarc{ $field }) ) {
It shouldn't be necessary to add fields that aren't hidden to this hash. Plus,
since the value is 0, you'll most likely get the same end result you would if
you didn't have this block of code.
@@ +1493,5 @@
> +# LDR field is excluded from $record->fields().
> +# if we hide it here, the MARCXML->MARC::Record->MARCXML
> +# transformation blows up.
> +#}
> +foreach my $fields ($record->fields()) {
Should probably use $field rather than $fields, as this incorrect pluralization
gets confusing lower down.
@@ +1495,5 @@
> +# transformation blows up.
> +#}
> +foreach my $fields ($record->fields()) {
> +my $tag = $fields->tag();
> +my $hidden;
This $hidden variable isn't really necessary. If it should be hidden, you
should just hide/delete it upon detection. The code looks like it would work
either way, but it would be easier to read with less needless code.
@@ +1500,5 @@
> +if ($tag>=10) {
> +foreach my $subpairs ($fields->subfields()) {
> +my ($subtag,$value) = @$subpairs;
> +my $visibility =
> $marcsubfieldstructure->{$tag}->{$subtag}->{hidden};
> +$visibility //= 0;
Is there are a reason to have this extra line instead of "my $visibility =
$marcsubfieldstructure->{$tag}->{$subtag}->{hidden} // 0"?
@@ +1670,4 @@
> $oauthors .= "&rft.au=$au";
> }
> }
> +$title = $record->subfield( '245', 'a' ) // '';
Why is this in this patch?
@@ +2122,4 @@
> push @marcsubjects, {
> MARCSUBJECT_SUBFIELDS_LOOP => \@subfields_loop,
> authoritylink => $authoritylink,
> +} if $authoritylink || @subfields_loop;
Why is this in this patch?
::: C4/XSLT.pm
@@ +93,5 @@
> +@new_subfields
> +) );
> +}
> +else {
> +$record->delete_fields($field);
What is this doing here, and why is it in this patch?
::: opac/opac-detail.pl
@@ +683,4 @@
> my $marcseriesarray = GetMarcSeries ($record,$marcflavour);
> my $marcurlsarray= GetMarcUrls($record,$marcflavour);
> my $marchostsarray = GetMarcHosts($record,$marcflavour);
> +my ($st_tag,$st_subtag) =
> GetMarcFromKohaField('bibliosubtitle.subtitle',$dat->{'frameworkcode'});
I think that this section is a mistake.
What is bibliosubtitle.subtitle? Also, why would this be in this patch?
::: opac/opac-showmarc.pl
@@ +55,4 @@
>
> if ($view eq 'card' || $view eq 'html') {
> my $xmlrecord= $importid? $record->as_xml(): GetXmlBiblio($biblionumber);
> +if (!$importid && $view eq 'html') {
I haven't looked at the context, but why not filter for all cases here?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #13 from Robin Sheat --- Assuming Mark's code is backwards compatible, it should work anyway. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #12 from David Cook --- I suppose I'm a bit hesitant to sign off on this one at the moment because of Mark's bug 11592. That said, I'm not going to sign off on Mark's patch either, as I'm not sold on the code there... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12367] Import patrons still says "MD5 hash"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12367 David Cook changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12367] Import patrons still says "MD5 hash"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12367 David Cook changed: What|Removed |Added Attachment #28671|0 |1 is obsolete|| --- Comment #2 from David Cook --- Created attachment 28693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28693&action=edit Bug 12367 - Import patrons still says "MD5 hash" The password hashing algorithm was changed in Bug 9611, but on Tools > Import patrons, in the text on the right hand side, it still says: "'password' should be stored in plaintext, and will be converted to a MD5 hash" This has no practical effect, of course, but to someone evaluating Koha it might give the false impression that password security is lower than it really is. To test: - Look at Tools > Import patrons and verify that it says "a MD5 hash" - Also look at the help page and see the same text - Apply the patch - Check that both the tool and the help now says "a Bcrypt hash" I'll do a patch for the docs too. Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12361] No default value for opaccolorstylesheet syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12361 David Cook changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12361] No default value for opaccolorstylesheet syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12361 David Cook changed: What|Removed |Added Attachment #28669|0 |1 is obsolete|| --- Comment #3 from David Cook --- Created attachment 28692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28692&action=edit Bug 12361 - No default value for opaccolorstylesheet syspref After install, the syspref opaccolorstylesheet will by default contain colors.css. This file exist in OPAC prog theme but not in bootstrap theme. This patch set the syspref empty by default in installer/data/mysql/sysprefs.sql. Test plan : - Create a fresh install - Look at opaccolorstylesheet content => without this patch : is contains colors.css => with this patch : it is empty - Enable opac bootstrap theme - Go to opac main page - Look at HTTP errors (with firebug for example) => without this patch : there is a 404 error because colors.css does not exist => with this patch : no such error Signed-off-by: David Cook Glad to see this one. That warning was annoying. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9093] 008 forgetting what material type was chosen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 David Cook changed: What|Removed |Added Attachment #28690|0 |1 is obsolete|| --- Comment #7 from David Cook --- Created attachment 28691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28691&action=edit Bug 9093 - 008 forgetting what material type was chosen This patch adds material type checking to the MARC21 008 tag editor, based on value from the leader. That is, the 008 tag editor will choose an initial material type based on the leader 06 (and if necessary the leader 07 position) _TEST PLAN_ 1) Create a new record or open an existing bib record 2) Change position 6 from its current value (probably "a") to "c" or "e" or "g" or "m" or "p". (See the end of this message for a comprehensive list of 06 values to try.) 3) Open the 008 tag editor 4) Note that it still says BKS even though it should say "MU" or "MP" or "VM" or "CF" or "MX". 5) Apply the patch 6) Repeat steps 2 and 3. 7) Note that the 008 tag editor now shows the correct material type based on the leader. 8) For more comprehensive checking, try switching position 6 back to "a" and changing position 7 to "b" instead of "m". 9) Note that it will switch from "BKS" to "CR". 10) Fin Comprehensive mapping: Field 008/18-34 Configuration If Leader/06 = a and Leader/07 = a, c, d, or m: Books If Leader/06 = a and Leader/07 = b, i, or s: Continuing Resources If Leader/06 = t: Books If Leader/06 = c, d, i, or j: Music If Leader/06 = e, or f: Maps If Leader/06 = g, k, o, or r: Visual Materials If Leader/06 = m: Computer Files If Leader/06 = p: Mixed Materials http://www.loc.gov/marc/bibliographic/bdleader.html -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9093] 008 forgetting what material type was chosen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9093] 008 forgetting what material type was chosen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 --- Comment #6 from David Cook --- Created attachment 28690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28690&action=edit Bug 9093 - 008 forgetting what material type was chosen This patch adds material type checking to the MARC21 008 tag editor, based on value from the leader. That is, the 008 tag editor will choose an initial material type based on the leader 06 (and if necessary the leader 07 position) _TEST PLAN_ 1) Create a new record or open an existing bib record 2) Change position 6 from its current value (probably "a") to "c" or "e" or "g" or "m" or "p". (See the end of this message for a comprehensive list of 06 values to try.) 3) Open the 008 tag editor 4) Note that it still says BKS even though it should say "MU" or "MP" or "VM" or "CF" or "MX". 5) Apply the patch 6) Repeat steps 2 and 3. 7) Note that the 008 tag editor now shows the correct material type based on the leader. 8) For more comprehensive checking, try switching position 6 back to "a" and changing position 7 to "b" instead of "m". 9) Note that it will switch from "BKS" to "CR". 10) Fin Comprehensive mapping: Field 008/18-34 Configuration If Leader/06 = a and Leader/07 = a, c, d, or m: Books If Leader/06 = a and Leader/07 = b, i, or s: Continuing Resources If Leader/06 = t: Books If Leader/06 = c, d, i, or j: Music If Leader/06 = e, or f: Maps If Leader/06 = g, k, o, or r: Visual Materials If Leader/06 = m: Computer Files If Leader/06 = p: Mixed Materials http://www.loc.gov/marc/bibliographic/bdleader.html -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12378] addbiblio.pl error when deleting record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12378 Ian Palko changed: What|Removed |Added Version|3.14|master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12378] New: addbiblio.pl error when deleting record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12378 Bug ID: 12378 Summary: addbiblio.pl error when deleting record Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: libr...@stas.org QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl When deleting a record using the menu on the detail.pl page, "normal" tab, the biblio is successfully deleted, but this is followed by a web page showing: - Software error: Can't call method "title" on an undefined value at /usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl line 838. -- Previously after deletion of the biblio, koha would return to the advanced search page. After upgrading to 3.16 it is repeatable everytime an biblio is deleted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9093] 008 forgetting what material type was chosen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au Assignee|gmcha...@gmail.com |dc...@prosentient.com.au --- Comment #5 from David Cook --- (In reply to Bernardo Gonzalez Kriegel from comment #3) > Created attachment 20789 [details] > Material type as determined by Leader/06 and Leader/07 > > 008 do not forgets, because it don't know. > As stated in http://www.loc.gov/marc/formatintegration.html, > "Field 008 does not carry any explicit flag identifying the definition of > positions 18-34. Instead, the identification of the type of field 008 is > dependent on the content of Leader/06 (Type of record) and,in the case of > textual material (i.e., when Leader/06 contains value a), the content of > Leader/07 (Bibliographic level)." > > So to fix this we need a way to pass Leader/06 and /07 to the plugin so it > learns and shows proper material type, and that if the leader is correctly > filled. > > Attached is a PDF with all possible combinations on leader/06 /07 and what > kind of material type must be set. Good work on the PDF! It looks like it's incorrect for 06 "a" 07 "i", but otherwise perfect. Field 008/18-34 Configuration If Leader/06 = a and Leader/07 = a, c, d, or m: Books If Leader/06 = a and Leader/07 = b, i, or s: Continuing Resources If Leader/06 = t: Books If Leader/06 = c, d, i, or j: Music If Leader/06 = e, or f: Maps If Leader/06 = g, k, o, or r: Visual Materials If Leader/06 = m: Computer Files If Leader/06 = p: Mixed Materials http://www.loc.gov/marc/bibliographic/bdleader.html I'm going to look at this one today. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9093] 008 forgetting what material type was chosen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 David Cook changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #4 from David Cook --- *** Bug 11472 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11472] MARC21 008 plugin should consult leader to set default type of material
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11472 David Cook changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from David Cook --- Yep, definitely a duplicate. *** This bug has been marked as a duplicate of bug 9093 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12338] Remove smartmatch operator from C4/Serials.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12338 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12338] Remove smartmatch operator from C4/Serials.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12338 Chris Cormack changed: What|Removed |Added Attachment #28578|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 28689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28689&action=edit Bug 12338: Remove smartmatch operator from C4/Serials.pm This patch removes the use of the 'when' smartmatch operator from Serials.pm Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11742] Overdue notice/status triggers displaying the wrong notice for default
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11742 Chris Cormack changed: What|Removed |Added Attachment #28021|0 |1 is obsolete|| --- Comment #7 from Chris Cormack --- Created attachment 28688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28688&action=edit Bug 11742: A letter code should be unique. This patch is a dirty way to fix a design issue on notices. Currently the code assumes that a letter code is unique. Which is wrong, the primary key is module, code, branchcode. Maybe we should add a primary key (id) for the letter table in order to pass the id to the template and correctly manage the letter code duplication. Test plan: Try to duplicate a letter code using edit, add and copy actions. If you manage to do it, please describe how you did. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11742] Overdue notice/status triggers displaying the wrong notice for default
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11742 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11742] Overdue notice/status triggers displaying the wrong notice for default
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11742 Chris Cormack changed: What|Removed |Added Attachment #28020|0 |1 is obsolete|| --- Comment #6 from Chris Cormack --- Created attachment 28687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28687&action=edit Bug 11742: Change return type for GetLetters The GetLetters subroutine should return an arrayref with different letters for a module. Test plan: 0/ Delete your notices with module=claimacquisition, claimissues, serial 1/ Go on the late orders page (acqui/lateorders.pl) and verify you cannot choose a notice for claiming 2/ Create a notice with module=claimacquisition 3/ Go on the late orders page (acqui/lateorders.pl) and verify you can choose the notice for claiming 4/ Go on the Claim serials page (serials/claims.pl) and repeat the same thing with the a "claimissues" notice 5/ Create a new subscription (serials/subscription-add.pl) and verify you cannot choose a notification for patrons. 6/ Create a notice with module "serial" and verify you can. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11472] MARC21 008 plugin should consult leader to set default type of material
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11472 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel --- Mmm, duplicate of Bug 9093? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10438] Packages pocket/name-versioning broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10438 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #2 from Martin Renvoize --- I personally liked this idea and feel it's wrong to be pushing people onto .0 releases. The idea needs fleshing out as per Lars's suggestions. I'm disappointed that this is a 'WONTFIX'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12377] Add date pickers to serials-edit.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 --- Comment #1 from Kyle M Hall --- Created attachment 28686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28686&action=edit Bug 12377 - Add date pickers to serials-edit.pl There are two date fields when receiving serials on serials-edit.pl, these inputs should have a calendar widget like other date fields in Koha. Test Plan: 1) Apply this patch 2) Recieve a serial 3) Note when clicking on the "Published on" or "Expected on" fields you will now have a calendar popup. Note you can still manually edit the date if you wish to. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12377] Add date pickers to serials-edit.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12377] Add date pickers to serials-edit.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12377] New: Add date pickers to serials-edit.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377 Bug ID: 12377 Summary: Add date pickers to serials-edit.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com There are two date fields when receiving serials on serials-edit.pl, these input should have a calendar widget like other date fields in Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12376] blinking cursor not clear in larger resolutions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12376 --- Comment #1 from Nicole C. Engard --- Created attachment 28685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28685&action=edit cursor right on the edge of the box and hard to see -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12376] New: blinking cursor not clear in larger resolutions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12376 Bug ID: 12376 Summary: blinking cursor not clear in larger resolutions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 28684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28684&action=edit easy to see on higher resolution This is one that I'm not sure we can fix, but users have noticed that the cursor isn't easy to see on higher resolutions. See my screenshots for examples - is there a way to add some padding or something on the boxes in Koha? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375
--- Comment #10 from Kyle M Hall ---
Created attachment 28683
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28683&action=edit
Bug 12375 [4] - Replace use of DBI with Koha::Database in C4::Serials::NewIssue
Currently, all serials enumeration data is stored in conglomerated
fashion in serial.serialseq. This makes it extremely difficult to do any
reporting based on the individual sequence values due to this fact. In
addition to the formatted version of the sequence, we should be storing
the individual values as well.
Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create a new subscription, and add serials to it. The new x y and
z fields should be populated with the same data the replaces {X} {Y} and
{Z} in the enumeration field.
4) Inspect some existing serials. The update script will have made a
best effort to recover the existing enumeration data to store in
separate fields.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Kyle M Hall changed: What|Removed |Added Attachment #28675|0 |1 is obsolete|| Attachment #28676|0 |1 is obsolete|| Attachment #28677|0 |1 is obsolete|| Attachment #28679|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 28680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28680&action=edit Bug 12375 [1] - Update database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #8 from Kyle M Hall --- Created attachment 28681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28681&action=edit Bug 12375 [2] - Update Serial schema file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #9 from Kyle M Hall --- Created attachment 28682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28682&action=edit Bug 12375 [3] - Store serials enumeration data in separate fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12266] The z39.50 authority search to create new auth record works randomly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12266 --- Comment #4 from Marc Véron --- Hi Ian, Is it possible to sign off? Thanks Marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375
Kyle M Hall changed:
What|Removed |Added
Attachment #28678|0 |1
is obsolete||
--- Comment #6 from Kyle M Hall ---
Created attachment 28679
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28679&action=edit
Bug 12375 [4] - Replace use of DBI with Koha::Database in C4::Serials::NewIssue
Currently, all serials enumeration data is stored in conglomerated
fashion in serial.serialseq. This makes it extremely difficult to do any
reporting based on the individual sequence values due to this fact. In
addition to the formatted version of the sequence, we should be storing
the individual values as well.
Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create a new subscription, and add serials to it. The new x y and
z fields should be populated with the same data the replaces {X} {Y} and
{Z} in the enumeration field.
4) Inspect some existing serials. The update script will have made a
best effort to recover the existing enumeration data to store in
separate fields.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #2 from Kyle M Hall --- Created attachment 28675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28675&action=edit Bug 12375 [1] - Update database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #4 from Kyle M Hall --- Created attachment 28677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28677&action=edit Bug 12375 [3] - Store serials enumeration data in separate fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #3 from Kyle M Hall --- Created attachment 28676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28676&action=edit Bug 12375 [2] - Update Serial schema file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #5 from Kyle M Hall --- Created attachment 28678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28678&action=edit Bug 12375 [4] - Replace use of DBI with Koha::Database in C4::Serials::NewIssue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #1 from Kyle M Hall --- *** Bug 8956 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #64 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 12375 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12375] New: Store serials enumeration data in separate fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Bug ID: 12375 Summary: Store serials enumeration data in separate fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com Currently, all serials enumeration data is stored in conglomerated fashion in serial.serialseq. This makes it extremely difficult to do any reporting based on the individual sequence values due to this fact. In addition to the formatted version of the sequence, we should be storing the individual values as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8991] Add a script to delete old orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8991 Paola Rossi changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||paola.ro...@cineca.it --- Comment #21 from Paola Rossi --- I apply against master 3.17.00.007 in comment 16: "A confirm flag is needed for deleting records. Without it, a list of orders and baskets is displayed." Without "-c" option set, the script makes some anticipations. The script counts orders to delete (completely received orders) and baskets to delete (basket without orders). But, counting the baskets, the script doesn't count the baskets whose orders, being completely received, are all eraseable. So after the first run without "-c" option set, the following execution with "-c" set will be able to delete some baskets: this is unexpected! NB1. The script doesn't delete orders received _before_ some date, but _until_ some date. The day in the "-until" option is included. NB2. There is no way to ask for deleting only orders and not the baskets. There is no way to ask for deleting only empty baskets. I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11857] Number of patrons on a patron list not accurate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11857 --- Comment #4 from Fridolin SOMERS --- I'm not 100% sure how the patch works, I'm new to DBIx. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12266] The z39.50 authority search to create new auth record works randomly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12266 Ian Palko changed: What|Removed |Added CC||libr...@stas.org --- Comment #3 from Ian Palko --- I manually edited the authorities_js.inc on my test system according to Marc's patch. It restored the past functionality of the z39.50 add new authority setup, which we use often (we're currently cleaing up our authorities database and standardizing it). Pushed to our production system after testing and also seems to fix the problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12374] New: Feature request: add koha-mqsqldump script, analagous to koha-mysql
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12374 Bug ID: 12374 Summary: Feature request: add koha-mqsqldump script, analagous to koha-mysql Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcha...@gmail.com Reporter: bar...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The command debian/scripts/koha-mysql is used to execute mysql on a given site without entering sql credentials, but if a database dump is required, there is not analogous tool available. It would be trivial to copy koha-mysql to koha-mysqldump and call mysqldump instead. See notes in bug 12372 about passing arguments into such a script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and manipulating collections of patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Fridolin SOMERS changed: What|Removed |Added Blocks||11857 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11857] Number of patrons on a patron list not accurate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11857 Fridolin SOMERS changed: What|Removed |Added Depends on||10565 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12373] New: yuipath system preference affects OPAC but is filed under Staff Client: Appearance
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12373 Bug ID: 12373 Summary: yuipath system preference affects OPAC but is filed under Staff Client: Appearance Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: m...@software.coop QA Contact: testo...@bugs.koha-community.org To test: 1. load the OPAC homepage and View Source, see the yui lines; 2. change the yuipath system preference; 3. reload the OPAC homepage and see the yui lines have changed. Should the yuipath preference be renamed (it isn't a path) and split into one for OPAC and one for intranet? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12025] Inventory tool fails with "Could not reads headers", or sometimes a timeout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12025 Galen Charlton changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #15 from Galen Charlton --- Pushed to 3.16.x for inclusion in 3.16.1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12295] Javascript error when merging authorities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 Galen Charlton changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #7 from Galen Charlton --- Pushed to 3.16.x for inclusion in 3.16.1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11857] Number of patrons on a patron list not accurate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11857 Fridolin SOMERS changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12372] New: feature request: debian/scripts/koha-mysql should be able to handle arbitrary mysql arguments.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12372 Bug ID: 12372 Summary: feature request: debian/scripts/koha-mysql should be able to handle arbitrary mysql arguments. Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcha...@gmail.com Reporter: bar...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The call to 'mysql' in /home/koha/kohaclone/debian/scripts/koha-mysql looks like this: mysql --host="$mysqlhost" --user="$mysqluser" --password="$mysqlpass" \ "$mysqldb" If $name were shifted off the argument stack, rather than simply assigned from $1, we could then pass the rest of the arguments directly to mysql: mysql --host="$mysqlhost" --user="$mysqluser" --password="$mysqlpass" \ "$mysqldb" "$@" This would make the koha-mysql command far more flexible at the command line, for instance koha-mysql mybranch --vertical or koha-mysql mybranch --html or koha-mysql mybranch --table would all be possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11857] Number of patrons on a patron list not accurate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11857 --- Comment #3 from Fridolin SOMERS --- Created attachment 28674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28674&action=edit Bug 11857 - Number of patrons on a patron list not accurate When creating a patron list with only 1 patron, the patron lists page says that the list contains 3 patrons. When creating a patron list with only 1 patron, it works fine. This is caused by the fact that access on "patron_list_patrons" Koha::Schema::Result::PatronList object retruns an hash if one result and an array if more results. See similar problem at http://permalink.gmane.org/gmane.comp.lang.perl.modules.template-toolkit/7250 This patch replaces by the call on resultset and then the use of "count" method. Test plan : - Go to patron lists : /cgi-bin/koha/patron_lists/lists.pl - Create a new patron list LIO - Add one patron - Create a new patron list LIM - Add 2 patrons - Go to patron lists : /cgi-bin/koha/patron_lists/lists.pl => Without this patch you see : Name Patrons in list LIO 3 LIM 2 => With this patch you see : Name Patrons in list LIO 1 LIM 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11857] Number of patrons on a patron list not accurate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11857 Fridolin SOMERS changed: What|Removed |Added CC||fridolyn.som...@biblibre.co ||m Assignee|koha-b...@lists.koha-commun |fridolyn.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12025] Inventory tool fails with "Could not reads headers", or sometimes a timeout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12025 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #14 from Tomás Cohen Arazi --- Pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12295] Javascript error when merging authorities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #6 from Tomás Cohen Arazi --- Pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12371] New: Links in every patron self-registration email points to a single borrower
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12371 Bug ID: 12371 Summary: Links in every patron self-registration email points to a single borrower Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: bar...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Library has the following system preferences set for Patron Self Registration: *** 1. row *** variable: PatronSelfRegistration value: 1 options: NULL explanation: If enabled, patrons will be able to register themselves via the OPAC. type: YesNo *** 2. row *** variable: PatronSelfRegistrationAdditionalInstructions value: Thank you for registering for a library card. To complete your registration, please come to your library (Cook, Jackson, or Madison) with identification documents, that show: proof of residency (physical address) mailing address photo ID We will save your information for 30 days, please stop in soon! options: NULL explanation: A free text field to display additional instructions to newly self registered patrons. type: free *** 3. row *** variable: PatronSelfRegistrationBorrowerMandatoryField value: surname|firstname|email|phone options: NULL explanation: Choose the mandatory fields for a patron's account, when registering via the OPAC. type: free *** 4. row *** variable: PatronSelfRegistrationBorrowerUnwantedField value: sex options: NULL explanation: Name the fields you don't want to display when registering a new patron via the OPAC. type: free *** 5. row *** variable: PatronSelfRegistrationDefaultCategory value: ONLINEREG options: explanation: A patron registered via the OPAC will receive a borrower category code set in this system preference. type: free *** 6. row *** variable: PatronSelfRegistrationExpireTemporaryAccountsDelay value: 30 options: NULL explanation: If PatronSelfRegistrationDefaultCategory is enabled, this system preference controls how long a patron can have a temporary status before the acc ount is deleted automatically. It is an integer value representing a number of days to wait before deleting a temporary patron account. Setting it to 0 disabl es the deleting of temporary accounts. type: Integer *** 7. row *** variable: PatronSelfRegistrationVerifyByEmail value: 1 options: NULL explanation: If enabled, any patron attempting to register themselves via the OPAC will be required to verify themselves via email to activate his or her acco unt. type: YesNo --- The self registration email is sent emails contining unique tokens, but all of the tokens are associated with borrowernumber 0: select verification_token, count(verification_token), borrowernumber from borrower_modifications where verification_token is not null group by verification_token; +--+---++ | verification_token | count(verification_token) | borrowernumber | +--+---++ | 8748c0cf981f3fadd6ec78433a5beddb | 1 | 0 | | 96738d8a27251326a7eb3971b1a03eb5 | 1 | 0 | | a5de1159d20fd3ed3f4a8d189db3fb32 | 1 | 0 | | aa131a40d93057e676c363a3e11be060 | 1 | 0 | | adf1bbfd6715714e9e8642e38d0c4462 | 1 | 0 | | b28898063358455c350e7eff9dc4cb94 | 1 | 0 | | ba24d496a711aa07f4a20a99c10c6d58 | 1 | 0 | | e035486fb47e2b6f3af641550098f6ea | 1 | 0 | | ec09849390835652149736252010b66e | 1 | 0 | | fdf76c060abb49b2ad1dc7aa2bdea7fb | 1 | 0 | +--+---++ 10 rows in set (0.00 sec) This means that when a patron clicks on the link to verify their identity, they will all connect to the same patron record. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.or
[Koha-bugs] [Bug 12370] New: tell user how many records will be imported on staged tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12370 Bug ID: 12370 Summary: tell user how many records will be imported on staged tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcha...@gmail.com Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org On the staged marc record tool it can be confusing when you have a large batch in which you told Koha to ignore certain items which items will be imported. A tip somewhere on the page before you finally click 'import' would be nice. For example you say you want it to ignore matches a note saying that only the non matching records (with a count) will be imported would be comforting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12369] serial history notes not editable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12369 --- Comment #1 from Nicole C. Engard --- Created attachment 28673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28673&action=edit notes to edit There doesn't appear to be a way to edit the history notes on a serial. If you click 'edit' on the serial those fields aren't there for editing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12369] New: serial history notes not editable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12369 Bug ID: 12369 Summary: serial history notes not editable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12368] Rebuild Zebra improvement: allow to specify a DB table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12368 --- Comment #1 from Jonathan Druart --- Created attachment 28672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28672&action=edit Bug 12368: Rebuild Zebra improvement: allow to specify a DB table Currently the --where parameter only allow to specify a condition on fields in the biblioitems table. For some needs it would be great to specify a condition on the field in the items table. The use case is the following: you want to reindex biblios with items modified since a specific timestamp. Test plan: 1/ Pick an item randomly in your catalogue 2/ Edit it and save 3/ Note that the items.timestamp has been set to today but not the biblioitems.timestamp 4/ launch rebuild_zebra without the new parameter perl misc/migration_tools/rebuild_zebra.pl -b -v --where "timestamp >= XXX" where XXX is the today date (e.g. "2014-06-05 00:00:00"). Note that the biblio has not been indexed. 5/ launch rebuild_zebra using the new parameter: perl misc/migration_tools/rebuild_zebra.pl -b -v -t items --where "timestamp >= XXX" Note the biblio has been indexed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12368] Rebuild Zebra improvement: allow to specify a DB table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12368 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12368] Rebuild Zebra improvement: allow to specify a DB table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12368 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12368] New: Rebuild Zebra improvement: allow to specify a DB table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12368 Bug ID: 12368 Summary: Rebuild Zebra improvement: allow to specify a DB table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Currently the --where parameter only allow to specify a condition on fields in the biblioitems table. For some needs it would be great to specify a condition on the field in the items table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12367] Import patrons still says "MD5 hash"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12367 --- Comment #1 from Magnus Enger --- Created attachment 28671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28671&action=edit Bug 12367 - Import patrons still says "MD5 hash" The password hashing algorithm was changed in Bug 9611, but on Tools > Import patrons, in the text on the right hand side, it still says: "'password' should be stored in plaintext, and will be converted to a MD5 hash" This has no practical effect, of course, but to someone evaluating Koha it might give the false impression that password security is lower than it really is. To test: - Look at Tools > Import patrons and verify that it says "a MD5 hash" - Also look at the help page and see the same text - Apply the patch - Check that both the tool and the help now says "a Bcrypt hash" I'll do a patch for the docs too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12367] Import patrons still says "MD5 hash"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12367 Magnus Enger changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12367] Import patrons still says "MD5 hash"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12367 Magnus Enger changed: What|Removed |Added Assignee|gmcha...@gmail.com |mag...@enger.priv.no -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12087] Improve purge of suggestions: to delete only suggestions with specified status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12087 Jacek Ablewicz changed: What|Removed |Added CC||a...@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Jacek Ablewicz changed: What|Removed |Added CC||a...@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6967] Create suggestion from z39.50 / existing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6967 Jacek Ablewicz changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9851 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9851] way to get full records for purchase suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9851 Jacek Ablewicz changed: What|Removed |Added CC||a...@biblos.pk.edu.pl See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=6967 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Jacek Ablewicz changed: What|Removed |Added CC||a...@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9846] system preference for required purchase suggestion fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9846 Jacek Ablewicz changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10848 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Jacek Ablewicz changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9846 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9846] system preference for required purchase suggestion fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9846 Jacek Ablewicz changed: What|Removed |Added CC||a...@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6967] Create suggestion from z39.50 / existing records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6967 Jacek Ablewicz changed: What|Removed |Added CC||a...@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11801] In transit hold items incorrectly labeled as "Waiting to be pulled" on request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 --- Comment #12 from Martin Renvoize --- Works as advertised and passes qa scripts. I'm also happier with the alternative patch using existent routines. I'm an advocate of dbic, but in this case I think as galen rightly states we should all have an aversion to having multiple ways of asking the same question. Nice work guys -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12367] New: Import patrons still says "MD5 hash"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12367 Bug ID: 12367 Summary: Import patrons still says "MD5 hash" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Tools Assignee: gmcha...@gmail.com Reporter: mag...@enger.priv.no QA Contact: testo...@bugs.koha-community.org The password hashing algorithm was changed in Bug 9611, but on Tools > Import patrons, in the text on the right hand side, it still says: "'password' should be stored in plaintext, and will be converted to a MD5 hash (if your passwords are already encrypted, talk to your system administrator about options)." This has no practical effect, of course, but to someone evaluating Koha it might give the false impression that password security is lower than it really is. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12349] patron name on suggestions should be linked
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12349 Jacek Ablewicz changed: What|Removed |Added CC||a...@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11801] In transit hold items incorrectly labeled as "Waiting to be pulled" on request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11801] In transit hold items incorrectly labeled as "Waiting to be pulled" on request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Martin Renvoize changed: What|Removed |Added Attachment #28664|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 28670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28670&action=edit [PASSED QA] Bug 11801: In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl If an item needs to be transferred to fill a hold, the hold will be listed as 'Waiting to be pulled" while it is in transit. Test Plan: 1) Place a hold for pickup at another library 2) Check in the item, confirm the hold transfer 3) View the holds for that record ( request.pl ) 4) Note the priority is "In transit" and the status is 'Waiting to be pulled". 5) Apply this patch 6) Reload the holds page 7) Note the status is now "Item being transferred to $branch" Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6070] On a new order defined from suggestion some fields were missing.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6070 Jacek Ablewicz changed: What|Removed |Added CC||a...@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11801] In transit hold items incorrectly labeled as "Waiting to be pulled" on request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11801 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Jacek Ablewicz changed: What|Removed |Added CC||a...@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12361] No default value for opaccolorstylesheet syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12361 Fridolin SOMERS changed: What|Removed |Added URL||/cgi-bin/koha/admin/prefere ||nces.pl?tab=&op=search&sear ||chfield=opaccolorstylesheet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12361] No default value for opaccolorstylesheet syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12361 Fridolin SOMERS changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12361] No default value for opaccolorstylesheet syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12361 --- Comment #2 from Fridolin SOMERS --- Created attachment 28669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28669&action=edit Bug 12361 - No default value for opaccolorstylesheet syspref After install, the syspref opaccolorstylesheet will by default contain colors.css. This file exist in OPAC prog theme but not in bootstrap theme. This patch set the syspref empty by default in installer/data/mysql/sysprefs.sql. Test plan : - Create a fresh install - Look at opaccolorstylesheet content => without this patch : is contains colors.css => with this patch : it is empty - Enable opac bootstrap theme - Go to opac main page - Look at HTTP errors (with firebug for example) => without this patch : there is a 404 error because colors.css does not exist => with this patch : no such error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12361] No default value for opaccolorstylesheet syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12361 Fridolin SOMERS changed: What|Removed |Added Summary|Bootstrap theme is missing |No default value for |colors.css |opaccolorstylesheet syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12086] Hold priorities incorrect, when waiting status was reversed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086 --- Comment #19 from Jonathan Druart --- I think something like t/db_dependent/Reserves/RevertWaitingStatus.t is more clear. What about others questions? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10212] Columns configuration for tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jacek Ablewicz changed: What|Removed |Added CC||a...@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12361] Bootstrap theme is missing colors.css
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12361 Fridolin SOMERS changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11472] MARC21 008 plugin should consult leader to set default type of material
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11472 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- This is something that I've been thinking about lately as well. I think the following would be very possible. Dependencies Field 008/18-34 Configuration If Leader/06 = a and Leader/07 = a, c, d, or m: Books If Leader/06 = a and Leader/07 = b, i, or s: Continuing Resources If Leader/06 = t: Books If Leader/06 = c, d, i, or j: Music If Leader/06 = e, or f: Maps If Leader/06 = g, k, o, or r: Visual Materials If Leader/06 = m: Computer Files If Leader/06 = p: Mixed Materials Capitalization - Alphabetic codes are input as lowercase letters. I might actually look at this myself tomorrow or next week... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
