[Koha-bugs] [Bug 12444] New: Show components( example popular/recently acquired books) on main page of any library

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12444

Bug ID: 12444
   Summary: Show components( example popular/recently acquired
books) on main page of any library
 Change sponsored?: ---
   Product: Koha
   Version: 3.14
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: mayanksri1...@gmail.com
QA Contact: testo...@bugs.koha-community.org

I was thinking about providing a functionality for libraries to be able to
showcase their books(along with their cover images) which they have recently
acquired or which are popular to be shown on the homepage.

To facilitate this we should have a component in the staff side, which would
manage the books to be added to the homepage.
With the help of the staff side component, these books can be updated on
weekly/monthly basis, which would be a refreshing change for the patrons of the
library.

Please pour in your suggestions.

Thanks in advance!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12443] Initial re-factoring of buildQuery

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12443

--- Comment #1 from David Cook dc...@prosentient.com.au ---
Created attachment 28917
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28917action=edit
Bug 12443 - Initial re-factoring of buildQuery

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12443] Initial re-factoring of buildQuery

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12443

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

  Attachment #28917|0   |1
is obsolete||

--- Comment #2 from David Cook dc...@prosentient.com.au ---
Created attachment 28918
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28918action=edit
Bug 12443 - Initial re-factoring of buildQuery

This patch reduces three repeated code fragments into a single
internal subroutine, which is easier to read, has comments,
and should make it easier to refactor more buildQuery code
in the future.

_TEST PLAN_

Before applying

1) Run a bunch of different searches in the staff client and OPAC
in separate tabs

2) Apply the patch

3) Run the same searches again (maybe in yet more tabs) and notice
that the results are exactly the same.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12443] Initial re-factoring of buildQuery

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12443

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12427] C4::Members::Attributes.pm needs unit tests

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12427

--- Comment #1 from Yohann Dufour yohann.duf...@biblibre.com ---
Created attachment 28919
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28919action=edit
Bug 12427: adding unit tests of module C4::Members::Attributes.pm

The subroutines UpdateBorrowerAttribute, SearchIdMatchingAttribute,
DeleteBorrowerAttribute, GetBorrowerAttributes, GetAttributes,
GetBorrowerAttributeValue, SetBorrowerAttributes and CheckUniqueness of the
module C4::Members::Attributes.pm was not tested

Test plan:
1/ Execute the command: prove t/db_dependent/Members_Attributes.t
2/ The result has to be:
t/db_dependent/Members_Attributes.t .. ok
All tests successful.
Files=1, Tests=60,  2 wallclock secs ( 0.04 usr  0.01 sys +  1.45 cusr  0.08
csys =  1.58 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12443] Initial re-factoring of buildQuery

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12443

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12427] C4::Members::Attributes.pm needs unit tests

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12427

Yohann Dufour yohann.duf...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12443] Initial re-factoring of buildQuery

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12443

--- Comment #3 from David Cook dc...@prosentient.com.au ---
You should probably turn off TryQueryParser when doing testing as well.

While QueryParser sometimes falls back to non-QueryParser, it's just easier if
you turn it off explicitly for testing purposes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12332] pay.pl and purchase-suggestions.pl tabs do not show selected

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #28865|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28920
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28920action=edit
Bug 12332: Fix for tab Purchase suggestions not lighting up

This patch changes the file purchase-suggestions.pl with suggestionsview = 1
for the template parameter.
In circ-menu.inc i changed the condition from suggestions to
suggestionsview since it seemed to conflict with the existing variable
suggestions (and in that case only highlighting the tab when there were
suggestions).

Please note that I fixed the troubles with the tab Fines in a separate patch
9245.

Test plan:
1) Verify that Purchase suggestions does not light up as it should when
clicked.
2) Install the patch.
3) Verify that the tab Purchase suggestions now actually light up when
clicked.

Signed-off-by: Christopher Brannon cbran...@cdalibrary.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12332] pay.pl and purchase-suggestions.pl tabs do not show selected

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332

sandbo...@biblibre.com sandbo...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12332] pay.pl and purchase-suggestions.pl tabs do not show selected

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
Viktor,
Please start the commit message of your patches by Bug X. Otherwise the
sandboxes cannot signoff them.

I fixed this one and added the Christopher's signoff.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12427] C4::Members::Attributes.pm needs unit tests

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12427

Yohann Dufour yohann.duf...@biblibre.com changed:

   What|Removed |Added

  Attachment #28919|0   |1
is obsolete||

--- Comment #2 from Yohann Dufour yohann.duf...@biblibre.com ---
Created attachment 28921
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28921action=edit
Bug 12427: adding unit tests of module C4::Members::Attributes.pm

The subroutines UpdateBorrowerAttribute, SearchIdMatchingAttribute,
DeleteBorrowerAttribute, GetBorrowerAttributes, GetAttributes,
GetBorrowerAttributeValue, SetBorrowerAttributes and CheckUniqueness of the
module C4::Members::Attributes.pm were not tested.

Test plan:
1/ Execute the command: prove t/db_dependent/Members_Attributes.t
2/ The result has to be:
t/db_dependent/Members_Attributes.t .. ok
All tests successful.
Files=1, Tests=60,  2 wallclock secs ( 0.04 usr  0.01 sys +  1.45 cusr  0.08
csys =  1.58 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12427] C4::Members::Attributes.pm needs unit tests

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12427

Yohann Dufour yohann.duf...@biblibre.com changed:

   What|Removed |Added

  Attachment #28921|0   |1
is obsolete||

--- Comment #3 from Yohann Dufour yohann.duf...@biblibre.com ---
Created attachment 28922
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28922action=edit
Bug 12427: adding unit tests of module C4::Members::Attributes.pm

The subroutines UpdateBorrowerAttribute, SearchIdMatchingAttribute,
DeleteBorrowerAttribute, GetBorrowerAttributes, GetAttributes,
GetBorrowerAttributeValue, SetBorrowerAttributes and CheckUniqueness of the
module C4::Members::Attributes.pm was not tested

Test plan:
1/ Execute the command: prove t/db_dependent/Members_Attributes.t
2/ The result has to be:
t/db_dependent/Members_Attributes.t .. ok
All tests successful.
Files=1, Tests=60,  2 wallclock secs ( 0.04 usr  0.01 sys +  1.45 cusr  0.08
csys =  1.58 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12427] C4::Members::Attributes.pm needs unit tests

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12427

Yohann Dufour yohann.duf...@biblibre.com changed:

   What|Removed |Added

  Attachment #28921|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12445] New: C4::Suggestions.pm needs more unit tests

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445

Bug ID: 12445
   Summary: C4::Suggestions.pm needs more unit tests
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: yohann.duf...@biblibre.com
QA Contact: gmcha...@gmail.com

The routines DelSuggestionsOlderThan, CountSuggestion,
ConnectSuggestionAndBiblio, SearchSuggestion, GetSuggestionInfo, DelSuggestion
and GetSuggestionByStatus of the module C4::Suggestions.pm are not tested in
t/db_dependent/Suggestions.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445

Yohann Dufour yohann.duf...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|ch...@bigballofwax.co.nz|yohann.duf...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12332] pay.pl and purchase-suggestions.pl tabs do not show selected

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332

--- Comment #6 from Viktor Sarge viktor.sa...@regionhalland.se ---
(In reply to Jonathan Druart from comment #5)
 Viktor,
 Please start the commit message of your patches by Bug X. Otherwise
 the sandboxes cannot signoff them.
 
 I fixed this one and added the Christopher's signoff.

Thank you for helping out Jonathan and for testing Christopher! I do have
things to learn with Git and I'm glad that someone caught that I misformated
the commit message before I made more patches.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12437] items.enumchron 952$h field not populated while sending Routing List Notice

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12437

--- Comment #2 from Binu Thomas b...@eclateng.com ---
hello katrin,

When I select Receive in Serials and change the status to Arrived, I get the
item info just below the screen and which has the 952$h filled automatically. I
assign a barcode and fill in the rest of the details and select save. the 952$h
info is displayed in serial info in opac, staff client and items table, but not
in the mail sent through routing list.

I have used serial.serialseq, it also doesnot work.

Thanks,

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

--- Comment #42 from Juhani Seppälä jsep...@student.uef.fi ---
Hello, we're looking at bringing this feature into production and I've been
going through this component - a trivial issue in additems.tt -template:

[% IF ( previousActionRemove ) %]
  [% IF ( removeSuccess ) %]
divItem with barcode '[% addedBarcode %]' Removed successfully!/div
  [% ELSE %]
divFailed to remove item with barcode '[% removedBarcode %]'!/div
divReason: strong[% failureMessage %]/strong/div
  [% END %]
[% END %]

The parameter addedBarcode is used here when it probably was supposed to be
removedBarcode - this leads to the barcode not being displayed after a
succesful item removal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #25871|0   |1
is obsolete||

--- Comment #47 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 28924
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28924action=edit
Bug 9011 - Add the ability to store the last patron to return an item

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #25870|0   |1
is obsolete||

--- Comment #46 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 28923
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28923action=edit
Bug 9011 - Re-engineer circ anonymization, move to subroutine in
C4::Circulation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #25873|0   |1
is obsolete||

--- Comment #48 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 28925
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28925action=edit
Bug 9011 - Add support for StoreLastBorrower to AnonymiseIssueHistory

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12191] Items with not for loan status shouldn't trigger a transfer

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12191

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
I cannot reproduce this issue on master ( db rev 3.17.00.008, commit
7181de4f1ca8e282990c4c624154b658ea0d644f );

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7843] Create RSS for OPAC news

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

--- Comment #2 from Viktor Sarge viktor.sa...@regionhalland.se ---
Created attachment 28926
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28926action=edit
Bug 7843 Create an RSS feed for news in Opac

This patch introduces two new files: opac-news-rss.pl and opac-news-rss.tt.
The files create an RSS feed for news in the opac between them, and to access
the feed you go to opac-news-rss.pl in the opac.
I intentionally waited with creating a RSS icon on opac-main.pl since I think
we might want to discuss a few issues before exposing the feeds publicly even
if the patch is pushed.

Issues I know would be good to discuss is:
* The news items have no individual links since there is no graphical view of
individual news items in the way that a blog would have. Is this a problem for
RSS-readers?
* Should we add additional metadata like author, administrator, publishing
dates etc?
* Currently the feed will display news for all libraries + your home branch if
you access it while logged in. Would only all libraries be better? Or maybe
all libraries + every item for individual branches?

Test plan:
* Install patch a
* Make shure there is news in the Opac.
* Go to the page opac-news-rss.pl in your Opac.
* Verify that an RSS feed shows up with the same news as in opac-main.pl
* Validate the RSS-feed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7843] Create RSS for OPAC news

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

Viktor Sarge viktor.sa...@regionhalland.se changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||k...@univ-lyon3.fr

--- Comment #18 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 8587:
h1Something went wrong !/h1Applying: Bug 8587 - Add a serial lifespan field
to serial subscriptions Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging C4/Serials.pm
CONFLICT (content): Merge conflict in C4/Serials.pm Auto-merging
installer/data/mysql/kohastructure.sql
CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
Auto-merging serials/subscription-add.pl CONFLICT (content): Merge conflict in
serials/subscription-add.pl Auto-merging serials/subscription-detail.pl Failed
to merge in the changes.
Patch failed at 0001 Bug 8587 - Add a serial lifespan field to serial
subscriptions When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 8587 - Add a serial lifespan to serial subscriptions

19415 - Bug 8587 - Add a serial lifespan field to serial subscriptions
19416 - Bug 8587 - Add a serial lifespan to serial subscriptions - Followup -
Change seriallifespan to serial_lifespan for readability

Apply? [(y)es, (n)o, (i)nteractive] Patch left in
/tmp/Bug-8587---Add-a-serial-lifespan-field-to-serial-s-TRyUC2.patch .

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12443] Initial re-factoring of buildQuery

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12443

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #28918|0   |1
is obsolete||

--- Comment #4 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 28927
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28927action=edit
[SIGNED-OFF] Bug 12443 - Initial re-factoring of buildQuery

This patch reduces three repeated code fragments into a single
internal subroutine, which is easier to read, has comments,
and should make it easier to refactor more buildQuery code
in the future.

_TEST PLAN_

Before applying

1) Run a bunch of different searches in the staff client and OPAC
in separate tabs

2) Apply the patch

3) Run the same searches again (maybe in yet more tabs) and notice
that the results are exactly the same.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Same results, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12443] Initial re-factoring of buildQuery

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12443

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12319] Novelist content doesn't work in Bootstrap

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12319

--- Comment #2 from Owen Leonard oleon...@myacpl.org ---
I can reproduce this bug in tags/v3.14.04 but not origin/3.14.x or master.
Looks like the issues is fixed by Bug 11663. Nicole, please check which version
your customer is on and mark this resolved duplicate of 11663 if they are
pre-3.14.4.

If not I guess we'll need more information about their configuration and any
errors which might be showing up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12420] syndetics content broken in bootstrap

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12420

--- Comment #3 from Owen Leonard oleon...@myacpl.org ---
I'm wondering now if this could be another symptom of Bug 11663. When the bug
presents itself Syndetics content appears but doesn't look correct because the
tabs are broken.

Please check whether they are on 3.14.4 or earlier and whether they have the
Cart enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12420] syndetics content broken in bootstrap

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12420

--- Comment #4 from Owen Leonard oleon...@myacpl.org ---
 SyndeticsEditions - couldn't confirm

Looks like there is an existing bug for this: Bug 7694 - Syndetics_Editons not
included

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12422] Javascript error triggered by opacbookbag being disabled while virtualshelves are enabled when using Bootstrap

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12422

--- Comment #2 from Owen Leonard oleon...@myacpl.org ---
Is this a duplicate of Bug 11663: fix display of holding tab in Bootstap OPAC
when opacbookbag syspref is disabled?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #98 from Owen Leonard oleon...@myacpl.org ---
(In reply to Liz Rea from comment #97)
 Eek,yes, this should work just as the staff client does, that a guarantee
 only sees their own issues, and a guarantor sees all guarantee's issues.

I agree.

 Allow Relative A to see checkouts? Y/N
 Allow Relative B to see checkouts? Y/N
 Allow Relative C to see checkouts? Y/N

This system, while it might be useful to some, is an enhancement outside the
scope of this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7843] Create RSS for OPAC news

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |viktor.sarge@regionhalland.
   ||se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449

Peggy Thrasher p.thras...@dover.nh.gov changed:

   What|Removed |Added

 CC||p.thras...@dover.nh.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519

--- Comment #36 from Paola Rossi paola.ro...@cineca.it ---

1) Special case to test for 10519:
I've applied 12257 against master 3.17.00.008.

As you certainly know, an anonymous purchase suggestion can be produced on OPAC
changing AnonSuggestions pref to Allow value, and the AnonymousPatron
pref to an X value (an existent patron's borrowernumber). As a patron, the
AnonymousPatron X should be linked to a library.

I've created a new patron, and I've linked him to Centerville, the same library
of the test-user I log in on intranet.
Then I've created an anonymous purchase suggestion on OPAC.

In Intranet ACQ, the AnonymousPatron X should be listed among the other users
in the Suggested by dropdown list of the Suggestion information filter: OK,
he's listed there.

In ACQ Suggestions, I've set Centerville in Acquisition information filter
For, and I've asked for all suggestions, f.i. organized by status.
In DB the anonymous suggestion has ASKED status, and is not linked to a
library (its branchcode is NULL).
No anonymous suggestion is listed among the pending ones: KO.

In intranet, I've set Any in Acquisition information filter For, and I've
asked for all suggestions, f.i. organized by status.
This time the anonymous suggestion has been listed among the pending ones: OK.
So the problem is about the library, not about the status of the suggestion.

About KO: IMO on OPAC the koha/opac-suggestions.pl should set the
AnonymousPatron's library to the anonymous suggestion branchcode, in case the
APatron has one. So there could be a bug there.
Otherwise, I invite you to pass this 10519 patch to Failed QA status.

2) Note.
When AnonSuggestions pref is set to Allow value, koha lets the
AnonymousPatron pref be kept to 0 value (non-existent patron), its default
value.
But, if in koha every patron should be linked to a library, the
AnonymousPatron should be linked too.
Setting to '0' the AnonymousPatron pref can violate a rule, and so it can
give some problems.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12296] OPAC search box should be customisable

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12296

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12296] OPAC search box should be customisable

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12296

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #28476|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28928
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28928action=edit
Bug 12296 - make search box customisable with OpacCustomSearch

This allows the search box to be replaced by some custom HTML, useful
when you're needing to integrate with some other search system, and
don't want to maintain a template change across upgrades.

Test plan:
* Install patch
* Look at the OPAC, see that nothing has changed.
* Change the OpacCustomSearch syspref to something like h1Zuul/h1
* Look at the OPAC again, you can no longer search, there is only Zuul.

Note:
* should work on both prog and bootstrap

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7843] Create RSS for OPAC news

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843

--- Comment #3 from Owen Leonard oleon...@myacpl.org ---
(In reply to Viktor Sarge from comment #2)

 * The news items have no individual links since there is no graphical view
 of individual news items in the way that a blog would have. Is this a
 problem for RSS-readers?

I think it could be potentially confusing. Maybe we should add an id to each
news item header row and link to that as an in-page anchor?
opac-main.pl#newsitem4

 * Should we add additional metadata like author, administrator, publishing
 dates etc?

I would add publish date. We don't store author or administrator information
with individual news items so we can't show anything relevant there.

 * Currently the feed will display news for all libraries + your home branch
 if you access it while logged in. Would only all libraries be better? Or
 maybe all libraries + every item for individual branches?

I would assume that anyone who was looking at the RSS feed would be doing so in
a feed reader outside the context of a logged-in session, so I'm not sure the
home branch items are going to get seen. I don't like that the feed a logged-in
user would see in their RSS reader would be different from the news they see on
the site, but I'm not sure there's a better way to handle it. A feed for all
libraries might be inappropriate or simply too much data. One option might be
to offer the user a choice?

 - All libraries news plus the user's library
 - All libraries news plus news for all libraries

I don't know how savvy users are with multiple RSS feeds.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12299] SQL setup (MARC21), translation of relators codes - Italian

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12299

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||bgkrie...@gmail.com

--- Comment #3 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Hi Zeno,
there is a problem, your insert lines have an '=' where they must have a ','
e.g.
...VALUES ('RELTERMS','abr' = 'Riduttore');

Change that to
...VALUES ('RELTERMS','abr', 'Riduttore');

Doing that change, file loads ok.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #23595|0   |1
is obsolete||

--- Comment #143 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28930
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28930action=edit
Bug 10855: Add unit tests for the new package Koha::AdditionalField

Test plan:
- prove t/db_dependent/AdditionalField.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #23598|0   |1
is obsolete||

--- Comment #146 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28933
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28933action=edit
Bug 10855: Search subscriptions by additional fields

Now you will abble to search subscriptions by additional fields.
The additional field values will be displayed in the table results.

Test plan:
- go on the subscriptions advanced search page
  (serials/serials-search.pl).
- verify all searchable additional fields are displayed on the form.
- combine 1 or more values and verify results are consistent.
- verify the values are displayed in new columns of the table.
- for field linked to an authorised value category, the description is
  displayed (not the code).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #26255|0   |1
is obsolete||

--- Comment #148 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28935
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28935action=edit
Bug 10855: Squash several fixes

Bug 10855: FIX: Add additional fields for closed subscriptions

Bug 10855: Fix instance vs static method

This patch fixes the error message.
The 3 modified routines *are* static methods.

Bug 10855: FIX conflicts with bug 7688

Bug 10855: Fix typo addition_fields - additional_fields

Bug 10855: A partial search should return the subscriptions

If a search on an additional fields is done using a partial string
(foo and the defined value is foobar), the subscription should
appear in the result list.

Test plan:
Try to search a part of the string for an additional field.

Bug 10855: Filtering on additional fields don't work if value is equal to 0

If you tried to filter on an additional field linked to an authorised
value, that did not work if the value was 0.

Bug 10855: Remove the advanced serial search box on the serial home page

Bug 10855: FIX an add field should not be created if the marc field does not
exist.

This patch fixes the following:
Create an add fields linked to a nonexistent marc field (does not exist
in serials).
Edit a subscription and save.
Without this patch, an error occured:
Software error:
DBD::mysql::db do failed: Column 'value' cannot be null at
/var/root-koha/bug-10855/Koha/AdditionalField.pm line 107.

Bug 10855: Fix Type table vs tablename

Koha::AdditionalField-all method take tablename not table in
parameter.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #26655|0   |1
is obsolete||

--- Comment #154 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28941
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28941action=edit
Bug 10855: Additional marc fields are not inserted

In subscription-add.pl, the code for inserting additional_fields is not
the same for updating and inserting.
This patch refactores this code in code to do the same tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #26651|0   |1
is obsolete||

--- Comment #153 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28940
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28940action=edit
Bug 10855: FIX encoding issues.

This commit should be reverted when bug 11944 (or replacement) will be
fixed. One day, maybe.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #23594|0   |1
is obsolete||

--- Comment #142 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28929
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28929action=edit
Bug 10855: Add the new package Koha::AdditionalField

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha.

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||k...@univ-lyon3.fr

--- Comment #4 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
h1Something went wrong !/h1Applying: Use HTTPS Amazon images when Koha is
using HTTPS.
Using index info to reconstruct a base tree...
stdin:67: trailing whitespace.
if ((this.src.indexOf('images.amazon.com') = 0) ||
(this.src.indexOf('g-images.amazon.com') =0) 
stdin:68: trailing whitespace.
|| (this.src.indexOf('syndetics.com') =0) ||
(this.src.indexOf('images-na.ssl-images-amazon.com') = 0)) { 
stdin:227: trailing whitespace.
if ((this.src.indexOf('images.amazon.com') = 0) ||
(this.src.indexOf('g-images.amazon.com') =0) 
stdin:228: trailing whitespace.
|| (this.src.indexOf('syndetics.com') =0) ||
(this.src.indexOf('images-na.ssl-images-amazon.com') = 0)) { 
stdin:253: trailing whitespace.
if ((this.src.indexOf('images.amazon.com') = 0) ||
(this.src.indexOf('g-images.amazon.com') =0) 
warning: squelched 3 whitespace errors
warning: 8 lines add whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-opensearch.tt
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-readingrecord.tt
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/prog/en/modules/opac-readingrecord.tt
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tt
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt
 .

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #26254|0   |1
is obsolete||

--- Comment #147 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28934
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28934action=edit
Bug 10855: Search subscriptions by additional fields on the claim page

Test plan:
- create some serials in late.
- go on serials/claims.pl.
- choose a vendor.
- verify that additional fields are displayed in new columns.
- try filters on columns.
- verify there is no regression on this page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #23596|0   |1
is obsolete||

--- Comment #144 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28931
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28931action=edit
Bug 10855: interface configuration for adding new fields to subscriptions

This patch adds an interface configuration for adding fields to
subscriptions.

Test plan:
- go to serials/serials-home.pl
- click on the Add subscription fields link on the left of the screen
- try to add/update/delete new fields
You are not abble to add a field with an authorised value category and a
marcfield. Columns are sortable
- for the rest, you should have, at least:
  * a new field named af1, sortable, linked to a category
  * a new field named af2, sortable, linked to a marcfield
  * a new field named af3, not sortable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #26257|0   |1
is obsolete||

--- Comment #150 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28937
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28937action=edit
Bug 10855: FIX bad conflict merge

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #26259|0   |1
is obsolete||

--- Comment #151 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28938
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28938action=edit
Bug 10855: Update database entry

Add 2 tables: additional_fields and additional_field_values

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #23597|0   |1
is obsolete||

--- Comment #145 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28932
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28932action=edit
Bug 10855: New fields on adding/updating a subscription

This patch adds the ability to add values for additional fields when
adding/updating a subscription.

Test plan (test the following on adding a new subscription and on
editing an existent one):
- add/edit a subscription.
- verify all additional fields appears into the Additional fields
  block.
- fill a value for af1 and af3.
- fill others values if you are adding a new subscription.
- save.
- verify values appears on the detail of the subscription page.
- verify the af2 field is automatically filled with the specified
  marc field of the notice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #155 from Jonathan Druart jonathan.dru...@biblibre.com ---
All patches rebased. Conflicts on serials/claims.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||k...@univ-lyon3.fr

--- Comment #19 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Some problems occurred applying patches from bug 8995:
h1Something went wrong !/h1Applying: Bug 8995: Show OpenURL links in OPAC
search results Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging C4/Biblio.pm
Auto-merging C4/XSLT.pm
CONFLICT (content): Merge conflict in C4/XSLT.pm Auto-merging
installer/data/mysql/sysprefs.sql Auto-merging
installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
Auto-merging koha-tmpl/opac-tmpl/prog/en/css/opac.css
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
Auto-merging koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl
Auto-merging koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl
Auto-merging opac/opac-detail.pl
CONFLICT (content): Merge conflict in opac/opac-detail.pl Auto-merging
opac/opac-search.pl Failed to merge in the changes.
Patch failed at 0001 Bug 8995: Show OpenURL links in OPAC search results When
you have

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12409] The test t/db_dependent/Record.t fails with Perl 5.18.2

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12409

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12296] OPAC search box should be customisable

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12296

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12419

--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
This looks similar than bug 12419 (but not the same view).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12296] OPAC search box should be customisable

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12296

--- Comment #12 from Owen Leonard oleon...@myacpl.org ---
Created attachment 28942
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28942action=edit
[SIGNED-OFF] Bug 12296 - make search box customisable with OpacCustomSearch

This allows the search box to be replaced by some custom HTML, useful
when you're needing to integrate with some other search system, and
don't want to maintain a template change across upgrades.

Test plan:
* Install patch
* Look at the OPAC, see that nothing has changed.
* Change the OpacCustomSearch syspref to something like h1Zuul/h1
* Look at the OPAC again, you can no longer search, there is only Zuul.

Note:
* should work on both prog and bootstrap

Signed-off-by: Owen Leonard oleon...@myacpl.org

Works as advertised. Seems like it would be really easy to screw up your
OPAC with this feature, but since we already offer other easy ways to
screw up your OPAC I guess this fits in.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12419] Not for loan items are not listed

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12419

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12307

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #26256|0   |1
is obsolete||

--- Comment #149 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28936
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28936action=edit
Bug 10855: Fix QA issues

This patch fixes the following QA issues:

FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
  FAIL   forbidden patterns
   forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug
10626) (line 2)

FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
  FAIL   forbidden patterns
   forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug
10626) (line 2)

FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt
  FAIL   forbidden patterns
   forbidden pattern: To include datatables files, please use the include
file (see bug 10868) (line 12)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #26276|0   |1
is obsolete||

--- Comment #152 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28939
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28939action=edit
Bug 10855: search with exact match if linked to an AV

If a field is linked to an AV, the search should be an exact match.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307

Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #99 from Owen Leonard oleon...@myacpl.org ---
In my opinion this would be a good time to get a single squashed patch to
re-test and get a fresh signoff. With so many follow-ups I find it hard to
track what really needs to be tested.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12395] Save order line's creator

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #9 from Paola Rossi paola.ro...@cineca.it ---
(In reply to Julian Maurice from comment #8)
 Hi Paola,
 
 have you created the order line being logged in with a real user (not the
 mysql user) ? Does this user have a firstname and a surname ?

Thanks, Julian.

Today I've applied against master 3.17.00.008.

I've added surname, first name, aso to my test-user, the creator of the orders.

Now everything's OK.

So I pass the patch to Signed Off status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12395] Save order line's creator

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

  Attachment #28754|0   |1
is obsolete||

--- Comment #10 from Paola Rossi paola.ro...@cineca.it ---
Created attachment 28943
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28943action=edit
Bug 12395: Save order line's creator

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12439] Apache 2.4 may not have the CGI module enabled by default, and we need it.

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12439

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #3 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Robin!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12446] New: Enable an adult to have a guarantor

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Bug ID: 12446
   Summary: Enable an adult to have a guarantor
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: simith.dolive...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Our sponsor require an adjustment to allow an adult to have a guarantor and
some other modifications concerning. This Fix:

- Enable an adult to have a guarantor;
- Shows guarantees fines in the guarantor's page;
- Transfer some guarantor's information to the guarantee while creating;
- Transfer guarantor's alternate contact to the guarantee while creating.  

Sponsor by: ville de victoriaville

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12261] Staff client next/previous links lead to unknown record

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12261

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12261] Staff client next/previous links lead to unknown record

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12261

--- Comment #9 from Owen Leonard oleon...@myacpl.org ---
Created attachment 28944
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28944action=edit
[SIGNED-OFF] Bug 12261: Staff client next/previous links lead to unknown record

When using Staff client next/previous links after a search :
If the current record is the last of the results, clicking on next
will lead to the page of an unknown record with message :

The record you requested does not exist (NaN).

To test:
1) Do an intranet catalog search that has more than 1 results.
2) Click on the last search result and then click the Next-button from
   the top-left navigation.
3) Confirm that you get thrown to a page with the message: The record
   you requested does not exist (NaN)..
4) Apply patch.
5) Repeat steps 1 - 2.
6) Confirm that the navigation button for Next is greyed out.

Signed-off-by: Owen Leonard oleon...@myacpl.org

This patch fixes the problem with last result in both single pages of
search results and multiple pages of search results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12406] Adding a column maxsuspensiondays in the table issuingrules breaks the UT t/db_dependent/Circulation_Issuingrule.t

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12406

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12406] Adding a column maxsuspensiondays in the table issuingrules breaks the UT t/db_dependent/Circulation_Issuingrule.t

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12406

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28945
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28945action=edit
Bug 12406: adding the column maxsuspensiondays in the tests

The column maxsuspensiondays was added in the datatable but not in the tests,
which caused the failure of the tests

test plan: execute prove t/db_dependent/Circulation_Issuingrule.t
The command has to print:
t/db_dependent/Circulation_Issuingrule.t .. ok
All tests successful.
Files=1, Tests=9,  2 wallclock secs ( 0.03 usr  0.01 sys +  1.35 cusr  0.08
csys =  1.47 CPU)
Result: PASS

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Failure on test before patch, success after
No koha-qa errors

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||k...@univ-lyon3.fr

--- Comment #58 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
h1Something went wrong !/h1Applying: Bug 8296: Add descriptive (text)
published date field for serials Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging C4/Serials.pm
CONFLICT (content): Merge conflict in C4/Serials.pm Auto-merging
installer/data/mysql/kohastructure.sql
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-full-serial-issues.tt
Auto-merging misc/cronjobs/serialsUpdate.pl Auto-merging
serials/serials-collection.pl Failed to merge in the changes.
Patch failed at 0001 Bug 8296: Add descriptive (text) published date field for
serials When you have resolved this problem run git bz apply --continue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12406] Adding a column maxsuspensiondays in the table issuingrules breaks the UT t/db_dependent/Circulation_Issuingrule.t

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12406

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #28787|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||k...@univ-lyon3.fr

--- Comment #29 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
h1Something went wrong !/h1Applying: Bug 7677: UT: add unit tests for
GetPreviousSerialid Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Serials_2.t
Applying: BZ7677: New areas in subscriptions and new functions when receiving.
Using index info to reconstruct a base tree...
stdin:49: trailing whitespace.
ORDER BY serialid DESC LIMIT ,1
stdin:97: trailing whitespace.
, , , , ,
stdin:198: trailing whitespace.
  choices: 
warning: 3 lines add whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging C4/Serials.pm
Auto-merging installer/data/mysql/kohastructure.sql
Auto-merging installer/data/mysql/sysprefs.sql Auto-merging
installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
Auto-merging serials/subscription-add.pl Failed to merge in the changes.
Patch failed at 0001 BZ7677: New areas in subscriptions and new functions when
receiving.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5672] Search History Should have RSS Feeds

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |viktor.sarge@regionhalland.
   ||se

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5672] Search History Should have RSS Feeds

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m, oleon...@myacpl.org

--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
All looks good. But one icon in a cell does not seem very elegant.

Maybe Owen has a brainwave?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12434] Typos in help files

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12434

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #28914|0   |1
is obsolete||
 CC||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12434] Typos in help files

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12434

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12332] pay.pl and purchase-suggestions.pl tabs do not show selected

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||9261

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||12332

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12332] pay.pl and purchase-suggestions.pl tabs do not show selected

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12332] pay.pl and purchase-suggestions.pl tabs do not show selected

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #28920|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28947
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28947action=edit
Bug 12332: Fix for tab Purchase suggestions not lighting up

This patch changes the file purchase-suggestions.pl with suggestionsview = 1
for the template parameter.
In circ-menu.inc i changed the condition from suggestions to
suggestionsview since it seemed to conflict with the existing variable
suggestions (and in that case only highlighting the tab when there were
suggestions).

Please note that I fixed the troubles with the tab Fines in a separate patch
9245.

Test plan:
1) Verify that Purchase suggestions does not light up as it should when
clicked.
2) Install the patch.
3) Verify that the tab Purchase suggestions now actually light up when
clicked.

Signed-off-by: Christopher Brannon cbran...@cdalibrary.org

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12434] Typos in help files

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12434

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28946
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28946action=edit
Bug 12434: Fix Typo in Smart Rules Help

This patch fixes a typos in the help file on the circ and
fine rules.

To test:

Visit admin  circ and fine rules
Click help in the top right
Confirm that period is not spelled peiod

Signed-off-by: David Cook dc...@prosentient.com.au

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12332] purchase-suggestions.pl tabs do not show selected

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

Summary|pay.pl and  |purchase-suggestions.pl
   |purchase-suggestions.pl |tabs do not show selected
   |tabs do not show selected   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12447] New: pay.pl tabs do not show selected

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12447

Bug ID: 12447
   Summary: pay.pl tabs do not show selected
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

If you go into a patron account and click on the fines tabs, it does not show
that this tab is selected, like all the other tabs do.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12447] pay.pl tabs do not show selected

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12447

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Severity|major   |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12332] purchase-suggestions.pl tabs do not show selected

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332

--- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com ---
Bug 12447 created for the pay.pl (Fines) tab.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12332] purchase-suggestions.pl tabs do not show selected

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12447

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12447] pay.pl tabs do not show selected

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12447

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12332

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9230] selectively delete reading history

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9230

Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12447] pay.pl tabs do not show selected

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12447

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 28948
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28948action=edit
Bug 12447: Fines tabs do not show selected

When you are on pay.pl, maninvoite.pl and mancredit.pl, the Fines tab
should be selected.

Test plan:
Go on these 3 pages and verify the Fines tabs is correctly selected

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12447] pay.pl tabs do not show selected

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12447

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12447] Fines tabs do not show selected

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12447

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

Summary|pay.pl tabs do not show |Fines tabs do not show
   |selected|selected

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12447] Fines tabs do not show selected

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12447

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5342] Serial claiming improvements

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||k...@univ-lyon3.fr

--- Comment #63 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
h1Something went wrong !/h1Applying: Bug 5342: Adds a claims_count field in
the serial table Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging C4/Serials.pm
CONFLICT (content): Merge conflict in C4/Serials.pm Auto-merging
installer/data/mysql/kohastructure.sql
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
Auto-merging serials/claims.pl
CONFLICT (content): Merge conflict in serials/claims.pl Failed to merge in the
changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7817] Items Permanent location (shelving location) is set to NULL when item is edited

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7817

--- Comment #7 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 28949
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28949action=edit
Bug 7817 - Items Permanent location (shelving location) is set to NULL when
item is edited

A quick fix to prevent more damages.
No perceived side-effects so far.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11395] Batch modifications for records

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||k...@univ-lyon3.fr

--- Comment #17 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
h1Something went wrong !/h1Applying: Bug 11395: Add a batch record
modification
Applying: Bug 11395: Add links to the new tool page
Applying: Bug 11395: Fix return for ModifyRecordWithTemplate
Applying: Bug 11395: New service to preview a record.
Applying: Bug 11395: DB: Add permission tools_records_batchmod Using index info
to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging installer/data/mysql/de-DE/mandatory/userpermissions.sql
Auto-merging installer/data/mysql/en/mandatory/userpermissions.sql
Auto-merging installer/data/mysql/es-ES/mandatory/userpermissions.sql
Auto-merging installer/data/mysql/fr-FR/1-Obligatoire/userpermissions.sql
Auto-merging installer/data/mysql/it-IT/necessari/userpermissions.sql
CONFLICT (content): Merge conflict in
installer/data/mysql/it-IT/necessari/userpermissions.sql
Auto-merging installer/data/mysql/nb-NO/1-Obligatorisk/userpermissions.sql
Auto-merging installer/data/mysql/pl-PL/mandatory/userpermissions.sql
Auto-merging
installer/data/mysql/ru-RU/mandatory/permissions_and_user_flags.sql
Auto-merging
installer/data/mysql/uk-UA/mandatory/permissions_and_user_flags.sql
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 11395: DB: Add permission tools_records_batchmod When
you have resolved this problem run git bz apply --continue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12409] The test t/db_dependent/Record.t fails with Perl 5.18.2

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12409

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
But I really don't matter :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11806] Use validation plugin when creating new OAI set

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11806

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||fridolyn.som...@biblibre.co
   ||m

--- Comment #5 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Pushed to 3.14.x, will be in 3.14.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >