[Koha-bugs] [Bug 12668] Stray dollar ($) -sign in opac-reserve.pl

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12668

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 30372
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30372action=edit
[PASSED QA] Bug 12668 - Stray dollar ($) -sign in opac-reserve.pl

A dollar sign is hard-coded in opac-reserve.pl and becomes apparent when trying
to place a reservation
 when one has too_much_oweing or too much fines.

Removing the dollar sign so we just get

Käyttömaksujen katto ylitetty. Et voi tehdä varauksia. Sinulla on
maksamattomia maksuja 9.50.

instead of

Käyttömaksujen katto ylitetty. Et voi tehdä varauksia. Sinulla on
maksamattomia maksuja $9.50.

Patch removes hard coded $ sign.
Signed-off-by: Marc Véron ve...@veron.ch

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
The dollar sign is gone and the message still displays correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12668] Stray dollar ($) -sign in opac-reserve.pl

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12668

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #30361|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12668] Stray dollar ($) -sign in opac-reserve.pl

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12668

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12027] Shibboleth authentication for staff client

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027

--- Comment #1 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 30373
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30373action=edit
BUG 12027: Added shibboleth authentication to the staff client

- This patch adds shibboleth authentication to the staff client.
- Depending upon how your url structure works, you may or may not need a
  second native shibboleth service provider profile configured for this
  to work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12027] Shibboleth authentication for staff client

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #30373|0   |1
is obsolete||

--- Comment #2 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 30374
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30374action=edit
BUG 12027: Added shibboleth authentication to the staff client

- This patch adds shibboleth authentication to the staff client.
- Depending upon how your url structure works, you may or may not need a
  second native shibboleth service provider profile configured for this
  to work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12027] Shibboleth authentication for staff client

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12027] Shibboleth authentication for staff client

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #30374|0   |1
is obsolete||

--- Comment #3 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 30375
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30375action=edit
BUG 12027: Added shibboleth authentication to the staff client

- This patch adds shibboleth authentication to the staff client.
- Depending upon how your url structure works, you may or may not need a
  second native shibboleth service provider profile configured for this
  to work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #30352|0   |1
is obsolete||

--- Comment #7 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 30376
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30376action=edit
BUG 12026, Follow up: Added Documentation

BUG 12026, Follow up: Updated to work with match point selection

- The base bug that this patch enhances has added the ability to choose
  your match point in the configuration file. This patch adds code to
  take that change into account.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12027] Shibboleth authentication for staff client

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #30375|0   |1
is obsolete||

--- Comment #4 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 30377
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30377action=edit
BUG 12027: Added shibboleth authentication to the staff client

- This patch adds shibboleth authentication to the staff client.
- Depending upon how your url structure works, you may or may not need a
  second native shibboleth service provider profile configured for this
  to work.

http://bugs.koha-community.org/show_bug.cgi?id=12026

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12680] New: Shibboleth adaptive config

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12680

Bug ID: 12680
   Summary: Shibboleth adaptive config
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Authentication
  Assignee: gmcha...@gmail.com
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

I wish to enhance the shibboleth system such that you can adapt the config used
depending upon some attribute returned from the identity provider.

Use case: Given an academic institution, such a place may have rather differing
information on record for students as opposed to staff.  I've had instances
where the mapping between attributes and koha fields has differed wildly
between these two groups. Given the there is probably an attribute that can
differentiate between the two, then we should be able to use that to load a set
of mapping specific to that usergroup.

Example intended implementation.

usesshibboleth1/usesshiboleth
shibboleth selector=affiliation value=student
  matchpointuseridmatchpoint
  mapping
userid is=uid/userid
  /mapping
/shibboleth
shibboleth selector=affiliation value=staff
  matchpointcardnumbermatchpoint
  mapping
cardnumber is=libraryID/cardnumber
  /mapping
/shibboleth

So, in the above example config, the intention would be for koha to look for an
'affiliation' attribute first and foremost, and then depending upon it's value
(student or staff) load the corresponding configuration and continue as per
normal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12680] Shibboleth adaptive config

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12680

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 Depends on||8446

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 Blocks||12680

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12027] Shibboleth authentication for staff client

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12680

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12680

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12680] Shibboleth adaptive config

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12680

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12026,
   ||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12027

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12681] Shibboleth attributes may contain lists

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12681

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 Depends on||8446

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12681] New: Shibboleth attributes may contain lists

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12681

Bug ID: 12681
   Summary: Shibboleth attributes may contain lists
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Authentication
  Assignee: gmcha...@gmail.com
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

In koha, a shibboleth attribute is always assumed to be a singular value;
however an attribute may actually contain a semi-colon separated list of values
in a string.

We should handle this in koha somehow.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 Blocks||12681

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12682] New: Shibboleth attribute manipulation

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12682

Bug ID: 12682
   Summary: Shibboleth attribute manipulation
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Authentication
  Assignee: gmcha...@gmail.com
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

As koha administrators, we are often not in control of the form in which we
will receive an attribute from a shibboleth identity provider.

This envisaged enhancement would add the ability to define very simple string
manipulations to an attribute in the koha config file.

Example of enhanced config:

usesshibboleth1/usesshibboleth
shibboleth
  matchpointuserid/matchpoint
  mapping
userid is=email regex=s/@student.university.ac.uk//g/userid
  /mapping
/shibboleth

In the above example, we want to match koha userid to the 'stuff before the @'
in the users email attribute.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12682] Shibboleth attribute manipulation

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12682

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 Depends on||8446

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 Blocks||12682

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12398] CAS authentication not working

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398

--- Comment #21 from Julian Maurice julian.maur...@biblibre.com ---
This is due to C4::Context-preference being called in C4::Auth_with_cas
outside of any functions (it gets called on use).
Rather than writing a workaround for this, I will move the test in
t/db_dependent.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12398] CAS authentication not working

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #30334|0   |1
is obsolete||

--- Comment #22 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 30378
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30378action=edit
Bug 12398: Move t/Auth_with_cas.t to t/db_dependent/Auth_with_cas.t

This patch obsoletes the previous one with mocks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12398] CAS authentication not working

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #28974|0   |1
is obsolete||

--- Comment #64 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 30379
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30379action=edit
Bug 8296: Add descriptive (text) published date field for serials

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #28976|0   |1
is obsolete||

--- Comment #66 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 30381
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30381action=edit
Bug 8296: Follow up for QA

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #28975|0   |1
is obsolete||

--- Comment #65 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 30380
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30380action=edit
Bug 8296: set input maxlength to the same of sql field length

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #28977|0   |1
is obsolete||

--- Comment #67 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 30382
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30382action=edit
Bug 8296: Don't fill text field automatically

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #68 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 30383
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30383action=edit
Bug 8296: Display publisheddatetext in OPAC bootstrap theme

and remove modifications for OPAC prog theme

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #83 from Paola Rossi paola.ro...@cineca.it ---
Today I've tried to apply against 3.17.00.011

Applying: Bug 10402: Use an object for contacts
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging acqui/supplier.pl

So I pass the patch to Patch doesn't apply status

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

--- Comment #75 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Tested ok.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

  Attachment #30356|0   |1
is obsolete||

--- Comment #76 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Created attachment 30384
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30384action=edit
BUG8446, Follow up: Improve local login fallback

Signed-off patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

--- Comment #77 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Matthias, can you add your sign off line to the other patches too please?
And thx for signing off!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #29358|0   |1
is obsolete||

--- Comment #28 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 30386
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30386action=edit
Bug 8995: Use uri_escape_utf8 instead of uri_escape

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #29357|0   |1
is obsolete||

--- Comment #27 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 30385
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30385action=edit
Bug 8995: Show OpenURL links in OPAC search results

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #29359|0   |1
is obsolete||

--- Comment #29 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 30387
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30387action=edit
Bug 8995: Show OpenURL links in bootstrap theme

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #30 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 30388
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30388action=edit
Bug 8995: Add OpenURL link to OPAC bootstrap XSLT files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #31 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 30389
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30389action=edit
Bug 8995: Change meaning and name of syspref OPACHideOpenURLForItemTypes

OPACHideOpenURLForItemTypes is now named OPACOpenURLItemTypes and do the
exact opposite as before: it shows OpenURL link only if the biblio
itemtype is in the syspref.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #33 from Julian Maurice julian.maur...@biblibre.com ---
 It is possible to open the link in a new tab (I activate the syspref
 OPACOpenInNewWindow, but there is no difference)

I wasn't aware of OpacOpenInNewWindow syspref, I will take a look to see what I
can do.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #32 from Julian Maurice julian.maur...@biblibre.com ---
(In reply to Koha Team Lyon 3 from comment #25)
 I'm disappointed, because I made a lot of tests and everything is OK except
 I can't see the openurl link when I Set sysprefs OPACXSLTDetailsDisplay and
 OPACXSLTResultsDisplay to default.
 It works very well when this sysprefs are empty (tested with two different
 open resolvers with electronic journals and ebooks.)

Fixed by attachment 30388

 Two more remarks :
 I agree with  David Cook (Comment 18)  : we usually use open url for 2 item
 types, it would be easier to list only those two and not all the others.

Fixed by attachment 30389

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #34 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 30390
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30390action=edit
Bug 8995: Consider OPACURLOpenInNewWindow for OpenURL links

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11319] Marc modification templates improvements

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #35 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA Comment: 
In general these patches look good to me. I have the impression that this
feature still needs some work however.
Here are some comments to start with:

[1] The last patch (template mods) adds the restriction: A move/copy/update
should have a subfield. If I want to update control field 003 to some text, it
should be possible. There is no subfield. (Blocker.) 
It also says: move/copy source and dest should have either a subfield or not. I
agree that it is normal behavior. But suppose that I want to copy some field to
a controlfield? This is somewhat unlikely, but it would not be wrong. (No
blocker since I do not have a real application for it at hand.) 

[2] Some code in the third patch for update_field: 
+if ( not $subfieldName or $subfieldName eq '' ) {
+# FIXME I'm not sure the actual implementation is correct.
+die This action is not implemented yet;
+#_update_field({ record = $record, field = $fieldName, values =
\@values });
This actually is the situation I was referring to (I want to update a control
field without subfield).
At this moment you are blocking an update without subfield in the interface.
This makes it hard to reach this die statement..

[3] Just looking at some code in SimpleMarc.pm, I notice the following:
field_equals just picks the first field value and runs the regex. If I do not
pass a subfield, it does not run the regex over the whole field just one
subfield. If I pass a subfield and the record contains repeated subfields, it
just checks the first one. This is not the behavior that I would (intuitively)
expect from the interface. Note that your patch does not really touch that part
of code, but you do touch the routine. Is improving that functionality not even
more important than passing a hashref? 

[4] BTW See some warnings in the log:
[Wed Jul 30 16:37:51 2014] stage-marc-import.pl: Filehandle STDOUT reopened as
FH only for input at Template/Provider.pm line 964., referer:
/cgi-bin/koha/tools/stage-marc-import.pl
[Wed Jul 30 16:37:51 2014] stage-marc-import.pl: Filehandle STDOUT reopened as
FH only for input at Template/Provider.pm line 964., referer:
/cgi-bin/koha/tools/stage-marc-import.pl
[Wed Jul 30 16:53:18 2014] marc_modification_templates.pl: Use of uninitialized
value in string eq at tools/marc_modification_templates.pl line 70., referer:
/cgi-bin/koha/tools/marc_modification_templates.pl?template_id=3op=delete_actionmmta_id=8
[Wed Jul 30 16:53:31 2014] marc_modification_templates.pl: Use of uninitialized
value $template_id in string eq at C4/MarcModificationTemplates.pm line 84.,
referer: /cgi-bin/koha/tools/marc_modification_templates.pl

Setting status to Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12465] XSLT: Missing punctuation between 710$a and $b

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

--- Comment #6 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA: Taking a look :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12465] XSLT: Missing punctuation between 710$a and $b

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465

--- Comment #7 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 30391
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30391action=edit
Bug 12465: Improve display of MARC21 710 in intranet and OPAC

Currently, 710$a and $b and $b will not display correctly.
This patch tries to improve the display adding the missing
space between both subfields.

Please test.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Tested, work as described on staff  opac for 710 detailed view.
Add space and punctuation.
No errors.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12465] XSLT: Missing punctuation between 710$a and $b

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465

--- Comment #8 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA Comment:
This patch improves the situation. Before $a and $b were glued together. Now we
have a space in between everywhere for subfields a-b-c-d-n. 
I am not saying that we already reached the ideal solution. Just listing
multiple $b's after $a with a space (and even more subfields possible) may
probably not always be so clear. But I do not have the better solution at
hand for this moment :)

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12465] XSLT: Missing punctuation between 710$a and $b

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12465] XSLT: Missing punctuation between 710$a and $b

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465

--- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Thx Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9180] Default rules are not always used for overdues

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 QA Contact||m.de.r...@rijksmuseum.nl

--- Comment #26 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA: Taking a look

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9180] Default rules are not always used for overdues

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Patch complexity|Trivial patch   |Small patch

--- Comment #27 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Changing complexity: Changing a routine in a module (Overdues) is generally not
considered trivial.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9180] Default rules are not always used for overdues

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9180] Default rules are not always used for overdues

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #29548|0   |1
is obsolete||

--- Comment #28 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 30392
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30392action=edit
Bug 9180: All branches should be returned if a default rule exists

The C4::Overdues::GetBranchcodesWithOverdueRules routine has a bug.
If a default rule *and* a specific rule exist, only the branchcode for
the specific rule is returned.

Test plan:
prove t/db_dependent/Overdues.t
and verify the unit tests are consistent.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687

simith.dolive...@inlibro.com changed:

   What|Removed |Added

 CC||simith.dolive...@inlibro.co
   ||m
   Assignee|fcapovi...@live.ca  |simith.dolive...@inlibro.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #84 from Jared Camins-Esakov jcam...@cpbibliography.com ---
(In reply to Paola Rossi from comment #83)
 Today I've tried to apply against 3.17.00.011
 
 Applying: Bug 10402: Use an object for contacts
 Using index info to reconstruct a base tree...
 Falling back to patching base and 3-way merge...
 Auto-merging acqui/supplier.pl
 
 So I pass the patch to Patch doesn't apply status

This message doesn't mean that the patch doesn't apply. It's just telling you
that there were other changes made to acqui/supplier.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12407] phone label or data switched

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407

--- Comment #8 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 30393
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30393action=edit
Bug 12407 - phone label or data switched

Fix for switched phone numbers on patron details page.

This patch fixes switched phone numbers on patron details page and also makes
phone number labels more uniform.

To Test:

1. Apply the patch.
2. Create/modify a patron entering some unique data into the Secondary phone:
and Other phone: fields (different data for each).
3. Save the patron record.
4. Go to the patrons details page and make sure the data entered into the
Secondary phone: field is displaying next to the Secondary phone: label and
that the data entered into the Other phone: field is displaying next to the
Other phone: label.

Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com
Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12407] phone label or data switched

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12407] phone label or data switched

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407

--- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 30394
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30394action=edit
Bug 12407: [QA Follow-up] Rename Other Phone to Mobile in staff

Touches three member templates.
Changes label Other into Mobile.
This is consistent with database field name and OPAC.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12407] phone label or data switched

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA Comment:
Looks good to me. 
With reference to bug 8760, I added a QA follow-up to rename Other to Mobile in
three member templates.

Also note that the field names in the database such as phonepro for secondary
phone do not make it easier.
Will put a note on the other report too.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8760] Phone number Field tags are reversed in patron record

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 CC||m.de.r...@rijksmuseum.nl
 Resolution|--- |DUPLICATE

--- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl ---


*** This bug has been marked as a duplicate of bug 12407 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12407] phone label or data switched

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||je...@bywatersolutions.com

--- Comment #11 from M. de Rooy m.de.r...@rijksmuseum.nl ---
*** Bug 8760 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12407] phone label or data switched

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #28904|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735

--- Comment #43 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 30398
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30398action=edit
Bug 8735 [QA Followup 2] - Remove extra period, add bug number to db update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735

--- Comment #41 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 30396
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30396action=edit
Bug 8735 - Expire holds waiting only on days the library is open - Followup -
Switch from C4::Calendar to Koha::Calendar

Test Plan:
 1) Set ExpireReservesMaxPickUpDelay
 2) Set ReservesMaxPickUpDelay to 1
 3) Place a hold, set it to waiting
 4) Using the MySQL console, modify the waiting date and set it to the
day before yesterday.
 5) Set today as a holiday for the pickup branch in question.
 6) Run misc/cronjobs/holds/cancel_expired_holds.pl
 7) The hold should remain unchanged
 8) Remove today as a holiday
 9) Run misc/cronjobs/holds/cancel_expired_holds.pl again
10) The hold should now be canceled

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #28660|0   |1
is obsolete||
  Attachment #28661|0   |1
is obsolete||
  Attachment #28662|0   |1
is obsolete||
  Attachment #28663|0   |1
is obsolete||

--- Comment #40 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 30395
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30395action=edit
Bug 8735 - Expire holds waiting only on days the library is open

Signed-off-by: Leila koha.aixmarsei...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735

--- Comment #42 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 30397
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30397action=edit
Bug 8735 [QA Followup] - Add Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

Version|3.14|master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 QA Contact||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735

--- Comment #44 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Trivial rebase.
Will take a look now for QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6113] enhancement to keep previous ids

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Status|In Discussion   |Patch doesn't apply

--- Comment #27 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
This patch just created an issue for us in conjunction with Bug 12624.

It was very useful in our initial migration but after that it will be
worthless.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6113] enhancement to keep previous ids

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113

--- Comment #28 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
BTW the issue was existing biblios getting overwritten by new records from
staging tables.

So if C4::Biblio::_koha_add_biblio() returns an error, the rest of the
instructions are carried out normally, eg. ModBiblio, which overwrites the
existing marc record even if the adding new record to a reserved biblionumber
just failed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735

--- Comment #48 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 30402
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30402action=edit
Bug 8735 [QA Followup 2] - Remove extra period, add bug number to db update

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735

--- Comment #47 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 30401
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30401action=edit
Bug 8735 [QA Followup] - Add Unit Tests

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #30395|0   |1
is obsolete||
  Attachment #30396|0   |1
is obsolete||
  Attachment #30397|0   |1
is obsolete||
  Attachment #30398|0   |1
is obsolete||

--- Comment #45 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 30399
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30399action=edit
Bug 8735 - Expire holds waiting only on days the library is open

Signed-off-by: Leila koha.aixmarsei...@gmail.com

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735

--- Comment #46 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 30400
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30400action=edit
Bug 8735 - Expire holds waiting only on days the library is open - Followup -
Switch from C4::Calendar to Koha::Calendar

Test Plan:
 1) Set ExpireReservesMaxPickUpDelay
 2) Set ReservesMaxPickUpDelay to 1
 3) Place a hold, set it to waiting
 4) Using the MySQL console, modify the waiting date and set it to the
day before yesterday.
 5) Set today as a holiday for the pickup branch in question.
 6) Run misc/cronjobs/holds/cancel_expired_holds.pl
 7) The hold should remain unchanged
 8) Remove today as a holiday
 9) Run misc/cronjobs/holds/cancel_expired_holds.pl again
10) The hold should now be canceled

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687

simith.dolive...@inlibro.com changed:

   What|Removed |Added

 CC||eric.be...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687

simith.dolive...@inlibro.com changed:

   What|Removed |Added

 CC||francois.charbonnier@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687

simith.dolive...@inlibro.com changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687

simith.dolive...@inlibro.com changed:

   What|Removed |Added

  Attachment #23229|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687

simith.dolive...@inlibro.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687

--- Comment #23 from simith.dolive...@inlibro.com ---
Created attachment 30403
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30403action=edit
Bug 8687 - Improvements in overdue_notices.pl

Improvements in the overdue_notices.pl script

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #29870|0   |1
is obsolete||

--- Comment #73 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 30404
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30404action=edit
Bug 766: Remove CGI::scrolling_list from aqplan.pl

This patch removes 3 occurences on aqplan.pl

To test:
1. You need a budget and a found
2. Apply the patch
3. Go to Aquisitions, click on your found
4. Select one of the options on pulldown Planning
e.g. Plan by months
5. Now to the left there are two boxes, Filter and Export

a) Filter: (1) pulldown below 'Select planning type'
check that works selecting other values and submit
This pulldown showed originally code types,
untranslatable BTW. Added a TT block to allow translation
and shows legends that match Planning pulldown, but not
the order.

b) Export: pulldowns for filetype (2) and delimiter (3)
Those have originally one value each, and for me Export
does not work, before or after patch, but check that
pulldown exist.

Notes:
A) 5.a) I can change de order of main Planning pulldown,
is harcoded. The values for Filter pulldown are sorted on
aqplan.pl. Is one or the other.
If desired, TT block can be moved to includes/budgets-admin-toolbar.inc
(where hardcoded Planning lives)

B) 5.b) Moved 'Export' legend inside it's box, like Filter.

C) Finally: there is something strange, before or after patch.
There is an empty option 'Planning by  if you select planning
using main pulldown, it disappears if you select planning using
Filter (not a mistery, using Planning fills $auth_cats_loop,
using Filter submit button does not)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #29872|0   |1
is obsolete||

--- Comment #74 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 30405
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30405action=edit
Bug 766: Remove CGI::scrollinglist from authorised_values.pl

This patch removes the only instance in this file.
Also fixes array sorting, removes some tabs, removes
an unneeded $dbh handler (there is a global one).
Makes use of C4::Koha::GetAuthorisedValueCategories.

To test:
1. Apply the patch
2. Go to Administration  Authorised values
3. Replaced pulldown next to 'Show category' must
show all (present  system) categories correctly ordered.
4. Select some and check for regressions, e.g. CCODE, Bsort2, YES_NO
no changes must be observed

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #29877|0   |1
is obsolete||

--- Comment #75 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 30406
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30406action=edit
Bug 766: Remove CGI::scrollinglist from marctagstructure.pl

This patch removes the only instance in this file.

Don't know if the feature is of some utility, seems
that does not work (no use of auth values as indicators
on MARC editor)

To test:
1. Apply the patch
2. Go to Administration  MARC frameworks
3. Clic on MARC structure of any fw
4. Clic Edit on any tag
5. On tag editor check the pulldown 'Authorised value', that was replaced
6. Check for regressions: select a value, save, verify the value, change
again, etc.

Note: removed a SELECT, using now C4::Koha::GetAuthorisedValueCategories
Do not we need an AuthorisedValues.pm? (on C4 or Koha)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #76 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
(In reply to Owen Leonard from comment #72)
 That means that instead of option value=foo selected
 We need to write option value=foo selected=selected
 
 And values should be quoted: option value=foo
 And not option value=foo

Thanks Owen, fixed now. 
I'll add a followup to some others that have been pushed, and fix also others
awaiting sings.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12673] Remove CGI::scrolling_list from C4::Items.pm

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12673

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #30301|0   |1
is obsolete||

--- Comment #2 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 30407
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30407action=edit
Bug 12673: Remove CGI::scrolling_list from C4::Items.pm

This patch removes only instance in this file

To test:
1. Apply the patch
2. (Esay way) Put on staff URL
/cgi-bin/koha/services/itemrecorddisplay.pl?biblionumber=Nitemnumber=M
3. Code replaced corresponds to pulldowns, verify information
is correct (check with another item edit view)

PrepareItemrecordDisplay() in Items.pm is filled with chunks of
HTML code that must be put on TT file. For now scrolling_list
is the only removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12675] Remove CGI::scrolling_list from labeledMARCdetail.pl

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12675

--- Comment #4 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 30409
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30409action=edit
Bug 12675: Add unit test to GetFrameworksLoop

to test:
1. Apply the patch
2. Run the test, prove t/db_dependent/Koha.t
3. Check that it pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12675] Remove CGI::scrolling_list from labeledMARCdetail.pl

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12675

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #30306|0   |1
is obsolete||

--- Comment #3 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 30408
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30408action=edit
Bug 12675: Remove CGI::scrolling_list from labeledMARCdetail.pl

This patch removes only instance in this file.

Also updates getframework POD on C4/Koha.pm,
adds new GetFrameworksLoop() func on same file from
suggested code, but with ordered result.

To test:
1. Apply the patch
2. Enable viewLabeledMARC syspref
3. On staff, search for a record, goto detail view
4. Clic on Labeled MARC
5. Framework pulldown was replaced, check changing
framework.

A bug was fixed, because selecting any fw and then Default
tries to load values from 'Default' fw code, which does not
exists.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12174] Zotero connection with Koha: problem with UTF-8

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12174

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #10 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Thanks Zeno!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12683] New: Use NOLoginInstructions to customize text for OPAC user/pass information

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12683

Bug ID: 12683
   Summary: Use NOLoginInstructions to customize text for OPAC
user/pass information
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P4
 Component: OPAC
  Assignee: simith.dolive...@inlibro.com
  Reporter: simith.dolive...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Pushed by Module Maintainer |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #16 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12683] Use NoLoginInstructions to customize text for OPAC user/pass information

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12683

simith.dolive...@inlibro.com changed:

   What|Removed |Added

 CC||simith.dolive...@inlibro.co
   ||m
Summary|Use NOLoginInstructions to  |Use NoLoginInstructions to
   |customize text for OPAC |customize text for OPAC
   |user/pass information   |user/pass information

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12669] Template process failed: undef error - Invalid local time for date in time zone

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669

--- Comment #2 from Rolando Isidoro rolando.isid...@gmail.com ---
Hey Colin, following on your comment I tried to fix the problem on my own and I
think I narrowed it to 1 code entry:

$dt-set_time_zone( C4::Context-tz ); @
https://github.com/digibib/koha-work/blob/master/Koha/DateUtils.pm#L126

Since my knowledge regarding Koha's codebase is limited I now have doubts on
how to proceed, but I think it would be as simple as replacing that line for:

my $tz = $dateonly ? DateTime::TimeZone-new(name = 'floating') :
C4::Context-tz;
$dt-set_time_zone( $tz );

What's your take on this solution?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12507] Don't show News in Staff and opac in 3.16.0 / 3.16.1

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
I can confirm this bug. There is no error message in the logs!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12507] Don't show News in Staff and opac in 3.16.0 / 3.16.1

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12507] Don't show News in Staff and opac in 3.16.0 / 3.16.1

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 30410
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30410action=edit
Bug 12507 - Don't show News in Staff and opac

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12507] Don't show News in Staff and opac in 3.16.0 / 3.16.1

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12507] Don't show News in Staff and opac in 3.16.0 / 3.16.1

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507

--- Comment #4 from Kyle M Hall k...@bywatersolutions.com ---
I have no idea how to trigger this bug, but the tester can at least prove it
does not cause a regression, I think that should be enough!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12507] News does not always display in staff or OPAC

2014-07-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Patch complexity|Trivial patch   |---
   Assignee|k...@bywatersolutions.com   |koha-b...@lists.koha-commun
   ||ity.org
Summary|Don't show News in Staff|News does not always
   |and opac in 3.16.0 / 3.16.1 |display in staff or OPAC

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >