[Koha-bugs] [Bug 12601] aqorders.budget_id should be a foreign key
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12601 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added CC||srd...@catalyst.net.nz --- Comment #2 from Srdjan Jankovic srd...@catalyst.net.nz --- And what about kohastructure.sql? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12505] Variable aqorders.listprice from 'Tools' - 'Notices and Slips' Does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added CC||srd...@catalyst.net.nz --- Comment #3 from Srdjan Jankovic srd...@catalyst.net.nz --- Well in that case the whole join is unnecessary and should be removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12623] SQLHelper replacement - Koha::Borrower::Modifications
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12623 --- Comment #14 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Katrin Fischer from comment #13) In another test I got: DBIx::Class::Row::new(): No such column 'B_email' on Koha::Schema::Result::BorrowerModification at /home/katrin/kohaclone/Koha/Borrower/Modifications.pm line 63 DBIx schema not up to date? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #29814|0 |1 is obsolete|| Attachment #29819|0 |1 is obsolete|| Attachment #30189|0 |1 is obsolete|| Attachment #30190|0 |1 is obsolete|| Attachment #30191|0 |1 is obsolete|| Attachment #30192|0 |1 is obsolete|| Attachment #30193|0 |1 is obsolete|| Attachment #30194|0 |1 is obsolete|| --- Comment #65 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 30900 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30900action=edit Bug 6536: Add a form for SRU Field mapping This form allows you to enter the match between the standard names of the Z3950 search fields and the field names for a specific SRU server. This patch only adds the form; it will be used in a subsequent patch. Test plan: Not needed, but you can call the form by constructing a URL like: cgi-bin/koha/admin/sru_modmapping.pl?mapping=title=1,author=2 You should see the form with title and author filled. Note that you cannot save the information yet. Signed-off-by: Giuseppe Angilella giuseppe.angile...@ct.infn.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #66 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 30901 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30901action=edit Bug 6536: Two simple test XSLT files You could use Add901.xsl or Set003ABC.xsl in field add_xslt of table z3950servers when testing this report. Set003ABC will change field 003 into ABC. And Add901 adds a tag 901. Signed-off-by: Giuseppe Angilella giuseppe.angile...@ct.infn.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #68 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 30903 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30903action=edit Bug 6536: Update DBIx schema of z3950servers for testing This patch adjusts the DBIx schema file for z3950servers table. This can be used for testing this set of patches. When the report is pushed, the RM should update the DBIx schema. Signed-off-by: Giuseppe Angilella giuseppe.angile...@ct.infn.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #69 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 30904 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30904action=edit Bug 6536: SRU servers administration This patch makes adjustments in admin/z3950servers in order to insert, edit and delete SRU server records. Test plan: Add, edit, copy and delete SRU server. Check if adding, editing, copying and deleting Z3950 servers still works. Signed-off-by: Giuseppe Angilella giuseppe.angile...@ct.infn.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #67 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 30902 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30902action=edit Bug 6536: Dbrev for Z3950 search improvements Adjusts table z3950servers: Drops unused columns icon, description and position. Moves id column to first position. Renames name to servername, and type to servertype. (This is not only more clear but may eliminate some problems too with DBIx.) Changes recordtype from varchar(45) to enumeration with two members. [The upgrade replaces unknown record types with biblio, although it is very unlikely to find such records.] Adds SRU as servertype enumeration member. Removes opensearch, since it is not used/supported. [The upgrade replaces unknown server types with zed (z3950) (in exceptional cases).] Adds new columns: sru_options, sru_fields, add_xslt. Test plan: Run database update via webinstaller. Check your z3950servers table. Signed-off-by: Giuseppe Angilella giuseppe.angile...@ct.infn.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #70 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 30905 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30905action=edit Bug 6536: Adjustments for servername and servertype Replaces name by servername, type by servertype for running Z3950 search. Limit search scripts to zed (z3950) servers until sru is supported. Test plan: Perform a Z3950 search in Cataloguing and Acquisition. Verify that it still works as it did. Signed-off-by: Giuseppe Angilella giuseppe.angile...@ct.infn.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #72 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 30907 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30907action=edit Bug 6536: Add XSLT transformation on Z3950 search results Use the stylesheets listed in field add_xslt of z3950servers to transform search results of Z3950/SRU search. Additionally, the template has been changed to make more error messages (or warnings) visible when displaying results. Until now, error message were shown in the results table and when connection errors occurred, no results were displayed at all. Test plan: Create some stylesheets (or see the sample patch on bug 6536). Add these stylesheets to some Z3950/SRU servers. Do Z3950 search and verify the transformations. Do a search with 2 targets; make one target fail (by manipulating its server data). Do you see the connection error and the results for the other target? Generate a XSLT error by modifying one stylesheet. Check search results. You should see warnings. Signed-off-by: Giuseppe Angilella giuseppe.angile...@ct.infn.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #71 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 30906 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30906action=edit Bug 6536: Include SRU searching in Breeding.pm This patch makes it possible to include SRU servers in Z3950 search. It adjusts the Z3950Search routine in Breeding module. It also replaces SQL code with DBIx statements in Breeding.pm/Z3950Search and the associated scripts z3950search.pl in cataloguing and acqui. Test plan: Verify if a normal Z3950 search still works in cataloging/acqui. Add a SRU target. (You could just use Koha's port 9998.) Define sru_options like sru=get. Use that target in a Z3950 search in cataloging and acqui. (Import.) Test sru_fields translation by comparing search results between various settings for some of the fields. For instance, leave title empty and after that set it to the title field of your SRU target. Signed-off-by: Giuseppe Angilella giuseppe.angile...@ct.infn.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12529] Overdue notices do not respect holidays
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 --- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com --- Martin and Tomas, did you see my comment 4 ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #73 from M. de Rooy m.de.r...@rijksmuseum.nl --- Rebased it again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #30901|Bug 6536: Two simple test |[TESTING_ONLY] Bug 6536: description|XSLT files |Two simple test XSLT files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #30903|Bug 6536: Update DBIx |[DO_NOT_PUSH] Bug 6536: description|schema of z3950servers for |Update DBIx schema of |testing |z3950servers for testing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12505] Variable aqorders.listprice from 'Tools' - 'Notices and Slips' Does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||ch...@bigballofwax.co.nz --- Comment #4 from Chris Cormack ch...@bigballofwax.co.nz --- I agree doing a join where we dont either return any of the data from the table, or use it in any condition doesn't make sense. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #30881|0 |1 is obsolete|| --- Comment #39 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 30908 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30908action=edit [PASSED QA] Bug 8868: ILS-DI: CancelHold needs to take a reserve_id CancelHold takes two parameters: patron_id and item_id. If item_id is considered as an itemnumber, holds on title can't be canceled. If item_id is considered as a biblionumber, all holds on this biblionumber (for a borrower) will be canceled. So CancelHold have to consider item_id as a reserve_id. - Added subroutine C4::Reserves::GetReserve - C4::ILSDI::Services::GetRecords now returns the reserve_id - Fix the text in the ilsdi.pl?service=Describeverb=CancelHold page - Unit tests for CancelReserved and GetReserve - Do not delete row in reserves table if insert in old_reserves fails Signed-off-by: Leila and Sonia koha.aixmarsei...@gmail.com Signed-off-by: Benjamin Rokseth bensino...@gmail.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signing off, while noting a style issue in the patch review Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes tests and QA script. Placed and cancelled a hold using ILS-DI successfully. Adding a follow-up to also update the ils-di documentation page in the bootstrap theme. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 --- Comment #40 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 30909 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30909action=edit Bug 8868: Follow-up: Update boostrap documentation page Updates the bootstrap documentation page for CancelHold. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 --- Comment #41 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Note: this is a change in how the API currently works and people who are using it to cancel holds will need to change their programs. That said, I think it's still a good change - but maybe it should not go into lower versions and have a note in the release notes for 3.18? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7673] New patron permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #28007|0 |1 is obsolete|| --- Comment #72 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 30910 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30910action=edit Bug 7673 : New patron permissions This patch adds the following permissions: - editcatalogue.limited_item_edition: Limit item modification to barcode, status and note - editcatalogue.delete_all_items: Delete all items at once - tools.items_limited_batchmod: Limit batch item modification to item status The SubfieldsToAllowForLimitedEdition syspref is used to define which subfields can be edited when the editcatalogue.limited_item_edition permission is enabled. In the same way, the SubfieldsToAllowForLimitedBatchmod is used to define which subfields can be edited when the tools.items_limited_batchmod permission is enabled. Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7673] New patron permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #28008|0 |1 is obsolete|| --- Comment #73 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 30911 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30911action=edit Bug 7673: QA Followup: trailing whitespace and perlcritic issues This patch fixes the following qa issues: FAIL cataloguing/additem.pl FAIL forbidden patterns forbidden pattern: trailing space char (line 833) FAIL critic # Variables::ProhibitConditionalDeclarations: Got 2 violation(s). FAIL tools/batchMod.pl FAIL critic # Variables::ProhibitConditionalDeclarations: Got 2 violation(s). Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7673] New patron permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #28009|0 |1 is obsolete|| --- Comment #74 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 30912 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30912action=edit Bug 7673: The delete all items link should only be displayed if delete_all_items is set This test had been lost in a rebase. Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7673] New patron permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #28010|0 |1 is obsolete|| --- Comment #75 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 30913 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30913action=edit Bug 7673: the limitation on editing an item does not affect FA framework The pref SubfieldsToAllowForLimitedEdition should not affect Fast cataloguing framework (FA). Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7673] New patron permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #28014|0 |1 is obsolete|| --- Comment #79 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 30917 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30917action=edit Bug 7673: Change the superlibrarian check To know if the user is a superlibrarian, we have to call C4::Context-IsSuperLibrarian Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7673] New patron permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #28015|0 |1 is obsolete|| --- Comment #80 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 30918 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30918action=edit Bug 7673: DB Changes - add system preferences This patch the 2 system preferences SubfieldsToAllowForRestrictedEdition and SubfieldsToAllowForRestrictedBatchmod. Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7673] New patron permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #28012|0 |1 is obsolete|| --- Comment #77 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 30915 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30915action=edit Bug 7673: DB changes - Add permissions This patch adds 3 permissions: - edit_items_restricted - delete_all_items - items_batchmod_restricted Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7673] New patron permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #28013|0 |1 is obsolete|| --- Comment #78 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 30916 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30916action=edit Bug 7673: Update permission names in script Two permission names have been changed since the first patch. Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7673] New patron permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #29550|0 |1 is obsolete|| --- Comment #81 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 30919 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30919action=edit Bug 7673: DB changes - (follow-up) Add permissions Add permissions for ru-RU and uk-UA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7673] New patron permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #28011|0 |1 is obsolete|| --- Comment #76 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 30914 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30914action=edit Bug 7673: Update syspref names in script The both syspref names have been changed since the first patch. Signed-off-by: Koha Team AMU koha.aixmarsei...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7673] New patron permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 --- Comment #42 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Because it took me a bit to find it: http://old.diglib.org/architectures/ilsdi/DLF_ILS_Discovery_1.1.pdf -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #29169|0 |1 is obsolete|| --- Comment #43 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 30920 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30920action=edit Bug 8992: Use the existing greybox plugin in interface/theme -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment #44 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #40) Hm, is it possible the library was submitted by accident? Older versions of the patch don't seem to include it. Sorry, I c/p the files in the interface directory and didn't remove them from the old directory. The last patch uses the existing files without moving them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11244] notices ignoring the dateformat preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #34 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Chris Cormack from comment #30) Also i'd love to see some benchmarks. see comment 21. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8836] Resurrect Rotating Collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 --- Comment #46 from Juhani Seppälä jsep...@student.uef.fi --- (In reply to Nick Clemens from comment #45) Could not apply on VM or sandbox Applying: Bug 8836 - Resurrect Rotating Collections - QA Followup Applying: Bug 8836 - Resurrect Rotating Collections - Followup 2 - Perltidy rotating collections scripts /home/nick/koha/.git/rebase-apply/patch:59: trailing whitespace. INSERT INTO collections ( colId, colTitle, colDesc ) /home/nick/koha/.git/rebase-apply/patch:211: trailing whitespace. SELECT /home/nick/koha/.git/rebase-apply/patch:373: trailing whitespace. DELETE FROM collections_tracking /home/nick/koha/.git/rebase-apply/patch:424: trailing whitespace. SELECT barcode FROM items, collections_tracking /home/nick/koha/.git/rebase-apply/patch:471: trailing whitespace. SELECT holdingbranch, colBranchcode FROM items, collections, collections_tracking fatal: sha1 information is lacking or useless (rotating_collections/addItems.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 8836 - Resurrect Rotating Collections - Followup 2 - Perltidy rotating collections scripts When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Patch left in /tmp/Bug-8836---Resurrect-Rotating-Collections---Follow-hvjidv.patch Did you mean to test the squashed patch? I didn't set anything obsolete because I'm unsure as to whether squashing these old patches like this is actually welcome at all - I was hoping for comments and reactions. I guess I shouldn't have a set needs signoff - sorry. I can fix the old separate patches if that's how they should be kept. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8836] Resurrect Rotating Collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 --- Comment #47 from Juhani Seppälä jsep...@student.uef.fi --- Created attachment 30921 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30921action=edit Bug 8836 - Resurrect Rotating Collections: additions This is patch is an enchancement patch based on our requirements (sending in hopes that it could be useful to someone) and is ment to be applied on top of my squashed rotating collections patch and focuses mainly on the interface, aiming to streamline workflow and and to reduce unnecessary page reloads. Core rotating collection functionality is also changed in that transfers are now handled on the item level instead of on the collection level. This allows individual items in the collection to have their own transfer branches - you can still of course have all items transferred to the same destination by using the collection transfer feature in the main view or in the additems-view. Note: as this is a fairly large change in how collections are handled, this patch cannot be used directly with collections managed by the old system. List of larger changes (of the top of my head): - transferCollection-view has been made redundant with the addition of a transfer button and branch select input in the main view. - editCollections-view has been made redundant with addition of the edit button in the main view. Note that Edit collection still exists - datatables used in all the views. - The main view table has been revamped and some columns have been moved around or removed. New columns: Owner(branch of the signed in user on creation), Items(count), Transferred(how many items in collection are transferred), Transfer collection, Edit and Delete. - New collections can be created directly from the main view using the New collection-button. - Item's original home branch (before a transfer) is now recorded on transfer (a new database column 'origin_branchcode' in collection_tracking). The old collection-level transfer branch in collections is no longer needed but is not touched by this patch. - Item's transfer location is now recored on item-level basis (a new database column: 'transfer_branch). - Item's tranfer status is now recorded (a new database column in collection_tracking: 'transferred'). - When removing a collection, all items (if any) in that collection get removed from collection_tracking and returned to their origin branch. - addItems-view: - Table now shows the item's origin branch, home branch and current loc. In addition to these, new columns: Transferred, Transfer, Return and Remove. - Item's title and barcode are now links to the relevant page in catalogue. - Buttons for individual item transfer, return and removal. The transfer button can be used to transfer an individual item to a branch (branch selection happens in a bootsrap modal-view). The return button can be used to return an item to its origin branch. The remove button allows removing an item from the collection without the need for reading a barcode. - A button for whole collection transfer. Sadly, this is *not* a complete list of changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7380] Can't filter patron search on detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- This patch depends on bug 11944. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9368] specific behavior of yr and acqdate indexes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9368 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added QA Contact|jonathan.dru...@biblibre.co | |m | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4162] Inventory Tool Fails Silently
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4162 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4162] Inventory Tool Fails Silently
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4162 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #30899|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 30922 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30922action=edit [PASSED QA] Bug 4162 - Followup: only count potential barcodes The $lines_read++; was before the code which skipped empty lines. By moving it after the next unless $barcode; code, the $lines_read variable only counts potential barcodes, and does not include empty lines. TEST PLAN - 1) Apply patch. 2) Attempt a valid barcode file with empty lines. -- The potential barcode count should exclude the empty lines. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Empty lines are now no longer counted as potential barcodes. Passes tests and QA script. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12557] Cannot revert the changes done by AcqItemSetSubfieldsWhenReceived on canceling a receipt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12557 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I am sorry, but the tests fail for me, could someone else check if they pass for them? perl t/db_dependent/Acquisition/CancelReceipt.t 1..3 ok 1 - Create items on receiving: 0 item exist after cancelling a receipt DBD::mysql::st execute failed: Column 'biblio_auth_number' cannot be null at /home/katrin/kohaclone/C4/Biblio.pm line 2886. DBD::mysql::st execute failed: Column 'biblio_auth_number' cannot be null at /home/katrin/kohaclone/C4/Biblio.pm line 2886. # Looks like you planned 3 tests but ran 1. # Looks like your test exited with 255 just after 1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7292] new permission for claims
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added QA Contact||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7292] new permission for claims
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292
--- Comment #44 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Just a note from code review:
-$template-{VARS}-{'info_claim'} = 1;
+$template-param(info_claim = 1);
The first line was correct (TT), the second is still working (HTP), but
outdated.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12162] Add class=branchcode to body tag to make OPAC CSS-styleable per branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12162 --- Comment #31 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to M. de Rooy from comment #27) For some reason, this patch does not pass the QA tools script: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt OK forbidden patterns OK tt_valid FAIL valid_template bodytag.inc: not found FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt OK forbidden patterns OK tt_valid FAIL valid_template bodytag.inc: not found My first idea here is that the qa tools script is still looking in prog for the include file instead of bootstrap. So it could be a false negative. Will add Jonathan to the CC list of this report. Fixed in the koha-qa repo: commit c2303b68be33e69198f26cd753172f995ac390eb Author: Jonathan Druart jonathan.dru...@biblibre.com Date: Mon Aug 18 13:07:18 2014 +0200 The prog theme for the OPAC is deprecated, now use bootstrap See bug 12162 comment 27. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7817] Items Permanent location (shelving location) is set to NULL when item is edited
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7817 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #30350|[SIGNED-OFF] Bug 7817: A DB |[SIGNED-OFF COUNTERPATCH] description|field without a default |Bug 7817: A DB field |mapping is set to a default |without a default mapping |value on editing|is set to a default value ||on editing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7817] Items Permanent location (shelving location) is set to NULL when item is edited
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7817 --- Comment #21 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 30923 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30923action=edit Bug 7817 - Items Permanent location (shelving location) is set to NULL when item is edited A quick fix to prevent more damages. No perceived side-effects so far. Signed-off-by: David Cook dc...@prosentient.com.au This is actually a perfectly good fix for this issue. I've changed the explanatory comment to explain why. Another option would be to remove the 'exists' check in the sub _do_column_fixes_for_mod(), but this is just as functional. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Detailed comment on Bugzilla. Adding a small follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7817] Items Permanent location (shelving location) is set to NULL when item is edited
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7817 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #30923|Bug 7817 - Items Permanent |[SIGNED_OFF ORIGINAL] Bug description|location (shelving |7817 - Items Permanent |location) is set to NULL|location (shelving |when item is edited |location) is set to NULL ||when item is edited -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11007] Useless column cancelledby in aqorders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11007 --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Owen Leonard from comment #3) (In reply to Jonathan Druart from comment #2) 3/ prove t/db_dependent/Acquisition.t should return green. Does that test return green for you in master? It doesn't for me. Yes, what is the error you get? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12780] New: Addition of plugins-menu.inc for handling a nav menu for Koha Plugins
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12780 Bug ID: 12780 Summary: Addition of plugins-menu.inc for handling a nav menu for Koha Plugins Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: indr...@gmail.com QA Contact: gmcha...@gmail.com Unlike other *-menu.inc files in the /intranet-tmpl/prog/en/includes directory, Koha plugin do not include such a file. This bug/patch is intended to add such sopport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12780] Addition of plugins-menu.inc for handling a nav menu for Koha Plugins
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12780 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added Component|Test Suite |Tools Assignee|ch...@bigballofwax.co.nz|gmcha...@gmail.com QA Contact|gmcha...@gmail.com |testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12780] Addition of plugins-menu.inc for handling a nav menu for Koha Plugins
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12780 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added Priority|P5 - low|P3 CC||indr...@gmail.com Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7817] Items Permanent location (shelving location) is set to NULL when item is edited
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7817 --- Comment #22 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 30924 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30924action=edit Bug 7817: [QA FOLLOW-UP FOR ORIGINAL] QA Follow-up for original patch This patch removes the commented line for permanent_location. It adds a more general comment. It also adjusts the exists check on permanent_location. Furthermore, it removes the line for paidfor too. Also an internal field that was being cleared when editing items (same logic). Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7292] new permission for claims
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #45 from Katrin Fischer katrin.fisc...@bsz-bw.de --- The database update works very nicely, seeting the permissions. But when I tried retesting the feature itself, I have run into problems: - AcqViewBaskets: created or managed by staff user - Staff patron doesn't have claim_for_all permission - aqorders.branch != staff patron home branch - aqorders.authorisedby != staff patron borrowernumber - Tried logging in and out after making the changes. ... and it still shows up in the late orders list. What am I missing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7817] Items Permanent location (shelving location) is set to NULL when item is edited
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7817 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #23 from M. de Rooy m.de.r...@rijksmuseum.nl --- QA Comment: I looked at the first signed patch and also the signed counterpatch. I have a strong preference for the original patch. I think that the reason for failing QA on that patch was not really valid. If failed because If a library decides to map permanent_location to a marc field, they will be unable to set it to a null value. A library should never decide that. Someone who maps permanent_location to a marc field, is doing something very weird! This item field is really a Koha internal for e.g. the CART functions. Nobody should use it for another reason (same for a few other item fields). We could hide such fields from using them in admin/koha2marclinks.pl and admin/marc_subfields_structure.pl (new report?) I think that one of the reasons for this problem is the historically grown 'hybrid' approach of items in Koha. We offer a MARC structure to edit them, but we do not save them in MARC but just in item fields. When saving an edited item, we call ModItemFromMarc with its default_values_for_mod_from_marc hash. Jonathan rebuilds this hash, but imo we should more focus on this subroutine. Let the subroutine only map the 952 fields to item fields, instead of doing what it does now (new marc record, transformMarcToKoha, get_unlinked_fields, etc.) This is too complicated. The second patch does not simplify the situation (not saying that it is theoretically correct btw). The first patch removes a non-marc item field from the default_values_for_mod_from_marc hash. This is a correct action; it should not be there. Other non-marc item fields should not be there either. Like paidfor (see follow-up). The counterpatch is a more drastic approach. It is not simple as mentioned. It does a lot more so it will add at least some to performance. And since it touches a lot more, it should be tested a lot more. I would favor pushing the first patch and refactor ModItemFromMarc with the counterpatch as a base. I will add a followup for the first patch and unhide the first patch, leaving the counterpatch as-is and set this report to In Discussion for one or two weeks, allowing all involved to give their opinion too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to M. Tompsett from comment #8) This seems like an abstraction that will detract momentum from those just starting to write tests. I'm not saying it isn't useful, but I see no need to refactor existing working tests to use it in the immediate future. The need is to provide some examples on how use this module for further uses. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11714] GetBudgetHierarchy needs optimization
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11714 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||paola.ro...@cineca.it --- Comment #9 from Paola Rossi paola.ro...@cineca.it --- I've applied the patch aginst master 3.17.00.014 The totals shown in the Period allocated row are wrong. Instead of being: 1,000.00 4.00 996.00 they are: 1,110.00 10.00 1,100.00 So I pass the patch to Failed QA status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7290] new permission for receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added QA Contact||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7817] Items Permanent location (shelving location) is set to NULL when item is edited
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7817 --- Comment #24 from M. de Rooy m.de.r...@rijksmuseum.nl --- First point for the discussion (with thanks to cait): Should we add a dbrev (here) for installations that mapped internal fields to their MARC structure in Koha? Or at least check permanent_location and paidfor under this report? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7290] new permission for receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #36 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Julian, I fixed the conflict in the database update and a tab char in parcels.tt, but now I got stuck with the tests failing: $ prove t/Acquisition/CanUserReceiveBasket.t t/Acquisition/CanUserReceiveBasket.t .. C4::Context-userenv not defined! at /home/katrin/kohaclone/C4/Acquisition.pm line 870. t/Acquisition/CanUserReceiveBasket.t .. 1/18 C4::Context-userenv not defined! at /home/katrin/kohaclone/C4/Acquisition.pm line 870. C4::Context-userenv not defined! at /home/katrin/kohaclone/C4/Acquisition.pm line 870. C4::Context-userenv not defined! at /home/katrin/kohaclone/C4/Acquisition.pm line 870. # Failed test at t/Acquisition/CanUserReceiveBasket.t line 46. C4::Context-userenv not defined! at /home/katrin/kohaclone/C4/Acquisition.pm line 870. # Failed test at t/Acquisition/CanUserReceiveBasket.t line 47. C4::Context-userenv not defined! at /home/katrin/kohaclone/C4/Acquisition.pm line 870. # Failed test at t/Acquisition/CanUserReceiveBasket.t line 48. C4::Context-userenv not defined! at /home/katrin/kohaclone/C4/Acquisition.pm line 870. C4::Context-userenv not defined! at /home/katrin/kohaclone/C4/Acquisition.pm line 870. C4::Context-userenv not defined! at /home/katrin/kohaclone/C4/Acquisition.pm line 870. # Failed test at t/Acquisition/CanUserReceiveBasket.t line 54. C4::Context-userenv not defined! at /home/katrin/kohaclone/C4/Acquisition.pm line 870. C4::Context-userenv not defined! at /home/katrin/kohaclone/C4/Acquisition.pm line 870. C4::Context-userenv not defined! at /home/katrin/kohaclone/C4/Acquisition.pm line 870. C4::Context-userenv not defined! at /home/katrin/kohaclone/C4/Acquisition.pm line 870. # Failed test at t/Acquisition/CanUserReceiveBasket.t line 64. C4::Context-userenv not defined! at /home/katrin/kohaclone/C4/Acquisition.pm line 870. # Failed test at t/Acquisition/CanUserReceiveBasket.t line 65. C4::Context-userenv not defined! at /home/katrin/kohaclone/C4/Acquisition.pm line 870. # Failed test at t/Acquisition/CanUserReceiveBasket.t line 66. C4::Context-userenv not defined! at /home/katrin/kohaclone/C4/Acquisition.pm line 870. C4::Context-userenv not defined! at /home/katrin/kohaclone/C4/Acquisition.pm line 870. # Failed test at t/Acquisition/CanUserReceiveBasket.t line 71. C4::Context-userenv not defined! at /home/katrin/kohaclone/C4/Acquisition.pm line 870. # Looks like you failed 8 tests of 18. t/Acquisition/CanUserReceiveBasket.t .. Dubious, test returned 8 (wstat 2048, 0x800) Failed 8/18 subtests Test Summary Report --- t/Acquisition/CanUserReceiveBasket.t (Wstat: 2048 Tests: 18 Failed: 8) Failed tests: 4-6, 9, 13-15, 17 Non-zero exit status: 8 Could you also take a look at squashing these patches? Because of the chanes in the database structure (we started with adding a branch column to aqorders that was later removed from the patches) I think it could make sense here. Also if I saw correctly all patches are from you and signed only by Paola. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12550] Add ability to delay loading of patron's checkouts in circulation and patron details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Patch complexity|--- |Medium patch QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | --- Comment #6 from M. de Rooy m.de.r...@rijksmuseum.nl --- This one is on top now. Will add this report to my QA to-do list (for nontrivial patches :) But if someone else wants to QA this first, no problem whatsoever.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12550] Add ability to delay loading of patron's checkouts in circulation and patron details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to M. de Rooy from comment #6) Will add this report to my QA to-do list (for nontrivial patches :) If I remember correctly, this is more a simple patch than a medium. Most of the part of the changes is indentation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12550] Add ability to delay loading of patron's checkouts in circulation and patron details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550 --- Comment #8 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Jonathan Druart from comment #7) (In reply to M. de Rooy from comment #6) Will add this report to my QA to-do list (for nontrivial patches :) If I remember correctly, this is more a simple patch than a medium. Most of the part of the changes is indentation. Could be. I just looked at the number of lines while scrolling through.. Thx -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11714] GetBudgetHierarchy needs optimization
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11714 --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 30925 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30925action=edit Bug 11714: A fund is a top-level fund if it does not have any parent -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11714] GetBudgetHierarchy needs optimization
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11714 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7673] New patron permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #82 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
From code review:
1) (normal) The descriptions for edit_items_restricted and
items_bachmod_restricted are now no longer correct, since the preferences have
been added to avoid hardcoding MARC fields - maybe refer to the prefs instead?
2) (non blocker) Patch keeps(?) a CGI::scrolling_list instance - could be in
conflict with one of Bernardo's patches there:
additem.pl:
$subfield_data{marc_value} =CGI::scrolling_list(@scrparam);
3) (non blocker) Database updates could be merged.
3) Suggestion: should we squash the patches (maybe 1-9 + )? Because the
permissions got renamed and some other things that could avoid some confusion.
Also an updated summary of the changes and a test plan would be great.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7290] new permission for receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #30340|0 |1 is obsolete|| --- Comment #38 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 30927 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30927action=edit Bug 7290: QA fixes Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7290] new permission for receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290
--- Comment #39 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 30928
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30928action=edit
Bug 7290: Fix CanUserReceiveBasket tests
CanUserReceiveBasket now verify the 'superlibrarian' status of user
using $userenv-{flags} (IsSuperLibrarian)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7290] new permission for receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #30337|0 |1 is obsolete|| Attachment #30338|0 |1 is obsolete|| Attachment #30339|0 |1 is obsolete|| --- Comment #37 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 30926 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30926action=edit Bug 7290: More granular permissions for order receiving Add subpermission acquisition = order_receive_all Users with order_receive_all can receive all orders. Users with only order_receive can receive an order if: - basket branch is defined and is the same as the current working branch, or - basket branch is not defined Use dataTables filters possibilities instead of custom JS solution in parcel.pl Unit tests are available in t/Acquisition/CanUserReceiveBasket.t Signed-off-by: Paola Rossi paola.ro...@cineca.it (squash of the 3 first patches, rebased on master) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7290] new permission for receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7673] New patron permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #83 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Some Minor comments to start the ball rolling.. Nothing fail worthy so far. 1. Z3950 references in the staff client. There are references to Z3950 in a number of places in the staff client, for instance admin-home where we go to configure z3950 targets should make it clear that we're now configuruing z3950 OR sru.. and 'Add new from z3950' under cataloguing should also be updated. Perhaps 'New from external database' or similar? 2. 'Database' on the 'Add Server' page is a required field, but it's also not obviose what it expects 3. I'de like a more visual queue somewhere in the Add SRU server page that one really aught to define the 'SRU Search fields mappings' else all searches will be against the 'any' index on the remote server. Maybe this is a documentation thing. Either a stronger hint to fill that stuff in.. or to drop the index specific search boxes in the 'Add from ' popup when the sru server is selected.. Hard call really.. we want people to map them to get sensible results really. Maybe set some sensible defaults and make it a required field? Back to testing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7673] New patron permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #84 from Martin Renvoize martin.renvo...@ptfs-europe.com --- poo.. worng bug for the above comment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #74 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Some Minor comments to start the ball rolling.. Nothing fail worthy so far. 1. Z3950 references in the staff client. There are references to Z3950 in a number of places in the staff client, for instance admin-home where we go to configure z3950 targets should make it clear that we're now configuruing z3950 OR sru.. and 'Add new from z3950' under cataloguing should also be updated. Perhaps 'New from external database' or similar? 2. 'Database' on the 'Add Server' page is a required field, but it's also not obviose what it expects 3. I'de like a more visual queue somewhere in the Add SRU server page that one really aught to define the 'SRU Search fields mappings' else all searches will be against the 'any' index on the remote server. Maybe this is a documentation thing. Either a stronger hint to fill that stuff in.. or to drop the index specific search boxes in the 'Add from ' popup when the sru server is selected.. Hard call really.. we want people to map them to get sensible results really. Maybe set some sensible defaults and make it a required field? Back to testing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #75 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Also.. any chance of a documentation patch to go along with the updated functionality? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #76 from Martin Renvoize martin.renvo...@ptfs-europe.com --- 1 Final comment before passing... We've already discussed that a user accessible way to set the xslt transformations would be a very useful and sensible future enhancement to this, and I believe from our chat that you are intended on implementing this via the marc modification templates framework. I don't really like how the configuration of SRU is currently spread between Serverside and Clientside actions; requiring templates to be placed on the server, yet the links to said templates to go into the staff client. Again.. not a fail.. but a comment for future enhancement.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30900|0 |1 is obsolete|| --- Comment #77 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30929 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30929action=edit [PASSED QA] Bug 6536: Add a form for SRU Field mapping This form allows you to enter the match between the standard names of the Z3950 search fields and the field names for a specific SRU server. This patch only adds the form; it will be used in a subsequent patch. Test plan: Not needed, but you can call the form by constructing a URL like: cgi-bin/koha/admin/sru_modmapping.pl?mapping=title=1,author=2 You should see the form with title and author filled. Note that you cannot save the information yet. Signed-off-by: Giuseppe Angilella giuseppe.angile...@ct.infn.it Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30902|0 |1 is obsolete|| --- Comment #79 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30931 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30931action=edit [PASSED QA] Bug 6536: Dbrev for Z3950 search improvements Adjusts table z3950servers: Drops unused columns icon, description and position. Moves id column to first position. Renames name to servername, and type to servertype. (This is not only more clear but may eliminate some problems too with DBIx.) Changes recordtype from varchar(45) to enumeration with two members. [The upgrade replaces unknown record types with biblio, although it is very unlikely to find such records.] Adds SRU as servertype enumeration member. Removes opensearch, since it is not used/supported. [The upgrade replaces unknown server types with zed (z3950) (in exceptional cases).] Adds new columns: sru_options, sru_fields, add_xslt. Test plan: Run database update via webinstaller. Check your z3950servers table. Signed-off-by: Giuseppe Angilella giuseppe.angile...@ct.infn.it Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30903|0 |1 is obsolete|| --- Comment #80 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30932 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30932action=edit [RM NOTE] Bug 6536: Update DBIx schema of z3950servers for testing This patch adjusts the DBIx schema file for z3950servers table. This can be used for testing this set of patches. When the report is pushed, the RM should update the DBIx schema. Signed-off-by: Giuseppe Angilella giuseppe.angile...@ct.infn.it Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30901|0 |1 is obsolete|| --- Comment #78 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30930 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30930action=edit Bug 6536: Two simple test XSLT files You could use Add901.xsl or Set003ABC.xsl in field add_xslt of table z3950servers when testing this report. Set003ABC will change field 003 into ABC. And Add901 adds a tag 901. Signed-off-by: Giuseppe Angilella giuseppe.angile...@ct.infn.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30904|0 |1 is obsolete|| --- Comment #81 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30933 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30933action=edit [PASSED QA] Bug 6536: SRU servers administration This patch makes adjustments in admin/z3950servers in order to insert, edit and delete SRU server records. Test plan: Add, edit, copy and delete SRU server. Check if adding, editing, copying and deleting Z3950 servers still works. Signed-off-by: Giuseppe Angilella giuseppe.angile...@ct.infn.it Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30905|0 |1 is obsolete|| --- Comment #82 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30934 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30934action=edit [PASSED QA] Bug 6536: Adjustments for servername and servertype Replaces name by servername, type by servertype for running Z3950 search. Limit search scripts to zed (z3950) servers until sru is supported. Test plan: Perform a Z3950 search in Cataloguing and Acquisition. Verify that it still works as it did. Signed-off-by: Giuseppe Angilella giuseppe.angile...@ct.infn.it Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30907|0 |1 is obsolete|| --- Comment #84 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30936 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30936action=edit [PASSED QA] Bug 6536: Add XSLT transformation on Z3950 search results Use the stylesheets listed in field add_xslt of z3950servers to transform search results of Z3950/SRU search. Additionally, the template has been changed to make more error messages (or warnings) visible when displaying results. Until now, error message were shown in the results table and when connection errors occurred, no results were displayed at all. Test plan: Create some stylesheets (or see the sample patch on bug 6536). Add these stylesheets to some Z3950/SRU servers. Do Z3950 search and verify the transformations. Do a search with 2 targets; make one target fail (by manipulating its server data). Do you see the connection error and the results for the other target? Generate a XSLT error by modifying one stylesheet. Check search results. You should see warnings. Signed-off-by: Giuseppe Angilella giuseppe.angile...@ct.infn.it Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30906|0 |1 is obsolete|| --- Comment #83 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30935 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30935action=edit [PASSED QA] Bug 6536: Include SRU searching in Breeding.pm This patch makes it possible to include SRU servers in Z3950 search. It adjusts the Z3950Search routine in Breeding module. It also replaces SQL code with DBIx statements in Breeding.pm/Z3950Search and the associated scripts z3950search.pl in cataloguing and acqui. Test plan: Verify if a normal Z3950 search still works in cataloging/acqui. Add a SRU target. (You could just use Koha's port 9998.) Define sru_options like sru=get. Use that target in a Z3950 search in cataloging and acqui. (Import.) Test sru_fields translation by comparing search results between various settings for some of the fields. For instance, leave title empty and after that set it to the title field of your SRU target. Signed-off-by: Giuseppe Angilella giuseppe.angile...@ct.infn.it Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #85 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Passing QA Nice work marcel, this adds a useful and usable enhancement. As commented above, I see a number of further follow-ups, but would be happy to see them as separate follow-up bugs once this piece has made it's way in and a few other areas of code have settled enough for the follow-ups to be based upon them. The main one I would like to see is a clear documentation patch to show exactly how one should configure all this stuff as is. It currently lies firmly in the system admin field for the xslt transformations stuff.. but even the SRU pieces need 'extra bits' that a normal library admin may not fully understand without a little more guidance. I can't find any regressions and the code all checks out through the qa scripts. SRU wise.. I tested mostly against the LOC SRU gateway.. but I also did some quick tests against a koha instance and a few other places. To note, if the gateway only outputs dublin core, then this it will not work with koha.. another future enhancement maybe. To test against LOC: Host: z3950.loc.gov Port: 7090 Database: voyager -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Yohann Dufour yohann.duf...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 --- Comment #5 from Yohann Dufour yohann.duf...@biblibre.com --- Created attachment 30937 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30937action=edit Bug 12633: SQLHelper replacement - C4::Members With this patch, the subroutines AddMember and Search uses DBIx::Class instead of C4::SQLHelper. In order to replace SQLHelper in the Search subroutine, 2 subroutines has been added, it seems a lot : replace 1 line with 2 subroutines, but in fact these 2 subroutines replace all the hidden work done by the SQLHelper. Test plan: 1) Apply the patch 12457 in order to get the last unit tests for Members 2) Apply the patch 3) Execute the unit tests by launching : prove t/db_dependent/Members.t 4) The result has to be a success without error or warning : t/db_dependent/Members.t .. ok All tests successful. Files=1, Tests=55, 2 wallclock secs ( 0.04 usr 0.01 sys + 2.27 cusr 0.09 csys = 2.41 CPU) Result: PASS 5) Sign in the intranet. 6) Verify you can add a member in the intranet. 7) Test of members/guarantor_search.pl : Edit a member which belongs to the cateogry type 'C' (Child), click on 'Set to patron' and verify the search of an adult member is correct. 8) Test of patroncards/members-search.pl : Go to Tools Patron card creator New batch Add item(s) and verify the search of a member is correct. 9) Test of serials/member-search.pl : Go on the page serials/member-search.pl and verify the search of a member is correct. 10) Test of reserve/request.pl : Go on a biblio details then Holds and verify the search of a member is correct. 11) Test of circ/circulation.pl : Go on Circulation Checkouts and verify the search of a member is correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8007] Discharge management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #52 from Yohann Dufour yohann.duf...@biblibre.com --- I have refactored the work of Jonathan in order to adapt it to the different comments I have read on this bug report. I have tried to find the best compromise between organization, heaviness and simplicity to finally integrate this improvement in Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10363] There is no package for authorised values.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #37 from Yohann Dufour yohann.duf...@biblibre.com --- I have refactored the work of Jonathan in order to adapt it to the different comments I have read on this bug report. I have tried to find the best compromise between organization, heaviness and simplicity to finally integrate this improvement in Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #157 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30938 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30938action=edit [PASSED QA] Bug 7143 Updating history Signed-off-by: Katrin Fischer katrin.fischer...@web.de Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30879|0 |1 is obsolete|| CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #158 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30939 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30939action=edit [PASSED QA] Bug 7143 Updating the about page Signed-off-by: Katrin Fischer katrin.fischer...@web.de Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30878|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Maxime Beaulieu maxime.beaul...@inlibro.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 --- Comment #7 from Maxime Beaulieu maxime.beaul...@inlibro.com --- Created attachment 30941 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30941action=edit Bug 11315 - Added unit tests for the modified sub in AuthoritiesMarc.pm new file: t/AuthoritiesMarc.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 --- Comment #6 from Maxime Beaulieu maxime.beaul...@inlibro.com --- Created attachment 30940 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30940action=edit Bug 11315 - Fixed issues in updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Maxime Beaulieu maxime.beaul...@inlibro.com changed: What|Removed |Added CC||maxime.beaul...@inlibro.com Assignee|fcapovi...@live.ca |maxime.beaul...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #68 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Comment on attachment 30694 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30694 Bug 11577: Code and intranet template changes Review of attachment 30694: -- (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=11577attachment=30694) - ::: C4/Circulation.pm @@ +2604,5 @@ C$override_limit, if supplied with a true value, causes the limit on the number of times that the loan can be renewed +(as controlled by the item type) to be ignored. Overriding also allows +to renew sooner than No renewal before und to manually renew loans Very minor typo in here.. 'und = and'.. no biggy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #69 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Comment on attachment 30699 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30699 Bug 11577: Add an automatic renewal cronjob Review of attachment 30699: -- (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=11577attachment=30699) - Could you also make this package safe by adding the relevant cron line to /debian/koha-common.cron.daily please -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
