[Koha-bugs] [Bug 12874] On editing an item, some fields can be set to NULL

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12874

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #31376|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 31517
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31517action=edit
Bug 12874: A DB field without a default mapping is set to a default value on
editing

If an item is edited and a field is not mapped to Koha, it is to 0 or
NULL (depending on the default value defined).

This patch adds a check on the mapping before editing the item. It there
is no mapping, the DB value is not erased.

Test plan:
1/ Edit an item and fill a value for a field
2/ Unmap this field
3/ Edit the item
4/ Verify that the value is not erased (using the MySQL CLI)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12874] On editing an item, some fields can be set to NULL

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12874

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10860] In-House Use

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860

--- Comment #38 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to David Cook from comment #37)
 The mailing list is probably a good idea for this one.

Mail sent on the koha ML.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

--- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com ---
This one is signed off and should be QA with 10900 and 10589.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10860] In-House Use

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 CC||indr...@gmail.com

--- Comment #39 from Indranil Das Gupta indr...@gmail.com ---
(In reply to Jonathan Druart from comment #38)
 (In reply to David Cook from comment #37)
  The mailing list is probably a good idea for this one.
 
 Mail sent on the koha ML.

how about in-library or intra-library use? keeps it 'in the library' but
doesn't necessary restrict it to a specific area with-in the library?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

stephane.dela...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

--- Comment #8 from stephane.dela...@biblibre.com ---
Created attachment 31518
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31518action=edit
followup : QA fixes

followup : QA fixes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

--- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com ---
Mark,

In order to add more flexibility, don't you think it would worth to add this
parameter at the patron category level?
The granularity would be better and it does not seem too difficult (except that
the UT should be rewrite).

Could I have you opinion on this idea please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12906] New: Show shipment date in invoices result list

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12906

Bug ID: 12906
   Summary: Show shipment date in invoices result list
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

It would be nice if the shipment date was included in the result list when
searching invoices. This is the date most libraries enter, while the other
dates (billing date and closing date) are not always used.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12415] Fee receipt: description of charges is empty

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12415

--- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com ---
I am sorry but I cannot recreate.
Could you please detail step by step or with screenshot/screencast?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12891] NewOrder does not return ordernumber

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12891

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||12830

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12830] Move the order-related code into its own module

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12830

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||12891

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12057] anonymous suggestions showing to all / own suggestions invisible

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12057

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Version|3.12|master
Summary|anonymous suggestions   |anonymous suggestions
   |showing to all  |showing to all / own
   ||suggestions invisible
   Severity|normal  |major

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
There is certainly some weirdness going on here, I have tried a few things now
and there is something seriously wrong:

1) If Anonsuggestions is activated, I don't have a 'my purchase suggestions'
tab in the patron account.

2) I had created a few suggestions from my account (logged in) and then set the
AnonymousPatron to 'not my borrowernumber'. Suddenly my own suggestions are no
longer accessible at all, not via the patron account and I am also not seeing
them in the purchase suggestions list.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8337] System preferences for longoverdue cron

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12827] NewOrder returns basketno

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12827

--- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 31520
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31520action=edit
Bug 12827: NewOrder needs more unit tests

NewOrder should be more tested!

This patch moves the existing unit tests into a new file and adds some
unit tests.

Note that there is no DB field aqorders.subscription, so the test in
NewOrder can be removed.

Test plan:
  prove t/db_dependent/Acquisition/NewOrder.t
and
  prove t/db_dependent/Acquisition.t
should return green.

Signed-off-by: Zeno Tajoli z.taj...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12827] NewOrder returns basketno

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12827

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #31494|0   |1
is obsolete||
  Attachment #31495|0   |1
is obsolete||

--- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 31519
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31519action=edit
Bug 12827: NewOrder should not return basketno

Since the basketno parameter is needed to insert an order, it is useless
to return it.

This patch changes the prototype for the C4::Acquisition::NewOrder
subroutine. The return value is now a scalar containing the ordernumber
created.

Test plan:
Verify there is no regression on an acquisition workflow:
1/ Create an order with several items
2/ Modify the order
3/ Receive some items
4/ Cancel the receipt
4/ Receive some items
5/ Receive all remaining items
6/ Cancel the receipt

Signed-off-by: Zeno Tajoli z.taj...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12891] NewOrder does not return ordernumber

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12891

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||12827

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12827] NewOrder returns basketno

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12827

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||12891

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12907] New: MARC21 relator codes and terms: Display relator term ($e) instead of relator code ($4)

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12907

Bug ID: 12907
   Summary: MARC21 relator codes and terms: Display relator term
($e) instead of relator code ($4)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Bibliographic data support
  Assignee: gmcha...@gmail.com
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

In case when both relator code $4 and relator term $e are used in a record,
display the relator term instead of the code.

Example:
700 1 
_aKuczaj, Stan A.
_eHrsg.
_4edt
_916185026 

Without relator terms being set up as an authorized value, this will display in
OPAC as:

Kuczaj, Stan A. [edt]

If we had a rule to display $e if it is set in the record, it would be:

Kuczaj, Stan A. [Hrsg.]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12830] Move the order-related code into its own module

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12830

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12830] Move the order-related code into its own module

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12830

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #31498|0   |1
is obsolete||
  Attachment #31499|0   |1
is obsolete||

--- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 31521
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31521action=edit
Bug 12830: Move the order-related code into Koha::Acquisition::Order

The C4::Acquisition module should be exploded in order to add
readability and maintainability to this part of the code.

This patch is a POC, it introduces a new Koha::Acquisition::Order module and
put in
it the code from NewOrder and NewOrderItem.

Test plan:
1/ Create an order, modify it, receive it, cancel the receipt.
2/ Launch the prove command on all unit tests modified by this patch and
verify that all pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12830] Move the order-related code into its own module

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12830

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on|12891   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12830] Move the order-related code into its own module

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12830

--- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 31522
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31522action=edit
Bug 12830: use find instead of search

Since ordernumber is the pk, it is stupid to use search.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12891] NewOrder does not return ordernumber

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12891

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks|12830   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12908] New: Add a German RELTERMS authorized value list to the web installer

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12908

Bug ID: 12908
   Summary: Add a German RELTERMS authorized value list to the web
installer
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Bibliographic data support
  Assignee: gmcha...@gmail.com
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

The German web installer is missing a list of RELTERMS authorized values.
(similar to bug 12299)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7627] Editing of invoice number

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7627

--- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Invoices with no received orders can now be deleted, editing the invoice number
is still impossible.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12874] On editing an item, some fields can be set to NULL

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12874

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

  Attachment #31517|0   |1
is obsolete||

--- Comment #4 from Nick Clemens n...@quecheelibrary.org ---
Created attachment 31523
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31523action=edit
[SIGNED OFF] Bug 12874: A DB field without a default mapping is set to a
default value on editing

If an item is edited and a field is not mapped to Koha, it is to 0 or
NULL (depending on the default value defined).

This patch adds a check on the mapping before editing the item. It there
is no mapping, the DB value is not erased.

Test plan:
1/ Edit an item and fill a value for a field
2/ Unmap this field
3/ Edit the item
4/ Verify that the value is not erased (using the MySQL CLI)

Signed-off-by: Nick Clemens n...@quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12818] Move permanent_location to more_subfields_xml if a library mapped it to MARC

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12818

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12874

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12874] On editing an item, some fields can be set to NULL

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12874

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12817,
   ||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12818

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12817] Remove internal item field paidfor from MARC structure

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12817

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12874

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12415] Fee receipt: description of charges is empty

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12415

--- Comment #11 from Nick Clemens n...@quecheelibrary.org ---
Here was my test plan:

1 - Create a manual invoice - Lost Item, $5.00
2 - Pay fine partially, $2.50
3 - Switch to account tab - Payment, Thanks appears twice in description
4 - Check database via repot (SELECT * FROM accountlines WHERE
borrowernumber=5)

I tested again with a manual invoice - Fine and got the same results, zip of
screenshots will be attached

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

--- Comment #7 from Nick Clemens n...@quecheelibrary.org ---
Created attachment 31524
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31524action=edit
Payment Thanks value entered into accountlines.description

Here are sequential screenshots of my steps

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

  Attachment #31524|0   |1
is obsolete||

--- Comment #8 from Nick Clemens n...@quecheelibrary.org ---
Comment on attachment 31524
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31524
Payment Thanks value entered into accountlines.description

Wrong bug# sorry

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12415] Fee receipt: description of charges is empty

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12415

--- Comment #12 from Nick Clemens n...@quecheelibrary.org ---
Created attachment 31525
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31525action=edit
Payment Thanks value entered into accountlines.description

Sequential screenshots of how I got the error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

--- Comment #23 from M. Tompsett mtomp...@hotmail.com ---
(In reply to Jonathan Druart from comment #22)
 Mark,
 
 In order to add more flexibility, don't you think it would worth to add this
 parameter at the patron category level?
 The granularity would be better and it does not seem too difficult (except
 that the UT should be rewrite).
 
 Could I have you opinion on this idea please?

In a way this is already at a patron category level, because you set the patron
category code (S/PT/VOL/etc.etc.). You aren't going to have differing
visibilities for every patron, but rather groups of patrons much like you have
staff, volunteers, or general patrons. So though the finer granularity would be
nice, I don't think the gain of finer granularity is worth a UI rework.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10860] In-House Use

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860

--- Comment #40 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Jonathan, reading through the description - can you explain some more about
the use case for the cronjob and how it might be used in the library? Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12902] Cronjob monitoring script, nagios3 compatible

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12902

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12895] Dropbox mode doesn't work correctly

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12895

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11995] Followup for Bug 7688 - FIX GetNextDate in serialsUpdate.pl

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11995

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12003] Next issues for irregular pattern not correctly predicted

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12003

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12872] Exclude limited number of fields from Zebra indexing

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12872

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

Summary|Exclude limited number of   |Exclude limited number of
   |fields from Zebra DOM   |fields from Zebra indexing
   |indexing|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12872] Exclude limited number of fields from Zebra indexing

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12872

--- Comment #7 from M. de Rooy m.de.r...@rijksmuseum.nl ---
On second thought, I am widening the scope of this report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12872] Exclude some fields from Zebra indexing

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12872

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

Summary|Exclude limited number of   |Exclude some fields from
   |fields from Zebra indexing  |Zebra indexing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7308] new column in admin/aqbudgets

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7163] BibLibre acquisitions omnibus

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7163
Bug 7163 depends on bug 7308, which changed state.

Bug 7308 Summary: new column in admin/aqbudgets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8044] Localization for Perl scripts and modules

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904
Bug 11904 depends on bug 8044, which changed state.

Bug 8044 Summary: Localization for Perl scripts and modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11864] Show parent_orderline in received orders table

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11864

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11848] Make Koha::I18N easier to use

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11848
Bug 11848 depends on bug 8044, which changed state.

Bug 8044 Summary: Localization for Perl scripts and modules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12237] Remove the horrible hack in C4::Templates

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12237

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7372] RoadTypes should be folded into Authorised Values

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7372

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com ---
ping 3.16 and master RM.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12872] Exclude some fields from Zebra indexing

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12872

--- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 31528
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31528action=edit
Bug 12872: Unit tests for ZebraExclude preference

Test plan:
Run ZebraExclude.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12872] Exclude some fields from Zebra indexing

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12872

--- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 31529
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31529action=edit
Bug 12872: Db revision for ZebraExclude pref

Test plan:
Run install or upgrade. Check insertion of pref into database.
Check editing the value via interface.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12872] Exclude some fields from Zebra indexing

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12872

--- Comment #8 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 31527
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31527action=edit
Bug 12872: Exclude limited number of fields from Zebra indexing

This patch adds the use of preference ZebraExclude to rebuild_zebra.pl.
If that pref does not exist or is empty, behavior is unchanged.

The pref allows you to exclude fields, specific subfields, and even
field groups like 9XX from passing them to Zebra. The magic field XXX allows
you to skip a whole record while indexing; this is of course only
practical with a preceding specific condition.

The pref may contain multiple lines with their own conditions. A line may
start with a regex like /regex/:fieldlist. The regex is applied to the
marcxml. If it matches, the field excludes are processed.

Test plan:
The plan includes a few rebuilds. It may be practical to run this test on
a smaller test database.

[1a] Edit ZebraExclude syspref. Set it to 590, 952e
[1b] Edit a few records/items for these fields.
[1c] Rebuild the zebra index.
[1d] Check that info in 590 and 952e cannot be found in Zebra.

[2a] Edit ZebraExclude syspref. Set it to /_skip_/: XXX
[2b] Enter the _skip_ string into a few biblios (not in the same field).
[2c] Rebuild the zebra index.
[2d] Check that you cannot find these records in Zebra.

[3a] Edit ZebraExclude syspref. Set it to 9XX
[3b] Edit a few 9XX fields including some items (952).
[3c] Rebuild the zebra index.
[3d] Check that you cannot find 9XX info in Zebra.

[4 ] Enter some other value in the pref. Edit, rebuild and check.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12872] Exclude some fields from Zebra indexing

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12872

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #11 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Will still add some documentation in online help later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12872] Exclude some fields from Zebra indexing

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12872

--- Comment #12 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to M. de Rooy from comment #11)
 Will still add some documentation in online help later.

And still some POD in a follow-up for the module.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #31305|0   |1
is obsolete||

--- Comment #29 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 31530
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31530action=edit
Bug 11708: Add aqbasketgroups.closeddate

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #31306|0   |1
is obsolete||

--- Comment #30 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 31531
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31531action=edit
Bug 11708: Unit tests for aqbasketgroups.closeddate

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #31307|0   |1
is obsolete||

--- Comment #31 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 31532
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31532action=edit
Bug 11708: basketgroup.pl can now display basketgroups for all suppliers

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #31308|0   |1
is obsolete||

--- Comment #32 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 31533
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31533action=edit
Bug 11708: explicitly remove pagination

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #31309|0   |1
is obsolete||

--- Comment #33 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 31534
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31534action=edit
Bug 11708: All basketgroups on one page - several fixes

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10860] In-House Use

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860

--- Comment #41 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Katrin Fischer from comment #40)
 Hi Jonathan, reading through the description - can you explain some more
 about the use case for the cronjob and how it might be used in the library?

The script was for a specific need: The patrons cannot checkout specific items
(rares for instance). But they can checkout them for an in-house use (replace
this term with the one you prefer :)).
These items are stored in a special local (location).
At the end of the day, the items which have been checked out in-house are
marked in transit. But actually someone puts them back in the local, so they
are not in transit anymore. To avoid a manual action, this script simulates a
checkin. That's why you can specify a location in parameter of the script.

I did not remember the script was submitted here. I can remove it if someone
notes it's too specific.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12865] Text in payment box

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12865

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #1 from Marc Véron ve...@veron.ch ---
I followed the test cases and can confirm the behaviour.

If I put a note in paycollet.pl: Pay an amount toward all fines, it does not
display.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #31530|0   |1
is obsolete||

--- Comment #34 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 31535
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31535action=edit
Bug 11708: Add aqbasketgroups.closeddate

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #31532|0   |1
is obsolete||

--- Comment #36 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 31537
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31537action=edit
Bug 11708: basketgroup.pl can now display basketgroups for all suppliers

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #31531|0   |1
is obsolete||

--- Comment #35 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 31536
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31536action=edit
Bug 11708: Unit tests for aqbasketgroups.closeddate

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #31534|0   |1
is obsolete||

--- Comment #38 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 31539
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31539action=edit
Bug 11708: All basketgroups on one page - several fixes

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #31533|0   |1
is obsolete||

--- Comment #37 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 31538
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31538action=edit
Bug 11708: explicitly remove pagination

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10860] In-House Use

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860

--- Comment #42 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
The script sounds interesting, but maybe split it off to a separate bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #31535|0   |1
is obsolete||

--- Comment #39 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 31540
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31540action=edit
Bug 11708: Add aqbasketgroups.closeddate

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #31537|0   |1
is obsolete||

--- Comment #41 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 31542
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31542action=edit
Bug 11708: basketgroup.pl can now display basketgroups for all suppliers

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #31536|0   |1
is obsolete||

--- Comment #40 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 31541
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31541action=edit
Bug 11708: Unit tests for aqbasketgroups.closeddate

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #31538|0   |1
is obsolete||

--- Comment #42 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 31543
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31543action=edit
Bug 11708: explicitly remove pagination

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #31539|0   |1
is obsolete||

--- Comment #43 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 31544
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31544action=edit
Bug 11708: All basketgroups on one page - several fixes

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10860] In-House Use

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860

--- Comment #43 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Katrin Fischer from comment #42)
 The script sounds interesting, but maybe split it off to a separate bug?

I am not sure it could be useful in another context.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #44 from Julian Maurice julian.maur...@biblibre.com ---
Ok, took me a while to figure out why these patches didn't apply well on
sandbox.
I was using diff.noprefix=true git option, thinking it was just a cosmetic
option, but it also generate patches that don't apply well with git am.

The last patches should apply correctly everywhere now ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12865] Text in payment box

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12865

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6685] circ rules by groups of items

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6685

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 CC||olli-antti.kivila...@jns.fi

--- Comment #7 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
We normally use itype to calculate circulation rules, but needed a solution to
set some items to shorter circulation duration (shortloan SHLO) and some to
even more shorter (quickloan QILO).

So we made ccodes SHLO and QILO and set them in the C4-modules to their
respective durations when circulation rules were checked.

Obviously this is not a very good solution and I am looking for a way to
generalize that a bit so we could get that feature to master :)

Do you think giving items a new attribute, loan duration, which would
essentially give the normal circulation duration some variation, would work for
others as well?

Loan duration could be for ex short , quick , normal , long , epoch ,
forever.

Then in the cgi-bin/koha/admin/smart-rules.pl we could set the Loan period
for each of the available Loan durations.

So for DVD's with short duration period is 7days, normal is 14days , epoch is
28 days ...

Sounds fair?
Also should be some some flag about whether or not those durations can be
renewed/reserved?

How does it sound like?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12865] 'Pay amount toward all fines' does not record payment note

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12865

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

Summary|Text in payment box |'Pay amount toward all
   ||fines' does not record
   ||payment note

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6685] circ rules by groups of items

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6685

--- Comment #8 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Or we could allow setting circulation rules for itemtype and ccode, prefering
ccode if it is available?

So no longer having to choose itype or ccode?

Maybe giving ability to syspref whether to prefer ccode or itype.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12865] 'Pay amount toward all fines' does not record payment note

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12865

--- Comment #2 from Marc Véron ve...@veron.ch ---
Created attachment 31545
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31545action=edit
Bug 12865 - 'Pay amount toward all fines' does not record payment note

Without patch:
-
Make payment for patron who has fines
Select the Pay Amount button and add a note in the note box.
Select confirm
Result: The note does not display in list

With patch:
--
Result: The note displays in list
Bonus testing: The note is included in system logs as well (Home:Tools:Logs)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12865] 'Pay amount toward all fines' does not record payment note

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12865

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   Priority|P5 - low|P4
 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch
Version|3.14|master

--- Comment #3 from Marc Véron ve...@veron.ch ---
Original version was 3.14. 
Version set to master.
Setting priority to P3 because data is not properly recorded in database.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12909] New: item withdrawn is missing in inventory results

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12909

Bug ID: 12909
   Summary: item withdrawn is missing in inventory results
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: fridolyn.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

In inventory results, CSV or screen, the item withdrawn information is missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12909] item withdrawn is missing in inventory results

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12909

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |fridolyn.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12865] 'Pay amount toward all fines' does not record payment note

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12865

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12865] 'Pay amount toward all fines' does not record payment note

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12865

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #31545|0   |1
is obsolete||

--- Comment #4 from Owen Leonard oleon...@myacpl.org ---
Created attachment 31546
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31546action=edit
[SIGNED-OFF] Bug 12865 - 'Pay amount toward all fines' does not record payment
note

Without patch:
-
Make payment for patron who has fines
Select the Pay Amount button and add a note in the note box.
Select confirm
Result: The note does not display in list

With patch:
--
Result: The note displays in list
Bonus testing: The note is included in system logs as well (Home:Tools:Logs)

Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #31514|0   |1
is obsolete||

--- Comment #2 from Owen Leonard oleon...@myacpl.org ---
Created attachment 31547
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31547action=edit
[SIGNED-OFF] Bug 12904 - Force browser to load new javascript files after
upgrade

A common issue with Koha seems to be that the web browsers continue to
use cached js files after an upgrade. If we append the version as a
parameter, we can force the browser to update the javascript files.

Test Plan:
1) Apply this patch
2) Note that all javascript continues to function properly

Signed-off-by: Owen Leonard oleon...@myacpl.org

More complete test plan to confirm that caching is working correctly:

1) Apply this patch on a new branch based on master.
2) In a separate branch check out a previous version of Koha and go
   through the installation process on an empty database.
3) After logging into Koha, turn on Firebug's Net panel (or Chrome's
   Network panel) and turn on the filter for JavaScript files.
4) Clear the browser cache and navigate to a page, for instance
   Circulation. In Firebug the Net panel should show a status of 200
   OK for all files, indicating that the file was downloaded, not
   loaded from the cache. In Chrome the size column will show a file
   size if the file was downloaded.
5) Navigate to another page and confirm that scripts are being loaded
   from the cache: Scripts like jquery.js and jquery-ui.js which are
   loaded on every page should have a status in the Firebug Net panel of
   304 Not Modified. In Chrome the size columns should show from
   cache.
6) Check out the branch you created for testing this patch.
7) In order to preserve the state of your browser cache for accurate
   testing, open a different browser from the one you were previously
   testing with, load Koha, and run through the database update.
8) Return to your original testing browser and navigate to another Koha
   page. Firebug's Net panel should show that script files are now being
   downloaded with a koha_version query string. These files should
   have a status of 200 OK indicating that they are being downloaded,
   not loaded from the cache.
9) Navigate to another page and conifrm that the new versions of the
   scripts are being loaded from the cache.

To confirm that all affected JavaScripts links are working correctly,
test these pages by checking the Firebug Net panel for errors:

- Administration - Currencies and exchange rates
  (jquery.dataTables.colvis.js)
- Tools - Stage MARC records for import (ajaxfileupload.js) or another
  page which performs a file upload.
- Catalog - Detail page - MARC Preview (greybox JS)
- Help - Any help page
- Any page which loads DataTables (Circulation in the staff client, for
  instance, and a title's detail page in the OPAC)
- Bonus points if you check the various conditional JS includes
  controlled by the many OPAC feature preferences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3534] Patron quick add form

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #3 from Marc Véron ve...@veron.ch ---
There was a blog entry related to this bug using jQuery for a Patron quick add
form. As far I remember it was declared as proof of concept.
The link was: http://www.myacpl.org/koha/category/koha/customizations/
(Link not valid as of today)

I tested the jQuery code in early 2012 and re-tested it today with current
master by putting it into intranetuserjs system preference. It is not really a
solution for this enhancement request, but it still works nice. That's why I
put it here.

$(document).ready(function(){
var list = fieldset class=\rows\legendQuick Addol;
$(label.required).each(function(){
item = $(this).parent().html()
item = li+item+/li;
list += item;
});
list += /ol/fieldsetfieldset class=\action\input type=\submit\
value=\Save\ onclick=\return check_form_borrowers();\ name=\save\/a
href=\/cgi-bin/koha/members/member.pl\
class=\cancel\Cancel/a/fieldset;
$(#entryform).prepend(list);
});

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12910] New: Confirming a hold with branch transfer clears Return Date

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12910

Bug ID: 12910
   Summary: Confirming a hold with branch transfer clears Return
Date
 Change sponsored?: ---
   Product: Koha
   Version: 3.14
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When the SpecifyReturnDate syspref is enabled, the library should be able to
set a return data in returns.pl and check 'Remember for next check in:' All
subsequent returns should be checked in using that return date.

If an item is checked in which has a hold with a pick-up location other than
the check-in branch, a The 'Hold found' dialog appears. Clicking 'Confirm hold
and transfer' dismisses this dialog, but also clears the 'Specify return date'
field.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12910] Confirming a hold with branch transfer clears Return Date

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12910

--- Comment #1 from Barton Chittenden bar...@bywatersolutions.com ---
To replicate the problem

1) Set system preference 'SpecifyReturnDate' to 'Allow'
2) Check out item to Borrower A at Branch X
3) Place hold for this item for borrower B with pick-up location set to Branch
Y
   (I don't believe that it makes a difference whether the items is
biblio-level or item-level).)
4) Go to check-in screen
5) Set the 'Specify return date (MM/DD/)' to yesterday's date
6) Click 'Remember for next check in' check-box
7) Check the item in.
8) The 'Hold found' dialog appears. Click 'Confirm hold and transfer'

At this point, note that the return date has been cleared.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

--- Comment #3 from Owen Leonard oleon...@myacpl.org ---
I'm not sure how relevant this is, but running a performance audit from Chrome
Developer Tools gives this warning: Resources with a ? in the URL are not
cached by most proxy caching servers.

Digging into that issue led me to this:

http://www.stevesouders.com/blog/2008/08/23/revving-filenames-dont-use-querystring/

Sounds like there are Apache configuration options, for instance, to rewrite
file names for this purpose. I have no idea whether that fits into Koha's
upgrade process.

I think we should do a general audit on how we handle compression and caching
at the server level--preferably by someone who knows more about it than me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

--- Comment #24 from M. Tompsett mtomp...@hotmail.com ---
(In reply to Jonathan Druart from comment #21)
 This one is signed off and should be QA with 10900 and 10589.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589#c34
Hopefully this will clarify that process.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900

--- Comment #35 from M. Tompsett mtomp...@hotmail.com ---
See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589#c34 for how
this all relates piecewise to the other bugs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10762] Not able to adjust size of barcode numbers

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12865] 'Pay amount toward all fines' does not record payment note

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12865

--- Comment #5 from Owen Leonard oleon...@myacpl.org ---
(In reply to Marc Véron from comment #3)

 Setting priority to P3 because data is not properly recorded in database.

By the way, as far as I know priority settings are not taken into account in
the QA process. I think changing the severity (minor/normal/major/etc) is
preferred.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10860] In-House Use

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860

--- Comment #44 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I think I'd leave the script out for now and maybe add it later on.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12911] New: batch_id for new label batches can be assigned to several batches

2014-09-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Bug ID: 12911
   Summary: batch_id for new label batches can be assigned to
several batches
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: n...@quecheelibrary.org
QA Contact: testo...@bugs.koha-community.org

When adding a new label batch the MAX batch_id is retrieved from
creator_batches and incremented, however, the updated value is not saved until
new items are added to the batch.  

This means that if one library opens a new batch but does not add items before
another library opens the batch they will both be assigned the same batch
number

To recreate:
1 -In one browser window, go to tools-label creator and click the new batch
button
2 - Before adding items, open a new browser, and go tools-label creator and
click the new batch button
3 - Note that both batches have the same number listed
4 - Add an item to the first batch - you should now see one item in the batch
5 - Add an item to the second batch, you should see two items in the batch

I can also verify this happens pretty often in our shared system.


C4:Creators
44 sub new {
 45 my ($invocant) = shift;
 46 my $type = ref($invocant) || $invocant;
 47 my $self = {
 48 batch_id= 0,
 49 items   = [],
 50 branch_code = 'NB',
 51 batch_stat  = 0,   # False if any data has changed and the db
has not been updated
 52 @_,
 53 };
 54 my $sth = C4::Context-dbh-prepare(SELECT MAX(batch_id) FROM
creator_batches;);
 55 $sth-execute();
 56 my $batch_id = $sth-fetchrow_array;
 57 $self-{'batch_id'} = ++$batch_id unless $self-{'batch_id'} != 0; 
# this allows batch_id to be passed in for individual label printing
 58 bless ($self, $type);
 59 return $self;
 60 }
 61 
 62 sub add_item {
 63 my $self = shift;
 64 my $number = shift;
 65 ref($self) =~ m/C4::(.+)::.+$/;
 66 my $number_type = ($1 eq 'Patroncards' ? 'borrower_number' :
'item_number');
 67 my $query = INSERT INTO creator_batches (batch_id, $number_type,
branch_code, creator) VALUES (?,?,?,?);;
 68 my $sth = C4::Context-dbh-prepare($query);
 69 #$sth-{'TraceLevel'} = 3;
 70 $sth-execute($self-{'batch_id'}, $number, $self-{'branch_code'},
$1);
 71 if ($sth-err) {
 72 warn sprintf('Database returned the following error on attempted
INSERT: %s', $sth-errstr);
 73 return -1;
 74 }
 75 $query = SELECT max(label_id) FROM creator_batches WHERE batch_id=?
AND $number_type=? AND branch_code=?;;
 76 my $sth1 = C4::Context-dbh-prepare($query);
 77 $sth1-execute($self-{'batch_id'}, $number, $self-{'branch_code'});
 78 my $label_id = $sth1-fetchrow_array;
 79 push (@{$self-{'items'}}, {$number_type = $number, label_id =
$label_id});
 80 $self-{'batch_stat'} = 1;
 81 return 0;
 82 }

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >