[Koha-bugs] [Bug 11362] increase zebra AUTH register sizes, from 4G to 20G
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11362 --- Comment #4 from Mason James --- (In reply to Robin Sheat from comment #3) > Are there any negative effects to having a large index size? Probably not > that outweighs the disadvantages to having one that's too small... afaik, no - everything 'just works' as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13017] New: koha h1 tag on staff login
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017 Bug ID: 13017 Summary: koha h1 tag on staff login Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 31959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31959&action=edit koha h1 If you zoom out on the staff client you will see Koha to the far left (see attached). The code reads: http://koha-community.org";> Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13016] New: Add fine grace period by hour
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13016 Bug ID: 13016 Summary: Add fine grace period by hour Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: marjorie.barry-v...@ccsr.qc.ca QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com In fine rules, it will be fine to have possibility to add a grace period by hour when loan period is by hour. Regards, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13015] New: Language filter on search should take all languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13015 Bug ID: 13015 Summary: Language filter on search should take all languages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org All languages on this list http://www.loc.gov/standards/iso639-2/php/code_list.php work in the advanced search language filter system preference, but they do not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Magnus Enger changed: What|Removed |Added Attachment #31958|0 |1 is obsolete|| --- Comment #130 from Magnus Enger --- Comment on attachment 31958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31958 Bug 12920 - Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead just testing... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #129 from Magnus Enger --- Created attachment 31958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31958&action=edit Bug 12920 - Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead Per the new guidelines, AllowRenewalLimitOverride should not be referenced in circulation.pl or moremember.pl Test Plan: 1) Apply this patch 2) Go to circulation.pl 3) Ensure you can still override renewal limits with pref enabled 4) Ensure you can not override renewal limits with pref disabled 5) Go to moremember.pl 6) Repeat steps 3-4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8074] Define default library for holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074 Owen Leonard changed: What|Removed |Added CC||savitra.sir...@osslabs.biz --- Comment #9 from Owen Leonard --- *** Bug 6809 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6809] Add branch filter in holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6809 Owen Leonard changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 8074 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9528] Add delivery branch to the place hold display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9528 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9528] Add delivery branch to the place hold display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9528 Owen Leonard changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9528] Add delivery branch to the place hold display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9528 --- Comment #1 from Owen Leonard --- Created attachment 31957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31957&action=edit Bug 9528 - Add delivery branch to the place hold display When viewing the list of a patron's holds from the circulation or patron detail page the pickup library is not listed. This patch adds a column to the table of holds which shows the pickup branch. This patch also removes some unnecessary markup from the generation of the table and corrects an instance where the term "reserve" was used instead of "hold." This patch also modifies the language describing an item which is marked waiting at the current library: "Item is waiting here" instead of "Item waiting." To test, add several holds to a patron's account with various pickup locations. - Confirm that those pickup locations are correctly displayed under the Holds tab in Circulation. - Check in and confirm a hold which is to be picked up at the current branch. Confirm that the revised language appears. - Confirm that table sorting works correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Paola Rossi changed: What|Removed |Added Attachment #31882|0 |1 is obsolete|| --- Comment #6 from Paola Rossi --- Created attachment 31956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31956&action=edit Bug 12970: Cancelled orders -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Paola Rossi changed: What|Removed |Added Attachment #31881|0 |1 is obsolete|| --- Comment #5 from Paola Rossi --- Created attachment 31955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31955&action=edit Bug 12970: Format totals -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Paola Rossi changed: What|Removed |Added Attachment #31747|0 |1 is obsolete|| --- Comment #4 from Paola Rossi --- Created attachment 31954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31954&action=edit Bug 12970: Use the centralize VAT and prices calculation - basket.pl I've applied the 3 patches against master 3.17.00.025 Firstly I've applied: 5342 (2), 12852 (3), 12844 (4), 12830 (2), 12896 (1), 12969 (2) Everything is OK. So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 Paola Rossi changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||paola.ro...@cineca.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Jonathan Druart changed: What|Removed |Added Attachment #31944|0 |1 is obsolete|| --- Comment #21 from Jonathan Druart --- Created attachment 31953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31953&action=edit Bug 12627: Fix default values The default value for *by and *date fields is NULL. But without this patch, the values are 0 or -00-00. It comes from the fact that the form set to an empty string the values and DBIX::Class does not consider them as undefined. This patch is very ugly, not sure how we can fix that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10912] Streamline hold error messages in staff interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #15 from Owen Leonard --- I tried to come up with a testing plan which matched Nora's description of their situation: I set up a Circulation and Fine rule for a Itemtype A at Branch A which set the hold limit to zero. Logged in to Branch A I attempted to place a hold on a title with items of Itemtype A and from Branch A for a patron from Branch A. In master the message I get is: Cannot place hold Too many holds: Fernando De la Cruz has too many holds. No items are available to be placed on hold After applying the patch I get this error: Cannot place hold Too many holds: Fernando De la Cruz has too many holds. It looks to me like the wrong one of the two error messages was removed. Of course I may be testing this incorrectly. I still don't understand what the "Disable AllowOnShelfHolds" step is for in the test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #3 from Jonathan Druart --- Created attachment 31952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31952&action=edit Bug 13014: Notify budget owner on new suggestion - cronjob Test plan: 0/ Create a new notice suggestions > TO_PROCESS You can use the one defined in the other patch. 1/ Create a suggestion and link it to a fund 2/ Add a owner to this fund and make sure this patron has an email address (the email address used should be the one defined in the AutoEmailPrimaryAddress syspref). 3/ Execute the cronjob script with the -v and without the -c argument 4/ The output should tell you that an email will be sent 5/ Execute the cronjob script with the -v and with the -c argument 6/ Verify the notice is generated in the message_queue table and it is correctly formatted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #1 from Jonathan Druart --- Created attachment 31950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31950&action=edit Bug 13014: Notify budget owner on new suggestion - UT When a suggestion is created and linked to a fund, a mail will be generated, using a cronjob, to notify the budget owner. A suggestion is considered as "can be treated" if its status is "ASKED". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #2 from Jonathan Druart --- Created attachment 31951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31951&action=edit Bug 13014: Notify budget owner on new suggestion - sample notices This patch add the new notice suggestion > TO_PROCESS Others will be added when the patch will be signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13007] suggestions.budgetid should be a foreign key
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13007 Jonathan Druart changed: What|Removed |Added Blocks||13014 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Depends on||13007 Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] New: Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Bug ID: 13014 Summary: Sent an email to budget owner when a suggestion can be treated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@biblibre.com QA Contact: testo...@bugs.koha-community.org When a suggestion is created and linked to a fund, it could be great to notify the budget owner. A cronjob will be developed in order to generate an email going to the budget owner. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10960] Holds Queue Report display loc code not description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10960 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10960] Holds Queue Report display loc code not description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10960 --- Comment #1 from Owen Leonard --- Created attachment 31949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31949&action=edit Bug 10960 - Holds Queue Report display loc code not description The holds queue report shows codes for item shelving location and for library transfer location. This patch adds template plugin handling of both these fields to display their full description. To test, make sure you have one or more items in your holds queue which have a shelving location. Rebuild your holds queue if necessary and view it. Items which have a shelving location should show the description instead of the code. The "send to" column should show the library name instead of code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10960] Holds Queue Report display loc code not description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10960 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Jonathan Druart changed: What|Removed |Added Attachment #31942|0 |1 is obsolete|| --- Comment #20 from Jonathan Druart --- Created attachment 31948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31948&action=edit Bug 12627: Bug 12627: Fix default values - TT changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12979] Price formatting should only be defined at one place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 Paola Rossi changed: What|Removed |Added Attachment #31936|0 |1 is obsolete|| --- Comment #6 from Paola Rossi --- Created attachment 31947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31947&action=edit Bug 12979: Fix error on layout3pagesfr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12979] Price formatting should only be defined at one place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 Paola Rossi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10960] Holds Queue Report display loc code not description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10960 Owen Leonard changed: What|Removed |Added Version|3.12|master Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #7 from Owen Leonard --- (In reply to Kyle M Hall from comment #3) > Test plan: > 1) Enable item level itemtypes > 2) Create two records with one item each of a given itemtype > 3) Create a single issuing rule and limit the holds allowed for that >itemtype to 1 > 4) Place a record level hold on your first record > 5) Attempt to place a record level hold for the same patron on your >second record. You should not be able to but you can! > 6) Apply this patch > 7) Repeat step 5, note you can no longer place the hold! This isn't working for me. I've created a circulation rule which limits the itemtype to one hold. I've confirmed that the two records I'm testing with have no biblio-level item type. When I try to place each title on hold for the same patron I'm not prevented from placing the second. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12979] Price formatting should only be defined at one place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 Paola Rossi changed: What|Removed |Added Attachment #31829|0 |1 is obsolete|| --- Comment #5 from Paola Rossi --- Created attachment 31946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31946&action=edit Bug 12979: Price formatting should only be defined at one place I've applied against 3.17.00.025 >>git grep Number::Format 1) C4/Installer/PerlDependencies.pm:'Number::Format' => { 2) Koha/Number/Price.pm:use Number::Format qw( format_price ); 3) Koha/Number/Price.pm: return Number::Format->new(%$format_params)->format_price($self->value); 4) Koha/Number/Price.pm: return Number::Format->new(%$format_params)->unformat_number($self->value); 5) t/Number/Price.t:# How put the symbol at the end with Number::Format? Everything is OK. I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13005] suggestions.budgetid should be NULL if not filled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13005 Jonathan Druart changed: What|Removed |Added Blocks|13007 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12831] local only logins should still work when ldap authentication is enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831 --- Comment #6 from Martin Renvoize --- Do either of your fancy doing that followup, then I can proceed further with QA? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13007] suggestions.budgetid should be a foreign key
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13007 --- Comment #2 from Jonathan Druart --- *** Bug 13005 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13007] suggestions.budgetid should be a foreign key
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13007 Bug 13007 depends on bug 13005, which changed state. Bug 13005 Summary: suggestions.budgetid should be NULL if not filled http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13005 What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13007] suggestions.budgetid should be a foreign key
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13007 Jonathan Druart changed: What|Removed |Added Attachment #31924|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 31945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31945&action=edit Bug 13007: Add a foreign key for suggestions.budgetid The DB field suggestions.budgetid should be linked to aqbudgets.budget_id. If the fund is removed, this column should be set to NULL. Test plan: 0/ Verify it is not possible to create an suggestion not linked to a fund via the Koha interface. 1/ Using your SQL CLI (or equivalent), create or update 1+ suggestions and set "0" in the budgetid field. 2/ Execute the updatedabase script. 3/ Verify that your suggestion is unlinked to the nonexistent fund. 4/ Verify the constraint has correctly been added (show create table suggestions). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Jonathan Druart changed: What|Removed |Added Blocks||13007 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13007] suggestions.budgetid should be a foreign key
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13007 Jonathan Druart changed: What|Removed |Added Depends on|13005 |12627 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13005] suggestions.budgetid should be NULL if not filled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13005 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Jonathan Druart --- Will be fixed by bug 13007. *** This bug has been marked as a duplicate of bug 13007 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13013] New: Selecting too many items in a batch hold operation triggers a strange error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13013 Bug ID: 13013 Summary: Selecting too many items in a batch hold operation triggers a strange error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org If I select multiple titles from the OPAC's search results screen--enough that I exceed the limit on the number of holds I can place--I get an error message on the place hold screen, " Sorry, you can only place 10 more holds. Please uncheck the checkboxes for the items you wish to not place holds on. " However, if I *don't* uncheck some checkboxes and simply submit the form anyway I get a page with this error message: "ERROR: Internal error: incomplete hold request." At this point I've lost my original selections and don't have a clear path back to make corrections. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Jonathan Druart changed: What|Removed |Added Attachment #31941|0 |1 is obsolete|| --- Comment #19 from Jonathan Druart --- Created attachment 31944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31944&action=edit Bug 12627: Fix default values The default value for *by and *date fields is NULL. But without this patch, the values are 0 or -00-00. It comes from the fact that the form set to an empty string the values and DBIX::Class does not consider them as undefined. This patch is very ugly, not sure how we can fix that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12959] Check in forgets to remember arbitrary backdating of returns setting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12959 Kyle M Hall changed: What|Removed |Added Attachment #31718|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 31943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31943&action=edit Bug 12959 - Check in forgets to remember arbitrary backdating of returns setting Whenever a librarian is prompted with a form during the checking process ( hold to fill, transfer, etc ) the date to backdate returns to is forgotten! Test Plan: 1) Begin returning items with a remembered backdate 2) Check in an item that need transfered or has a hold 3) Complete the action requested 4) Note your set return date is now lost 5) Apply this patch 6) Repeat steps 1-3 7) Note your backdate is now remembered! Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13012] suggestion.suggesteddate should be set to NOW if not defined
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13012 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|jonathan.dru...@biblibre.co |gmcha...@gmail.com |m | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Signed Off CC||jonathan.dru...@biblibre.co ||m Assignee|yohann.duf...@biblibre.com |jonathan.dru...@biblibre.co ||m --- Comment #18 from Jonathan Druart --- Last 5 patches need to be QAed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 --- Comment #17 from Jonathan Druart --- Created attachment 31942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31942&action=edit Bug 12627: Bug 12627: Fix default values - TT changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Jonathan Druart changed: What|Removed |Added Attachment #31940|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart --- Created attachment 31941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31941&action=edit Bug 12627: Fix default values The default value for *by and *date fields is NULL. But without this patch, the values are 0 or -00-00. It comes from the fact that the form set to an empty string the values and DBIX::Class does not consider them as undefined. This patch is very ugly, not sure how we can fix that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13012] suggestion.suggesteddate should be set to NOW if not defined
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13012 --- Comment #1 from Jonathan Druart --- Which is not possible. We should make this field a timestamp instead of a date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13012] New: suggestion.suggesteddate should be set to NOW if not defined
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13012 Bug ID: 13012 Summary: suggestion.suggesteddate should be set to NOW if not defined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: jonathan.dru...@biblibre.com QA Contact: testo...@bugs.koha-community.org Bug 11391 remove the default value 0 for the suggesteddate. Actually it should be NOW. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13012] suggestion.suggesteddate should be set to NOW if not defined
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13012 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Depends on||11391 Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11391] suggestions.suggesteddate has a problematic default value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11391 Jonathan Druart changed: What|Removed |Added Blocks||13012 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Jonathan Druart changed: What|Removed |Added Attachment #31939|0 |1 is obsolete|| --- Comment #15 from Jonathan Druart --- Created attachment 31940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31940&action=edit Bug 12627: Fix default values The default value for *by and *date fields is NULL. But without this patch, the values are 0 or -00-00. It comes from the fact that the form set to an empty string the values and DBIX::Class does not consider them as undefined. This patch is very ugly, not sure how we can fix that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 --- Comment #14 from Jonathan Druart --- Created attachment 31939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31939&action=edit Bug 12627: Fix default values The default value for *by and *date fields is NULL. But without this patch, the values are 0 or -00-00. It comes from the fact that the form set to an empty string the values and DBIX::Class does not consider them as undefined. This patch is very ugly, not sure how we can fix that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13011] Parsing a date on sending a letter generates a warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13011 --- Comment #2 from Jonathan Druart --- Created attachment 31938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31938&action=edit Bug 13011: -00-00 should not be considered as a valid date When parsing the letter content, the -00-00 should not be replaced, it's not a valid date. Test plan: prove t/db_dependent/Suggestions.t should not return the following error: -00-00 seems to be a date but an error occurs on generating it (The 'month' parameter ("0") to DateTime::new did not pass the 'an integer between 1 and 12' callback -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13011] Parsing a date on sending a letter generates a warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13011 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13011] Parsing a date on sending a letter generates a warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13011 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Depends on||11244 Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m --- Comment #1 from Jonathan Druart --- Introduced by bug 11244. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11244] notices ignoring the dateformat preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Jonathan Druart changed: What|Removed |Added Blocks||13011 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13011] New: Parsing a date on sending a letter generates a warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13011 Bug ID: 13011 Summary: Parsing a date on sending a letter generates a warning Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: jonathan.dru...@biblibre.com QA Contact: testo...@bugs.koha-community.org -00-00 seems to be a date but an error occurs on generating it (The 'month' parameter ("0") to DateTime::new did not pass the 'an integer between 1 and 12' callback at /usr/lib/i386-linux-gnu/perl5/5.20/DateTime.pm line 195. DateTime::new(undef, "month", 0, "day", 01, "year", 1900, "time_zone", "Europe/Paris", ...) called at /usr/share/perl5/DateTime/Format/DateParse.pm line 60 DateTime::Format::DateParse::parse_datetime("DateTime::Format::DateParse", "/01/00", "Europe/Paris") called at Koha/DateUtils.pm line 87 Koha::DateUtils::dt_from_string("-00-00") called at C4/Letters.pm line 639 eval {...} called at C4/Letters.pm line 638 C4::Letters::_parseletter(HASH(0xbf97e78), "suggestions", HASH(0xbf8e39c)) called at C4/Letters.pm line 550 C4::Letters::_substitute_tables(HASH(0xbf97e78), HASH(0xbf8c0b4)) called at C4/Letters.pm line 497 C4::Letters::GetPreparedLetter("module", "suggestions", "letter_code", "CHECKED", "branchcode", undef, "tables", HASH(0xbf8c0b4)) called at C4/Suggestions.pm line 454 C4::Suggestions::ModSuggestion(HASH(0xbf9ac58)) called at t/db_dependent/Suggestions.t line 119 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 --- Comment #13 from Jonathan Druart --- Created attachment 31937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31937&action=edit Bug 12627: Fix date management C4::Dates->today returns a string formatted depending on the dateformat syspref. Before the original patch, SQLHelper managed both format (string formatted and DateTime. Now DBIX::Class only manages DateTime, so the call to NewSuggestion and ModSuggestion should pass a DateTime object -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #250 from Jonathan Druart --- (In reply to Martin Renvoize from comment #249) > PS: Only 'passed' in bugzilla status, Jonathan will add the signoff line in > the patches for me. This is to 'keep it simple' regarding conflicts and > re-basing :) Done, signed-off-by line added on 29 patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #249 from Martin Renvoize --- Happy to Passed QA. In my extensive testing I could not find any regressions, and the code all comes up to scratch passing qa script and tests all still pass. We still need the unit tests, but as Tomas/Galen promised to get onto these, I don't see them holding up QA on this part of the proceedings. Jonathan, IRC Gang and I all chatted about utf8_mb4 and we ended up realising that Squeeze still ships with a mysql version over 4 yeras old and so does not support the _mb4 encoding. I don't feel there is enough benefit to be had from mb4 to ask Jonathan to add a followup with code to decide encoding based upon distrobution. (Though I'd love to see this some time, and would suggest opening a followup bug to track it) Fantastic work all involved! PS: Only 'passed' in bugzilla status, Jonathan will add the signoff line in the patches for me. This is to 'keep it simple' regarding conflicts and re-basing :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12979] Price formatting should only be defined at one place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 --- Comment #4 from Jonathan Druart --- Good catch Paola! Stupid error, it is fixed in the last patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12979] Price formatting should only be defined at one place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 --- Comment #3 from Jonathan Druart --- Created attachment 31936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31936&action=edit Bug 12979: Fix error on layout3pagesfr The format method was not called. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12979] Price formatting should only be defined at one place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/