[Koha-bugs] [Bug 13110] New: News needs a Read More option
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13110 Bug ID: 13110 Summary: News needs a Read More option Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcha...@gmail.com Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org It would be great if News allowed the insertion of a READ MORE tag/link so that if you have a lengthy article, it doesn't have to take up a lot of room on the Koha main page or in the main page of the OPAC. Christopher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11023] Toggle new status for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Failed QA
CC||k...@bywatersolutions.com
--- Comment #56 from Kyle M Hall ---
I'm getting failed unit tests:
prove -v t/db_dependent/Circulation.t
t/db_dependent/Circulation.t ..
1..55
ok 1 - use C4::Circulation;
ok 2 - CircControl changed to PickupLibrary
ok 3 - _GetCircControlBranch returned item branch (no userenv defined)
ok 4 - CircControl changed to PatronLibrary
ok 5 - _GetCircControlBranch returned borrower branch
ok 6 - CircControl changed to ItemHomeLibrary
ok 7 - _GetCircControlBranch returned item branch
ok 8 - userenv set
ok 9 - CircControl changed to PickupLibrary
ok 10 - _GetCircControlBranch returned current branch
ok 11 - CircControl changed to PatronLibrary
ok 12 - _GetCircControlBranch returned borrower branch
ok 13 - CircControl changed to ItemHomeLibrary
ok 14 - _GetCircControlBranch returned item branch
ok 15 - CircControl reset to its initial value
ok 16 - ProcessOfflinePayment makes payment correctly
ok 17 - Item 1 checked out, due date: 2014-11-03T23:59:00
ok 18 - Item 2 checked out, due date: 2014-11-03T23:59:00
ok 19 - Item checked out to John Renewal
ok 20 - Can renew, no holds for this title or item
ok 21 - (Bug 10663) Cannot renew, reserved
ok 22 - (Bug 10663) Cannot renew, reserved (returned error is on_reserve)
ok 23 - (Bug 10663) Cannot renew, reserved
ok 24 - (Bug 10663) Cannot renew, reserved (returned error is on_reserve)
ok 25 - hold marked completed when checking out item that fills it
ok 26 - (Bug 10663) Cannot renew, item reserved
ok 27 - (Bug 10663) Cannot renew, item reserved (returned error is on_reserve)
ok 28 - Can renew item 2, item-level hold is on item 1
ok 29 - Can renew, item is marked not for loan, hold does not block
Can't use string ("1") as a HASH ref while "strict refs" in use at
C4/Circulation.pm line 1187.
# Looks like you planned 55 tests but ran 29.
# Looks like your test exited with 255 just after 29.
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 26/55 subtests
Test Summary Report
---
t/db_dependent/Circulation.t (Wstat: 65280 Tests: 29 Failed: 0)
Non-zero exit status: 255
Parse errors: Bad plan. You planned 55 tests but ran 29.
Files=1, Tests=29, 3 wallclock secs ( 0.01 usr 0.01 sys + 1.12 cusr 0.05
csys = 1.19 CPU)
Result: FAIL
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13104] Changing date or time format on a production server will create duplicate fines!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Kyle M Hall changed: What|Removed |Added Attachment #32499|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 32519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32519&action=edit Bug 13104 - Changing date or time format on a production server will create duplicate fines! The system preference TimeFormat decides if times are formatted in 24 hour or 12 hour format. The issue at hand is that this changes the time description for fines. Let us assume the time format is currently 24 hour, and there are overdue items with accruing fines. When the format is changed to 12 hour, and fines.pl is run, it will begin looking for fines with a 12 hour format. Since there are no, it will create a new fine and you will now have two fines for the same item! There are solutions which require database manipulation: 1) Update all existing fines from 24 hour to 12 hour format 2) Delete all existing accruing fines so they are all regenerated the following night The same situation applies to DateFormat. The accounts rewrite ( Bug 6427 ) will resolve this issue, as it does not look for existing fines based on the description. I believe the best course of action until bug 6427 is pushed to master is to add a warning to the system preference to not alter it on a production server with existing fines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13109] New: Serial failure for received and general viewing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Bug ID: 13109 Summary: Serial failure for received and general viewing Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: librar...@sasaki.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com For Log Magazine, also still an issue for Sports Business Journal Received the following message Software error: Usage: Date::Calc::Delta_Days(year1, month1, day1, year2, month2, day2) at /usr/share/koha/lib/C4/Serials.pm line 2379. For help, please send mail to the webmaster (st...@bywatersolutions.com), giving this error message and the time and date of the error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13104] Changing date or time format on a production server will create duplicate fines!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 --- Comment #2 from Kyle M Hall --- When I filed the patch, I did not think about the fact that DateFormat has the same effect. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13108] Members are restricted even if the debarment is ended - opac-reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13108 Fridolin SOMERS changed: What|Removed |Added Patch complexity|--- |Trivial patch Assignee|koha-b...@lists.koha-commun |fridolyn.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13107] Members are restricted even if the debarment is ended - opac-user
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13107 Fridolin SOMERS changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |fridolyn.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13108] Members are restricted even if the debarment is ended - opac-reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13108 Fridolin SOMERS changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13108] Members are restricted even if the debarment is ended - opac-reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13108 --- Comment #1 from Fridolin SOMERS --- Created attachment 32518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32518&action=edit Bug 13108 - Members are restricted even if the debarment is ended - opac-reserve This is the same issue as bug 12134. Test Plan: 1) Add a manual restriction to a patron with expiration date in the past 2) Go on the OPAC and connect 3) Try to add an hold on a record (opac-reserve.pl) 3) Note the warning message "Sorry, you cannot place holds because your account has been frozen ..." 4) Apply this patch 5) Repeat step 2 6) Note the warning message does not appear anymore -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12134] Members are restricted even if the debarment is ended
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Fridolin SOMERS changed: What|Removed |Added Blocks||13108 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12292] Members are restricted even if the debarment is ended - moremember.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12292 Fridolin SOMERS changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13108 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13108] Members are restricted even if the debarment is ended - opac-reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13108 Fridolin SOMERS changed: What|Removed |Added Depends on||12134 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13108] Members are restricted even if the debarment is ended - opac-reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13108 Fridolin SOMERS changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13107 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13108] Members are restricted even if the debarment is ended - opac-reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13108 Fridolin SOMERS changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12292 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13107] Members are restricted even if the debarment is ended - opac-user
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13107 Fridolin SOMERS changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13108 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13108] New: Members are restricted even if the debarment is ended - opac-reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13108 Bug ID: 13108 Summary: Members are restricted even if the debarment is ended - opac-reserve Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: fridolyn.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Same issue as bug 12134 on the opac/opac-reserve.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13107] Members are restricted even if the debarment is ended - opac-user
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13107 Fridolin SOMERS changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13107] Members are restricted even if the debarment is ended - opac-user
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13107 --- Comment #1 from Fridolin SOMERS --- Created attachment 32517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32517&action=edit Bug 13107 - Members are restricted even if the debarment is ended - opac-user This is the same issue as bug 12134. Test Plan: 1) Add a manual restriction to a patron with expiration date in the past. 2) Go on the OPAC and connect (opac-user.pl) 3) Note the warning message "Your account has been frozen until until XX/XX/ ..." 4) Apply this patch 5) Repeat step 2 6) Note the warning message does not appear anymore -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13107] Members are restricted even if the debarment is ended - opac-user
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13107 Fridolin SOMERS changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12292] Members are restricted even if the debarment is ended - moremember.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12292 Fridolin SOMERS changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13107 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13107] Members are restricted even if the debarment is ended - opac-user
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13107 Fridolin SOMERS changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12292 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12134] Members are restricted even if the debarment is ended
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Fridolin SOMERS changed: What|Removed |Added Blocks||13107 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13107] Members are restricted even if the debarment is ended - opac-user
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13107 Fridolin SOMERS changed: What|Removed |Added Depends on||12134 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13107] New: Members are restricted even if the debarment is ended - opac-user
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13107 Bug ID: 13107 Summary: Members are restricted even if the debarment is ended - opac-user Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: fridolyn.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Same issue as bug 12134 on the opac/opac-user.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13104] Changing date or time format on a production server will create duplicate fines!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Kyle M Hall changed: What|Removed |Added Summary|Changing TimeFormat on a|Changing date or time |production server will |format on a production |create duplicate fines! |server will create ||duplicate fines! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12872] Exclude some fields from Zebra indexing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12872 Paola Rossi changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||paola.ro...@cineca.it --- Comment #13 from Paola Rossi --- I've applied against master 3.17.00.027 Two patches need trivial rebasing. I pass the patch to "Patch doesn't apply" status. Some problems about "any" index (searching by keyword index). For example if the subfields 999c/999d exists in a record. In intranet, if I searched the biblionumber (=value of the number in the 2 subfields) by keyword index (on advanced search) or entering search keywords on the simple search, I found that record even if the "ZebraExclude" syspref has been set to 999. I found that record by sn index too, even if the "ZebraExclude" syspref has been set to 999. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12801] Koha::Calendar is caching holidays for the wrong branch!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12801 Brendan Gallagher changed: What|Removed |Added Attachment #31075|0 |1 is obsolete|| CC||bren...@bywatersolutions.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12801] Koha::Calendar is caching holidays for the wrong branch!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12801 --- Comment #14 from Brendan Gallagher --- Created attachment 32516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32516&action=edit Bug 12801: Use the branchcode to cache holidays Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12801] Koha::Calendar is caching holidays for the wrong branch!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12801 --- Comment #12 from Brendan Gallagher --- Created attachment 32514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32514&action=edit Bug 10126: (qa followup) fix tests It seems the removal of global variables changes the behaviour of Test::MockModule, and it now expects the namespace in front of the statically called method. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12801] Koha::Calendar is caching holidays for the wrong branch!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12801 Brendan Gallagher changed: What|Removed |Added Attachment #31052|0 |1 is obsolete|| --- Comment #13 from Brendan Gallagher --- Created attachment 32515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32515&action=edit Bug 12801 - Unit Test Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12801] Koha::Calendar is caching holidays for the wrong branch!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12801 Brendan Gallagher changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8836] Resurrect Rotating Collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Cindy Murdock Ames changed: What|Removed |Added CC||cmurd...@ccfls.org --- Comment #56 from Cindy Murdock Ames --- I tried applying attachment 32361, and I got this error: Applying: Bug 8836 - Resurrect Rotating Collections error: patch failed: installer/data/mysql/updatedatabase.pl:8800 error: installer/data/mysql/updatedatabase.pl: patch does not apply Patch failed at 0001 Bug 8836 - Resurrect Rotating Collections -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall changed: What|Removed |Added Attachment #32401|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 32513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32513&action=edit Bug 13023 - Nonpublic note for items should be mapped to a database column like itemnotes An item's public notes are mapped to a db column, but the librarian only notes are not. We need to map these so in the future we may display them in places other than the editor. Test Plan: 1) Create an item with a non-public note 2) Apply this patch 3) Run updatedatabase 4) Update your frameworks to map your nonpublic item note to items.itemnotes_nonpublic 5) Run misc/batchRebuildItemsTables.pl 6) Inspect the database, note that your non-public note is now in items.itemnotes_nonpublic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11399] batch Rebuild Items Tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399 Kyle M Hall changed: What|Removed |Added Blocks||13023 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Kyle M Hall changed: What|Removed |Added Depends on||11399 --- Comment #7 from Kyle M Hall --- I've discovered bug 11399 has a much better implementation for updating items. I will be removing my script from this patch and adding that bug as a dependency. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11399] batch Rebuild Items Tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #11 from Kyle M Hall --- Note, I found it a bit confusing that a test run required both -t *and* -c. I would expect each to be independent, and use of both would be the same as -t alone. However, we have no formal guidelines for this yet, so I do not feel it is proper to fail qa on this point. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11399] batch Rebuild Items Tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11399] batch Rebuild Items Tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399
Kyle M Hall changed:
What|Removed |Added
Attachment #29156|0 |1
is obsolete||
Attachment #31518|0 |1
is obsolete||
--- Comment #9 from Kyle M Hall ---
Created attachment 32511
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32511&action=edit
[PASSED QA] Bug 11399: batch Rebuild Items Tables
You can/must use it when you change items mapping.
this script rebuilds the non-MARC DB items table from the MARC values
usage : batchRebuildItemsTables.pl [ -h ][ -c ][ -t ][ -where ]
Options:
-h --help (or without arguments) shows this help message
-c Confirm: rebuild non marc DB (may be long)
-t test only, change nothing in DB
--where add where condition on default query
(eg. -where 'biblio.biblionumber<100')
(copied test plan)
to test it :
create a test item (eg on biblionumber 3) with a non mapped subfield with a
test value.
check real items DB row ( SELECT * from items where biblionumber=3 ) => non
mapped value is in more_subfields_xml
map the non mapped subfield with unused items column
re-check in Db that nothing changes
run ./batchRebuildItemsTables.pl -c --where 'biblio.biblionumber=3'
check real items DB row ( SELECT * from items where biblionumber=3 ) => new
mapped value is not in more_subfields_xml anymore but in the mapped column
Signed-off-by: Bernardo Gonzalez Kriegel
Work as described, no koha-qa errors.
Add a new item to record, save with value in unmapped subfield ('x')
Change mapping, run script, value on newly mapped column
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11399] batch Rebuild Items Tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399 --- Comment #10 from Kyle M Hall --- Created attachment 32512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32512&action=edit [PASSED QA] Bug 11399: QA fixes Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up language="javascript"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 --- Comment #14 from Kyle M Hall --- Created attachment 32509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32509&action=edit [PASSED QA] Bug 12862: OPAC bootstrap - clean up language="javascript" There was a
[Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up language="javascript"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up language="javascript"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 --- Comment #15 from Kyle M Hall --- Created attachment 32510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32510&action=edit [PASSED QA] Bug 12862: CCSR and Prog - language="javascript" is obsolete. Corrected/removed the obsolete HTML. Fixed a hard coded opac-tmpl, as per koha-qa's demand. Trigger all the templates and check of the language="javascript" error is listed in the validation done by the HTML Validator plugin for FireFox that Owen pointed me at. TEST PLAN - 1) Test with opactheme set to ccsr. Any opac page with opac-bottom.inc will do. 2) Test with opactheme set to prog. - Any opac page with opac-bottom.inc - Any opac page with doc-head-close.inc - Advanced search - Authority search -> Submit -> View full heading -> MARC View - staff client, home, serials, submit by the title text box, click one of the subscriptions (you don't have subscriptions?! can't help you), determine the biblionumber, opac, search for the biblio number and get to an opac details page, click on more details 3) Test the self-checkout printslip, just like the bootstrap one previously. Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up language="javascript"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 Kyle M Hall changed: What|Removed |Added Attachment #32186|0 |1 is obsolete|| Attachment #32187|0 |1 is obsolete|| Attachment #32188|0 |1 is obsolete|| --- Comment #13 from Kyle M Hall --- Created attachment 32508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32508&action=edit [PASSED QA] Bug 12862: Staff client tweaks related to obsolete language="javascript" As a result, this patch removed the deprecated tag from the intranet templates. And since there was just 1 other tiny error in the same template file, the checked="checked" was removed from a text box. TEST PLAN - 1) Install the HTML Validator 0.9.5.8 for FireFox. 2) Open Intranet to Home -> Tools -> News 3) View Page Source -- you'll notice the message about language="javascript" being one of the error messages. 4) Click Edit beside one of the news items. 5) View Page Source -- you'll notice the message about language="javascript" being one of the error messages. 6) Apply patch 7) Repeat steps 2 to 5 without "language="javascript" related error messages. 8) Run koha QA test tools. Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12914] Wrong message 'Patron(..) is blocked for 2014-09-30 day(s).
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 --- Comment #17 from Kyle M Hall --- Looks good! I was also looking in the wrong place when I marked as failed qa. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13106] Encapsulate Circulation::GetAgeRestriction() and modify it to check borrowers age as well.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13106 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 32507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32507&action=edit Bug 13106 - Encapsulate Circulation::GetAgeRestriction() and modify it to check borrowers age as well. This patch moves the logic of deciding whether or not a borrower is old enough to access this material to its own function GetAgeRestriction. This makes it easier to use AgeRestriction elsewhere, like with placing holds. Unit tests included. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12914] Wrong message 'Patron(..) is blocked for 2014-09-30 day(s).
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Kyle M Hall changed: What|Removed |Added Attachment #32323|0 |1 is obsolete|| --- Comment #16 from Kyle M Hall --- Created attachment 32506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32506&action=edit [PASSED QA] Bug 12914 - Wrong message 'Patron(..) is blocked for 2014-09-30 day(s). The message in circulation.tt assumed to get days but date is given. Updated comments and message depending on expiration date or no expiration of restriction. The message shows up on top of Bug 643 Allow override of 'debarred' status if a patron has a restriction. Replaced date_format with date template (see comment #6) Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12914] Wrong message 'Patron(..) is blocked for 2014-09-30 day(s).
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13106] Encapsulate Circulation::GetAgeRestriction() and modify it to check borrowers age as well.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13106 Olli-Antti Kivilahti changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13106] Encapsulate Circulation::GetAgeRestriction() and modify it to check borrowers age as well.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13106 Olli-Antti Kivilahti changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11630 Assignee|koha-b...@lists.koha-commun |olli-antti.kivila...@jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13106] New: Encapsulate Circulation::GetAgeRestriction() and modify it to check borrowers age as well.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13106 Bug ID: 13106 Summary: Encapsulate Circulation::GetAgeRestriction() and modify it to check borrowers age as well. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: olli-antti.kivila...@jns.fi QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com This patch moves the logic of deciding whether or not a borrower is old enough to access this material to its own function GetAgeRestriction. This makes it easier to use AgeRestriction elsewhere, like with placing holds. Unit tests included. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11630] AgeRestrictionMarker doesn't handle marker immediately followed by age
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630 Olli-Antti Kivilahti changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13106 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13105] Columns misplaced in member search result
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13105 Rafal Kopaczka changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13105] Columns misplaced in member search result
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13105 --- Comment #1 from Rafal Kopaczka --- Created attachment 32505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32505&action=edit Bug 13105: Columns misplaced in member search result When staff member, without manage_patron_lists permissions, search for patrons on result page, he gets table with additional column in head table. Test plan: Log in as staff member without manage_patron_lists permissions, search for any patron. Check that table with results is fine now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13105] New: Columns misplaced in member search result
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13105 Bug ID: 13105 Summary: Columns misplaced in member search result Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: rkopac...@afm.edu.pl Reporter: rkopac...@afm.edu.pl QA Contact: testo...@bugs.koha-community.org Created attachment 32504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32504&action=edit Columns misplaced When staff member, without manage_patron_lists permissions, search for patrons on result page, he gets table with additional column in head table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12981] Patron attribute type limit by patron category not working on patron entry form
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12981 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12981] Patron attribute type limit by patron category not working on patron entry form
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12981
Kyle M Hall changed:
What|Removed |Added
Attachment #32345|0 |1
is obsolete||
--- Comment #4 from Kyle M Hall ---
Created attachment 32503
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32503&action=edit
[PASSED QA] Bug 12981 - Patron attribute type limit by patron category not
working on patron entry form
To reproduce this bug:
- Create a patron attribute type and limit it by patron category
- Create a new patron with that category
- Observe that there is no entry field for the patron attribute type you
created for that patron category. Inspecting the source should show
that the entry field has been hidden.
The patron entry form tries to hide patron attribute type input fields
based on the currently selected patron category. It does this based on
the value of $("categorycode"). However, instead of pulling the data
from the categorycode input in the body of the entry form, it pulls it
from the patron search box at the top of the page. The value of that
input is always empty because no category is preselected.
This patch corrects the problem by changing the ID of the categorycode
in the body of the entry form and making corresponding changes
to the JavaScript which depends on it.
To test, apply the patch and load the patron entry form for a patron
category to which a patron attribute type has been limited. That patron
attribute entry field should appear correctly.
Choose a different patron category from the "Category" dropdown. Confirm
that the patron attribute entry field has been hidden.
Signed-off-by: Chris Cormack
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #27 from Kyle M Hall --- Created attachment 32502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32502&action=edit Bug 13084 [Master] - QA Followup - Use DBIx::Class to simplify logic Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #26 from Kyle M Hall --- Created attachment 32501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32501&action=edit Bug 13084 [Master] - Mixup of columns in deletedborrowers I could reproduce this problem in 3.14.4 where I wrote the patch. Fields shifted like branchcode moved to B_phone. Could not reproduce it for master. But this code change seems to improve things on master too. TEST PLAN - 1) Alter the order of your deletedborrowers table. e.g. alter table deletedborrowers change column privacy privacy int(11) after city; 2) Apply the 3.14.x test patch. 3) prove -v t/db_dependent/Members.t -- Will fail on the new test. 4) Apply the 3.14.x code change patch. 5) prove -v t/db_dependent/Members.t -- Will succeed on the new test. 6) run koha qa test tools. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 Kyle M Hall changed: What|Removed |Added Attachment #32493|0 |1 is obsolete|| Attachment #32494|0 |1 is obsolete|| Attachment #32495|0 |1 is obsolete|| --- Comment #25 from Kyle M Hall --- Created attachment 32500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32500&action=edit Bug 13084 [Master] - Improve t/db_dependent/Members.t test coverage Added a MoveMemberToDeleted set of tests. TEST PLAN - 1) prove -v t/db_dependent/Members.t -- all should pass. 2) Run koha QA tests. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA CC||k...@bywatersolutions.com --- Comment #24 from Kyle M Hall --- RM Note: My QA followup does change the implementation of MoveMemberToDeleted completely. This new implementation is much simpler and passes the provided unit tests. However, if you feel it should be re-qa'ed, please reset the status to signed off. This followup has not been included in the 3.14.x patch set, as 3.14 has a bug where unit tests involving DBIC code will fail. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13104] Changing TimeFormat on a production server will create duplicate fines!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13104] Changing TimeFormat on a production server will create duplicate fines!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Kyle M Hall changed: What|Removed |Added Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13104] Changing TimeFormat on a production server will create duplicate fines!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 --- Comment #1 from Kyle M Hall --- Created attachment 32499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32499&action=edit Bug 13104 - Changing TimeFormat on a production server will create duplicate fines! The system preference TimeFormat decides if times are formatted in 24 hour or 12 hour format. The issue at hand is that this changes the time description for fines. Let us assume the time format is currently 24 hour, and there are overdue items with accruing fines. When the format is changed to 12 hour, and fines.pl is run, it will begin looking for fines with a 12 hour format. Since there are no, it will create a new fine and you will now have two fines for the same item! There are solutions which require database manipulation: 1) Update all existing fines from 24 hour to 12 hour format 2) Delete all existing accruing fines so they are all regenerated the following night The accounts rewrite ( Bug 6427 ) will resolve this issue, as it does not look for existing fines based on the description. I believe the best course of action until bug 6427 is pushed to master is to add a warning to the system preference to not alter it on a production server with existing fines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13104 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13104] Changing TimeFormat on a production server will create duplicate fines!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Kyle M Hall changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=6427 Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13104] New: Changing TimeFormat on a production server will create duplicate fines!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Bug ID: 13104 Summary: Changing TimeFormat on a production server will create duplicate fines! Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The system preference TimeFormat decides if times are formatted in 24 hour or 12 hour format. The issue at hand is that this changes the time description for fines. Let us assume the time format is currently 24 hour, and there are overdue items with accruing fines. When the format is changed to 12 hour, and fines.pl is run, it will begin looking for fines with a 12 hour format. Since there are no, it will create a new fine and you will now have two fines for the same item! There are solutions which require database manipulation: 1) Update all existing fines from 24 hour to 12 hour format 2) Delete all existing accruing fines so they are all regenerated the following night The accounts rewrite ( Bug 6427 ) will resolve this issue, as it does not look for existing fines based on the description. I believe the best course of action until bug 6427 is pushed to master is to add a warning to the system preference to not alter it on a production server with existing fines. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4277] budget planning refreshes funny
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4277 Pete Edwards changed: What|Removed |Added CC||k...@jsense.co.uk --- Comment #3 from Pete Edwards --- Still apparent in 3.16.03.000 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13103] No checkouts count on member details page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13103 Rafal Kopaczka changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13103] No checkouts count on member details page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13103 Rafal Kopaczka changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13103] No checkouts count on member details page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13103 --- Comment #1 from Rafal Kopaczka --- Created attachment 32498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32498&action=edit Bug 13103: No checkouts count on member details page On member details page, number of issues are not shown. It's caused by, old variable name for issue count in Moremember.tt template. To test: Apply patch go to member details page and check if there's number alongside "Checkout(s)" tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #23 from Kyle M Hall --- Created attachment 32497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32497&action=edit [PASSED QA] Bug 13084 [3.14.x]: Mixup of columns in deletedborrowers I could reproduce this problem in 3.14.4 where I wrote the patch. Fields shifted like branchcode moved to B_phone. Could not reproduce it for master. But this code change seems to improve things on master too. NOTE: The callers of this routine should use the return value to check, and not simply assume that it will be fine ;) Changing those places is out of the scope of this report. TEST PLAN - 1) Alter the order of your deletedborrowers table. e.g. alter table deletedborrowers change column privacy privacy int(11) after city; 2) Apply the 3.14.x test patch. 3) prove -v t/db_dependent/Members.t -- Will fail on the new test. 4) Apply the 3.14.x code change patch. 5) prove -v t/db_dependent/Members.t -- Will succeed on the new test. 6) run koha qa test tools. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 Kyle M Hall changed: What|Removed |Added Attachment #32396|0 |1 is obsolete|| Attachment #32397|0 |1 is obsolete|| --- Comment #22 from Kyle M Hall --- Created attachment 32496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32496&action=edit [PASSED QA] Bug 13084 [3.14.x] - Improve t/db_dependent/Members.t test coverage Added a MoveMemberToDeleted set of tests. TEST PLAN - 1) prove -v t/db_dependent/Members.t -- all should pass. 2) Run koha QA tests. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13103] New: No checkouts count on member details page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13103 Bug ID: 13103 Summary: No checkouts count on member details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: rkopac...@afm.edu.pl Reporter: rkopac...@afm.edu.pl QA Contact: testo...@bugs.koha-community.org On member details page, number of issues are not shown. It's caused by, old variable name for issue count in Moremember.tt template. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #21 from Kyle M Hall --- Created attachment 32495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32495&action=edit [PASSED QA] Bug 13084 [Master] - QA Followup - Use DBIx::Class to simplify logic Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #20 from Kyle M Hall --- Created attachment 32494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32494&action=edit [PASSED QA] Bug 13084 [Master] - Mixup of columns in deletedborrowers I could reproduce this problem in 3.14.4 where I wrote the patch. Fields shifted like branchcode moved to B_phone. Could not reproduce it for master. But this code change seems to improve things on master too. TEST PLAN - 1) Alter the order of your deletedborrowers table. e.g. alter table deletedborrowers change column privacy privacy int(11) after city; 2) Apply the 3.14.x test patch. 3) prove -v t/db_dependent/Members.t -- Will fail on the new test. 4) Apply the 3.14.x code change patch. 5) prove -v t/db_dependent/Members.t -- Will succeed on the new test. 6) run koha qa test tools. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #18 from Kyle M Hall --- Created attachment 32492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32492&action=edit Bug 13084 [Master] - QA Followup - Use DBIx::Class to simplify logic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 Kyle M Hall changed: What|Removed |Added Attachment #32490|0 |1 is obsolete|| Attachment #32491|0 |1 is obsolete|| Attachment #32492|0 |1 is obsolete|| --- Comment #19 from Kyle M Hall --- Created attachment 32493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32493&action=edit [PASSED QA] Bug 13084 [Master] - Improve t/db_dependent/Members.t test coverage Added a MoveMemberToDeleted set of tests. TEST PLAN - 1) prove -v t/db_dependent/Members.t -- all should pass. 2) Run koha QA tests. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 --- Comment #17 from Kyle M Hall --- Created attachment 32491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32491&action=edit Bug 13084 [Master] - Mixup of columns in deletedborrowers I could reproduce this problem in 3.14.4 where I wrote the patch. Fields shifted like branchcode moved to B_phone. Could not reproduce it for master. But this code change seems to improve things on master too. TEST PLAN - 1) Alter the order of your deletedborrowers table. e.g. alter table deletedborrowers change column privacy privacy int(11) after city; 2) Apply the 3.14.x test patch. 3) prove -v t/db_dependent/Members.t -- Will fail on the new test. 4) Apply the 3.14.x code change patch. 5) prove -v t/db_dependent/Members.t -- Will succeed on the new test. 6) run koha qa test tools. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 Kyle M Hall changed: What|Removed |Added Attachment #32394|0 |1 is obsolete|| Attachment #32395|0 |1 is obsolete|| --- Comment #16 from Kyle M Hall --- Created attachment 32490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32490&action=edit Bug 13084 [Master] - Improve t/db_dependent/Members.t test coverage Added a MoveMemberToDeleted set of tests. TEST PLAN - 1) prove -v t/db_dependent/Members.t -- all should pass. 2) Run koha QA tests. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #533 from Kyle M Hall --- Created attachment 32488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32488&action=edit Bug 6427 - Delete unused and unnecessary files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #532 from Kyle M Hall --- Created attachment 32487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32487&action=edit Bug 6427 - Add & update cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #534 from Kyle M Hall --- Created attachment 32489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32489&action=edit Bug 6427 - Unit Tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #531 from Kyle M Hall --- Created attachment 32486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32486&action=edit Bug 6427 - Update OPAC scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #530 from Kyle M Hall --- Created attachment 32485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32485&action=edit Bug 6427 - Update existing intranet scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #529 from Kyle M Hall --- Created attachment 32484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32484&action=edit Bug 6427 - Add new staff scripts for managing accounts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #528 from Kyle M Hall --- Created attachment 32483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32483&action=edit Bug 6427 - Add TableTools plugin for DataTables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #527 from Kyle M Hall --- Created attachment 32482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32482&action=edit Bug 6427 - Add new TT plugin to deal with currency -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #526 from Kyle M Hall --- Created attachment 32481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32481&action=edit Bug 6427 - Update existing Koha perl modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #524 from Kyle M Hall --- Created attachment 32479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32479&action=edit Bug 6427 - Update schema files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #525 from Kyle M Hall --- Created attachment 32480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32480&action=edit Bug 6427 - Add new Accounts related Koha modules -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What|Removed |Added Attachment #31766|0 |1 is obsolete|| Attachment #31767|0 |1 is obsolete|| Attachment #31768|0 |1 is obsolete|| Attachment #31769|0 |1 is obsolete|| Attachment #31770|0 |1 is obsolete|| Attachment #31771|0 |1 is obsolete|| Attachment #31772|0 |1 is obsolete|| Attachment #31773|0 |1 is obsolete|| Attachment #31774|0 |1 is obsolete|| Attachment #31775|0 |1 is obsolete|| Attachment #31776|0 |1 is obsolete|| Attachment #31777|0 |1 is obsolete|| --- Comment #523 from Kyle M Hall --- Created attachment 32478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32478&action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12273] print entire list at once
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12273 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What|Removed |Added Patch complexity|--- |Large patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8374] Option to print all entries of a list in a user friendly format
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8374 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12653] PROG/CCSR deprecation: Correct hard-coded opac-tmpl/prog path in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12653 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12653] PROG/CCSR deprecation: Correct hard-coded opac-tmpl/prog path in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12653 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #30706|0 |1 is obsolete|| --- Comment #5 from Bernardo Gonzalez Kriegel --- Created attachment 32477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32477&action=edit Bug 12653: PROG/CCSR deprecation: Correct hard-coded opac-tmpl/prog path in tests This patch removes explicit references of themes from xt/author/icondirectories.t xt/author/translatable-templates.t xt/author/valid-templates.t xt/single_quotes.t xt/tt_valid.t For xt/author/icondirectories.t it fixes a small difference on two bootstrap files, previously unchecked, crystal-clear/_COPYING.txt and crystal-clear/_README.txt Some updates to license information To test: 1. Apply the patch 2. Run each test, all must pass prove xt/author/icondirectories.t xt/author/translatable-templates.t xt/author/valid-templates.t xt/single_quotes.t xt/tt_valid.t 3. Try to fail each test a) xt/author/icondirectories.t create a new file on any of icon dirs, e.g. touch koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/newfile.png test must fail b) xt/author/translatable-templates.t change the name of 'en' dir on any theme opac or staff test must fail Add following line to any template file TEST [% INCLUDE 'fail.inc' %] c) xt/author/valid-templates.t must fail d) xt/single_quotes.t must fail e) xt/tt_valid.t must fail -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13096] Send an ACCTDETAILS notice when staff changes user or password or ?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 --- Comment #5 from M. de Rooy --- For native speakers: Is the text " Mail account details to patron when saving this record" clear enough? It should make clear that this is a one-off mail and not a permanent patron attribute or so. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13096] Send an ACCTDETAILS notice when staff changes user or password or ?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 --- Comment #4 from M. de Rooy --- Just a thing that I will still do: Put the same logic in member-password.pl Could do that on another report? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
