[Koha-bugs] [Bug 13110] News needs a Read More option
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13110 --- Comment #3 from Marc Véron ve...@veron.ch --- (In reply to Christopher Brannon from comment #2) The #news ID doesn't work because the articles are numerated like news32 I'm glad that it works. Which Koha version are you using? - The display of news is changed by Bug 12863 (Pushed to master). Marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11401] Add support for Norwegian national library card
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11401] Add support for Norwegian national library card
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added Attachment #31816|0 |1 is obsolete|| --- Comment #17 from Magnus Enger mag...@enger.priv.no --- Created attachment 32546 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32546action=edit Bug 11401 - Add support for Norwegian national library card This patch makes it possible to sync patron data between Koha and the Norwegian national patron database, in both directions. In order to use this, the following information is necessary: - a username/password from the Norwegian national database of libraries (Base Bibliotek), available to all Norwegian libraries - a special key in order to decrypt and encrypt PIN-codes/passwords, which is only available to Norwegian library system vendors - a norwegian library vendor username/password See http://www.lanekortet.no/ for more information (in Norwegian). While this is of course an implementation of a specific synchronization scheme for borrower data, attempts have been made to prepare the ground for other sync schemes that might be implemented later. Especially the structure of the new borrower_sync table might be reviewed with an eye to how it might fit other schemes. To test: Since the password and cryptographic key needed to use this functionality is only available to Norwegian library system vendors, only regression testing can be done on the submitted code. Suggested things to check: - Apply the patch and make sure the database update is done. This should add the new borrower_sync table and five new systmpreferences under the Patrons Norwegian patron database category: - NorwegianPatronDBEnable - NorwegianPatronDBEndpoint - NorwegianPatronDBUsername - NorwegianPatronDBPassword - NorwegianPatronDBSearchNLAfterLocalHit - Check that patrons can be created, edited and deleted as usual, when NorwegianPatronDBEnable is set to Disable - Check that the new tests in t/NorwegianPatronDB.pm run ok, e.g. on a gitified setup: $ sudo koha-shell -c PERL5LIB=/path/to/kohaclone prove -v t/NorwegianPatronDB.t instancename - Check that all the other tests still run ok - Check that the POD in the new files itroduced by this patch looks ok: - Koha/NorwegianPatronDB.pm - members/nl-search.pl - misc/cronjobs/nl-sync-from-koha.pl - misc/cronjobs/nl-sync-to-koha.pl - t/NorwegianPatronDB.t Sponsored-by: Oslo Public Library Update 2014-09-18: - Rebase on master - Split out changes to Koha::Schema - Incorporate new way of authenticating with NL Update 2014-10-21: - Rebase on master - Use Module::Load to load Koha::NorwegianPatronDB in non-NL-specific scripts and modules - Fix the version number of Digest::SHA - Fix a missing semicolon in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11401] Add support for Norwegian national library card
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401
--- Comment #18 from Magnus Enger mag...@enger.priv.no ---
(In reply to Chris Cormack from comment #8)
The only suggestion I have is that we could perhaps use
Module::Load::Conditional
in C4/Members.pm, so that we don't have to load the module unless we need it.
It looks like Module::Load::Conditional can't take a list of subs to import, so
I went with Module::Load (which is already used a couple of places in Koha)
instead, e.g.:
use Module::Load;
if ( C4::Context-preference('NorwegianPatronDBEnable') == 1 ) {
load Koha::NorwegianPatronDB, qw( NLMarkForDeletion NLSync );
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13117] Waiting Reserve Message Missing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13117 Rafal Kopaczka rkopac...@afm.edu.pl changed: What|Removed |Added Status|NEW |RESOLVED CC||rkopac...@afm.edu.pl Resolution|--- |DUPLICATE --- Comment #1 from Rafal Kopaczka rkopac...@afm.edu.pl --- Looks like duplicate of bug 12892. *** This bug has been marked as a duplicate of bug 12892 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892 Rafal Kopaczka rkopac...@afm.edu.pl changed: What|Removed |Added CC||fred.pie...@smfpl.org --- Comment #38 from Rafal Kopaczka rkopac...@afm.edu.pl --- *** Bug 13117 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13116] Make it possible to propagate errors from C4::Reserves::CanItemBeReserved() to the web-templates.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13116 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added CC||mag...@enger.priv.no --- Comment #3 from Magnus Enger mag...@enger.priv.no --- No test plan? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677
Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:
What|Removed |Added
Attachment #32101|0 |1
is obsolete||
--- Comment #10 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 32547
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32547action=edit
Bug 11677 - Limit to Only items currently available for loan or reference not
working!
This row:
$availability_limit .=
( ( allrecords,AlwaysMatches='' not onloan,AlwaysMatches='') and
(lost,st-numeric=0) );
Causes all records in Zebra to be selected and removes records with even one
item onloan
(even if items would be available)!
This is obviously wrong, but because Zebra (and not many other text indexers)
cannot deal
with (If undef)-search terms, a fix might be to set 952$q (onloan) datetime to
-00-00
instead of NULL in the DB. Then we could find Records with items where onloan
is -00-00.
Comments out that Zebra availability search and deals with availability on
Koha-side.
Gets the branch or holdingbranch limit from opac-search.pl or search.pl and
uses that to
skip Zebra results which are onloan or notforloan.
Updates the result set size when results are removed.
Fixed a bug where pagination broke, due to the $results_hash-{'RECORDS'}
-array getting populated
always starting from 0, where it should have started from the given $offset.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13106] Encapsulate Circulation::GetAgeRestriction() and modify it to check borrowers age as well.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13106 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #32538|0 |1 is obsolete|| --- Comment #4 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 32548 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32548action=edit Bug 13106 - Encapsulate Circulation::GetAgeRestriction() and modify it to check borrowers age as well. This patch moves the logic of deciding whether or not a borrower is old enough to access this material to its own function GetAgeRestriction. This makes it easier to use AgeRestriction elsewhere, like with placing holds. Unit tests included. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13113] Prevent juvenile/children from reserving ageRestricted material
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13113 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #32539|0 |1 is obsolete|| --- Comment #3 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 32549 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32549action=edit Bug 13113 - Prevent juvenile/children from reserving ageRestricted material There is no reason for underage borrowers to reserve ageRestricted material and then be denied it's check-out due to ageRestriction. This patch prevents reserving material for borrowers not suitably aged. # # # # # # # A PRIORI # # # # # # # BOTH THE STAFF CLIENT AND THE OPAC 1. Find a Record with Items, update the MARC Subfield 521a to PEGI 16. 2. Get a Borrower who is younger than 16 years. 3. Place a hold for the underage Borrower for the ageRestricted Record. 4. You can reserve an ageRestricted Record with ease. STAFF CLIENT ONLY 5. Check-in an Item from the ageRestricted Record and catch the reservation. 6. Check-out the ageRestricted Item for this underage Borrower. 7. You get a notification about being unable to check-out due to age restriction. How lame is that for a 12 year old? # # # # # # # # # A POSTERIORI # # # # # # # # # STAFF CLIENT 1. Find a Record with Items, update the MARC Subfield 521a to PEGI 16. 2. Get a Borrower who is younger than 16 years. 3. Check-out an ageRestricted Item for this underage Borrower. 4. You get a notification about having the maximum amount of reserves. 5. Place a hold for the underage Borrower for the ageRestricted Record. 6. You get a notification, that placing a hold on ageRestricted material is forbidden. OPAC A. In OPAC go to opac-detail.pl for the ageRestricted Biblio. The Place Hold -button is missing on the right sidebar if the underage user is logged in. B. From the opac-search.pl a hold can still be placed, but it will fail giving an error about age restrictions. Includes Unit tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13116] Make it possible to propagate errors from C4::Reserves::CanItemBeReserved() to the web-templates.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13116 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #32544|0 |1 is obsolete|| --- Comment #4 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 32550 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32550action=edit Bug 13116 - Make it possible to propagate errors from C4::Reserves::CanItemBeReserved() to the web-templates. This patch changes the way CanBookBeReserved() and CanItemBeReserved() return error messages and how they are dealt with in the templates. This change makes it possible to distinguish between different types of reservation failure. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13116] Make it possible to propagate errors from C4::Reserves::CanItemBeReserved() to the web-templates.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13116 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #32550|0 |1 is obsolete|| --- Comment #5 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 32551 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32551action=edit Bug 13116 - Make it possible to propagate errors from C4::Reserves::CanItemBeReserved() to the web-templates. This patch changes the way CanBookBeReserved() and CanItemBeReserved() return error messages and how they are dealt with in the templates. This change makes it possible to distinguish between different types of reservation failure. Currently only two types of errors are handled, all the way to the user, from the CanItemBeReserved(): -ageRestricted -tooManyReserves which translates to maxreserves # - TEST PLAN - # ((-- AGE RESTRICTION --)) STAFF CLIENT 1. Find a Record with Items, update the MARC Subfield 521a to PEGI 16. 2. Get a Borrower who is younger than 16 years. 3. Place a hold for the underage Borrower for the ageRestricted Record. 4. You get a notification, that placing a hold on ageRestricted material is forbidden. (previously you just got a notification about maximum amount of reserves reached) OPAC A. In OPAC go to opac-detail.pl for the ageRestricted Biblio. The Place Hold -button is missing on the right sidebar if the underage user is logged in. B. From the opac-search.pl a hold can still be placed, but it will fail giving an error about age restrictions. ((-- MAXIMUM RESERVES REACHED --)) 0. Set the maxreserves -syspref to 3 (or any low value) STAFF CLIENT AND OPAC 1. Make a ton of reserves for one borrower. 2. Observe the notification about maximum reserves reached blocking your reservations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13106] Encapsulate Circulation::GetAgeRestriction() and modify it to check borrowers age as well.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13106 --- Comment #5 from Marc Véron ve...@veron.ch --- Hi Olli-Antti, It seems that the line did not change in the newest patch, it still reads if ( $daysToAgeRestriction ) (...) The patch seems to be unchanged. Something similar happend to me several times when I forgot to do git add [file] :-) Marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13116] Make it possible to propagate errors from C4::Reserves::CanItemBeReserved() to the web-templates.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13116 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #32551|0 |1 is obsolete|| --- Comment #6 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 32552 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32552action=edit Bug 13116 - Make it possible to propagate errors from C4::Reserves::CanItemBeReserved() to the web-templates. This patch changes the way CanBookBeReserved() and CanItemBeReserved() return error messages and how they are dealt with in the templates. This change makes it possible to distinguish between different types of reservation failure. Currently only two types of errors are handled, all the way to the user, from the CanItemBeReserved(): -ageRestricted -tooManyReserves which translates to maxreserves # - TEST PLAN - # ((-- AGE RESTRICTION --)) STAFF CLIENT 1. Find a Record with Items, update the MARC Subfield 521a to PEGI 16. 2. Get a Borrower who is younger than 16 years. 3. Place a hold for the underage Borrower for the ageRestricted Record. 4. You get a notification, that placing a hold on ageRestricted material is forbidden. (previously you just got a notification about maximum amount of reserves reached) OPAC A. In OPAC go to opac-detail.pl for the ageRestricted Biblio. The Place Hold -button is missing on the right sidebar if the underage user is logged in. B. From the opac-search.pl a hold can still be placed, but it will fail giving an error about age restrictions. ((-- MAXIMUM RESERVES REACHED --)) 0. Set the maxreserves -syspref to 3 (or any low value) STAFF CLIENT AND OPAC 1. Make a ton of reserves for one borrower. 2. Observe the notification about maximum reserves reached blocking your reservations. Updated the unit tests to match the new method return values. t/db_dependent/Holds.t Reserves.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10480] Cataloging plugins without redefining
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|REOPENED|ASSIGNED Blocks|9921| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13116] Make it possible to propagate errors from C4::Reserves::CanItemBeReserved() to the web-templates.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13116 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #7 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Hi there early birds! I didn't set Needs Signoff because I didn't think the patch was ready for testing. Just wanted to share my work at the days end to see where the feature set is moving to. Thanks for caring though! There are still bugs there, but setting the status to Needs Signoff for your leisure. It's all your now :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921 Bug 9921 depends on bug 10480, which changed state. Bug 10480 Summary: Cataloging plugins without redefining http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 What|Removed |Added Status|RESOLVED|REOPENED Resolution|WONTFIX |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10480] Cataloging plugins without redefining
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #19154|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Depends on|10480 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10480] Cataloging plugins without redefining
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WONTFIX |--- --- Comment #12 from M. de Rooy m.de.r...@rijksmuseum.nl --- Still want to proceed on this in another direction. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10480] Cataloging plugins without redefining
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #19169|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13007] suggestions.budgetid should be a foreign key
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13007 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||paola.ro...@cineca.it --- Comment #4 from Paola Rossi paola.ro...@cineca.it --- I've tried to apply the patches against master 3.17.00.029 At first I've applied the 6 patches of 12627. --- The patch Bug 13007: Add a foreign key for suggestions.budgetid needs a trivial rebase. Moreover, this wrong line of the patch 13007: +print Upgrade to $DBversion done (Bug 13007 - Add new foreign key suggestions.budgetid\n); should be changed in the following right one: +print Upgrade to $DBversion done (Bug 13007 - Add new foreign key suggestions.budgetid)\n; --- About the first step: 0/ Verify it is not possible to create a suggestion not linked to a fund via the Koha interface. in intranet, any is an option in the dropdown list on Acquisition information for selecting a fund to link to the suggestion. So IMO it's still easy to create suggestions not linked to a fund. So I pass the patch to Failed QA STATUS. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12982] Patron category dropdown empty in header search form on patron entry page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12982 --- Comment #6 from Owen Leonard oleon...@myacpl.org --- (In reply to M. de Rooy from comment #5) QA Comment: Looks good. But I still have a question: Would this be the place to also provide the branches if they are not passed in? Of course that would be a good idea, but since this bug specifically references patron categories I think it's out of its scope. However, I'll leave this as Failed QA since it still lacks a test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12919] Automate collecting all records added and deleted from the catalogue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12919 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Summary|It'd be nice to be able to |Automate collecting all |automate collecting all |records added and deleted |records added and deleted |from the catalogue |from the catalogue | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13112] Add name of template file in html comment for each '.tt' file.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13112 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Summary|Feature Request -- Add name |Add name of template file |of template file in html|in html comment for each |comment for each '.tt' |'.tt' file. |file. | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13088] Allow the user to specify a max amount of facets to show.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13088 --- Comment #2 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 32554 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32554action=edit Bug 13088: Allow the user to specify a max amount of facets to show This patch makes _get_facet_from_result_set rely on a new syspref (FacetsMaxCount) to set the max facets to show for each facet category. It defaults to 20 if the syspref is absent or empty. To test: - Have a search with lots of facet results (with some category showing the See more link). - Jump to See more, notice it shows more than 20 facet values. - Apply the patch, reload the page. = SUCCESS It only shows 20 (default hardcoded value) - Change the FacetsMaxCount syspref to other value (e.g. 15 or 100). - Reload = SUCCESS: it shows the expected amount. - Sign off :-D Regards Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13088] Allow the user to specify a max amount of facets to show.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13088 --- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 32553 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32553action=edit Bug 13088: Add a syspref so the user can chose the amount of facets to show This patch introduces a syspref (FacetMaxCount) that controls how many facets to show for each category (e.g. Author). Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13088] Allow the user to specify a max amount of facets to show.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13088 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13099] Item hasn't been transferred yet shows pickup branch rather than holding branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13099 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||paola.ro...@cineca.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13099] Item hasn't been transferred yet shows pickup branch rather than holding branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13099 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Attachment #32428|0 |1 is obsolete|| --- Comment #2 from Paola Rossi paola.ro...@cineca.it --- Created attachment 32555 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32555action=edit Bug 13099 - Item hasn't been transferred yet shows pickup branch rather than holding branch I've applied against master 3.17.00.029 Everything is ok. The library listed now is the holding library (current location). So I pass the patch to Signed Off status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13118] New: Download report as CSV
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13118 Bug ID: 13118 Summary: Download report as CSV Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcha...@gmail.com Reporter: ihuss...@eastgate-ls.com QA Contact: testo...@bugs.koha-community.org When I save any report contains Arabic characters as CSV file, Arabic characters comes as non readable characters, check attached -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||paola.ro...@cineca.it --- Comment #9 from Paola Rossi paola.ro...@cineca.it --- I've applied against master 3.17.00.029 The test plan was OK as required. But, when I tried to select Yes, check out (Y), the page remained Loading And no checkout was created for the patron. So I pass the patch to Failed QA status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13083] Hard-coded by in opac-tags.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13083 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 32556 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32556action=edit Bug 13083 - Hard-coded by in opac-tags.pl The OPAC's list of a logged-in user's tagged titles displays title and author, which for some reason are combined in the script into one variable. I can't see any reason to do it this way. This patch modifies the script so that title and author are passed as separate variables. In addition, subtitle is now passed as well. To test you must log into the OPAC as a user who has tagged multiple titles, at least one of which should have an author and at least one with a subtitle. View the list of tagged titles and confirm that this information is being displayed correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13083] Hard-coded by in opac-tags.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13083 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13082] tools/export.pl fix to forbid adding of all invalid records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13082 stephane.dela...@biblibre.com changed: What|Removed |Added Attachment #32332|0 |1 is obsolete|| --- Comment #2 from stephane.dela...@biblibre.com --- Created attachment 32557 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32557action=edit proposed patch proposed patch : excludes records with marc-record's errors and also other non-marc fatal errors (eg. utf8 \xCF does not map to Unicode at /usr/lib/perl/5.10/Encode.pm line 174.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13083] Hard-coded by in opac-tags.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13083 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Blocks||13119 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13119] New: Use XSLT to display tagged titles in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13119 Bug ID: 13119 Summary: Use XSLT to display tagged titles in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 13083 The list of a logged-in user's tagged titles should provide the same kind of information see in other lists of titles like search results and Lists. If OPACXSLTResultsDisplay is set to use XSLT the tags page should display title information using XSLT. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13120] New: Invalid HTML generated by MARC21slim2OPACResults.xsl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13120 Bug ID: 13120 Summary: Invalid HTML generated by MARC21slim2OPACResults.xsl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org MARC21slim2OPACResults.xsl, which controls XSLT output of search results in the OPAC, applies a non-unique id attribute to each row of results. This is invalid HTML. A class should be used instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13119] Use XSLT to display tagged titles in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13119 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13119] Use XSLT to display tagged titles in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13119 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 32558 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32558action=edit Bug 13119 - Use XSLT to display tagged titles in the OPAC This patch updates the display of a logged-in user's tagged titles to use the same XSLT stylesheet used by search results and Lists. This would make for a more consistent display of information. Unrelated change: Corrected My tags header to read Your tags, consistent with sidebar navigation. To test you should have multiple titles in your catalog which you have tagged in the OPAC. - Set the OPACXSLTResultsDisplay system preference to 'default' - Log in to the OPAC and view the your tags page. - Confirm that title information is displayed correctly. Compare to search results. - Empty the OPACXSLTResultsDisplay system preference and reload the your tags page. The display should revert to the old view, showing title, subtitle (if any) and author (if any). - Set the OPACXSLTResultsDisplay to a custom path pointing to a custom XSL file and confirm that the list of your tagged titles changes accordingly. Note: A follow-up will add action links (place hold, add to cart, etc) consistent with other pages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13121] New: Move search results action links (Place hold, Add tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121 Bug ID: 13121 Summary: Move search results action links (Place hold, Add tag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 13083, 13119 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13119] Use XSLT to display tagged titles in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13119 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Blocks||13121 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13121] Move search results action links (Place hold, Add tag, etc) into include file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Summary|Move search results |Move search results |action links (Place |action links (Place |hold, Add tag |hold, Add tag, etc) into ||include file --- Comment #1 from Owen Leonard oleon...@myacpl.org --- There are three areas in the OPAC which display multiple rows of title information using XSLT. All three could use the same include file when displaying action links: Place hold, Add tags, etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13083] Hard-coded by in opac-tags.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13083 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Blocks||13121 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12585] Tag searching broken if QueryParser is turned on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12585 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13122] New: Patron holds table no longer display date item went in transit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13122 Bug ID: 13122 Summary: Patron holds table no longer display date item went in transit Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com In Koha 3.14 and earlier, an item on hold and in transit would display the date the item was transferred. This is missing from the new ajax holds table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13122] Patron holds table no longer display date item went in transit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13122 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13122] Patron holds table no longer display date item went in transit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13122 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Patch complexity|--- |Trivial patch Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13122] Patron holds table no longer display date item went in transit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13122 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13122] Patron holds table no longer display date item went in transit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13122 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 32559 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32559action=edit Bug 13122 - Patron holds table no longer display date item went in transit In Koha 3.14 and earlier, an item on hold and in transit would display the date the item was transferred. This is missing from the new ajax holds table. Test Plan: 1) Place an item on hold for delivery at a different library 2) Check the item in, confirm the hold and transfer 3) View the patron's holds tab on circulation.pl and/or moremember.pl 4) Note the item is show as in transit, but does not give the since date 5) Apply this patch 6) Note the in transit status now has a since date -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13115] Holidays.t will fail some unit tests on Sundays
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13115 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13120] Invalid HTML generated by MARC21slim2OPACResults.xsl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13120 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13120] Invalid HTML generated by MARC21slim2OPACResults.xsl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13120 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 32560 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32560action=edit Bug 13120 - Invalid HTML generated by MARC21slim2OPACResults.xsl This patch converts an id to a class in order to avoid duplicate id attributes on one page. To test you must have XSLT enabled with the default setting. Perform a search in the OPAC and confirm that the display of location looks correct. Run the resulting page through a validator using an in-browser tool like Firefox's Html Validator addon or using the W3C's validator.w3.org. The results should not complain of duplicate id attributes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13123] New: Duplicate label ids for language and opaclanguages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13123 Bug ID: 13123 Summary: Duplicate label ids for language and opaclanguages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The labels corresponding to the checkboxes enabling translations in system preferences are duplicated from the language preference to the opaclanguages preference: language: label for=enEnglish(en)/label opaclanguages: label for=enEnglish(en)/label The result is that clicking the opaclanguages label toggles the language label. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13123] Duplicate label ids for language and opaclanguages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13123 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12653] PROG/CCSR deprecation: Correct hard-coded opac-tmpl/prog path in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12653 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #32542|0 |1 is obsolete|| --- Comment #25 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 32561 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32561action=edit [SIGNED-OFF] Bug 12653: Text file clean up _README.txt has 4 newlines removed. _COPYING.txt has 2 empty lines at the end of the file removed. This was done by copying the smallest file in an existing theme directory. TEST PLAN - 1) Compare files. diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_COPYING.txt koha-tmpl/opac-tmpl/prog/itemtypeimg/crystal-clear/_COPYING.txt diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_COPYING.txt koha-tmpl/opac-tmpl/ccsr/itemtypeimg/crystal-clear/_COPYING.txt diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_COPYING.txt koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/crystal-clear/_COPYING.txt diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_README.txt koha-tmpl/opac-tmpl/prog/itemtypeimg/crystal-clear/_README.txt diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_README.txt koha-tmpl/opac-tmpl/ccsr/itemtypeimg/crystal-clear/_README.txt diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_README.txt koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/crystal-clear/_README.txt -- there will be differences. 2) Apply patch 3) Compare files again. diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_COPYING.txt koha-tmpl/opac-tmpl/prog/itemtypeimg/crystal-clear/_COPYING.txt diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_COPYING.txt koha-tmpl/opac-tmpl/ccsr/itemtypeimg/crystal-clear/_COPYING.txt diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_COPYING.txt koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/crystal-clear/_COPYING.txt diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_README.txt koha-tmpl/opac-tmpl/prog/itemtypeimg/crystal-clear/_README.txt diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_README.txt koha-tmpl/opac-tmpl/ccsr/itemtypeimg/crystal-clear/_README.txt diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_README.txt koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/crystal-clear/_README.txt -- there will be no differences. 4) git reset --hard origin/master 5) Apply the patch affecting the .t files. 6) Prove things. prove xt/author/icondirectories.t xt/author/translatable-templates.t xt/author/valid-templates.t xt/single_quotes.t xt/tt_valid.t -- expecting xt/author/icondirectories.t to fail 7) Apply this patch. 8) Prove things. prove xt/author/icondirectories.t xt/author/translatable-templates.t xt/author/valid-templates.t xt/single_quotes.t xt/tt_valid.t -- expecting success. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com This patch fixes some issues with files on itemtypes dirs. No koha-qa erros. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12653] PROG/CCSR deprecation: Correct hard-coded opac-tmpl/prog path in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12653 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13123] Duplicate label ids for language and opaclanguages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13123 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13123] Duplicate label ids for language and opaclanguages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13123 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 32562 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32562action=edit Bug 13123 - Duplicate label ids for language and opaclanguages When enabling or disabling a OPAC language choice clicking the label triggers the checkbox under the language preference instead. This is because both labels have the same id. This patch adds a modifier to each label and corresponding id attribute in order to make them unique. To test, go to Administration - System preferences - I18N/L10N. Clicking the English (en) label under the language system preference should toggle the corresponding checkbox. Clicking the English (en) label under the opaclanguages system preference should toggle the correct checkbox. Further tests: - Install an English 'sub-language' like en-GB and confirm that checkbox labels work correctly. - Install a non-English language and confirm that checkbox labels work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13124] New: Record titles with parentheses causing label weirdness
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Bug ID: 13124 Summary: Record titles with parentheses causing label weirdness Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswon...@foundations.edu Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org See the attached image -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 32563 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32563action=edit Label PDF with weirdness -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 --- Comment #2 from Chris Nighswonger cnighswon...@foundations.edu --- That is due to the embedded parenthesis. The inner parenthesis are not being escaped properly by the code which handles that. Without looking, I'd say its a pretty trivial fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 32564 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32564action=edit Label PDF after patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 --- Comment #4 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 32565 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32565action=edit Bug 13124 - Record titles with parentheses causing label weirdness -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 --- Comment #5 from Chris Nighswonger cnighswon...@foundations.edu --- That fix will cause problems with the postscript stream. I don't remember exactly the case, but do remember it took some hours to find and fix. At a minimum these lines should only be commented out rather than removed and a commend added to the effect of what I've mentioned. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 --- Comment #6 from Kyle M Hall k...@bywatersolutions.com --- Test Plan ( using sample data included with Koha ) 1) Catalog a record and item with the title Oh no! or, (How my science project destroyed the world) / 2) Edit the DEFAULT template a) Set layout type to Biblio b) Set data fields to title, author, isbn, issn, itemtype, barcode, itemcallnumber c) Set font size to 10 3) Create a batch with just the one item you created 4) Export the PDF with the Avery template and the DEFAULT layout 5) Note the weirdness 6) Apply this patch 7) Re-export the PDF, note it's no longer weird ; ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 --- Comment #7 from Kyle M Hall k...@bywatersolutions.com --- (In reply to Chris Nighswonger from comment #5) That fix will cause problems with the postscript stream. I don't remember exactly the case, but do remember it took some hours to find and fix. At a minimum these lines should only be commented out rather than removed and a commend added to the effect of what I've mentioned. Will do! I don't see any negative effects. Possibly the need for them was fixed downstream. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #32565|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 32566 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32566action=edit Bug 13124 - Record titles with parentheses causing label weirdness Test Plan ( using sample data included with Koha ) 1) Catalog a record and item with the title Oh no! or, (How my science project destroyed the world) / 2) Edit the DEFAULT template a) Set layout type to Biblio b) Set data fields to title, author, isbn, issn, itemtype, barcode, itemcallnumber c) Set font size to 10 3) Create a batch with just the one item you created 4) Export the PDF with the Avery template and the DEFAULT layout 5) Note the weirdness 6) Apply this patch 7) Re-export the PDF, note it's no longer weird ; ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10960] Holds Queue Report display loc code not description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10960 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12068] label-create-pdf.pl Add support for RTL languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12068 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #14 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12914] Wrong message 'Patron(..) is blocked for 2014-09-30 day(s).
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #18 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Marc! Note: It feels it's time to refactor CanBookBeIsued. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13115] Holidays.t will fail some unit tests on Sundays
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13115 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13115] Holidays.t will fail some unit tests on Sundays
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13115 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #32532|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 32567 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32567action=edit [PASSED QA] Bug 13115 - Holidays.t will fail some unit tests on Sundays Due to the fact that Sunday is a repeating holiday in the example data which is used for part but not all of Holidays.t, the last test will fail on Sundays. The test is to see if today is *not* a special holiday for MPL, but since it's already a repeating holiday, is_holiday will return true rather than false. Test Plan: 1) Wait until Sunday 2) prove t/db_dependent/Holidays.t 3) Note the failure 4) Apply this patch 5) Repeat step 2 6) Note there is no longer a failure Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Used my time machine... :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13114] Disabled Shibboleth authentication spams logs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13114 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13114] Disabled Shibboleth authentication spams logs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13114
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Attachment #32533|0 |1
is obsolete||
--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32568
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32568action=edit
[PASSED QA] Bug 13114: Prevent Shibboleth Patches from spamming logs
- The shibboleth patch introduced an undefined message into the error
logs, when shiboleth is disabled.
Testplan
1. Ensure shibboleth is disabled.
2. Refresh any opac page
3. See 'Use of uninitialized value $ENV{REMOTE_USER} in string ne at
/home/koha/kohaclone/C4/Auth.pm line 711.' popup in the opac-error.log
4. Apply patch
5. Refresh opac page
6. Error should no longer appear
Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Works as described.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13105] Columns misplaced in member search result
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13105 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #32505|0 |1 is obsolete|| CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13105] Columns misplaced in member search result
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13105 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #32524|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 32569 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32569action=edit [PASSED QA] Bug 13105: Columns misplaced in member search result When staff member, without manage_patron_lists permissions, search for patrons on result page, he gets table with additional column in head table. Test plan: Log in as staff member without manage_patron_lists permissions, search for any patron. Check that table with results is fine now. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de Fixes problem by adding a permission check to the template. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13105] Columns misplaced in member search result
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13105 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13042] Move budget action links into menu
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13042 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13042] Move budget action links into menu
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13042 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #32527|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 32570 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32570action=edit [PASSED QA] Bug 13042 - Move budget action links into menu The series of links in the actions column of the budgets administration summary table are not very readable as they are, all strung together: Edit Delete Duplicate Close Add fund. This patch moves the links into an Actions menu, similar to the change made by Bug 10615 in Reports. To test you should have multiple active and inactive budgets. Apply the patch and go to Administration - Budgets. Confirm that each menu item links to the correct action. Test the menu for both active and inactive budgets. Signed-off-by: Paola Rossi paola.ro...@cineca.it Signed-off-by: Katrin Fischer katrin.fischer...@web.de Nice improvement on template level, works as described. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13108] Members are restricted even if the debarment is ended - opac-reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13108 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #32523|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 32571 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32571action=edit [PASSED QA] Bug 13108 - Members are restricted even if the debarment is ended - opac-reserve This is the same issue as bug 12134. Test Plan: 1) Add a manual restriction to a patron with expiration date in the past 2) Go on the OPAC and connect 3) Try to add an hold on a record (opac-reserve.pl) 3) Note the warning message Sorry, you cannot place holds because your account has been frozen ... 4) Apply this patch 5) Repeat step 2 6) Note the warning message does not appear anymore Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de Makes code cleaner, also works as described. NOTE: If you set a debarment with date in the past in the GUI, there will be no entry in borrowers.debarred and you won't be able to see the problem. Set one with a date in the future and then alter the date in borrower_debarments and borrowers.debarred. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13108] Members are restricted even if the debarment is ended - opac-reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13108 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13107] Members are restricted even if the debarment is ended - opac-user
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13107 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #32522|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 32572 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32572action=edit [PASSED QA] Bug 13107 - Members are restricted even if the debarment is ended - opac-user This is the same issue as bug 12134. Test Plan: 1) Add a manual restriction to a patron with expiration date in the past. 2) Go on the OPAC and connect (opac-user.pl) 3) Note the warning message Your account has been frozen until until XX/XX/ ... 4) Apply this patch 5) Repeat step 2 6) Note the warning message does not appear anymore Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de Works as described. NOTE: If you set a debarment with date in the past in the GUI, there will be no entry in borrowers.debarred and you won't be able to see the problem. Set one with a date in the future and then alter the date in borrower_debarments and borrowers.debarred. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13107] Members are restricted even if the debarment is ended - opac-user
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13107 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13104] Changing date or time format on a production server will create duplicate fines!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #32521|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 32573 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32573action=edit [PASSED QA] Bug 13104 - Changing date or time format on a production server will create duplicate fines! The system preference TimeFormat decides if times are formatted in 24 hour or 12 hour format. The issue at hand is that this changes the time description for fines. Let us assume the time format is currently 24 hour, and there are overdue items with accruing fines. When the format is changed to 12 hour, and fines.pl is run, it will begin looking for fines with a 12 hour format. Since there are no, it will create a new fine and you will now have two fines for the same item! There are solutions which require database manipulation: 1) Update all existing fines from 24 hour to 12 hour format 2) Delete all existing accruing fines so they are all regenerated the following night The same situation applies to DateFormat. The accounts rewrite ( Bug 6427 ) will resolve this issue, as it does not look for existing fines based on the description. I believe the best course of action until bug 6427 is pushed to master is to add a warning to the system preference to not alter it on a production server with existing fines. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de Adds some documentation to warn about the problem. Tested the new addition shows up in po files. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13104] Changing date or time format on a production server will create duplicate fines!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13104 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12979] Price formatting should only be defined at one place
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12979 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13115] Holidays.t will fail some unit tests on Sundays
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13115 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13114] Disabled Shibboleth authentication spams logs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13114 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Martin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13125] New: Total Holds does not tally holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13125 Bug ID: 13125 Summary: Total Holds does not tally holds Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: danie...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The items.reserves field in Koha is not working. It does not tally the total number of holds. I have checked several libraries with books that are usually on hold an all do not have any holds in the total ... at all. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13118] Download report as CSV
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13118 paxed pasi.kalli...@pttk.fi changed: What|Removed |Added CC||pasi.kalli...@pttk.fi --- Comment #1 from paxed pasi.kalli...@pttk.fi --- (In reply to Ihab from comment #0) When I save any report contains Arabic characters as CSV file, Arabic characters comes as non readable characters, check attached If you're using Microsoft Excel: It cannot handle UTF8 CSV files when opening the file. Instead, you need to import the data from the CSV file to already existing work sheet, and tell Excel the CSV contains 65001: Unicode (UTF-8) data. Libreoffice at least can do the Right Thing... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 --- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Do we need a new patch here? It looks like this is the last missing piece to get rid of SQLHelper. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
