[Koha-bugs] [Bug 11881] Small improvements in OPAC results list.

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

--- Comment #27 from Jonathan Druart jonathan.dru...@biblibre.com ---
The opac.css does not look good.
With your patch:
-rw-r--r-- 1 koha koha 42132 Mar  4 16:25 bootstrap/css/opac.css

$lessc --compress bootstrap/less/opac.less  bootstrap/css/opac.css
-rw-r--r-- 1 koha koha 42946 Mar  4 16:25 bootstrap/css/opac.css

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13635] $record-title is called even if marc flavour is UNIMARC

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13635

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #35575|0   |1
is obsolete||
  Attachment #35576|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 36502
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36502action=edit
Bug 13635: Unimarc - On editing a notice, the title should be displayed

The title method of MARC::Record does not deal with UNIMARC, it should
not be called if the marc flavour is UNIMARC.

Test plan:
On an unimarc installation, edit a notice, with this patch you should
see
 Editing TITLE (Record number BIBLIONUMBER)

Without, the title was not displayed.
Same in the breadcrumbs.

Bug 13635: Remove another useless call

There is another call to the title method in additem.pl without any
check on the marc flavour.
But here the title variable sent to the template is redefined 3 lines
later.
So it can be simply removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13771] Koha 3.18 Help Files

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

  Attachment #36500|0   |1
is obsolete||

--- Comment #16 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 36503
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36503action=edit
Bug 13771: Add missing item search help file

This patch adds a help file for the staff item search.

To test:

* Click search
* click item search
* click help
* review the help file

Signed-off-by: Mirko Tietgen mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13771] Koha 3.18 Help Files

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net
 Status|Needs Signoff   |Signed Off

--- Comment #17 from Mirko Tietgen mi...@abunchofthings.net ---
Item search help works for me.

I noticed that about the first half of the text is a description of how to get
to the very page you open that help file from, I'm not sure it is very helpful
in this context. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13635] $record-title is called even if marc flavour is UNIMARC

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13635

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12887] User logged out on refresh after CAS authentication

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12887

--- Comment #5 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Created attachment 36498
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36498action=edit
Bug 12887: User logged out on refresh after CAS authentication

 - If the user is already logged-in, do not trigger CAS authentication even if
there is a ticket in the parameters.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

--- Comment #8 from Nicole C. Engard neng...@gmail.com ---
Discussion from IRC: http://irc.koha-community.org/koha/2015-03-04#i_1645311

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12461] Add patron clubs feature

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net
 Status|Needs Signoff   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12344] Multi transport types for issues and checkins

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
I think I found an issue, to reproduce:
Enable sms + email for checkout, check an item out = no letter is generated.

Ok it's a configuration problem, but I think it could easily be fixed if you
next instead of return if the template does not exist.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13789] facets with accented utf-8 characters generate double encoded links

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Dobrica Pavlinusic dpav...@rot13.org changed:

   What|Removed |Added

  Attachment #36477|0   |1
is obsolete||

--- Comment #4 from Dobrica Pavlinusic dpav...@rot13.org ---
Created attachment 36501
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36501action=edit
Bug 13789 - facets with accented utf-8 characters generate double encoded links

Bug 13425 tried to fix XSS in OPAC, by using url filter in template toolkit
on whole generated url. This doesn't work and create double encoded strings
in facets because we are creating url variable by concatenating query_cgi
(which did pass through uri_escape_utf8 on perl side) and other
parameters which have to be escaped in template.

Also, code like

[% SET limit_cgi_f = limit_cgi | url %]

doesn't do anything (at least doesn't apply url filter) so it's not needed.

Test scenario:
1. find results in your opac which contain accented characters
2. click on them and verify that results are missing
3. apply this patch
4. re-run search and click on facets link verifying that there are
   now results
5. verify that facets are still safe from injection by constructing url like
  
/cgi-bin/koha/opac-search.pl?q=123sort_by='scriptprompt('Happy_Holidays')/scriptlimit=123
   and verifying that you DON'T see prompt window in your browser

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1985] Email notification of new OPAC comments

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 CC||k...@univ-lyon3.fr
 Status|Needs Signoff   |Failed QA

--- Comment #11 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
I tested this patch on a sandbox :
1. set syspref CommentModeratorsEmail with my email adress
2. go to public interface and add a comment on a book
3. go to saved reports to check to table message_queue : I have a new record
with the letter_code ''COMMENT_CREATED' : Ok, it works !
4. Go to notices and slips to change the message of ''COMMENT_CREATED' model :
in email tab, I try to add the title of the book in the message
(biblio.title) and the biblionumber (biblio.biblionumber)
5. Go to the opac and add a new comment on an other book
6. go to saved reports to check to table message_queue :  I don't retrieve the
title of the book and the biblionumber in the email : it's a pity because it
can be usefull informations for the librarian.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Francois Charbonnier francois.charbonn...@inlibro.com changed:

   What|Removed |Added

 Status|In Discussion   |ASSIGNED

--- Comment #9 from Francois Charbonnier francois.charbonn...@inlibro.com ---
Thanks nicole!
We just talked about this with Nicole and Kyle.
We agreeded on this :
* On the patron category page, there will be a new button : display the edit
garantor information box : yes | no
* by default, we will have yes for child and professional categories
* if yes, we will display the edit guarantor box on the patron edit page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12887] User logged out on refresh after CAS authentication

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12887

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13717] Add ability to move old patron attributes when importing borrowers

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13717

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||neng...@gmail.com

--- Comment #2 from Nicole C. Engard neng...@gmail.com ---
Applying: Bug 13717 - Add ability to move old patron attributes when importing
new patron data
fatal: sha1 information is lacking or useless (Koha/Borrower/Import.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 13717 - Add ability to move old patron attributes when
importing new patron data
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Patch left in
/tmp/Bug-13717---Add-ability-to-move-old-patron-attribu-k3144M.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2806] issuingbranch isn't used

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #36124|0   |1
is obsolete||

--- Comment #4 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 36499
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36499action=edit
[SIGNED-OFF] Bug 2806: Remove issuingbranch columns

This column is not in used in the Koha code and could be removed.

Test plan:
Verify the branch is correctly displayed on the circulation history
(members/readingrec.pl) and that both reports Most-cisulated items
(cat_issues_top.pl) and Avg checkout (issues_avg_stats.pl) work as
before.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
No problems found.
Fixed wrong table name on updatedatabase.pl and a tab char.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2806] issuingbranch isn't used

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com
 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13789] facets with accented utf-8 characters generate double encoded links

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Dobrica Pavlinusic dpav...@rot13.org changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12769] Notice fee management

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769

--- Comment #8 from Ahmed Sfayhi ahmed.sfa...@inlibro.com ---
Created attachment 36504
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36504action=edit
Bug 12769 - Display fee in notice fee

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Charles Farmer charles.far...@inlibro.com changed:

   What|Removed |Added

  Attachment #36505|0   |1
is obsolete||

--- Comment #10 from Charles Farmer charles.far...@inlibro.com ---
Created attachment 36506
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36506action=edit
Bug 12768 - Replacement cost and processing fee management

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Charles Farmer charles.far...@inlibro.com changed:

   What|Removed |Added

  Attachment #36350|0   |1
is obsolete||

--- Comment #9 from Charles Farmer charles.far...@inlibro.com ---
Created attachment 36505
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36505action=edit
Bug 12768 - Replacement cost and processing fee management

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12085] Allow staff to place multiple reserves for the same patron

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12085

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net
 Status|Needs Signoff   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1985] Email notification of new OPAC comments

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

--- Comment #12 from M. Tompsett mtomp...@hotmail.com ---
I think that may be a cronjob configuration problem. I'll recheck this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12769] Notice fee management

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769

Ahmed Sfayhi ahmed.sfa...@inlibro.com changed:

   What|Removed |Added

 CC||ahmed.sfa...@inlibro.com

--- Comment #9 from Ahmed Sfayhi ahmed.sfa...@inlibro.com ---
This attachment correct the problem with the last attachment: the fee was not
displayed in the notice fee input

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13635] $record-title is called even if marc flavour is UNIMARC

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13635

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #36502|0   |1
is obsolete||

--- Comment #6 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 36507
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36507action=edit
[SIGNED-OFF] Bug 13635: Unimarc - On editing a notice, the title should be
displayed

The title method of MARC::Record does not deal with UNIMARC, it should
not be called if the marc flavour is UNIMARC.

Test plan:
On an unimarc installation, edit a notice, with this patch you should
see
 Editing TITLE (Record number BIBLIONUMBER)

Without, the title was not displayed.
Same in the breadcrumbs.

Bug 13635: Remove another useless call

There is another call to the title method in additem.pl without any
check on the marc flavour.
But here the title variable sent to the template is redefined 3 lines
later.
So it can be simply removed.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

Tested on UNIMARC install, editing a 'record' (not notice) does not show
title on breadcrumbs, status bar or page title.
With patch it does!
No koha-qa errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

--- Comment #8 from Charles Farmer charles.far...@inlibro.com ---
I read _insert_accountlines again and adapted manualinvoice to take its place.
I also removed the *return* instruction at the end of chargelostitem() because,
as you said, it wasn't used anywhere (except once in ChargeLostItem.t)

Thank you for your time!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

LuceBarbey luce.bar...@cirad.fr changed:

   What|Removed |Added

 CC||luce.bar...@cirad.fr

--- Comment #9 from LuceBarbey luce.bar...@cirad.fr ---
I've tested it and I've some comments.
1.This function (developpement) needs a documentation about the behavior.
2. The first time we come on search history, we must select some lines and
click on start a new search before to see the boolean operator 'NOT'. It's
not intuitive
3. To build a complex search, we must proceed in several steps, because we
could search only with AND (match all) / OR (match any.)
Proposals :
1. Display the not column immediately
2. Modify the form : when nothing is checked display Select searches to run a
combined search. When at least one search is checked, display With selected
searches run a combined search [matching any of selected searches] [ok]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13635] $record-title is called even if marc flavour is UNIMARC

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13635

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6810] Send membership expiry reminder notices

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

 CC||n...@quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13784] Koha-stop-zebra should also work for disabled instances

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13785] Koha-disable should also stop SIP and zebra for instance

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13785

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

  Attachment #36413|0   |1
is obsolete||

--- Comment #2 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 36509
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36509action=edit
Bug 13785 - Koha-disable should also stop SIP and zebra for instance

Currently koha-disable ONLY disables the instance in the apache conf
file. Presumably if you want to disable the instance, you also want
its processes to stop, so this patch will stop zebra, if running,
and SIP, if enabled.

Depends on Bug 13784.

To Test:
1) Have an enabled instance, with zebra and SIP running.
2) Run koha-disable INST. Note that after, both zebra and SIP
   will still be running.
3) Re-enable INST.
4) Apply patch, and then copy debian/scripts/koha-disable to
   package site, over /usr/sbin/koha-disable.
5) Run koha-disable INST. You should now see that both zebra
   and SIP have been stopped.

Signed-off-by: Mirko Tietgen mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

  Attachment #30487|0   |1
is obsolete||

--- Comment #13 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 36512
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36512action=edit
Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC

QA Follow up

This patch will stop a person without access hitting the url directly and
being able to change their messaging preferences.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz
Signed-off-by: Mirko Tietgen mi...@abunchofthings.net
I fixed some minor conflicts, so I'm sending all patches w/ signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

--- Comment #15 from Mirko Tietgen mi...@abunchofthings.net ---
The description of EnhancedMessagingPreferences should probably be reworded as
it does not make much sense in combination with
OPACEnhancedMessagingPreferences.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11881] Small improvements in OPAC results list.

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

--- Comment #29 from simith.dolive...@inlibro.com ---
I created a new patch with just MARC21slim2OPACResults.xsl file because reading
the comments #2, #4, #9 and #21 we don't need .css ou .less files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Charles Farmer charles.far...@inlibro.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

  Attachment #30259|0   |1
is obsolete||

--- Comment #12 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 36511
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36511action=edit
Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC

This fix permits the staff to pull apart the access to patron message setting.

Modified:

installer/data/mysql/sysprefs.sql
-OPACEnhancedMessagingPreferences preference added
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref   
-OPACEnhancedMessagingPreferences preference added
koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc   
-access to message setting changed

Testing:

I Apply the patch
II Run updatedatabase.pl

0) Search OPACEnhancedMessagingPreferences preference;
1) Validate OPACEnhancedMessagingPreferences show patron messaging setting on
the OPAC (NOTE: EnhancedMessagingPreferences must be enabled).;
2) Disable OPACEnhancedMessagingPreferences preference;
3) Enable EnhancedMessagingPreferences preference;
4) On the OPAC - user's settings, validate your messaging is not showed.

Patch behaves as expected
Signed-off-by: Marc VĂ©ron ve...@veron.ch

Signed-off-by: Mirko Tietgen mi...@abunchofthings.net
I fixed some minor conflicts, so I'm sending all patches w/ signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13785] Koha-disable should also stop SIP and zebra for instance

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13785

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11881] Small improvements in OPAC results list.

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

--- Comment #28 from simith.dolive...@inlibro.com ---
Created attachment 36510
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36510action=edit
Small improvements for the availability informations in the search results list
on the OPAC

This patch contains small modifications to the template of OPAC search results.
Theses modifications affect the Availability line :
* Add a linebreak after each location.
* Add the text Call Number: before call numbers.

To test:

I) Apply the patch

II) Include the following test in the OPACUserCSS preference:

.searchresults .CommasWithLinebreaks {
display: block; # block - line breaks, inline - all one line
}

.searchresults .LabelCallNumber {
display: inline; # inline - display, none - don't display
}

III) Do a search on the OPAC

IV) Validate : check the format of availability informations for each search
result (Breakline or Call Number: text).

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

  Attachment #31047|0   |1
is obsolete||

--- Comment #14 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 36513
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36513action=edit
Bug 12528 Patch with updatedatabase.pl included

Signed-off-by: Mirko Tietgen mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Francois Charbonnier francois.charbonn...@inlibro.com changed:

   What|Removed |Added

 Status|Failed QA   |In Discussion

--- Comment #7 from Francois Charbonnier francois.charbonn...@inlibro.com ---
Hi Nicole, Hi Kyle,

I do not agree since it fixes an issue in Koha.

Koha already allows librarian to linked adult cards together. But once the
cards are linked together, if the guarantee is an adult, the patron edit page
doesn't display the Guarantor information. So you can't edit the link. If you
want to, you have to change the patron category to a child type, edit it and
then put back the correct patron category.

To me, it's a feature that needed to be fixed.

I agree there is a need to be able to hide parts of the patron edit page but I
think it should be part of a different feature. If we add the ability to
control the display of the edit patron page, we should be able to do it for
every part of the page.

What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13771] Koha 3.18 Help Files

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13771] Koha 3.18 Help Files

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13771

--- Comment #15 from Nicole C. Engard neng...@gmail.com ---
Created attachment 36500
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36500action=edit
Bug 13771: Add missing item search help file

This patch adds a help file for the staff item search.

To test:

* Click search
* click item search
* click help
* review the help file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13635] $record-title is called even if marc flavour is UNIMARC

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13635

--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Bernardo Gonzalez Kriegel from comment #3)
 Hi Jonathan,
 Seems that 'usmarc' is not a valid value for 'marcflavour' syspref,
 only MARC21, UNIMARC and NORMARC
 
 And the same error is on line 916 of addbiblio.pl
 
 Perhaps is better to write the code as:
 
 if ( $record ne -1 ) {
 if ( C4::Context-preference('marcflavour') =~/unimarc/i ) {
 $template-param( title = $record-subfield('200',a) );
 } else {
 $template-param( title = $record-title() );
 }
 }
 
 ... unless I'm mistaken.

Yes of course, you are right!
Now patch attached.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13784] Koha-stop-zebra should also work for disabled instances

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

  Attachment #36412|0   |1
is obsolete||

--- Comment #6 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 36508
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36508action=edit
Koha-stop-zebra should also work for disabled instances

Currently koha-stop-zebra will not stop zebra for disabled instances. It should
work more like koha-stop-sip, which does work for disabled instances. Also,
koha-stop-zebra is called by '/etc/init.d/koha-common stop' which clearly
should also apply to disabled instances.

To Test:
1) Disable a koha instance.
2) Run koha-stop-zebra INSTANCE. You should get message
   Instance INSTANCE disabled. No action taken.
3) Apply patch, and copy patched file debian/scripts/koha-stop-zebra
   to package site over /usr/sbin/koha-stop-zebra.
4) Disable koha instance.
5) Run koha-stop-zebra INSTANCE. It should now stop zebra.

http://bugs.koha-community.org/show_bug.cgi?id=13784
Signed-off-by: Mirko Tietgen mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11881] Small improvements in OPAC results list.

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

simith.dolive...@inlibro.com changed:

   What|Removed |Added

  Attachment #36496|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11881] Small improvements in OPAC results list.

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

simith.dolive...@inlibro.com changed:

   What|Removed |Added

  Attachment #34004|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13794] New: Input field values not translated

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

Bug ID: 13794
   Summary: Input field values not translated
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: maxime.beaul...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

The template translation tool does not translate input field values.
I have fixed a logical test marked by a #FIXME tag in tmpl_process3.pl.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13794] Input field values not translated

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

--- Comment #1 from Maxime Beaulieu maxime.beaul...@inlibro.com ---
Created attachment 36514
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36514action=edit
Fixed logical test in tmpl_process3.pl

The line:
next if $a eq 'value'  ($tag ne 'input' || (ref $attr-{'type'} 
$attr-{'type'}-[1] =~ /^(?:checkbox|hidden|radio|text)$/)); # FIXME

This portion: (ref $attr-{'type'}  $attr-{'type'}-[1] =~
/^(?:checkbox|hidden|radio|text)$/) checks if the input type is valid.

We get the following (wrong) logic:
next IF
$a eq value
AND
the tag is not an input OR the input type is valid

The test is true when : $a eq value, tag is an input, input type is valid
We skip the tag when it is valid, it is never translated.

I propose the following change:
  my $isValidType = ref $attr-{'type'}  $attr-{'type'}-[1] =~
/^(?:checkbox|hidden|radio|text)$/;
  next if $a eq 'value'  !($tag eq 'input'  $isValidType);

next IF
$a eq value
AND
NOT ( tag is an input AND input type is valid )
in short: NOT (tag is a valid input tag)

[ Alternative ] ( Not included in patch )
next if $a eq 'value'  ($tag ne 'input' || (ref $attr-{'type'} 
$attr-{'type'}-[1] !~ /^(?:checkbox|hidden|radio|text)$/));
No extra variable, at the cost of code readability.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13794] Input field values not translated

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

Maxime Beaulieu maxime.beaul...@inlibro.com changed:

   What|Removed |Added

 CC||eric.be...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13794] Input field values not translated

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13794

Maxime Beaulieu maxime.beaul...@inlibro.com changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10988] Allow login via Google OAuth2

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

--- Comment #28 from David Cook dc...@prosentient.com.au ---
(In reply to M. Tompsett from comment #26)

 I would think the parameter would be better renamed to $AuthenticatedEmail,
 because persona and this OAuth patch both authenticate against an Email
 address (the primary email address is used to find the user).
 

Yeah, I thought about that a bit, but it also sets a persona key in the
session, which I think might be used for persona session management, so
re-using it without careful checking could lead to weirdness with Persona. 

 NOO! Please hashref the parameter!
 If there are more than 3 parameters, you probably should use a hashref.

...

Yes, a single hashref would be nicer. If I were designing a new sub, I would
use a single hashref. However, I'm personally not planning on refactoring
C4::Auth::checkauth() and testing every use of it. Nor am I going to add
checking to checkauth() so that it can use a single hashref OR a bunch of
scalars. That just leads to more technical debt.

Of course, I'm not planning on upstreaming my OpenID Connect work at the moment
anyway, so it doesn't really matter. I'm sure whoever refactors checkauth()
someday will use a single hashref instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

--- Comment #24 from Nick Clemens n...@quecheelibrary.org ---
Created attachment 36515
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36515action=edit
MARC record with contained works

When displaying the contained works with this patch the last character is
chopped.  Presumably this is to remove punctuation, but for an incorrectly
punctuated field or field ending in ')' this could be problematic. 

In the attached record the first 700 contained work is badly punctuated and the
word orchestra is trimmed, for others a comma is trimmed and replaced with a
';' separator.  When testing it seems to be any character in the last field
displayed

AFAIK subject fields will trim a '.' on display, but not a ')' so maybe just
ensure only certain punctuation is trimmed if possible

Probably contained works should be separated by the '|' character as other
fields are for consistency throughout

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1985] Email notification of new OPAC comments

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

--- Comment #13 from M. Tompsett mtomp...@hotmail.com ---
Another reason this is currently failed qa. This modifies C4/Review.pm without
adding any tests. Don't worry, the patch I'm working on for this will handle
comment #11 and add tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1985] Email notification of new OPAC comments

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

--- Comment #17 from M. Tompsett mtomp...@hotmail.com ---
And by the way, comment 10 is still a valid issue. I figure it might be useful
to include it in the letter in the future, but no code was added to make that
possible.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1985] Email notification of new OPAC comments

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

--- Comment #15 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 36517
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36517action=edit
Bug 1985 - Add missing table variables, tweak License, and cleanup

In comment #11, it was mentioned that title and biblionumber from
the biblio table were not available as variables in the letter.

This corrects this by converting the parameter list to a hashref,
and adding the missing biblio number.

It also cleans up the license on C4/Review.pm to be in line with
the current coding guidelines license. Also strict and warning
have been changed to the 'Use Modern::Perl;' now.

TEST PLAN
-
1) Create test branch and apply patch
2) run installer/data/mysql/updatedatabase.pl
   -- this will add the required default letter.
3) In the staff client:
   a) set the CommentModeratorsEmail system preference.
  -- not setting it will mean you won't get any queued
 letters.
   b) modify the COMMENT_CREATED default letter as desired.
  -- feel free to add other things.
4) In the OPAC:
   a) Log in
   b) Find something
   c) Click on the 'Comments' tab
  -- Holdings/Title notes/Comments (#) is at the bottom
   d) Click 'Post or edit your comments on this item'
   e) In the window that pops up, type your comment.
   f) Click 'Submit and close this window'.
   g) Click 'Edit' and repeat steps e and f again.
5) In a mysql client:
   a) Open the koha database
   b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED';
  -- There should be at least two.
  -- They should be able to contain the borrower number, biblio
 title, and other borrower and biblio related things.
  -- Comments are at a biblio level, so items, and issues don't
 make sense as variables for the letter.
6) prove -v t/db_dependent/Review.t
6) Run the koha qa test tool.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1985] Email notification of new OPAC comments

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #36065|0   |1
is obsolete||

--- Comment #14 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 36516
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36516action=edit
Bug 1985 - Email notification of new OPAC comments

This feature adds YAS 'CommentModeratorsEmail', where an email (template code
COMMENT_CREATED) is sent when
a borrower creates/modifies an comment/review. The syspref is empty by default
and no email is sent when the
syspref is empty.

This feature is needed because we want to alert our content moderators to take
action when needed. Usually
it is our librarians who write reviews and this improvement makes the process
of moving Koha reviews to our
CMS more smooth.

TEST SETUP:
-1. Run updatedatabase.pl to add the syspref and the new letter template.
0. Go to admin/preferences.pl?tab=opac, and set the
'CommentModeratorsEmail'-syspref to your email-address.

TEST PLAN:
1. Log in to OPAC and find any Biblio.
2. Make a comment/review for it.
3. Check the koha.message_queue-table for any letter_code = 'COMMENT_CREATED'.
You should see the reasonable
   default message. You can change the message in tools/letter.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1985] Email notification of new OPAC comments

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #16 from M. Tompsett mtomp...@hotmail.com ---
Obviously item numbers and the like don't make sense in the context of this
bug, but fixing what is listed for what reports would require a separate
enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11998] Syspref caching issues

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #32874|0   |1
is obsolete||

--- Comment #72 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 36527
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36527action=edit
Bug 11998 - make syspref caching use Koha::Cache

This modifies the caching system in C4::Context to use Koha::Cache
instead of a custom implementation.

It should be applied on top of the other syspref caching patches.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11998] Syspref caching issues

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #32872|0   |1
is obsolete||

--- Comment #70 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 36525
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36525action=edit
Bug 11998 - sysprefs in memcached

The caching mechanism has been abstracted a little bit, and now supports
memcached for storing sysprefs. These should be correctly stored and
cleared so caching will work between processes.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11998] Syspref caching issues

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #32871|0   |1
is obsolete||

--- Comment #69 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 36524
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36524action=edit
Bug 11998 - move most syspref db access into Context.pm

There was a lot of direct database access in systempreferences.pl. This
moves a lot of it into C4::Context so that it'll interact with caching
better, and to centralise common functions and logging in one place.

Test plan:
* Make sure that creating, editing, deleting local use preferences works
* Make sure that other system preferences still function normally

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11998] Syspref caching issues

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #33746|0   |1
is obsolete||

--- Comment #77 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 36532
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36532action=edit
Bug 11998: Add Koha::Config::SystemPreference

This (dirty) patch extract the syspref set and delete routine into a
module.
It fixes the circular dependency and the logging problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11998] Syspref caching issues

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #33724|0   |1
is obsolete||

--- Comment #75 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 36530
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36530action=edit
Bug 11998 - remove logging from places where it shouldn't be

This prevents duplicate action_log entries when a preference is updated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11998] Syspref caching issues

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #33940|0   |1
is obsolete||

--- Comment #79 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 36534
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36534action=edit
Bug 11998 - fix some compile warnings

This lazy-loads C4::Context and some other modules so that they can be
be safely used by C4::Context without introducing problematic circular
dependencies.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11998] Syspref caching issues

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #33183|0   |1
is obsolete||

--- Comment #73 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 36528
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36528action=edit
Bug 11998: QA follow-up - fix the perlcritic error

% perlcritic C4/Context.pm
Variable declared in conditional statement at line 544, column 5.
Declare variables outside of the condition.  (Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11998] Syspref caching issues

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #33829|0   |1
is obsolete||

--- Comment #78 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 36533
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36533action=edit
Bug 11998 - tidy up the Koha::Config::SystemPreferences module a bit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11998] Syspref caching issues

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #33670|0   |1
is obsolete||

--- Comment #74 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 36529
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36529action=edit
Bug 11998 - fix compile warnings

This creates a simplified logging system that can be used by
C4::Context.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11998] Syspref caching issues

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #33725|0   |1
is obsolete||

--- Comment #76 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 36531
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36531action=edit
Bug 11998 - fix test case so it's testing the cache properly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11998] Syspref caching issues

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1985] Email notification of new OPAC comments

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

--- Comment #20 from M. Tompsett mtomp...@hotmail.com ---
Ignore comments #10 and #17. My second commit covers all that. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11998] Syspref caching issues

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #32870|0   |1
is obsolete||

--- Comment #68 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 36523
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36523action=edit
Bug 11998 - timeout for syspref caching

This adds a 30 second timeout for syspref caching so that when run under
plack, you don't end up with different workers having different ideas of
what the sysprefs are for too long.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11998] Syspref caching issues

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #32873|0   |1
is obsolete||

--- Comment #71 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 36526
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36526action=edit
Bug 11998 - add test case, fix issue found

Adds a test case with improved coverage of the caching functionality.
Fixes a bug that was uncovered by writing the test case.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1985] Email notification of new OPAC comments

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #36516|0   |1
is obsolete||

--- Comment #18 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 36521
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36521action=edit
Bug 1985 - Email notification of new OPAC comments

This feature adds YAS 'CommentModeratorsEmail', where an email (template code
COMMENT_CREATED) is sent when
a borrower creates/modifies an comment/review. The syspref is empty by default
and no email is sent when the
syspref is empty.

This feature is needed because we want to alert our content moderators to take
action when needed. Usually
it is our librarians who write reviews and this improvement makes the process
of moving Koha reviews to our
CMS more smooth.

TEST SETUP:
-1. Run updatedatabase.pl to add the syspref and the new letter template.
0. Go to admin/preferences.pl?tab=opac, and set the
'CommentModeratorsEmail'-syspref to your email-address.

TEST PLAN:
1. Log in to OPAC and find any Biblio.
2. Make a comment/review for it.
3. Check the koha.message_queue-table for any letter_code = 'COMMENT_CREATED'.
You should see the reasonable
   default message. You can change the message in tools/letter.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1985] Email notification of new OPAC comments

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #36517|0   |1
is obsolete||

--- Comment #19 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 36522
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36522action=edit
Bug 1985 - tweak License and lots of cleanup

In comment #11, it was mentioned that title and biblionumber from
the biblio table were not available as variables in the letter.

This corrects this by converting the parameter list to a hashref,
and adding the missing biblio number.

It also cleans up the license on C4/Review.pm to be in line with
the current coding guidelines license. Also strict and warning
have been changed to the 'Use Modern::Perl;' now.

Additionally, reviews.reviewid is now usable in the letter,
as is StaffBaseURL. These were required additions, because
comment #1 expressly says there should be a direct link to
approve or delete. I also included a review everything link,
since there could be multiple comments outstanding.

The default letter was tweaked as well to reflect these changes.

TEST PLAN
-
1) Create test branch and apply patch
2) run installer/data/mysql/updatedatabase.pl
   -- this will add the required default letter.
3) In the staff client:
   a) set the CommentModeratorsEmail system preference.
  -- not setting it will mean you won't get any queued
 letters.
   b) modify the COMMENT_CREATED default letter as desired.
  -- feel free to add other things.
4) In the OPAC:
   a) Log in
   b) Find something
   c) Click on the 'Comments' tab
  -- Holdings/Title notes/Comments (#) is at the bottom
   d) Click 'Post or edit your comments on this item'
   e) In the window that pops up, type your comment.
   f) Click 'Submit and close this window'.
   g) Click 'Edit' and repeat steps e and f again.
5) In a mysql client:
   a) Open the koha database
   b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED';
  -- There should be at least two.
  -- They should be able to contain the borrower number, biblio
 title, and other borrower and biblio related things.
  -- Comments are at a biblio level, so items, and issues don't
 make sense as variables for the letter.
6) prove -v t/db_dependent/Review.t
7) Run the koha qa test tool.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

--- Comment #15 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Colin, could you take a look at this again please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13785] Koha-disable should also stop SIP and zebra for instance

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13785

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13784] Koha-stop-zebra should also work for disabled instances

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13785] Koha-disable should also stop SIP and zebra for instance

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13785

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #36509|0   |1
is obsolete||

--- Comment #3 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 36518
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36518action=edit
Bug 13785 - Koha-disable should also stop SIP and zebra for instance

Currently koha-disable ONLY disables the instance in the apache conf
file. Presumably if you want to disable the instance, you also want
its processes to stop, so this patch will stop zebra, if running,
and SIP, if enabled.

Depends on Bug 13784.

To Test:
1) Have an enabled instance, with zebra and SIP running.
2) Run koha-disable INST. Note that after, both zebra and SIP
   will still be running.
3) Re-enable INST.
4) Apply patch, and then copy debian/scripts/koha-disable to
   package site, over /usr/sbin/koha-disable.
5) Run koha-disable INST. You should now see that both zebra
   and SIP have been stopped.

Signed-off-by: Mirko Tietgen mi...@abunchofthings.net
Signed-off-by: Robin Sheat ro...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13784] Koha-stop-zebra should also work for disabled instances

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

--- Comment #7 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 36520
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36520action=edit
Bug 13784: Koha-stop-zebra should also work for disabled instances

Currently koha-stop-zebra will not stop zebra for disabled instances. It should
work more like koha-stop-sip, which does work for disabled instances. Also,
koha-stop-zebra is called by '/etc/init.d/koha-common stop' which clearly
should also apply to disabled instances.

To Test:
1) Disable a koha instance.
2) Run koha-stop-zebra INSTANCE. You should get message
   Instance INSTANCE disabled. No action taken.
3) Apply patch, and copy patched file debian/scripts/koha-stop-zebra
   to package site over /usr/sbin/koha-stop-zebra.
4) Disable koha instance.
5) Run koha-stop-zebra INSTANCE. It should now stop zebra.

http://bugs.koha-community.org/show_bug.cgi?id=13784
Signed-off-by: Mirko Tietgen mi...@abunchofthings.net
Signed-off-by: Robin Sheat ro...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13785] Koha-disable should also stop SIP and zebra for instance

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13785

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #36518|0   |1
is obsolete||

--- Comment #4 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 36519
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36519action=edit
Bug 13785 - Koha-disable should also stop SIP and zebra for instance

Currently koha-disable ONLY disables the instance in the apache conf
file. Presumably if you want to disable the instance, you also want
its processes to stop, so this patch will stop zebra, if running,
and SIP, if enabled.

Depends on Bug 13784.

To Test:
1) Have an enabled instance, with zebra and SIP running.
2) Run koha-disable INST. Note that after, both zebra and SIP
   will still be running.
3) Re-enable INST.
4) Apply patch, and then copy debian/scripts/koha-disable to
   package site, over /usr/sbin/koha-disable.
5) Run koha-disable INST. You should now see that both zebra
   and SIP have been stopped.

Signed-off-by: Mirko Tietgen mi...@abunchofthings.net
Signed-off-by: Robin Sheat ro...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11881] Small improvements in OPAC results list.

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

--- Comment #30 from M. Tompsett mtomp...@hotmail.com ---
(In reply to Jonathan Druart from comment #27)
 The opac.css does not look good.
 With your patch:
 -rw-r--r-- 1 koha koha 42132 Mar  4 16:25 bootstrap/css/opac.css
 
 $lessc --compress bootstrap/less/opac.less  bootstrap/css/opac.css
 -rw-r--r-- 1 koha koha 42946 Mar  4 16:25 bootstrap/css/opac.css

mtompset@ubuntu:~/kohaclone$ git reset --hard origin/masterHEAD
is now at 45e5afb Bug 13731: Suggestions reason does not save on updating the
status
mtompset@ubuntu:~/kohaclone$ ls -la koha-tmpl/opac-tmpl/bootstrap/css/opac.css
-rw-rw-r-- 1 mtompset mtompset 42879 Mar  5 00:01
koha-tmpl/opac-tmpl/bootstrap/css/opac.css
mtompset@ubuntu:~/kohaclone$ lessc --compress
koha-tmpl/opac-tmpl/bootstrap/less/opac.less 
koha-tmpl/opac-tmpl/bootstrap/css/opac.css
mtompset@ubuntu:~/kohaclone$ ls -la koha-tmpl/opac-tmpl/bootstrap/css/opac.css
-rw-rw-r-- 1 mtompset mtompset 43371 Mar  5 00:01
koha-tmpl/opac-tmpl/bootstrap/css/opac.css
mtompset@ubuntu:~/kohaclone$

I don't think it is this patch per say.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480

--- Comment #36 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Katrin Fischer from comment #35)
 I think this probably shouldn't go on to the stable branches as it would
 break custom plugins the library might have. 

Do you have any reasons to say that it would break custom plugins? Part of some
complexity here is backward compatibility.
BTW I agree that this is not targeted for the stable branches in the first
place.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13143] Add a tool to show a Koha's password

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13143

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #18 from Robin Sheat ro...@catalyst.net.nz ---
My issue is that the pausing thing means it can't be used within a script.

It shouldn't say password for x is y, it should just output the password, and
it should only block if it's outputting to a terminal, otherwise it'll block
forever.

A test for this is here:

http://stackoverflow.com/questions/911168/how-to-detect-if-my-shell-script-is-running-through-a-pipe

running koha-passwd instance | cat should output the password and then finish
without issuing a clear or anything. This makes it easy for people who need the
password as part of some other shell script.

Additionally, it'd probably be good (although I wouldn't consider it a blocker)
to make a function in koha-functions.sh to fetch the password and use that,
that way other scripts in the koha-* set can use that (if you're really keen
you can change them to use it, but certainly don't consider than necessary.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #41 from Robin Sheat ro...@catalyst.net.nz ---
FYI, the catalyst repo branch now has basic authority search working. There's
still a good bit to do (paging, biblio counts, many more things aren't there
yet), but results are coming out so I'm counting that as a win :)

You can see it in action here:

http://elasticsearch.koha.catalystdemo.net.nz/cgi-bin/koha/opac-authorities-home.pl?op=do_searchtype=opacoperator=containsvalue=robertmarclist=anyand_or=andorderby=HeadingAsc

I think the fact that there are so many Jordan, Roberts is due to the data, but
I haven't actually checked yet. At the moment it just replicates how the zebra
version works, but I do want to push some of the things into the indexing side
so that there's less computation needed to display results and things can
perhaps be made a bit simpler. We can do this because we can store arbitrary
fields in elasticsearch alongside the actual records.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Severity|normal  |enhancement
 CC||katrin.fisc...@bsz-bw.de

--- Comment #35 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I think this probably shouldn't go on to the stable branches as it would break
custom plugins the library might have. As the title says improvements
switching to enh - but I know it's not quite.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13784] Koha-stop-zebra should also work for disabled instances

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

--- Comment #4 from Larry Baerveldt la...@bywatersolutions.com ---
It's not even that weird of a situation. We often need to temporarily block
access to a site for both the public catalog and the staff client (such as when
performing maintenance, or other actions where we wouldn't want the database to
be touched), and disabling the instance is the fastest way to do that, and
still present a maintenance page to the user. Unless you remember to stop
zebra manually first, then if you have already disabled the instance, then you
*can't* stop zebra without just killing the processes. This patch addresses
that.

Also, I did just submit a patch for koha-disable to stop zebra (and SIP) (see
13785). However, for that patch to work, this one first has to be pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11368] Add script to import Lexile scores

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

  Attachment #28092|0   |1
is obsolete||

--- Comment #5 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 36438
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36438action=edit
Bug 11368 - Add script to import Lexile scores

Koha needs a script to automate the importing of Lexile score data for
titles that have available scores but are not currently in the title's
record.

This script will take a CSV file of Lexile scores, and locate any
matching records in the Koha database ( by ISBN ). If the record already
has a score, it will be updated. If not, the Lexile score field will be
created.

Test Plan:
1) Apply this patch
2) Catalog a record for each of the following ISBNs:
   0789170191
   9780673779410
3) Download the file LexileTitlesTruncated.txt attached
   to this bug report
4) Run the script from the command line:
   ./misc/migraction_tools/import_lexile.pl -v --file
/path/to/LexileTitlesTruncated.txt
5) View those records in Koha
6) Note those records now have valid Lexile scores
7) Edit the Lexile score ( 521$a ) and change the value to something else
8) Repeat step 4
9) Note the original Lexile score has been restored

Signed-off-by: Mirko Tietgen mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11368] Add script to import Lexile scores

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13784] Koha-stop-zebra should also work for disabled instances

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13784

--- Comment #5 from Robin Sheat ro...@catalyst.net.nz ---
Well the idea being that if koha-disable stops zebra, then zebra still running
would be a weird situation :)

I'm quite happy with all these patches, all going well I'll have a real look at
them tomorrow and get them through.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11430] Search history: Delete selected lines

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

  Attachment #33835|0   |1
is obsolete||

--- Comment #74 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Created attachment 36444
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36444action=edit
Bug 11430: DB changes: Add the primary key for search_history

Adds a primary key search_history.id.

Signed-off-by: sonia BOUIS sonia.bo...@univ-lyon3.fr

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13611] Serial enumeration not visible in the opac-user.pl when browsing own holds.

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13611

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

Dobrica Pavlinusic dpav...@rot13.org changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13789

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13697] Syspref to not add a fee when a patron changes to a category with enrolment fee

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697

Juliane jcas...@ville-roubaix.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||jcas...@ville-roubaix.fr

--- Comment #5 from Juliane jcas...@ville-roubaix.fr ---
Ok, tested and it works. 

Case 1 tested: the patron has already a category with enrolment fee, I change
it to another category with enrolment fee, the patron has no enrolment fee to
pay 

Case 2 tested : the patron has a free category , I change it to a category with
enrolment fee, the patron has no enrolment fee to pay



Howether, I created the 13792 bugzilla : testing make me realise a bug about
payment on fees on the master version of koha (not linked to this patch)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13611] Serial enumeration not visible in the opac-user.pl when browsing own holds.

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13611

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #36279|0   |1
is obsolete||

--- Comment #5 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 36439
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36439action=edit
Bug 13611 - Serial enumeration not visible in the opac-user.pl when browsing
own holds.

Having placed holds on Serial Items with an enumchron, and browsing the
opac-user.pl's Holds-tab, the user cannot see which numbers of
magazines/serials he has on hold.

This patch appends the koha.items.enumchron after the title component in the
opac-user.pl's Holds-view.

Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13789] New: facets with accented utf-8 characters generate double encoded links

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789

Bug ID: 13789
   Summary: facets with accented utf-8 characters generate double
encoded links
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: dpav...@rot13.org
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3] mod_env module checking in installer.pl

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3

--- Comment #1 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 36440
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36440action=edit
Bug 13744: Fix datatables paging on 'Holds to pull' report

The paging of the datatables on the 'holds to pull' report
page is broken without this patch.

To test:
- Make sure that some holds are placed on available items
  in your installation
- Go to the circulation start page
- Open the 'holds to pull' report
- Verify that the patch fixes the paging on the result table

Also: Fixes None in the filter pull downs to be translatable.
Signed-off-by: Nicole nic...@bywatersolutions.com
Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13790] Add unique id issue_id to issues and oldissues tables

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 36441
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36441action=edit
Bug 13790 - Add unique id issue_id to issues and old_issues tables

Test Plan:
1) Use a database with existing issues and old issues
2) Apply this patch
3) Run updatedatabase
4) Inspect the database
   a) old_issues should now have a column issue_id starting with 1
   b) issues should now have a column issue_id starting with the number
  of rows in the old_issues table plus one

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13790] Add unique id issue_id to issues and oldissues tables

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13791] New: Plack out of the box

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791

Bug ID: 13791
   Summary: Plack out of the box
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: dpav...@rot13.org
QA Contact: testo...@bugs.koha-community.org

Offer plack as valid alternative for installation.

For now, some progress is documented at wiki page:

http://wiki.koha-community.org/wiki/Plack

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13790] New: Add unique id issue_id to issues and oldissues tables

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

Bug ID: 13790
   Summary: Add unique id issue_id to issues and oldissues tables
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13790] Add unique id issue_id to issues and oldissues tables

2015-03-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 36442
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36442action=edit
Bug 13790 - Update Koha Schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >