[Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to M. de Rooy from comment #2)
 Maybe use File::Temp instead of hardcoding /tmp ?

Done.

(In reply to M. de Rooy from comment #3)
 BTW Note that if I would have permissions to write in the original log dir,
 but SELinux would not allow it, your test here would not work.

I don't know a lot about SELinux, how can you know if a directory is writable?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13878] Typo in help file (aqbudgets.tt)

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13878

--- Comment #1 from Héctor Eduardo Castro Avalos hector.hecax...@gmail.com ---
Created attachment 37021
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37021action=edit
Bug 13878 - Typo in help file (aqbudgets.tt)

Bug 13878 - Typo in help file (aqbudgets.tt)

Test plan:
1) Go to url
'koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/aqbudgets.tt:15' and check
the typo wan or go to Administration  Acquisition parameters  Funds  Help
2) Apply the patch
3) Repeat step 1 and check if the typo is fixed.

Sponsored-by: Universidad de El Salvador

Signed-off-by: Hector Eduardo Castro Avalos hector.hecax...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #37014|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 37022
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37022action=edit
Bug 13876: Fallback to /tmp if logdir is not writable

If the logdir directory is not writable by the koha user, the installer
should not explode.
This patch uses a temporary directory as a fallback.
That means that the history won't be kept.

Test plan:
0/ Generate an update (modify updatedatabase.pl and kohaversion)
1/ Make sure the permission are not correct on $logdir
2/ Go on the interface and execute the update entry.
3/ Confirm that the log has been created in a temporaty directory.

Retry with correct permissions and confirm the log will be created in
$logdir.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12739] SendAlerts function does not take care of html format or UTF-8

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739

--- Comment #22 from David Cook dc...@prosentient.com.au ---
(In reply to Tomás Cohen Arazi from comment #19)
 David, why aren't you using encode('UTF-8',$string) as stated in
 http://wiki.koha-community.org/wiki/Handling_UTF8_in_development
 
 Please take a look at my followup and check it is ok.

I didn't eve know that was a thing! Neat! It might be an idea to add the thing
about using utf-8 in emails... or UTF-8 if that works as well for the
content type.

At a glance, your patch looks good to me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13878] Typo in help file (aqbudgets.tt)

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13878

Héctor Eduardo Castro Avalos hector.hecax...@gmail.com changed:

   What|Removed |Added

   Assignee|neng...@gmail.com   |hector.hecax...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13878] Typo in help file (aqbudgets.tt)

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13878

Héctor Eduardo Castro Avalos hector.hecax...@gmail.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13872

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13878] Typo in help file (aqbudgets.tt)

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13878

Héctor Eduardo Castro Avalos hector.hecax...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

Héctor Eduardo Castro Avalos hector.hecax...@gmail.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13878

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

--- Comment #4 from Héctor Eduardo Castro Avalos hector.hecax...@gmail.com ---
(In reply to Nicole C. Engard from comment #3)
 Thanks for finding the typo, but be aware that the help files haven't
 followed the capitalization rules in the past.  
 
 Nicole

Hi Nicole

I will change the patch about the capitalization and let it as the original
one, what would you recommend me to do?

By the way there are another typo in file:
intranet-tmpl/prog/en/modules/help/admin/aqbudgets.tt:15

It reads: In the form that appears you wan to enter the basics about your fund.

I will file a new bug for the typo and link it with this as See also.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13878] New: Typo in help file (aqbudgets.tt)

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13878

Bug ID: 13878
   Summary: Typo in help file (aqbudgets.tt)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Documentation
  Assignee: neng...@gmail.com
  Reporter: hector.hecax...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Typo in file: intranet-tmpl/prog/en/modules/help/admin/aqbudgets.tt:15

It reads: In the form that appears you wan to enter the basics about your fund.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13878] Typo in help file (aqbudgets.tt)

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13878

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #37021|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13878] Typo in help file (aqbudgets.tt)

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13878

--- Comment #2 from Marc Véron ve...@veron.ch ---
Created attachment 37025
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37025action=edit
[Signed-off] Bug 13878 - Typo in help file (aqbudgets.tt)

Test plan:
1) Go to url
'koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/aqbudgets.tt:15' and check
the typo wan or go to Administration  Acquisition parameters  Funds  Help
2) Apply the patch
3) Repeat step 1 and check if the typo is fixed.

Sponsored-by: Universidad de El Salvador

Signed-off-by: Hector Eduardo Castro Avalos hector.hecax...@gmail.com

Typo is fixed.
Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #36997|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

--- Comment #5 from Marc Véron ve...@veron.ch ---
Created attachment 37026
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37026action=edit
[Signed off] Bug 13872 - Typographical error on columns_settings.tt

Test plan:
1) Go to url
'koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/columns_settings.tt' line 9
and check the typo columsn and change for columns.
2) See also changes for Column settings to Columns settings at lines 3 and 15
3) Apply the patch
4) Repeat step 1 and chek if the typo is fixed or go to Administration 
Additional parameters  Configure columns and go to Help page.

Sponsored-by: Universidad de El Salvador

Signed-off-by: Hector Eduardo Castro Avalos hector.hecax...@gmail.com

Typo is fixed
Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13878] Typo in help file (aqbudgets.tt)

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13878

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11385] C4::SQLHelper should be removed

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385
Bug 11385 depends on bug 12633, which changed state.

Bug 12633 Summary: SQLHelper replacement - C4::Members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com ---
No track of SQLHelper in C4::Members anymore :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Woohoo!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11385] C4::SQLHelper should be removed

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385
Bug 11385 depends on bug 12633, which changed state.

Bug 12633 Summary: SQLHelper replacement - C4::Members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com ---
Sorry, but there is one left in C4::Members::Search :-/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

  Attachment #36939|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #36 from Marc Véron ve...@veron.ch ---
Created attachment 37023
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37023action=edit
[Signed-off] Bug 13601: The fallback regex should contain the time part

On displaying a sql date, if the dateformat is not set to sql, the
output should contain the date.
In the previous version, the fallback regex (used for sql format) did not
included the time part (hh:mm:ss).

Checked out an item with due date an ddue time. Time displays as expected.
Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13822] Patron autocomplete search is severly limited

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

--- Comment #5 from Marc Véron ve...@veron.ch ---
Created attachment 37024
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37024action=edit
[Signed-off] Bug 13822 - Patron autocomplete search is severly limited

The script that returns data for the patron autocomplete does not use
C4::Members::Search. Instead it uses bespoke code that does not behave like the
traditional search and is very limited in how it can search.

If, for example, I search for Kyle Hall in the standard search, I would get
Kyle Hall back as a result. For the autocomplete search, I will not.

This script should use C4::Members::Search to provide better searching and to
keep the code base DRY.

Test Plan:
1) Enable the system preference CircAutocompl
2) Create a user with the first name Test and the surname User
3) Perform a checkout autocomplete search for Test User
4) Note you do not get the user as a result
5) Apply this patch
6) Try different combinations of Test and User such as
   Test User
   User Test
   U Test
   Test U
   etc.
7) Note these searches now work

Folllowed test plan, works as expected
Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531

--- Comment #21 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37046
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37046action=edit
[PASSED QA] Bug 13531: QA follow up

A minor QA comment.

::: misc/migration_tools/bulkmarcimport.pl
@@ +271,5 @@
  my ( $error, $results, $totalhits ) = C4::Search::SimpleSearch( 
 $query, 0, 3, [$server] );
 +# changed to warn so able to continue with one broken record
 +if ( defined $error ) {
 +warn unable to search the database for duplicates : $error;
 +next;

For consistency with the rest of the script, should this perhaps be:

next RECORD;

Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2542] Manual invoice fails on superfluous characters ( e.g. '$' )

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #4 from Marc Véron ve...@veron.ch ---
The patch prevents aumount with non-number characters.

Questions:

I can enter a negative number. Should that be possible? - It changes an invoice
to kind of credit.

Additionally, I can still enter non-number characters in Create manual credit
(and put negative numbers here as well, changing a credit to kind of invoice).

Should that be fixed here or with a separate Bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531

--- Comment #22 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37047
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37047action=edit
[PASSED QA] Bug 13531 - Follow up

Add logging of errors.

Signed-off-by: Magnus Enger mag...@enger.priv.no
More errors are indeed showing up in the log.
(I took the liberty of changing the commit message a little bit.)

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #35147|0   |1
is obsolete||
  Attachment #35295|0   |1
is obsolete||
  Attachment #36625|0   |1
is obsolete||
  Attachment #37044|0   |1
is obsolete||

--- Comment #20 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37045
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37045action=edit
[PASSED QA] Bug 13531 - bulkmarcimport bombs if no match is found Changed the
die statment to a warn allowing the import to continue.

Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13880] Allow svc/report to be passed sql parameters

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37042
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37042action=edit
Bug 13880 - Allow svc/report to be passed sql parameters

The same feature added to the opac svc/report in bug 9915 should be
added to the staff side.

Test Plan:
1) Apply this patch
2) Create this report:
   SELECT * FROM biblio WHERE biblionumber = biblionumber
3) Note the id of the report
4) Go to the URL
/cgi-bin/koha/svc/report?id=YOUR_REPORT_IDsql_params=SOME_VALID_BIBLIONUMBER
5) Note you recieve a json response

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13880] Allow svc/report to be passed sql parameters

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8007] Discharge management

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #37029|0   |1
is obsolete||

--- Comment #98 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37030
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37030action=edit
[PASSED QA] Bug 8007: Discharge - DB changes

This patch adds:
- syspref useDischarge
- the new table discharges
- the discharge notice

Signed-off-by: Lucie lucie.rousse...@dracenie.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8007] Discharge management

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #100 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37032
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37032action=edit
[PASSED QA] Bug 8007: Discharge - Glue

This patch adds:
- links to the new pages.
- syspref description
- links on the main page (intranet)
- the DISCHARGE type for debarment

Signed-off-by: Lucie lucie.rousse...@dracenie.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8007] Discharge management

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #99 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37031
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37031action=edit
[PASSED QA] Bug 8007: Discharge - DBIx changes

Signed-off-by: Lucie lucie.rousse...@dracenie.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9120] Typing the ENTER key when submitting a tag from search results reloads the page

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9120

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch
 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9120] Typing the ENTER key when submitting a tag from search results reloads the page

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9120

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

  Attachment #36991|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13881] New: Add desk management

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Bug ID: 13881
   Summary: Add desk management
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: nicolas.legr...@bulac.fr
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

A Library may have multiple desks inside its public space. If desks are defined
in Koha, a librarion in public space should set her desk when opening her
session as she should set her library. When items are checked-in and trigger a
hold, the hold may be attachable to a desk and the patron may be advertised
where she can retreive her hold.

This may also be usefull when items come from closed stacked. Some may be kept
as hold behind the everyday items issue desk, some may be behind the rare books
section desks.

Such a module was developped by Progilone for the BULAC Koha 3.2, check:
https://github.com/BULAC/koha/blob/bulac-dead_end-3.02.04/C4/Stack/Desk.pm.
The BULAC is going to port it to current master, with a more Kohaish style and
comments. The circulation logic will be a bit different from those sources, as
the BULAC plans to use Holds for books coming from closed stacked and dumps its
overkill stack request module.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13881] Add desk management

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881

Nicolas Legrand nicolas.legr...@bulac.fr changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
 CC||nicolas.legr...@bulac.fr

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13021] DataTables server-side processing - guarantor search

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13021

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||13879

--- Comment #31 from Jonathan Druart jonathan.dru...@biblibre.com ---
Regression found, will be fixed soon on bug 13879.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13879] DataTables server-side processing for patrons - sort is broken

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||13021

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13868] Date on routing list slip is not well formatted

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13868

--- Comment #3 from Marc Véron ve...@veron.ch ---
Created attachment 37041
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37041action=edit
[Signed-off] Bug 13868: Correct formatting of date on routing list slip

The date planned printed on the issue slip is not formatted
according to the dateformat system preference setting.

To test:
- enable RoutingSerials
- create a subscription
- create a routing list from the serial collection page
- use the 'print list' links next to the issues to print a routing list
- verify that the date there is not displayed according to the dateformat
  system preference without the patch, but is correct with the patch applied

Followed test plan, date appears according to the date format syspref.
Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13868] Date on routing list slip is not well formatted

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13868

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13868] Date on routing list slip is not well formatted

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13868

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #36994|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #39 from Nicole C. Engard neng...@gmail.com ---
I'm seeing two new permissions - Lists and then the permission to delete under
that.  Does the lists permission do anything? Does it control who can use
lists? I'm looking for the manual.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13879] New: DataTables server-side processing for patrons - sort is broken

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879

Bug ID: 13879
   Summary: DataTables server-side processing for patrons - sort
is broken
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: jonathan.dru...@biblibre.com
  Reporter: jonathan.dru...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Bug 13021 introduced a regression for guarantor search and patron search for
orders, the sort is broken.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12820] SIP2 does not send rental charge fee!

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12820] SIP2 does not send rental charge fee!

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #36155|0   |1
is obsolete||

--- Comment #14 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37038
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37038action=edit
[PASSED QA] Bug 12820: Handle rental fees in Sip issue and renew

Implement correct handling of fees associated with checking out
an item.
This is associated with fee acknowledged field (BO)

To quote from the Sip2 document
 If this field is N in a Checkout message and there is a fee
associated with checking out the item, the ACS should tell the
SC in the Checkout Response that there is a fee, and refuse to
check out the item. If the SC and the patron then interact and the
patron agrees to pay the fee, this field will be set to Y on a second
Checkout message, indicating to the ACS that the patron has acknowledged
the fee and checkout of the item should not be refused just
because there is a fee associated with the item

So there are two Checkout requests the first with BO not set to Y is
rejected but the fee amount is returned. The Second Checkout with BO set
to Y should succeed.

Added a debug log message indicating why we block a checkout
when we dont otherwise indicate

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12820] SIP2 does not send rental charge fee!

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820

--- Comment #15 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37039
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37039action=edit
Bug 12820 [QA Followup] - Tab and whitespace cleanup

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13880] New: Allow svc/report to be passed sql parameters

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880

Bug ID: 13880
   Summary: Allow svc/report to be passed sql parameters
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The same feature added to the opac svc/report in bug 9915 should be added to
the staff side.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13880] Allow svc/report to be passed sql parameters

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Component|Architecture, internals,|Reports
   |and plumbing|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13880] Allow svc/report to be passed sql parameters

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8007] Discharge management

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #101 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37033
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37033action=edit
[PASSED QA] Bug 8007: Discharge management

This patch is the main patch. It adds new package and files for the new
pages (opac-discharge, members/discharge and members/discharges).

At the intranet, it is now possible to generate a discharge for a patron.
At the opac, a patron can request a discharge and a discharge if it has
been validated by a librarian.

Requirements:
The perl module PDF::FromHTML

New sysprefs:
 - useDischarge: Allows librarians to discharge borrowers and borrowers
   to request a discharge

New letter with a letter_code DISCHARGE.

Test plan:
- Switch on the syspref useDischarge.
- Verify a new tab appears in the patron page (intranet and opac).
- Verify the discharge cannot be generated if the patron has issues.
- Verify the patron can request a discharge from it's opac area.
- The request appears on the main page (intranet).
- Generate the discharge from the intranet.
- Try to download it (from the opac and the intranet).

Signed-off-by: Lucie lucie.rousse...@dracenie.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8007] Discharge management

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #102 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37034
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37034action=edit
[PASSED QA] Bug 8007: Discharge - Add unit tests

Signed-off-by: Lucie lucie.rousse...@dracenie.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create new fines with an amount outstanding of 0

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8007] Discharge management

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #105 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37037
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37037action=edit
[PASSED QA] Bug 8007: Compatibility with bug 11944

This patch should be applied to work with bug 11944.
If you don't have 11944 yet, just don't apply this patch.

Note that the line
  binmode(STDOUT);
in pl files is mandatory.

It comes from bug 11944 that adds the line
  binmode( STDOUT, :utf8 );
in C4::Templates::gettemplate.

Signed-off-by: Lucie lucie.rousse...@dracenie.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8007] Discharge management

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #104 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37036
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37036action=edit
[PASSED QA] Bug 8007: Replace HTML::HTMLDoc with PDF::FromHTML

Signed-off-by: Lucie lucie.rousse...@dracenie.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8007] Discharge management

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #103 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37035
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37035action=edit
[PASSED QA] Bug 8007 : Discharge - Adding Perl dependencie

HTML::HTMLDoc is required in order to generate the discharges in PDF format.

Signed-off-by: Lucie lucie.rousse...@dracenie.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531

--- Comment #19 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37044
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37044action=edit
[PASSED QA] Bug 13531 - bulkmarcimport bombs if no match is found Changed the
die statment to a warn allowing the import to continue.

Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13869] Wrong capitalization on guided reports page

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3125] IE7-8: Selected columns list in Reports Dictionary is not showing column names.

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3125

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #3 from Marc Véron ve...@veron.ch ---
(In reply to Jonathan Druart from comment #2)
 Is this one solved with newer versions of IE?

I compared IE 11 with FF 36.0, both work the same way, no problems found.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417

--- Comment #41 from Nicole C. Engard neng...@gmail.com ---
Created attachment 37051
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37051action=edit
permissions

I see two new permissions - and I see that one of the patches here is to rename
the delete permission. So my question is why are there 2 permission checkboxes?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13882] Adding new unit tests in t/Borrower.t, testing all 'borrower' database fields

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882

--- Comment #1 from Julian FIOL julian.f...@biblibre.com ---
Created attachment 37054
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37054action=edit
Bug 13882 : Adding new unit tests in t/Borrower.t, testing all 'borrower'
database fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417

--- Comment #42 from Jonathan Druart jonathan.dru...@biblibre.com ---
Sorry yes, it's delete_public_lists (not manage).
And, there is 1 permission in the group of permissions Lists.
It's the first permission of the List module, we can imagine other
permissions for this module.
Have a look at the userflags and permissions tables: 1 flag can have several
permissions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #37022|0   |1
is obsolete||

--- Comment #7 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 37052
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37052action=edit
Bug 13876: Fallback to /tmp if logdir is not writable

If the logdir directory is not writable by the koha user, the installer
should not explode.
This patch uses a temporary directory as a fallback.
That means that the history won't be kept.

Test plan:
0/ Generate an update (modify updatedatabase.pl and kohaversion)
1/ Make sure the permission are not correct on $logdir
2/ Go on the interface and execute the update entry.
3/ Confirm that the log has been created in a temporaty directory.

Retry with correct permissions and confirm the log will be created in
$logdir.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
Adding a follow-up for completely resolving encountered issues.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13697] Syspref to not add a fee when a patron changes to a category with enrolment fee

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697

--- Comment #7 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37049
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37049action=edit
Bug 13697 [QA Followup] - Add Unit Test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13697] Syspref to not add a fee when a patron changes to a category with enrolment fee

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #36234|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37048
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37048action=edit
[PASSED QA] Bug 13697 : Syspref to not add a fee when a patron changes to a
category with enrolment fee

By default this syspref is Do to keep the previous behaviour.

Test plan :

1/ create 2 categories (A  B). B with enrolment fee
2/ create a patron in category A
3/ change the patron category from A to B
4/ check that the patron has an enrolment fee to pay

Apply the patch

1/ create a new patron in category A
2/ change the patron category from A to B.
3/ check that the patron has an enrolment fee to pay
4/ change the system preference 'FeeOnChangePatronCategory' to 'Don't';
5/ create a new patron in category A
6/ change the patron category from A to B
7/ check that the patron has no enrolment fee to pay

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13882] Adding new unit tests in t/Borrower.t, testing all 'borrower' database fields

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882

Julian FIOL julian.f...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded eng)

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9269

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9269] Remove DefaultLanguageField008 syspref

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9269

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=7601
 CC||ve...@veron.ch

--- Comment #3 from Marc Véron ve...@veron.ch ---
See Bug 7601

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13882] New: Adding new unit tests in t/Borrower.t, testing all 'borrower' database fields

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882

Bug ID: 13882
   Summary: Adding new unit tests in t/Borrower.t, testing all
'borrower' database fields
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: trivial
  Priority: P5 - low
 Component: Test Suite
  Assignee: julian.f...@biblibre.com
  Reporter: julian.f...@biblibre.com
QA Contact: gmcha...@gmail.com

Adding new unit tests in t/Borrower.t, testing all 'borrower' database fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13869] Wrong capitalization on guided reports page

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #36996|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13869] Wrong capitalization on guided reports page

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869

--- Comment #4 from Marc Véron ve...@veron.ch ---
Created attachment 37050
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37050action=edit
[Signed-off] Bug 13869: Wrong capitalization of 'Save Report' in guided reports

On the last step of saving a new guided report to the database,
the button is labelled 'Save Report', but should be 'Save report'.

To test:
- Create a new guided report from the reports page
- Check on the very last step, when saving the report to the
  database, the button is labelled 'Save Report'
- With the patch applied, this reads 'Save report' instead

http://bugs.koha-community.org/show_bug.cgi?id=13868

Works as expected.
Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

--- Comment #6 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Will sign off on this one with a follow-up. Please wait :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417

--- Comment #40 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Nicole C. Engard from comment #39)
 I'm seeing two new permissions - Lists and then the permission to delete
 under that.  Does the lists permission do anything? Does it control who can
 use lists? I'm looking for the manual.

Hi Nicole,
This patchset only introduced 1 'manage_shelves' permission.
If set, the librarian will be able to manage all shelves.
There is no specific permission for deletion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

--- Comment #8 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 37053
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37053action=edit
Bug 13876: [QA Follow-up] Resolve updatedatabase logfile issues

This patch removes the test on write permissions of the logdir.
It uses File::Temp to generate a file in the logdir or otherwise in
a system tmp dir.
This resolves issues with both write permissions as well as SELinux
denials.
Note that after generating an empty file, we are appending to it in
the system statement.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY of message_queue

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #16 from Kyle M Hall k...@bywatersolutions.com ---
I got this error when I tried to update my db:
DBD::mysql::db do failed: ALTER TABLE causes auto_increment resequencing,
resulting in duplicate entry '9' for key 'PRIMARY' at
installer/data/mysql/updatedatabase.pl line 6750.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY of message_queue

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793

--- Comment #18 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37028
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37028action=edit
Bug 7793 - Simplify db update

Since message_id is not linked to anything else in the database, we
can ensure the message_id's are unique by simply dropping the column
and recreating it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY of message_queue

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #36987|0   |1
is obsolete||

--- Comment #17 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37027
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37027action=edit
[SIGNED-OFF] Bug 7793 - redefine the field message_id as PRIMARY KEY of
message_queue

Making message_queue work nicely with DBIx.

DROP the existing KEY and replace with an PRIMARY KEY.
If somebody has managed to get duplicate message_ids in his/her
message_queue-table, this patch takes care of them as well, but givin
all duplicate message_id's a new id.

TEST INSTRUCTIONS: in the patch.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY of message_queue

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8007] Discharge management

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #36394|0   |1
is obsolete||
  Attachment #36395|0   |1
is obsolete||
  Attachment #36396|0   |1
is obsolete||
  Attachment #36397|0   |1
is obsolete||
  Attachment #36398|0   |1
is obsolete||
  Attachment #36399|0   |1
is obsolete||
  Attachment #36400|0   |1
is obsolete||
  Attachment #36401|0   |1
is obsolete||

--- Comment #97 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37029
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37029action=edit
[PASSED QA] Bug 8007: Discharge - DB changes

This patch adds:
- syspref useDischarge
- the new table discharges
- the discharge notice

Signed-off-by: Lucie lucie.rousse...@dracenie.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8007] Discharge management

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13879] DataTables server-side processing for patrons - sort is broken

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13879] DataTables server-side processing for patrons - sort is broken

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 37040
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37040action=edit
Bug 13879: Fix sort on patron search (guarantor and linked to orders)

This patch fixes a regression introduced by bug 13021.

Test plan:
1/ Go on a child detail page  edit
2/ Click on Set a patron as a guarantor
3/ Launch a search a confirm that you are able to sort on card, name and
date of birth.
Note that the Address column is not sortable (it's a limitation, could
be fixed later).
4/ Go on the acquisition module, create an order.
5/ Click on the Add user button.
6/ Launch a search a confirm that you are able to sort on card, name and
category

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9120] Typing the ENTER key when submitting a tag from search results reloads the page

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9120

--- Comment #2 from Marc Véron ve...@veron.ch ---
Created attachment 37043
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37043action=edit
[Signed-off] Bug 9120: Prevent form submission on adding tags - OPAC

At the OPAC, if the user adds tags pressing 'Enter', the page is
reloaded and the tags are not added.
To prevent that, this patch suggests to block the press enter event on
the inputs.

Test plan:
0/ Confirm the bad behavior, without this patch.
1/ Apply this patch and confirm nothing happen on pressing enter when
the focus is on the add tag input (At the opac, on the result view).

Patch works as expected.
Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13697] Syspref to not add a fee when a patron changes to a category with enrolment fee

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

--- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Katrin or Jonathan: Please check. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13879] DataTables server-side processing for patrons - sort is broken

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13879] DataTables server-side processing for patrons - sort is broken

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #37059|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37072
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37072action=edit
[PASSED QA] Bug 13879: Fix sort on patron search (guarantor and linked to
orders)

This patch fixes a regression introduced by bug 13021.

Test plan:
1/ Go on a child detail page  edit
2/ Click on Set a patron as a guarantor
3/ Launch a search a confirm that you are able to sort on card, name and
date of birth.
Note that the Address column is not sortable (it's a limitation, could
be fixed later).
4/ Go on the acquisition module, create an order.
5/ Click on the Add user button.
6/ Launch a search a confirm that you are able to sort on card, name and
category

Without patch, I could not sort on names. With patch, sorting works as
dexcribed in Test plan

Signed-off-by: Marc Veron ve...@veron.ch

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

Winona Salesky wsale...@gmail.com changed:

   What|Removed |Added

  Attachment #36786|0   |1
is obsolete||

--- Comment #26 from Winona Salesky wsale...@gmail.com ---
Created attachment 37073
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37073action=edit
Bug 13382 - RDA: 700/710/711 display in XSLT

Test Plan:
1) Apply this patch
2) Ensure you are using the default XSLT setting for the staff and opac search
results and record details
3) Find or create a record with MARC tags 700,710,711
4) Perform an opac search that would show the record in the search results.
5) Click title to review record.
6) Note the fields updates 700,710,711 to show subfields a, b, c, d, e, f, g,
h, i, k, l, m, n, o, p, r, s, t, u, x. Multiple fields are separated by span
class=separator |. Adds Related and Contained Works as new headings.
7) Repeat steps 4 - 6 for the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13068] New feature for DB update and sandbox

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #99 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37066
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37066action=edit
Bug 13068 [QA Followup] - Remove use File::Slurp

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381

Winona Salesky wsale...@gmail.com changed:

   What|Removed |Added

  Attachment #37068|0   |1
is obsolete||

--- Comment #25 from Winona Salesky wsale...@gmail.com ---
Created attachment 37069
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37069action=edit
Updates display of 245 field

Updates for #13381
This patch updates the display of the title and statement of responsibility in
the
XSLT display in the staff and OPAC.

Display includes subfields a,b,c,h,k,n,p,s
Subfield c is wrapped in a span class=title_resp_stmt for easy suppression via
css.
Subfield h is wrapped in a span class=title_medium for easy suppression via
css.

To test:

* Search the opac
* Click the title
* Make sure the fields display properly
* Repeat for a few more titles
* Repeat in the Staff Client

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9120] Typing the ENTER key when submitting a tag from search results reloads the page

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9120

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #37043|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37071
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37071action=edit
[PASSED QA] Bug 9120: Prevent form submission on adding tags - OPAC

At the OPAC, if the user adds tags pressing 'Enter', the page is
reloaded and the tags are not added.
To prevent that, this patch suggests to block the press enter event on
the inputs.

Test plan:
0/ Confirm the bad behavior, without this patch.
1/ Apply this patch and confirm nothing happen on pressing enter when
the focus is on the add tag input (At the opac, on the result view).

Patch works as expected.
Signed-off-by: Marc Veron ve...@veron.ch

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9120] Typing the ENTER key when submitting a tag from search results reloads the page

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9120

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13068] New feature for DB update and sandbox

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #95 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37062
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37062action=edit
[PASSED QA] Bug 13068: Follow-up for cleaning up atomicupdate folder

The folder atomicupdate can be cleaned up. It mainly contains old files that
are not used any more.
I found two files that are still referenced:
[1] Bug-4246-Talking-Tech-itiva-phone-notifications.pl
A readme file refers to it. The code in this file slightly differs
from the TalkingTech db revision. It can probably be deleted too, but
I will first check.
[2] oai_sets.sql
This file should remain. It is used in dbrev 3.07.00.029.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13068] New feature for DB update and sandbox

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13068] New feature for DB update and sandbox

2015-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #36779|0   |1
is obsolete||
  Attachment #36780|0   |1
is obsolete||
  Attachment #36781|0   |1
is obsolete||
  Attachment #36792|0   |1
is obsolete||

--- Comment #94 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37061
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37061action=edit
[PASSED QA] Bug 13068: updatedatabase improvement for developer process

with this patch, the updatedatabase now checks info the atomicupdate directory.
If there is some SQL here, it's executed.
Note that there is no version update, so if you run the updatedatabase script
twice, you'll get an sql error probably.

This patch will be very useful for sandbox testing process.

When the RM pushes a patch with something in i'atomicupdate', he will have to
copy it into updatedatabase.pl, give it a number, and remove the file in
db_update

Test plan:
 * apply the patch
 * create a files with a .sql extension in the atomicupdate directory
 * run updatedatabase.pl
 * look at your database, what was in the .sql file must have been run

Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >