[Koha-bugs] [Bug 13926] SQLHelper replacement - C4::Members::Search - circulation.pl

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13926

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #8 from Tomás Cohen Arazi tomasco...@gmail.com ---
Rebased patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

--- Comment #21 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 37776
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37776action=edit
Bug 13315: (QA followup) fix t/db_dependent/Circulation_issue.t

C4::Circulation::AddIssue now returns a Koha::Schema::Result::Issue object
so tests need to be fixed.

The old behaviour was to always return the due date. It now returns
undef if no issue performed. So one of the tests become irrelevant.

Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13156] Display borrower's cardnumber who did a suggestion in suggestion.pl

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13156

--- Comment #3 from Marc Véron ve...@veron.ch ---
Created attachment 3
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3action=edit
[Signed-off] Bug 13156 Display borrower's cardnumber who did a suggestion in
suggestion.pl

To avoid homonyms, it would be nice if the card number is displayed in the user
suggestion.pl. Currently, consult the record of the user to know exactly who
made the suggestion.

TEST PLAN: Apply the patch. Go on suggestion.pl. Check that nothing has
changed, except that cardnumbers are displayed in 'Suggested by' column.

Resolved an easy conflict while applying. Followed test plan. Works as
expected.
Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13941] Add ids to body tag in staff client where missing

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

  Attachment #37760|0   |1
is obsolete||

--- Comment #18 from Frédéric Demians frede...@tamil.fr ---
Created attachment 37775
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37775action=edit
Bug 13941 [1/2] Test body tag with id/class attributes

Test:

- Apply the first patch [1/2] containg a new test checking body tags in all
  templates
- Run the test: prove xt/tt_valid.t
- You get a list of templates with invalid body tags.
- Apply the second patch [2/2] fixing all invalid body tags.
- Re-run the test: It passes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13941] Add ids to body tag in staff client where missing

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

  Attachment #37759|0   |1
is obsolete||

--- Comment #17 from Frédéric Demians frede...@tamil.fr ---
Created attachment 37774
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37774action=edit
Bug 13941 [2/2] Fix body tags missing id/class

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on creating record from Z39.50

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|In Discussion   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139

Andreas Hedström Mace andreas.hedstrom.m...@sub.su.se changed:

   What|Removed |Added

  Attachment #37580|0   |1
is obsolete||

--- Comment #3 from Andreas Hedström Mace andreas.hedstrom.m...@sub.su.se ---
Created attachment 37780
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37780action=edit
Bug 9139: New subscription form - Does not check form on the first page

The vendor and Record input try to sent the form if the focus is on the
inputs (normal behavior).
But the form is on 2 pages, and the popup message ask you to fill info
on the second page when you are on the first one. This does not make
sense.

This patch suggests to launch search when the enter key is press on
these inputs.

Test plan:
1/ Create a new subscription
2/ Put the focus in the Vendor input and press enter: the vendor search
popup should appear
3/ Put the focus in the Record input and press enter: the record search
popup should appear

Signed-off-by: Andreas Hedström Mace andreas.hedstrom.m...@sub.su.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139

Andreas Hedström Mace andreas.hedstrom.m...@sub.su.se changed:

   What|Removed |Added

 CC||andreas.hedstrom.mace@sub.s
   ||u.se
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13941] Add ids to body tag in staff client where missing

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #16 from Marc Véron ve...@veron.ch ---
Patch 2/2 does not apply on current master because
koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/receipt.tt no longer exists.

Applying: Bug 13941 [2/2] Fix body tags missing id/class
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
error: refusing to lose untracked file at
'koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/receipt.tt'
CONFLICT (modify/delete):
koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/receipt.tt deleted in HEAD and
modified in Bug 13941 [2/2] Fix body tags missing id/class. Version Bug 13941
[2/2] Fix body tags missing id/class of
koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/receipt.tt left in tree.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13987] New: Z39.50 Authority search result not displaying server name

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13987

Bug ID: 13987
   Summary: Z39.50 Authority search result not displaying server
name
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: philippe.blo...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

When doing an Auth search through z3950, the resulting table has the first
column (servers name) always empty.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   Attachment #8273|0   |1
is obsolete||

--- Comment #12 from Marc Véron ve...@veron.ch ---
Created attachment 37779
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37779action=edit
Bug 7646: Add do not print SQL link to reports

I redid the patch without the superfluos CSS part for class noprint.

To test:
Go to Home  Reports  Guided reports wizard  Saved reports
Select a report and run it
You will find a new link Print w/o SQL above the title
Hit this link.
The report (this page) will print without the SQL statement.

The original patch was QAed in 2012, I think it is better to have put it back
to Needs Sign-off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13941] Add ids to body tag in staff client where missing

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941

--- Comment #19 from Frédéric Demians frede...@tamil.fr ---
(In reply to Marc Véron from comment #16)
 Patch 2/2 does not apply on current master because
 koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/receipt.tt no longer exists.

Thanks. Conflict solved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13987] Z39.50 Authority search result not displaying server name

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13987

Blou philippe.blo...@inlibro.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||anthony.laque...@ccsr.qc.ca
   ||, eric.be...@inlibro.com,
   ||francois.charbonnier@inlibr
   ||o.com

--- Comment #2 from Blou philippe.blo...@inlibro.com ---
Sponsored by : CCSR

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7571] Maintain exchange rate history

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7571

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13988

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13988] Log activities related to Acquisitions

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13988

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=7571

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13988] New: Log activities related to Acquisitions

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13988

Bug ID: 13988
   Summary: Log activities related to Acquisitions
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org

Some activities in module Acquisitions could be written to the system log, e.g.
changes to exchange rates.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6973] Allow reply-to on cart emails to go to the sender of the cart.

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6973

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6911] Log viewer should remember search terms

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13156] Display borrower's cardnumber who did a suggestion in suggestion.pl

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13156

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #33133|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13156] Display borrower's cardnumber who did a suggestion in suggestion.pl

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13156

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13987] Z39.50 Authority search result not displaying server name

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13987

--- Comment #1 from Blou philippe.blo...@inlibro.com ---
Created attachment 37778
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37778action=edit
Bug 13987 - Fix server name in z39.50 authority search results

When doing an Auth search through z3950, the resulting table has the first
column (servers name) always empty.

TEST
1) once logged into the intranet, go to Authorities.
2) Click New from z39.50, fill appropriatly for a successful search.
3) Acknowledge first column is empty.  Always.
4) Apply the (very simple) patch.
5) Do another search, validate column is not empty anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on creating record from Z39.50

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #9 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Jonathan!

PS. thank Gustavo from UNC that convinced me :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13987] Z39.50 Authority search result not displaying server name

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13987

Blou philippe.blo...@inlibro.com changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10951

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12752] OVERDUE notice mis-labeled as Hold Available for Pickup

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
It's a problem with the database update not setting a variable correctly I
think, we ran into this too, but lost sight of it

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123

Tom Misilo misi...@fit.edu changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13941] Add ids to body tag in staff client where missing

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941

--- Comment #21 from Marc Véron ve...@veron.ch ---
Created attachment 37782
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37782action=edit
[Signed-off] Bug 13941 [2/2] Fix body tags missing id/class

Followed test plan (Comment #18), works as expected.
Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12656] add a notice that tells patrons when their hold was cancelled because it wasn't picked up in time

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656

Tom Misilo misi...@fit.edu changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13941] Add ids to body tag in staff client where missing

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941

--- Comment #20 from Marc Véron ve...@veron.ch ---
Created attachment 37781
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37781action=edit
[Signed-off] Bug 13941 [1/2] Test body tag with id/class attributes

Test:

- Apply the first patch [1/2] containg a new test checking body tags in all
  templates
- Run the test: prove xt/tt_valid.t
- You get a list of templates with invalid body tags.
- Apply the second patch [2/2] fixing all invalid body tags.
- Re-run the test: It passes.

Followed test plan. Works as expected.
Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13941] Add ids to body tag in staff client where missing

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

  Attachment #37775|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7999] send test notice

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7999

Tom Misilo misi...@fit.edu changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13990] New: ILS-DI LookupPatron Requries ID Type

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990

Bug ID: 13990
   Summary: ILS-DI LookupPatron Requries ID Type
 Change sponsored?: ---
   Product: Koha
   Version: 3.16
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Web services
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: misi...@fit.edu
QA Contact: testo...@bugs.koha-community.org

For the LookupPatron the id_type argument seems to be required, even though it
says it is optional.

For example: https://site/cgi-bin/koha/ilsdi.pl?service=LookupPatronid=4456

I get the following error: 
h1Software error:/h1
preCan't use an undefined value as an ARRAY reference at
/usr/lib/perl5/DBI.pm line 2054.
/pre

However, if I add id_type=borrowernumber

I get the correct output.

LookupPatron
  id4456/id
/LookupPatron

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13916] NORMARC can have analytics with leader 07 = a, b or p

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13916

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

--- Comment #2 from Mirko Tietgen mi...@abunchofthings.net ---
I tried to test this and set up a NORMARC instance. Among other things, there
is no MARC field 774 in the Norwegian standard framework.

I added it with subfields t and w, but when I tried to set up two linked
records I found that the 773 subfields in the child record do not save for me.
I enter values, save the record and when I open it again, the values are gone.

I suppose there is something wrong with the standard framework, it worked fine
for the 774 I added in the parent record.

I filled every single 773 subfield and after saving found that subfields 7, a-h
keep the value, i, k, s, t, w, x, y, z lose it. I stopped investigating at that
point.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Tom Misilo misi...@fit.edu changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12752] OVERDUE notice mis-labeled as Hold Available for Pickup

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752

Tom Misilo misi...@fit.edu changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8399] Problems with mandatory field alert message for authorities

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399

Andreas Hedström Mace andreas.hedstrom.m...@sub.su.se changed:

   What|Removed |Added

 CC||andreas.hedstrom.mace@sub.s
   ||u.se
 Status|Needs Signoff   |Failed QA

--- Comment #4 from Andreas Hedström Mace andreas.hedstrom.m...@sub.su.se ---
This patch only seems to solve one of the two issues in the bug. The tab number
are there but longer descriptions are still being cut off.

Please correct me if i have missed something or misunderstood.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8000] Test mode for notices

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

Tom Misilo misi...@fit.edu changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13941] Add ids to body tag in staff client where missing

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

  Attachment #37774|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13941] Add ids to body tag in staff client where missing

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13989] New: Undocumented Option in ILS-DI LookupPatron

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13989

Bug ID: 13989
   Summary: Undocumented Option in ILS-DI LookupPatron
 Change sponsored?: ---
   Product: Koha
   Version: 3.16
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Web services
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: misi...@fit.edu
QA Contact: testo...@bugs.koha-community.org

id_type userid is not documented in the Description of the LookupPatron API.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=6864

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9083] items.content in checkin/checkout notices does nothing

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9083

Tom Misilo misi...@fit.edu changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399

--- Comment #8 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 37783
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37783action=edit
Bug 13399: Missing validation on authorised value descriptions

This adds validations which force both the OPAC and Staff Client
authorised value descriptions to be filled in.

Counter Patch in the works.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13982] Checkouts table not sorting on correct column

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982

Aleisha Amohia aleishaamo...@hotmail.com changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com

--- Comment #2 from Aleisha Amohia aleishaamo...@hotmail.com ---
Patch applied cleanly but date is still not sorting correctly.
Will leave as Needs signoff in case I'm testing it wrong

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10581] Authority search: no results should not display as 404 error page

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10581

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC|jcam...@cpbibliography.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5627] lock symbol even on not locked fields

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5627

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC|jcam...@cpbibliography.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4040] Placing a hold on an item while it is in transit results in duplicate dialogs upon check-in

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4040

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC|jcam...@cpbibliography.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC|jcam...@cpbibliography.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7107] 'used in' column on analytics not populating

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7107

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC|jcam...@cpbibliography.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10673] Message hide timeout can go out of sync in preferences.pl

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10673

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC|jcam...@cpbibliography.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7170] Remove use of XML::Simple

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC|jcam...@cpbibliography.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13987] Z39.50 Authority search result not displaying server name

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13987

Aleisha Amohia aleishaamo...@hotmail.com changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com

--- Comment #3 from Aleisha Amohia aleishaamo...@hotmail.com ---
Patch applied cleanly but server column remains empty?
Could just be me testing it wrong so will leave for someone else to test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #37783|0   |1
is obsolete||

--- Comment #9 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 37784
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37784action=edit
Bug 13399: Missing validation on authorised value descriptions

This adds validations which force both the OPAC and Staff Client
authorized value descriptions to be filled in.

TEST PLAN
-
1) Login to staff client
2) Koha administration - Authorized values
3) Change drop-down to 'DEPARTMENT'
   -- Assuming you have default values installed,
  and DEPARTMENT exists.
4) Click '+ New authorized value for DEPARTMENT'
5) Enter a 'Authorized value:' and click 'Save'
   -- This will create it without OPAC and Staff Client
  descriptions! This is wrong.
6) Apply patch
7) $ ./installer/data/mysql/updatedatabase.pl
   -- expecting atomic update to run.
8) Refresh staff client page
   -- the descriptions should now be filled in.
9) Repeat steps 4 and 5
   -- This time, you will be given two error messages
   -- Nothing will be created.
10) Attempt to create a new authorized value with descriptions.
-- should save without issue.
11) Run koha qa test tools
-- SQL files are unchecked, but steps 7  8 confirm validity.
-- Should be no issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13982] Checkouts table not sorting on correct column

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #37720|0   |1
is obsolete||

--- Comment #3 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 37786
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37786action=edit
Bug 13982 - Checkouts table not sorting on correct column

The Date Due column for checkouts is using the column index 1 to sort by.
This column is the one that is used for grouping items into today's checkouts
and previous checkouts. This is definitely not the column that should be used.
Instead, we should be using column index 2, which contains the raw unformatted
due date.

Revised Test Plan:
1) Find a patron with no checkouts
2) Check out something as due the beginning on the month.
3) Check out something as due the end of the month.
4) Check out something due tomorrow (hopefully not end of month)
   -- so you should have 2015-04-01, 2015-04-30, and 2015-04-14
  (for example)
5) Attempt to sort by due date
   -- Note the sorting is incorrect
6) Apply this patch
7) Clear your browser cache
8) Reload the page
9) Attempt to sort by due date again
   -- Note the sorting works correctly this time
10) Verify there are no regressions with bug 13908
-- this will require finding a patron with many checkouts,
   playing with the Circulation system preferences
   previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder,
   and understanding what the four different cases mean with
   respect to actually manually sorting the 'Due Date' column.

NOTE: I did not do step 10,
Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13982] Checkouts table not sorting on correct column

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #37532|0   |1
is obsolete||
  Attachment #37784|0   |1
is obsolete||

--- Comment #10 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 37785
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37785action=edit
Bug 13399: Missing validation on authorised value descriptions

This adds validations which force both the OPAC and Staff Client
authorized value descriptions to be filled in.

TEST PLAN
-
1) Login to staff client
2) Koha administration - Authorized values
3) Change drop-down to 'DEPARTMENT'
   -- Assuming you have default values installed,
  and DEPARTMENT exists.
4) Click '+ New authorized value for DEPARTMENT'
5) Enter a 'Authorized value:' and click 'Save'
   -- This will create it without OPAC and Staff Client
  descriptions! This is wrong.
6) Apply patch
7) $ ./installer/data/mysql/updatedatabase.pl
   -- expecting atomic update to run.
8) Refresh staff client page
   -- the descriptions should now be filled in.
9) Repeat steps 4 and 5
   -- This time, you will be given two error messages
   -- Nothing will be created.
10) Attempt to create a new authorized value with descriptions.
-- should save without issue.
11) Run koha qa test tools
-- SQL files are unchecked, but steps 7  8 confirm validity.
-- Should be no issues.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646

Aleisha Amohia aleishaamo...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||aleishaamo...@hotmail.com

--- Comment #13 from Aleisha Amohia aleishaamo...@hotmail.com ---
Patch applied cleanly but can't seem to see the print link?
Setting as Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC|jcam...@cpbibliography.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9512] Did you mean searches authority number as a stem, returns false positives

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9512

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC|jcam...@cpbibliography.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10551] Merging records allows duplicaton of non-repeatable subfields

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10551

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC|jcam...@cpbibliography.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7365] Koha should support PostgreSQL

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC|jcam...@cpbibliography.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5069] Authority clean-up scripts

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5069

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC|jcam...@cpbibliography.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7177] memoize more function calls to speed up Koha

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7177

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC|jcam...@cpbibliography.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6762] show orderline numbers in the basket display

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6762

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC|jcam...@cpbibliography.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2797] Add Summary records to represent summary holdings

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2797

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC|jcam...@cpbibliography.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5185] Match modification should (optionally) update the last seen time

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5185

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC|jcam...@cpbibliography.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1091] in the opac search, a second pass with shorter terms if there are no results?

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1091

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC|jcam...@cpbibliography.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2500] Standing enhancement request for adding/updating call number splitting algorithms in C4/Labels.pm

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2500

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC|jcam...@cpbibliography.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5362] Simple (non-MARC) cataloging interface

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5362

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC|jcam...@cpbibliography.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5609] Holds Rewrite

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5609

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 CC|jcam...@cpbibliography.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13991] Uninitialized value $src in /tools/viewlog.pl

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13991] Uninitialized value $src in /tools/viewlog.pl

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13991] Uninitialized value $src in /tools/viewlog.pl

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991

--- Comment #1 from Marc Véron ve...@veron.ch ---
Created attachment 37791
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37791action=edit
Bug 13991 - Uninitialized value $src in /tools/viewlog.pl

To reproduce:

Go to Home  Tools  Logs
Check intranet-error.log.
You will find a line similar to:
viewlog.pl: Use of uninitialized value $src in string eq at
(...)/tools/viewlog.pl line 70., referer:
http://(...)/cgi-bin/koha/tools/tools-home.pl

To test:
Apply patch.
Verify that no more warnings appear in intranet-error.log
Verify that the log viewer behaves as before.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399

--- Comment #12 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
And is this really a bug? What if a library just doesn't want to display
anything in department and term?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646

--- Comment #14 from Marc Véron ve...@veron.ch ---
Created attachment 37790
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37790action=edit
Screenshot showing position of link after applying patch

I re-tested, the link appears as intended by the original patch. See
screenshot. Setting back to Needs signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10363] There is no package for authorised values.

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363

--- Comment #67 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 35838
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35838
Bug 10363 - There is no package for authorised values.

Review of attachment 35838:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=10363attachment=35838)
-

::: installer/data/mysql/updatedatabase.pl
@@ +9766,5 @@
 +CHANGE av_id av_id INT( 11 ) NOT NULL,
 +CHANGE branchcode branchcode VARCHAR( 10 ) NOT NULL
 +});
 +print Upgrade to $DBversion done ( Bug 10363 - There is no package for 
 authorised values. )\n;
 +SetVersion($DBversion);

Shouldn't this be an atomicupdate now?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13979] Packages uninstallable on Debian Jessie

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979

--- Comment #2 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 37788
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37788action=edit
Bug 13979: [3.18.x] updates to allow installation on jessie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13979] Packages uninstallable on Debian Jessie

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979

--- Comment #1 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 37787
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37787action=edit
Bug 13979: updates to allow installation on jessie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I don't think this is the correct solution. There are reasons why it makes
sometimes sense to leave one or both descriptions empty. In the past Koha even
came with 0 values that had empty descriptions to offer an empty entry in some
pull down lists. Also, if you leave the OPAC description empty it will fall
back to the library description as a feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13979] Packages uninstallable on Debian Jessie

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979

--- Comment #3 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 37789
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37789action=edit
Bug 13979: [3.16.x] updates to allow installation on jessie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13979] Packages uninstallable on Debian Jessie

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13991] New: Uninitialized value $src in /tools/viewlog.pl

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991

Bug ID: 13991
   Summary: Uninitialized value $src in /tools/viewlog.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

To reproduce:

Go to Home  Tools  Logs
Check intranet-error.log. 
You will find a line similar to:
viewlog.pl: Use of uninitialized value $src in string eq at
(...)/tools/viewlog.pl line 70., referer:
http://(...)/cgi-bin/koha/tools/tools-home.pl

Reason: 
Line 57
my $src  = $input-param(src);
Param is not always defined.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #22 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Thanks Kyle and Owen, nice job!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986

--- Comment #2 from Marc Véron ve...@veron.ch ---
Created attachment 37773
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37773action=edit
[Signed-off] Bug 13986 - Printing a list only prints the results of the page
you are viewing

The print list button only prints the page you are viewing, and not the
entire list.

Test Plan:
1) Apply this patch
2) Create a list with enough items that it will paginate
3) Browse to that list, click the 'print list' button
4) Note the entire list prints, not just the visible items

Tested in staff client, works as expected.
It would be great to have the same for OPAC as well (OPAC still prints first
page only).
Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #37761|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13930] Add supporting service svc/ncip for xnciptoolkit driver

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930

--- Comment #5 from Magnus Enger mag...@enger.priv.no ---
Hi! This is really interesting, but could you please submit a patch as
described here:

http://wiki.koha-community.org/wiki/Version_Control_Using_Git#Share_with_the_rest_of_the_world

The preferred way to submit the actual patch these days is to attach it to the
bug here on Bugzilla, and many people use Git bz for that:
http://wiki.koha-community.org/wiki/Git_bz_configuration#Submitting_a_patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #37416|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 37713
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37713action=edit
Bug 9067: Hide item related strings when importing staged authority records

On importing authority records, the items related string should not be
displayed.

Test plan:
1/ Import an authority record
2/ Confirm the item related string are not displayed.
3/ Before this script, the record_type param was lost just after
importing the records. Now you should see
Processing authority records of Processing bibliographic records in
the MARC staging results
4/ Revert the import and check there is not item related strings.

No behavior should exist on importing bibliographic records.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #55 from Jonathan Druart jonathan.dru...@biblibre.com ---
Minor since I suppose it existed before:

 FAIL   cataloguing/value_builder/dateaccessioned.pl
   FAIL   forbidden patterns
forbidden pattern: tab char (line 54)

 FAIL   members/moremember.pl
   FAIL   forbidden patterns
forbidden pattern: tab char (line 136)
 FAIL   C4/Barcodes/hbyymmincr.pm
   FAIL   forbidden patterns
forbidden pattern: tab char (line 76)
forbidden pattern: tab char (line 106)

 FAIL   C4/Barcodes/annual.pm
   FAIL   forbidden patterns
forbidden pattern: tab char (line 84)
forbidden pattern: tab char (line 63)
forbidden pattern: tab char (line 49)
forbidden pattern: tab char (line 46)
forbidden pattern: tab char (line 52)

 FAIL   C4/Items.pm
   FAIL   forbidden patterns
forbidden pattern: trailing space char (line 650)

 FAIL   members/readingrec.pl
   FAIL   forbidden patterns
forbidden pattern: trailing space char (line 81)



Could you explain why you replaced

-my $rsstimestamp = C4::Dates-new($result-{datereviewed},iso);
-my $rsstimestamp_output = $rsstimestamp-output(rfc822);
-$result-{timestamp} = $rsstimestamp_output;
+$result-{timestamp} = strftime(%Y-%m-%dT%H:%M:%S-00:00, gmtime);

and 

-$datereceived = C4::Dates-output('iso') unless $datereceived;
+$datereceived = output_pref({ dt=DateTime-now(), dateonly=1,
otputpref='iso' }) unless $datereceived;

I would use Koha::DateUtils everywhere.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

  Attachment #37679|0   |1
is obsolete||
  Attachment #37707|0   |1
is obsolete||

--- Comment #8 from Frédéric Demians frede...@tamil.fr ---
Created attachment 37711
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37711action=edit
Bug 13889 - Add information about cron jobs to system log

This patch adds information about cron jobs performed and make it viewable
under Home  Tools  Logs (Browse system logs)

To test:

Apply patch
- Got to system preferences and set 'CronjobLog' to:  [Log] information from
  cron jobs.
- Run some cron jobs
- Go to Home  Tools  Logs
- Verify that you have a selection 'Cron jobs' in drop-down 'Module'. Select it
  with Action All and Submit.
- Output should show Date/time and info about Cron jobs

Rebased to work on top of Bug 6911 (conflict in viewlog.tt)  /MV

Rebased after applying patch for Bug 6911 /MV
Conflicts resolved:
misc/cronjobs/overdue_notices.pl
misc/cronjobs/cleanup_database.pl

Signed-off-by: Frederic Demians f.demi...@tamil.fr
  - Merge both patches, and fix updatedatabase.pl
  - Works as described. Provide intersting feedback from cronjob scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13967] System preferences need a package

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967

--- Comment #25 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Robin Sheat from comment #24)
 (In reply to Kyle M Hall from comment #21)
  (In reply to Robin Sheat from comment #19)
   This sounds dangerous for plack.
  
  I was not aware of that! Should we create a bug report to re-add the
  rollback to all unit tests?
 
 I think I was confused, I didn't realise it was referencing test cases,
 which won't be run under plack at all, and was to do with regular koha
 scripts.

Yes, transactions are not used using the interface (except from
tools/batch_delete_records.pl, this script explicitly rollbacks).
We could add the rollback call at the end of each db dependent test file,
but... it's just useless.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

  Attachment #36840|0   |1
is obsolete||

--- Comment #20 from Magnus Enger mag...@enger.priv.no ---
Created attachment 37714
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37714action=edit
Bug 11084 - Delete biblios on Leader 05 == d

Position 05 of the leader in MARC 21 indicates the record's status.
A lower case 'd' indicates that the record is to be deleted
(http://www.loc.gov/marc/authority/adleader.html).

This patch adds a cronjob script that may be run nightly to delete
records where position 05 of the leader is set to 'd'.

Test Plan:
1) Edit one or more records, and set the leader position 05 to 'd'.
2) Run misc/cronjobs/delete_records_via_leader.pl -c -v
3) Those records should either be deleted, or an error message should
   state why they were not.

Signed-off-by: Magnus Enger mag...@enger.priv.no

Works as advertised. Edited a record with an item to have leader05 = d,
then ran delete_records_via_leader.pl with -c and got a message that
the record could not be deleted because of the item. Removed the item
and the script deleted the record. Tried with another record with an
item, this time with the -i option and the record was deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8474] Holds done by librarians cause silent errors in koha-error_log

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8474

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13805] Installer does not work under Plack

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 CC||mag...@enger.priv.no

--- Comment #6 from Magnus Enger mag...@enger.priv.no ---
I can't reproduce the problem on current master. I spin up kohadevbox, drop and
recreate the database, then go to the webinstaller. After logging in once i can
start to use the webinstaller.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >