[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049

--- Comment #11 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Katrin Fischer from comment #10)
  A next step (as described on the Bugzilla report) would be: remove the Delay
  pref for self regs.
 
 Can we rethink this? There is another 'movement' in the patches recently to
 create preferences for options in the cronjobs. This is helpful when you are
 running multiple installations on one server, where maintaining separate
 cronjobs for each library would be quite a hassle. Ultimately I'd like a
 separate tool for those things, but as we have a pref already, why not keep
 it until that arrives?

Fine with me. But this could proceed now separate of that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

  Attachment #34087|0   |1
is obsolete||

--- Comment #35 from Frédéric Demians frede...@tamil.fr ---
Created attachment 37942
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37942action=edit
Bug 11190 sitemap.pl -- Generate a Catalog sitemap

Add a script sitemap.pl to process all biblio records from a Koha
instance and generate Sitemap files complying with this protocol as
described on http://sitemaps.org. The goal of this script is to be able
to provide to search engines direct access to biblio records. It avoid
leaving search engine browsing Koha OPAC and so generating a lot of
traffic, and workload, for a bad result.

Thanks Magnus for testing, and helping to improve the script design.

[2015.04.16] Switch from Moose to Moo.

Signed-off-by: Magnus Enger mag...@enger.priv.no
All options to the script work as expected and the output looks
good. Nice enhancement!

Signed-off-by: Frederic Demians f.demi...@tamil.fr

I signed-of my own patch after fixing various QA errors.

Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

 Status|Passed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #14 from Robin Sheat ro...@catalyst.net.nz ---
So there's a bug in the version of tar that debian includes that means I can't
currently build mojolicious. I'll have to find a workaround to that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13912] System preference for default place of publication (country code) for field 008, range 15-17

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912

Mike blac...@gmail.com changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity'

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Nick Clemens from comment #9)
 Test plan successful for first patch, when checking for regression I cannot
 delete a patron
 
 Software error:
 
 DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.ethnicity' in
 'field list' at /home/kidclamp/kohaclone/C4/Members.pm line 1864
 For help, please send mail to the webmaster ([no address given]), giving
 this error message and the time and date of the error.

I have retested and it works.
Did you update the schema (step 0 of first patch)?
You need to edit the file and set $db_name, $db_user and $db_password

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13912] System preference for default place of publication (country code) for field 008, range 15-17

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912

--- Comment #13 from Thomas Dukleth td-koha-b...@agogme.com ---
The proposed fix using $DefaultCountryField008 follows the somewhat less
problematic example of $DefaultLanguageField008.


1.  CORRECTING HARD CODED CHOICES.

Already existing code has hard coded choices for both language of content and
country of production in marc21_field_008.pl if no preference is specified, but
we should not be perpetuating that mistake in a new patch.  Country also has a
narrower scope and is thus more likely to be wrong if not specified than
language.

If no preference has been set, the corresponding value should be empty by
default or specified as an equivalent to no attempt to code where relevant.


2.  MARC NEUTRAL APPLICATION.

The proposed $DefaultCountryField008 follows the mistaken pattern of
$DefaultLanguageField008 for the MARC 21 based description in
`systempreferences`.`description`.  However, the same list of language codes
for language of content applies to the current standard for both MARC 21 and
UNIMARC $DefaultLanguageField008.  [There had been a few differences in
language codes for the respective bibliographic standards from the 1990s and
earlier.]  Consequently, a default specified in $DefaultLanguageField008 could
be used equally for both MARC 21 and UNIMARC.

A more universal approach for specifying country of production could use a
value list for country which would be a superset of country specifications from
both the ISO 3166 Country Codes list and Library of Congress MARC Country Codes
list.  The user could choose by the label for the country code in a manner
independent of MARC and the appropriate code could be used based on the MARC
standard specified in Koha $marcflavour.  Alas, I am uncertain, if I am
prepared to do all the work which would be necessary for such a worthy goal
along with related validation at the present time.


3.  KOHA MARC FRAMEWORK CENTRIC DEFAULT.

Tomás Cohen Arazi is interested in tying a default setting closer to the Koha
MARC frameworks.  An advantage would be that the user could choose from
different default values by choosing different frameworks which the user could
create.

The difficulty of using `marc_subfield_structure`.`defaultvalue` is that fixed
fields, such as MARC 21 008, would be difficult for users to encode as a
default.  A plugin for the frameworks editor similar to one for the record
editor could be used to populate default values for fixed fields in the
frameworks.  [In the Koha MARC frameworks, MARC 21 fixed fields are managed as
if they are subfield $0 of the respective fields.  UNIMARC fixed subfields are
subfields which is unproblematic for the original design of the Koha MARC
frameworks code.]

I am a little uncertain of the degree of debugging time required for plugins to
work on framework values relative to my time.  I would be happy to have a more
MARC neutral system preference for country of production at the present time in
which the user would enter a value as in the proposed fix, but choosing from
the linked documentation for MARC country code list for MARC 21 or the ISO 3166
code list for UNIMARC.  We could then file an enhancement bug for adding more
granular defaults for fixed fields and fixed subfields associated with Koha
MARC frameworks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #28 from Jonathan Druart jonathan.dru...@biblibre.com ---
Kyle, some questions have been asked, please have a look.
Also tests are missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049

--- Comment #12 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Yes, this is separate, just thought maybe better to discuss first before code
written :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13981] Transliterate rule for oe and ae

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13981

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #37718|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13981] Transliterate rule for oe and ae

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13981

--- Comment #2 from Marc Véron ve...@veron.ch ---
Created attachment 37943
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37943action=edit
[Signed-off] Bug 13981 - Transliterate rule for oe and ae

NOTE : I use HTML codes for special characters to avoir encoding issues in
patch file.

In ICU configuration, add a transliterate rule for
oelig; = oe
aelig; = ae

Test plan :
- Without patch
- Create a record R1 with title containing for example coelig;ur
- Create a record R2 with title containing for example coeur
- Index those records
- Search for coelig;ur
= You only find R1
- Search for coeur
= You only find R2
- Apply patch
- Restart zebra
- Index R1 and R2
- Search for coelig;ur
= You find R1 and R2
- Search for coeur
= You find R1 and R2
(Same test plan for ae)

--
Tested with all variants of Ae ae Oe oe. Search worked as expected.
Note: The words with special characters were not highlighted, but I think this
can be done in an other bug.
Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13981] Transliterate rule for oe and ae

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13981

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646

--- Comment #17 from Marc Véron ve...@veron.ch ---
Created attachment 37945
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37945action=edit
[Signed-off] Bug 7646 - Printing w/o the SQL Code showing

This patch provides the same function but adds a 'Print results' button rather
than the link.
Looks a little cleaner to my eye and there doesn't seem to be an option to
print with SQL.

To test:
Go to Home  Reports  Guided reports wizard  Saved reports
Select a report and run it
You will find a new link Print w/o SQL above the title
Hit this link.
The report (this page) will print without the SQL statement.

Works as expected. Print function is displayed as Button.
Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

  Attachment #37926|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7976] Borrow Permission is not used and can be removed

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976

--- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Katrin Fischer from comment #7)
 Should we also adjust the borrowres.flags for staff users who had borrows
 permission? Any negative side effects if we don't?

Yes you are right, to be safe it's certainly better :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7976] Borrow Permission is not used and can be removed

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

  Attachment #37779|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

  Attachment #37790|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7976] Borrow Permission is not used and can be removed

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976

--- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 37944
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37944action=edit
Bug 7976: Update borrowers.flags

The borrowers.flags values need to be updated to prevent side effects.

Test plan:
Set the borrow permission flags for some borrowers
Execute the updatedb entry and verify the flags has been updated (-128)
only for borrowers with this permission set.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED
   Assignee|k...@bywatersolutions.com   |jonathan.dru...@biblibre.co
   ||m

--- Comment #29 from Jonathan Druart jonathan.dru...@biblibre.com ---
I will try to provide a patch today.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190

--- Comment #36 from Frédéric Demians frede...@tamil.fr ---
Few personal notes about Moose vs Moo (just seen IRC dev meeting logs):

There is an overhead using Moose for small short lived programs. But for long-
running cronjob/maintenance scripts, there isn't any problem using Moose. For
Koha WUI scripts, Moose start time is a problem as long as Koha operates in
CGI mode. As soon as there is persistence (Plack), it isn't a problem anymore.

This issue of runtime penaly due to using a large and complex library, doing a
lot of stuff behind the scene, is not different with Moose and DBIx::Class  I
don't say DBIx::Class is bad. Moose it bad too = So let's go with Moose! I'd
say both libraries share a lot of good things.

I think that Moose has various advantages over other OO frameworks. It's
complete, very well documented, widely used, a standard, carefully packaged
for all major Linux distro. All books about the so-called modern-Perl
movement deals with using Moose as OO.  There is the Perl's famous moto:
There's more than one way to do it. Applied to OO, this could conduct to
chaos. There are so many ways to do OO in Perl. Code become unreadable and
unreliable. Moose forces to adopt a proper and consistent OO approach. Moo try
to solve a non-issue (library weight, startup time) in modern execution
environments at high price: too many important features are lost.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7890] highlight required in yellow

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #36048|0   |1
is obsolete||
  Attachment #36049|0   |1
is obsolete||

--- Comment #30 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 37946
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37946action=edit
Bug 12847: Items issued today is considered as overdue

The date comparisons in C4::Members::IssueSlip does not work as
expected.
Is an item is issue yesterday and due today (23:59), it should not be
considered as an overdue yet.

Test plan:
Define a valid issue slip (code ISSUESLIP)
Check 2 items out and update the issuedate value for one of them as
yesterday (using the mariadb/mysql cli or similar)
Print the slip
Before this patch the item marked as issued yesterday is considered as
overdue.

Special cases:
- hourly loans
- Quick slip is impacted too

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480

--- Comment #46 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37950
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37950action=edit
[PASSED QA] Bug 10480: Use the framework plugin object in cataloguing

This patch implements the use of Koha::FrameworkPlugin in Cataloguing,
Authorities, Acquisition, Serials and Tools.

The main change is architectural: see the commit message of the previous
patch. No changes in behavior are expected, but the support of new events
may provide additional functionality in the future. Some small bugs are
resolved along the way.

The change primarily focuses on the MARC and items editor in Cataloguing.
But the MARC editor for Authorities and the item editor in Acquisition,
Serials and Tools are touched too. This commit message gives some comments
per module.

NOTE FOR CATALOGUING:
A new plugin without popup (or other click event code) now shows the title
No popup when hovering over the tag editor image. The image alerts the
user on a plugin, the title tells about its status. The noclick property
allows for further style modifications in the template. Note that a
follow-up patch will clean up the old style plugins too with the same
effect.

Some additional code in cataloging.js makes it possible to clone subfields
with plugins (although only theoretically useful). The clones use the
same javascript functions but event.data contains an updated id.
This effectively resolves bug 13306. Note that if old plugins do not use
the javascript parameter for the id but the perl variable, cloning does
still operate on the wrong field (with and without this patch set).

In the absence of report 12176 in master, it is not yet necessary to modify
additem.tt. When it gets pushed, it should be an easy rebase.
New style item plugins will no longer need an extra parameter. (The code in
the FrameworkPlugin object actually takes care of that.)

NOTE FOR AUTHORITIES:
This patch also adds class name tag_editor to the buttonDot anchors. This
effectively makes the same tag editor image appear as in Cataloguing.
Futhermore it removes the button from the tab sequence if there is no click
event (really effective after conversion to the new style, since the old
style plugins contain empty onclicks and launchers).
Both small adjustments increase consistency between auth and bib edits.

NOTE FOR ACQUISITION:
In Acquisition two scripts use an item editor, but in a different way.
The scripts addorderiso2709 and neworderempty both rely on the routine
PrepareItemrecordDisplay in C4::Items, but neworderempty creates item
blocks dynamically via an ajax call to services/itemrecorddisplay.pl.

In order to make the dynamic item blocks work with plugins, some code
changes were needed in additem.js. (Normally the event binding is done
at document ready time; now it must be done later.)

At this moment the routine in Items.pm contains the html tags, and this
makes changes to the following templates not necessary for now:
* acqui/addorderiso2709.tt
* services/itemrecorddisplay.tt
Report 13397 has been opened to address moving the html to the templates.

NOTE FOR SERIALS:
Script serial-edit relies also on C4::Items (just as in Acquisition).
This makes changes to serials/serials-edit.tt not necessary for now.

NOTE FOR TOOLS:
The current code in tools/batchMod.pl allows the use of plugins for batch
modification of items. This patch just converts that code to use the new
object. Most item plugins however may not be very useful for operating on
multiple items at once.

PERFORMANCE:
I have benchmarked build_tabs in addbiblio to see how especially the
additional processing of the javascript in the FrameworkPlugin object
would impact performance. Testing default MARC21 framework with 8 plugins
gave the following figures:
- Old situation: 851 ms
- New situation: 942 ms (+10,7%)
- New situation after plugin cleanup: 881 ms (+3,4%)
Note also that adding lines for event binding is compensated by removing
lines for unused events. Page load should essentially be the same.

TEST PLAN:
Suggestion: If you also apply the next patch with the EXAMPLE plugin, you
can test with a rather harmless plugin (with popup) on various places :)
But your test should also include old style plugins, with[out] popups.

If you want to test a new plugin without popup, rename/remove Click$id
in the javascript code of the $builder definition (temporarily).

[1] Test Cataloguing:
- Add/Edit biblio. Try plugins with and without popup.
- Add/Edit items. (EXAMPLE can be used as an item plugin with popup.)
- Clone a subfield with plugin (use EXAMPLE): Verify that the plugin
  works on both original and clone with the respective field values.
  Is the value put back in the right field too?
[2] Test Authorities:
Edit an authority record. Try plugins with an without popup.
[3] Test Acquisition:
Set system preference AcqCreateItem to placing 

[Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #36953|0   |1
is obsolete||
  Attachment #36954|0   |1
is obsolete||
  Attachment #36955|0   |1
is obsolete||
  Attachment #36956|0   |1
is obsolete||
  Attachment #36957|0   |1
is obsolete||

--- Comment #44 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37948
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37948action=edit
[PASSED QA] Bug 10480: New module and unit test for framework plugins

This patch introduces the Koha::FrameworkPlugin object to Koha.
This object supports the current old-style plugins while adding a new
style based on the concept of two anynomous subroutines for building and
launching.

I will summarize the advantages of this new approach, justifying the
additional lines of code in this patch:

[1] Centralizing the code for building and launching plugins.
[2] Extensive unit testing: this was not possible before.
[3] Simplicity: Only define what you need in the plugin.
A follow-up patch will delete 1500 lines with *empty* routines.
[4] Make it possible to restore the warnings pragma for all plugins.
New style plugins do no longer depend on redefinition.
[5] Event binding moved from HTML attributes moved to jQuery code.
This separates behavior and presentation.
[6] Much more documentation, including EXAMPLE plugin in follow-up.
[7] Improved error handling.
[8] Usability: property noclick tells you if plugin's buttonDot is active.
[9] More events supported: Change, keyboard/mouse events. See EXAMPLE.

NOTE ON EXAMPLE PLUGIN:
The example plugin is added in the third patch of this report. Since
it is new style, it can be used only after we start using this object. It
also contains an example for a keypress and mouseover event.

NOTE ON ITEM PLUGINS:
Old style plugins for items contain an additional parameter in the js
functions for Blur, Focus and Change. This distinction has no actual use
and is resolved for new plugins in the object code. When converting
item plugins, this minor correction will be addressed. In the meantime
old style item plugins behave as expected.

TEST PLAN:
Run the new test t/db_dependent/FrameworkPlugin.t
At this point in time, you do not need to do anything more. Follow-up
patches will incorporate the object in real-life Koha and provide
additional test plans.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #37948|0   |1
is obsolete||

--- Comment #45 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37949
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37949action=edit
[PASSED QA] Bug 10480: New module and unit test for framework plugins

This patch introduces the Koha::FrameworkPlugin object to Koha.
This object supports the current old-style plugins while adding a new
style based on the concept of two anynomous subroutines for building and
launching.

I will summarize the advantages of this new approach, justifying the
additional lines of code in this patch:

[1] Centralizing the code for building and launching plugins.
[2] Extensive unit testing: this was not possible before.
[3] Simplicity: Only define what you need in the plugin.
A follow-up patch will delete 1500 lines with *empty* routines.
[4] Make it possible to restore the warnings pragma for all plugins.
New style plugins do no longer depend on redefinition.
[5] Event binding moved from HTML attributes moved to jQuery code.
This separates behavior and presentation.
[6] Much more documentation, including EXAMPLE plugin in follow-up.
[7] Improved error handling.
[8] Usability: property noclick tells you if plugin's buttonDot is active.
[9] More events supported: Change, keyboard/mouse events. See EXAMPLE.

NOTE ON EXAMPLE PLUGIN:
The example plugin is added in the third patch of this report. Since
it is new style, it can be used only after we start using this object. It
also contains an example for a keypress and mouseover event.

NOTE ON ITEM PLUGINS:
Old style plugins for items contain an additional parameter in the js
functions for Blur, Focus and Change. This distinction has no actual use
and is resolved for new plugins in the object code. When converting
item plugins, this minor correction will be addressed. In the meantime
old style item plugins behave as expected.

TEST PLAN:
Run the new test t/db_dependent/FrameworkPlugin.t
At this point in time, you do not need to do anything more. Follow-up
patches will incorporate the object in real-life Koha and provide
additional test plans.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480

--- Comment #47 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37951
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37951action=edit
[PASSED QA] Bug 10480: EXAMPLE plugin with associated template

The EXAMPLE plugin helps you to create a new style framework plugin by
providing a simple working example and additional documentation for
developers.

Test plan:
[1] Connect the EXAMPLE plugin to one or more fields.
[2] Try the following events:
a- Focus: If the field is empty, it should put EXAMPLE: into it.
b- MouseOver: If the field is empty and you move your mouse over it,
   it should have the same effect as Focus.
c- Change: Edit the field in the editor and tab out of it, the color
   of the text should toggle (randomly) between red, green and blue.
d- KeyPress: If you edit the field and you type @, it should give AT.
e- Click: Click on the tag editor. Change the value in the popup.
   If you press OK, the field should be changed.
[3] Would the documentation in the perl script help you to create a plugin?

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10423] Date not well formatted on 'print summary' from patron account

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #37955|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10423] Date not well formatted on 'print summary' from patron account

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 37955
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37955action=edit
[ALTERNATIVE PATCH] Bug 10423: Prevent race condition on printing a ReserveSlip

The problem has been well described by Kyle and Nicole on bug 7255
description and comment 1.

With this counter patch, I suggest to popup AFTER the return has been
confirmed. This will remove the race condition and avoid to pass
itemnumber to the pl file as in the patch submitted by Olli.

Only the borrowernumber and biblionumber are needed (transfer and op are
never used by circ/hold-transfer-slip.pl).

Test plan:
It is very hard to know all cases (at least 6) where the popup is
displayed. Try at least to get the hold and the transfer confirmation
messages.
You should get the popup if you click on print slip button.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed.

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #37798|0   |1
is obsolete||

--- Comment #4 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 37958
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37958action=edit
Bug 13993 - Transfer order from one vendor to another vendor Previous
orderstatus is not changed

To Test:
1) Create a vendor for ex: A
2) Create a basket under vendor A
3) Create a order
4) Create a vendor for ex: B
5) Create a basket under vendor B
6) Search vendor A and basket/order
7) Click on Transfer link and choose the vendor and basket in which you want to
transfer the order
8) Go to mysql prompt and see previous orderstatus.
For ex:
mysql select orderstatus from aqorders where ordernumber = 2;
+-+
| orderstatus |
+-+
| cancelled   |
+-+

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10423] Date not well formatted on 'print summary' from patron account

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #37907|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 37947
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37947action=edit
Bug 10423: Show date due with time if it's a hourly loan

On printing the summary from the patron account, the hours are not
displayed if needed.
The as_date_due flag should be set to display it correctly.
Problem, GetPendingIssues modify the value retrieved from the database.
In order to not add regression and check all calls to GetPendingIssues,
this patch backup the value before the change.

Test plan:
Check some items out, specify a hourly loan for some.
Click on print  print summary and confirm the date due are correctly
formatted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480

--- Comment #48 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37952
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37952action=edit
[PASSED QA] Bug 10480: Remove useless routines and irrelevant pod lines

This patch makes the following cleanup actions for all plugins:

1- Remove sub plugin_parameters. This function is not used.
2- Remove empty plugin or empty plugin_javascript subs.
3- Remove empty Blur, Clic or Focus routines from javascript.
4- Remove pod lines (copy-pasta) only referring to the 3 plugin subs.
5- Remove the last 1; line. It is no longer needed.

Test plan:
Run the unit test t/db_dependent/FrameworkPlugins.t
Test some cataloguing plugins in addbiblio.
Test some item plugins in additem and neworderempty.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
I also checked the syntax of all plugins with perl -c.
And checked the pod (if any) with podchecker: Two files still produce a
warning; the follow-up deals with them: unimarc_field_686a/_700-4.pl.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480

--- Comment #49 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37953
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37953action=edit
[PASSED QA] Bug 10480: Follow-up for unimarc_field_686a/_700-4.pl

This patch fixes the pod errors on those two files by removing the pod
section that actually does not add anything useful.

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13982] Checkouts table not sorting on correct column

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982

--- Comment #4 from Kyle M Hall k...@bywatersolutions.com ---
Thanks for signing off Mark! For what it's worth I do not believe there is any
possible way this patch will affect the fix for bug 13908, I just added it to
the test plan for thoroughness.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed.

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993

--- Comment #3 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 37957
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37957action=edit
Bug 13993 - Add tests to confirm 'new' and 'cancelled'

This adds 2 tests to t/db_dependent/Acquisition/TransferOrder.t
in order to confirm the order's status is properly marked.

TEST PLAN
-
1) Apply this patch only
2) prove -v t/db_dependent/Acquisition/TransferOrder.t
   -- should fail one test: not marked as 'cancelled'.
3) Apply other patch
4) prove -v t/db_dependent/Acquisition/TransferOrder.t
   -- should succeed.
5) Run test plan as per initial patch.
6) Run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing.

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482

--- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 37956
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37956action=edit
[ALTERNATIVE PATCH] Bug 13482: Prevent race condition on printing a ReserveSlip

The problem has been well described by Kyle and Nicole on bug 7255
description and comment 1.

With this counter patch, I suggest to popup AFTER the return has been
confirmed. This will remove the race condition and avoid to pass
itemnumber to the pl file as in the patch submitted by Olli.

Only the borrowernumber and biblionumber are needed (transfer and op are
never used by circ/hold-transfer-slip.pl).

Test plan:
It is very hard to know all cases (at least 6) where the popup is
displayed. Try at least to get the hold and the transfer confirmation
messages.
You should get the popup if you click on print slip button.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing.

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14002] New: Show patron expiry date in OPAC

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14002

Bug ID: 14002
   Summary: Show patron expiry date in OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

We currently don't show the expiry date of the patron on the OPAC detail page.
This is an important date and we should display it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

--- Comment #22 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37954
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37954action=edit
Bug 11084 [QA Followup]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14003] New: SIP2 AF Field return 1

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14003

Bug ID: 14003
   Summary: SIP2 AF Field return 1
 Change sponsored?: ---
   Product: Koha
   Version: 3.8
  Hardware: All
OS: Linux
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: SIP2
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: hblanc...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

When try to checkout an item that have any problem (circulation rules, item
block or other) appears 1 and no the circulation, patron or item message.

Any idea; here is the output for SIP log 

OUTPUT MSG: '120NUN20150415120425 
AOBIBARAAO = FID_INST_ID
AA79736535AA = FID_PATRON_ID
AB100093734AB = FID_ITEM_ID
AJThe Oxford Handbook on the United NationsAJ = FID_TITLE_ID
AHAH = FID_DUE_DATE
AF1AF = FID_SCREEN_MSG
BLY  BL = FID_HOLD_TYPE
AY1AZDE35AY = FID_SEQNO

my koha version is 3.08.06.000

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10338] Search history can cause Out of memory errors

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10338

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Galen Charlton from comment #1)
 This should be fixed by the patch to bug 10657, which replaces Storable with
 JSON for serializing the search history.

Confirmed, should be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6911] Log viewer should remember search terms

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911

--- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 37961
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37961action=edit
Bug 6911: (follow-up) Reintroduce few lines to avoid regression

If you come from the biblio detail page and click on modification log,
you should get the circ menu, not the tools menu.

Test plan:
1/ Go on a biblio detail page
2/ Click on the modification log tab
3/ You should get the modification log page with the circ menu.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14005] Fix working of previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14005

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37962
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37962action=edit
Bug 14005 - Fix working of previousIssuesDefaultSortOrder and
todaysIssuesDefaultSortOrder

It appears that many librarians find the language for the default sort
order system preferences ambiguous and confusing.

Test Plan:
1) Apply this patch
2) View the system preferences previousIssuesDefaultSortOrder and
todaysIssuesDefaultSortOrder
3) Verify the new language is sensible and describes each sort order correctly

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10355] Second click on modification log misses object parameter

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10355

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10355] Second click on modification log misses object parameter

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10355

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 37964
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37964action=edit
Bug 10355: paramater 'object' lost on the road

Test plan:
1) Go to any detail page in staff
2) Click on the modification log tab
3) Verify, that the object is prefilled with the records biblionumber
and you can also see it as parameter in the url
4) Click a second time on modification log to reset your search

Before this patch, the object parameter was empty.
It now contains the value of the biblionumber.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

Chris Nighswonger cnighswon...@foundations.edu changed:

   What|Removed |Added

  Attachment #37906|0   |1
is obsolete||

--- Comment #18 from Chris Nighswonger cnighswon...@foundations.edu ---
Created attachment 37965
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37965action=edit
[SIGNED OFF] Bug 13876: [QA Follow-up] Resolve updatedatabase logfile issues

This patch removes the test on write permissions of the logdir.
It uses File::Temp to generate a file in the logdir or otherwise in
a system tmp dir.
This resolves issues with both write permissions as well as SELinux
denials.
Note that after generating an empty file, we are appending to it in
the system statement.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
Amended: only use File::Temp in the fallback case. Do not add the four
character suffix in the first attempt.

Signed-off-by: Chris Nighswonger cnighswon...@foundations.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

Chris Nighswonger cnighswon...@foundations.edu changed:

   What|Removed |Added

  Attachment #37094|0   |1
is obsolete||

--- Comment #19 from Chris Nighswonger cnighswon...@foundations.edu ---
Created attachment 37966
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37966action=edit
[SIGNED-OFF] Bug 13876: Fallback to /tmp if logdir is not writable

If the logdir directory is not writable by the koha user, the installer
should not explode.
This patch uses a temporary directory as a fallback.
That means that the history won't be kept.

Test plan:
0/ Generate an update (modify updatedatabase.pl and kohaversion)
1/ Make sure the permission are not correct on $logdir
2/ Go on the interface and execute the update entry.
3/ Confirm that the log has been created in a temporaty directory.

Retry with correct permissions and confirm the log will be created in
$logdir.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
Adding a follow-up for completely resolving encountered issues.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Signed-off-by: Chris Nighswonger cnighswon...@foundations.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13434] 586 XSLT improvements

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13434

rgra...@marlboro.edu changed:

   What|Removed |Added

 CC||rgra...@marlboro.edu

--- Comment #6 from rgra...@marlboro.edu ---
Regarding 1: That sounds right to me, Nick. The redundancy of the contents and
summary notes, for instance, drives me a little crazy personally, and so
anything to avoid that appeals to me! I am in favor of leaving it only in the
details and not in the notes tab. 

Regarding 2: I'm no expert on display constants, but I think these are for
card/shelf-list printing, so I don't think that distinguishing ## from #8 is
necessary, as they are all awards and the cataloger cannot supply a different
label anyway. 

(In reply to Nick Clemens from comment #4)
 Separation and display look good so signing off, but I have some questions
 that I am leaving for QA:
 
 1 - Before this patch the awards displayed in the description tab only on
 staff-client, and both in detail view and description tab on opac.  I am
 thinking if we are going to display on the details page we should remove
 from description tab on both staff/opac - maybe out of scope.
 
 2 - indicator 1 is supposed to control generation of display content
 Awards:  (display if blank, dont if =8) and it does if all =8, but with
 multiple fields and a mix of =8 or =# you always get the Awards: I don't
 know if it would be worth splitting them into two display sections based on
 the indicator or if it isn't a big deal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382

--- Comment #33 from rgra...@marlboro.edu ---
With our systems librarian on leave, I'm not able to do a done of patch
testing, but I wonder: Are multiple relator terms displaying with the patch,
like in the below example? Thanks!

Contributor(s): Nolan, Christopher, 1970­ [film producer, screenwriter,
director]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6911] Log viewer should remember search terms

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6911] Log viewer should remember search terms

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #37961|0   |1
is obsolete||

--- Comment #9 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 37968
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37968action=edit
[PASSED QA] Bug 6911: (follow-up) Reintroduce few lines to avoid regression

If you come from the biblio detail page and click on modification log,
you should get the circ menu, not the tools menu.

Test plan:
1/ Go on a biblio detail page
2/ Click on the modification log tab
3/ You should get the modification log page with the circ menu.

Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6911] Log viewer should remember search terms

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||10355

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10355] Second click on modification log misses object parameter

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10355

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||6911
   Patch complexity|--- |Trivial patch
   Assignee|gmcha...@gmail.com  |jonathan.dru...@biblibre.co
   ||m

--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
It depends on the fix I submitted on bug 6911 comment 7.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13386] 246 display in XSLT

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386

rgra...@marlboro.edu changed:

   What|Removed |Added

 CC||rgra...@marlboro.edu

--- Comment #6 from rgra...@marlboro.edu ---
I think that sounds like a great idea, Nick. 

One thing to keep in mind is that the second indicator isn't *always* coded;
occasionally it's left blank and the type of other title isn't specified. So, I
suspect you'd have to tell the xslt what to do in that case. 

(In reply to Nick Clemens from comment #3)
 Outside the scope of this change, but if I had my druthers:
 
 246 2nd indicator specifies type of other title, would be nice to display
 that when 1st indicator 1.  Probab;y it would go into brackets like relator
 terms and would be overridden by subfield i
 
 That out of the way, works as described and will sign off momentarily

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 37967
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37967action=edit
Bug 10752: Alert the librarian if the suggestion has not been added

Test plan:
- Create a new suggestion, chose a short term as your title and copy it.
- Leave all other fields of the suggestion form untouched.
- Save your first suggestion.
- Enter a second suggestion with the same title.

Before this patch, the suggestion was not inserted without alert.
With this patch, an alert is displayed on the interface.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m
   Patch complexity|--- |Trivial patch

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA: I already used the message trick in some other bugs: bug 10363, bug 10855,
bug 11023

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10706] keyword search on reports should search report number

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 CC||jonathan.dru...@biblibre.co
   ||m
   Assignee|gmcha...@gmail.com  |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10706] keyword search on reports should search report number

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 37969
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37969action=edit
Bug 10706: Search reports by id

This patch adds the ability to search reports by their id.

Test plan:
1/ Go on the saved report list (reports/guided_reports.pl?phase=Use saved)
2/ Search for a report id (refer to the ID column in the table)
3/ The result should be consistent

That the filters are not kept, already existed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13516] Display issue for search results with items both checkout out and lost

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #8 from Kyle M Hall k...@bywatersolutions.com ---
This patch fixes the mangled display. With the patch, you will still see the
lost status. See this screenshot:
http://content.screencast.com/users/kylemhall/folders/Jing/media/891a082f-1c71-4207-b01c-44b27b465fd8/0017.png

(In reply to Katrin Fischer from comment #7)
 I am not sure I understand this correctly. 
 
 1) With and without the patch my staff result list for the checked out item
 with lost status = 1 looks the same:
 
 2 items, 1 available:
 
 Books Midway Book Cart (1)
 Books
 
 1 on loan:
 
 Computer Files Midway Book Cart (1) date due: 11/01/2015
 Computer Files
 
 
 Should we not include the information that the item is lost somehow?
 
 Please take a look and explain!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #31978|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37970
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37970action=edit
Bug 13022 - Hardcoded limit causes records with more than 20 items to show
inaccurate statuses

If a record has more than 20 items, all the items over 20 will show as
available on the search results even if they are not!

This is a hard coded limit in the Search module. This number should be
configurable.

Test Plan:
1) Create a record with more than 20 items
2) Set all the items to waiting holds or in transit
3) Search for results that will include that item
4) Note some say they are available even though they are not
5) Apply this patch
6) Run updatedatabase.pl
7) Set the new system preference MaxSearchResultsItemsPerRecordStatusCheck
   to a number larger than the number of items on your record
8) Re-run the search
9) Note that the hold and transit statuses for the items are now correct

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX)

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

--- Comment #13 from Blou philippe.blo...@inlibro.com ---
Created attachment 37972
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37972action=edit
Bug 11299 - cleaning up warnings/errors appearing in automatic_linker.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to Owen Leonard from comment #2)
 This is an interesting bug... I had no idea this arbitrary limitation was in
 the code. Note the associated FIXME:
 
 # A couple heuristics to limit how many times
 # we query the database for item transfer information, sacrificing
 # accuracy in some cases for speed;
 #
 # 1. don't query if item has one of the other statuses
 # 2. don't check transit status if the bib has
 #more than 20 items
 #
 # FIXME: to avoid having the query the database like this, and to make
 #the in transit status count as unavailable for search limiting,
 #should map transit status to record indexed in Zebra.
 
 The problem with both the old way and the patched version of things is that
 something is happening which the user doesn't know anything about. You can
 pick an arbitrarily high number for
 MaxSearchResultsItemsPerRecordStatusCheck (that's a mouthful!) and rest
 assured that no inaccurate information will be displayed or you can set it
 to something else and take your chances.
 
 How does the librarian administrator know what value of
 MaxSearchResultsItemsPerRecordStatusCheck is reasonable?
 
 I'm interested in hearing why the solution proposed in the FIXME isn't the
 one which has been implemented.
 
 If the Zebra solution is not a good one, I think a better solution to this
 might just be to add a note which tells the user to click through to the
 detail page for accurate status information.

I don't think that would be a satisfactory solution for many librarians. The
zebra fix is also limited. This problem isn't just inherent in the transit
status, but also the lost status ( and probably the not for loan status and who
knows what else ). I think the most correct solution would be to remove the
limit altogether, but in the interest of those libraries that would prefer
speed over accuracy, I made the limit controllable via a system preference
instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #37970|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37971
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37971action=edit
Bug 13022 - Hardcoded limit causes records with more than 20 items to show
inaccurate statuses

If a record has more than 20 items, all the items over 20 will show as
available on the search results even if they are not!

This is a hard coded limit in the Search module. This number should be
configurable.

Test Plan:
1) Create a record with more than 20 items
2) Set all the items to waiting holds or in transit
3) Search for results that will include that item
4) Note some say they are available even though they are not
5) Apply this patch
6) Run updatedatabase.pl
7) Set the new system preference MaxSearchResultsItemsPerRecordStatusCheck
   to a number larger than the number of items on your record
8) Re-run the search
9) Note that the hold and transit statuses for the items are now correct

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10706] keyword search on reports should search report number

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13265] Still too many search cursor cookies

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13265

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13265] Still too many search cursor cookies

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13265

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #33616|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37973
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37973action=edit
Bug 13265 - Still too many search cursor cookies

We have multiple sites that are still exhibiting bug 11369. For whatever
reason, the cookies on these sites are larger and thus the maximum of 10
is still too large. This setting should be controlled by a system
preference to the number can be tailored on a per-site basis.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Set the new system preference MaxSearchCookies to a high number ( e.g. 20 ).
4) Perform searches until you get the error described in bug 11369
5) Delete your cookies so you can use the staff intranet again
5) Set the system preference to a much lower number ( e.g. 5 )
6) Repeat setp 4, you should no longer get the error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

Blou philippe.blo...@inlibro.com changed:

   What|Removed |Added

  Attachment #37918|0   |1
is obsolete||

--- Comment #4 from Blou philippe.blo...@inlibro.com ---
Created attachment 37974
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37974action=edit
Bug 11300 - Add a Z39.50 Linker that searches for authority links in the
specified Z39.50 server

This patch depends on code added in Bug 11299, and must be applied after it.

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )

This patch adds a Z39.50 Linker which searches for authority links on a remote
server.

If a matching authority is found, it's imported in the local database for
linking with the current biblio record.

If no matching authority was found on the remote server, the Linker falls back
to a local authority search.

Configuration :
* The option Z39.50 Server is added to the LinkerModule preference. You must
choose this to use the new Linker.
* The preference LinkerZ3950Server is required and specifies which server to
use for linking. It must contain the name of the server, as defined in the
z3950servers table.
* You can set the local_first option in the LinkerOptions preference to force
the Linker to search for authorities in the local database first. If no local
authority match was found, the Linker falls back to a remote Z39.50 search.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

--- Comment #5 from Blou philippe.blo...@inlibro.com ---
Created attachment 37975
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37975action=edit
Bug 11300 - correcting table z3950servers now uses 'servername' instead of
'name'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

--- Comment #6 from Blou philippe.blo...@inlibro.com ---
Rebased over 11299, and small fixes added in new patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10222] Error when saving Demco label templates

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222

Chris Nighswonger cnighswon...@foundations.edu changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10222] Error when saving Demco label templates

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222

--- Comment #2 from Chris Nighswonger cnighswon...@foundations.edu ---
Created attachment 37976
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37976action=edit
Bug 10222 - Error when saving Demco label templates

This patch fixes a bug whereby if you open either of the
Demco label templates (loaded by the sample data) and
click save without making any changes you will get an
error:

Can't bless non-reference value at C4/Creators/Profile.pm
line 92.

It also fixes another minor bug in the creator sample data.

To test:

1. Install all sample data in a clean database.
2. In the label tool, edit either of the Demco label templates.
3. Save the template and observe the error mentioned above.
4. Drop and recreate the database.
5. Apply the patch.
6. Repeate steps 1-3 and note the successful save.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13947] serials/subscription-history.pl calls GetBiblio incorrectly

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13991] Uninitialized value $src in /tools/viewlog.pl

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991

--- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 37980
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37980action=edit
Bug 13991: (QA followup) uninitialized value  and [0] in /tools/viewlog.pl

Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed.

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

   Severity|enhancement |normal
 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13386] 246 display in XSLT

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386

--- Comment #7 from Winona Salesky wsale...@gmail.com ---
Should this become a new issue? 

-Winona

(In reply to rgravel from comment #6)
 I think that sounds like a great idea, Nick. 
 
 One thing to keep in mind is that the second indicator isn't *always* coded;
 occasionally it's left blank and the type of other title isn't specified.
 So, I suspect you'd have to tell the xslt what to do in that case. 
 
 (In reply to Nick Clemens from comment #3)
  Outside the scope of this change, but if I had my druthers:
  
  246 2nd indicator specifies type of other title, would be nice to display
  that when 1st indicator 1.  Probab;y it would go into brackets like relator
  terms and would be overridden by subfield i
  
  That out of the way, works as described and will sign off momentarily

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13966] Backport HEA to Koha 3.16 and/or 3.14

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #6 from M. Tompsett mtomp...@hotmail.com ---
Test plan?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13386] 246 display in XSLT

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386

--- Comment #8 from rgra...@marlboro.edu ---
If it's not easy to incorporate into these changes and if Nicole thinks this is
something we can tackle later, then I'd say no. 

I'm about to put in a ticket to explore a development for dynamic display of
264s, which would similarly read the second indicator and change the label;
these two things seem very related, so I can add this to the ticket to see if
they might be better handled together.   

(In reply to Winona Salesky from comment #7)
 Should this become a new issue? 
 
 -Winona

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in XSLT

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387

--- Comment #9 from rgra...@marlboro.edu ---
We didn't originally include them because we didn't think they were often used,
but it's a valid point: if they are actually there, then you'd want to see
them. So, I'm for displaying all subfields associated with these fields.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed.

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #37959|0   |1
is obsolete||

--- Comment #7 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 37978
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37978action=edit
Bug 13993 - (2) Correct poorly transferred orders

Added Atomic Update to fix poorly transferred orders

TEST PLAN
-
8) Apply patch (2)
9) Run the database updates
   $ ./installer/data/mysql/updatedatabase.pl
   -- This should run without error
10) prove -v t/db_dependent/Acquisition/TransferOrder.t
-- This should succeed now, because the update fixed it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed.

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #37958|0   |1
is obsolete||

--- Comment #8 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 37979
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37979action=edit
Bug 13993 - (3) Transfer order leaves incorrect orderstatus

11) Apply patch (3)
12) Log in to staff client
13) Acquisitions
14) Create a basket for two different vendors
15) Place an order in one vendor's basket.
16) Transfer the order to the other vendor's basket.
17) prove -v t/db_dependent/Acquisition/TransferOrder.t
-- This should succeed without intervention.
18) Run koha qa test tools for the last 3 commits.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed.

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #37957|0   |1
is obsolete||

--- Comment #6 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 37977
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37977action=edit
Bug 13993 - (1) Add tests to confirm 'new' and 'cancelled'

This adds 2 tests to t/db_dependent/Acquisition/TransferOrder.t
in order to confirm the order's status is properly marked.

TEST PLAN
-
1) Log into staff client
2) Acquisitions
3) Create a basket for two differing vendors.
4) Place an order in one of the baskets.
5) Transfer the order from one vendor's basket to the others.
6) Apply this patch (1) only
7) prove -v t/db_dependent/Acquisition/TransferOrder.t
   -- should fail one test: not marked as 'cancelled'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13433] 655 display in XSLT

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433

--- Comment #9 from rgra...@marlboro.edu ---
Ideally, they should behave like subject headings and be clickable, too. 

(In reply to Nick Clemens from comment #6)

 2 - When displaying as Genre/Form the headings are not linked for searching,
 I think they should still be clickable.  This is just my opinion though,
 willing to concede ts one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6911] Log viewer should remember search terms

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #10 from Tomás Cohen Arazi tomasco...@gmail.com ---
QA followup pushed.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13528] Ability to search on the different isbn variations

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #8 from Tomás Cohen Arazi tomasco...@gmail.com ---
Enhancement pushed.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6520] Items don't display when viewing staged records

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #12 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed.

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993

--- Comment #5 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 37959
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37959action=edit
Bug 13993 - Correct poorly transferred orders

Added Atomic Update to fix poorly transferred orders

TEST PLAN
-
1) Do an order transfer
2) Confirm the bad transfer in sql
3) Apply this patch
4) Run the updatedatabase.pl script
5) Confirm the bad transfer is fixed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10355] Second click on modification log misses object parameter

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10355

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Katrin Fischer from comment #0)
 To reproduce the problem:
 
 1) Go to any detail page in staff
 2) Click on the modification log tab
 3) Verify, that the object is prefilled with the records biblionumber and
 you can also see it as parameter in the url
 4) Click a second time on modification log to reset your search

I am not sure this is still valid, when I am on tools/viewlog.pl, I don't see
the modification log tab, I see the menu from the tools module.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10299] authorities plugin putting values in reverse order

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10299

--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 37960
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37960action=edit
Bug 10299: authority plugin - authority field are reversed

If you click the plugin next to an authority field that is already
populated it takes the values from the field and puts them in the search
in the reverse order.

Test plan:
1/ Edit a biblio
2/ Fill the subfield for an authority field (for instance 650$v, 650$x,
650$y, etc.)
3/ Click on the authority plugin
Before this patch, the values were concatenated in the reverse order.
With this patch, it should not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10299] authorities plugin putting values in reverse order

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10299

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10299] authorities plugin putting values in reverse order

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10299

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Thanks for the image, very useful :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10299] authorities plugin putting values in reverse order

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10299

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Assignee|gmcha...@gmail.com  |jonathan.dru...@biblibre.co
   ||m
Version|3.10|master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6911] Log viewer should remember search terms

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6911] Log viewer should remember search terms

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Pushed to Master|ASSIGNED

--- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com ---
Quick patch, easy to test. Could I get a quick QA look please?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6911] Log viewer should remember search terms

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14004] Add ability to temporarily disable intranetuserjs / opacuserjs

2015-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14004

Barton Chittenden bar...@bywatersolutions.com changed:

   What|Removed |Added

Summary|Disable intranetuserjs /|Add ability to temporarily
   |opacuserjs  |disable intranetuserjs /
   ||opacuserjs

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >