[Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #7 from Marc Véron ve...@veron.ch ---
Created attachment 38126
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38126action=edit
Columns wrong in result table

In cgi-bin/koha/members/member.pl the birth date displays in the column
Category and an empty column is added.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13630] Angular-based circulation client

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630

Mike blac...@gmail.com changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10407] allow MARCXML records to be imported via Koha's GUI

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #38101|0   |1
is obsolete||

--- Comment #5 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 38127
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38127action=edit
Bug 10407 - allow MARCXML records to be imported via Koha's GUI

Initial commit

Added check to warn if ISO2709-Records' encoding is different than the expected
one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10407] allow MARCXML records to be imported via Koha's GUI

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #38127|0   |1
is obsolete||

--- Comment #6 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 38129
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38129action=edit
Bug 10407 - allow MARCXML records to be imported via Koha's GUI

Initial commit

Added check to warn if ISO2709-Records' encoding is different than the expected
one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122

--- Comment #16 from M. Tompsett mtomp...@hotmail.com ---
My question about testing changes more completely still stands (comment #14).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #22306|0   |1
is obsolete||

--- Comment #15 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38130
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38130action=edit
Bug 11122 - publisher code and publication year not fetched in acq orders

In acquisition, several templates try to display publisher code and publication
year : invoice.tt, parcel.tt, transferorder.tt.
Thoses pages use C4::Acquisition methods GetPendingOrders or GetInvoiceDetails.
The bug is that in the SQL query of those methods, biblioitems.publishercode
and biblioitems.publicationyear.
In uncertainprice.pl those datas are fetch using GetBiblioData.
It whould be better to fetch them in GetPendingOrders and GetInvoiceDetails.

This patch changes SQL queries to fetch wanted datas :
aqorders.*,biblio.title,biblio.author,biblioitems.isbn,biblioitems.publishercode,biblioitems.publicationyear.
GetInvoiceDetails also needs : biblio.seriestitle,biblioitems.volume.
This patch also unifies the way biblio datas are displayed :
  a href=link to catalog using biblionumber[title]/a emby/em [author]
ndash; [isbn]
  emPublisher:/em [publishercode], [publicationyear]

Test plan :
- Choose a biblio record containing a data in :
biblio.title,
biblio.author,
biblioitems.isbn,
biblioitems.publishercode,
biblioitems.publicationyear,
biblio.seriestitle,
biblioitems.volume.
- Create an order using this biblio.
- Look at this order in pages : parcel.pl, transferorder.pl, uncertainprice.pl
= You see publisher code and publication year
- Look at this order in page : invoice.pl
= You see publisher code, publication year, series title and volume

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||mtomp...@hotmail.com

--- Comment #54 from M. Tompsett mtomp...@hotmail.com ---
Some of this may also be obsolete. :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #37695|0   |1
is obsolete||

--- Comment #91 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38128
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38128action=edit
Bug 5010 - Fix OPACBaseURL to include protocol

First, it is strongly recommended to set the OPACBaseURL. But
this patch allows the inclusion of the protocol and not just
a site.

Next, C4/Auth now puts OPACBaseURL into the template parameters
regardless of OPAC or Staff clients.  t/db_dependent/Auth.t was
tweaked to add a check for confirming that get_template_and_user
adds OPACBaseURL to both OPAC and Staff templates.

In the staff client, once the OPACBaseURL is set, you get a nice
OPAC View link when viewing a biblio's detail. It should reflect
the protocol used now.

Hard coded 'http://' strings were removed from the
sample_notices.sql files. This is what required also updating
the letters table in the updatedatabase.pl script.

The explanation text in the sysprefs.sql needed updating too to
reflect the inclusion of the protocol. And this was the other
update done in the updatedatabase.pl script. The opac.pref file
was similarly changed as well.

catalogue/detail.pl had no need to pass a custom OpacUrl value,
since C4/Auth passes the required OPACBaseURL, so it and the
corresponding template were modified.

Both the MARC21 and NORMARC intranet details files had 'http://'
hard coded in them. This was removed.

Both the bootstrap and prog theme opac-detail template had a
protocol parameter that was used. The logic for the parameter
was not removed, because it is used extensively in one template.
Perhaps it should be used to simplify the other. However, the
calculated current_url parameter had references to the protocol
removed, because of the changes to OPACBaseURL.

opac/opac-shareshelf.pl had a hard coded 'http://' which was
removed.

t/db_dependent/Auth_with_cas.t had 'http://' added to the value
set for OPACBaseURL.

In virtualshelves/sendshelf.pl explicit code which sent the
OPACBaseURL preference was removed, since C4/Auth sends it all
the time now.

C4::Context::set_preference was tweaked to ensure that
OPACBaseURL would always start with http.
t/db_dependent/Context.t was tweaked to specifically test this.

The Shibboleth authentication needs OPACBaseURL set, and that
it be https protocol. The _get_uri routine was tweaked to always
pass back https:// as the protocol on the OPACBaseURL.
t/Auth_with_shibboleth.t was tweaked to specifically test the
changes.

TEST PLAN
-
This is not an easy patch to test. Difficulties include:
- configuring Koha to run under https
(tweaking apache2 isn't so hard, just tricky)
- configuring Koha to run OPAC and Staff with Plak
(since code with comments about plak were sliced out)
- configuring Koha to use CAS
(may be requires for the CAS test)

 1) Apply patch
 2) Make sure OPACBaseURL is set without the protocol included.

UPDATEDATABASE
 3) back up your DB
 4) ./installer/data/mysql/updatedatabase.pl
-- It should run without errors.
 5) Look up the OPACBaseURL system preference in the staff
client
-- It should have http:// prepended.
 6) Run the mysqlclient from your koha git directory
  USE koha_library;
  SELECT content FROM letter WHERE content LIKE %OPACBaseURL%;
-- There should be no prepended http:// on the
   OPACBaseURL.
 7) restore your DB
 8) Make sure OPACBaseURL is set with the protocol included,
preferably https.
-- Using https requires a bunch of apache2 tweaks.

AUTH
 9) Call up staff client.
10) Call up OPAC.
-- C4/Auth.pm doesn't barf.
11) Call up Plack staff client
12) Call up Plack OPAC.
-- C4/Auth.pm doesn't barf.
13) prove -v t/db_dependent/Auth.t

CONTEXT
14) Home - Koha administration - Global System Preferences
 - OPAC
15) Modify and save OPACBaseURL to not have http:// or https://
on it.
-- It should be modified to include http://
16) Modify and save another system preference.
-- It should save normally
17) prove -v t/db_dependent/Context.t

CATALOGUE/DETAIL (tt  pl)
18) Confirm the OPACBaseURL is set
19) Navigate to any biblio details in the staff client
-- There should be a OPAC view link which has the
   correct http:// or https:// in it.

SQL (sample notices and sysprefs)
20) Run the mysqlclient from your koha git directory
  USE koha_library;
  DELETE FROM letter;
  source installer/data/mysql/de-DE/mandatory/sample_notices.sql;
  SELECT content FROM letter WHERE content LIKE %OPACBaseURL%;
  DELETE FROM letter;
  source installer/data/mysql/en/mandatory/sample_notices.sql;
  SELECT content FROM letter WHERE content LIKE 

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13623] Enhance html for holds queue viewer

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13623

--- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 38144
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38144action=edit
Bug 13623: Follow-up: remove stray /p tag

Just removing a stray /p tag.

I got problems when trying to check this page
with an HTML validator, would probaby be worth
checking.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13623] Enhance html for holds queue viewer

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13623

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1917] Add RSS Feeds for Lists

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917

--- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Comment on attachment 38117
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38117
[Signed-off] Bug 1917 - Add RSS Feeds for Lists

Review of attachment 38117:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=1917attachment=38117)
-

Hi,

I love to see work on the low bug numbers! :)

The biggest issue here is that the strings from opac-shelves-rss.tt don't
appear to be translatable. I updated my po files, but the strings or file name
won't show up there.

I also found some smaller issues, please see comments below:

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves-rss.tt
@@ +2,5 @@
 +
 +rss version=2.0
 +
 +channel
 + title[% shelfname %]/title

Why no |html here, but below?

@@ +8,5 @@
 + descriptionRSS feed for public list [% shelfname | html %]/description
 +
 +[% FOREACH i IN itemsloop %]
 + item
 +  title[% i.title %] by [% i.author %]/title

The by is always shown, even if there is no author. Also because of the
included ISBD punctuation in MARC21 this would only be needed/useful for
UNIMARC.

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
@@ +153,5 @@
  [% IF ( viewshelf ) %]!--  Viewing a particular shelf 
 --
 +h3
 +[% shelfname |html %]
 +a href=[% OPACBaseURL 
 %]/cgi-bin/koha/opac-shelves.pl?rss=1amp;viewshelf=[% shelfnumber | html %] 
 class=rss-list-link noprint
 +img src=[% interface %]/[% theme 
 %]/images/feed-icon-16x16.png alt=Subscribe to this search 
 title=Subscribe to this search border=0 class=rsssearchicon/

Should we adjust the title here? Maybe: Subscribe to this list

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1917] Add RSS Feeds for Lists

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122

--- Comment #19 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38146
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38146action=edit
Bug 11122: Address MARC21 vs. UNIMARC issue

In comment #6 and comment #17, Katrin pointed out the discrepancy
between UNIMARC (using publisheryear) vs. Other MARC installations
(using copyrightdate). This was dealt with in invoice.tt already.
This patch does similar logic for the other 3 template files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13415] Prevent librarians from scanning multiple items into a single barcode field

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13415

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14011

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14011] Triggering slip print with enter key collides with 'barcode submitted' message

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14011

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13415

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14014] Argument isn't numeric in numeric gt () in circulation.tt

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14014

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff
   Severity|enhancement |trivial
   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8276] circ history not sorting right

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276

--- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 38142
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38142action=edit
Follow-up: Remove stry /td

Removes an additional /td tag that isn't needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8276] circ history not sorting right

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #37847|0   |1
is obsolete||

--- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 38141
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38141action=edit
[PASSED QA] Bug 8276: circ history - checked out items are later

If the sort is done on checkin on, the items currently checked out
should be list after all others.

Test plan:
1/ Go on the checkout history page for a record with checked out items
2/ Sort on the checkin on column and confirm that the checked out
items are sorted after/before others depending on the sort order
(asc/desc).

Signed-off-by: Josef Moravec josef.mora...@gmail.com

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8276] circ history not sorting right

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14015] New: Entering 0 (zero) as barcode reloads checkout page without patron information

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015

Bug ID: 14015
   Summary: Entering 0 (zero) as barcode reloads checkout page
without patron information
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

To reproduce:

- Go to Home  Circulation  Checkouts  [a patron]
- Enter 0 (zero) in barcode field and hit Enter

Result: circ/circulation.pl reloads without patron selected (Home  Circulation
 Checkouts). You have to search the patron again to proceed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13623] Enhance html for holds queue viewer

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13623

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #37849|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 38143
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38143action=edit
[PASSED QA] Bug 13623 - Enhance html for holds queue viewer

It would be very helpful from a css/scripting point of view if the
author field in the holds queue report had a selectable class. In
edition, it would be great if the biblionumber were easy to grab from a
hidden div.

Test Plan:
1) Apply this patch
2) Load the holds queue report ( view_holdsqueue.pl )
3) Inspect an author name with your web browser ( or view the html )
   a) Note the hq-author class of the wrapping div
   b) Note the hidden hq-biblionumber div

HTML appears as expected.
Signed-off-by: Marc Véron ve...@veron.ch

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13322] Update MARC21 frameworks to Update No. 19 (October 2014)

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13322

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #36675|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 38145
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38145action=edit
[PASSED QA] Bug 13322: Update MARC21 frameworks to Update No. 19

Summary of changes:
1) Bibliographic
- Added fields 370 and 388
- 382s is non repeatable
- $g added to 650 and 651
- $g now repeatable on 100,110,111,130,240,243,246,247,
  600,610,611,630,700,710,711,730,800,810,811 and 830

2) Authority
- Added field 388
- New $g on 150,151,450,451,550,551,750 and 751
- New $i on 700,710,711,730,748,750,751,755,762,780,781,782 and 785
- New $4 on 700,710,711,730,748,750,751,755,762,780,781,782,785 and 788
- $g now repeatable on 100,110,111,130,400,410,411,430,500,
  510,511,530,700,710,711 and 730

This patch updates MARC21 frameworks to Update No. 19 (October 2014)
Also updates values on database for MARC21 installs.

To test
1. Apply the patch
2. Run updatedatbase.pl, check that runs without error
3. Remove default frameworks, bibliographic and authorities (all of them),
load again. Check that both files load without errors.
4. Verify changes

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13322] Update MARC21 frameworks to Update No. 19 (October 2014)

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13322

--- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I have marked this passed QA, but please take a look at my last comment - thx!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13322] Update MARC21 frameworks to Update No. 19 (October 2014)

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13322

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14016] New: Due dates in OPAC show 0:00 when it should be 23:59

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14016

Bug ID: 14016
   Summary: Due dates in OPAC show 0:00 when it should be 23:59
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: jonathan.dru...@biblibre.com

The due dates on the checkouts tab in the patron account in the OPAC currently
show as 04/08/2015 00:00 when the due date is actually 23:59.

Staff and database are correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5685] Validation of email address field

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
2 Problems with this:

1) koha-tmpl/opac-tmpl/bootstrap/css/opac.css is not correctly 'compressed' -
before it is all on one line, now it's mulitple with just the spaces removed.

2) The patch adds a new jQuery plugin that should also show up on the about
page.

Please fix! Tests looked good.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #32 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Some first notes - please fix!

 FAILinstaller/data/mysql/updatedatabase.pl
   OK  critic
   OK  forbidden patterns
   OK  pod
   FAIL  valid
Missing right curly or square bracket 
installer/data/mysql/updatedatabase.pl had compilation errors.
syntax error 

 OKt/db_dependent/Circulation_Branch.t
   OK  critic
   OK  forbidden patterns
   OK  pod
   OK  valid

 FAILkoha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
   FAIL  forbidden patterns
forbidden pattern: tab char (line 287)
forbidden pattern: tab char (line 279)
   OK  tt_valid
   OK  valid_template

 OKinstaller/data/mysql/sysprefs.sql
   OK  sysprefs_order

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122

--- Comment #18 from M. Tompsett mtomp...@hotmail.com ---
(In reply to Katrin Fischer from comment #17)
 I am sorry, but this is not MARC agnostic - while UNIMARC uses
 publicationyear, MARC21 standard installations save this information in
 copyrightdate. Please take this into account.

Actually, this is agnostic. For MARC, the output should be unchanged. For
UNIMARC, the publication year will be added.

Are you saying that copyrightdate should be used too, so that UNIMARC and
MARC21 installations will have identical output?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13322] Update MARC21 frameworks to Update No. 19 (October 2014)

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13322

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
This looks all good and I think it would be good to include updated frameworks
in our next release.

Only one question here: What about the non-default frameworks for bilbiographic
and authorities?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7939] Separate po files for different MARC dialects

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939

--- Comment #15 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Bernardo, can you please take a look? Tomas has set us a tight deadline!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7939] Separate po files for different MARC dialects

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I think in the past all the po files used to have the version number of the
version they were applying to - but it was more trouble than useful to keep
changing the file names. Currently the staff po file is the only file that
still has a (wrong) version number. I am in favor of the change! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14008] Filters are not displayed on search for reports

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #7 from M. Tompsett mtomp...@hotmail.com ---
Retested with dependency. Sign-off holds. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14013] Use name of a saved report as part of the file name for download

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14013

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14013] Use name of a saved report as part of the file name for download

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14013

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #38134|0   |1
is obsolete||

--- Comment #2 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38135
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38135action=edit
Bug 14013 - Use name of a saved report as part of the file name for download

This patch propoeses the name of a saved report as part of the download file
name.

To test:

- Apply patch
- Got to Home  Reports  Guided reports wizard  Saved reports (or create a
new report from sql)
- Run a saved report
- Download the report (as csv, tab, ods)
Result: The downlaod file name proposed should be prepended by the report name,
separated with a -

- Bonus test: Try to downlaod saved reports which have special character in
their name.

NOTE: Used ñ/â is N/A as a report name. The /'s were translated
  to underscored, but the letters were as expected.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14008] Filters are not displayed on search for reports

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #38125|0   |1
is obsolete||

--- Comment #5 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38137
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38137action=edit
Bug 14008 - Proposed follow-up: Dialog should appear whenever filters are
active

The first patch displays the value(s) of an active filter if you come back to
the page or reload the page via a menu action.
To make the situation more clear the dialog No saved reports match your
criteria. shoudl always appear when a filter is active.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14008] Filters are not displayed on search for reports

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #38062|0   |1
is obsolete||

--- Comment #4 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38136
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38136action=edit
Bug 14008: Display active filters when searching for reports

On the saved report list, the filters on the left are not displayed.
It means that some can be set, but the user has not visible feedbacks.

How filters work here:
If a user set a filter, it is saved in the session. Next time he will
come on this search, the previous values will be kept.

This patch just displayed the filter's values in the input fields.

Test plan:
Search for reports by date, author and keyword.
The filters should be displayed after you have clicked on the submit
button (Apply filter).

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14008] Filters are not displayed on search for reports

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #6 from M. Tompsett mtomp...@hotmail.com ---
Oops... Signed off without including the Depends on. Will re-test in 6+
hours.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14011] Triggering slip print with enter key collides with 'barcode submitted' message

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14011

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14014] Argument isn't numeric in numeric gt () in circulation.tt

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14014

--- Comment #1 from Marc Véron ve...@veron.ch ---
Created attachment 38139
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38139action=edit
Bug 14014 - Argument  isn't numeric in numeric gt () in circulation.tt

To test:

Do some checkouts
In intranet-error.log you get lines similar to:
circulation.pl: Argument  isn't numeric in numeric gt () at
/usr/share/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
line 217.

Apply patch
The warning  should no longer appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13982] Checkouts table not sorting on correct column

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #37786|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 38140
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38140action=edit
[PASSED QA] Bug 13982 - Checkouts table not sorting on correct column

The Date Due column for checkouts is using the column index 1 to sort by.
This column is the one that is used for grouping items into today's checkouts
and previous checkouts. This is definitely not the column that should be used.
Instead, we should be using column index 2, which contains the raw unformatted
due date.

Revised Test Plan:
1) Find a patron with no checkouts
2) Check out something as due the beginning on the month.
3) Check out something as due the end of the month.
4) Check out something due tomorrow (hopefully not end of month)
   -- so you should have 2015-04-01, 2015-04-30, and 2015-04-14
  (for example)
5) Attempt to sort by due date
   -- Note the sorting is incorrect
6) Apply this patch
7) Clear your browser cache
8) Reload the page
9) Attempt to sort by due date again
   -- Note the sorting works correctly this time
10) Verify there are no regressions with bug 13908
-- this will require finding a patron with many checkouts,
   playing with the Circulation system preferences
   previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder,
   and understanding what the four different cases mean with
   respect to actually manually sorting the 'Due Date' column.

NOTE: I did not do step 10,
Signed-off-by: Mark Tompsett mtomp...@hotmail.com

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13982] Checkouts table not sorting on correct column

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13623] Enhance html for holds queue viewer

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13623

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14011] Triggering slip print with enter key collides with 'barcode submitted' message

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14011

--- Comment #1 from Marc Véron ve...@veron.ch ---
Created attachment 38138
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38138action=edit
Bug 14011 - Triggering slip print with enter key collides with 'barcode
submitted'

To reproduce:

- submit empty checkout for triggering a slip print
- print the slip or cancel
- notice you can't read a new barcode into the field now,
  instead, the 'barcode submitted' message will be triggered each time
  you try

To test:
- apply patch
- try to reproduce issue

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14014] New: Argument isn't numeric in numeric gt () in circulation.tt

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14014

Bug ID: 14014
   Summary: Argument  isn't numeric in numeric gt () in
circulation.tt
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

intranet-error.log contains:

Argument  isn't numeric in numeric gt () at
/usr/share/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
line 217

Line 217:
[% IF ( RENTALCHARGE  0 ) %]

RENTALCHARGE does not necessarily exist.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #17 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I am sorry, but this is not MARC agnostic - while UNIMARC uses publicationyear,
MARC21 standard installations save this information in copyrightdate. Please
take this into account.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14013] Use name of a saved report as part of the file name for download

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14013

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14011] Triggering slip print with enter key collides with 'barcode submitted' message

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14011

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13995] Proper Exception handling

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #37827|0   |1
is obsolete||

--- Comment #3 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 38131
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38131action=edit
Bug 13995 - Proper Exception handling

try {
Koha::Exception::BadSystemPreference-throw(error = 'Syspref
DisplayIconsXSLT is not a valid boolean');
} catch {
if (blessed($_)  $_-isa('Koha::Exception::BadSystemPreference')) {
print $_-as_string();
warn $_-error, \n, $_-trace-as_string, \n;
}
else {
$_-rethrow();
}
}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14012] New: Koha::FTP, a happy FTP-library to supercharge FTP operations.

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14012

Bug ID: 14012
   Summary: Koha::FTP, a happy FTP-library to supercharge FTP
operations.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: olli-antti.kivila...@jns.fi
QA Contact: testo...@bugs.koha-community.org

When dealing with FTP-connections, we need to prepare for all kinds of remote
connection failures.
This library simply wraps exception handling and connection creation into a one
nice package.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14012] Koha::FTP, a happy FTP-library to supercharge FTP operations.

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14012

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Status|NEW |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10627] history of reports run/results

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10627

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

--- Comment #11 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 38116
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38116
Bug 13889 - Add information about cron jobs to system log

Review of attachment 38116:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=13889attachment=38116)
-

::: installer/data/mysql/sysprefs.sql
@@ +474,5 @@
  ('XSLTDetailsDisplay','default','','Enable XSL stylesheet control over 
 details page display on intranet','Free'),
  ('XSLTResultsDisplay','default','','Enable XSL stylesheet control over 
 results page display on intranet','Free'),
  ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields 
 for Personal Name Authorities to fill biblio.author','free'),
 +('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will 
 replace authors in biblio.author','YesNo'),
 +('CronjobLog','0',NULL,'If ON, log information from cron jobs.','YesNo')

This should be placed alphabetically.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13979] Packages uninstallable on Debian Jessie

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979

Tom Misilo misi...@fit.edu changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14011] Triggering slip print with enter key collides with 'barcode submitted' message

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14011

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14011] Triggering slip print with enter key collides with 'barcode submitted' message

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14011

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #38138|0   |1
is obsolete||

--- Comment #2 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38148
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38148action=edit
Bug 14011 - Triggering slip print with enter key collides with 'barcode
submitted'

To reproduce:

- Log into staff client
- Find a client with 0 checkouts
- Print a slip (or cancel printing it)
- Attempt to type in a barcode to checkout
  -- annoying modal screen pops up
 'barcode submitted' message will be triggered each time
 you try

To test:
- apply patch
- try to reproduce issue

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||mtomp...@hotmail.com

--- Comment #13 from M. Tompsett mtomp...@hotmail.com ---
Koha QA tools fails related to my comment #11.
And a tab character on line 37 of C4/Log.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Tom Misilo misi...@fit.edu changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6059] Problem with changing quantity on uncertain prices list

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6059] Problem with changing quantity on uncertain prices list

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #37560|0   |1
is obsolete||

--- Comment #5 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38149
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38149action=edit
Bug 6059: Don't permit to change the quantity when items are created on
ordering

If items are created on ordering, the quantity for uncertain prices
should not be editable.

Test plan:
0/ Set AcqCreateItem to on ordering
1/ Create a basket and add an order with 1+ items
2/ Mark it as uncertain prices
3/ Go on the uncertain prices page for this vendor
(acqui/uncertainprice.pl?booksellerid=X)
4/ Confirm you are not allowed to update the quantity
5/ Change the price and save
6/ Confirm the quantity is still correct

Set the pref to another value and confirm the behavior has not changed.

NOTE: Tested with 'on placing order' and 'on receiving order'.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14014] Argument isn't numeric in numeric gt () in circulation.tt

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14014

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #38139|0   |1
is obsolete||

--- Comment #2 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38147
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38147action=edit
Bug 14014 - Argument  isn't numeric in numeric gt () in circulation.tt

To test:

Do some checkouts
In intranet-error.log you get lines similar to:
circulation.pl: Argument  isn't numeric in numeric gt () at
/usr/share/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
line 217.

Apply patch
The warning  should no longer appear.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14014] Argument isn't numeric in numeric gt () in circulation.tt

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14014

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14017] New: Join the General Mailing list does is a 404

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14017

Bug ID: 14017
   Summary: Join the General Mailing list does is a 404
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Websites, Mailing Lists, etc
  Assignee: wizzy...@gmail.com
  Reporter: misi...@fit.edu
QA Contact: testo...@bugs.koha-community.org

The URL for the General List no longer works. 

Current link is: http://lists.katipo.co.nz/mailman/listinfo/koha which Does not
exist.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

--- Comment #12 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 38116
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38116
Bug 13889 - Add information about cron jobs to system log

Review of attachment 38116:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=13889attachment=38116)
-

::: installer/data/mysql/updatedatabase.pl
@@ +10039,5 @@
 +if ( CheckVersion($DBversion) ) {
 +$dbh-do(INSERT IGNORE INTO `systempreferences` 
 (variable,value,explanation,options,type) VALUES ('CronjobLog','0',NULL,'If 
 ON, log information from cron jobs.','YesNo'););
 +print Upgrade to $DBversion done (Add CronjobLog syspref)\n;
 +SetVersion ($DBversion);
 +}

This new. Why not do the new atomic update way?
http://wiki.koha-community.org/wiki/Database_updates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122

--- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de ---

 Are you saying that copyrightdate should be used too, so that UNIMARC and
 MARC21 installations will have identical output?

Yep.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7595] Add branchcode to accountlines

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7595] Add branchcode to accountlines

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #30950|0   |1
is obsolete||

--- Comment #30 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38150
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38150action=edit
Bug 7595 - Add branchcode to accountlines

Adds a branchcode column to the accountlines table. For payments,
this inserts the branchcode of the library where the payment was
recorded. For manual invoices, it insert the branchcode of the
library where the manual invoice was created.

NOTE: Rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10388] acq edited items showing 'null's

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981

--- Comment #33 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 38151
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38151action=edit
Bug 7981: Follow-up - Fix qa script complaints

- Fix updatedatabase, moving the update entry into the right spot
- Fix some tabs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7595] Add branchcode to accountlines

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #31 from M. Tompsett mtomp...@hotmail.com ---
I'll triple check I didn't miss anything in the fix later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14018] New: Ordering from suggestion shows 'copy. year:2014'

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14018

Bug ID: 14018
   Summary: Ordering from suggestion shows 'copy. year:2014'
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

To test:

- create a suggestion with the publication year
- accect suggestion
- create a new order from that suggestion
- in the list of suggestions to order, the display problem should be visible:
  copy. year:2014 

I'd rather avoid using the copyright symbol here as it has often caused
problems in translations for us and probably others. Maybe just having the year
would be ok?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10388] acq edited items showing 'null's

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #37672|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 38152
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38152action=edit
[PASSED QA] Bug 10388: Does not display 'null' after editing an item on
receiving

After editing an item on receiving, 'null' is displayed if no value is
defined for a field. It should be blank.

Test plan:
0/ Set AcqCreateItem to 'ordering'
1/ Go on the receipt page page
2/ Edit an item
3/ Does not fill all values
4/ Confirm that undefined values are replaced with an empty string

NOTE: I think you meant receive. Editing requires at least clicking
  the dropdown value, even if you don't change it before
  clicking save. null's appeared. Post patch application was
  able to get nulls to disappear. :)

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10388] acq edited items showing 'null's

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388

--- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
One question I won't have to answer in training again :) yay!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10407] allow MARCXML records to be imported via Koha's GUI

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #38129|0   |1
is obsolete||

--- Comment #7 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 38133
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38133action=edit
Bug 10407 - allow MARCXML records to be imported via Koha's GUI

Initial commit

Added check to warn if ISO2709-Records' encoding is different than the expected
one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14013] Use name of a saved report as part of the file name for download

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14013

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10627

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14013] Use name of a saved report as part of the file name for download

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14013

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10627] history of reports run/results

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10627

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14013

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14012] Koha::FTP, a happy FTP-library to supercharge FTP operations.

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14012

--- Comment #1 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 38132
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38132action=edit
Bug 14012 - Koha::FTP, a happy FTP-library to supercharge FTP operations.

try {
my $ftp = Koha::FTP-new( Net::FTP-new() );

my $currentDir = $ftp-getCurrentFtpDirectory();
$ftp-changeFtpDirectory($targetDirectory, $ftp);
$ftp-putFtpFile($filePath, $ftp);
$ftp-changeFtpDirectory($currentDir, $ftp);
$ftp-deleteFtpFile($fileName, $ftp);
catch {
if (blessed($_)  $_-isa('Koha::Exception::ConnectionFailed')) {
warn $_-error().\n;
}
}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14013] New: Use name of a saved report as part of the file name for download

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14013

Bug ID: 14013
   Summary: Use name of a saved report as part of the file name
for download
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: gmcha...@gmail.com
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org

If you download the results of a saved report Koha proposes a standard filename
(reportresults.csv / reportresults.tab / reportresults.ods)

It would be nice to get the name of the saved report as part of the download
file name, e.g. 
MyReport-reportresults.csv
OtherReport-reportresults.csv

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14013] Use name of a saved report as part of the file name for download

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14013

--- Comment #1 from Marc Véron ve...@veron.ch ---
Created attachment 38134
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38134action=edit
Bug 14013 - Use name of a saved report as part of the file name for download

This patch propoeses the name of a saved report as part of the download file
name.

To test:

- Apply patch
- Got to Home  Reports  Guided reports wizard  Saved reports (or create a
new report from sql)
- Run a saved report
- Download the report (as csv, tab, ods)
Result: The downlaod file name proposed should be prepended by the report name,
separated with a -

- Bonus test: Try to downlaod saved reports which have special character in
their name.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/