[Koha-bugs] [Bug 14057] Inventory is painfully slow
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #38507|0 |1 is obsolete|| --- Comment #14 from Marc Véron ve...@veron.ch --- Comment on attachment 38507 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38507 Bug 14057 - A Rough Start - Compare old and new code Obsoleting my temporary patch with test code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14060] Remove readonly on date inputs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38540 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38540action=edit Bug 14060: Add OnClose event on missing datepicker The suspend until inputs (hold list on circ/circulation.pl and members/moremember.pl) were not set in the same way. The minDate option should be set for both (bug 10703 removed it for circ/circulation.pl). This patch reintroduces the option and add the OnClose event on both. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #38343|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38542 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38542action=edit Bug 14044: Escape json strings for patron searches In a couple of patron searches, the address is displayed. If the address contain invalid json characters, DataTables won't manage to parse the results and display them. This patch makes the templates more readable by creating a BLOCK instead of a long line and escape the invalid json characters calling the TT plugin (To.json). Test plan: Edit a patron and add something like: patron address \123 ☎ ⚑ in the address field. Search for this patron using the main patron search (members/member.pl) and the guarantor search. Confirm that a result with this patron is correctly displayed. Regression test: Since Koha::Template::Plugin::To::json is modified, confirm that the add users to basket search (on acqui/basket.pl?basketno=X click on the Add user button) still works as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 Julian FIOL julian.f...@biblibre.com changed: What|Removed |Added Attachment #38529|0 |1 is obsolete|| --- Comment #11 from Julian FIOL julian.f...@biblibre.com --- Created attachment 38530 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38530action=edit Bug 13899 : Changing license to GPLv3 koha-qa should be good : OKmisc/devel/coverage.pl OK critic OK forbidden patterns OK pod OK valid OKC4/Installer/PerlDependencies.pm OK critic OK forbidden patterns OK pod OK valid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14063] Implement language overlay for authorised values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14063 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m CC||jonathan.dru...@biblibre.co ||m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||tomasco...@gmail.com Severity|normal |major --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- This issue could cause failures when upgrading from 3.18 to 3.20, I am raising the priority. It should be fixed before the 3.20 release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38543 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38543action=edit Bug 13810: Change collate for tagsubfield (utf8_bin) Before bug 11944, the marc_subfield_structure.tagsubfield column had a specific collate: utf8_bin. It has been introduced by commit 67e20d82ffdfcd69344ec30696bebc51c00d863c Date: Sun Jun 22 16:35:48 2008 -0500 DB Bump 094 - bug 2268 -- allow mixed case subfield labels in MARC21 by changing db column collation. This change should be kept and Koha should continue to allow and create subfields with the same letter but different case sensitivity. What does this patch: 1/ To prevent the updatedatabase entry 3.19.00.006 to fail if subfields with different case sensitivity already exist in the DB, the table is managed separately from others. 2/ To update DB which have already pass this dbrev, a new entry will be create to update the specific collate for this column. Test plan: 1/ a. With a 3.18 DB, create subfield 'a' and 'A' for the same field b. Execute the updatedatabase.pl script. 3.19.00.006 should not fail anymore 2/ a. With a master DB (3.19.00.006 has already been executed), create subfields 'a' and 'A'. You should get an error. b. Apply this patch, execute the DB entry and try again 2/a. you should be able to create the second subfield. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Assignee|k...@bywatersolutions.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- Please obsolete your patch if you agree with mine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Nicolas, If you have a look at a 3.18.x branch, you will see that the marc_subfield_structure.tagsubfield had a specific collate. We should keep utf8_unicode_ci for other tables and columns, so I suggest to set back utf8_bin for this column. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13914] The holds statistics report returns random data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914 --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Eivin Giske Skaaren from comment #2) I am still very new to Koha so please excuse (and explain) if I am thinking wrong here: The query that gets fired when testing this bug looks like this: [skip] So one way of getting line numbers that are not unique for the same col is if priority is set to 0 for an item in the old_reserves table. Question: Should priority ever be anything else than 0 for an item in the old_reserves table? Yes, I think so. At least I have some on local installation. I suppose the priority is not updated when a reserve is canceled. So if it has a priority 0, it will be copied as it to the old_reserves. Perhaps this is better solved by getting the SQL correct for the use case, perhaps by adding a field to the result set that is unique? I assumed that the query was correct. But as you can see, it is ugly and there is certainly a better way to do the same work. This patch then does not solve the problem if the things that I have assumed are correct. Did you have the patience to test/compare the results? I didn't :) But the customer validated the patch, so I supposed he tested it. If you are able to give me a simple example to recreate a issue on my side, I will have a look and try to provide a fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #24 from Chris Cormack ch...@bigballofwax.co.nz --- (In reply to Julian Maurice from comment #23) (In reply to Robin Sheat from comment #22) (In reply to Julian Maurice from comment #20) I only used dh-make-perl and debuild to build packages (and dpkg to install them). That won't result in a package acceptable to Debian. But it will be acceptable to debian.koha-community.org, won't it ? No, we build proper packages for debian.koha-community.org and upstream them also. eg https://qa.debian.org/developer.php?login=ro...@catalyst.net.nz this gets them into debian proper, and from there into ubuntu. Regardless of the packages, I think this should be split into a bunch of bugs, certainly shifting the documentation one off on to its on thing. I don't think we need to build any front end stuff for this. If we do that should be on it's on bug also. To get something like this in, its much better to do what was done with the acquisitions work, seperate bugs that don't mean the entire thing has to pass at once. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #25 from Julian Maurice julian.maur...@biblibre.com --- (In reply to Chris Cormack from comment #24) Regardless of the packages, I think this should be split into a bunch of bugs, certainly shifting the documentation one off on to its on thing. I don't think we need to build any front end stuff for this. If we do that should be on it's on bug also. To get something like this in, its much better to do what was done with the acquisitions work, seperate bugs that don't mean the entire thing has to pass at once. I disagree. The front end stuff is the API documentation, and I don't think we can integrate the new API without a proper documentation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11576] Untranslatable manage in serials-collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38544 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38544action=edit Bug 11576: Make manage translatable - serials-collection If a subscription is irregular, a tab with manage is displayed on the serial collection page. But this string is not translatable. Test plan: 1/ Go on the serial collection page of an irregular subscription (or create one). 2/ Note that the first tab was named managed, it's now Manage. 3/ Update a po lang file and confirm you see the string and you are able to translate it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11576] Untranslatable manage in serials-collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Severity|normal |minor Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11576] Untranslatable manage in serials-collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685 Tom Misilo misi...@fit.edu changed: What|Removed |Added CC||misi...@fit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8007] Discharge management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||ro...@catalyst.net.nz, ||tomasco...@gmail.com --- Comment #106 from Tomás Cohen Arazi tomasco...@gmail.com --- Ok, I hate you guys :-D Couldn't you just choose a PDF library that is shipped with Debian? :-D I successfully built both - libpdf-writer-perl - libpdf-fromhtml-perl on Jessie but I need to check with Robin. Maybe he would let me build those. I put this one on hold for a couple days (it works, I like it). There's also a new non-Perl dependency python-pisa. It definitely needs to be added to control.in on the koha-deps section for this to be pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 --- Comment #17 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38572 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38572action=edit Three Barcodes and blank lines (\n delimiter) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 --- Comment #18 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38573 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38573action=edit Three Barcodes and blank lines (\r delimiter) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #37848|0 |1 is obsolete|| --- Comment #20 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38575 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38575action=edit Bug 10625: Inventory/Stocktaking tool cannot handle windows file uploads The current code uses $barcode = fh; logic. This reads until \n, as far as I can tell. EOL is indicated by \n, \r, and \r\n depending on OS and software. So, to this end, rather than File::Slurp (which is a potential memory hog, which is already an issue with no filters), a loop to pre-read the barcodes was written. This loop includes: $barcode =~ s/\r/\n/g; $barcode =~ s/\n\n/\n/g; my @data = split(/\n/, $barcode); push @uploadedbarcodes,@data; So, that means that lines ending in \n would have it stripped and pushed into the uploaded barcodes array. Lines ending in \r would likely be read as one giant block, have everything converted to single \n's and then using a split, the set of barcodes are pushed into the uploaded barcodes array. Lines ending in \r\n would get that stripped and pushed into the uploaded barcodes array. It is then the uploaded barcodes array that is looped over for validating the barcodes. TEST PLAN - 1) Back up your database 2) Download the three sample files (or create your own) 3) Log in to staff client 4) Create a branch with no inventory. 5) Home - Tools - Inventory/Stocktaking 6) Browse for your '\r' test file. 7) Limit to just that branch 8) Click 'Submit' -- Confirm expected errors 9) Repeat steps 5-8 with the '\n' test file. 10) Repeat steps 5-8 with the '\r\n' test file. -- one of these repetitions should have problems. 11) Apply patch 12) Repeat steps 5-8 for each of the 3 test files. -- there should be no issues. 13) run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Christopher Brannon cbran...@cdalibrary.org changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||cbran...@cdalibrary.org --- Comment #6 from Christopher Brannon cbran...@cdalibrary.org --- Works in circulation.pl. Problem still exists in member.pl and guarantor_search.pl. Don't know about other areas. Christopher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 --- Comment #19 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38574 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38574action=edit Three Barcodes and blank lines (\r\n delimiter) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #38575|0 |1 is obsolete|| --- Comment #21 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38576 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38576action=edit Bug 10625: Inventory/Stocktaking tool cannot handle windows file uploads The current code uses $barcode = fh; logic. This reads until \n, as far as I can tell. EOL is indicated by \n, \r, and \r\n depending on OS and software. So, to this end, rather than File::Slurp (which is a potential memory hog, which is already an issue with no filters), a loop to pre-read the barcodes was written. This loop includes: $barcode =~ s/\r/\n/g; $barcode =~ s/\n\n/\n/g; my @data = split(/\n/, $barcode); push @uploadedbarcodes,@data; So, that means that lines ending in \n would have it stripped and pushed into the uploaded barcodes array. Lines ending in \r would likely be read as one giant block, have everything converted to single \n's and then using a split, the set of barcodes are pushed into the uploaded barcodes array. Lines ending in \r\n would get that stripped and pushed into the uploaded barcodes array. It is then the uploaded barcodes array that is looped over for validating the barcodes. TEST PLAN - 1) Back up your database 2) Download the three sample files (or create your own) 3) Log in to staff client 4) Create a branch with no inventory. 5) Home - Tools - Inventory/Stocktaking 6) Browse for your '\r' test file. 7) Limit to just that branch 8) Click 'Submit' -- Confirm expected errors 9) Repeat steps 5-8 with the '\n' test file. 10) Repeat steps 5-8 with the '\r\n' test file. -- one of these repetitions should have problems. 11) Apply patch 12) Repeat steps 5-8 for each of the 3 test files. -- there should be no issues. 13) run koha qa test tools. Note: This is a tweak based on Jonathan Druart's comment #16 I have reset it to needs sign off again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #38526|0 |1 is obsolete|| --- Comment #5 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38527 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38527action=edit Bug 13767: Fix Readonly::XS version detection The about.pl screen is unable to see that version 1.05-1+b1 is installed because eval require Readonly::XS returns an error message telling you that you can't use Readonly::XS directly. Since it is the only one, we attempt to use /usr/bin/dpkg to determine the version number. TEST PLAN - 1) $ dpkg -l libreadonly-xs-perl -- note the version number 2) Log in to staff client 3) About Koha - Perl modules -- note it says Readonly::XS is not installed. -- note the versions and colours of the other modules. 4) Apply patch 5) Reload page and go to Perl modules tab -- Readonly::XS should list the version noted in step 1. -- the other modules' output should be unchanged. 6) Run koha qa test tools For non-debian systems lacking a /usr/bin/dpkg, the output would be identical since the version number variable is left undefined, which is true for the criteria used for the missing logic. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 --- Comment #7 from Marc Véron ve...@veron.ch --- To test what happens if libreadonly-xs-perl is not installed, I did: apt-get remove libreadonly-xs-perl On the about page, I get now: Readonly::XS (1.02) | [nothing in column for version number] I would expect: Readonly::XS (1.02) | Not installed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 Julian FIOL julian.f...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Version|3.18|master Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11559] Professional cataloger's interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #84 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38538 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38538action=edit Bug 11559 followup - refactoring and cleanup Added license headers to all JS files, moved metasearcher code into a new service that largely lives in Koha::, and massively cleaned up the internals of the textual MARC machinery. Also, fixed some encoding and saving issues. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11559] Professional cataloger's interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #83 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38537 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38537action=edit Bug 11559 followup - Remove Pazpar2 dependency, bugfixes Adds a new metasearch service, removing dependency on Pazpar2. Current limitations: * Can only sort by title. Should be easy to fix. * Requires refetching results when changing pages. Also adds an edit items link, and fixes a loading error when logged in as the database user. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11559] Professional cataloger's interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559
--- Comment #82 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 38536
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38536action=edit
Bug 11559 followup - Allow insertion of dollar sign, remove fixFloat
The dollar sign now shows up as {dollar} inside subfield contents. This
is converted on load and save.
Also, remove fixFloat, as it has moved and is no longer needed anyway.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #38528|0 |1 is obsolete|| --- Comment #10 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38531 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38531action=edit Bug 13767: Fix Readonly::XS version detection The about.pl screen is unable to see that version 1.05-1+b1 is installed because eval require Readonly::XS returns an error message telling you that you can't use Readonly::XS directly. Since it is the only one, we attempt to use /usr/bin/dpkg to determine the version number. TEST PLAN - 1) $ dpkg -l libreadonly-xs-perl -- note the version number 2) Log in to staff client 3) About Koha - Perl modules -- note it says Readonly::XS is not installed. -- note the versions and colours of the other modules. 4) Apply patch 5) Reload page and go to Perl modules tab -- Readonly::XS should list the version noted in step 1. -- the other modules' output should be unchanged. 6) Run koha qa test tools All systems running Koha will have perldoc installed. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6815] Capture member photo via webcam
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Marc Véron ve...@veron.ch changed: What|Removed |Added CC||ve...@veron.ch --- Comment #12 from Marc Véron ve...@veron.ch --- Sorry, could not test patch (no access to webcam with my server / vm) Tested code on jsfiddle.net with a client - works. I would prefer a client side solution. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #38527|0 |1 is obsolete|| --- Comment #9 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38528 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38528action=edit Bug 13767: Fix Readonly::XS version detection The about.pl screen is unable to see that version 1.05-1+b1 is installed because eval require Readonly::XS returns an error message telling you that you can't use Readonly::XS directly. Since it is the only one, we attempt to use /usr/bin/dpkg to determine the version number. TEST PLAN - 1) $ dpkg -l libreadonly-xs-perl -- note the version number 2) Log in to staff client 3) About Koha - Perl modules -- note it says Readonly::XS is not installed. -- note the versions and colours of the other modules. 4) Apply patch 5) Reload page and go to Perl modules tab -- Readonly::XS should list the version noted in step 1. -- the other modules' output should be unchanged. 6) Run koha qa test tools For non-debian systems lacking a /usr/bin/dpkg, the output would be identical since the version number variable is left undefined, which is true for the criteria used for the missing logic. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 --- Comment #10 from Julian FIOL julian.f...@biblibre.com --- Created attachment 38529 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38529action=edit Bug 13899 : Changing license to GPLv3 koha-qa should be good : OKmisc/devel/coverage.pl OK critic OK forbidden patterns OK pod OK valid OKC4/Installer/PerlDependencies.pm OK critic OK forbidden patterns OK pod OK valid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 --- Comment #11 from Marc Véron ve...@veron.ch --- Created attachment 38532 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38532action=edit [Signed-off] Bug 13767: Fix Readonly::XS version detection The about.pl screen is unable to see that version 1.05-1+b1 is installed because eval require Readonly::XS returns an error message telling you that you can't use Readonly::XS directly. Since it is the only one, we attempt to use /usr/bin/dpkg to determine the version number. TEST PLAN - 1) $ dpkg -l libreadonly-xs-perl -- note the version number 2) Log in to staff client 3) About Koha - Perl modules -- note it says Readonly::XS is not installed. -- note the versions and colours of the other modules. 4) Apply patch 5) Reload page and go to Perl modules tab -- Readonly::XS should list the version noted in step 1. -- the other modules' output should be unchanged. 6) Run koha qa test tools All systems running Koha will have perldoc installed. :) Tested with an without Readonly::XS 1.04 installed. Works as expected. Signed-off-by: Marc Véron ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11559] Professional cataloger's interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #81 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38535 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38535action=edit Bug 11559 - Rancor: professional cataloging interface Test plan: 1. Apply patches for bug 10486 and this bug. 2. Reinstall patches for pazpar2. 3. Switch back and forth between basic and advanced editor, and verify that preference is saved (by workstation, not user. 4. Enter in a record (with all required fields). 5. Save to ISO2709, MARCXML and catalog, verify that all three match. 6. Import a MARCXML and ISO2709 record, and verify that the record is correct after import. 7. Run keyword and advanced searches with a variety of Z39.50 servers to check that searching is correct, and try to both import records as new records and substitute them for the contents of existing records. 8. Create, edit and delete macros, verifying that they are autosaved. 9. Try running macros (example follows). 10. Try enabling and disabling fixed-field widgets and customizing fonts, and test the editor afterwards. Example macro: goto field 003 copy field data insert new field 040 data= goto subfield end insert new subfield a data= goto subfield a paste -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11559] Professional cataloger's interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #36243|0 |1 is obsolete|| Attachment #36244|0 |1 is obsolete|| Attachment #36245|0 |1 is obsolete|| Attachment #36246|0 |1 is obsolete|| Attachment #36247|0 |1 is obsolete|| Attachment #36248|0 |1 is obsolete|| Attachment #36455|0 |1 is obsolete|| --- Comment #79 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38533 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38533action=edit Bug 11559 - Supporting changes for Rancor * Extends login screen to pass along #hash * Adds JSONP support to C4::Service * Extends humanmsg to allow per-message classes * Adds proper charset to results of svc/bib -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11559] Professional cataloger's interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #80 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38534 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38534action=edit Bug 11559 - New libraries for Rancor Adds the following JS libraries: * CodeMirror - extensible text editor * FileSaver - shim for saving files * pz2 - library for connecting to pazpar2 * require - dependency resolver and module loader -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Andreas Hedström Mace andreas.hedstrom.m...@sub.su.se changed: What|Removed |Added CC||andreas.hedstrom.mace@sub.s ||u.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 --- Comment #6 from Marc Véron ve...@veron.ch --- Results with new patch: dpkg -l libreadonly-xs-perl Result: ii libreadonly-xs-perl 1.04-2+b3 amd64 Faster Readonly implementation Staff client About Koha without patch Readonly::XS (1.02) 1.04 Staff client About Koha with patch Readonly::XS (1.02) 1.04 The result is now the same with and without patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14063] Implement language overlay for authorised values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14063 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added CC||mi...@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11448] Accessibility: Make it possible to enter date for restriction without using the datepicker widget
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11448 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Christopher Brannon from comment #4) I suggestion a global solution on bug 14060. Actually I should have submitted it here. *** This bug has been marked as a duplicate of bug 14060 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14060] Remove readonly on date inputs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- *** Bug 11448 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to M. Tompsett from comment #15) Comment on attachment 37848 [details] [review] [Signed-off] Bug 10625: Inventory/Stocktaking tool cannot handle windows file uploads Review of attachment 37848 [details] [review]: - ::: tools/inventory.pl @@ +174,5 @@ +$barcode =~ s/\r/\n/g; +$barcode =~ s/\n\n/\n/g; +$barcode =~ s/\n$//; +$barcode =~ s/^\n//; +my @data = split(/\n/,$barcode); Because then I couldn't split the barcodes. I agree the logic might be more optimizable, but the idea is that if $barcode = foo\nbar; it needs to split into two barcodes: foo and bar. And given that some OS's may use \r and \n and \r\n in ways different than how $barcode=$uploadbarcodes works, I wanted to be certain that all middle combinations get split, and that there are no beginning or end strangeness. Ok sorry, did not read it with the context. So the last 2 replacements are useless :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #8 from M. Tompsett mtomp...@hotmail.com --- Still looking for a nicer way. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Nick Clemens from comment #5) Note that this patch is not perfect, it fixes the 2 bad behaviors but the ctrl+click gives the focus to the new tab (could go against the preferences of the users). This is a huge improvement so signing off, would it seem ungrateful to file the above as a new bug? Not at all, feel free to do it :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14060] Remove readonly on date inputs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38541 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38541action=edit Bug 14060: Display the date format on the warning popup The date format is now displayed on the warning popup. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #38531|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11559] Professional cataloger's interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #86 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Karam Qubsi from comment #78) Hi Jessie, I tried to apply the patch on master , but it wasn't applied , I have the following error : Auto-merging svc/bib CONFLICT (content): Merge conflict in svc/bib Failed to merge in the changes. Patch failed at 0001 Bug 11559 - Supporting changes for Rancor is there any order that I have to follow to apply the patches ? thank you for your great efforts . Karam, I have fixed the conflict in the first patch, you should be able to apply all of them in the same order as they are on this bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11559] Professional cataloger's interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #85 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38539 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38539action=edit Bug 11559 followup - a number of small UI bugfixes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Dobrica Pavlinusic dpav...@rot13.org changed: What|Removed |Added CC||dpav...@rot13.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13577] The correct COLLATE is not set to all DB tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Dobrica Pavlinusic from comment #11) Dobrica, could you please detail how did you get this error? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11431] Add additional sound options for warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #72 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38548 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38548action=edit Bug 11431 [QA Followup] - Fix POD -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices slips
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added QA Contact|jonathan.dru...@biblibre.co | |m | CC||m.de.r...@rijksmuseum.nl --- Comment #47 from Jonathan Druart jonathan.dru...@biblibre.com --- I would like to get point of view from another QAer on this one and bug 11747. I don't know to be sure Kyle's patch won't introduce regression on the tools/letter.pl page. Moreover I am still concerned by the addition of 3 prefs to do the same thing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13914] The holds statistics report returns random data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914 --- Comment #4 from Eivin Giske Skaaren eskaa...@yahoo.no --- (In reply to Jonathan Druart from comment #3) (In reply to Eivin Giske Skaaren from comment #2) So one way of getting line numbers that are not unique for the same col is if priority is set to 0 for an item in the old_reserves table. Question: Should priority ever be anything else than 0 for an item in the old_reserves table? Yes, I think so. At least I have some on local installation. I suppose the priority is not updated when a reserve is canceled. So if it has a priority 0, it will be copied as it to the old_reserves. Since the query evaluates on priority this means that the result will be wrong if the rows from old_reserves are not to be shown as 1- placed in the holds report. Did you have the patience to test/compare the results? I didn't :) Yes I did test it ;) But the customer validated the patch, so I supposed he tested it. If you are able to give me a simple example to recreate a issue on my side, I will have a look and try to provide a fix. This is my test result that you can modify to your installation: I have 2 books in the reserves table with priority 1 I have 3 books in the old_reserves table with priority 0 Run the report and it will say: 1- placed: 2 2- processed : 3 Change the priority to 1 for one of the books in the old_reserves table and rerun the report: 1- placed: 3 2- processed: 2 Perhaps it would be good to refactor out the use of magic numbers so the whole thing gets more maintainable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11431] Add additional sound options for warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11431] Add additional sound options for warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #71 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38547 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38547action=edit Bug 11431 [QA Followup] - Allow https in sound URLs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Dobrica Pavlinusic dpav...@rot13.org changed: What|Removed |Added CC||dpav...@rot13.org --- Comment #34 from Dobrica Pavlinusic dpav...@rot13.org --- I have problem with this patch. When applied to our database it generates following errors: [Mon Apr 27 12:33:40 2015] updatedatabase.pl: DBD::mysql::db do failed: Multiple primary key defined at /srv/koha/installer/data/mysql/updatedatabase.pl line 10166. [Mon Apr 27 12:33:40 2015] updatedatabase.pl: DBD::mysql::db do failed: Unknown column 'issue_id' in 'order clause' at /srv/koha/installer/data/mysql/updatedatabase.pl line 10170. [Mon Apr 27 12:33:40 2015] updatedatabase.pl: DBD::mysql::st execute failed: Unknown column 'me.issue_id' in 'field list' at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1481. DBIx::Class::ResultSetColumn::max(): Unknown column 'me.issue_id' in 'field list' at /srv/koha/installer/data/mysql/updatedatabase.pl line 10174 It seems that ALTER TABLE issues ADD issue_id INT( 11 ) NOT NULL AUTO_INCREMENT PRIMARY KEY FIRST doesn't work because we already have itemnumber defined as primary key. Should we drop it before this alter table? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Nicolas Legrand nicolas.legr...@bulac.fr changed: What|Removed |Added CC||nicolas.legr...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14066] New: Koha code does not really use Readonly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 Bug ID: 14066 Summary: Koha code does not really use Readonly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@biblibre.com Reporter: jonathan.dru...@biblibre.com QA Contact: testo...@bugs.koha-community.org The Readonly and Readonly::XS package are only used in Koha::Calendar. IMO the added value of there packages does not justify their purpose. I would suggest to remove these packages as Koha deps. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14065] Typo in opac self registration form
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14065 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Severity|enhancement |trivial Patch complexity|--- |String patch Assignee|oleon...@myacpl.org |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14065] New: Typo in opac self registration form
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14065 Bug ID: 14065 Summary: Typo in opac self registration form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The phrase Please type this following characters into the preceding box should be Please type the following characters into the preceding box -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14066] Koha code does not really use Readonly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||colin.campbell@ptfs-europe. ||com --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Colin, do you have any concerns about this patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14066] Koha code does not really use Readonly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38546 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38546action=edit Bug 14066: Remove the Readonly[::XS] dependency The Readonly and Readonly::XS package are only used in Koha::Calendar. IMO the added value of there packages does not justify their purpose. Test plan: 1/ Remove Readonly and Readonly::XS 2/ Open the calendar and confirm you don't get any error concerning missing dependency -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14066] Koha code does not really use Readonly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14065] Typo in opac self registration form
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14065 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38545 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38545action=edit Bug 14065 - Typo in opac self registration form The phrase Please type this following characters into the preceding box should be Please type the following characters into the preceding box -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14065] Typo in opac self registration form
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14065 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 --- Comment #35 from Tomás Cohen Arazi tomasco...@gmail.com --- (In reply to Dobrica Pavlinusic from comment #34) doesn't work because we already have itemnumber defined as primary key. Should we drop it before this alter table? Dobrica, you mean you altered the original DB definition? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |In Discussion CC||jonathan.dru...@biblibre.co ||m --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- When QAing this patch, I was wondering why we used Readonly and Readonly::XS. And actually I did not find valid reasons. I have opened bug 14066 to remove these packages. If valided, it will invalid this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12411] Encoding broken in the syspref template plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12052 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12052] Display a patron message on the summary page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12052 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12411 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13914] The holds statistics report returns random data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914 --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Eivin Giske Skaaren from comment #4) Perhaps it would be good to refactor out the use of magic numbers so the whole thing gets more maintainable. Actually I think that all the script should be rewritten. It looks much more complicated than I expected and at the moment I don't plan to work more on this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #36364|0 |1 is obsolete|| --- Comment #211 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38551 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38551action=edit Bug 10855: interface configuration for adding new fields to subscriptions This patch adds an interface configuration for adding fields to subscriptions. Test plan: - go to serials/serials-home.pl - click on the Add subscription fields link on the left of the screen - try to add/update/delete new fields You are not abble to add a field with an authorised value category and a marcfield. Columns are sortable - for the rest, you should have, at least: * a new field named af1, sortable, linked to a category * a new field named af2, sortable, linked to a marcfield * a new field named af3, not sortable Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #36366|0 |1 is obsolete|| --- Comment #213 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38553 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38553action=edit Bug 10855: Search subscriptions by additional fields Now you will abble to search subscriptions by additional fields. The additional field values will be displayed in the table results. Test plan: - go on the subscriptions advanced search page (serials/serials-search.pl). - verify all searchable additional fields are displayed on the form. - combine 1 or more values and verify results are consistent. - verify the values are displayed in new columns of the table. - for field linked to an authorised value category, the description is displayed (not the code). Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #36367|0 |1 is obsolete|| --- Comment #214 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38554 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38554action=edit Bug 10855: Search subscriptions by additional fields on the claim page Test plan: - create some serials in late. - go on serials/claims.pl. - choose a vendor. - verify that additional fields are displayed in new columns. - try filters on columns. - verify there is no regression on this page. Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #36368|0 |1 is obsolete|| --- Comment #215 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38555 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38555action=edit Bug 10855: Squash several fixes Bug 10855: FIX: Add additional fields for closed subscriptions Bug 10855: Fix instance vs static method This patch fixes the error message. The 3 modified routines *are* static methods. Bug 10855: FIX conflicts with bug 7688 Bug 10855: Fix typo addition_fields - additional_fields Bug 10855: A partial search should return the subscriptions If a search on an additional fields is done using a partial string (foo and the defined value is foobar), the subscription should appear in the result list. Test plan: Try to search a part of the string for an additional field. Bug 10855: Filtering on additional fields don't work if value is equal to 0 If you tried to filter on an additional field linked to an authorised value, that did not work if the value was 0. Bug 10855: Remove the advanced serial search box on the serial home page Bug 10855: FIX an add field should not be created if the marc field does not exist. This patch fixes the following: Create an add fields linked to a nonexistent marc field (does not exist in serials). Edit a subscription and save. Without this patch, an error occured: Software error: DBD::mysql::db do failed: Column 'value' cannot be null at /var/root-koha/bug-10855/Koha/AdditionalField.pm line 107. Bug 10855: Fix Type table vs tablename Koha::AdditionalField-all method take tablename not table in parameter. Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #36363|0 |1 is obsolete|| --- Comment #210 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38550 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38550action=edit Bug 10855: Add unit tests for the new package Koha::AdditionalField Test plan: - prove t/db_dependent/AdditionalField.t Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10327] Rename poorly named system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Depends on||12160 CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12160] Rename intranetuserjs to IntranetUserJS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||10327 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #36369|0 |1 is obsolete|| --- Comment #216 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38556 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38556action=edit Bug 10855: Fix QA issues This patch fixes the following QA issues: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt FAIL forbidden patterns forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt FAIL forbidden patterns forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt FAIL forbidden patterns forbidden pattern: To include datatables files, please use the include file (see bug 10868) (line 12) Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11340] make the 'print summary' a custom slip/notice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340 Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style (see also 10480)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Patch complexity|--- |Small patch Assignee|gmcha...@gmail.com |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style (see also 10480)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #38543|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38562 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38562action=edit Bug 13810: Change collate for tagsubfield (utf8_bin) Before bug 11944, the marc_subfield_structure.tagsubfield column had a specific collate: utf8_bin. It has been introduced by commit 67e20d82ffdfcd69344ec30696bebc51c00d863c Date: Sun Jun 22 16:35:48 2008 -0500 DB Bump 094 - bug 2268 -- allow mixed case subfield labels in MARC21 by changing db column collation. This change should be kept and Koha should continue to allow and create subfields with the same letter but different case sensitivity. What does this patch: 1/ To prevent the updatedatabase entry 3.19.00.006 to fail if subfields with different case sensitivity already exist in the DB, the table is managed separately from others. 2/ To update DB which have already pass this dbrev, a new entry will be create to update the specific collate for this column. Test plan: 1/ a. With a 3.18 DB, create subfield 'a' and 'A' for the same field b. Execute the updatedatabase.pl script. 3.19.00.006 should not fail anymore 2/ a. With a master DB (3.19.00.006 has already been executed), create subfields 'a' and 'A'. You should get an error. b. Apply this patch, execute the DB entry and try again 2/a. you should be able to create the second subfield. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12135] Pending suggestions table width is wrong
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38567 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38567action=edit Bug 12135: Fix suggestions table width The trick to update the suggestions table width is outdated since jQuery UI has been updated. Test plan: 0/ Don't apply this patch 1/ Go on the suggestions page (suggestion/suggestion.pl), change tabs: the table width is wrong 2/ Apply this patch 4/ Repeat 1 and confirm the width is now updated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14066] Koha code does not really use Readonly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066
--- Comment #3 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 38546
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38546
Bug 14066: Remove the Readonly[::XS] dependency
Review of attachment 38546:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=14066attachment=38546)
-
::: C4/Installer/PerlDependencies.pm
@@ -240,5 @@
-'Readonly' = {
-'usage'= 'Core',
-'required' = '1',
-'min_ver' = '1.03'
-},
I think we should keep Readonly. It is one of the better ways of defining
constants, and would allow us to improve our perlcritic levels in the future.
Currently, we only require perlcritic -5.
@@ -245,5 @@
-'Readonly::XS' = {
-'usage'= 'Core',
-'required' = '0',
-'min_ver' = '1.02'
-},
However, from the Readonly page on CPAN:
I repeat, you do not need Readonly::XS if your environment has perl 5.8.x or
higher.
Perhaps just removing Readonly::XS is the better solution. :)
::: Koha/Calendar.pm
@@ +126,4 @@
if ( $unit eq 'hours' ) {
# Fixed for legacy support. Should be set as a branch parameter
+my $return_by_hour = 10;
Readonly's definition of a scalar value is confusing, such that when you
changed it to a simple variable to accidentally left what looks like hashiness
(=), even though it probably should be plainly scalar (=).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #36362|0 |1 is obsolete|| --- Comment #209 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38549 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38549action=edit Bug 10855: Add the new package Koha::AdditionalField Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #36365|0 |1 is obsolete|| --- Comment #212 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38552 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38552action=edit Bug 10855: New fields on adding/updating a subscription This patch adds the ability to add values for additional fields when adding/updating a subscription. Test plan (test the following on adding a new subscription and on editing an existent one): - add/edit a subscription. - verify all additional fields appears into the Additional fields block. - fill a value for af1 and af3. - fill others values if you are adding a new subscription. - save. - verify values appears on the detail of the subscription page. - verify the af2 field is automatically filled with the specified marc field of the notice. Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12160] Rename intranetuserjs to IntranetUserJS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Patch complexity|--- |Trivial patch Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12160] Rename [intranet|opac]userjs to [Intranet|OPAC]UserJS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Summary|Rename intranetuserjs to|Rename |IntranetUserJS |[intranet|opac]userjs to ||[Intranet|OPAC]UserJS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12160] Rename [intranet|opac]userjs to [Intranet|Opac]UserJS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Summary|Rename |Rename |[intranet|opac]userjs to|[intranet|opac]userjs to |[Intranet|OPAC]UserJS |[Intranet|Opac]UserJS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12160] Rename [intranet|opac]userjs to [Intranet|OPAC]UserJS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #38565|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38566 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38566action=edit Bug 12160: Rename opacuserjs with OPACUserJS Test plan: Same as previous patch for opacuserjs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #36374|0 |1 is obsolete|| --- Comment #221 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 38561 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38561action=edit Bug 10855: Update database entry Add 2 tables: additional_fields and additional_field_values Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12160] Rename intranetuserjs to IntranetUserJS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
