[Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl)

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #2 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
On top of 13705.

1) No license
2) koha-qa complais

 FAIL   misc/migration_tools/dedup_authorities.pl
   FAIL   pod
*** ERROR: Apparent command =cut not preceded by blank line  in
file misc/migration_tools/dedup_authorities.pl
*** WARNING: =head2 without preceding higher level  in file
misc/migration_tools/dedup_authorities.pl
   OK forbidden patterns
   FAIL   critic
Variable declared in conditional statement at line 429, column
5. Declare variables outside of the condition.
Variable declared in conditional statement at line 435, column
5. Declare variables outside of the condition.
   FAIL   valid
my variable $string masks earlier declaration in same scope 
given is experimental 
when is experimental

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14117] Silence warnings t/Search_PazPar2.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14119] Missing de-DE DISCHARGE message

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #3 from M. Tompsett mtomp...@hotmail.com ---
This works, but I rather a German counter patch. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14120] Silence warnings t/db_dependent/Auth.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14120

--- Comment #2 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38762
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38762action=edit
Bug 14120: Fixing t/db_dependent/Auth.t noise

TEST PLAN
-
1) $ prove t/db_dependent/Auth.t
   -- warnings
2) Apply this patch
3) $ prove t/db_dependent/Auth.t
   -- only one specific type of warning
4) Apply bug 5010 patch
5) $ prove t/db_dependent/Auth.t
   -- noisy is eliminated
6) koha qa test tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14120] Silence warnings t/db_dependent/Auth.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14120

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14116] Silence noise t/Scrubber.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116

--- Comment #1 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38757
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38757action=edit
Bug 14116: Silence noisy output for t/Scrubber.

Some diag's are better suited as prints.

TEST PLAN
-
1) $ prove t/Scrubber.t
   -- there's some noise.
2) apply patch
3) $ prove t/Scrubber.t
   -- noise issue resolved.
  Output is still reasonable for -v.
4) koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12919] Automate collecting all records added and deleted from the catalogue

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12919

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #5 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
It works.

Just a couple of things:

1) If you have no new or deleted records, an email is sent anyway
with an empty Koha.mrc file

2) License needs to be updated

FAIL   misc/cronjobs/newly_deleted_records.pl
   OK critic
   FAIL   forbidden patterns
forbidden pattern: Koha is now under the GPLv3 license (line 9)
   OK pod
   OK valid

 FAIL   misc/cronjobs/newly_added_records.pl
   OK critic
   FAIL   forbidden patterns
forbidden pattern: Koha is now under the GPLv3 license (line 9)
   OK pod
   OK valid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14117] Silence warnings t/Search_PazPar2.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117

--- Comment #1 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38758
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38758action=edit
Bug 14117: Silence warnings t/SearchPazPar2.t

The use of relative URLS (null actually), triggers warnings.
Catch them, instead of letting them loose.

TEST PLAN
-
1) $ prove t/Search_PazPar2.t
   -- noise for each test currently.
2) apply patch
3) $ prove t/Search_PazPar2.t
   -- No noise, and extra tests added.
  -v shows caught warning tests.
4) koha qa test tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14119] Missing de-DE DISCHARGE message

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119

--- Comment #1 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 38760
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38760action=edit
Bug 14119: Missing de-DE DISCHARGE message

This patch adds DISCHARGE sample message to de-DE sample_notices.pl

To test:
1) prove xt/sample_notices.t, it fails
2) apply the patch
3) prove again, this time no errors

As original Bug 8007 sample message this is not translated,
so a German counter patch is welcome.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14117] New: Silence warnings t/Search_PazPar2.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117

Bug ID: 14117
   Summary: Silence warnings t/Search_PazPar2.t
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: mtomp...@hotmail.com
QA Contact: gmcha...@gmail.com

Relative URLs trigger warnings. Test for them, instead of letting them loose on
the screen.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14117] Silence warnings t/Search_PazPar2.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|mtomp...@hotmail.com
 Blocks||8879
 Status|NEW |ASSIGNED
   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||bgkrie...@gmail.com

--- Comment #4 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
We still add things on C4?
Just a question

1) License need to be updated to GPL v3
2) koha-qa complains

 FAIL   C4/ZebraIndex.pm
   OK pod
   OK forbidden patterns
   OK critic
   FAIL   valid
my variable $string masks earlier declaration in same scope

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus)

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Depends on||14117

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121

--- Comment #1 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38763
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38763action=edit
Bug 14121: Silence warnings t/db_dependent/Auth_with_cas.t

TEST PLAN
-
1) $ prove t/db_dependent/Auth_with_cas.t
   -- CGI security warning
2) apply patch
3) $ prove t/db_dependent/Auth_with_cas.t
   -- no noise.
4) koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14116] Silence noise t/Scrubber.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus)

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Depends on||14116

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14119] Missing de-DE DISCHARGE message

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |bgkrie...@gmail.com
   |ity.org |
   Patch complexity|--- |Trivial patch

--- Comment #2 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
If a German patch is provided, please reset assignee :)
I will sign.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14119] Missing de-DE DISCHARGE message

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14119] Missing de-DE DISCHARGE message

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #38760|0   |1
is obsolete||

--- Comment #4 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38761
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38761action=edit
Bug 14119: Missing de-DE DISCHARGE message

This patch adds DISCHARGE sample message to de-DE sample_notices.pl

To test:
1) prove xt/sample_notices.t, it fails
2) apply the patch
3) prove again, this time no errors

As original Bug 8007 sample message this is not translated,
so a German counter patch is welcome.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

As noted, a German counter patch is preferred. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14121] New: Silence warnings t/db_dependent/Auth_with_cas.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121

Bug ID: 14121
   Summary: Silence warnings t/db_dependent/Auth_with_cas.t
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: mtomp...@hotmail.com
QA Contact: gmcha...@gmail.com

C4::Auth_with_case has a $query-param($_) in a context which is not clearly
scalar to the interpreter, so it throws a security warning.

Introduce a variable, use the variable instead of calling param() twice. Noise
disappears.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|mtomp...@hotmail.com
 Blocks||8879
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus)

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Depends on||14121

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14116] Silence noise t/Scrubber.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|mtomp...@hotmail.com
 Blocks||8879
   Severity|enhancement |minor
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14116] New: Silence noise t/Scrubber.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14116

Bug ID: 14116
   Summary: Silence noise t/Scrubber.t
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: mtomp...@hotmail.com
QA Contact: gmcha...@gmail.com

Some diag's are better suited as prints.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14118] New: Silence warnings t/DataTables/Members.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118

Bug ID: 14118
   Summary: Silence warnings t/DataTables/Members.t
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: mtomp...@hotmail.com
QA Contact: gmcha...@gmail.com

A couple uninitialized variable warnings when a prove -r t is issued.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus)

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Depends on||14118

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14118] Silence warnings t/DataTables/Members.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Blocks||8879
   Assignee|ch...@bigballofwax.co.nz|mtomp...@hotmail.com
 Status|NEW |ASSIGNED

--- Comment #1 from M. Tompsett mtomp...@hotmail.com ---
I know that bug 8879 is just prove ./t, but I think it is reasonable to
extend that omnibus to include prove -r ./t.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14119] New: Missing de-DE DISCHARGE message

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119

Bug ID: 14119
   Summary: Missing de-DE DISCHARGE message
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bgkrie...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Bug 8007 DB changes forgot de-DE DISCHARGE message,
prove xt/sample_notices.t fails

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14118] Silence warnings t/DataTables/Members.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14118] Silence warnings t/DataTables/Members.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118

--- Comment #2 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38759
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38759action=edit
Bug 14118: Silence warnings t/DataTables/Members.t

After cleaning 'prove t' up. 'prove -r t' was attempted next.
A couple uninitialized variable warning were triggered.

TEST PLAN
--
1) prove t/DataTables/Members.t
   -- warnings.
2) apply patch
3) prove t/DataTables/Members.t
   -- no warnings.
4) koha qa test tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14120] Silence warnings t/db_dependent/Auth.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14120

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|mtomp...@hotmail.com
   Severity|enhancement |minor
 Blocks||8879
 Depends on||5010
 Status|NEW |ASSIGNED

--- Comment #1 from M. Tompsett mtomp...@hotmail.com ---
In order to fully remove all the warnings, bug 5010 needs to be applied. Fixing
the updatedatabase.pl for the application is easy enough.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus)

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Depends on||14120

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14120] New: Silence warnings t/db_dependent/Auth.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14120

Bug ID: 14120
   Summary: Silence warnings t/db_dependent/Auth.t
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: mtomp...@hotmail.com
QA Contact: gmcha...@gmail.com

prove t/db_dependent/Auth.t is noisy. Reduce the noise.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Blocks||14120

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107

--- Comment #1 from Marc Véron ve...@veron.ch ---
Created attachment 38764
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38764action=edit
Bug 14107 - Patron cards: Make barcode width and height scaling editable

The size of the barcode in patron card creator was hardcoded to 1% of the card
height and 80% of the card width.
This patch exposes both values in the layout editor. If no values are given,
the previousely hard coded values (0.01 / 0.8) are used in order to work with
existing card definitions.

To test:
- Go to Home  Tools  Patron card creator
- Export a patron card (PDF) from en existing definition
- Apply patch
- Export patron card again, compare results (should be the same)
- Go to Home  Tools  Patron card creator  Manage card layouts
- Edit the layout you use for testing and set barcode scaling values e.g. to
0.03 for height and 0.4 for widht
- Export patron card again, verify that barcode size changed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   Assignee|cnighswon...@foundations.ed |ve...@veron.ch
   |u   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14100] Generic solution for language overlay

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 CC||mag...@enger.priv.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5685] Validation of email address field

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12461] Add patron clubs feature

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12461] Add patron clubs feature

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #36192|0   |1
is obsolete||

--- Comment #11 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 38748
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38748action=edit
Bug 12461 - Add patron clubs feature

This features would add the ability to create clubs which patrons may be
enrolled in. It would be particularly useful for tracking summer reading
programs, book clubs and other such clubs.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Ensure your staff user has the new 'Patron clubs' permissions
4) Under the tools menu, click the Patron clubs link
5) Create a new club template
   * Here you can add fields that can be filled out at the time
 a new club is created based on the template, or a new enrollment
 is created for a given club based on the template.
6) Create a new club based on that template
7) Attempt to enroll a patron in that club
8) Create a club with email required set
9) Attempt to enroll a patron without an email address in that club
10) Create a club that is enrollable from the OPAC
11) Attempt to enroll a patron in that club
12) Attempt to cancel a club enrollment from the OPAC
13) Attempt to cancel a club enrollment from the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly.

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #3 from M. Tompsett mtomp...@hotmail.com ---
Is it possible to add a reserve/hold with a particular expiration date, but
then before that expiration date, change a system preference to indicate that
it should already be expired? If so, this patch is insufficient. If not, then
it should be fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12160] Rename [intranet|opac]userjs to [Intranet|OPAC]UserJS

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #5 from M. Tompsett mtomp...@hotmail.com ---
Here's my checking. Looks good.

mtompset@debian:~/kohaclone$ grep -i intranetuserjs `git grep -l -i
intranetuserjs | grep -v \.po`
C4/Auth.pm:intranetuserjs  
  = C4::Context-preference(intranetuserjs),
C4/Auth.pm:intranetuserjs=
C4::Context-preference(intranetuserjs),
installer/data/mysql/sysprefs.sql:('intranetuserjs','','70|10','Custom
javascript for inclusion in Intranet','Textarea'),
installer/data/mysql/updatedatabase.pl:$dbh-do(UPDATE `systempreferences`
SET options='70|10' WHERE variable='intranetuserjs');
installer/data/mysql/updatedatabase.pl:my $intranetuserjs =
C4::Context-preference('intranetuserjs');
installer/data/mysql/updatedatabase.pl:if ($intranetuserjs  and 
$intranetuserjs eq $bad_value) {
installer/data/mysql/updatedatabase.pl:WHERE variable = 'intranetuserjs'
installer/data/mysql/updatedatabase.pl:print Upgrade to $DBversion done
(removed bogus intranetuserjs syspref)\n;
koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc:[% IF (
intranetuserjs ) %]
koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc:[%
intranetuserjs %]
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref:   
- pref: intranetuserjs
koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt:[% IF (
intranetuserjs ) %]
koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt:[%
intranetuserjs %]
[SNIP]
mtompset@debian:~/kohaclone$ grep -i opacuserjs `git grep -l -i opacuserjs |
grep -v \.po`
C4/Auth.pm:opacuserjs=
C4::Context-preference(opacuserjs),
C4/Auth.pm:opacuserjs=
C4::Context-preference(opacuserjs),
installer/data/mysql/sysprefs.sql:('opacuserjs','','70|10','Define custom
javascript for inclusion in OPAC','Textarea'),
installer/data/mysql/updatedatabase.pl:$dbh-do(UPDATE `systempreferences`
SET options='70|10' WHERE variable='opacuserjs');
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref:   
- pref: opacuserjs
koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc:[% IF ( opacuserjs )
%]
koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc:[% opacuserjs
%]
[SNIP]
mtompset@debian:~/kohaclone$ git bz apply 12160
Bug 12160 - Rename [intranet|opac]userjs to [Intranet|OPAC]UserJS

38563 - Bug 12160: Rename intranetuserjs with IntranetUserJS
38566 - Bug 12160: Rename opacuserjs with OPACUserJS

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 12160: Rename intranetuserjs with IntranetUserJS
Applying: Bug 12160: Rename opacuserjs with OPACUserJS
mtompset@debian:~/kohaclone$ grep -i intranetuserjs `git grep -l -i
intranetuserjs | grep -v \.po`
C4/Auth.pm:IntranetUserJS  
  = C4::Context-preference(IntranetUserJS),
C4/Auth.pm:IntranetUserJS=
C4::Context-preference(IntranetUserJS),
installer/data/mysql/atomicupdate/Bug_12160-Rename_pref_intranetuserjs_to_IntranetUserJS.sql:UPDATE
systempreferences SET variable=IntranetUserJS where variable=intranetuserjs
installer/data/mysql/sysprefs.sql:('IntranetUserJS','','70|10','Custom
javascript for inclusion in Intranet','Textarea'),
installer/data/mysql/updatedatabase.pl:$dbh-do(UPDATE `systempreferences`
SET options='70|10' WHERE variable='intranetuserjs');
installer/data/mysql/updatedatabase.pl:my $intranetuserjs =
C4::Context-preference('intranetuserjs');
installer/data/mysql/updatedatabase.pl:if ($intranetuserjs  and 
$intranetuserjs eq $bad_value) {
installer/data/mysql/updatedatabase.pl:WHERE variable = 'intranetuserjs'
installer/data/mysql/updatedatabase.pl:print Upgrade to $DBversion done
(removed bogus intranetuserjs syspref)\n;
koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc:[% IF (
IntranetUserJS ) %]
koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc:[%
IntranetUserJS %]
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref:   
- pref: IntranetUserJS
koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt:[% IF (
IntranetUserJS ) %]
koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt:[%
IntranetUserJS %]
[SNIP]
mtompset@debian:~/kohaclone$ grep -i opacuserjs `git grep -l -i opacuserjs |
grep -v \.po`
C4/Auth.pm:OPACUserJS=
C4::Context-preference(OPACUserJS),
C4/Auth.pm:OPACUserJS=
C4::Context-preference(OPACUserJS),

[Koha-bugs] [Bug 12160] Rename [intranet|opac]userjs to [Intranet|OPAC]UserJS

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12160] Rename [intranet|opac]userjs to [Intranet|OPAC]UserJS

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #38563|0   |1
is obsolete||

--- Comment #6 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38742
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38742action=edit
Bug 12160: Rename intranetuserjs with IntranetUserJS

To match IntranetUserCSS, intranetuserjs should be renamed
IntranetUserJS.

Test plan:
1/ Be sure there is no occurrence of intranetuserjs
2/ Confirm the pref still works as before

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

NOTE: Worked before and after updatedatabase.pl, though after
  is less confusing to the person unaware of case insensitivity.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12160] Rename [intranet|opac]userjs to [Intranet|OPAC]UserJS

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #38566|0   |1
is obsolete||

--- Comment #7 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38743
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38743action=edit
Bug 12160: Rename opacuserjs with OPACUserJS

Test plan:
Same as previous patch for opacuserjs

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

NOTE: Worked before and after updatedatabase.pl, though after
  is less confusing to the programmer unaware of case-insensitivity.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5685] Validation of email address field

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
  Attachment #38711|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14107] New: Patron cards: Make barcode width and height scaling editable

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107

Bug ID: 14107
   Summary: Patron cards: Make barcode width and height scaling
editable
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Label/patron card printing
  Assignee: cnighswon...@foundations.edu
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14108] New: manual chapter 3.1.6 on patron card creator - revision

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14108

Bug ID: 14108
   Summary: manual chapter 3.1.6 on patron card creator - revision
 Change sponsored?: ---
   Product: Koha
   Version: 3.18
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Documentation
  Assignee: neng...@gmail.com
  Reporter: heinrich.ha...@email.de
QA Contact: testo...@bugs.koha-community.org

Created attachment 38749
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38749action=edit
Revised manual chapter (3.) 1.6 Patron Card Creator

The manual description for patron card creator as of 3.18 was incomplete and
not consistent with the current program. 

Please find attached the revised chapter. Any comments for further improvement
are welcome. Providing it in .odt format is in agreement with nengard. The tool
oxygen is not available for me. Also she could not suggest any other tool that
allows .xml editing + inspecting e.g. a .html transform thereof. 

The initial document content was copied from chapter (3.) 1.6 in
http://manual.koha-community.org/3.18/en/index.html and pasted in a virgin .odt
document. All the text changes are recorded. I ended with changing quite a lot,
so looking at the document with viewing changes enabled is a little bit
confusing but fortunately viewing changes can be disabled at least in my
LibrOffice writer. To present the information in the order given by the left
side menu I moved the chapter on layout to (3.) 1.6.1. Screen snapshots were
taken with irfanview.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5685] Validation of email address field

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #38708|0   |1
is obsolete||
  Attachment #38709|0   |1
is obsolete||
  Attachment #38710|0   |1
is obsolete||
  Attachment #38715|0   |1
is obsolete||

--- Comment #28 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 38744
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38744action=edit
[PASSED QA] Bug 5685: Validation of email address field

This patch adds server-side  client-side validation for email
form fields in the members/memberentry -view and in the
opac/memberentry-view (bootstrap).

I recently added simple validation for phone number and email address fields
for our in-house koha and saw this old bug: I'm open to any ideas on how
to do this better. Validation for phone numbers would be easy to add on
top of this but I left it out since this bug is only about the email
fields.

To test:
1) Select a member and go to any of the edit forms with email fields
(Primary info, Library use, Alternate address, Alternative
contact).
2) Disable javascript in the browser in order to test server-side
validation and try to input invalid emails in each of the email form
fields.
3) Confirm that an invalid address is catched from any of the email
fields, an alert shown for each invalid address and that the member's
information was not updated with invalid data.
4) Enable javascript in the browser.
5) Confirm that the jquery validation plugin caches invalid addresses
from any of the email fields and that you cannot send the form before
correcting the problem.
6) Perform the same tests for the opac-memberentry-view.

Note: as the jQuery validation plugin doesn't exist in the bootstrap
folder, I just copied it over from the staff-client folder -how to deal
with this?

Signed-off-by: Owen Leonard oleon...@myacpl.org

I have undone the changes to opac.css so that they can be submitted as a
separate patch. I have some other follow-ups to make as well.

Signed-off-by: Nicole Engard neng...@bywatersolutions.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5685] Validation of email address field

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685

--- Comment #30 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 38746
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38746action=edit
[PASSED QA] Bug 5685 [OPAC follow-up] Validation of email address field

This patch makes a few changes to the way errors are handled in the
OPAC:

- The validation plugin has been moved from the global include file to
  the template itself. Since we aren't doing form validation on any
  other page yet it doesn't make sense to include it globally at this
  time.

- The error message which appears if you have JavaScript disabled and
  have submitted invalid emails was styled in a non-standard way.

- I have added in-page links to the error message which appears if you
  have JavaScript disabled so that you can click to jump to the field
  which contains the error.

- I have modified the error message language slightly to make it (I
  hope) read better.

Signed-off-by: Nicole Engard neng...@bywatersolutions.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5685] Validation of email address field

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685

--- Comment #31 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 38747
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38747action=edit
[PASSED QA] Bug 5685: Add missing about information

In comment #20, Katrin requested the about page be updated
to reflect the addition of a jquery plugin.

TEST PLAN
-
1) Apply all patches
2) Log in to Staff Client
3) Home - About Koha - Licenses
   -- jQuery Validation Plugin is now listed nicely.
4) Run koha qa test tools

License appears as expected, qa OK
Signed-off-by: Marc Véron ve...@veron.ch

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5685] Validation of email address field

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685

--- Comment #29 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 38745
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38745action=edit
[PASSED QA] Bug 5685 [Compiled CSS] Validation of email address field

This patch contains the recompiled opac.css file based on changes made
to opac.less in the previous patch.

Signed-off-by: Nicole Engard neng...@bywatersolutions.com

FIXED the compress. - mtompset

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11941] Patron lists are not easily accessible

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11941

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12461] Add patron clubs feature

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

 CC||n...@quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5704] bib level item type icon should display on search results

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5704

kh...@roseville.ca.us changed:

   What|Removed |Added

 CC||kh...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11941] Patron lists are not easily accessible

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11941

--- Comment #3 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 38598
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38598
Bug 11941: Add link to patron lists from the patron home page

Review of attachment 38598:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=11941attachment=38598)
-

::: koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc
@@ +6,5 @@
  [% FOREACH category IN categories %]lia 
 href=/cgi-bin/koha/members/memberentry.pl?op=addamp;categorycode=[% 
 category.categorycode %][% category.description %]/a/li[% END %]
  /ul
  /div
 +[% IF CAN_user_tools_manage_patron_lists %]
 +button class=btn btn-small 
 href=/cgi-bin/koha/patron_lists/lists.pli class=icon-edit/iPatron 
 lists/button

This isn't inside a form, as far as I can tell. Please change 'button' to 'a'.
I couldn't get it to meaningfully click with 'button'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14109] ability to do multiple custom field searches on item search

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14109

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

 CC||n...@quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14109] New: ability to do multiple custom field searches on item search

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14109

Bug ID: 14109
   Summary: ability to do multiple custom field searches on item
search
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 38750
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38750action=edit
custom field search on item search

It would be nice if there was a way to add more than one field search on the
item search (a plus sign like on advanced search?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14113] New: Silence warnings t/Date.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14113

Bug ID: 14113
   Summary: Silence warnings t/Date.t
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: mtomp...@hotmail.com
QA Contact: gmcha...@gmail.com

And clean up the vertical spacing too on the output which is forced on the
user.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus)

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Depends on||14113

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14113] Silence warnings t/Date.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14113

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Blocks||8879

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14113] Silence warnings t/Date.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14113

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

   Severity|enhancement |minor
   Assignee|ch...@bigballofwax.co.nz|mtomp...@hotmail.com
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14113] Silence warnings t/Date.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14113

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12461] Add patron clubs feature

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus)

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Depends on||14112

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14112] Silence warnings t/Charset.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14112] Silence warnings t/Charset.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Blocks||8879
   Assignee|ch...@bigballofwax.co.nz|mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14112] New: Silence warnings t/Charset.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112

Bug ID: 14112
   Summary: Silence warnings t/Charset.t
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: mtomp...@hotmail.com
QA Contact: gmcha...@gmail.com

Self-explanitory.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14112] Silence warnings t/Charset.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112

--- Comment #1 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38753
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38753action=edit
Bug 14112: Silence warnings in t/Charset.t

Running prove on t/Charset.t had a complaint about a better way
to write \c3. This suppresses it.

TEST PLAN
-
1) $ prove t/Charset.t
   -- get a warning
2) apply patch
3) $ prove t/Charset.t
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14113] Silence warnings t/Date.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14113

--- Comment #1 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38754
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38754action=edit
Bug 14113: Silence t/Dates.t warnings and cleanup output.

The expectation of a user not freaking out over 'Illegal date'
messages is not sensible. Catch the messages, give a nicer
message.

Also, compress the veritical spacing on the output.

TEST PLAN
-
1) $ prove t/Dates.t
   -- notice Illegal date messages, and extra lines between
  some sectional messages.
2) Apply patch
3) $ prove t/Dates.t
   -- Notice how nice and clean it is?
  Try it with -v to see all the warnings, including the
  expected warning type messages.
4) run koha qa test tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7232] clicking title on receive should open in new window/tab

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7232

kh...@roseville.ca.us changed:

   What|Removed |Added

 CC||kh...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14110] New: Silence warnings t/00-load.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110

Bug ID: 14110
   Summary: Silence warnings t/00-load.t
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: mtomp...@hotmail.com
QA Contact: gmcha...@gmail.com

Noted: bug 8879 is an omnibus for the ./t errors.

This cleanly catches all the errors in t/00-load.t, but it does not clean up
the Koha tests which actually exclude testing Koha/NorwegianPatronDB.pm!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14110] Silence warnings t/00-load.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|mtomp...@hotmail.com
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus)

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14110

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14110] Silence warnings t/00-load.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=8879

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus)

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

   See Also|http://bugs.koha-community. |
   |org/bugzilla3/show_bug.cgi? |
   |id=14110|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111

--- Comment #1 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38752
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38752action=edit
Bug 14111: Silence warnings in t/Auth_with_shibboleth.t

Poorly capturing warnings_exist test cases generated noise.
This patch fixes that.

TEST PLAN
-
1) $ prove t/Auth_with_shibboleth.t
   -- There are messages about lines 132 and 133. Noise.
2) Apply patch
3) $ prove t/Auth_with_shibboleth.t
   -- No messages. YAY!
4) koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14110] Silence warnings t/00-load.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

   See Also|http://bugs.koha-community. |
   |org/bugzilla3/show_bug.cgi? |
   |id=8879 |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus)

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Depends on|11402   |14110

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11402] Labels::_guide_box should return undef if undefned data is passed

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11402

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Blocks|8879|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14110] Silence warnings t/00-load.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Blocks||8879

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14110] Silence warnings t/00-load.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110

--- Comment #1 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38751
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38751action=edit
Bug 14110: Silence t/00-load.t warnings

prove t/00-load.t has noisy messages. This catches them.

TEST PLAN
-
1) $ prove -v t/00-load.t
   -- ugly INIT errors, etc.
2) apply patch
3) $ prove -v t/00-load.t
   -- nice Expected warnings type messages on
  the ones that were noisy.
4) koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14110] Silence warnings t/00-load.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus)

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Depends on||14111

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Blocks||8879
   Assignee|ch...@bigballofwax.co.nz|mtomp...@hotmail.com
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14111] New: Silence warnings t/Auth_with_shibboleth.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111

Bug ID: 14111
   Summary: Silence warnings t/Auth_with_shibboleth.t
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: mtomp...@hotmail.com
QA Contact: gmcha...@gmail.com

Remove noise from prove t/Auth_with_shibboleth.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14100] Generic solution for language overlay

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100

Josef Moravec josef.mora...@gmail.com changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #31 from Chris Cormack ch...@bigballofwax.co.nz ---
This doesn't apply on 3.18.x please rebase if needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10985] Unimarc: Authority summary does not work as expected

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10985

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #11 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14114] Silence warnings t/Debug.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14114

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

   Severity|enhancement |minor
 Status|NEW |ASSIGNED
   Assignee|ch...@bigballofwax.co.nz|mtomp...@hotmail.com
 Blocks||8879

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14114] Silence warnings t/Debug.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14114

--- Comment #1 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38755
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38755action=edit
Bug 14114: Silence warns and cleanup t/Debug.t

TEST PLAN
-
1) $ prove t/Debug.t
   -- What's with this BEFORE and AFTER stuff?!
2) apply patch
3) $ prove t/Debug.t
   -- cleaner, and you only get fuller output with -v.
4) koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14114] Silence warnings t/Debug.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14114

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14114] New: Silence warnings t/Debug.t

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14114

Bug ID: 14114
   Summary: Silence warnings t/Debug.t
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: mtomp...@hotmail.com
QA Contact: gmcha...@gmail.com

Turns out there are annoying and pointless diags. Clean up. Fix layout. And
perhaps even a Modern::Perl while I'm at it. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus)

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Depends on||14114

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14115] New: Silence warnings t/Label*

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14115

Bug ID: 14115
   Summary: Silence warnings t/Label*
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: mtomp...@hotmail.com
QA Contact: gmcha...@gmail.com

Various uninitialized warnings spew out when proving. Clean up output while
maintaining test integrity.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14115] Silence warnings t/Label*

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14115

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Blocks||8879
 Status|NEW |ASSIGNED
   Assignee|ch...@bigballofwax.co.nz|mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus)

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Depends on||14115

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14115] Silence warnings t/Label*

2015-05-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14115

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >