[Koha-bugs] [Bug 14129] templates.readme is outdated

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14129

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14129] templates.readme is outdated

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14129

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 38795
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38795action=edit
Bug 14129: templates.readme is outdated

The file templates.readme dates back to CSV and
HTML::Template times and is outdated.

To test:
- Verify the file is outdated and removed by this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14126] Typo on order receive page

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14126

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #38794|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 38796
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38796action=edit
[SIGNED OFF] Bug 14126 - Typo on order receive page

A typo found while doing translation:

To test
1) Go to dir 'intranet-tmpl/prog/en/modules/acqui/neworderempty.tt'
   line 268 and check the typo To notify on reveiving:
2) Apply the patch
3) Repeat step 1 and check if the typo is fixed

Sponsored-by: Universidad de El Salvador

Signed-off-by: Hector Castro hector.hecax...@gmail.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14126] Typo on order receive page

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14126

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Patch complexity|--- |String patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14129] templates.readme is outdated

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14129

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14129] templates.readme is outdated

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14129

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I am proposing to remove the file - I think nowadays this kind of information
would be better in the wiki.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14125] Version variable not properly replaced in csv profiles help page

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14125

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14125] Version variable not properly replaced in csv profiles help page

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14125

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14125] Version variable not properly replaced in csv profiles help page

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14125

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 38797
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38797action=edit
Bug 14125: Fix template problems on csv profiles help page

Page uses TAGS Directive in order to print TT directives
in the manual without having them interpreted, but fails
to switch back/change all following TT code, causing
problems in displaying the file correctly.

See TT documentation:
http://www.template-toolkit.org/docs/manual/Directives.html#section_TAGS

As [- ... -] showed up in translations, I chose to switch back
instead of changing the TT variable and INCLUDE.

To test:
- Go to tools  csv profiles
- Open the help page
- Verify the link to the manual includes the version and works
- Verify the footer shows up correctly with the edit buttons

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14130] column.def should be updated with descriptions for new columns

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14130

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14129] templates.readme is outdated

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14129

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14129] templates.readme is outdated

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14129

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

  Attachment #38795|0   |1
is obsolete||

--- Comment #3 from Magnus Enger mag...@enger.priv.no ---
Created attachment 38798
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38798action=edit
Bug 14129: templates.readme is outdated

The file templates.readme dates back to CSV and
HTML::Template times and is outdated.

To test:
- Verify the file is outdated and removed by this patch.

Signed-off-by: Magnus Enger mag...@enger.priv.no
If noone spotted the outdatedness of this file until now I
agree with Katrin that we should get rid of it and maybe
create something similar in the wiki. The patch works as
advertised.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14099] RESERVESLIP shows incorrect information in items.holdingbranch on first scan

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14099

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Severity|normal  |major
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing.

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482

--- Comment #23 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Bug 14099 - thx Christopher!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14099] RESERVESLIP shows incorrect information in items.holdingbranch on first scan

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14099

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12348] unique barcodes should be mandatory

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12348

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED
 CC||mag...@enger.priv.no

--- Comment #2 from Magnus Enger mag...@enger.priv.no ---
I agree with Katrin. Because of itemBarcodeFallbackSearch, we cannot force
barcodes to be NOT NULL. This should be ficed in the frameworks instead.
Marking as RECOLVED WONTFIX.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023

--- Comment #27 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Why does the db rev of this report not update kohafield for existing installs?

If 952$x has not been connected to some other field, what would be the problem
in connecting it to itemnotes_nonpublic just as you do for the new install?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13691] Add some selenium scripts

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691

--- Comment #8 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
FYI: Just started working on this.
https://metacpan.org/pod/Selenium::Remote::Driver
no longer needs the stand-alone server !! YAY YAY!!!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023

--- Comment #28 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Because the data is still in more_subfields_xml or items.paidfor (depending on
the age of the installation) you will have problems accessing your data. 

I did a lot of tests when we tried to do that in the first iteration and there
always remained problems (see bug 4222).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14122] Patron card: Software error when creating using borrower_number as parameter from URL

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14122

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #4 from Marc Véron ve...@veron.ch ---
Ho, forgot to set to Needs Signoff...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14125] Version variable not properly replaced in csv profiles help page

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14125

--- Comment #2 from Marc Véron ve...@veron.ch ---
Created attachment 38799
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38799action=edit
[Signed-off] Bug 14125: Fix template problems on csv profiles help page

Page uses TAGS Directive in order to print TT directives
in the manual without having them interpreted, but fails
to switch back/change all following TT code, causing
problems in displaying the file correctly.

See TT documentation:
http://www.template-toolkit.org/docs/manual/Directives.html#section_TAGS

As [- ... -] showed up in translations, I chose to switch back
instead of changing the TT variable and INCLUDE.

To test:
- Go to tools  csv profiles
- Open the help page
- Verify the link to the manual includes the version and works
- Verify the footer shows up correctly with the edit buttons

Works as expected.
Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13691] Add some selenium scripts

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691

--- Comment #9 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Cannot proceed because generating test users with test permissions has no API
in Koha:: or C4::
Looking into the Koha REST API to create one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14125] Version variable not properly replaced in csv profiles help page

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14125

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

--- Comment #4 from Julian FIOL julian.f...@biblibre.com ---
Created attachment 38800
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38800action=edit
Bug 14097 : Delete table issues before testing

If we delete all biblio DB, we could have some troubles with foreign keys

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059

--- Comment #5 from Julian FIOL julian.f...@biblibre.com ---
Created attachment 38801
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38801action=edit
Bug 14059 : Delete all export of get_column_names

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059

Julian FIOL julian.f...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128

--- Comment #1 from Marc Véron ve...@veron.ch ---
Created attachment 38802
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38802action=edit
Bug 14128 - Capitalization: Guided Reports - step 2 - Build A Report

To verify and test:
Go to Home  Reports
Click on 'Build new'
Verify that the title in Step 1 and to display with correct capitalization

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

--- Comment #5 from Julian FIOL julian.f...@biblibre.com ---
About Comment #3

After some tests, it seems that if the script stops / exits / fails for
whatever reason after following lines, there is no $dbh-rollback, and the
changes of the DB remains...


my $dbh = C4::Context-dbh;
$dbh-{AutoCommit} = 0;
$dbh-{RaiseError} = 1;
$dbh-do('DELETE FROM biblio');
$dbh-do('DELETE FROM items');
$dbh-do('DELETE FROM auth_header');
$dbh-do('DELETE FROM old_issues');
$dbh-do('DELETE FROM old_reserves');
$dbh-do('DELETE FROM borrowers');
$dbh-do('DELETE FROM aqorders');
$dbh-do('DELETE FROM subscription');

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128

--- Comment #2 from Marc Véron ve...@veron.ch ---
Created attachment 38803
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38803action=edit
Title 'Build a report' should display with all steps

The tile displayed only with steps #1 and #2

This patch adds the title to the following steps.

To test:
Home  Reports
Click on 'Build new'
Step through steps 1 - 6
Verify that title displays with each step.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |ve...@veron.ch
 CC||ve...@veron.ch
   Patch complexity|--- |String patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12036] Neworderempty.pl fails to add items when itemrecorddisplay is too long (acqCreateItem=ordering)

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12036

--- Comment #3 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Jonathan Druart from comment #2)
 Marcel, do you still have this issue?

Normally, I do not have AcqCreateItem set to ordering. So I did not see it
recently. But no proof of a solution yet :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14127] Typo in message preference form - mesage

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14127

--- Comment #1 from Marc Véron ve...@veron.ch ---
Created attachment 38804
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38804action=edit
Bug 14127 - Typo in message preference form - mesage

This path fixes the typo.

To reproduce and test:
Go to a patron's detail page
The message appears as hint in column-header 'Digests only (i)'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14127] Typo in message preference form - mesage

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14127

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14127] Typo in message preference form - mesage

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14127

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |ve...@veron.ch
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

--- Comment #138 from Marc Véron ve...@veron.ch ---
Patches still apply on current master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14132] suggestions table is missing indexes

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |fridolyn.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14132] New: suggestions table is missing indexes

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132

Bug ID: 14132
   Summary: suggestions table is missing indexes
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Database
  Assignee: gmcha...@gmail.com
  Reporter: fridolyn.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Suggestions table is missing some indexes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10832] Multi transport types for overdue notices

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832

Sophie MEYNIEUX sophie.meyni...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14133

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133

Sophie MEYNIEUX sophie.meyni...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10832

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14133] New: Print notices generated in special case do not use print template

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133

Bug ID: 14133
   Summary: Print notices generated in special case do not use
print template
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: sophie.meyni...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

In http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832, there are
specific cases where print notices are generated (If a user don't have a
smsalertnumber and a sms is required or if a user don't have an email defined
and an email is required).
But in this case, the template used is not print one, but sms or email.
The pb is that in that case, there is no way to identify the borrower that
should receive this message (especially for sms where the message is very
brief)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7923] Performance omnibus

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Depends on||14132

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14132] suggestions table is missing indexes

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Blocks||7923

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14134] Make Holds over show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14134

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14134] New: Make Holds over show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14134

Bug ID: 14134
   Summary: Make Holds over show holds expiring tomorrow if
ExpireReservesMaxPickUpDelay is set
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

If ExpireReservesMaxPickUpDelay is enabled, the holds over tab becomes
useless. It would be nice if the holds over tab would display *tomorrow's*
holds over so the librarian can see what will be automatically canceled over
night.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14134] Make Holds over show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14134

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 38805
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38805action=edit
Bug 14134 - Make Holds over show holds expiring tomorrow if
ExpireReservesMaxPickUpDelay is set

If ExpireReservesMaxPickUpDelay is enabled, the holds over tab becomes
useless. It would be nice if the holds over tab would display
*tomorrow's* holds over so the librarian can see what will be
automatically canceled over night.

Test Plan:
1) Apply this patch
2) Enable ExpireReservesMaxPickUpDelay
3) Note the holds over list now displays holds that will have been
   waiting more than the number of days defined in ReservesMaxPickUpDelay
   as of tomorrow.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14132] suggestions table is missing indexes

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132

--- Comment #2 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 38807
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38807action=edit
Bug 14132 - suggestions table is missing indexes - atomicupdate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14132] suggestions table is missing indexes

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132

--- Comment #1 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 38806
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38806action=edit
Bug 14132 - suggestions table is missing indexes

Suggestions table is missing some indexes.

Index on biblionumber will speed up
C4::Suggestions::GetSuggestionInfoFromBiblionumber(), often called in a loop.
Index on status and branchcode will speed up many queries.
Note that an index on budgetid is automatically added by the creation of the
foreign key constraint.

Test plan :
- Check performance with an invoice containing a lot of orders.
- Check suggestions pages are faster or at least not slower.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053

--- Comment #9 from Marc Véron ve...@veron.ch ---
Created attachment 38808
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38808action=edit
[Signed-off] Bug 14053 - Acquisition db tables are missing indexes -
atomicupdates

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

Atomic updates worked OK
Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #38729|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7923] Performance omnibus

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14132] suggestions table is missing indexes

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #3 from Marc Véron ve...@veron.ch ---
Should this have the status Needs sign-off?

For the second patch: 
Instead of
ALTER TABLE `suggestions`...
maybe better:
ALTER IGNORE TABLE `suggestions`...

http://wiki.koha-community.org/wiki/Database_updates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14134] Make Holds over show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14134

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7840] Remove from manual Koha as a CMS (or add it to master)

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7840

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 CC||indr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14134] Make Holds over show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14134

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #38805|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 38809
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38809action=edit
Bug 14134 - Make Holds over show holds expiring tomorrow if
ExpireReservesMaxPickUpDelay is set

If ExpireReservesMaxPickUpDelay is enabled, the holds over tab becomes
useless. It would be nice if the holds over tab would display
*tomorrow's* holds over so the librarian can see what will be
automatically canceled over night.

Test Plan:
1) Apply this patch
2) Enable ExpireReservesMaxPickUpDelay
3) Note the holds over list now displays holds that will have been
   waiting more than the number of days defined in ReservesMaxPickUpDelay
   as of tomorrow.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14067] 500 error when deleting patrons

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14067

Barton Chittenden bar...@bywatersolutions.com changed:

   What|Removed |Added

 CC||bar...@bywatersolutions.com

--- Comment #2 from Barton Chittenden bar...@bywatersolutions.com ---
Here's the error as found in intranet-error.log

[Mon May 04 08:52:27 2015] [error] [client xx.xx.xx.xx] [Mon May  4 08:52:27
2015] deletemem.pl: DBD::mysql::st execute failed: Column 'cardnumber' cannot
be null at /usr/local/share/perl/5.10.1/DBIx/Class/Storage/DBI.pm line 1834.
[Mon May 04 08:52:27 2015] [error] [client xx.xx.xx.xx] Premature end of script
headers: deletemem.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14135] New: Local Use syspref addition form missing variable type 'Free'

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135

Bug ID: 14135
   Summary: Local Use syspref addition form missing variable type
'Free'
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: indr...@gmail.com
QA Contact: testo...@bugs.koha-community.org

The 'Local Use' system preference addition/modification template provides the
following options against Variable Type - Choice, YesNo, Integer, Textarea,
Float, Themes, Languages, Upload or ClassSource.

But there is no option presented for Free which seems to be the most used
variable type out-of-the-box (i.e. INTRAdidyoumean, OPACdidyoumean,
UsageStatsID and UsageStatsLastUpdateTime)

This trivial patch proposes to modify the systempreferences.tt and add the
option 'Free' to the list offered to users.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14136] New: Remove superfluous template parameters from members/member-flags.pl

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14136

Bug ID: 14136
   Summary: Remove superfluous template parameters from
members/member-flags.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

This bug was triggered because intranet-error ad entries like the following:
member-flags.pl: Use of uninitialized value $roadtype in concatenation (.) or
string at /usr/share/kohaclone/members/member-flags.pl line 176.

To reproduce: Have a patron without roadtype and go to 
Home  Patrons  Set permissions for ...

There are some template parameters that are not used in the template
member-flags.tt ( $roadtype is used while preparing $address )

Unused template params are:
cardnumber
othernames
categorycode
category_type
categoryname
address
address2
city
state
zipcode
country
phone
phonepro
mobile
email
emailpro
branchcode
branchname
loop
is_child
activeBorrowerRelationship
RoutingSerials

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #38481|0   |1
is obsolete||

--- Comment #6 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38810
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38810action=edit
Bug 14059 : Testing C4::Creators::Lib

Testing C4::Creators::Lib at 100%
Deleting get_column_names subroutine (never used)

TEST PLAN
-
1. Apply patch
2. prove -v t/db_dependent/Creators/Lib.t
-- All 644 tests should run successfully without
any error or warning

TEST PLAN OPTIONAL
--

Check with bug 13899 to see the coverage of this module.

Coverage BEFORE this patch :
Statement  :  11,6%
Branch :   0,0%
Condition  :N/A
Subroutine :  36,0%

Coverage AFTER this patch :
Statement  : 100,0%
Branch : 100,0%
Condition  :N/A
Subroutine : 100,0%

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #38801|0   |1
is obsolete||

--- Comment #7 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38811
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38811action=edit
Bug 14059 : Delete all export of get_column_names

This deals with my concerns raised in comment #2.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

--- Comment #10 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
I have to review those patches because I discovered that adding a foreign key
constraint automatically adds an index

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #38728|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #38808|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14132

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14132] suggestions table is missing indexes

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14053

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14136] Remove superfluous template parameters from members/member-flags.pl

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14136

--- Comment #1 from Marc Véron ve...@veron.ch ---
Created attachment 38812
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38812action=edit
Bug 14136 - Remove superfluous template parameters from members/member-flags.pl

This bug was triggered because intranet-error.log had entries like the
following:
member-flags.pl: Use of uninitialized value $roadtype in concatenation (.) or
string at /usr/share/kohaclone/members/member-flags.pl line 176.

To reproduce: Have a patron without roadtype and go to
Home  Patrons  Set permissions for ...

There are some template parameters that are not used in the template
member-flags.tt ( $roadtype is used while preparing $address )

Unused template params are:
cardnumber
othernames
categorycode
category_type
categoryname
address
address2
city
state
zipcode
country
phone
phonepro
mobile
email
emailpro
branchcode
branchname
loop
is_child
activeBorrowerRelationship
RoutingSerials

To test:
- Verify that you get the warning above in intranet-error.log
- Verify that the parameters above are not used in the template member-flags.tt
- Apply patch
- Verify that setting permissions for patrons still works

Note: There are a lot of indenting issues in this file. This patch does not
intend to resolve them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14136] Remove superfluous template parameters from members/member-flags.pl

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14136

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14122] Patron card: Software error when creating using borrower_number as parameter from URL

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14122

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #38772|0   |1
is obsolete||

--- Comment #5 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38813
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38813action=edit
Bug 14122 - Patron card: Software error when creating using borrower_number as
parameter from URL

To test prepare an URL like the following:

...cgi-bin/koha/patroncards/create-pdf.pl?borrower_number=61template_id=24layout_id=21start_card=1

Change the values for borrower_number, template_id and layout_id to something
that exists in your system.

Without patch, the URL leads to a software error:
Can't use an undefined value as a HASH reference at
/usr/share/kohaclone/patroncards/create-pdf.pl line 118.

With patch, a PDF with the patron card is created.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

NOTE: This does NOT deal with the case where borrowernumber,
template_id, or layout_id are invalid. This only deals with
the case where they do exist.

Invalid borrowernumber still gives same error.
Invalid template_id or layout_id gives error on line 111.
Those are beyond the scope of this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14122] Patron card: Software error when creating using borrower_number as parameter from URL

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14122

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

--- Comment #6 from Julian FIOL julian.f...@biblibre.com ---
Created attachment 38814
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38814action=edit
Bug 14097 : changing verif_systempreferences_values subroutine

It's saving a large number of lines

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14122] Patron card: Software error when creating using borrower_number as parameter from URL

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14122

--- Comment #6 from Chris Nighswonger cnighswon...@foundations.edu ---
(In reply to M. Tompsett from comment #5)
 NOTE: This does NOT deal with the case where borrowernumber,
 template_id, or layout_id are invalid. This only deals with
 the case where they do exist.
 
 Invalid borrowernumber still gives same error.
 Invalid template_id or layout_id gives error on line 111.
 Those are beyond the scope of this bug.

If you don't mind, go ahead and open a bug for this. create-pdf.pl and friends
should handle this gracefully.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14137] New: Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14137

Bug ID: 14137
   Summary: Allow ExpireReservesMaxPickUpDelayCharge to be used
without ExpireReservesMaxPickUpDelay
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Some libraries would like to be able to use ExpireReservesMaxPickUpDelayCharge
without ExpireReservesMaxPickUpDelay.

ExpireReservesMaxPickUpDelay automatically cancels the holds but some
librarians would prefer to cancel the holds manually but still have the
patron's charged the fee for allowing a waiting hold to become expired and
canceled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14137] Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14137

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 38815
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38815action=edit
Bug 14137 - Allow ExpireReservesMaxPickUpDelayCharge to be used without
ExpireReservesMaxPickUpDelay

Some libraries would like to be able to use
ExpireReservesMaxPickUpDelayCharge without ExpireReservesMaxPickUpDelay.

ExpireReservesMaxPickUpDelay automatically cancels the holds but some
librarians would prefer to cancel the holds manually but still have the
patron's charged the fee for allowing a waiting hold to become expired
and canceled.

Test Plan:
1) Apply this patch
2) Set a fee amount in ExpireReservesMaxPickUpDelayCharge
3) Cancel a hold from the holds over tab
4) View the patron record, note the fee has been added

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14137] Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14137

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14135] Local Use syspref addition form missing variable type 'Free'

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135

--- Comment #1 from Indranil Das Gupta indr...@gmail.com ---
Created attachment 38816
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38816action=edit
Bug 14135 [ENH] Adds 'Free' to variabletypes in systempreferences.tt The 'Local
Use' system preference addition/modification template provides the following
options against Variable Type - Choice, YesNo, Integer, Textarea, Float,
Themes, Languages, Uplo

There is no option presented for Free which seems to be the most
used variable type out-of-the-box (i.e. INTRAdidyoumean,
OPACdidyoumean, UsageStatsID and UsageStatsLastUpdateTime)

This trivial patch proposes to modify the systempreferences.tt
and add the option 'Free' to the list offered to users.

Test Plan
=

1/ Go to Home  Administration  System preferences  Local use
2/ Click on 'New preference'.
3/ In the fieldset 'Koha Internal', the variable types offered
   are Choice, YesNo, Integer, Textarea, Float, Themes,
   Languages, Upload or ClassSources.
4/ Clicking on 'Choice' should set the 'preftype' field as
   'Choice'.
5/ Apply this patch.
6/ Refresh the page.
7/ The variable types list should read - Free, Choice, YesNo,
   Integer, Textarea, Float, Themes, Languages, Upload or
   ClassSources.
8/ Clicking on 'Free' should set the 'preftype' field as 'Free'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14135] Local Use syspref addition form missing variable type 'Free'

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14135

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13886] Add ability to merge records directly from cataloging search

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13886

--- Comment #9 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 38817
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38817action=edit
Bug 13886: (QA followup) only show merge button on search results

Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14138] New: Patroncard: Prevent errors if create-pdf.pl gets wrong parameters

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138

Bug ID: 14138
   Summary: Patroncard: Prevent errors if create-pdf.pl gets wrong
parameters
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

Creating PDF for patron cards fails if it is getting invalid parameters for
borrowernumber, template_id or layout_id

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14122] Patron card: Software error when creating using borrower_number as parameter from URL

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14122

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Blocks||14138
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14138
 QA Contact|ve...@veron.ch  |testo...@bugs.koha-communit
   ||y.org
   Assignee|cnighswon...@foundations.ed |ve...@veron.ch
   |u   |

--- Comment #7 from Marc Véron ve...@veron.ch ---
I was about to open Bug 14138...

(Oh, it seems that I mistaked by setting Assignee...)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14138] Patroncard: Prevent errors if create-pdf.pl gets wrong parameters

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Depends on||14122
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14122

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14139] New: Koha showing 1 264 and it's not the first

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14139

Bug ID: 14139
   Summary: Koha showing 1 264 and it's not the first
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

When there are two 264 fields with blank indicators, Koha seems to display the
second 264 field display rather than the first 264 field.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14140] New: Reversed payments don't generate entry in statistics

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14140

Bug ID: 14140
   Summary: Reversed payments don't generate entry in statistics
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Transaction logs
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

We are tracking payments in the statistics table, but when a payment gets
reversed, the data you can get from there is not correct. We should also be
tracking reversed payments so it's possible to calculate the correct amounts
from the statistics table.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14137] Allow ExpireReservesMaxPickUpDelayCharge to be used without ExpireReservesMaxPickUpDelay

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14137

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13886] Add ability to merge records directly from cataloging search

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13886

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #10 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Thanks Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #32 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Good job Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13887] Add datatables to item specific holds table

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #28 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Thanks Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #20 from Tomás Cohen Arazi tomasco...@gmail.com ---
Fix pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14011] Triggering slip print with enter key collides with 'barcode submitted' message

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14011

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #10 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14141] New: Changing the Library for a notice duplicates the notice instead of updating it

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141

Bug ID: 14141
   Summary: Changing the Library for a notice duplicates the
notice instead of updating it
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

If you edit a notice for a library and choose to change the Library field, the
notice is created for that library, but the old notice remains. Essentially
this turns the update into a copy with edits.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14127] Typo in message preference form - mesage

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14127

Héctor Eduardo Castro Avalos hector.hecax...@gmail.com changed:

   What|Removed |Added

  Attachment #38804|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos hector.hecax...@gmail.com ---
Created attachment 38818
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38818action=edit
[SIGNED-OFF] Bug 14127 - Typo in message preference form - mesage

This path fixes the typo.

To reproduce and test:
Go to a patron's detail page
The message appears as hint in column-header 'Digests only (i)'

Sponsored-by: Universidad de El Salvador

Signed-off-by: Hector Castro hector.hecax...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14127] Typo in message preference form - mesage

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14127

Héctor Eduardo Castro Avalos hector.hecax...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||hector.hecax...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

Héctor Eduardo Castro Avalos hector.hecax...@gmail.com changed:

   What|Removed |Added

  Attachment #38220|0   |1
is obsolete||

--- Comment #64 from Héctor Eduardo Castro Avalos hector.hecax...@gmail.com 
---
Created attachment 38819
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38819action=edit
Bug 13642 [ENH] Adding new features for Dublin Core metadata

When Koha export a bibliographic record to DC, makes it in XML format. This XML
not follows the DC-XML recommendations as should be: elements in uppercase eg.
dc:Date, dc:Creator, section 4.2, recommendation 4 explain that The property
names for the 15 DC elements should be all lower-case. eg. dc:date,
dc:creator and section 4.3 Example - a simple DC record,
xsi:schemaLocation=http://example.org/myapp/
http://example.org/myapp/schema.xsd; schema does not exist.
The recommendation can be consulted at
http://dublincore.org/documents/dc-xml-guidelines/.
This new feature, adds an ability to export Dublin Core metadata to XML and RDF
(including rdfxml, rdfjson, ntriples, turtle, etc.)

Test plan
---
1) Download Dublin Core file. Open up the file, and make sure that the document
not follows the DC-XML recommendations as should be.
2) Apply patches.
3) Go to whichever bib record in OPAC or staff and click on Save  Dublin Core.
A modal will display, prove all options.
4) Change the system preference 'Opac ExportOptions' by enabling and disabling
Dublin Core and try to download a record in the OPAC.
5) Try several bibliographic records in any format (book, magazine, DVD, etc.)
to confirm that properly exported.
6) RDF/XML can be validated per RDF Validator W3C.
7) DC-XML cannot valid if not exist a valid XSD schema.
8) OAI-DC can be validated using
http://www.freeformatter.com/xml-validator-xsd.html and the proper schema
http://www.openarchives.org/OAI/2.0/oai_dc.xsd typed in text field for URL.
9) Since unit test fail last time, test with prove t/db_dependent/Record.t

Sponsored-by: Universidad de El Salvador

Signed-off-by: Hector Castro hector.hecax...@gmail.com
XML::Entities, HTML::Entities and, HTML::Entities::Numbered were eliminated
from patch, use instead C4::Record::_entity_encode, RDF::Helper has been
eliminated too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

--- Comment #65 from Héctor Eduardo Castro Avalos hector.hecax...@gmail.com 
---
New patch sent since PerlDependencies.pm changed in master branch for 3.20 and
merge conflict with it. I really hope this not continue changing.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #38446|0   |1
is obsolete||
  Attachment #38447|0   |1
is obsolete||
  Attachment #38448|0   |1
is obsolete||
  Attachment #38449|0   |1
is obsolete||
  Attachment #38450|0   |1
is obsolete||

--- Comment #226 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 38820
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38820action=edit
Bug 9303 [1] - relative's checkouts in the opac - Database Updates

This patch gives patrons the option of allowing other
linked relatives to view his or her checkouts from
opac-user.pl in a manner similiar to the patron's own
checkouts tab. By default the setting is not enabled.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create three borrowers, link them as relatives
4) In the OPAC, go to my privacy and choose to allow
   relatives to view current checkouts for borrowers A and B
5) Check out some items to each borrower
6) Log into the OPAC as borrower A, you should see a Relatives'
   checkouts tab. In this tab you should see the checkouts for
   borrower B
7) Log into the OPAC as borrower C, you should be able to view
   the current checkouts for both borrower A and borrower B

Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #227 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 38821
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38821action=edit
Bug 9303 [2] - relative's checkouts in the opac - Schema Updates e
opac/svc/patron/

Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #230 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 38824
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38824action=edit
Bug 9303 [QA Followup] - Restore missing biblio relationship

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #229 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 38823
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38823action=edit
Bug 9303 [QA Followup] - Remove extra 'USE Koha', change Call number back to
Call no.

Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #228 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 38822
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38822action=edit
Bug 9303 [3] - relative's checkouts in the opac

Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >