[Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|ASSIGNED|In Discussion --- Comment #12 from M. Tompsett mtomp...@hotmail.com --- If I type something more than 255 characters, I get no warnings. I lost the first part of my currency description for something over 255 characters. Is there a way to wrap long descriptions, because my 255 character descriptions make the table impractical to use. I find it strange the description can not be edited. Why? AH! Because of the relationships into aqbooksellers invoiceprice and listprice. Perhaps you need another bug to fix the relation to be on the ISO code, and then this one to fix the width. Because you can't change the width to 255 on this related field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7571] Maintain exchange rate history
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7571 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added CC||indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12146] Add new ISO code column to currency sample files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 --- Comment #2 from Indranil Das Gupta indr...@gmail.com --- Created attachment 39020 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39020action=edit Bug 12146 [ENH] Add isocode column to parameters.sql a) Adds currency.isocode column to parameters.sql b) Introduces INR as an option for Koha's EN installation locale in the list of currencies Remarks: The issue of non-mandatory nature of isocode column is already settled via bug 9593, comment 77. Test Plan = 1/ create a fresh Koha instance and run the web installer 2/ at step #3 - Selecting Default Settings, select Some basic currencies with USA dollar as default for ACQ module under the section Optional to import the sample currencies. 3/ login to this new instance and go to Home - Administration - Currencies Exchange rates 4/ click edit for any of the currency options 5/ ISO code will be blank 6/ Apply patch 7/ Repeat steps 1 to 4 above 8/ ISO code will now show 3-letter ISO codes inserted by patched parameters.sql -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added Attachment #39021|0 |1 is obsolete|| --- Comment #5 from Indranil Das Gupta indr...@gmail.com --- Created attachment 39030 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39030action=edit Bug 14179 - Alters currency field to VARCHAR(255) Alters `currency`.`currency` column from VARCHAR(10) to VARCHAR(255) Test plan = 1/ login to Koha staff client and go to Home - Administration - Currencies Exchange rates 2/ add a new currency - Bhutanese Ngultrum, ISO code BTN, currency symbol Nu. and rate of 0.016) and save it. 3/ the currency name should be truncated as 'Bhutanese ' 4/ apply the patch in attachment 39021 [details] [review] 5/ update the db schema by running : % perl installer/data/mysql/updatedatabase.pl 6/ delete currency 'Bhutanese ' 7/ repeat step #2 above 8/ the currency should be saved correctly (without truncation) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|In Discussion |ASSIGNED --- Comment #9 from M. Tompsett mtomp...@hotmail.com --- (In reply to Indranil Das Gupta from comment #8) (In reply to M. Tompsett from comment #7) I believe the problem of a currency description is in need of a new table, not an increased field width. The currency column is used as a CODE not as a DESCRIPTION, as you are assuming. That be the case, giving it a maxlength and size of 50 is highly misleading. No? I stand corrected. There is a column ISO code for that. Though, I protest that schema.koha-community.org failed me. ;) Sadly, my iso codes are all null. Please fix that too in this. ;) Oh, and display the ISO code too. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 --- Comment #2 from Indranil Das Gupta indr...@gmail.com --- Created attachment 39022 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39022action=edit Bug 14179 - Update currency field's maxlength attribute Updates 'maxlength' attribute of field 'currency' in the 'New currency' addition form to 255 and brings it in sync with the field width of corresponding `currency`.`currency` column. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11213] GetItemsInfo() called twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #38584|0 |1 is obsolete|| --- Comment #52 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 39023 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39023action=edit bug_11213: Changed XSLTParse4Display() interface The list of biblio items is passed on now, instead of GetItemsInfo() being called. This is because the callers already have the list ready, so the GetItemsInfo() call is being duplicated unnecessarily. Search::searchResults() builds items list from XML, and that one is passed instead. * XSLT::XSLTParse4Display() - supply the items list as input param - removed hidden items list param - hidden should not be in the items list - changed buildKohaItemsNamespace() accordingly * Items - removed GetItemsLocationInfo() - added sort_by input param to GetItemsInfo() - VirtualShelves::Page::shelfpage() - replaced GetItemsLocationInfo() call with GetItemsInfo() call, passing order_by cn_sort * catalogue/detail.pl, opac/opac-detail.pl, shelfpage() - added items list to the XSLTParse4Display() call * Search::searchResults() - include all available info when building items lists - added combined items list (available, on loan, other) to the XSLTParse4Display() call To test: This change is a noop, so following screens need to be checked against any changes: * Intranet: - catalogue/search.pl (results) - catalogue/detail.pl - virtualshelves/shelves.pl * Opac - opac-search.pl (results, hidelostitems syspref on and off) - opac-detail.pl - opac-shelves.pl The display should stay the same before and after patch. The speed should increase though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |In Discussion CC||mtomp...@hotmail.com --- Comment #7 from M. Tompsett mtomp...@hotmail.com --- I believe the problem of a currency description is in need of a new table, not an increased field width. The currency column is used as a CODE not as a DESCRIPTION, as you are assuming. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added Attachment #39030|0 |1 is obsolete|| --- Comment #6 from Indranil Das Gupta indr...@gmail.com --- Created attachment 39031 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39031action=edit Bug 14179 - Alters currency field to VARCHAR(255) Alters `currency`.`currency` column from VARCHAR(10) to VARCHAR(255) Test plan = 1/ login to Koha staff client and go to Home - Administration - Currencies Exchange rates 2/ add a new currency - Bhutanese Ngultrum, ISO code BTN, currency symbol Nu. and rate of 0.016) and save it. 3/ the currency name should be truncated as 'Bhutanese ' 4/ apply the patch 5/ update the db schema by running : % perl installer/data/mysql/updatedatabase.pl 6/ delete currency 'Bhutanese ' 7/ repeat step #2 above 8/ the currency should be saved correctly (without truncation) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12146 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12146] Add new ISO code column to currency sample files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9593 CC||mtomp...@hotmail.com --- Comment #3 from M. Tompsett mtomp...@hotmail.com --- Bug 9593 is what added the isocode into the currency table. I figure a See Also link might be useful to have. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 --- Comment #8 from Indranil Das Gupta indr...@gmail.com --- (In reply to M. Tompsett from comment #7) I believe the problem of a currency description is in need of a new table, not an increased field width. The currency column is used as a CODE not as a DESCRIPTION, as you are assuming. That be the case, giving it a maxlength and size of 50 is highly misleading. No? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12146] Add new ISO code column to currency sample files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff CC||indr...@gmail.com Assignee|koha-b...@lists.koha-commun |indr...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14179] New: Field width for currency.currency is inadequate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 Bug ID: 14179 Summary: Field width for currency.currency is inadequate Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P4 Component: Database Assignee: gmcha...@gmail.com Reporter: indr...@gmail.com QA Contact: testo...@bugs.koha-community.org The database field currency.currency is defined as VARCHAR(10) NOT NULL. This needs to be increased e.g. set as VARCHAR(255) NOT NULL. The rationale: a) While it is possible to accomodate 'US Dollar' in that width, for many currencies this space is inadequate e.g. 'East Caribbean Dollar', 'Indian Rupee' or 'Tanzanian Shilling'. b) Further, in the 'New currency' addition form, the maxlength and size attributes are set as 50, and allows user to enter long names as examples above. While saving the record, it is truncated to VARCHAR(10). I propose the following: 1/ Alter the currency.currency field to VARCHAR(255) NOT NULL from VARCHAR(10) NOT NULL. 2/ Change the 'maxlength' attribute in the template to 255 (to match column property) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #35 from Robin Sheat ro...@catalyst.net.nz --- (In reply to Julian Maurice from comment #34) About 5.54 vs 6.0, maybe we could ask the author of Swagger2 to change the required version of Mojolicious (if Swagger2 is proven to work with 5.54 of course). What do you think ? Will that make things easier ? It certainly would, but it might be the difference between 5 minutes and half and hour, or 5 minutes and 5 weeks :) it remains to be seen. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 --- Comment #1 from Indranil Das Gupta indr...@gmail.com --- Created attachment 39021 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39021action=edit Bug 14179 - Alters currency field to VARCHAR(255) Alters `currency`.`currency` column from VARCHAR(10) to VARCHAR(255) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |indr...@gmail.com Status|NEW |Needs Signoff --- Comment #3 from Indranil Das Gupta indr...@gmail.com --- Test plan (for attachment 39021) 1/ login to Koha staff client and go to Home - Administration - Currencies Exchange rates 2/ add a new currency - Bhutanese Ngultrum, ISO code BTN, currency symbol Nu. and rate of 0.016) and save it. 3/ the currency name should be truncated as 'Bhutanese ' 4/ apply the patch in attachment 39021 5/ update the db schema by running : % perl installer/data/mysql/updatedatabase.pl 6/ delete currency 'Bhutanese ' 7/ repeat step #2 above 8/ the currency should be saved correctly (without truncation) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11213] GetItemsInfo() called twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #38590|0 |1 is obsolete|| --- Comment #58 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 39029 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39029action=edit bug_11213: Check for $item-{itype} presence to avoid warning -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11213] GetItemsInfo() called twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #38589|0 |1 is obsolete|| --- Comment #57 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 39028 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39028action=edit bug_11213: Added XSLTParse4Display() to Items test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11939] Sample of currencies with a working active value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11939 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14179 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 --- Comment #4 from Indranil Das Gupta indr...@gmail.com --- Test plan for attachment 39022 == 1/ login to Koha staff client and go to Home - Administration - Currencies Exchange rates 2/ try to enter a 59 character long fictitious currency name e.g. 'very long imaginary currency name from a fictitious country' 3/ you shouldn't be able to enter more than 'very long imaginary currency name from a fictitiou' (50 characters). do not try to save the record. 4/ apply the patch in attachment 39022 5/ repeat step #2 6/ you should be able to save the entire 59 char long name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11213] GetItemsInfo() called twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #38587|0 |1 is obsolete|| --- Comment #55 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 39026 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39026action=edit bug_11213: C4::VirtualShelves::Page::shelf_contents() * Extracted shelf items processing from shelfpage() into a separate sub shelf_contents() in order to be able to test it * Added tests for shelf_contents() with XSLT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11213] GetItemsInfo() called twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #38588|0 |1 is obsolete|| --- Comment #56 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 39027 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39027action=edit bug_11213: GetItemsInfo() test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11213] GetItemsInfo() called twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #38585|0 |1 is obsolete|| --- Comment #53 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 39024 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39024action=edit bug_11213: whitespace correction -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11213] GetItemsInfo() called twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #38586|0 |1 is obsolete|| --- Comment #54 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 39025 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39025action=edit bug_11213: Include XSLT processing for searchResults() test * Added template paths to temp test dir, so XSLT templates can be picked up -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 --- Comment #10 from Indranil Das Gupta indr...@gmail.com --- (In reply to M. Tompsett from comment #9) This is what lead me to originally write the patch From bug 9593, comment 46 : Moreover, an 'isocode' column had been added in currency table (editable in the pro interface from Administration/Currencies and exchange rates). So the active currency can be picked either through its symbol or through its iso code. From bug 9593, comment 68 : I agree, the default data convention is for the Currency field to be the ISO code. However, that doesn't mean that everyone is currently following this convention. I *don't* think this is a blocker. I could easily see the Currency being Brazilian real while the ISO code would be BRL. Since not everyone memorizes ISO codes for currency, I think this may be an improvement anyway. and then Galen pointing out in bug 9593, comment 76 : Note that currency.currency is only a varchar(10). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14179] Field width for currency.currency is inadequate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11939 --- Comment #11 from M. Tompsett mtomp...@hotmail.com --- Added bug 11939, since I posted a nice little script I wrote there. Perhaps you might like it. ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14117] Silence warnings t/Search_PazPar2.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added Attachment #38758|0 |1 is obsolete|| --- Comment #2 from Indranil Das Gupta indr...@gmail.com --- Created attachment 39016 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39016action=edit Bug 14117: Silence warnings t/SearchPazPar2.t The use of relative URLS (null actually), triggers warnings. Catch them, instead of letting them loose. TEST PLAN - 1) $ prove t/Search_PazPar2.t -- noise for each test currently. 2) apply patch 3) $ prove t/Search_PazPar2.t -- No noise, and extra tests added. -v shows caught warning tests. 4) koha qa test tools. Signed-off-by: Indranil Das Gupta indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14112] Silence warnings t/Charset.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added Attachment #38753|0 |1 is obsolete|| --- Comment #2 from Indranil Das Gupta indr...@gmail.com --- Created attachment 39014 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39014action=edit Bug 14112: Silence warnings in t/Charset.t Running prove on t/Charset.t had a complaint about a better way to write \c3. This suppresses it. TEST PLAN - 1) $ prove t/Charset.t -- get a warning 2) apply patch 3) $ prove t/Charset.t 4) run koha qa test tools Signed-off-by: Indranil Das Gupta indr...@gmail.com Current status: Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14112] Silence warnings t/Charset.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added Attachment #39014|0 |1 is obsolete|| --- Comment #3 from Indranil Das Gupta indr...@gmail.com --- Created attachment 39015 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39015action=edit Bug 14112: Silence warnings in t/Charset.t Running prove on t/Charset.t had a complaint about a better way to write \c3. This suppresses it. TEST PLAN - 1) $ prove t/Charset.t -- get a warning 2) apply patch 3) $ prove t/Charset.t 4) run koha qa test tools Signed-off-by: Indranil Das Gupta indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14112] Silence warnings t/Charset.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14117] Silence warnings t/Search_PazPar2.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14178] New: System automatically forgiving the fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14178 Bug ID: 14178 Summary: System automatically forgiving the fines Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: vimal0...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com System automatically forgiving the fines without our instruction Screenshot http://postimg.org/image/nn5cry9rl/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14177] New: Automatically changing the due date.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14177 Bug ID: 14177 Summary: Automatically changing the due date. Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: vimal0...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com As per system we are issuing the books for 25 days but for this student the due date is less than 25 days(book India govt and politics) Screenshot http://postimg.org/image/ilmdt84pl/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14176] New: No fine displaying.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14176 Bug ID: 14176 Summary: No fine displaying. Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: vimal0...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The bookk has Rs.20/- fine The screen shot taken on 20/4/2015 while check in the book. Eventhough the duedate is 31/3/2015 no fine generated for this student. See the screenshot http://postimg.org/image/wo96tpfdd/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added Attachment #38676|0 |1 is obsolete|| --- Comment #19 from Indranil Das Gupta indr...@gmail.com --- Created attachment 39019 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39019action=edit Bug 13993 - (3) Transfer order leaves incorrect orderstatus 11) Apply patch (3) 12) Log in to staff client 13) Acquisitions 14) Create a basket for two different vendors 15) Place an order in one vendor's basket. 16) Transfer the order to the other vendor's basket. 17) prove -v t/db_dependent/Acquisition/TransferOrder.t -- This should succeed without intervention. 18) Run koha qa test tools for the last 3 commits. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 Amit amitddng...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added Attachment #38674|0 |1 is obsolete|| --- Comment #17 from Indranil Das Gupta indr...@gmail.com --- Created attachment 39017 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39017action=edit Bug 13993 - (1) Add tests to confirm 'new' and 'cancelled' This adds 2 tests to t/db_dependent/Acquisition/TransferOrder.t in order to confirm the order's status is properly marked. TEST PLAN - 1) Log into staff client 2) Acquisitions 3) Create a basket for two differing vendors. 4) Place an order in one of the baskets. 5) Transfer the order from one vendor's basket to the others. 6) Apply this patch (1) only 7) prove -v t/db_dependent/Acquisition/TransferOrder.t -- should fail one test: not marked as 'cancelled'. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added Attachment #38675|0 |1 is obsolete|| --- Comment #18 from Indranil Das Gupta indr...@gmail.com --- Created attachment 39018 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39018action=edit Bug 13993 - (2) Correct poorly transferred orders Added Atomic Update to fix poorly transferred orders TEST PLAN - 8) Apply patch (2) 9) Run the database updates $ ./installer/data/mysql/updatedatabase.pl -- This should run without error 10) prove -v t/db_dependent/Acquisition/TransferOrder.t -- This should fail, because the transfer function is still not fixed. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13607] Patron management API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added CC||indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/