[Koha-bugs] [Bug 14025] Fix 865u-links in the OPAC for NORMARC

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14025

--- Comment #3 from Magnus Enger mag...@enger.priv.no ---
(In reply to Magnus Enger from comment #2)
 The scope of this bug changed a bit after I made the first comment, please
 disregard it.

...where it = the first comment (not the bug and the patch :-).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 CC||mag...@enger.priv.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14162] Instance creation information on YAML

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14162

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 CC||mag...@enger.priv.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045

Nicolas Legrand nicolas.legr...@bulac.fr changed:

   What|Removed |Added

  Change sponsored?|Seeking developer   |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10113] Currency and cost calculation problem in acquisition

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10113

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

   Hardware|PC  |All

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10113] Currency and cost calculation problem in acquisition

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10113

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 CC||indr...@gmail.com
   Severity|enhancement |normal
 OS|Windows |All

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #38411|0   |1
is obsolete||
  Attachment #38412|0   |1
is obsolete||
  Attachment #38413|0   |1
is obsolete||
  Attachment #38414|0   |1
is obsolete||
  Attachment #38415|0   |1
is obsolete||
  Attachment #38416|0   |1
is obsolete||
  Attachment #38417|0   |1
is obsolete||
  Attachment #38418|0   |1
is obsolete||
  Attachment #38419|0   |1
is obsolete||

--- Comment #62 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 39033
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39033action=edit
Bug 11603: Preparation step, cleaning up

This patch refactores and adds some good practices:
- use Modern::Perl
- use Pod::Usage
- add POD

Signed-off-by: Frederic Demians f.demi...@tamil.fr
Signed-off-by: Katrin Fischer katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #34894|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 39032
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39032action=edit
Bug 12743: ACQ: default values for catalogue records

At the moment, it is possible to create records in acquisitions, but the
ACQ framework is only used for items created in this module.

This patch allows to defined default values in the ACQ framework for
records created on the acquisition module.

Test plan:
1/ Make sure you have the ACQ framework created (otherwise create it
from the default framework).
2/ Define a default value for a field (for instance 099$z=1).
3/ Go in the acquisition module and create a new order from a new
record.
4/ Fill mandatory information and save.
5/ Go on the detail page of this record and verify the default value
exist.

Signed-off-by: Gaetan Boisson gaetan.bois...@biblibre.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603

--- Comment #70 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 39041
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39041action=edit
Bug 11603: Change the output filenames

The output filename is notices_all_date.[html|csv|ods] if no
letter_code parameter is given.
If 1 is given: notices_letter_code_date.[html|csv|ods]
If 1+ are given:
noties_letter_code1_..._letter_codeN_date.[html|csv|ods]

Signed-off-by: Katrin Fischer katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603

--- Comment #65 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 39036
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39036action=edit
Bug 11603: If a letter code is given, filenames should contain it

If you choose to generate print notices for a specific letter code, the
generated files should be distinct.

The use case is: you want to process print notice for letter codes:
overdue1, overdue2 and overdue3.

The cronjobs will be:

perl misc/cronjobs/gather_print_notices.pl
/tmp --letter_code=overdue1 --csv --ods --html --delimiter=;

perl misc/cronjobs/gather_print_notices.pl
/tmp --letter_code=overdue2 --csv --ods --html --delimiter=;

perl misc/cronjobs/gather_print_notices.pl
/tmp --letter_code=overdue3 --csv --ods --html --delimiter=;

without this patch, the 2 first files will be erased.

Signed-off-by: Frederic Demians f.demi...@tamil.fr
Signed-off-by: Katrin Fischer katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603

--- Comment #63 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 39034
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39034action=edit
Bug 11603: Gather print notices - add a csv parameter

This patch adds:
- the ability to generate a csv file instead of a html file.
- a letter_code parameter.

From now you are able to generate a csv file for print notices.

Imagine a template notice defined as:
cardnumber:patron:email:item
borrowers.cardnumber:borrowers.firstname
borrowers.surname:borrowers.email:items.barcode

You would like to generate a csv file and not a html file.

Test plan:
- define your ODUE notice for the print template as:

cardnumber:patron:email:item
borrowers.cardnumber:borrowers.firstname
borrowers.surname:borrowers.email:itemitems.barcode/item

- define overdues rules for a patron category
- check 2 items out using a due date in order to generate the overdue
  notices
- check these 2 items in
- launch the overdue_notices script
- the message_queue table should now contain 2 new entries
- launch the gather_print_notices cronjob with the following parameters:
 perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv
 --letter_code=OVERDUE --letter_code=CHECKIN
you should get an error

 perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv
you should get an error

 perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv
 --letter_code=OVERDUE -d=:
 will produce 1 csv file in your /tmp/test directory
- verify the csv file is correct and contain only 1 csv header column.

Signed-off-by: Frederic Demians f.demi...@tamil.fr
Signed-off-by: Katrin Fischer katrin.fisc...@bsz-bw.de
QA note: Keep in mind that you can use all placeholders for the
csv that you can use for the normal templates. If you normally
get the item information from item/item you need to use that.
If you can use item.barcode directly, you can also do so
in the csv.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603

--- Comment #69 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 39040
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39040action=edit
Bug 11603: (follow-up) pod

The filenames will change

Signed-off-by: Katrin Fischer katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603

--- Comment #64 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 39035
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39035action=edit
Bug 11603: Gather print notices - add a ods parameter

This patch adds:
- the ability to generate an ods file

From now you are able to generate a ods file for print notices.

You would like to generate a csv file and not a html file.

Test plan:
- same as previous patch but test the following parameters:
 perl misc/cronjobs/gather_print_notices.pl /tmp/test --ods
 --letter_code=OVERDUE -d=:
you should get an error because csv2ods is not installed.
Follow the installation instructions and try again the command.

A ods file should be generated in your /tmp/test directory.

Signed-off-by: Frederic Demians f.demi...@tamil.fr
Signed-off-by: Katrin Fischer katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603

--- Comment #66 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 39037
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39037action=edit
Bug 11603: Fix encoding issues (bug 11944 is now pushed)

Signed-off-by: Frederic Demians f.demi...@tamil.fr
  No more encoding issue with html file, no problem with csv|ods

Signed-off-by: Katrin Fischer katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603

--- Comment #67 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 39038
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39038action=edit
Bug 11603 Add --send|--nosend, fix stuf

Fix --html without --letter_code
Fix --ods which was producing a 2 lines ods file

Signed-off-by: Katrin Fischer katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603

--- Comment #68 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 39039
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39039action=edit
Bug 11603: Some minor documentation changes

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Signed-off-by: Katrin Fischer katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC)

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3758] Automatic Exchange Rates

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3758

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 CC||indr...@gmail.com

--- Comment #3 from Indranil Das Gupta indr...@gmail.com ---
http://treasury.un.org/operationalrates/UNOperationalRatesRSS.xml seems to be a
possible useful source.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2889] templates should not use [% IF ( loop.odd ) %]

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2889

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 CC||indr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14180] Make Always show checkouts immediately a global setting

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
(In reply to Katrin Fischer from comment #0)

 Several libraries have asked to check the checkbox permanently, as it's
 annoying to redo the checkbox every morning or even several times during the
 day. 

I thought Bug 13196 fixed this?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14180] Make Always show checkouts immediately a global setting

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13196

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Owen, thx for the comment! I have left a comment on the other bug - it's not
in 3.18.x and marking ths see also for now to see if it fixes the problem for
the library.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Maxime Beaulieu maxime.beaul...@inlibro.com changed:

   What|Removed |Added

  Attachment #37492|0   |1
is obsolete||

--- Comment #89 from Maxime Beaulieu maxime.beaul...@inlibro.com ---
Created attachment 39049
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39049action=edit
Bug 8753 - Add forgot password link to OPAC

I've addressed a lot of Liz Rea's points.

1.  I have moved the code from updatedatabase.pl and kohastructure.sql to a
file in the atomicupdates directory.
1a. The feature is now off by default when the atomicupdate is run.

2.  The password reset link is now visible on the home page, in the modal box
and on opac-user.pl .

3.  The password recovery pages now use bootstrap markup.

4.  I am unsure here. I see New Password: and Confirm new password:.

5.  This should still work :).

6.  I could not reproduce.

7.  I have added the userid field.
You can now reset the password by submitting either your useid or email
address.
Both fields can be filled, but the email address must be one of the
borrower's (email, emailpro or b_email).
When entering only the email address and two borrowers use that same
address, the system tells the user to try with another address or to specify
his userid.

8.  The text is in the atomicupdate file. Have at it, anyone.

Concerning the email. It is inconvenient for the use to have to wait X minutes
for the message queue the be processed.
Maybe we could add a sub in Letters.pm that:
Takes the same argments as EnqueueLetter
Sends the letter.
Saves the letter in the message queue with a 'sent' status.

 TEST PLAN:

Setup)
1) apply the patch
2) go to system preferences OPACPrivacy and set 'OpacResetPassword' to
ON.
2b) make sure that OpacPasswordChange is also ON.
A)
1) refresh front page, click on 'Forgot your password' and enter a VALID
address
1b) Also try an INVALID address (valid yet not in your koha db).  An error
message will show up.
2) An email should be received at that address with a link.
3) Follow the link in the mail to fill the new password.
Until a satisfactory new password is entered, the old password is not
reset.
4) Go to main page try the new password.
B)
1) Repeat the password reset, this time use the userid (username) field.
2) Try to reset the password using a userid and an email not linked to the
account. An error appears.
3) Make sure the borrower has many available email addresses.
4) For each email, reset the password using both the userid and the email.
The link should be sent to the specified address
C)
1) Make sure two borrowers use the same email.
2) Repeat the reset procedure in test case A). An error message appears

 Author:Maxime Beaulieu maxime.beaul...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Maxime Beaulieu maxime.beaul...@inlibro.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13758] KOHAVERSION should be statically set

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #23 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks for the followup Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #39047|0   |1
is obsolete||

--- Comment #238 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39048
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39048action=edit
Bug 9303 [QA Followup] - Restore ability for patron to control setting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13196] Always show checkouts immediately cookie should persist across sessions

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14180

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Maxime Beaulieu maxime.beaul...@inlibro.com changed:

   What|Removed |Added

 CC||maxime.beaul...@inlibro.com
   Assignee|philippe.blo...@inlibro.com |maxime.beaul...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #233 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39043
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39043action=edit
Bug 9303 [2] - relative's checkouts in the opac - Schema Updates e
opac/svc/patron/

Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #38820|0   |1
is obsolete||
  Attachment #38821|0   |1
is obsolete||
  Attachment #38822|0   |1
is obsolete||
  Attachment #38823|0   |1
is obsolete||
  Attachment #38824|0   |1
is obsolete||

--- Comment #232 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39042
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39042action=edit
Bug 9303 [1] - relative's checkouts in the opac - Database Updates

This patch gives patrons the option of allowing other
linked relatives to view his or her checkouts from
opac-user.pl in a manner similiar to the patron's own
checkouts tab. By default the setting is not enabled.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create three borrowers, link them as relatives
4) In the OPAC, go to my privacy and choose to allow
   relatives to view current checkouts for borrowers A and B
5) Check out some items to each borrower
6) Log into the OPAC as borrower A, you should see a Relatives'
   checkouts tab. In this tab you should see the checkouts for
   borrower B
7) Log into the OPAC as borrower C, you should be able to view
   the current checkouts for both borrower A and borrower B

Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14180] New: Make Always show checkouts immediately a global setting

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180

Bug ID: 14180
   Summary: Make Always show checkouts immediately a global
setting
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Right now the checkbox is unchecked by default and your setting will be kept
during the session. 

Several libraries have asked to check the checkbox permanently, as it's
annoying to redo the checkbox every morning or even several times during the
day. 

One of the librarians reporting this is relying on a screen reader and braille
line - which makes the task of rechecking the checkbox in order to be able to
read the checkouts even more tedious.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #236 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39046
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39046action=edit
Bug 9303 [QA Followup] - Restore missing biblio relationship

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #234 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39044
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39044action=edit
Bug 9303 [3] - relative's checkouts in the opac

Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #237 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39047
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39047action=edit
Bug 9303 [QA Followup] - Restore ability for patron to control setting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #235 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39045
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39045action=edit
Bug 9303 [QA Followup] - Remove extra 'USE Koha', change Call number back to
Call no.

Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13196] Always show checkouts immediately cookie should persist across sessions

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13196

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz,
   ||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Chris, can you consider this for the next 3.18.x? We have had several libraries
asking for it since their update to 3.18 (see bug 14180).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13723] OPAC cart not pulling date from RDA tag 264 only tag 260

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13723

Héctor Eduardo Castro Avalos hector.hecax...@gmail.com changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10306

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10306] acquisitions shows publisher from 260 only (RDA)

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

Héctor Eduardo Castro Avalos hector.hecax...@gmail.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13723

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383

--- Comment #17 from Winona Salesky wsale...@gmail.com ---
I don't see any reason not to include the 100$j, if no one objects I will add
it. 
-Winona


(In reply to Nick Clemens from comment #16)
 Okay, fixed what I saw before but noticed new issue:
 
 -Multiple relator terms/codes do seem to be showing (only shows first $e/$4
 (or $j/$4 for 111)
 
 Also a question:  Should we display 100$j (Attribution qualifier)?  I don't
 know if I have ever used it, but seems like it should show if present (and
 all if repeated)
 
 I think that is it then, trying to catch all the cases but so many little
 details to watch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14181] New: MARC21 773 -- Display when ind1 = 0 or blank

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181

Bug ID: 14181
   Summary: MARC21 773 -- Display when ind1 = 0 or blank
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: wsale...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Currently 773 is set to display if ind1=0 and is suppressed if ind1 = ''. Patch
will  change code to display if ind1 != 1. So it will catch both scenarios.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14170] branchtransfers items need to be cancelled when on loan or a waiting reserve

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14170

--- Comment #2 from Christopher Brannon cbran...@cdalibrary.org ---
I'm wondering if this ticket should address a more pressing issue.  It is
really perplexing as to why we are tracking the status of an item in 4 or more
tables.  I can find the status of an item in the items, reserves,
branchtransfers and issues tables, if not others.  This is extremely
inefficient, and possibly the reason statuses get jumbled in Koha, I'm finding,
on a regular basis.

Why not have an itemstatus table that keeps track of an item if it is not
available?  The reserves table should really only keep track of who is next in
the reserves.  On loan, waiting, transfers, and even damaged, lost, withdrawn,
etc could all be tracked in one table.  You could even put the status of on
cart for recently returned items in this table.

This is an area of Koha that could really use some attention and streamlining,
in my opinion.  If I am wrong, that is fine.  I just think it should be
discussed more.  It just seems like it could be a lot easier to troubleshoot
and eliminate dual statuses.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181

--- Comment #1 from Winona Salesky wsale...@gmail.com ---
Created attachment 39050
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39050action=edit
Bug 14181 : MARC21 773 -- Display when ind1 = 0 or blank

Display 773 in opac and staff details when ind1 !=1

Test Plan:
1) Apply this patch
2) Ensure you are using the default XSLT setting for the staff and opac search
results and record details
3) Find or create a record with MARC tags 773 with ind1 set to 0 or blanks
4) Check display
6) Repeat steps 3 and 4 for the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181

Winona Salesky wsale...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10941] MARC21 documentation links while adding an authority

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10941

--- Comment #4 from Stefano Bargioni bargi...@pusc.it ---
(In reply to Pablo AB from comment #3)
 Added to JQuery Library on wiki:
 http://wiki.koha-community.org/wiki/
 JQuery_Library#MARC21_documentation_links_while_adding_an_authority but in
 status=incomplete because it shows also on bibliographic frameworks.
 A lot of this JQuery enhancement should be added to Koha...

Thx Pablo to adding it to the jQuery Library.
I wrapped the code into an IF statement to apply it only in case of auth
frameworks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14067] 500 error when deleting patrons

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14067

--- Comment #5 from Barton Chittenden bar...@bywatersolutions.com ---
(In reply to David Cook from comment #4)
 (In reply to Barton Chittenden from comment #2)
  Here's the error as found in intranet-error.log
  
  [Mon May 04 08:52:27 2015] [error] [client xx.xx.xx.xx] [Mon May  4 08:52:27
  2015] deletemem.pl: DBD::mysql::st execute failed: Column 'cardnumber'
  cannot be null at /usr/local/share/perl/5.10.1/DBIx/Class/Storage/DBI.pm
  line 1834.
  [Mon May 04 08:52:27 2015] [error] [client xx.xx.xx.xx] Premature end of
  script headers: deletemem.pl



 
 That's an interesting error. When I look at my databases, 'cardnumber' is a
 nullable column. I'd suggest looking at Koha::Schema::Result::Borrower.pm
 and seeing if cardnumber has is_nullable set to 1. I'd also check the
 actual database to see if it's a nullable column...

Yes, borrowers.cardnumber is nullable in the database in question:

mysql describe borrowers;
+-+--+--+-+-++
| Field   | Type | Null | Key | Default | Extra  |
+-+--+--+-+-++
| borrowernumber  | int(11)  | NO   | PRI | NULL| auto_increment |
| cardnumber  | varchar(16)  | YES  | UNI | NULL||

and in /usr/share/koha/lib/Koha/Schema/Result/Borrower.pm

=head2 cardnumber

  data_type: 'varchar'
  is_nullable: 1
  size: 16

So... I don't know.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14067] 500 error when deleting patrons

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14067

Arturo libr...@sll.texas.gov changed:

   What|Removed |Added

 CC||libr...@sll.texas.gov

--- Comment #6 from Arturo libr...@sll.texas.gov ---
Our library is experiencing this bug, and to add a little more insight, even
though the DB 'cardnumber' field is nullable, we've set our
BorrowerMandatoryField sys pref to require a value for the 'cardnumber' field.
In our case, we allow self-registrations, and during the self-registration
process, a card number is not automatically generated -- we manually add that
in later once we review each self-registration. So when we come across a
self-registered patron during our workflow whose account we need to delete, we
get this error since we are trying to delete the account and it does not have
one of the required fields.

In other words, I don't think this bug involves a SQL error -- perhaps it is
needlessly running a check on required fields before deleting the account?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14170] branchtransfers items need to be cancelled when on loan or a waiting reserve

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14170

--- Comment #5 from Kyle M Hall k...@bywatersolutions.com ---
ModReserveStatus is only called by C4::Circulation::AddReturn, but any open
branch transfers are closed out by the same code:

1918 if ($datesent) {
1919 if ( $tobranch eq $branch ) {
1920 my $sth = C4::Context-dbh-prepare(
1921 UPDATE branchtransfers SET datearrived = now() WHERE
itemnumber= ? AND datearrived IS NULL
1922 );
1923 $sth-execute( $item-{'itemnumber'} );
1924 # if we have a reservation with valid transfer, we can set
it's status to 'W'
1925 ShelfToCart( $item-{'itemnumber'} ) if (
C4::Context-preference(ReturnToShelvingCart) );
1926 C4::Reserves::ModReserveStatus($item-{'itemnumber'}, 'W');
1927 } else {
1928 $messages-{'WrongTransfer'} = $tobranch;
1929 $messages-{'WrongTransferItem'} = $item-{'itemnumber'};
1930 }
1931 $validTransfert = 1;
1932 } else {
1933 ShelfToCart( $item-{'itemnumber'} ) if (
C4::Context-preference(ReturnToShelvingCart) );
1934 }

ModReserveAffect should probably close out any open transfers in the case it's
called to set an item to waiting.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Sheila Kearns sheila.kea...@state.vt.us changed:

   What|Removed |Added

 CC||sheila.kea...@state.vt.us

--- Comment #1 from Sheila Kearns sheila.kea...@state.vt.us ---
--Kyle,
There seems to be a conflict in this test plan for our consortium purposes.

HomeOrHolding is set to the library the item is checked out from in order to
make it possible for the holding library to charge fines and feeds for their
patrons according to their own rules--particularly libraries that do not charge
fines.

However, it is the home libraries that want to be able to decide whether or not
a lost item charge gets forgiven if a lost item makes it back to their library.

It is completely possible that I do not understand what you are planning to do.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #38999|0   |1
is obsolete||

--- Comment #7 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 39051
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39051action=edit
[SIGNED-OFF] Bug 14145: Noisy warns in admin/preferences.pl

The problem with the odd number of hashes happens when not everything is
selected.
The grep returns undef, because it isn't found in @values.
By turning the grep into a ternary-operator truth value, we can set a value (1
or 0) expressly.

The next problem is when nothing is selected in these multiple lists, $value is
undefined, so you can't split it. By splitting the definition of @values from
the actual splitting, we can split only if $value is defined, thus eliminating
the
warning message.

TEST PLAN
-
1) back up your koha error log file
2) blank your koha error log file
3) log in to the staff client
4) Home - Koha administration - Global system preferences
5) Click on every tab, EXCEPT local use.
6) notice the koha error log file has warnings.
7) blank the koha error log file again
8) apply this patch
9) Click on every tab, EXCEPT local use, again.
10) notice the koha error log file has no warnings.
11) koha qa test tools.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
I like more this version
Works as described
No koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com
  Attachment #38838|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11064] batch import ignoring framework choice

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11064

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #38319|0   |1
is obsolete||

--- Comment #3 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 39052
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39052action=edit
[SIGNED-OFF] Bug 11064: Hide the framework choice when importing biblio

This choice is ignored, it's preferable to hide it.

Test plan:
0/ Before to apply the patch, confirm the issue
1/ Stage some records for import and on the detail of the batch
(/tools/manage-marc-import.pl?import_batch_id=XXX), confirm the
framework dropdown list does not appear anymore.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Woks as described, no more dropdown.
As stated, is not a fix, only hide the option.
No koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11064] batch import ignoring framework choice

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11064

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14016] Due dates in OPAC show 0:00 when it should be 23:59

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14016

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #9 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14022] Subscription form resets 'subscription length' to issues on editing

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14022

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11884] SlipCSS and NoticeCSS should be CSS not a file

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11884

Barton Chittenden bar...@bywatersolutions.com changed:

   What|Removed |Added

   Priority|P5 - low|P3
 CC||bar...@bywatersolutions.com

--- Comment #3 from Barton Chittenden bar...@bywatersolutions.com ---
I'm bumping the priority on this -- it causes support issues in hosted
environments -- granting partners access to those files, and supporting users
who are trying to edit their own files are both pain points.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #90 from Liz Rea l...@catalyst.net.nz ---
Hi,

Spectacular, thanks I'll have another look. :)

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14008] Filters are not displayed on search for reports

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #11 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #38839|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14130] column.def should be updated with descriptions for new columns

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14130

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12949] changing child to adult doesn't remove link to guarantor

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949

jdem...@roseville.ca.us jdem...@roseville.ca.us changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14182] New: Suspended holds should show in separate list

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14182

Bug ID: 14182
   Summary: Suspended holds should show in separate list
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

It would be helpful if suspended holds were moved to a separate suspended hold
list below the active holds list, or on a separate tab, when reviewing holds on
a bib record.  They tend to blend together and staff don't always discern what
is active and what is suspended.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

Jose julianescobarmora...@gmail.com changed:

   What|Removed |Added

 CC||julianescobarmorales@gmail.
   ||com

--- Comment #95 from Jose julianescobarmora...@gmail.com ---
(In reply to Jesse Weaver from comment #1)
 Created attachment 19142 [details] [review]
 Bug 10486 - Allow external Z39.50 targets to be searched from the OPAC (1/2)
 
 This adds a new page to the OPAC that can search several Z39.50 targets
 using Pazpar2.
 
 Test plan:
 1) Apply patches.
 2) Update database.
 3) Add one or more Z39.50 targets, using the Administration - External
targets screen. Note that not all targets support keyword search, but
here are some that do:
  * Library of Congress: lx2.loc.gov, 210, LCDB, none, none, MARC21, UTF-8
  * BNF2: z3950.bnf.fr, 2211, TOUT, Z3950, Z3950_BNF, UNIMARC, UTF-8
 4) Perform a search on the OPAC, check to see if the external targets
notice pops up at the top.
 5) Click on the results link near that message.
 6) This should bring back results from all enabled targets, all of which
should be clickable to bring up a detailed view of the record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14183] New: [Koha] z39.50 search refused to connect

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14183

Bug ID: 14183
   Summary: [Koha] z39.50 search refused to connect
 Change sponsored?: ---
   Product: Koha
   Version: 3.16
  Hardware: PC
OS: Windows
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Z39.50 / SRU / OpenSearch Servers
  Assignee: gmcha...@gmail.com
  Reporter: julianescobarmora...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

[Connection failed to lx2.loc.gov] I'm using Koha 3.16

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12461] Add patron clubs feature

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #12 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Sorry, patch does not apply.
Small conflicts, and DB update is not on atomicupdate,
perhaps RM can make an exception

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14130] column.def should be updated with descriptions for new columns

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14130

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #38826|0   |1
is obsolete||

--- Comment #3 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 39053
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39053action=edit
[SIGNED-OFF] Bug 14130: Update columns.def

- Updates columns.def with new columns in items
- Adds some descriptions
- Corrects some existing column descrpitions

To test:
- Read the patch to see what has been changed
- Run the guided report builder for the 'circulation'
  module
- Observe changes show up

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Changes show up, no errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

  Attachment #39050|0   |1
is obsolete||

--- Comment #3 from Indranil Das Gupta indr...@gmail.com ---
Created attachment 39054
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39054action=edit
Bug 14181 : MARC21 773 -- Display when ind1 = 0 or blank

Display 773 in opac and staff details when ind1 !=1

Test plan
=

1/ Add a new record which uses the 773 field to an instance running
   master code. (the selected MARC framework should have the 773's
   relevant sub-fields enabled and visible on staff client, opac and
   the editor).
2/ Set ind1 as '0' (zero). The note should be displayed both on OPAC
   as well as the staff client.
3/ Reset ind1 with a non-zero value or leave it blank. The display
   note should no longer be visible from either client or opac.
4/ Apply the patch.
5/ Repeat step #1 and #2. The note is displayed on staff and opac.
6/ Repeat step #3. The display note should be visible on both staff
   and opac.
7/ run koha-qa.pl -c 1 -v 2

Note : For #1 above, the following LoC record was used:
   http://www.loc.gov/marc/bibliographic/examples.html#monographic

   The patch applied cleanly and performed as expected.

   The koha-qa.pl gave OK as results.

Signed-off-by: Indranil Das Gupta  indr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181

--- Comment #4 from Winona Salesky wsale...@gmail.com ---
I believe that coding ind1=0 is to suppress the display, 1 to display, and
blank is just a default value. According to my understanding of the LOC rules
indicate the element should be displayed as the default, or unless expressly 
coded as 0.

Any other catalogers want to chime in? 
Thanks!
-Winona


(In reply to Indranil Das Gupta from comment #2)
 (In reply to Winona Salesky from comment #0)
  Currently 773 is set to display if ind1=0 and is suppressed if ind1 = ''.
  Patch will  change code to display if ind1 != 1. So it will catch both
  scenarios.
 
 Apologies in advance for my ignorance. but isn't the point of leaving ind1
 as other than 1, is to suppress the display of the note?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14046] CheckIfIssuedToPatron fails if biblionumber != biblioitemnumber

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14046

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13817] Edit links on course items may point to the wrong course!

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14184] New: Noisy warns in C4/CourseReserves.pm

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14184

Bug ID: 14184
   Summary: Noisy warns in C4/CourseReserves.pm
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

If $term is not set and left as undefined there are a couple noisy warns

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14184] Noisy warns in C4/CourseReserves.pm

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14184

Aleisha Amohia aleishaamo...@hotmail.com changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14184] Noisy warns in C4/CourseReserves.pm

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14184

--- Comment #1 from Aleisha Amohia aleishaamo...@hotmail.com ---
Created attachment 39055
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39055action=edit
Bug 14184: Undefined $term causes noisy warns in C4/CourseReserves.pm

This patch sets $term to be an empty string.

To test:

1) Go to Course Reserves on the OPAC
2) Notice warns in error log
3) Apply patch
4) Reload page
5) Notice page still works but no warns

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11356] can't order from suggestions not at my branch

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11356

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 CC||indr...@gmail.com
 Status|Needs Signoff   |In Discussion

--- Comment #2 from Indranil Das Gupta indr...@gmail.com ---
(In reply to Winona Salesky from comment #0)
 Currently 773 is set to display if ind1=0 and is suppressed if ind1 = ''.
 Patch will  change code to display if ind1 != 1. So it will catch both
 scenarios.

Apologies in advance for my ignorance. but isn't the point of leaving ind1 as
other than 1, is to suppress the display of the note?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14099] RESERVESLIP shows incorrect information in items.holdingbranch on first scan

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14099

--- Comment #2 from Christopher Brannon cbran...@cdalibrary.org ---
So, Kyle, are you saying that scanning the item a 2nd time messes up the
transfer?  I have seen no evidence of that, and it shouldn't.  The process
works as expected.  It is just the holding branch that appears to be incorrect.
 But it sounds like you are saying it really isn't incorrect until it is
scanned and printed again.  Am I understanding that correctly?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11064] batch import ignoring framework choice

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11064

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 CC||indr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13834] News: Wording not consistent for Publication date / Creation date

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13834

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #10 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10174] Digest is confusing

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #18 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14051] Tiny adjustment of ReturnPathDefault pref description

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14051

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing.

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #24 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8474] Holds done by librarians cause silent errors in koha-error_log

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8474

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14185] Noisy warns in opac-readingrecord.pl

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14185

Aleisha Amohia aleishaamo...@hotmail.com changed:

   What|Removed |Added

   Severity|trivial |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14185] Noisy warns in opac-readingrecord.pl

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14185

--- Comment #1 from Aleisha Amohia aleishaamo...@hotmail.com ---
Created attachment 39056
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39056action=edit
Bug 14185: Undefined $limit causes warn in opac/opac-readingrecord.pl

This patch sets $limit to be an empty string.

To test:

1) On the OPAC, click on your account in the top right (Welcome, 'yourname')
2) Go to 'your reading history' tab
3) Notice warns in error log
4) Apply patch
5) Reload page
6) Notice page still works but no warns

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14186] New: Noisy warns in opac-reserve.pl

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14186

Bug ID: 14186
   Summary: Noisy warns in opac-reserve.pl
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

If $reservedfor is undefined, a warn comes up in error log

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14186] Noisy warns in opac-reserve.pl

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14186

--- Comment #1 from Aleisha Amohia aleishaamo...@hotmail.com ---
Created attachment 39057
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39057action=edit
Bug 14186: Undefined $reservedfor causes warn in opac-reserve.pl

This patch sets $reservedfor to an empty string.

To test:

1) On the OPAC, do a simple search for an item that will return results (ie by
Keyword, search for a)
2) Click Place Hold on any item
3) Notice warn in error log
4) Apply patch
5) Reload page (attempt to Place Hold)
6) Notice page still works but no warns

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14186] Noisy warns in opac-reserve.pl

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14186

Aleisha Amohia aleishaamo...@hotmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523

--- Comment #23 from Stephen Warren swar...@wwwdotorg.org ---
The issue I mentioned in comment 20 here was caused by user error. For the
record, when I modified my koha-conf.xml to add some lines to fix bug 13396, I
didn't realize that the __xxx__ values needed to be replaced with their actual
values. It seems there are some fields that contain __xxx__ after koha-create
and some that don't... After fixing that and rebuilding the search index,
everything seems to be working again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14185] New: Noisy warns in opac-readingrecord.pl

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14185

Bug ID: 14185
   Summary: Noisy warns in opac-readingrecord.pl
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

If $limit is left undefined it causes a warn in error log

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14185] Noisy warns in opac-readingrecord.pl

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14185

Aleisha Amohia aleishaamo...@hotmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14067] 500 error when deleting patrons

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14067

--- Comment #7 from David Cook dc...@prosentient.com.au ---
I can't reproduce this one on 3.14.5 or master.

Barton: I'd suggest checking
/usr/local/share/perl/5.10.1/DBIx/Class/Storage/DBI.pm line 1834

I use Perl 5.20.1 and that line doesn't seem relevant in my
DBIx::Class::Storage::DBI.

Which version of DBIx::Class are you using?

It looks like we're using version 0.082810.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14170] branchtransfers items need to be cancelled when on loan or a waiting reserve

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14170

--- Comment #4 from Christopher Brannon cbran...@cdalibrary.org ---
No.  I cannot tell exactly what causes it to be missed, but we are regularly
seeing things like this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14170] branchtransfers items need to be cancelled when on loan or a waiting reserve

2015-05-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14170

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
It does appear that C4::Circulation::AddIssue closes out any open branch
transfers at the time of checkin with the following query:

UPDATE branchtransfers SET datearrived = now(), tobranch = ?, comments =
'Forced branchtransfer' WHERE itemnumber= ? AND datearrived IS NULL

Where tobranch is the logged in branch.

Have you been able to trigger a scenario where the transfer isn't closed out
when an item is issued?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/