[Koha-bugs] [Bug 13839] Force item holds on item type level

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13839

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Marcel - can this be closed with the new option in the circulation
conditions?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #39058|0   |1
is obsolete||

--- Comment #2 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 39059
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39059action=edit
Bug 14187 - branchtransfer needs a primary key (id) for DBIx and common sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14188

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14188] branchtransfers GetAllTransfers and GetAllPendingTransfers functions to ease testing.

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14188

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14187

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14187] New: branchtransfer needs a primary key (id) for DBIx.

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187

Bug ID: 14187
   Summary: branchtransfer needs a primary key (id) for DBIx.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: olli-antti.kivila...@jns.fi
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

Summary|branchtransfer needs a  |branchtransfer needs a
   |primary key (id) for DBIx.  |primary key (id) for DBIx
   ||and common sense.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181

--- Comment #5 from Indranil Das Gupta indr...@gmail.com ---
(In reply to Winona Salesky from comment #4)
 I believe that coding ind1=0 is to suppress the display, 1 to display, and
 blank is just a default value. According to my understanding of the LOC
 rules indicate the element should be displayed as the default, or unless
 expressly  coded as 0.

I discussed this with Galen Charlton, after I asked the question here. He
agrees with the idea of you patch and said that should be default behavior if
not set to 0.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14188] New: branchtransfers GetAllTransfers and GetAllPendingTransfers functions to ease testing.

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14188

Bug ID: 14188
   Summary: branchtransfers GetAllTransfers and
GetAllPendingTransfers functions to ease testing.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: olli-antti.kivila...@jns.fi
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187

--- Comment #1 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 39058
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39058action=edit
Bug 14187 - branchtransfer needs a primary key (id) for DBIx and common sense.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #39059|0   |1
is obsolete||

--- Comment #3 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 39060
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39060action=edit
Bug 14187 - branchtransfer needs a primary key (id) for DBIx and common sense.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14188] branchtransfers GetAllTransfers and GetAllPendingTransfers functions to ease testing.

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14188

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |olli-antti.kivila...@jns.fi
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14188] branchtransfers GetAllTransfers and GetAllPendingTransfers functions to ease testing.

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14188

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14188] branchtransfers GetAllTransfers and GetAllPendingTransfers functions to ease testing.

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14188

--- Comment #1 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 39061
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39061action=edit
Bug 14188 - branchtransfers GetAllTransfers and GetAllPendingTransfers
functions to ease testing.

Because there is no nice way of getting all branchtransfers and putting SQL
into
tests is VERY VERY BAD, introducing these branchtransfer API calls to
conveniently get all transfers data nicely.

Unit tests included.

TEST PLAN:
Run t/db_dependent/Circulation_transfers.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342

Eivin Giske Skaaren eskaa...@yahoo.no changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||eskaa...@yahoo.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #10 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Nice concise bit of code here adding a long needed logger to koha in as simple
a way as possible using a well developed lib.

Lets make the choice and get this rolling!

Minor comments, I can't fully remember how the package building get put
together.. but I 'think' we need a copy of the log4perl.conf file that's added
here also adding under the debian dir somewhere.

I'll try and dig out my notes to advise, assuming Tomas or Robin don't beat me
to it. ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #38993|0   |1
is obsolete||

--- Comment #9 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 39103
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39103action=edit
Bug 14167 - Add Koha::Logger based on Log4perl

Koha needs a better logger, and it seems like the best solution would be
to take advantage of Log4perl which is already a fully featured logger.
We use Log4perl to selectively decide what statements should be logged,
and where they should go!

Test plan:
0) Install Log::Log4perl via packages or cpan
1) Apply this patch
2) Copy etc/log4perl.conf to your koha conf directory, edit the paths
   to match your current error logs
3) Edit your koha-conf file and add the
   log4perl_conf/path/to/log4perl.conf/log4perl_conf line
4) Watch your intranet and opac error logs
5) Perform a renewal via the staff interface, note there is nothing new
   in the log file
7) Update the log4perl.conf, change the log level from DEBUG to TRACE
   for both the staff and opac sides
8) Perform a renewal via the staff interface, note the logged lines
9) Perform a renewal via the opac, note the logged lines

Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #34197|0   |1
is obsolete||

--- Comment #212 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 39101
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39101action=edit
[SIGNED-OFF] Bug 6679: (follow-up) fix 9 perlcritic violations in
C4/TmplTokenType.pm

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #34196|0   |1
is obsolete||

--- Comment #211 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 39100
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39100action=edit
[SIGNED-OFF] Bug 6679 - Fixing code so it passes basic Perl:::Critic tests

opac/ilsdi.pl: Stricture disabled at line 217, column 17.  See page 429 of PBP.
 (Severity: 5)

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189

Eivin Giske Skaaren eskaa...@yahoo.no changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |eskaa...@yahoo.no
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style (see also 10480)

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437

--- Comment #3 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Still more to come..Please wait

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #37981|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39096
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39096action=edit
Bug 13948 - Add ability to dump template toolkit variables to html comment

It would be incredibly helpful if we could easily enable Koha to dump
all Template Toolkit variables to a comment for debugging purposes.

Test Plan:
1) Apply this patch
2) Run updatedatabase
3) Enable the new system preferences DumpTemplateVarsIntranet and
   DumpTemplateVarsOpac
4) Load a page in the staff intranet, view the html source
5) Note the template toolkit variables are embedded in an html comment
6) Load a page in the opac, view the html source
7) Note the template toolkit variable are embedded in an html comment

NOTE: I had to cpan2deb Template::Plugin::Stash to test.
  This is not optimal. Additionally:
  http://www.template-toolkit.org/docs/modules/Template/Plugin/index.html
  does not contain Stash. I suspect this was how it was
  introduced initially by TT.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342

Eivin Giske Skaaren eskaa...@yahoo.no changed:

   What|Removed |Added

  Attachment #39089|0   |1
is obsolete||

--- Comment #3 from Eivin Giske Skaaren eskaa...@yahoo.no ---
Created attachment 39098
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39098action=edit
Bug 12342: Patron registration datepicker dropdown shows only 10 years

This patch changes the options to the date picker, allowing easy
selection of dates up to 100 years from the current date.
Default value selected is current date minus 15 years; this assumes that
15 years is a common age for new patrons.

To test:
- Click on 'Patrons' from the main menu, select 'New patron'
- Set input focus to the 'Date of birth' input field,
  the date selection widget should show up.
- The default selected date will be current date minus one.
- The year selection drop-down will only show current year minus 10.
- Apply the patch
- Go back to the same screen, set input focus to the 'Date of birth' field.
- The default selected date should be current year minus 15.
- The year selection drop-down should show current year minus 100.

Signed-off-by: Eivin Giske Skaaren eskaa...@yahoo.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to Jonathan Druart from comment #2)
 The plan of attack looks good to me.
 I am just wondering if the field branches.refund_lost_item_fee_on_return
 makes sense.
 Don't you think it would be better to set this rule in the Circulation and
 fine rules page (admin/smart-rules.pl)? It would be easy to change the
 behavior for all libraries (if only a default rule is defined).

I was wondering that myself Jonathan. I'll look into it, seems like a good
idea.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948

--- Comment #10 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39097
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39097action=edit
Bug 13948 [QA Followup] - Make dependency optional

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing Matching

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #36105|0   |1
is obsolete||

--- Comment #17 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 39099
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39099action=edit
[SIGNED-OFF] Bug 6499: Add Zebra index Other-control-number covering MARC21
035$a, 035$z and 035 (entire tag)

1) Apply patch
2) Make sure that you have a bib that has MARC21 035$a (and possibly also
035$z) populated.

pre 3) Replace all modified zebra files and restart zebra server

3) Rebuild zebra: misc/migration_tools/rebuild_zebra.pl -x -b -z
4) Add the following to the intranetuserjs syspref:

$(document).ready(function(){
// Add Other Control Number to advanced search
if (window.location.href.indexOf(catalogue/search.pl)  -1) {
$(.advsearch).append('option value=Other-control-numberOther
Control Number/option');
}
});

5) Do an advanced search, select Other Control Number from the search menu,
then add the Other Control Number in 035$a for the bib specified in step 1.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Works, no koha-qa errors

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing Matching

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12366] Better handling of Zebra errors when searching empty indexes

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12366

Jacek Ablewicz a...@biblos.pk.edu.pl changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14189] New: Make text persist/populate hidden fields for the Staff searchbox

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189

Bug ID: 14189
   Summary: Make text persist/populate hidden fields for the Staff
searchbox
 Change sponsored?: Sponsored
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: eskaa...@yahoo.no
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Sponsored by Halland County Library.

When clicking the tabs under the search box the currently typed value does not
persist since hidden fields are used. 

Users of the system are interested in that the text is populated to the hidden
fields so that they don't have to type it in again if they for example had the
wrong tab selected when searching the first time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189

Eivin Giske Skaaren eskaa...@yahoo.no changed:

   What|Removed |Added

  Attachment #39105|0   |1
is obsolete||
  Attachment #39106|0   |1
is obsolete||

--- Comment #4 from Eivin Giske Skaaren eskaa...@yahoo.no ---
Created attachment 39107
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39107action=edit
Made text persist when clicking the tabs under the searchbox

To test:
Apply the patch and see that the text now is there in the search
box when clicking the tabs: check in, check out etc..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I think Sheila has a good point - maybe the dependence on HomeOrHolding is not
the best option here and we need something that is a bit more flexible?

Only other thing is maybe the column name - refund_lost_item_fee_on_return is
quite a bit to write, maybe just refund_lost_on_return? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #3 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Thanks Mark, will take a quick test but looks good from a quick read.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189

--- Comment #1 from Eivin Giske Skaaren eskaa...@yahoo.no ---
Created attachment 39104
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39104action=edit
Added the functionality to most staff header search boxes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #16 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Thanks Theodoros, 

Think that must have crept in amongst the various rebases/iterations..

From a quick read of the code I actually thing the $dbh param can be removed
from both the calling line and the sub unless I'm mistaken as it doesn't appear
to be called upon at anywhere.

I'll do a quick test and a followup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

--- Comment #101 from M. Tompsett mtomp...@hotmail.com ---
(In reply to Bernardo Gonzalez Kriegel from comment #100)
 Tested what I can, not plack/shibboleth/cas

For plack: https://github.com/digibib/kohadevbox
(Because I don't understand how to get it installed by default either)

For shibboleth: I figure the tests are good enough, but you need
Test::DBIx::Class (which I believe is in the kohadevbox :) )

For cas: Again, I just assumed the tests were good enough.


 Perhaps this can pass and we can fix any problem later (for 3.22)

Yes, please. :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14035] Shibboleth SingleSignOut

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14035

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189

Eivin Giske Skaaren eskaa...@yahoo.no changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12681] Shibboleth attributes may contain lists

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12681

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189

--- Comment #3 from Eivin Giske Skaaren eskaa...@yahoo.no ---
Created attachment 39106
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39106action=edit
Added the functionality to most staff header search boxes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189

Eivin Giske Skaaren eskaa...@yahoo.no changed:

   What|Removed |Added

  Attachment #39104|0   |1
is obsolete||

--- Comment #2 from Eivin Giske Skaaren eskaa...@yahoo.no ---
Created attachment 39105
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39105action=edit
Bug 14189 - Make text persist/populate hidden fields for the Staff searchbox

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14034] User logged out on refresh after Shibboleth authentication

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189

Eivin Giske Skaaren eskaa...@yahoo.no changed:

   What|Removed |Added

  Attachment #39107|0   |1
is obsolete||

--- Comment #5 from Eivin Giske Skaaren eskaa...@yahoo.no ---
Created attachment 39108
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39108action=edit
Made text persist when clicking the tabs under the searchbox

To test:
Apply the patch and see that the text now is there in the search
box when clicking the tabs: check in, check out etc..

Sponsored-by: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167

--- Comment #11 from Tomás Cohen Arazi tomasco...@gmail.com ---
(In reply to Martin Renvoize from comment #10)
 Nice concise bit of code here adding a long needed logger to koha in as
 simple a way as possible using a well developed lib.
 
 Lets make the choice and get this rolling!
 
 Minor comments, I can't fully remember how the package building get put
 together.. but I 'think' we need a copy of the log4perl.conf file that's
 added here also adding under the debian dir somewhere.
 
 I'll try and dig out my notes to advise, assuming Tomas or Robin don't beat
 me to it. ;)

Indeed, for the packages we will need to:
- Add a template file into debian/templates/(logger4perl-site.conf.in ?)
- Tweak the debian/scripts/koha-create script so it correctly puts the
  template file with the right variable substitutions.
- Maybe add some switches controlling the logging configuration, but this could
  go into a separate bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14190] New: Scale search boxes in staff head

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190

Bug ID: 14190
   Summary: Scale search boxes in staff head
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: viktor.sa...@regionhalland.se
QA Contact: testo...@bugs.koha-community.org

I've had pointed out to me that the search boxes in the head of the staff
interface in unnecessarily small. For catalog search it could even shape the
expectation of how many search terms is expected and unconsciously steer
librarians towards broader searches. Since screens is often bigger these days
and the area right of the search box is unused it seems a bit conservative to
go with size 40. 

I suggest that we make the container float up to some max size and then let the
individual search boxes be for example size 60 but also have the CSS rule of
width:100% to resize with the container. That way it will use the space
better, scale up and down and still not become ridiculously huge on a 27.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14191] Noisy warns in C4/XSLT.pm

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14191

--- Comment #1 from Aleisha Amohia aleishaamo...@hotmail.com ---
Created attachment 39109
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39109action=edit
Bug 14191: Use of operators causing warn in C4/XSLT.pm

In this if statement causing the warns, || is used in the left arguments. This
patch changes these to // as I think this is essentially the same thing. I
don't know that this is the best way to fix this but it silences the warns.

To test:

1) On the OPAC, do a simple search for an item that will return results (ie by
Keyword, search for a)
2) Notice the warns in the error log
3) Apply patch
4) Reload page (search for a)
5) Notice page still works but no warns

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14191] Noisy warns in C4/XSLT.pm

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14191

Aleisha Amohia aleishaamo...@hotmail.com changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14191] New: Noisy warns in C4/XSLT.pm

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14191

Bug ID: 14191
   Summary: Noisy warns in C4/XSLT.pm
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

Use of uninitialized value in numeric eq at an if statement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948

--- Comment #11 from M. Tompsett mtomp...@hotmail.com ---
(In reply to Kyle M Hall from comment #10)
 Created attachment 39097 [details] [review]
 Bug 13948 [QA Followup] - Make dependency optional

This doesn't answer the implied question from what I wrote:
Additionally:
 http://www.template-toolkit.org/docs/modules/Template/Plugin/index.html
 does not contain Stash. I suspect this was how it was
 introduced initially by TT.

Do you even need to mention it? Is not stash already part of TT?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #34194|0   |1
is obsolete||

--- Comment #213 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 39102
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39102action=edit
Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Record.pm

Expression form of eval at line 358, column 5.  See page 161 of PBP. 
(Severity: 5)
Expression form of eval at line 367, column 5.  See page 161 of PBP. 
(Severity: 5)
Expression form of eval at line 510, column 3.  See page 161 of PBP. 
(Severity: 5)

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Fixed conflict

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189

Eivin Giske Skaaren eskaa...@yahoo.no changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14185] Noisy warns in opac-readingrecord.pl

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14185

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||indr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14185] Noisy warns in opac-readingrecord.pl

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14185

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

  Attachment #39056|0   |1
is obsolete||

--- Comment #2 from Indranil Das Gupta indr...@gmail.com ---
Created attachment 39111
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39111action=edit
Bug 14185: Undefined $limit causes warn in opac/opac-readingrecord.pl

This patch sets $limit to be an empty string.

Test plan
=

1/ login into the opac using your user account credentials
2/ in a terminal, run a `tail -f ` on your instance's opac-error.log
3/ go back to the opac, click on 'your reading history' tab to go to
   opac-readingrecord.pl
4/ notice the warning - opac-readingrecord.pl: Use of uninitialized
   value $limit appear in the `tail`ed opac-error.log
5/ apply the patch
6/ reload the page (opac-readingrecord.pl)
7/ page works but the warning in step #4 is no longer logged
8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error

Remarks: Testing result match expected test plan output. The QA tests
 pass with OK for the commit.

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) indr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13799] Add base for building RESTful API

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #36 from Julian Maurice julian.maur...@biblibre.com ---
Just asked: https://github.com/jhthorsen/swagger2/issues/14

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6837] When AllowOnShelfHolds is OFF then holds on records with available items should not be possible

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6837

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 CC||indr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
The plan of attack looks good to me.
I am just wondering if the field branches.refund_lost_item_fee_on_return makes
sense.
Don't you think it would be better to set this rule in the Circulation and
fine rules page (admin/smart-rules.pl)? It would be easy to change the
behavior for all libraries (if only a default rule is defined).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069

--- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
(In reply to Colin Campbell from comment #6)
 Wonder if there needs to be a unique constraint on itemnumber in issues.
 Have noticed after losing the old PK constraint that duplicate issues can
 now occur, in various places ( fines? holds?) I think there are assumptions
 that only 1 isssue will exist for an itemnumber

I think a unique for the issues table would make sense. 

Did you experience double issues? It sounds scary, but I am still hoping we are
not doing that, as it looked like not all installations had the PK to begin
with. We removed the line from kohastructure quite a while back by accident
with:
http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=91b5a09c6cef398d9ad39ca1ced7d6569a87456b

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

 CC||ro...@catalyst.net.nz

--- Comment #12 from Robin Sheat ro...@catalyst.net.nz ---
How does this compare to bug 13413?

As for the packaging stuff, what Tomás says looks like the right idea to me, it
shouldn't be too complicated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189

Eivin Giske Skaaren eskaa...@yahoo.no changed:

   What|Removed |Added

  Attachment #39108|0   |1
is obsolete||

--- Comment #6 from Eivin Giske Skaaren eskaa...@yahoo.no ---
Created attachment 39110
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39110action=edit
Made text persist when clicking the tabs under the searchbox

To test:
Apply the patch and see that the text now is there in the search
box when clicking the tabs: check in, check out etc..

(More files changed for persistent text in searchbox)

Sponsored-by: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #38247|0   |1
is obsolete||
  Attachment #38248|0   |1
is obsolete||
  Attachment #38249|0   |1
is obsolete||
  Attachment #38250|0   |1
is obsolete||
  Attachment #38251|0   |1
is obsolete||
  Attachment #38252|0   |1
is obsolete||
  Attachment #38253|0   |1
is obsolete||
  Attachment #38254|0   |1
is obsolete||
  Attachment #38255|0   |1
is obsolete||
  Attachment #38256|0   |1
is obsolete||
  Attachment #38257|0   |1
is obsolete||
  Attachment #38258|0   |1
is obsolete||
  Attachment #38259|0   |1
is obsolete||
  Attachment #38260|0   |1
is obsolete||
  Attachment #38261|0   |1
is obsolete||
  Attachment #38262|0   |1
is obsolete||

--- Comment #714 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39063
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39063action=edit
Bug 6427 - Update database

This patch set re-engineers Koha's accounting system to be faster, more
stable, and have a better historical accounting of fees and payments
while also unifying much of the payment logic and simplifying the code
behind it.

Three new tables have been created:
account_debits stores fines and fees owed by the patron.

account_credits stores payments, write-offs, and other line items that
reduce the amount owed by a patron.

account_offsets stores data about changes to debits and credits,
including which credits paid which debits.

borrowers.account_balance stores the current balance of the
patron, so it does not have to be calculated each time it needs to be
displayed.

issues.issue_id has been added so that individual fines can be directly
linked to the issue that caused them without ambiguity.

The various accounting code strings ( F, FU, Rent, etc ), some of which
have little or no documentation have been replaced by what enumerated
data types which are documented via POD.
There are three, one for each of Debits ( fees/fines ), Credits ( payments ),
and Offsets.

The system continues to allow custom fee types ( moving MANUAL_INV to
MANUAL_DEBIT )
while additionally allowing custom payment types ( MANUAL_CREDIT ).

The system also allows for overpayment, the the outstanding credit being
applied to future fees as they are created.

The system also allows for a librarian to accept a different amount of
money than what is to be paid, and will calculate the change to be
given.

Test Plan:
1) Apply this patch
2) Create some manual fees
3) Test the fee payments
   * Pay one fee
   * Pay multiple fees
   * Make a partial payment
   * Write off a fee
4) View the fees/payments, verify they are correct
5) Check out some items as overdue that should have fines
6) Run fines.pl, verify fines were generated
7) Pay on an accruing fine
8) Run fines.pl again, verify the fine hasn't changed
9) Increase the daily fine in issuing rules
10) Run fines.pl again, verify the fine has increased
11) Decrease the daily fine in issuing rules
12) Run fines.pl again, verify the fine has decreased
13) Test dropbox mode
14) Test WhenLostChargeReplacementFee both ways
15) Test RefundLostItemFeeOnReturn both ways
16) Test WhenLostForgiveFine both ways
17) Test CalculateFinesOnReturn both ways

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Sean McGarvey se...@pascolibraries.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #718 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39067
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39067action=edit
Bug 6427 - Add new TT plugin to deal with currency

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Sean McGarvey se...@pascolibraries.org

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Theodoros Theodoropoulos th...@lib.auth.gr changed:

   What|Removed |Added

 CC||th...@lib.auth.gr

--- Comment #14 from Theodoros Theodoropoulos th...@lib.auth.gr ---
Very useful enhancement Martin! It is exactly what we need too :)

One small suggestion: An extra line that defines dbh is probably required in
the beginning of checkpw_shib in case _autocreate has to be called
(ie something like: my $dbh = C4::Context-dbh; )

Other than that it's working like a charm for me!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12516] The module C4::Tags needs more unit tests

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12516

Julian FIOL julian.f...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #725 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39075
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39075action=edit
Bug 6427 - Make fines tabs link to account payment page

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Sean McGarvey se...@pascolibraries.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #727 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39077
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39077action=edit
Bug 6427 [QA Followup] - Fix accounts table default sorting

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #726 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39076
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39076action=edit
Bug 6427 [QA Followup] - Improvements to OPAC view

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #729 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39079
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39079action=edit
Bug 6427 [QA Followup] - Fix kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #728 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39078
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39078action=edit
Bug 6427 [QA Followup] - Drop old accounts tables

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12516] The module C4::Tags needs more unit tests

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12516

Julian FIOL julian.f...@biblibre.com changed:

   What|Removed |Added

   Assignee|julian.f...@biblibre.com|ch...@bigballofwax.co.nz
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #716 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39065
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39065action=edit
Bug 6427 - Add new Accounts related Koha modules

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Sean McGarvey se...@pascolibraries.org

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #715 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39064
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39064action=edit
Bug 6427 - Update schema files

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Sean McGarvey se...@pascolibraries.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #717 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39066
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39066action=edit
Bug 6427 - Update existing Koha perl modules

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Sean McGarvey se...@pascolibraries.org

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #723 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39073
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39073action=edit
Bug 6427 - Delete unused and unnecessary files

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Sean McGarvey se...@pascolibraries.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #724 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39074
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39074action=edit
Bug 6427 - Unit Tests

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Sean McGarvey se...@pascolibraries.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4137] OPACViewOthersSuggestions does not work

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4137

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #37207|0   |1
is obsolete||

--- Comment #12 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 39068
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39068action=edit
[SIGNED-OFF] Bug 4137: Fix the OPACViewOthersSuggestions behavior

This pref does not work at all, the interface let the user choose to
list all suggestions, but whatever he chooses the suggestion list is the
same.

This patch cleans a bit the suggestedby management.

There are a lot of cases to test, because linked to 2 prefs:
 AnonSuggestions and OPACViewOthersSuggestions.
1/ AnonSuggestions = 0 and OPACViewOthersSuggestions = 0
  - A non logged in user is not able to purchase a suggestion.
  - A logged in user is not able to see suggestions made by someone else.
2/ AnonSuggestions = 0 and OPACViewOthersSuggestions = 1
  - A non logged in user is not able to purchase a suggestion.
  - A logged in user is able to see suggestions made by someone else.
3/ AnonSuggestions = 1 and OPACViewOthersSuggestions = 0
  - A non logged in user is able to purchase a suggestion.
  The suggestedby field will be filled with the AnonymousPatron pref value.
  He is not able to see suggestions, even the ones made by AnonymousPatron.
  - A logged in user is not able to see suggestions made by someone else.
4/ AnonSuggestions = 1 and OPACViewOthersSuggestions = 1
  - A non logged in user is able to purchase a suggestion.
  He is able to see all suggestions.
  - A logged in user is able to see suggestions made by someone else.

In all cases a logged in user should be able to search for suggestions
(except if he is not able to see them).

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
All use cases tested, work as expected
No errors

Only comment is perhaps (in the future) a gracefull failure
when AnonymousPatron is not set, or has '0' value

Message is DBIx::Class::ResultSet::create(): Column 'suggestedby' cannot be
null at ...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #722 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39072
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39072action=edit
Bug 6427 - Add  update cron scripts

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Sean McGarvey se...@pascolibraries.org

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #721 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39071
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39071action=edit
Bug 6427 - Update OPAC scripts

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Sean McGarvey se...@pascolibraries.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #720 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39070
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39070action=edit
Bug 6427 - Update existing intranet scripts

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Sean McGarvey se...@pascolibraries.org

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #15 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Theodoros, thx for testing this! I am setting to failed QA for now, as this
will need a follow-up from Martin to get further. If you want, you could also
sign off his patches as they are and add a follow-up for Martin to check and
sign off on.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

--- Comment #11 from Julian FIOL julian.f...@biblibre.com ---
Created attachment 39080
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39080action=edit
Bug 14097 : Rollback issue and warning corrected

The rollback issue came from '_count' testing.
It used a 'DROP TABLE' and 'CREATE TABLE' which implicitly do autocommit.
That's why the final rollback could not be.

This patch no longer uses t::lib::TestBuilder either because it was the cause
of the warning on Comment #1 :
DBIx::Class::Storage::txn_rollback(): A txn_rollback
in nested transaction is ineffective! (depth 1) at
t/lib/TestBuilder.pm line 308

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097

Julian FIOL julian.f...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #719 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39069
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39069action=edit
Bug 6427 - Add new staff scripts for managing accounts

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Sean McGarvey se...@pascolibraries.org

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4137] OPACViewOthersSuggestions does not work

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4137

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

--- Comment #102 from M. Tompsett mtomp...@hotmail.com ---
(In reply to M. Tompsett from comment #101)
 For shibboleth: I figure the tests are good enough, but you need
 Test::DBIx::Class (which I believe is in the kohadevbox :) )

Debug and make sense of this to get it in.

sudo apt-get install dh-make-perl libdata-visitor-perl
libdbix-class-timestamp-perl libdatetime-format-sqlite-perl
libdatetimex-easy-perl libtype-tiny-perl libyaml-tiny-perl
libmoox-handlesvia-perl libtest-fatal-perl libclass-dbi-perl
libmoosex-types-path-class-perl libmoosex-types-json-perl
libmoosex-types-loadableclass-perl libtime-piece-mysql-perl libmath-base36-perl
libcpanel-json-xs-perl libclass-accessor-lite-perl libfile-copy-recursive-perl
libtest-sharedfork-perl libtest-deep-perl libdata-uuid-perl
libdbix-class-uuidcolumns-perl libtest-differences-perl libdbd-mysql
mysql-server libdatetime-format-mysql-perl

cpan2deb MooseX::Attribute::ENV
cpan2deb DBD::SQLite
cpan2deb MooX::HandlesVia
cpan2deb DBIx::Class::Schema::PopulateMore
cpan2deb Test::mysqld
cpan2deb Test::DBIx::Class

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13774] Add the unique anchors of news as links in the RSS for news in Opac

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774

Viktor Sarge viktor.sa...@regionhalland.se changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #3 from Viktor Sarge viktor.sa...@regionhalland.se ---
Hi Pierre! We discovered that the sandboxes has the opac disabled as public.
The RSS stream does link to the correct news item but when the opac require log
in you will not be able to see the news. Does the problem persist when you make
the opac public in the sysprefs? 

Another thing to watch our for is that the RSS stream can only expose news that
are directed to all libraries. If you view the news while logged in and only
have news directed to a particular library (but none directed to all
libraries you will get an empty RSS. This need to be handled a bit better, but
that's a matter for other patches :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

 CC||colin.campbell@ptfs-europe.
   ||com

--- Comment #6 from Colin Campbell colin.campb...@ptfs-europe.com ---
Wonder if there needs to be a unique constraint on itemnumber in issues. Have
noticed after losing the old PK constraint that duplicate issues can now occur,
in various places ( fines? holds?) I think there are assumptions that only 1
isssue will exist for an itemnumber

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1985] Email notification of new OPAC comments

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #38910|0   |1
is obsolete||

--- Comment #43 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 39062
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39062action=edit
[SIGNED-OFF] Bug 1985: Follow up - Add sample letter to other languages

As per comment #36, the letter COMMENT_CREATED has been added
to the other languages.

TEST PLAN
-
0) Back up your letters table
1) In your mysql client after selected your Koha database,
   Run this:

SET foreign_key_checks = 0;
truncate letter;
source installer/data/mysql/de-DE/mandatory/sample_notices.sql
SELECT COUNT(*) FROM letter where code='COMMENT_CREATED';
truncate letter;
source installer/data/mysql/es-ES/mandatory/sample_notices.sql
SELECT COUNT(*) FROM letter where code='COMMENT_CREATED';
truncate letter;
source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql
SELECT COUNT(*) FROM letter where code='COMMENT_CREATED';
truncate letter;
source installer/data/mysql/it-IT/necessari/notices.sql
SELECT COUNT(*) FROM letter where code='COMMENT_CREATED';
truncate letter;
source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql
SELECT COUNT(*) FROM letter where code='COMMENT_CREATED';
truncate letter;
source installer/data/mysql/pl-PL/mandatory/sample_notices.sql
SELECT COUNT(*) FROM letter where code='COMMENT_CREATED';
truncate letter;
source installer/data/mysql/ru-RU/mandatory/sample_notices.sql
SELECT COUNT(*) FROM letter where code='COMMENT_CREATED';
truncate letter;
source installer/data/mysql/uk-UA/mandatory/sample_notices.sql
SELECT COUNT(*) FROM letter where code='COMMENT_CREATED';
truncate letter;
source installer/data/mysql/en/mandatory/sample_notices.sql
SELECT COUNT(*) FROM letter where code='COMMENT_CREATED';

   -- there should be 9 counts of 1.
2) Restore your letters table.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Sample letter in all languages
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1985] Email notification of new OPAC comments

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #39008|0   |1
is obsolete||

--- Comment #99 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 39086
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39086action=edit
[SIGNED-OFF] Bug 5010: Fix OPACBaseURL to include protocol

First, it is strongly recommended to set the OPACBaseURL. But
this patch allows the inclusion of the protocol and not just
a site.

Next, C4/Auth now puts OPACBaseURL into the template parameters
regardless of OPAC or Staff clients.  t/db_dependent/Auth.t was
tweaked to add a check for confirming that get_template_and_user
adds OPACBaseURL to both OPAC and Staff templates.

In the staff client, once the OPACBaseURL is set, you get a nice
OPAC View link when viewing a biblio's detail. It should reflect
the protocol used now.

Hard coded 'http://' strings were removed from the
sample_notices.sql files. This is what required also updating
the letters table in the updatedatabase.pl script.

The explanation text in the sysprefs.sql needed updating too to
reflect the inclusion of the protocol. And this was the other
update done in the updatedatabase.pl script. The opac.pref file
was similarly changed as well.

catalogue/detail.pl had no need to pass a custom OpacUrl value,
since C4/Auth passes the required OPACBaseURL, so it and the
corresponding template were modified.

Both the MARC21 and NORMARC intranet details files had 'http://'
hard coded in them. This was removed.

Both the bootstrap and prog theme opac-detail template had a
protocol parameter that was used. The logic for the parameter
was not removed, because it is used extensively in one template.
Perhaps it should be used to simplify the other. However, the
calculated current_url parameter had references to the protocol
removed, because of the changes to OPACBaseURL.

opac/opac-shareshelf.pl had a hard coded 'http://' which was
removed.

t/db_dependent/Auth_with_cas.t had 'http://' added to the value
set for OPACBaseURL.

In virtualshelves/sendshelf.pl explicit code which sent the
OPACBaseURL preference was removed, since C4/Auth sends it all
the time now.

C4::Context::set_preference was tweaked to ensure that
OPACBaseURL would always start with http.
t/db_dependent/Context.t was tweaked to specifically test this.

The Shibboleth authentication needs OPACBaseURL set, and that
it be https protocol. The _get_uri routine was tweaked to always
pass back https:// as the protocol on the OPACBaseURL.
t/Auth_with_shibboleth.t was tweaked to specifically test the
changes.

TEST PLAN
-
This is not an easy patch to test. Difficulties include:
- configuring Koha to run under https
(tweaking apache2 isn't so hard, just tricky)
- configuring Koha to run OPAC and Staff with Plak
(since code with comments about plak were sliced out)
- configuring Koha to use CAS
(may be requires for the CAS test)

 1) Apply patch
 2) Make sure OPACBaseURL is set without the protocol included.

UPDATEDATABASE
 3) back up your DB
 4) ./installer/data/mysql/updatedatabase.pl
-- It should run without errors.
 5) Look up the OPACBaseURL system preference in the staff
client
-- It should have http:// prepended.
 6) Run the mysqlclient from your koha git directory
  USE koha_library;
  SELECT content FROM letter WHERE content LIKE %OPACBaseURL%;
-- There should be no prepended http:// on the
   OPACBaseURL.
 7) restore your DB
 8) Make sure OPACBaseURL is set with the protocol included,
preferably https.
-- Using https requires a bunch of apache2 tweaks.

AUTH
 9) Call up staff client.
10) Call up OPAC.
-- C4/Auth.pm doesn't barf.
11) Call up Plack staff client
12) Call up Plack OPAC.
-- C4/Auth.pm doesn't barf.
13) prove -v t/db_dependent/Auth.t

CONTEXT
14) Home - Koha administration - Global System Preferences
 - OPAC
15) Modify and save OPACBaseURL to not have http:// or https://
on it.
-- It should be modified to include http://
16) Modify and save another system preference.
-- It should save normally
17) prove -v t/db_dependent/Context.t

CATALOGUE/DETAIL (tt  pl)
18) Confirm the OPACBaseURL is set
19) Navigate to any biblio details in the staff client
-- There should be a OPAC view link which has the
   correct http:// or https:// in it.

SQL (sample notices and sysprefs)
20) Run the mysqlclient from your koha git directory
  USE koha_library;
  DELETE FROM letter;
  source installer/data/mysql/de-DE/mandatory/sample_notices.sql;
  SELECT content FROM letter WHERE content LIKE %OPACBaseURL%;
  DELETE FROM letter;
  source installer/data/mysql/en/mandatory/sample_notices.sql;
  SELECT 

[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #39009|0   |1
is obsolete||

--- Comment #100 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 39087
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39087action=edit
[SIGNED-OFF] Bug 5010: Fix - replace tab with spaces

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
No errors.

Tested what I can, not plack/shibboleth/cas

Perhaps this can pass and we can fix any problem later (for 3.22)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14185] Noisy warns in opac-readingrecord.pl

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14185

--- Comment #3 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 39111
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39111
Bug 14185: Undefined $limit causes warn in opac/opac-readingrecord.pl

Review of attachment 39111:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=14185attachment=39111)
-

::: opac/opac-readingrecord.pl
@@ +73,4 @@
  
  
  my $limit = $query-param('limit');
 +$limit //= '';

This works, but why not add // '' to line 75?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14192] New: Noisy warns in Koha/XSLT_Handler.pm

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14192

Bug ID: 14192
   Summary: Noisy warns in Koha/XSLT_Handler.pm
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

Module isn't locating XSLT file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1811] Zebra search stops working with Zebra 2.0.26

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1811

Rupesh kabra roopka...@gmail.com changed:

   What|Removed |Added

 CC||roopka...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14185] Noisy warns in opac-readingrecord.pl

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14185

--- Comment #4 from Aleisha Amohia aleishaamo...@hotmail.com ---
(In reply to M. Tompsett from comment #3)
 Comment on attachment 39111 [details] [review]
 Bug 14185: Undefined $limit causes warn in opac/opac-readingrecord.pl
 
 Review of attachment 39111 [details] [review]:
 -
 
 ::: opac/opac-readingrecord.pl
 @@ +73,4 @@
   
   
   my $limit = $query-param('limit');
  +$limit //= '';
 
 This works, but why not add // '' to line 75?

I'm still very new to perl and had seen this warn solved this way before so
just did it again. Of course if you think your way is cleaner then do that!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181

--- Comment #6 from Winona Salesky wsale...@gmail.com ---
Great! Thanks,
-Winona

(In reply to Indranil Das Gupta from comment #5)
 (In reply to Winona Salesky from comment #4)
  I believe that coding ind1=0 is to suppress the display, 1 to display, and
  blank is just a default value. According to my understanding of the LOC
  rules indicate the element should be displayed as the default, or unless
  expressly  coded as 0.
 
 I discussed this with Galen Charlton, after I asked the question here. He
 agrees with the idea of you patch and said that should be default behavior
 if not set to 0.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4502] Perl error in acq budget planning

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #37354|0   |1
is obsolete||

--- Comment #15 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 39081
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39081action=edit
[SIGNED-OFF] Bug 4502: Catch software error if no active budget defined

TEST PLAN
-
0) Back up your database.
1) In mysql client:
DROP DATABASE {your koha database name};
CREATE DATABASE {your koha database name};
QUIT;
2) Go to the staff client, and install all the default
   and optional things -- except patrons. :)
3) Log into staff client.
4) Create a patron - New Patron - Staff
5) Enter data and Save
6) More - Set Permissions
7) Make superlibrarian
8) Log out
9) Log in as new superlibrarian
10) Acquisitions - Budgets - New Budget
11) Enter a non-active budget with some funds.
-- Once saved, it should list in the inactive budgets.
12) Click on the name.
13) Click on one of the Planning submenu options.
14) Click the 'Submit' button in the Filter area.
-- This should trigger the blow up.
15) Apply the patch
16) Repeat steps 12-15
-- The kaboom is avoided and a nice message given.

NOTE: This does not solve all the problems in this ugly, ugly
  module area. It does solve the one thing it is meant to:
  that nasty kaboom.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4502] Perl error in acq budget planning

2015-05-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #37534|0   |1
is obsolete||

--- Comment #17 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 39083
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39083action=edit
[SIGNED-OFF] Bug 4502: Catch software error if no active budget defined

TEST PLAN
-
0) Back up your database.
1) In mysql client:
DROP DATABASE {your koha database name};
CREATE DATABASE {your koha database name};
QUIT;
2) Go to the staff client, and install all the default
   and optional things -- except patrons. :)
3) Log into staff client.
4) Create a patron - New Patron - Staff
5) Enter data and Save
6) More - Set Permissions
7) Make superlibrarian
8) Log out
9) Log in as new superlibrarian
10) Acquisitions - Budgets - New Budget
11) Enter a non-active budget with some funds.
-- Once saved, it should list in the inactive budgets.
12) Click on the name.
13) Click on one of the Planning submenu options.
14) Click the 'Submit' button in the Filter area.
-- This should trigger the blow up.
15) Apply the patch
16) Repeat steps 12-15
-- The kaboom is avoided and a nice message given.

NOTE: This does not solve all the problems in this ugly, ugly
  module area. It does solve the one thing it is meant to:
  that nasty kaboom.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >