[Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Patch doesn't apply

--- Comment #14 from Tomás Cohen Arazi tomasco...@gmail.com ---
Please rebase for inclusion ASAP.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #2 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Marc, you still see those messages?
On current master (aa8bd7a Koha 3.20 beta) I see no messages at all

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14202] Unexpected parameter for window.open in marc21_linking_section plugin

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14202

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13437

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13822] Patron autocomplete search is severly limited

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11368] Add script to import Lexile scores

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368

--- Comment #7 from Kyle M Hall k...@bywatersolutions.com ---

 0) The QA script fails:
 
  FAIL misc/migration_tools/import_lexile.pl
FAIL critic
   I/O layer :utf8 used at line 39, column 1. Use 
 :encoding(UTF-8) to get
 strict validation.
FAIL forbidden patterns
   forbidden pattern: Koha is now under the GPLv3 license (line 9)
OK   pod
OK   valid

Will fix!

 1) Is copyright 2013 correct?

Will fix!
 
 2) I am not sure what one of the options means from the description, could
 you clarify?
 +--source-value  Defines the value to put stored in the Source
 subfield ( default: Lexile )

Please take a look at http://www.loc.gov/marc/bibliographic/bd521.html

Basically, 521 fields can store all types of target audience data. 521$a stores
the 'rating' while 521$b stores the type of the rating. In this case, the
rating is a Lexile score.

 3) The documentation for --file says: acquired from Lexile.com, but the
 actual file format is not documented. I think maybe we need to decide here
 if this is a vendor specific or a general purpose script. If it's vendor
 specific, we might want to reflect that more clearly in the file name and
 description. If it's general purpose, we should include notes about the file
 format to make this easier to reuse.

I'll add the file format to the help. This is meant specifically for importing
Lexile.com files ( as they own and control Lexile rankings ) but this script is
general purpose enough to import any CSV file that matches the schema.

 
 4) We didn't really finish our discussions about the standard options for
 CLI scripts
 (http://wiki.koha-community.org/wiki/Coding_Guidelines#Command-
 line_argument_conventions), but maybe this should have a -c for confirming
 the action as it's going to change data?

I'll add the -c and -t options.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11368] Add script to import Lexile scores

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #36438|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39182
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39182action=edit
Bug 11368 - Add script to import Lexile scores

Koha needs a script to automate the importing of Lexile score data for
titles that have available scores but are not currently in the title's
record.

This script will take a CSV file of Lexile scores, and locate any
matching records in the Koha database ( by ISBN ). If the record already
has a score, it will be updated. If not, the Lexile score field will be
created.

Test Plan:
1) Apply this patch
2) Catalog a record for each of the following ISBNs:
   0789170191
   9780673779410
3) Download the file LexileTitlesTruncated.txt attached
   to this bug report
4) Run the script from the command line:
   ./misc/migraction_tools/import_lexile.pl -v --file
/path/to/LexileTitlesTruncated.txt
5) View those records in Koha
6) Note those records now have valid Lexile scores
7) Edit the Lexile score ( 521$a ) and change the value to something else
8) Repeat step 4
9) Note the original Lexile score has been restored

Signed-off-by: Mirko Tietgen mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11368] Add script to import Lexile scores

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368

--- Comment #9 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39183
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39183action=edit
Bug 11368 [QA Followup]

* Fix QA failures
* Fix copyright
* Add file format documentation
* Add -c --confirm option
* Add -t --test option
* Add -h --help option

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11368] Add script to import Lexile scores

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14202

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11115] Pull help files from the manual

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

   Assignee|testo...@bugs.koha-communit |indr...@gmail.com
   |y.org   |
 CC||indr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14202] New: Unexpected parameter for window.open in marc21_linking_section plugin

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14202

Bug ID: 14202
   Summary: Unexpected parameter for window.open in
marc21_linking_section plugin
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Code contains:

window.open(\/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=marc21_linking_section.plindex=\
+ i +
\result=\+defaultvalue,\marc21_field_7\+i+\\,'width=900,height=700,toolbar=false,scrollbars=yes');

The part ,\marc21_field_7\+i+\\, is somewhat unexpected.
If I am correct, js could interpret this as the name parameter of window.open.
Note that this name is not the title.

I propose to remove it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14160] typo in AddressFormat preference

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14160

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Nicole!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13822] Patron autocomplete search is severly limited

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #16 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Kyle!

tatus: Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity'

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8994] Make FindDuplicateAuthority behaviour customizable

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8994

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #7 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
I fixed conflicts to test, also loaded a bunch of auths.

But... how is this supposed to be tested?

For now, does not apply. 
But give me a test plan and I will upload a fixed patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437

--- Comment #9 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 39184
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39184action=edit
Bug 13437: Replace javascript function parameter in builder

The builder contains js functions with a parameter like subfield_managed
or i or something similar. This parameter contains the html id of the
field corresponding with the plugin.
With the functionality of Koha::FrameworkPlugin in place, we can eliminate
one js function call and get the same id via the event passed in. Note
that this actually makes the function a 'real' event handler.

Also note that in many cases this parameter was not used but the id
was borrowed from a perl variable like $params-{id}. If the field is not
cloned, this is not a problem. But some fields can be cloned and should
not use the static perl value but should get it from the event.

Test plan:
Look for js errors when loading the marc editor.
Since the Focus or Click event code has been touched for most marc21
plugins, move your cursor into the field or click on the tag editor
button. Verify that the focus event updates the correct field or the
click event correctly launches the plugin AND the value comes back into
the right field.
Bonus: Attach a plugin with popup (like leader) to 040$d. Clone this field.
Verify that the two launch buttons operate on the correct value.
(This resolves a current bug.)

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
Checked all 15 plugins.
Plugin marc21_linking_section seems to work, but I could not get it to pass
back something useful into my field. (Same without this patch.)
Tested the clone button with leader on 040d.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076

--- Comment #3 from M. Tompsett mtomp...@hotmail.com ---
(In reply to Bernardo Gonzalez Kriegel from comment #2)
 Marc, you still see those messages?
 On current master (aa8bd7a Koha 3.20 beta) I see no messages at all

Greetings, I do. I should have also mentioned. This will require Apache 2.4.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12461] Add patron clubs feature

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #38748|0   |1
is obsolete||

--- Comment #13 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39181
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39181action=edit
Bug 12461 - Add patron clubs feature

This features would add the ability to create clubs which patrons may be
enrolled in. It would be particularly useful for tracking summer reading
programs, book clubs and other such clubs.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Ensure your staff user has the new 'Patron clubs' permissions
4) Under the tools menu, click the Patron clubs link
5) Create a new club template
   * Here you can add fields that can be filled out at the time
 a new club is created based on the template, or a new enrollment
 is created for a given club based on the template.
6) Create a new club based on that template
7) Attempt to enroll a patron in that club
8) Create a club with email required set
9) Attempt to enroll a patron without an email address in that club
10) Create a club that is enrollable from the OPAC
11) Attempt to enroll a patron in that club
12) Attempt to cancel a club enrollment from the OPAC
13) Attempt to cancel a club enrollment from the staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12461] Add patron clubs feature

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #10 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Ready for signoff.
This patch set can go on its own. The see also reports may bring some later
refinements, but are not needed right now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Jonathan!

tatus: Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14147] Add unit tests to C4::External::OverDrive

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14147

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14160] typo in AddressFormat preference

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14160

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006

--- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 39186
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39186action=edit
Bug 11006: (RM followup) DBIx updates

Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13421] Add the creation time for virtual shelves

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13421

--- Comment #13 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 39185
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39185action=edit
Bug 13421: (RM followup) DBIx updates

Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076

--- Comment #4 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
(In reply to M. Tompsett from comment #3)
...
 Greetings, I do. I should have also mentioned. This will require Apache 2.4.

Ah! I have 2.2, will try in another machine

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #8 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13969] Testing C4::Review

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #17 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Thanks Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11849] consolidate display of analytic/bound-with analytic item links

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11849

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|consolidate display of  |consolidate display of
   |analytic/bound-width|analytic/bound-with
   |analytic item links |analytic item links

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11576] Untranslatable manage in serials-collection

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #39145|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 39187
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39187action=edit
[PASSED QA] Bug 14194: Restore the HH:MM to 23:59 for onsite-checkouts

(Introduced by bug 13601)

Test plan
=
1/ enable 'OnSiteCheckouts' pref under Circulation Preferences
2/ go to the checkouts page and try to issue an item to any user.
3/ when the item barcode entry form shows, select the 'On-site
   checkout' checkbox
4/ the default date due should show as today with 00:00 as HH:MM
5/ apply the patch
6/ repeat steps 2 - 3. The default date due should show today's
   date with 23:59 as HH:MM.
7/ run koha-qa.pl -c 1 -v 2

Remarks: Testing result match expected test plan output. The QA tests
 pass with OK for the commit.

Technical note: There is a confusion with iso and sql date formats at
some places in the code.
A better way should be provided (later) to fix globally the mismatch
between these 2 formats.
What happened before this patch: the DateTime was cast to a string and
the template received -MM-DDTHH:MM:SS which is an iso formatted
date. BUT this format is not managed by Koha::DateUtils::output_pref
(iso and sql are considered as indentical which is wrong).
As I did not estimated the problem (how big it is) I prefer to fix it
easily (and dirty) for now.

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) indr...@gmail.com

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14072] Update German web installer for 3.20

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14072

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14072] Update German web installer for 3.20

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14072

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14072] Update German web installer for 3.20

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14072

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #39190|0   |1
is obsolete||

--- Comment #2 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 39191
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39191action=edit
[SIGNED-OFF] Bug 14072: Update German web installer for 3.20

- translates new notice ACQ_NOTIF_ON_RECEIV
- translates new permissions

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Tested German install till Gratulation, die Installation ist abgeschlossen
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14072] Update German web installer for 3.20

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14072

--- Comment #3 from Indranil Das Gupta indr...@gmail.com ---
Created attachment 39192
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39192action=edit
Bug 14072: Update German web installer for 3.20

- translates new notice ACQ_NOTIF_ON_RECEIV
- translates new permissions

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Tested German install till Gratulation, die Installation ist abgeschlossen
No errors

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) indr...@gmail.com
Same results noted as above.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437

--- Comment #15 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Second patch slightly adjusted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437

--- Comment #13 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 39195
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39195action=edit
Bug 13437: Conversion of marc21 cataloguing plugins to new style

This patch converts marc21 plugins to new style by making the following
modifications:

[1] Replace use strict with use Modern::Perl. This implies that we now
re-enabled warnings. There are no redefine warnings anymore, but note that
we need to silence some warnings from individual plugins that were covered
by disabling the warnings pragma until now. Silencing these individual
warnings is outside the scope of this report.
[2] Sub plugin_javascript is replaced by an anonymous subroutine $builder.
[3] The parameters of $builder are combined in a params hashref. In most
cases we only need $params-{id} for the function name.
[4] Javascript function Clicxxx is renamed to Clickxxx.
[5] The builder does no longer return function_name.
[6] Sub plugin is replaced by subroutine $launcher.
[7] The parameters of $launcher are combined in a params hashref. We only
use $params-{cgi}. Mostly we save that to $input. One exception: $query.
[8] The plugins returns a hash with $builder and/or $launcher.

Test plan:
[1] Run t/db_dependent/FrameworkPlugin.t -incl cataloguing/value_builder/
marc21*.pl. This should catch compile errors and general problems when
building or launching these plugins.
NOTE: You will see several initialize warnings from individual plugins that
were hidden until now by disabling warnings. This is fine; we will be
able to address these warnings now on new reports.
[2] Check behavior of several plugins in the marc editor.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
Checked all marc21 plugins. Attached unused plugins to some field.
Some plugins (unused by default) may need some further attention, but
also outside the scope of this report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14072] Update German web installer for 3.20

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14072

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 CC||indr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14150] Field issues.date_due does not display in ISSUESLIP or ISSUEQSLIP

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14150

Christopher Brannon cbran...@cdalibrary.org changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #2 from Christopher Brannon cbran...@cdalibrary.org ---
Barton,
Does this affect only those two slips, or does it affect any notices as well?

Christopher

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14162] Instance creation information on YAML

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14162

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 CC||indr...@gmail.com
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12824

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14200] GetNormalizedISBN failing to normalize valid ISBNs in some cases

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14200] GetNormalizedISBN failing to normalize valid ISBNs in some cases

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #39178|0   |1
is obsolete||
  Attachment #39179|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39197
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39197action=edit
[SIGNED-OFF] Bug 14200 - Unit Tests

Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Karen Bryant kbry...@ccpl-fl.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14200] GetNormalizedISBN failing to normalize valid ISBNs in some cases

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200

--- Comment #4 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39198
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39198action=edit
[SIGNED-OFF] Bug 14200 - GetNormalizedISBN failing to normalize valid ISBNs in
some cases

For some reason the regular expression used to split the multiple ISBN
fields can fail which keeps Business::ISBN from being able to parse out
and return a valid isbn. Using split() instead of the regex fixes the
issue.

Test Plan:
1) Apply the unit test patch first
2) prove t/Koha.t
3) Note the failures
4) Apply the second patch
5) prove t/Koha.t
6) Note all tests pass

Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Karen Bryant kbry...@ccpl-fl.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195

--- Comment #4 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 39201
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39201action=edit
Bug 14195: (followup) increment number of tests

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #39138|0   |1
is obsolete||

--- Comment #3 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 39200
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39200action=edit
[SIGNED-OFF] Bug 14195: TestBuilder - A random string should not be longer than
the DB field

t::lib::TestBuilder::_gen_text does not use correctly the regex and the
max parameter to generate the random string (String::Random).

This can cause future tests to fail.

http://bugs.koha-community.org/show_bug.cgi?id=14195
Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

Script tested, problem occurs, patch fixes it.
Bad number on commit subject
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12824] Create a general purpose koha-config script?

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12824

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14162

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5534] koha does not ignore punctuation when searching

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5534

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

 CC||n...@quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5534] koha does not ignore punctuation when searching

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5534

Christopher Brannon cbran...@cdalibrary.org changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #9 from Christopher Brannon cbran...@cdalibrary.org ---
We're seeing this when we do searches between the word don't and dont. 
This is a real, ongoing problem.  I'm wondering if there is anything that can
be done outside of waiting for ElasticSearch?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5534] koha does not ignore punctuation when searching

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5534

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #10 from Tomás Cohen Arazi tomasco...@gmail.com ---
We should fix this taking advantage of DOM: i.e. generating indexes for the
strings with punctuation removed. It could be tricky in some scenarios, but it
should work.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10299] authorities plugin putting values in reverse order

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10299

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10299] authorities plugin putting values in reverse order

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10299

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #37960|0   |1
is obsolete||

--- Comment #4 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 39199
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39199action=edit
[SIGNED-OFF] Bug 10299: authority plugin - authority field are reversed

If you click the plugin next to an authority field that is already
populated it takes the values from the field and puts them in the search
in the reverse order.

Test plan:
1/ Edit a biblio
2/ Fill the subfield for an authority field (for instance 650$v, 650$x,
650$y, etc.)
3/ Click on the authority plugin
Before this patch, the values were concatenated in the reverse order.
With this patch, it should not.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Work as described, no koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11368] Add script to import Lexile scores

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368

--- Comment #10 from Mirko Tietgen mi...@abunchofthings.net ---
(In reply to Katrin Fischer from comment #6)

 If it's vendor
 specific, we might want to reflect that more clearly in the file name and
 description. If it's general purpose, we should include notes about the file
 format to make this easier to reuse.

I thought about broadening the scope of the script when I signed off on the
patch, checking with the table for Antolin (German reading platform with
quizzes for school kids, run by a publisher).

I don't think it's feasible to guess all possible fields and options that may
occur in such lists, and given the non-standardized nature of these things, you
never know if a format will change at some point.

It is easily possible to tweak the script if you know what you need, so I'd say
keeping it vendor specific and having more vendor specific scripts of this
nature if needed makes sense. This patch is a good starting point for similar
tasks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437

--- Comment #12 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 39194
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39194action=edit
Bug 13437: Trivial edits on marc21 plugins before conversion

marc21_field_003.pl: copy-pasta comment about date removed
marc21_field_005.pl: commented use removed
marc21_field_006.pl: old/irrelevant pod lines
marc21_field_007.pl: old/irrelevant pod lines
marc21_field_008.pl: old/irrelevant pod lines, move sub par line twice
marc21_field_008_authorities.pl: whitespace, old/irrelevant pod lines
marc21_field_040c.pl: two commented lines removed
marc21_field_040d.pl: whitespace, commented lines, old/irrelevant pod
marc21_field_245h.pl: whitespace

marc21_linking_section.pl: relocated some comment lines, and replaced a new
CGI object by the one passed in via the plugin launcher (agreed, this may
not be so trivial as the other changes)

Test plan:
These (trivial) changes are hard to test.
Pick a few plugins and verify that behavior is not changed in the marc
editor.
For the brave: Try marc21_linking_section.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437

--- Comment #14 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 39196
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39196action=edit
Bug 13437: Replace javascript function parameter in builder

The builder contains js functions with a parameter like subfield_managed
or i or something similar. This parameter contains the html id of the
field corresponding with the plugin.
With the functionality of Koha::FrameworkPlugin in place, we can eliminate
one js function call and get the same id via the event passed in. Note
that this actually makes the function a 'real' event handler.

Also note that in many cases this parameter was not used but the id
was borrowed from a perl variable like $params-{id}. If the field is not
cloned, this is not a problem. But some fields can be cloned and should
not use the static perl value but should get it from the event.

Test plan:
Look for js errors when loading the marc editor.
Since the Focus or Click event code has been touched for most marc21
plugins, move your cursor into the field or click on the tag editor
button. Verify that the focus event updates the correct field or the
click event correctly launches the plugin AND the value comes back into
the right field.
Bonus: Attach a plugin with popup (like leader) to 040$d. Clone this field.
Verify that the two launch buttons operate on the correct value.
(This resolves a current bug.)

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
Checked all 15 plugins.
Plugin marc21_linking_section seems to work, but I could not get it to pass
back something useful into my field. (Same without this patch.)
Tested the clone button with leader on 040d.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #39141|0   |1
is obsolete||
  Attachment #39142|0   |1
is obsolete||
  Attachment #39177|0   |1
is obsolete||
  Attachment #39184|0   |1
is obsolete||

--- Comment #11 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 39193
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39193action=edit
Bug 13437: Preliminary changes for marc21 plugins field 008

Preliminary work on marc21_field_008.pl and 008_authorities.pl.
Moving $dateentered en $defaultval to lower scope level.
date_entered is a new sub (in a module); sub Field008 has been reduced to
one line.
Added a trivial unit test for date_entered.
Note: the format used in date_entered could be added in DateUtils, moving
this logic to a better place.

Test plan:
Use both plugins in the marc21 editor (biblios/authorities).
Run the adjusted unit test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14180] Make Always show checkouts immediately a global setting

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 CC||indr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

--- Comment #17 from M. Tompsett mtomp...@hotmail.com ---
Fixed conflict, retested, reset back to Passed QA.
(*grumbles about commas and white space making things conflict so easily*)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10235] Koha's syspref search fails to find 'local' sysprefs

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10235

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14132] suggestions table is missing indexes

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #12 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Thanks Frido!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|In Discussion   |ASSIGNED

--- Comment #60 from Nicole C. Engard neng...@gmail.com ---
Removing in discussion as it seems we can maybe get this in now? It's a big big
deal to track what was ordered/deleted for reorder and accounting purposes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #20 from Tomás Cohen Arazi tomasco...@gmail.com ---
Parches aplicados en master.

Gracias Bernardo!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14077] Remove unused AUTH_UPDATE_FAILED from moremember.tt

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12461] Add patron clubs feature

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #14 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Almost all tested, looks good.
But reloading kohastructure with your patch applied, gives

mysql kohadev   ~/kohaclone/installer/data/mysql/kohastructure.sql
ERROR 1005 (HY000) at line 3656: Can't create table 'kohadev.#sql-42d1_401'
(errno: 150)

Can't understand or find the error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #18 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Thanks Jonathan and Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14072] Update German web installer for 3.20

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14072

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14072] Update German web installer for 3.20

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14072

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 39190
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39190action=edit
Bug 14072: Update German web installer for 3.20

- translates new notice ACQ_NOTIF_ON_RECEIV
- translates new permissions

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #240 from Katrin Fischer katrin.fisc...@bsz-bw.de ---

 with OPACprivacy disabled and
 AllowPatronToSetCheckoutsVisibilityForGuarantor enabled a patron can see
 their guarantor but cannot save changes to whether their checkouts are
 shown.  The update button doesn't work and a change to this field doesn't
 register if using the submit update request button

Should this be failed QA?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14074] 'suggested on' date on suggestion list not correctly formatted

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14074

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #9 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13910] Prevent delete of one's own patron account

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #13 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067

--- Comment #15 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 39188
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39188action=edit
Bug 9067: Hide item related strings when importing staged authority records

On importing authority records, the items related string should not be
displayed.

Test plan:
1/ Import an authority record
2/ Confirm the item related string are not displayed.
3/ Before this script, the record_type param was lost just after
importing the records. Now you should see
Processing authority records of Processing bibliographic records in
the MARC staging results
4/ Revert the import and check there is not item related strings.

No behavior should exist on importing bibliographic records.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #38630|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #38631|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067

--- Comment #16 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 39189
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39189action=edit
Bug 9067 - Fix space

There was a [ % END %] which triggered template parsing errors.
Follow the test plan in comment #7 with both patches applied.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14203] koha-translate error string for non-existent lang removal

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203

--- Comment #1 from Indranil Das Gupta indr...@gmail.com ---
Created attachment 39202
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39202action=edit
Bug 14203 - Message for non-existent lang removal

A trivial string patch to update the error message displayed to
user if koha-translate is used to attempt removal of a language
that is not installed.

Test plan
=

1/ attempt to remove a non-existent language by
   installdir/debian/scripts/koha-translate --remove langcode
2/ it should show Error: the selected language is not already
   installed.
3/ apply patch
4/ repeat step 1; it should show Error: the selected language is
   not installed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14204] Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14204] Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|n...@quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13610] delete_patrons.pl crashes on debian squeeze

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13610

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Can this be closed?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14162] Instance creation information on YAML

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14162

--- Comment #3 from Tomás Cohen Arazi tomasco...@gmail.com ---
(In reply to Indranil Das Gupta from comment #2)
 (In reply to Indranil Das Gupta from comment #1)
  (In reply to Tomás Cohen Arazi from comment #0)
   It would be handy to have information about instance creation on a YAML
   file. It could serve for recreating an instance, for creating it, etc.
  
 
 That should read as
 
  Something on similar lines:
  
  Bug 12824, comment 0 by Magnus
  
  Bug 12824, comment 4 by Robin

They are related, but talk about different things. Because a cli tool for
manipulating the instance's koha-conf.xml file is one thing, and a registry of
how instances were created is another one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13929] opac description not showing on search results for authorized values

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13929

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14162] Instance creation information on YAML

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14162

--- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com ---
(In reply to Indranil Das Gupta from comment #4)
 (In reply to Tomás Cohen Arazi from comment #3)
  (In reply to Indranil Das Gupta from comment #2)
 snipped 
  They are related, but talk about different things. Because a cli tool for
  manipulating the instance's koha-conf.xml file is one thing, and a registry
  of how instances were created is another one.
 
 You are right! So more like a YAML based install log that can
 cross-checked / replayed etc?

Yeah, so better upgrade path for packages too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14162] Instance creation information on YAML

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14162

--- Comment #1 from Indranil Das Gupta indr...@gmail.com ---
(In reply to Tomás Cohen Arazi from comment #0)
 It would be handy to have information about instance creation on a YAML
 file. It could serve for recreating an instance, for creating it, etc.

Something on similar lines:

Bug 12824, comment 4 by Magnus

Bug 12824, comment 4 by Robin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14203] New: koha-translate error string for non-existent lang removal

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203

Bug ID: 14203
   Summary: koha-translate error string for non-existent lang
removal
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: indr...@gmail.com
  Reporter: indr...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: tomasco...@gmail.com

An attempt to remove a language that is not installed shows the message:

Error: the selected language is not already installed.

I feel that it will be nicer to just have Error: the selected language is not
installed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14203] koha-translate error string for non-existent lang removal

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14162] Instance creation information on YAML

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14162

--- Comment #4 from Indranil Das Gupta indr...@gmail.com ---
(In reply to Tomás Cohen Arazi from comment #3)
 (In reply to Indranil Das Gupta from comment #2)
snipped 
 They are related, but talk about different things. Because a cli tool for
 manipulating the instance's koha-conf.xml file is one thing, and a registry
 of how instances were created is another one.

You are right! So more like a YAML based install log that can cross-checked /
replayed etc?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14204] New: Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204

Bug ID: 14204
   Summary: Fix t/db_dependent/Labels/t_Batch.t failing test from
Bug 12991
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: n...@quecheelibrary.org
QA Contact: gmcha...@gmail.com

Bug 12991 altered the creation of label batches such that the batch_id is set
at 0 until items are added.  The variable in the tests was set at batch
creation and not updated after items were added to test batch and this led to
failing tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14204] Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14204] Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204

--- Comment #1 from Nick Clemens n...@quecheelibrary.org ---
Created attachment 39203
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39203action=edit
Bug 14204 - Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991

This patch updaes the batch_id variable after items are added to test batch

To test:
1. prove t/db_dependent/Labels/t_Batch.t and see two tests fail
2. apply patch
3. prove again, tests pass!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14203] koha-translate error string for non-existent lang removal

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

  Attachment #39202|0   |1
is obsolete||

--- Comment #2 from Nick Clemens n...@quecheelibrary.org ---
Created attachment 39204
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39204action=edit
[SIGNED OFF] Bug 14203 - Message for non-existent lang removal

A trivial string patch to update the error message displayed to
user if koha-translate is used to attempt removal of a language
that is not installed.

Test plan
=

1/ attempt to remove a non-existent language by
   installdir/debian/scripts/koha-translate --remove langcode
2/ it should show Error: the selected language is not already
   installed.
3/ apply patch
4/ repeat step 1; it should show Error: the selected language is
   not installed.

Signed-off-by: Nick Clemens n...@quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14203] koha-translate error string for non-existent lang removal

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14070] Notice not saved when mandatory fields are not filled

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14070

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 CC||indr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14162] Instance creation information on YAML

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14162

--- Comment #2 from Indranil Das Gupta indr...@gmail.com ---
(In reply to Indranil Das Gupta from comment #1)
 (In reply to Tomás Cohen Arazi from comment #0)
  It would be handy to have information about instance creation on a YAML
  file. It could serve for recreating an instance, for creating it, etc.
 

That should read as

 Something on similar lines:

 Bug 12824, comment 0 by Magnus

 Bug 12824, comment 4 by Robin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12824] Create a general purpose koha-config script?

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12824

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than any

2015-05-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

   Assignee|mathsaby...@gmail.com   |gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >