[Koha-bugs] [Bug 14256] Tests for TestBuilder fail randomly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14256 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #39789|0 |1 is obsolete|| --- Comment #13 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 39824 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39824action=edit Bug 14256: (followup) check for unique constrainta to regenerate random data Unique constraints should be checked when creating random data. Otherwise we get failures when the generated data already exists on the DB. This patch takes advantage of -unique_constraints() to do the job, looping through all the unique constraints defined for the source. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14256] Tests for TestBuilder fail randomly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14256 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14256] Tests for TestBuilder fail randomly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14256
--- Comment #15 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 39825
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39825
Bug 14256: (followup) check for unique constrainta to regenerate random data
Review of attachment 39825:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=14256attachment=39825)
-
::: t/lib/TestBuilder.pm
@@ +192,5 @@
+}
+
+my $count = $self-schema
+ -resultset( $source )
+ -search( $condition )
Making the changes suggested in comment #1 sometimes triggers a KABOOM here,
because condition is not right somehow. I think something goes wrong with the
building loop above. { ARRAY = undef }?!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8007] Discharge management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007
--- Comment #123 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 37034
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37034
[PASSED QA] Bug 8007: Discharge - Add unit tests
Review of attachment 37034:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=8007attachment=37034)
-
::: t/db_dependent/Borrower_Discharge.t
@@ +18,5 @@
+
+$dbh-do(q|DELETE FROM discharges|);
+
+C4::Context-_new_userenv('xxx');
+C4::Context::set_userenv(0, 0, 0, 'firstname', 'surname', 'CPL', 'CPL', '',
'', '');
This was pushed after bug 10900. Creating another report to correct this.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Attachment #39811|0 |1 is obsolete|| --- Comment #249 from Nick Clemens n...@quecheelibrary.org --- Created attachment 39823 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39823action=edit Bug 9303 [QA Followup] - Restore missing svc script Signed-off-by: Nick Clemens n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Attachment #39045|0 |1 is obsolete|| --- Comment #246 from Nick Clemens n...@quecheelibrary.org --- Created attachment 39820 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39820action=edit Bug 9303 [QA Followup] - Remove extra 'USE Koha', change Call number back to Call no. Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com Signed-off-by: Nick Clemens n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Attachment #39044|0 |1 is obsolete|| --- Comment #245 from Nick Clemens n...@quecheelibrary.org --- Created attachment 39819 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39819action=edit Bug 9303 [3] - relative's checkouts in the opac Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com Signed-off-by: Nick Clemens n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Attachment #39042|0 |1 is obsolete|| --- Comment #243 from Nick Clemens n...@quecheelibrary.org --- Created attachment 39817 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39817action=edit Bug 9303 [1] - relative's checkouts in the opac - Database Updates This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to my privacy and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a Relatives' checkouts tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com Signed-off-by: Nick Clemens n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Attachment #39043|0 |1 is obsolete|| --- Comment #244 from Nick Clemens n...@quecheelibrary.org --- Created attachment 39818 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39818action=edit Bug 9303 [2] - relative's checkouts in the opac - Schema Updates e opac/svc/patron/ Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com Signed-off-by: Nick Clemens n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Attachment #39046|0 |1 is obsolete|| --- Comment #247 from Nick Clemens n...@quecheelibrary.org --- Created attachment 39821 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39821action=edit Bug 9303 [QA Followup] - Restore missing biblio relationship Signed-off-by: Nick Clemens n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Attachment #39048|0 |1 is obsolete|| --- Comment #248 from Nick Clemens n...@quecheelibrary.org --- Created attachment 39822 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39822action=edit Bug 9303 [QA Followup] - Restore ability for patron to control setting Signed-off-by: Nick Clemens n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14325] Test calls C4::Context::set_userenv
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14325 --- Comment #1 from M. Tompsett mtomp...@hotmail.com --- Created attachment 39826 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39826action=edit Bug 14325: Test calls C4::Context::set_userenv This is a case of works by accident. This patch corrects the set_userenv call. TEST PLAN - 1) prove t/db_dependent/Borrower_Discharge.t -- works 2) git grep :set_userenv -- only this one file. 3) Confirm the the C4/Context.pm has a set_userenv which shifts the first parameter, as intended for a - call and not a :: call. 4) apply patch 5) prove t/db_dependent/Borrower_Discharge.t -- still works 6) git grep :set_userenv -- nothing now. 7) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14325] Test calls C4::Context::set_userenv
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14325 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Rémi Mayrand-Provencher remi.mayrand-provenc...@inlibro.com changed: What|Removed |Added Status|Failed QA |Needs Signoff CC||remi.mayrand-provencher@inL ||ibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14047] Sort z39.50 biblio servers by rank in derivate cataloguing doesn't work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14047] Sort z39.50 biblio servers by rank in derivate cataloguing doesn't work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #12 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14256] Tests for TestBuilder fail randomly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14256 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #39824|0 |1 is obsolete|| --- Comment #14 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 39825 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39825action=edit Bug 14256: (followup) check for unique constrainta to regenerate random data Unique constraints should be checked when creating random data. Otherwise we get failures when the generated data already exists on the DB. This patch takes advantage of -unique_constraints() to do the job, looping through all the unique constraints defined for the source. Edit: removed leftover variable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #98 from Rémi Mayrand-Provencher remi.mayrand-provenc...@inlibro.com --- Created attachment 39827 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39827action=edit Bug 8753 - Fixed the forbidden pattern error in opac-auth.tt I could only reproduce the forbidden pattern error from jonathan Druart's comment#97 locally, so I fixed it. TEST PLAN 1)Apply all patches 2)Forbidden pattern error should not be there anymore -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14256] Tests for TestBuilder fail randomly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14256 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added QA Contact|gmcha...@gmail.com |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14325] Test calls C4::Context::set_userenv
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14325 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10900 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8007] Discharge management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14325 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14325] Test calls C4::Context::set_userenv
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14325 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=8007 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14325] Test calls C4::Context::set_userenv
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14325 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14325] New: Test calls C4::Context::set_userenv
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14325 Bug ID: 14325 Summary: Test calls C4::Context::set_userenv Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: mtomp...@hotmail.com QA Contact: testo...@bugs.koha-community.org Bug 8007 added a C4::Context::set_userenv call, after bug 10900 corrected all instances to C4::Context-set_userenv calls. This will appropriately patch the test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14325 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9234] Koha's search code needs to be rewritten
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9234 Bug 9234 depends on bug 7978, which changed state. Bug 7978 Summary: Koha index-names have inconsistent CaPiTaLiSaTiOn http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7978 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7978] Koha index-names have inconsistent CaPiTaLiSaTiOn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7978 Mason James m...@kohaaloha.com changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Mason James m...@kohaaloha.com --- (In reply to Mason James from comment #0) i hope to send a patch to change all index-names to lowercase oops, i think thats an invalid bug :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198 --- Comment #11 from Héctor Eduardo Castro Avalos hector.hecax...@gmail.com --- Hi Katrine I don't know if there are another observation of your part, or if the patch is OK and Beranardo can sign-off the patch again. In advance thank you very much. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14325] Test calls C4::Context::set_userenv
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14325 --- Comment #2 from Indranil Das Gupta indr...@gmail.com --- Created attachment 39828 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39828action=edit Bug 14325: Test calls C4::Context::set_userenv This is a case of works by accident. This patch corrects the set_userenv call. TEST PLAN - 1) prove t/db_dependent/Borrower_Discharge.t -- works 2) git grep :set_userenv -- only this one file. 3) Confirm the the C4/Context.pm has a set_userenv which shifts the first parameter, as intended for a - call and not a :: call. 4) apply patch 5) prove t/db_dependent/Borrower_Discharge.t -- still works 6) git grep :set_userenv -- nothing now. 7) run koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14325] Test calls C4::Context::set_userenv
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14325 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added CC||indr...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242 Mason James m...@kohaaloha.com changed: What|Removed |Added Keywords||rel_3_16_candidate --- Comment #39 from Mason James m...@kohaaloha.com --- (In reply to Sophie MEYNIEUX from comment #38) Would it be possible to have it in 3.16.x ? Thanx oops, i missed this bug i'll take a look for the next 3.16 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14151] SIP2 Checkouts fail in Koha 3.18
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151 --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Jonathan Druart from comment #9) Maybe I missed something, but it does not work here: % perl -IC4/SIP/ -MILS C4/SIP/SIPServer.pm /home/koha/etc/SIPconfig.xml Can't locate object method new via package ILS::Patron (perhaps you forgot to load ILS::Patron?) at C4/SIP/ILS.pm line 134. Ok so forget that. Could someone confirm this can be close? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14173] Paging on 'recent comments' page in OPAC is not displaying correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14173 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Tested on master, 3.20, 3.18, 3.16 and 3.14, the bug exist on all versions and the patch fixes it! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14283] Required Devel::Cover should be Wheezy's
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14283 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #39757|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39798 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39798action=edit Bug 14283: Required Devel::Cover should be Wheezy's There's no special requirement for such a recent version of the Devel::Cover package. We have just deprecated Squeeze, so Wheezy's version should be ok. Signed-off-by: Robin Sheat ro...@catalyst.net.nz Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14283] Required Devel::Cover should be Wheezy's
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14283 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- I don't have a wheezy install to test the script. Robin, could you please confirm you have tested misc/devel/coverage.pl on wheezy? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14283] Required Devel::Cover should be Wheezy's
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14283 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14313] OPAC: Adding a comment makes result browser disappear
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14313 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #39767|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39801 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39801action=edit Bug 14313: OPAC - Adding a comment makes result browser disappear To reproduce: - Allow commenting in OPAC (Syspref reviewson) - Log in to OPAC - Do a search with many results - Click on a biblio in result list - Verify that you can browse the results in detail view (Browse results) - Repeat teh search above - Click on the same biblio as above - Add a comment (Tab Comments) - Close commenting window - Click on Next in result browser Result: The next biblio is displayed, but result browser has disappeared. To test: - Apply patch - Try to reproduce issue above, verify that result browser does no longer disappear AMended to remove whitespace chars. / MV Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Bug solution checked, works well. No koha-qa errors Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14313] OPAC: Adding a comment makes result browser disappear
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14313 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Holger Meißner h.meissner...@web.de changed: What|Removed |Added CC||fiona.borthwick@ptfs-europe ||.com --- Comment #13 from Holger Meißner h.meissner...@web.de --- *** Bug 14214 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14214] Automatic renewal to renew at end of due date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14214 Holger Meißner h.meissner...@web.de changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Holger Meißner h.meissner...@web.de --- *** This bug has been marked as a duplicate of bug 14101 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14321] New: Merge UploadedFile and UploadedFiles into Koha::Uploader
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Bug ID: 14321 Summary: Merge UploadedFile and UploadedFiles into Koha::Uploader Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org One of the main QA concerns on bug 6874 was the introduction of UploadedFiles.pm while we already have UploadedFile.pm. Recognizing the amount of work on that report, it would not be very productive to just park the development in FQA. The older module UploadedFile contains functionality for temporary uploads and has minimum test coverage; the newer module contains functionality for permanent uploads and access via hash id, and with much more unit tests. Koha::Uploader should contain the best of both: allow temporary and permanent uploads, also keeping the progress and ajax upload of the old one. Providing an object that allows for some future extensions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14283] Required Devel::Cover should be Wheezy's
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14283 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14173] Paging on 'recent comments' page in OPAC is not displaying correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14173 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14173] Paging on 'recent comments' page in OPAC is not displaying correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14173 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #39759|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39799 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39799action=edit Bug 14173: Paging on 'recent comments' page in OPAC is not displaying correctly This patch corrects the display of current page on a multipage recent comments. To test: 1) Enable OpacShowRecentComments 2) Add multiple comments to multiple records I used a script to add multiple lines like insert into reviews values ($i, 51, $i, 'Comment $i', 1, '2015-06-01 00:00:00') to table reviews 3) On OPAC, go to 'Recent comments', verify the bug 4) Apply the patch 5) Reload and check correct display Can't found missing space near 'by' from description. Display is correct for me. Followed test plan, displays as expected. Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14294] Umbrella report for tracking improvements to File upload feature (see also 6874)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14294 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14321 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Uploader
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14294 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14275] Remove CGI::scrolling_list from guided_reports.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14275 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Sent notices using several email addresses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Assignee|jonathan.dru...@biblibre.co |matthias.meusburger@biblibr |m |e.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Sent notices using several email addresses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #40 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Matthias Meusburger from comment #38) Created attachment 39770 [details] [review] Bug 12802: EnqueueLetter must retrieve at least an email (for print messages). Could you explain this patch please? The tests pass without it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #12 from Holger Meißner h.meissner...@web.de --- Created attachment 39802 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39802action=edit Table to illustrate how automatic renewals should work. To make testing easier and for documentation purposes I include a table about how the feature is supposed to work. Please let me know if you think the behavior should be altered. Note: I can't think of a use case, but negative values for 'No renewal before' work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Holger Meißner h.meissner...@web.de changed: What|Removed |Added CC||cost...@gmail.com --- Comment #14 from Holger Meißner h.meissner...@web.de --- *** Bug 14301 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14301] “No renewal before” does not accept 0 as parameter.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14301 --- Comment #6 from Holger Meißner h.meissner...@web.de --- Hi bondiurbano, I have uploaded a patch to fix the problem with bug 14101. Please test and let me know if it works for you. I also uploaded a table to illustrate how automatic renewals and 'No renewal before' work at this moment. If you have any suggestions for further changes please comment. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13219] Add graphs to guided reports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Status|Signed Off |Failed QA --- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comments: 1/ New JS lib is not added to the about page 2/ The version 1.0.2 of Chart is released (after first submission), not need to include a beta version :) 3/ If there is no result, there is no graph. But the canvas is created = 1000x400px is blank on top of the page. Moreover the button (Click to change to...) is displayed. 4/ There is no way not to hardcode the canvas size? 1000 could be too wide on small screens. 5/ Maybe it could be better to display the graph under the table (?) 6/ Commented code in js (//circChart.update();) 7/ IMO the colors should not be defined in the pl code but in tt. Moreover the get_colors subroutine is defined twice (c/p is bad ;)) Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3206] OAI repositry deleted record support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Attachment #39795|0 |1 is obsolete|| --- Comment #11 from Frédéric Demians frede...@tamil.fr --- Created attachment 39797 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39797action=edit Bug 3206: OAI repository deleted records support. This patch allows Koha OAI repository to support deleted records. The OAI-PMH:DeletedRecord syspref is introduced and can be set to: - persistent (in case Koha's deletedbiblio table will never be emptied or truncated) - transient (in case Koha's deletedbiblio table might be emptied or truncated at some point) Test plan: - After applying the patch, test that: - Deleted records appear in ListRecords and ListIdentifiers requests. - Filter parameters (from, until, set and resumptionToken) still work and are applied to ListRecords and ListIdentifiers requests. - Identify request shows if the repository is considered persistent or transient, according to the OAI-PMH:DeletedRecord syspref. - Deleted records that used to belong to a set are still displayed in those sets and marked as deleted. - GetRecord requests work on deleted records, which are marked as deleted. Requests examples: /cgi-bin/koha/oai.pl?verb=ListRecordsmetadataPrefix=oai_dc /cgi-bin/koha/oai.pl?verb=ListRecordsmetadataPrefix=oai_dcfrom=2015-02-20T11:08:33Z /cgi-bin/koha/oai.pl?verb=ListRecordsmetadataPrefix=oai_dcset=new_specSet1 /cgi-bin/koha/oai.pl?verb=GetRecordidentifier=KOHA-OAI-TEST:2metadataPrefix=oai_dc /cgi-bin/koha/oai.pl?verb=Identify Signed-off-by: Frederic Demians f.demi...@tamil.fr It works in all situations described in the test plan. Great addition. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #11 from Holger Meißner h.meissner...@web.de --- Created attachment 39800 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39800action=edit Bug 14101: Automatic renewals exactly on due date If no value for 'no renewal before' is specified, automatic renewal now falls back on the due date. Also 'no renewal before' can now be zero, so both automatic and manual renewals can be delayed until due date. Test plan: 1) Create some circulation rules with different settings for 'No renewal before' and 'Automatic renewal'. Both daily and hourly loans should work. 2) Run misc/cronjobs/automatic_renewals.pl and try to renew manually before and after a renewal should be possible. 3) Confirm that: * Both automatic and manual renewal with 'No renewal before' set to 0 do not happen before the due date (exact DateTime). * Manual renewal with 'No renewal before' set to undef (enter empty string) is unrestricted. * Automatic renewal with 'No renewal before' set to undef does not happen before the due date. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14320] New: Improve the speed of the checkouts table loading items with many holds and items using AllowRenewalIfOtherItemsAvailable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14320 Bug ID: 14320 Summary: Improve the speed of the checkouts table loading items with many holds and items using AllowRenewalIfOtherItemsAvailable Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The feature AllowRenewalIfOtherItemsAvailable can take a tremendous amount of processing for records with large numbers of holds and/or items. For example, for a record with 50 items and 100 holds we must call a series of subroutines 5000 times! The loop this processing takes place in has an outer loop of borrowers and an inner loop of items. However, two of the three subroutines only need an itemnumber. So, if we move the items loop to be the outer loop, we can 'cache' these subroutine calls and vastly improve the speed of the subroutine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14301] “No renewal before” does not accept 0 as parameter.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14301 Holger Meißner h.meissner...@web.de changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #5 from Holger Meißner h.meissner...@web.de --- *** This bug has been marked as a duplicate of bug 14101 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14320] Improve the speed of the checkouts table loading items with many holds and items using AllowRenewalIfOtherItemsAvailable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14320 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- I was looking at v3.18. Looks like these speed improvements won't apply to master due to changes in IsAvailableForItemLevelRequest. I'll see if there is any way to improve this in master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13946] Change order status 'Pending' to ordered like in database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13946 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #8 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14256] Tests for TestBuilder fail randomly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14256
--- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com ---
Comment on attachment 39789
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39789
Bug 14256: (followup) do not repeat existing values on primary columns
Review of attachment 39789:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=14256attachment=39789)
-
::: t/lib/TestBuilder.pm
@@ +244,5 @@
+my $data_type = $col_info-{data_type};
+$data_type =~ s| |_|;
+
+if ( any { $data_type eq $_ } (keys $gen_type) ) {
+my $value_ok = 'no';
A boolean would be enough.
@@ +249,5 @@
+while ( $value_ok eq 'no' ) {
+# generate value
+$col_value = $gen_type-{$data_type}-( $self, { info =
$col_info } );
+# should value be unique?
+my $primary_names =
$self-schema-source($source)-primary_columns();
What about unique keys?
@@ +250,5 @@
+# generate value
+$col_value = $gen_type-{$data_type}-( $self, { info =
$col_info } );
+# should value be unique?
+my $primary_names =
$self-schema-source($source)-primary_columns();
+if ( not ( any { $col_name eq $_ } $primary_names and
any takes a list in parameter, not a ref.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12066] New renew page in staff client doesn't record branch in statistics
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12066 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Status|Pushed to Master|Pushed to Stable --- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14266] Replace trim() with $.trim() in opac-shareshelf.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14266 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Status|Pushed to Master|Pushed to Stable --- Comment #12 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14265] Use $.trim instead of trim() in admin/categorie.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14265 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Status|Pushed to Master|Pushed to Stable --- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11490] Deleting Batch Items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||gaetan.bois...@biblibre.com --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #4) I feel like we should honor the system preference. Wondering: Does it display a warning, that not all information is displayed? (batch item deletion) If we don't honor the pref to its current description, we should rephrase it and also make it clear to the user that not all information is displayed. I am not sure. In this case, people won't be able to modify more than MaxItemsForBatch items. I think the limit has been introduced in order not to freeze the browser if there is too much info to display. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12054] It’s possible to make order from an inactive vendor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #9) I wonder: should we allow receiving shipments for inactive vendors? There might still be orderes outstanding,when you decide that you don't want to use the vendor for odering in the future. (In reply to Katrin Fischer from comment #10) Hm, also, I can still: - reopen the baskt - add new orders This is possible by using the 'view' link from the vendor search page. This patch only prevents to add order to an inactive vendor. The second one fixes 2 more occurrences where it was possible to add orders (on the basket page). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3206] OAI repositry deleted record support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 --- Comment #9 from Matthias Meusburger matthias.meusbur...@biblibre.com --- (In reply to Frédéric Demians from comment #7) Adding a new syspref, you're supposed to add it also to sysprefs.sql file. Added ! I don't understand this in your patch: diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql index c41710c..5fd5612 100644 --- a/installer/data/mysql/kohastructure.sql +++ b/installer/data/mysql/kohastructure.sql @@ -1609,7 +1609,6 @@ CREATE TABLE `oai_sets_biblios` ( `biblionumber` int(11) NOT NULL, `set_id` int(11) NOT NULL, PRIMARY KEY (`biblionumber`, `set_id`), - CONSTRAINT `oai_sets_biblios_ibfk_1` FOREIGN KEY (`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `oai_sets_biblios_ibfk_2` FOREIGN KEY (`set_id`) REFERENCES `oai_sets` (`id`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; This is required to be able to display deleted records in a set. With the constraint, when a record is deleted, its biblionumber is automatically deleted from the oai_sets_biblio, and thus removed from the set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11929] patron modification error shows borrowernumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11929 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #10 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3206] OAI repositry deleted record support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3206] OAI repositry deleted record support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Attachment #39794|0 |1 is obsolete|| --- Comment #10 from Frédéric Demians frede...@tamil.fr --- Created attachment 39795 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39795action=edit Bug 3206: OAI repository deleted records support. This patch allows Koha OAI repository to support deleted records. The OAI-PMH:DeletedRecord syspref is introduced and can be set to: - persistent (in case Koha's deletedbiblio table will never be emptied or truncated) - transient (in case Koha's deletedbiblio table might be emptied or truncated at some point) Test plan: - After applying the patch, test that: - Deleted records appear in ListRecords and ListIdentifiers requests. - Filter parameters (from, until, set and resumptionToken) still work and are applied to ListRecords and ListIdentifiers requests. - Identify request shows if the repository is considered persistent or transient, according to the OAI-PMH:DeletedRecord syspref. - Deleted records that used to belong to a set are still displayed in those sets and marked as deleted. - GetRecord requests work on deleted records, which are marked as deleted. Requests examples: /cgi-bin/koha/oai.pl?verb=ListRecordsmetadataPrefix=oai_dc /cgi-bin/koha/oai.pl?verb=ListRecordsmetadataPrefix=oai_dcfrom=2015-02-20T11:08:33Z /cgi-bin/koha/oai.pl?verb=ListRecordsmetadataPrefix=oai_dcset=new_specSet1 /cgi-bin/koha/oai.pl?verb=GetRecordidentifier=KOHA-OAI-TEST:2metadataPrefix=oai_dc /cgi-bin/koha/oai.pl?verb=Identify Signed-off-by: Frederic Demians f.demi...@tamil.fr It works in all situations described in the test plan. Great addition. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Version|3.18|master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Severity|normal |major --- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com --- According to my comment 12, I am raising the priority to get a quick QA review on this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3206] OAI repositry deleted record support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 Matthias Meusburger matthias.meusbur...@biblibre.com changed: What|Removed |Added Attachment #39771|0 |1 is obsolete|| --- Comment #8 from Matthias Meusburger matthias.meusbur...@biblibre.com --- Created attachment 39794 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39794action=edit Bug 3206: OAI repository deleted records support. This patch allows Koha OAI repository to support deleted records. The OAI-PMH:DeletedRecord syspref is introduced and can be set to: - persistent (in case Koha's deletedbiblio table will never be emptied or truncated) - transient (in case Koha's deletedbiblio table might be emptied or truncated at some point) Test plan: - After applying the patch, test that: - Deleted records appear in ListRecords and ListIdentifiers requests. - Filter parameters (from, until, set and resumptionToken) still work and are applied to ListRecords and ListIdentifiers requests. - Identify request shows if the repository is considered persistent or transient, according to the OAI-PMH:DeletedRecord syspref. - Deleted records that used to belong to a set are still displayed in those sets and marked as deleted. - GetRecord requests work on deleted records, which are marked as deleted. Requests examples: /cgi-bin/koha/oai.pl?verb=ListRecordsmetadataPrefix=oai_dc /cgi-bin/koha/oai.pl?verb=ListRecordsmetadataPrefix=oai_dcfrom=2015-02-20T11:08:33Z /cgi-bin/koha/oai.pl?verb=ListRecordsmetadataPrefix=oai_dcset=new_specSet1 /cgi-bin/koha/oai.pl?verb=GetRecordidentifier=KOHA-OAI-TEST:2metadataPrefix=oai_dc /cgi-bin/koha/oai.pl?verb=Identify -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11578] Improvement of the funds list view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 --- Comment #49 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Marjorie Barry-Vila from comment #47) Hi, I have a question about this patch: why column sorting was abandoned? It is expected, the sort option would be quite difficult to implement on this new view I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12176] Remove HTML from additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #50 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY of message_queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793 --- Comment #25 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Tomás Cohen Arazi from comment #24) Guys, can u verify this? I ran the dbix upgrade script just in case on top of this, and found that the generated Koha/Schema/Result/MessageQueue.pm differs from the one shipped with this patch set. I always regenerate them, because the hash on them usually is invalid and makes the upgrade script fail. I mark this Failed-QA until you tell me which is wrong: the kohastructure.sql change or the Koha/Schema/Result/MessageQueue.pm change. Yes, the file provided in the first patch is wrong. I think the changes to Koha/Schema should not be provided unless it is needed to make the dev/fix work. It always should be provided in a separate patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 David Roberts david.robe...@ptfs-europe.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #71 from David Roberts david.robe...@ptfs-europe.com --- Ah, I didn't know that. All the patches have been signed off, so I'll change the status. Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #82 from Jonathan Druart jonathan.dru...@biblibre.com --- No sorry, back to Needs QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14112] Silence warnings t/Charset.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #9 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 --- Comment #70 from Jonathan Druart jonathan.dru...@biblibre.com --- You can switch the status back to Signed Off after a rebase, unless you are not confident and/or you rewrote a part of the patches to fix the conflict. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14279] Remove CGI::scrolling_list from issues_avg_stats.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14279 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Status|Pushed to Master|Pushed to Stable --- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11578] Improvement of the funds list view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 --- Comment #50 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Jonathan Druart from comment #49) (In reply to Marjorie Barry-Vila from comment #47) Hi, I have a question about this patch: why column sorting was abandoned? It is expected, the sort option would be quite difficult to implement on this new view I think. ... But not impossible ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12054] It’s possible to make order from an inactive vendor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054 --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39796 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39796action=edit Bug 12054: (follow-up) Inactive vendors should be inactive Don't display add orderblock and buttons if the vendor is inactive. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Holger Meißner h.meissner...@web.de changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14214] Automatic renewal to renew at end of due date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14214 --- Comment #3 from Holger Meißner h.meissner...@web.de --- I have uploaded a patch to fix this problem with bug 14101. Please test and let me know if it works for you. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3206] OAI repositry deleted record support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 Gaetan Boisson gaetan.bois...@biblibre.com changed: What|Removed |Added CC||gaetan.bois...@biblibre.com --- Comment #15 from Gaetan Boisson gaetan.bois...@biblibre.com --- Jonathan, i think the no option (and the whole syspref) is there to stick to the OAI standard: http://www.openarchives.org/OAI/openarchivesprotocol.html#DeletedRecords My understanding is that the transient, persistent or no status, is more a result of how you administer your database than one of the choice you made in this syspref. I'd say it's here so that the server communicates the right value to harvesters. Default value should be persistent, since the deletedbiblio table can only be emptied manually if the administrator does so. So transient would be i do that from time to time and 'no' would be i never ever let anything go in this table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14320] Improve the speed of the checkouts table loading items with many holds and items using AllowRenewalIfOtherItemsAvailable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14320 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- My best effort looks like it offers little to no improvement. Closing out the bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 --- Comment #73 from Jonathan Druart jonathan.dru...@biblibre.com --- Ha yes, something else: 16 patches is much too many for this features :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #49 from Jonathan Druart jonathan.dru...@biblibre.com --- Note that now strict and warnings are enabled, the log contains a lot of 'Use of uninitialized value. But it's not introduced by this patch set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #72 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: 1/ Really, it's very hard to provide a strong password with this plugin... Something like A1!p2@3foo4bar% only fill half of the gauge. 2/ There is no indication to explain what is the gauge 3/ New lib has to be added to the about page. 4/ FAIL installer/data/mysql/updatedatabase.pl FAIL forbidden patterns forbidden pattern: Use INSERT IGNORE INTO on inserting a new syspref (see bug 9071) (line 10532) forbidden pattern: Use INSERT IGNORE INTO on inserting a new syspref (see bug 9071) (line 10526) 5/ No need to pass the pref value in C4::Auth, use the Koha TT plugin 6/ [% INCLUDE 'complexify.inc' %] should be put in the head part 7/ in members/member-password.tt you include the complexity.inc but also include the jquery.complexify.js from github 8/ The most important: the gauges are not the same at the OPAC and at the intranet. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12488] bulkmarcimport.pl -d option should use DELETE instead of TRUNCATE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12488 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #6 from M. Tompsett mtomp...@hotmail.com --- (In reply to wajasu from comment #4) Also, an understanding of bulkimport.pl and the implications for folks with huge imports, and the resulting rollback support. Slow processing is usually overcome by intermediate user feedback. It's a bulk import. People are going to assume it is slow to begin with. And the ability to rollback is very important in my opinion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14320] Improve the speed of the checkouts table loading items with many holds and items using AllowRenewalIfOtherItemsAvailable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14320 --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39808 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39808action=edit Bug 14320 - WIP -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3206] OAI repositry deleted record support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206
--- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com ---
Comment on attachment 39797
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39797
Bug 3206: OAI repository deleted records support.
Review of attachment 39797:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=3206attachment=39797)
-
::: installer/data/mysql/sysprefs.sql
@@ +479,5 @@
('XSLTDetailsDisplay','default','','Enable XSL stylesheet control over
details page display on intranet','Free'),
('XSLTResultsDisplay','default','','Enable XSL stylesheet control over
results page display on intranet','Free'),
('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields
for Personal Name Authorities to fill biblio.author','free'),
+('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will
replace authors in biblio.author','YesNo'),
+('OAI-PMH:DeletedRecord','persistent','Koha\'s deletedbiblio table will
never be deleted (persistent) or might be deleted
(transient)','transient|persistent','Choice')
Insert the pref at the right place, this file must be kept ordered.
::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/web_services.pref
@@ +31,5 @@
+- Koha's deletedbiblio table
+- pref: OAI-PMH:DeletedRecord
+ choices:
+ persistent: will never be emptied or truncated (persistent)
+ transient: might be emptied or truncated at some point
(transient)
Does it make sense to have the no option?
::: opac/oai.pl
@@ +242,5 @@
+package C4::OAI::DeletedRecord;
+
+use strict;
+use warnings;
Prefer Modern::Perl;
@@ +303,5 @@
+FROM deletedbiblio
+WHERE biblionumber=? );
+ $sth-execute( $biblionumber );
+
+ unless ( ($marcxml, $timestamp) = $sth-fetchrow ) {
Prefer $dbh-selectrow_*
@@ +358,4 @@
}
my $max = $repository-{koha_max_count};
my $sql =
+(SELECT biblioitems.biblionumber, timestamp
Why do you remove the table name?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3206] OAI repositry deleted record support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 --- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com --- Should not we update the misc/migration_tools/build_oai_sets.pl script to take into account the deletedbiblio table? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14322] New: Can't link to an item search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14322 Bug ID: 14322 Summary: Can't link to an item search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: mag...@libriotech.no QA Contact: testo...@bugs.koha-community.org The new item search in the staff client is awesome, but a bit too AJAXy for my tastes. The main problem is that it is not possible to link to the results of a search. If you do a search and you want to show the results to a colleague, you have to explain what boxes to check, what to type where, what to select from what pulldown menus etc. If the search criteria were in the URL it could be done with simply copying and pasting the URL. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #47 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39805 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39805action=edit Bug 12357: Fix comma issues related to additional fields. TEST PLAN - 1) Apply patches, except this one. 2) prove t/db_dependent/Record.t -- fails like comment #38 3) Apply this patch 4) prove t/db_dependent/Record.t -- now it passes. 5) koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Make test work, koha-qa problems fixed in next patch Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #39773|0 |1 is obsolete|| Attachment #39774|0 |1 is obsolete|| Attachment #39775|0 |1 is obsolete|| Attachment #39776|0 |1 is obsolete|| --- Comment #45 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39803 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39803action=edit Bug 12357 - Enhancements to RIS and BibTeX exporting Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add the following to the new syspref RisExportAdditionalFields: TY: 942$c LC: 010$a NT: [501$a, 505$g] 4) Find or create a record with an 010$a (lccn) field, a 501$a field, a 942$c field, and multiple 505$g fields. 5) Locate the record in the catalog, choose Save and select RIS 6) Inspect the downloaded file, note the replaced TY field, the LC field, and multiple NT fields 7) Add the following to the new syspref BibtexExportAdditionalFields: '@': 942$c lccn: 010$a notes: [501$a, 505$g] 9) Using the previously selected record, choose Save and select BIBTEX 10) Inspect the downloaded file, note the lccn, the multiple note fields, and the new record type value Signed-off-by: Frederic Demians f.demi...@tamil.fr Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #46 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39804 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39804action=edit Bug 12357 [QA Followup] - Unit Test Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com This works with next patch Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Sent notices using several email addresses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802
--- Comment #41 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Letters.t tests are ok without the patch, but Reserves.t are not. (cf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802#c36 ).
This is because when sending a print message, if the email address is not
gathered, this loop in C4::Letters::EnqueueLetter is never entered:
for my $to_address ( @to_addresses ) {
$rs-create({
...
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3206] OAI repositry deleted record support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Change sponsored?|Seeking cosponsors |--- CC||jonathan.dru...@biblibre.co ||m Assignee|gmcha...@gmail.com |matthias.meusburger@biblibr ||e.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
