[Koha-bugs] [Bug 14280] Add branches fields to discharges letters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14280 Marc Véron ve...@veron.ch changed: What|Removed |Added CC||ve...@veron.ch Attachment #39571|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14280] Add branches fields to discharges letters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14280 --- Comment #2 from Marc Véron ve...@veron.ch --- Created attachment 39896 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39896action=edit [Signed-off] Bug 14280: Add branches fields to discharges letters Currently, when generating a discharge letter, branches fields are not translated in the letter (branches.branchname, branches.branchaddress1, etc.) This patch fixes that. How I tested: - Set syspref 'useDischarge' to 'allow' - Go to Home Tools Notices Slips - Edit DISCHARGE, add to 'Email message': pbranches.branchnamebr / branches.branchaddress1br / branches.branchaddress2br / branches.branchaddress3br / branches.zip branches.citybr / /p - Go to detail page of a patron discharge - Click 'Generate discharge' - Verify that the PDF contains the information above. Signed-off-by: Marc Véron ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #18 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 39888 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39888action=edit Bug 14167 [QA Followup] - Add template and changes needed for packages Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Amended: upgraded DEBUG level to WARN in config file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #17 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 39887 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39887action=edit Bug 14167 - [DO_NOT_PUSH] Renewal example patch for logging This patch adds logging to the renewal process to test the first patch. Note to RM: Do not push this patch. Test plan: See the first patch. Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #39103|0 |1 is obsolete|| Attachment #39180|0 |1 is obsolete|| --- Comment #16 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 39886 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39886action=edit Bug 14167 - Add Koha::Logger based on Log4perl Koha needs a better logger, and it seems like the best solution would be to take advantage of Log4perl which is already a fully featured logger. We use Log4perl to selectively decide what statements should be logged, and where they should go! Test plan: 0) Install Log::Log4perl via packages or cpan 1) Apply this patch and the example renewal patch 2) Copy etc/log4perl.conf to your koha conf directory, edit the paths to match your current error logs 3) Edit your koha-conf file and add the log4perl_conf/path/to/log4perl.conf/log4perl_conf line 4) Watch your intranet and opac error logs 5) Perform a renewal via the staff interface, note there is nothing new in the log file 7) Update the log4perl.conf, change the log level from DEBUG to TRACE for both the staff and opac sides 8) Perform a renewal via the staff interface, note the logged lines 9) Perform a renewal via the opac, note the logged lines Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Amended this patch: Moved the renewal stuff to a separate example patch. And upgraded the DEBUG level to WARN in the log4perl config file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #22 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Please wait..not ready yet! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #39888|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #25 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 39894 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39894action=edit Bug 14167 - [DO_NOT_PUSH] Renewal example patch for logging This patch adds logging to the renewal process to test the first patch. Note to RM: Do not push this patch. Test plan: See the first patch. Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Amended the get call in light of the QA follow-up for category. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #39890|0 |1 is obsolete|| Attachment #39892|0 |1 is obsolete|| --- Comment #24 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 39893 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39893action=edit Bug 14167: [QA Follow-up] Adjust category handling in Koha::Logger The first patch makes the category parameter mandatory. This patch makes it optional, falling back to the current package. This is the expected log4perl model. It would not be necessary to pass the class name everywhere (check subclasses..) It also adds a delimiter between the interface and the class name. This allows you to add config lines like: log4perl.logger.opac.C4.Auth = DEBUG, OPAC log4perl.logger.intranet.C4.Circulation = TRACE, INTRANET The first line would make the logger more sensitive to C4::Auth log messages while staying at the WARN level for other messages, etc. The second line makes the trace visible from the renewal example. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #26 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 39895 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39895action=edit Bug 14167 [QA Followup] - Add template and changes needed for packages Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Amended: upgraded DEBUG level to WARN in config file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #39891|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #23 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 39892 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39892action=edit Bug 14167 [QA Followup] - Add template and changes needed for packages Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Amended: upgraded DEBUG level to WARN in config file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14335] New: SCO fails to strip leading/trailing whitespace in 'barcode' input field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14335 Bug ID: 14335 Summary: SCO fails to strip leading/trailing whitespace in 'barcode' input field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: m...@kohaaloha.com QA Contact: testo...@bugs.koha-community.org SCO fails to strip leading/trailing whitespace in 'barcode' input field -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #39888|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14335] SCO fails to strip leading/trailing whitespace in 'barcode' input field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14335 Mason James m...@kohaaloha.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=1626 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14335] SCO fails to strip leading/trailing whitespace in 'barcode' input field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14335 Mason James m...@kohaaloha.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13354 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13354] z3950 admin: strip leading/trailing whitespace in fields, when saving Z39 entry
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13354 Mason James m...@kohaaloha.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14335 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1626] Trim whitespace from barcode inputs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1626 Mason James m...@kohaaloha.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14335 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14280] Add branches fields to discharges letters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14280 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #20 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 39890 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39890action=edit Bug 14167 - [DO_NOT_PUSH] Renewal example patch for logging This patch adds logging to the renewal process to test the first patch. Note to RM: Do not push this patch. Test plan: See the first patch. Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #39886|0 |1 is obsolete|| Attachment #39887|0 |1 is obsolete|| Attachment #39888|0 |1 is obsolete|| --- Comment #19 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 39889 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39889action=edit Bug 14167 - Add Koha::Logger based on Log4perl Koha needs a better logger, and it seems like the best solution would be to take advantage of Log4perl which is already a fully featured logger. We use Log4perl to selectively decide what statements should be logged, and where they should go! Test plan: 0) Install Log::Log4perl via packages or cpan 1) Apply this patch and the example renewal patch 2) Copy etc/log4perl.conf to your koha conf directory, edit the paths to match your current error logs 3) Edit your koha-conf file and add the log4perl_conf/path/to/log4perl.conf/log4perl_conf line 4) Watch your intranet and opac error logs 5) Perform a renewal via the staff interface, note there is nothing new in the log file 7) Update the log4perl.conf, change the log level from WARN to TRACE for both the staff and opac sides 8) Perform a renewal via the staff interface, note the logged lines 9) Perform a renewal via the opac, note the logged lines Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Amended this patch: Moved the renewal stuff to a separate example patch. And upgraded the DEBUG level to WARN in the log4perl config file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #21 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 39891 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39891action=edit Bug 14167 [QA Followup] - Add template and changes needed for packages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14280] Add branches fields to discharges letters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14280 Matthias Meusburger matthias.meusbur...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14031] Itemnumber should be a numeric search in ccl.properties
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14031 Magnus Enger mag...@libriotech.no changed: What|Removed |Added Attachment #38223|0 |1 is obsolete|| --- Comment #2 from Magnus Enger mag...@libriotech.no --- Created attachment 39897 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39897action=edit Bug 14031 - Itemnumber should be a numeric search in ccl.properties This patch changes the itemnumber alias so that it acts like itemnumber,st-numeric. That is, it always does a numeric search. _TEST PLAN_ The best way to test this patch is to apply the patch and then run make upgrade, I suspect. As this will refresh your ccl.properties. However, this patch is actually really small, so you can just apply it manually to an existing ccl.properties if you rather save time. Basically, you just need to do the following steps: 0) Do a search for itemnumber:insert real indexed itemnumber here 1) Note that you can't retrieve any results 2) Change your ccl.properties to say itemnumber 1=8010 4=109 3) Repeat the search for itemnumber:X 4) Note that you now retrieve your result Signed-off-by: Magnus Enger mag...@libriotech.no Tested on a gitified package install. Made the change to /etc/koha/zebradb/ccl.properties manually. After this change I can successfully search for itemnumber:1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14336] SCO: Move embedded Jscript code from sco-main.tt to new sco.js file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14336 Mason James m...@kohaaloha.com changed: What|Removed |Added Summary|SCO: Move embebbed Jscript |SCO: Move embedded Jscript |code from sco-main.tt to|code from sco-main.tt to |new sco.js file |new sco.js file -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14336] New: SCO: Move embebbed Jscript code from sco-main.tt to new sco.js file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14336 Bug ID: 14336 Summary: SCO: Move embebbed Jscript code from sco-main.tt to new sco.js file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: m...@kohaaloha.com QA Contact: testo...@bugs.koha-community.org SCO: Move embebbed Jscript code from sco-main.tt to new sco.js file -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14031] Itemnumber should be a numeric search in ccl.properties
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14031 Magnus Enger mag...@libriotech.no changed: What|Removed |Added Patch complexity|Trivial patch |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167
Marcel de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #27 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
QA Comment:
Nice feature. Economic implementation of logging.
Although the code looks good to me, I still have some concerns:
[1] For logging level and category handling, I made some tiny adjustments via
amending or follow-up.
[2] A bigger problem could be permissions on the logfile.
If you do not have sufficient permissions, Log4perl will make a crash. So this
is a very fundamental issue. In Debian the koha instance user should have
permissions on the file, but I noticed that after a forced logrotate, the file
permissions for the new log file were changed to root and Koha crashed on that.
What about other distros btw?
[3] The BEGIN section of Koha::Logger assumes that it will have either a conf
file via $ENV{LOG4PERL_CONF} or the koha-conf.xml.
If you do not have either one, Koha will again crash on you (Configuration not
defined).
It is safer imo to go always via the koha-conf. If there is nothing in
koha-conf, set some flag, warn once and do nothing or perhaps fall back to
warn. (Note that you should trap all calls to warn, trace etc. in that case.)
Note that a new installation would be fine. But an upgrade does not guarantee
the presence of a config file.
Also note that you can pass some default configuration string to init() too.
By conclusion, we could argue that a Koha administrator should just take care
of the perl module and the log4perl config file and push this as-is. But we
also know that this will result in problems at various locations when
upgrading. What would be the best way to go here?
I will be happy to follow through on this report, but not in the next two
weeks. (But another QAer is welcome too.)
Changing status to reflect need for changes or clarification..
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 Stefano Bargioni bargi...@pusc.it changed: What|Removed |Added CC||bargi...@pusc.it --- Comment #1 from Stefano Bargioni bargi...@pusc.it --- (In reply to Bernardo Gonzalez Kriegel from comment #0) New update: few new subfields and one new field (884) Good sources: http://www.itsmarc.com/crs/mergedprojects/helptop1/helptop1/appendices/appendix_g_format_changes_update_no._20_april_2015.htm and http://www.itsmarc.com/crs/mergedprojects/helpauth/helpauth/appendix_f_format_changes_update_no._20_april_2015.htm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14337] New: AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Bug ID: 14337 Summary: AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com AllowRenewalIfOtherItemsAvailable checks C4::Reserves::IsAvailableForItemLevelRequest to see if the item is holdable, which catches not for loan values less than 0 ( i.e. holdable, but not circ-able ). However, since this feature is about actually checking out items to patrons, we should not count *any* not for loan items when deciding if the available items will satisfy all current holds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39898 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39898action=edit Bug 14337 - AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability AllowRenewalIfOtherItemsAvailable checks C4::Reserves::IsAvailableForItemLevelRequest to see if the item is holdable, which catches not for loan values less than 0 ( i.e. holdable, but not circ-able ). However, since this feature is about actually checking out items to patrons, we should not count *any* not for loan items when deciding if the available items will satisfy all current holds. Test Plan: 1) Enable AllowRenewalIfOtherItemsAvailable 2) Create a record with two items 3) Check out one item to a patron 4) Ensure the item is renewable 5) Place a hold on the record 6) The item should now be non-renewable 7) Add a second item to the record, but with a not for loan value 0 8) Note the checkout is still renewable 9) Apply this patch 10) Note the checkout is now non-renewable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14338] Unable to delete patron images
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14338 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39899 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39899action=edit Bug 14338 - Unable to delete patron images The call to RmPatronImage is still passing cardnumber as its parameter instead of borrowernumber. Test Plan: 1) Upload a patron image 2) Attempt to delete patron image 3) Image will remain 4) Apply this patch 5) Attempt to delete patron image 6) Image will be removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14338] Unable to delete patron images
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14338 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14338] Unable to delete patron images
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14338 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14338] New: Unable to delete patron images
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14338 Bug ID: 14338 Summary: Unable to delete patron images Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The call to RmPatronImage is still passing cardnumber as its parameter instead of borrowernumber. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 --- Comment #2 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- (In reply to Stefano Bargioni from comment #1) (In reply to Bernardo Gonzalez Kriegel from comment #0) New update: few new subfields and one new field (884) Good sources: http://www.itsmarc.com/crs/mergedprojects/helptop1/helptop1/appendices/ appendix_g_format_changes_update_no._20_april_2015.htm and http://www.itsmarc.com/crs/mergedprojects/helpauth/helpauth/ appendix_f_format_changes_update_no._20_april_2015.htm Thanks Stefano! I'll try to do this today. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14338] Unable to delete patron images
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14338 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10636 CC||mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14338 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #2 from Nicole C. Engard neng...@gmail.com --- (In reply to Winona Salesky from comment #1) How about if there is 490$0 or 490$# ? Should the 8xx display in that case as well? You know .. I don't know. The examples on the 810 documentation look like it should so not matter what the indicators ... On the 490 documentation the 830 only shows if the indicator is 1 - and so maybe if the indicator is 1 we shouldn't show the 8xx because it will be duplicate info. Anyone else have any feedback here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14339] Installer broken by bug 13967
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14339 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |tomasco...@gmail.com QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12769] Notice fee management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Maxime Beaulieu maxime.beaul...@inlibro.com changed: What|Removed |Added CC||maxime.beaul...@inlibro.com Assignee|simith.dolive...@inlibro.co |maxime.beaul...@inlibro.com |m | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14339] Installer broken by bug 13967
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14339 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Depends on||13967 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13967] System preferences need a package
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Blocks||14339 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12769] Notice fee management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Maxime Beaulieu maxime.beaul...@inlibro.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12769] Notice fee management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Maxime Beaulieu maxime.beaul...@inlibro.com changed: What|Removed |Added Attachment #36351|0 |1 is obsolete|| Attachment #36504|0 |1 is obsolete|| --- Comment #13 from Maxime Beaulieu maxime.beaul...@inlibro.com --- Created attachment 39900 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39900action=edit Bug 12769 - Notice fee management Created an atomic update .sql file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12768] Replacement cost and processing fee management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Maxime Beaulieu maxime.beaul...@inlibro.com changed: What|Removed |Added CC||maxime.beaul...@inlibro.com Assignee|simith.dolive...@inlibro.co |maxime.beaul...@inlibro.com |m | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14341] XSLT 773$x
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14341 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14340 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14341] New: XSLT 773$x
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14341 Bug ID: 14341 Summary: XSLT 773$x Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org 773$x is an ISSN field and should show on the line in the display that shows the 773. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14339] New: Installer broken by bug 13967
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14339 Bug ID: 14339 Summary: Installer broken by bug 13967 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org The introduction of the new Koha::Config::SysPrefs package slightly changed the behaviour on syspref retrieval by not catching DB errors (notably when there is no DB structure :-/, which should be detected and redirected to the installer/maintenance depending on the interface) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14340] New: 773x ISSN Index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14340 Bug ID: 14340 Summary: 773x ISSN Index Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org 773$x should be an ISSN index. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14340] 773x ISSN Index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14340 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14341 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12769] Notice fee management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769
--- Comment #14 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 39900
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39900
Bug 12769 - Notice fee management
Review of attachment 39900:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=12769attachment=39900)
-
::: misc/cronjobs/advance_notices.pl
@@ +525,5 @@
+} else {
+$sendfee = C4::Context-preference('DefaultNoticeFee');
+}
+
+if ($sendfee 0){
$sendfee could be undefined. This would generate noise.
::: misc/cronjobs/overdue_notices.pl
@@ +599,5 @@
+} else {
+$sendfee = C4::Context-preference('DefaultNoticeFee');
+}
+
+if ($sendfee 0){
Check if defined. :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14338] Unable to delete patron images
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14338 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Version|3.18|master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12769] Notice fee management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #15 from M. Tompsett mtomp...@hotmail.com --- Comment on attachment 39900 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39900 Bug 12769 - Notice fee management Review of attachment 39900: -- (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=12769attachment=39900) - ::: installer/data/mysql/kohastructure.sql @@ +1393,4 @@ `title` varchar(200) NOT NULL default '', -- subject line of the notice `content` text, -- body text for the notice or slip `message_transport_type` varchar(20) NOT NULL DEFAULT 'email', -- transport type for this notice + `fee` decimal(10,2) DEFAULT NULL, -- set up the cost of sending a notice Null = Don't send fee notice? How does 0 and NULL differ in intended behaviour? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14338] Unable to delete patron images
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14338 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14338] Unable to delete patron images
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14338 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #39899|0 |1 is obsolete|| --- Comment #3 from M. Tompsett mtomp...@hotmail.com --- Created attachment 39904 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39904action=edit Bug 14338 - Unable to delete patron images The call to RmPatronImage is still passing cardnumber as its parameter instead of borrowernumber. Test Plan: 1) Upload a patron image 2) Ensure the card number is not the same as the borrower number 3) Attempt to delete patron image -- Image will remain 4) Apply this patch 5) Attempt to delete patron image -- Image will be removed 6) run koha qa test tools Signed-off-by: Mark Tompsett mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14343] Links to results pages don't work in Receive Shipment list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14343 Koha Team Lyon 3 k...@univ-lyon3.fr changed: What|Removed |Added CC||k...@univ-lyon3.fr --- Comment #1 from Koha Team Lyon 3 k...@univ-lyon3.fr --- Created attachment 39907 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39907action=edit Bug 14343 Incorrect links to results pages in Receive shipment list The problem is already existing in 3.14 version and maybe previous ones. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14342] Unit tests in t/db_dependent/Context.t failing due to Bug 13967
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14342 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14342] Unit tests in t/db_dependent/Context.t failing due to Bug 13967
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14342 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39901 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39901action=edit Bug 14342 - Unit tests in t/db_dependent/Context.t failing due to Bug 13967 The introduction of system preference objects in bug 13967 has caused the current testing regimen to fail do to the mixing of DBI mocking and DBIx::Class. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Context.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14342] Unit tests in t/db_dependent/Context.t failing due to Bug 13967
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14342 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #39901|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39902 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39902action=edit Bug 14342 - Unit tests in t/db_dependent/Context.t failing due to Bug 13967 The introduction of system preference objects in bug 13967 has caused the current testing regimen to fail do to the mixing of DBI mocking and DBIx::Class. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Context.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14338] Unable to delete patron images
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14338 --- Comment #2 from M. Tompsett mtomp...@hotmail.com --- DOH! I figured out why it worked for me. my borrowernumber = cardnumber! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14342] Unit tests in t/db_dependent/Context.t failing due to Bug 13967
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14342 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |k...@bywatersolutions.com Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14342] New: Unit tests in t/db_dependent/Context.t failing due to Bug 13967
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14342 Bug ID: 14342 Summary: Unit tests in t/db_dependent/Context.t failing due to Bug 13967 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The introduction of system preference objects in bug 13967 has caused the current testing regimen to fail do to the mixing of DBI mocking and DBIx::Class. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14342] Unit tests in t/db_dependent/Context.t failing due to Bug 13967
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14342 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #39902|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39903 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39903action=edit Bug 14342 - Unit tests in t/db_dependent/Context.t failing due to Bug 13967 The introduction of system preference objects in bug 13967 has caused the current testing regimen to fail do to the mixing of DBI mocking and DBIx::Class. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Context.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14339] Installer broken by bug 13967
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14339 --- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 39906 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39906action=edit Bug 14339: C4::Context-preference should return undef if DB is not populated The current behaviour for C4::Context-preference when the DB is not still populated with tables is to return undef. This is used by C4::Auth to identify the need of running the installer. This behaviour got broken by bug 13967, which lets DB errors to escalate and thus Koha gets broken instead of prompting for install. This patch wraps Koha::Config::Sysprefs-find inside an eval and sets undef if needed. To test: - In current master, drop the DB - Load OPAC and Intranet = FAIL: notice an ugly software error. - Apply the patch - Load the OPAC = SUCCESS: Maintenance mode screen is shown - Load Intranet = SUCCESS: You are prompted the DB credentials to run the web installer. - Sign off :-D Tomas -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14339] Installer broken by bug 13967
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14339 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14343] New: Links to results pages don't work in Receive Shipment list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14343 Bug ID: 14343 Summary: Links to results pages don't work in Receive Shipment list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: k...@univ-lyon3.fr QA Contact: testo...@bugs.koha-community.org Created attachment 39905 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39905action=edit Numbered links have incorrect url Links to result pages don't work in Receive Shipment List (but fortunately, Next and Previous buttons work) It's because the booksellerid is not furnished in the url. Test Plan : 1) Go to Acquisitions module, enter a bookseller name that you know you can get many page of invoices for and search for it. 2) click on Receive shipment button. 3) On bottom of the first results page, click on page number 2 link. (cf joined screencast) You'll see that the results include invoices from other booksellerid. Indeed, I suppose that you get results from all booksellerid. Intall patch and redo 3 steps. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14343] Links to results pages don't work in Receive Shipment list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14343 Koha Team Lyon 3 k...@univ-lyon3.fr changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14342] Unit tests in t/db_dependent/Context.t failing due to Bug 13967
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14342 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14342] Unit tests in t/db_dependent/Context.t failing due to Bug 13967
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14342 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #39903|0 |1 is obsolete|| --- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 39908 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39908action=edit [SIGNED OFF] Bug 14342: Unit tests in t/db_dependent/Context.t failing due to Bug 13967 The introduction of system preference objects in bug 13967 has caused the current testing regimen to fail do to the mixing of DBI mocking and DBIx::Class. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Context.t Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14339] Installer broken by bug 13967
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14339 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #39906|0 |1 is obsolete|| --- Comment #2 from M. Tompsett mtomp...@hotmail.com --- Created attachment 39909 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39909action=edit Bug 14339: C4::Context-preference should return undef if DB is not populated The current behaviour for C4::Context-preference when the DB is not still populated with tables is to return undef. This is used by C4::Auth to identify the need of running the installer. This behaviour got broken by bug 13967, which lets DB errors to escalate and thus Koha gets broken instead of prompting for install. This patch wraps Koha::Config::Sysprefs-find inside an eval and sets undef if needed. To test: - In current master, drop the DB - Load OPAC and Intranet = FAIL: notice an ugly software error. - Apply the patch - Load the OPAC = SUCCESS: Maintenance mode screen is shown - Load Intranet = SUCCESS: You are prompted the DB credentials to run the web installer. - Sign off :-D Tomas Signed-off-by: Mark Tompsett mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14339] Installer broken by bug 13967
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14339 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14318] iDreamBooks doesn't work when Koha is using https
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14318 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #39847|0 |1 is obsolete|| --- Comment #4 from M. Tompsett mtomp...@hotmail.com --- Created attachment 39912 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39912action=edit Bug 14318 - iDreamBooks doesn't work when Koha is using https If a Koha server is configured to run over SSL, all iDreamBooks content is blocked due to the fact that a secure page is requesting an insecure endpoint. This is due to the fact that the urls for iDreamBooks use http and not https. A simple fix would be to switch them to https since browsers have to qualms about loading a secure data endpoint from an insecure one. Test Plan: 1) Enable iDreamBooks 2) Set up your OPAC to use https 3) Verify iDreamBooks content continues to work Note: tested Chrome and IE, so that the IE change would be validated. Discovered isbn semi-colon issue that is beyond scope of this bug. Signed-off-by: Mark Tompsett mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #21 from Blou philippe.blo...@inlibro.com --- Created attachment 39920 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39920action=edit Bug 13624 - Tidying the atomicupdate file and kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14346] New: t/Biblio.t fails because of new warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14346 Bug ID: 14346 Summary: t/Biblio.t fails because of new warning Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: tomasco...@gmail.com QA Contact: gmcha...@gmail.com Running $ prove t/Biblio.t fails because of us now using DBIx to retrieve sysprefs. Then our mocked DBI is not supported by DBIx hence a warning that makes our test fail (there is one more warning now). The cool thing about this, is that it actually helped spot a situation where GetMarcBiblio is doing wrong things because is not checking its parameters are undefined, so we have the chance to fix it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #20 from Blou philippe.blo...@inlibro.com --- Hi Jonathan, I'll try to reply to these to the best of my knowledge 1) tidying : I'm on it, but I couldn't find much beside 3-4 keywords. No extra space, as this code had been through qa-test before. 2) mediumint : no valid reason whatsoever, reasoning prb lost in time, along with the initial coder. I'll change to int(11) 3) simple ALTER ADD : Well, I remembered trying, so I tried again and could not. The existing constraints, the relation to OTT, the auto_increment... Whatever I tried failed. I won't say it's simpler this way, but I just couldn't make it work otherwise. 4) Took me a while to remember WHY we want it out. I guess it's premature, but this is the first step to allow for unlimited steps, and as such that combo cannot be unique. BUT this being the first step, I cannot justify removing it yet, only that it will be more complicated to remove later. I WILL LEAVE IT IN, you being QA and all ;) Mini Patch coming... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7976] Borrow Permission is not used and can be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #13 from Tomás Cohen Arazi tomasco...@gmail.com --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10938] item columns in different order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10938 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tomás Cohen Arazi tomasco...@gmail.com --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14329] Useless copy/pasta from Template::Plugin::HtmlToText
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14329 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #39838|0 |1 is obsolete|| --- Comment #2 from M. Tompsett mtomp...@hotmail.com --- Created attachment 39915 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39915action=edit Bug 14329: Useless copy/pasta from Template::Plugin::HtmlToText The synopsis of this TT plugin contains two example lines: [% myhtml FILTER html2text(leftmargin = 0, rightmargin = 0) %] [% myhtmltext | html2text %] These lines have been copied (without too much thought :) to a few templates. Since we do no use the variables myhtml or myhtmltext in these templates, these lines are useless. Test plan: [1] Put some items in your cart. And send it. [2] Send a shelf. [3] Git grep on myhtml. Should not have results. NOTE: Sent carts and lists in Intranet and OPAC successfully. Though, this does bring into question why the letters have HTML formatting if it is getting removed. That, however, is beyond the scope of this bug. Signed-off-by: Mark Tompsett mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14329] Useless copy/pasta from Template::Plugin::HtmlToText
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14329 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14346] t/Biblio.t fails because of new warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14346 --- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 39921 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39921action=edit Bug 14346: t/Biblio.t fails because of new warning Running $ prove t/Biblio.t fails because of us now using DBIx to retrieve sysprefs. Then our mocked DBI is not supported by DBIx hence a warning that makes our test fail (there is one more warning now). The cool thing about this, is that it actually helped spot a situation where GetMarcBiblio is doing wrong things because is not checking its parameters are undefined, so we have the chance to fix it. This patch makes GetMarcBiblio return undef if no biblionumber is passed, and also raises a conveniently carped warning. This change is tested in t/Biblio.t with new tests. To test: - In current master, run $ prove t/Biblio.t = FAIL: a test detects a wrong warning count and fails. - Apply the patch and run $ prove t/Biblio.t = SUCCESS: Tests now pass, and there are 2 new ones. - Sign off :-D Regards -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14346] t/Biblio.t fails because of new warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14346 --- Comment #2 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 39922 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39922action=edit Bug 14346: (folowup) Fix previously existing POD This patch makes koha-qa.pl happy by fixing POD issues prior to this bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14346] t/Biblio.t fails because of new warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14346 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14346] t/Biblio.t fails because of new warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14346 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14339] Installer broken by bug 13967
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14339 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12769] Notice fee management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Maxime Beaulieu maxime.beaul...@inlibro.com changed: What|Removed |Added Attachment #39918|0 |1 is obsolete|| --- Comment #17 from Maxime Beaulieu maxime.beaul...@inlibro.com --- Created attachment 39919 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39919action=edit Bug 12769 - Follow up to comments 14 15 Removed useless change in previous patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7232] clicking title on receive should open in new window/tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7232 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #9 from M. Tompsett mtomp...@hotmail.com --- (In reply to Olli-Antti Kivilahti from comment #5) Beating the dead horse... I am sorry but I have to agree with Jonathan and Katrin here. We should teach our librarians to use the browser properly, instead of trying to programmatically fix user errors. +1 Next thing, they'll be using the new tab/window instead of the old one, and they'll nest several layers deep. It just gets ugly. User education is always better. So, although the attached patches likely work correctly, I don't think it is wise to do that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14339] Installer broken by bug 13967
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14339 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #39909|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39917 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39917action=edit [PASSED QA] Bug 14339: C4::Context-preference should return undef if DB is not populated The current behaviour for C4::Context-preference when the DB is not still populated with tables is to return undef. This is used by C4::Auth to identify the need of running the installer. This behaviour got broken by bug 13967, which lets DB errors to escalate and thus Koha gets broken instead of prompting for install. This patch wraps Koha::Config::Sysprefs-find inside an eval and sets undef if needed. To test: - In current master, drop the DB - Load OPAC and Intranet = FAIL: notice an ugly software error. - Apply the patch - Load the OPAC = SUCCESS: Maintenance mode screen is shown - Load Intranet = SUCCESS: You are prompted the DB credentials to run the web installer. - Sign off :-D Tomas Signed-off-by: Mark Tompsett mtomp...@hotmail.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12769] Notice fee management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #16 from Maxime Beaulieu maxime.beaul...@inlibro.com --- Created attachment 39918 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39918action=edit Bug 12769 - Follow up to comments 14 15 The scripts now check if the variable is defined. As for 0 and NULL in the letter's fee column: If the fee is NULL, we use the default value stored in the system preference. If the syspref is 0 or NULL the patron is not charged. If the fee is 0, we use that value and the fine is not created. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Blou philippe.blo...@inlibro.com changed: What|Removed |Added Attachment #38289|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14347] New: Running overdue_notices.pl with --html flag set does not create well structured html
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14347 Bug ID: 14347 Summary: Running overdue_notices.pl with --html flag set does not create well structured html Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: bar...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When overdue_notices.pl creates the email containing un-emailed notices, and the --html flag is set, the resulting file is not a well structured HTML file: * It contains no DTD * There are no html tags * It has no header * The file pointed to by the NoticesCSS syspref *should* be included, but is not * It has no body * The body of the individual messages is wrapped in pre tags, which is unnecessary, ugly, and precludes the use of styling of the notices (If you want unstyled notices, why not use text?) * The file is always named 'attachment.txt' regardless of whether the script is called using the --html or --text flags. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14054] 246 XSLT Improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14054 --- Comment #4 from Nick Clemens n...@quecheelibrary.org --- Should the display force subfield i to occur at the end as with the titles generated by the indicator? (Makes the most sense to me.) I agree, that makes sense -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #21 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39916 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39916action=edit [v3.18.x] Bug 13986 - Printing a list only prints the results of the page you are viewing The print list button only prints the page you are viewing, and not the entire list. Test Plan: 1) Apply this patch 2) Create a list with enough items that it will paginate 3) Browse to that list, click the 'print list' button 4) Note the entire list prints, not just the visible items Tested in staff client, works as expected. It would be great to have the same for OPAC as well (OPAC still prints first page only). Signed-off-by: Marc Veron ve...@veron.ch Signed-off-by: Katrin Fischer katrin.fischer...@web.de Bug 13986 - Implement fix for OPAC Tested wit OPAC, full list is printed. Signed-off-by: Marc Veron ve...@veron.ch Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13662] Serial permissions: receive_serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Josef! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14345] parsed isbn has semi-colon fails to nicely link for idreambooks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14345 --- Comment #1 from M. Tompsett mtomp...@hotmail.com --- Created attachment 39913 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39913action=edit Bug 14345: broken isbn logic prevents display of idreambooks image TEST PLAN - 1) Ensure you have a book that would pull up an idreambooks image (e.g. The road to character / David Brooks.) 2) Ensure your system preferences for idreambook stuff is set. 3) Search for that book in OPAC and go to details. -- There should be a readometer image, but it will be broken. 4) Apply this patch 5) Refresh page -- readometer image appears. YAY! 6) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14345] parsed isbn has semi-colon fails to nicely link for idreambooks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14345 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14344] uninitialized value warning C4/Utils/DataTables/Members.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14344 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #39911|0 |1 is obsolete|| --- Comment #2 from M. Tompsett mtomp...@hotmail.com --- Created attachment 39914 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39914action=edit Bug 14344: uninitialized value warning C4/Utils/DataTables/Members.pm The condition for the assignment depends on $searchtype to be defined and equal to 'contains'. So this change doesn't change the semantics. -if $term !~ /^%/ -and $searchtype eq contain; +if (defined $searchtype) $searchtype eq contain + $term !~ /^%/; To test: - Home - Circulation - Checkout - Search for a user that does not exist (I searched 'whywouldthisexist') on the intranet interface. - Look at the intranet logs = FAIL: you get Use of uninitialized value $searchtype in string eq at.,, - Apply the patch - Repeat the search = SUCCESS: No warning - Sign off :-D NOTE: Other pages are more forgiving. Tweaked test plan. Signed-off-by: Mark Tompsett mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14344] uninitialized value warning C4/Utils/DataTables/Members.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14344 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
