[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #40094|0 |1 is obsolete|| --- Comment #60 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Comment on attachment 40094 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40094 Bug 13799 - Set up logging for Mojolicious. From 17fe4147396127c87be5d0270ad78a7d44576cd5 Mon Sep 17 00:00:00 2001 From: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi Date: Thu, 11 Jun 2015 17:48:54 +0300 Subject: [PATCH] Bug 13799 - Set up logging for Mojolicious. Somebody smarter can set the logging path as dynamic. --- Koha/REST/V1.pm |4 1 file changed, 4 insertions(+) diff --git a/Koha/REST/V1.pm b/Koha/REST/V1.pm index 3becf12..197c17b 100644 --- a/Koha/REST/V1.pm +++ b/Koha/REST/V1.pm @@ -2,10 +2,14 @@ package Koha::REST::V1; use Modern::Perl; use Mojo::Base 'Mojolicious'; +use Mojo::Log; sub startup { my $self = shift; +$self-app-log( Mojo::Log-new( path = /home/koha/koha-dev/var/log/kohaapi.mojo.log, level = 'debug' ) ); + + my $route = $self-routes-under-to( cb = sub { my $c = shift; -- 1.7.9.5 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #59 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 40098 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40098action=edit Bug 13799 - Set up logging and configuration file reading for Mojolicious. Use environmental values to control some aspects of Mojolicious: This way we can have different settings for different servers running Mojolicious. Configuration file $ENV{MOJO_CONFIG} should be set in the system service (init) starting Mojolicious, eg: export MOJO_CONFIG=/home/koha/kohaclone/api/v1/hypnotoad.conf This configuration file read by the Mojolicious::Plugin::Config http://mojolicio.us/perldoc/Mojolicious/Plugin/Config % Logging % Log to a filename configured in an environemnt variable $ENV{MOJO_LOGFILE} using loglevel $ENV{MOJO_LOGLEVEL}. Defaults to '/tmp/koha-api.log' and loglevel of 'error' Examples: export MOJO_LOGFILE=/home/koha/koha-dev/var/log/kohaapi.mojo.log export MOJO_LOGLEVEL=debug Logging is done by Mojo::Log http://www.mojolicio.us/perldoc/Mojo/Log -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #40092|0 |1 is obsolete|| --- Comment #61 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 40099 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40099action=edit Bug 13799 - Adding the REST API as a Hypnotoad service, koha-api-daemon. After running make, the koha-api-daemon.sh -script should be in ../koha-dev/bin/koha-api-daemon.sh Link it to the init-directory and set up upstart triggers: ..$ ln -s /home/koha/koha-dev/bin/koha-api-daemon.sh /etc/init.d/koha-api-daemon ..$ update-rc.d koha-api-daemon defaults Start hypnotoad: ..$ service koha-api-daemon start Hypnotoad is now listening in 127.0.0.1:8080 and is preconfigured to be production ready. Hypnotoad config is in $KOHA_PATH/api/v1/hypnotoad.conf For more info, read the koha-api-daemon.sh -service -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #8 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 40103 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40103action=edit The floating matrix control panel where you configure the 4 types of floating between routes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #7 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 40102 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40102action=edit Admin menu screenshot, how to navigate to the control panel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13663] offline circ permission issue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13663 Alex Arnaud alex.arn...@biblibre.com changed: What|Removed |Added Assignee|claire.hernandez@biblibre.c |alex.arn...@biblibre.com |om | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Alex Arnaud alex.arn...@biblibre.com changed: What|Removed |Added QA Contact|koha-b...@lists.koha-commun |alex.arn...@biblibre.com |ity.org | Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #9 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- This screenshot: The floating matrix control panel where you configure the 4 types of floating between routes. Explains how to use this feature. Then just check-in Items and they float based on the rules. If you don't want to use this feature, don't set any floating routes and it is completely unintrusive. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #10 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Thanks for pushing Bernardo. I hope images are worth more than 100 words ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #6 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- (In reply to Olli-Antti Kivilahti from comment #5) But it is a nice feature and works remarkably well for us. Great :) Is it possible a short description of the use case scenario? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #5 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- But it is a nice feature and works remarkably well for us. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #4 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Hi Bernardo. Sorry I must focus on other things. I am happy I even managed to rebase and push all things to bugzilla. If you like it, you can write a test plan. Tho I am 100% sure the dependencies will go stale in 1 week and then nobody but a programmer can test this :) And that kind of testing implies a code review. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add API routes for issues retrieval and renewal
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #37146|0 |1 is obsolete|| --- Comment #2 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 40104 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40104action=edit Bug 13895: Add API routes for issues retrieval and renewal GET /borrowers/{borrowernumber}/issues GET /borrowers/{borrowernumber}/issues/{itemnumber} PUT /borrowers/{borrowernumber}/issues/{itemnumber} + unit tests in t/db_dependent/api/v1/borrowers/issues.t Test plan: 1/ Go to http://api.yourlibrary/v1/doc and test the above routes with different values for each parameter 2/ Try to renew the same issue (with PUT) until the maximum number of renewals is reached (you should have a 403 error then) 3/ Run unit tests in t/db_dependent/api/v1/borrowers/issues.t Depends on bugg 13799 FOLLOWUP 1: -- Rebased t/db_dependent/api/v1/borrowers/issues.t because C4::Circulation::AddIssue() was changed to return a DBIx-object, by Bugg 13315 which should have nothing to do modifying AddIssue()-function. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Alex Arnaud alex.arn...@biblibre.com changed: What|Removed |Added Assignee|fridolyn.som...@biblibre.co |alex.arn...@biblibre.com |m | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 Alex Arnaud alex.arn...@biblibre.com changed: What|Removed |Added Assignee|julian.maur...@biblibre.com |alex.arn...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Alex Arnaud alex.arn...@biblibre.com changed: What|Removed |Added Assignee|julian.maur...@biblibre.com |alex.arn...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #44 from Alex Arnaud alex.arn...@biblibre.com --- Created attachment 40100 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40100action=edit [follow-up] Bug 6810 - Fix QA failures - Use KohaDates to convert dateexpiry - remove MYSQL specifics methods for date handling in GetUpcomingMembershipExpires - make the script membership_expiry.pl write in Koha system logs - add tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #40093|0 |1 is obsolete|| --- Comment #62 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 40101 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40101action=edit Bug 13799 - Nginx reverse proxy config baseline for Koha REST API. Tweaking needed to work with makefile. Uses a self-signed SSL-certificate to service at port 444 by default. Reverse proxies to 127.0.0.1:8080 (expecting hypnotoad to be listening) ¤¤ ¤¤ Koha API Nginx configuration ¤¤ ¤¤ Deploy the Nginx configuration -- Run make to populate the koha-nginx-kohaapi.conf link to the /etc/nginx/sites-available/ -directory ..$ ln -s /home/koha/koha-dev/etc/koha-nginx-kohaapi.conf /etc/nginx/sites-available/kohaapi and enable with command ..$ ln -s /etc/nginx/sites-available/kohaapi /etc/nginx/sites-enabled/kohaapi Disable the default config ..$ rm /etc/nginx/sites-enabled/default Create a openssl self-signed certificate or use your own. - ..$ cd /etc/nginx ..$ mkdir ssl ..$ chmod 400 ssl ..$ cd ssl ..$ openssl req -x509 -sha256 -newkey rsa:2048 -keyout key.pem.secure -out cert.pem -days 720 ..$ openssl rsa -in key.pem.secure -out key.pem ..$ chmod 400 * Restart nginx ..$ service nginx restart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14345] parsed isbn has semi-colon fails to nicely link for idreambooks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14345 --- Comment #4 from Nick Clemens n...@quecheelibrary.org --- (In reply to Nick Clemens from comment #3) Took me a while here, the missing step is Have an ISBN ending in ; (with no space before the punctuation) It fixes a problem caused by questionable punctuation in record, but it doesn't hurt anything that I see Ah, forgive me, this actually crops up when you have more than one isbn or an ISBN with no punctuation. It's pulling the isbn from the document so any added punctuation (semicolon between multiples or period if single) is breaking the link. Seems to be affecting both SSL and non-SSL as well -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14359] RDA: 700/710/711 display in XSLT Bug fix for Contributors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14359 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14359] RDA: 700/710/711 display in XSLT Bug fix for Contributors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14359 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Attachment #39970|0 |1 is obsolete|| --- Comment #2 from Nick Clemens n...@quecheelibrary.org --- Created attachment 40108 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40108action=edit [SIGNED OFF] Bug 14359 - RDA: 700/710/711 display in XSLT Bug fix for Contributors Corrects contributors display and corrects path to search icon for authority records. Signed-off-by: Nick Clemens n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14094] DDC - Add separators for repeated $a subfields (MARC21)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14094 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Attachment #40097|0 |1 is obsolete|| --- Comment #10 from Nick Clemens n...@quecheelibrary.org --- Created attachment 40107 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40107action=edit [SIGNED OFF] Bug 13600 - XSLT: 8xx not showing if there is no 4xx Removes dependency on 490 ind1 for 8xx display. 8xx will always display. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac details view. 3) Find or create a record with MARC tags 800, 810, 830 4) Check display of 8xx tags, should always display if present in the record. 6) Repeat test for the staff interface Signed-off-by: Nick Clemens n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14094] DDC - Add separators for repeated $a subfields (MARC21)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14094 --- Comment #2 from Nick Clemens n...@quecheelibrary.org --- Created attachment 40109 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40109action=edit [SIGNED OFF] Bug 14094: DDC - Add separators for repeated $a subfields (MARC21) Mulitple 082 fields are already separated by |, but multiple $a in one 082 field were only separated by space, making those not easy to read. Patch takes care that the | separator is used in all cases. To test: - Catalog a record with multiple 082 fields - Add one or multiple $a subfields to each - Verify every single classification is separated from the others with a | in staff and in OPAC detail pages Signed-off-by: Nick Clemens n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14345] parsed isbn has semi-colon fails to nicely link for idreambooks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14345 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added CC||n...@quecheelibrary.org --- Comment #3 from Nick Clemens n...@quecheelibrary.org --- Took me a while here, the missing step is Have an ISBN ending in ; (with no space before the punctuation) It fixes a problem caused by questionable punctuation in record, but it doesn't hurt anything that I see -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14054] 246 XSLT Improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14054 --- Comment #7 from Nick Clemens n...@quecheelibrary.org --- Looking very good! Going back to the initial bug filing, I think 246 2nd indicator should display for first indicator either 0 or 1. According to MARC the values are: First Indicator Note/added entry controller 0 - Note, no added entry 1 - Note, added entry 2 - No note, no added entry 3 - No note, added entry I don't know if 2 or 3 actually means you are not supposed to display the title at all, but I always prefer seeing it so am not rocking that boat unless someone else wants to chime in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Attachment #40106|0 |1 is obsolete|| Attachment #40106|1 |0 is patch|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14345] parsed isbn has semi-colon fails to nicely link for idreambooks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14345 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Attachment #39913|0 |1 is obsolete|| --- Comment #2 from Nick Clemens n...@quecheelibrary.org --- Created attachment 40105 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40105action=edit Bug 14345: broken isbn logic prevents display of idreambooks image TEST PLAN - 1) Ensure you have a book that would pull up an idreambooks image (e.g. The road to character / David Brooks.) 2) Ensure your system preferences for idreambook stuff is set. 3) Search for that book in OPAC and go to details. -- There should be a readometer image, but it will be broken. 4) Apply this patch 5) Refresh page -- readometer image appears. YAY! 6) run koha qa test tools Signed-off-by: Nick Clemens n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14345] parsed isbn has semi-colon fails to nicely link for idreambooks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14345 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added CC||n...@quecheelibrary.org --- Comment #11 from Nick Clemens n...@quecheelibrary.org --- This works as described and is an improvement so signing off. All below are just wishlist: Punctuation could be better, between fields is ';' would be nice to see as '|' as on others Also, 8xx fields seems to be ending in ':' regardless of field ending in record Would also be nice to have some indication between author/title in the 8xx, maybe title in italics? (And apologies for mis-attached patch earlier) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #9 from Nick Clemens n...@quecheelibrary.org --- Created attachment 40106 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40106action=edit Bug 14280: Add branches fields to discharges letters Currently, when generating a discharge letter, branches fields are not translated in the letter (branches.branchname, branches.branchaddress1, etc.) This patch fixes that. How I tested: - Set syspref 'useDischarge' to 'allow' - Go to Home Tools Notices Slips - Edit DISCHARGE, add to 'Email message': pbranches.branchnamebr / branches.branchaddress1br / branches.branchaddress2br / branches.branchaddress3br / branches.zip branches.citybr / /p - Go to detail page of a patron discharge - Click 'Generate discharge' - Verify that the PDF contains the information above. Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Katrin Fischer katrin.fischer...@web.de Signed-off-by: Tomas Cohen Arazi tomasco...@unc.edu.ar Signed-off-by: Nick Clemens n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14380] New: Overriding fine on renewal will cause duplicate fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14380 Bug ID: 14380 Summary: Overriding fine on renewal will cause duplicate fines Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: bar...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Overriding fine on renewal will cause duplicate fines. Because we use the due date in accountlines.description, and fines.pl uses accountlines.description to uniquely identify fines on update, changing date_due will create duplicate entries in accountlines. select date, amount, description, accounttype, amountoutstanding, lastincrement, timestamp from accountlines where itemnumber = 35540 and borrowernumber = 24990\G *** 1. row *** date: 2015-05-05 amount: 0.50 description: O'Connor's annotated criminal codes plus. 05/04/2015 11:59 PM accounttype: F amountoutstanding: 0.50 lastincrement: 0.50 timestamp: 2015-06-08 12:42:27 *** 2. row *** date: 2015-06-08 amount: 4.50 description: O'Connor's annotated criminal codes plus. 05/26/2015 11:59 PM accounttype: FU amountoutstanding: 4.50 lastincrement: 0.50 timestamp: 2015-06-08 02:02:40 2 rows in set (0.00 sec) Looking in old_issues, you can see that the item was renewed, and that date_due does match the second description... only the first accountlines entry is marked woth accounttype 'F' on return, however. select date_due, returndate, lastreneweddate, renewals, timestamp, issuedate from old_issues where itemnumber = 35540 and borrowernumber = 24990\G *** 1. row *** date_due: 2015-05-26 23:59:00 returndate: 2015-06-08 12:42:27 lastreneweddate: 2015-05-05 00:00:00 renewals: 1 timestamp: 2015-06-08 12:42:27 issuedate: 2015-04-13 09:23:20 To replicate: 1) check out an item 2) let the item go overdue and start accruing fines 3) renew the item 4) let the item go overdue again. Note that a second accountlines entry has been added 5) return the item. Note that only one accountlines entry is marked with accounttype 'F'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14381] New: viewlog bug
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14381 Bug ID: 14381 Summary: viewlog bug Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcha...@gmail.com Reporter: long_sam...@yahoo.com.tw QA Contact: testo...@bugs.koha-community.org Created attachment 40110 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40110action=edit viewlog Dear koha floks, I found viewlog bugs. If you turn on [ExtendedPatronAttributes], then view Home › Patrons › Modification log Software error: Undefined subroutine main::GetBorrowerAttributes called at /usr/share/koha/intranet/cgi-bin/tools/viewlog.pl line 82. The attachment has more infromation. Help me patch. Thanks a lot. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5770] email librarian when purchase suggestion made
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added CC||indr...@gmail.com Assignee|koha-b...@lists.koha-commun |indr...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Christopher Bloomfield c_bloomfie...@hotmail.com changed: What|Removed |Added CC||c_bloomfie...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14379] New: Batch item modification tool - Can't change custom subfields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14379 Bug ID: 14379 Summary: Batch item modification tool - Can't change custom subfields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: gmcha...@gmail.com Reporter: pablo.bian...@gmail.com QA Contact: testo...@bugs.koha-community.org On a framework a librarian create custom item subfields, like withdrawn date or date when item was sent to bookbinding sector ($D, uppercase). Batch item modification tool (batchMod.pl) doesn't let you change this new item subfields (saved on more_subfields_xml). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Hi, nice feature! Can you please add a test plan? Also some files need a Licence and others need an updated one (from 2 - 3) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1232] Add Invoice/Credit/Fines Payed For Day on Issues (Print Page) (Print Slip)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1232 Cab Vinton direc...@plaistowlibrary.com changed: What|Removed |Added CC||direc...@plaistowlibrary.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added CC||neng...@gmail.com --- Comment #6 from Nicole C. Engard neng...@gmail.com --- Has anyone confirmed that this is still an issue/resolved? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Cab Vinton direc...@plaistowlibrary.com changed: What|Removed |Added CC||direc...@plaistowlibrary.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 Cab Vinton direc...@plaistowlibrary.com changed: What|Removed |Added CC||direc...@plaistowlibrary.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13498] ISSUESLIP, ISSUEQSLIP use 'email' template for print.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498 Cab Vinton direc...@plaistowlibrary.com changed: What|Removed |Added CC||direc...@plaistowlibrary.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14378] New: koha-run-backups should check disk usage first
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14378 Bug ID: 14378 Summary: koha-run-backups should check disk usage first Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcha...@gmail.com Reporter: pablo.bian...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz Naively I increase --days koha-run-backups parameter too high (30) letting disc out of space. It could be a nice enhancement: + Check disk space before generating files (for eg with fallocate: preallocate space to a file)) + and/or sacrifice/remove older backup. + option to backup indefinitely until destination dir/partition grow up to a given percentage (lets say 95 (%)). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/