[Koha-bugs] [Bug 12395] Save order line's creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Alex Arnaud alex.arn...@biblibre.com changed: What|Removed |Added Attachment #36079|0 |1 is obsolete|| --- Comment #57 from Alex Arnaud alex.arn...@biblibre.com --- Created attachment 40134 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40134action=edit Bug 12395: Fix call to set_userenv in unit tests Signed-off-by: Paola Rossi paola.ro...@cineca.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Alex Arnaud alex.arn...@biblibre.com changed: What|Removed |Added Attachment #36075|0 |1 is obsolete|| Attachment #36076|0 |1 is obsolete|| Attachment #36077|0 |1 is obsolete|| --- Comment #55 from Alex Arnaud alex.arn...@biblibre.com --- Created attachment 40132 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40132action=edit Bug 12395: Save order line's creator New MySQL column: aqorders.createdby Creator's name is displayed on order's receive pages (acqui/orderreceive.pl and acqui/parcel.pl) On acqui/orderreceive.pl it replace the name of basket's creator On acqui/parcel.pl, to avoid adding more data in the table of pending orders, it is shown in a popup like MARC and Card views Test plan: 1/ Run updatedatabase.pl 2/ Create a new order and go to the receipt page (acqui/parcel.pl) 3/ Click on Order link in column More (previously View record) 4/ A javascript popup should appear with your name in it. Close the popup. 5/ Click on Receive link 6/ Your name should appear in front of Created by label, to the right of the page. Patch updated with use of atomic update. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Alex Arnaud alex.arn...@biblibre.com changed: What|Removed |Added Attachment #36080|0 |1 is obsolete|| --- Comment #58 from Alex Arnaud alex.arn...@biblibre.com --- Created attachment 40135 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40135action=edit Bug 12395: Display created_by even if firstname is missing on receiving On receiving orders, no name was displayed if the firstname of creator was not filled. The surname should be displayed. Signed-off-by: Paola Rossi paola.ro...@cineca.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Alex Arnaud alex.arn...@biblibre.com changed: What|Removed |Added Attachment #36078|0 |1 is obsolete|| --- Comment #56 from Alex Arnaud alex.arn...@biblibre.com --- Created attachment 40133 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40133action=edit Bug 12395: Add unit test to check created_by is correctly set Signed-off-by: Paola Rossi paola.ro...@cineca.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added CC||paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14376] Allow the librarian to choose a patron when entering a purchase suggestion
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #5 from Indranil Das Gupta indr...@gmail.com --- Hi Matthias, (In reply to Matthias Meusburger from comment #4) Created attachment 40131 [details] [review] Bug 14376: Allow the librarian to choose a patron when entering a purchase suggestion. Sometimes librarians are creating purchase suggestions that came from patrons which didn't use the opac (but sent an email, or told the librarian verbally...) This patch allows the librarian to change the creator of the purchase suggestion when entering it. The fact that Suggestion creation was pre-filled and not editable, served an important function. It created a de-facto audit trail and helped maintain accountability. By making it editable, this patch is taking that function away, without something to replace it. So I disagree with this patch in its present shape. This bug does have merit though and does address a valid concern. My observations: 1/ Needs additional column in 'suggestions' say 'source' (i.e. of suggestion) with options - 'OPAC|STAFF CLIENT|EMAIL|PHONE|LETTER|OTHER' 2/ Keep the field locked with pre-filled values (current behaviour) with say a check box to edit/change it 3/ Log the edit. Setting this to 'In Discussion' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 Zeno Tajoli z.taj...@cineca.it changed: What|Removed |Added CC||z.taj...@cineca.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14384] Add option to koha-run-backups, to disable koha instance during backup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14384 --- Comment #2 from Mason James m...@kohaaloha.com --- (In reply to Robin Sheat from comment #1) Why? This option would nicely fix a problem when backing up a ‘large’ Koha, that takes some hours to complete. Large koha instances can accumulate many stalled perl processes, when their databases are locked during backup. Eventually, mysql could hang or crash, and the server will become unstable :) The option to ‘disable’ Koha instances for the duration of their backup, would stop this problem from occurring -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #40141|0 |1 is obsolete|| --- Comment #68 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 40142 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40142action=edit Bug 13799 - Adding the REST API as a Hypnotoad service, koha-api-daemon. After running make, the koha-api-daemon.sh -script should be in ../koha-dev/bin/koha-api-daemon.sh Link it to the init-directory and set up upstart triggers: ..$ ln -s /home/koha/koha-dev/bin/koha-api-daemon.sh /etc/init.d/koha-api-daemon ..$ update-rc.d koha-api-daemon defaults Start hypnotoad: ..$ service koha-api-daemon start Hypnotoad is now listening in 127.0.0.1:8080 and is preconfigured to be production ready. Hypnotoad config is in $KOHA_PATH/api/v1/hypnotoad.conf For more info, read the koha-api-daemon.sh -service -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Alex Arnaud alex.arn...@biblibre.com changed: What|Removed |Added Attachment #40134|0 |1 is obsolete|| --- Comment #61 from Alex Arnaud alex.arn...@biblibre.com --- Created attachment 40138 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40138action=edit Bug 12395: Fix call to set_userenv in unit tests Signed-off-by: Paola Rossi paola.ro...@cineca.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14366] Units doesn't get saved usefully for patroncards
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14366 --- Comment #7 from Chris Nighswonger cnighswon...@foundations.edu --- (In reply to David Cook from comment #6) (In reply to Chris Nighswonger from comment #3) (In reply to David Cook from comment #2) Of course... I'm not sure that the actual label creator is using the different units... that's fun... User selected units are converted to postscript points before rendering. Postscript points are the common denominator. Are you certain? I tried changing a label by 1cm but it looks like it only changed by 1pt. I haven't had time to look into this yet, unfortunately :/. Point conversions are done here: http://tinyurl.com/o99ve52 This bug is addressing the fact that labels do not save the user's preferred UOM, which explains the phenomena you are describing. The real fix is for the labels code to be refactored to save templates as xml as patroncard code does. That was my long-term intention when I wrote the patroncard feature. Of course, even the best of intentions never materialize at times. :-P -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14380] Overriding fine on renewal will cause duplicate fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14380 --- Comment #2 from Barton Chittenden bar...@bywatersolutions.com --- (In reply to Katrin Fischer from comment #1) Hm, I thimk the problem is not that there are 2 entries in accountlines - that seems correct to me, but both should be set to the same type on return? I feel that there should be no more than one entry in accountlines for a given row in the issues table... but the underlying problem is that using description as a lookup in the accountlines table is fundamentally broken. Bug 13790 adds a unique id to issues/old_issues -- adding a corresponding foreign key to accountlines table would fix the bug going forward. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799
Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:
What|Removed |Added
Attachment #40098|0 |1
is obsolete||
--- Comment #66 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 40140
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40140action=edit
Bug 13799 - Set up logging and configuration file reading for Mojolicious.
Use environmental values to control some aspects of Mojolicious:
This way we can have different settings for different servers running
Mojolicious.
Configuration file
$ENV{MOJO_CONFIG} should be set in the system service (init) starting
Mojolicious, eg:
export MOJO_CONFIG=/home/koha/kohaclone/api/v1/hypnotoad.conf
This configuration file read by the Mojolicious::Plugin::Config
http://mojolicio.us/perldoc/Mojolicious/Plugin/Config
% Logging %
NOTE!!
There is a feature in Mojo::Server disabling STDOUT and STDERR, because such
errors are not-suited-for-prod~
This modification in Mojo::Server disables this and preserves the STD* handles
for forked server threads
in Mojo::Server::daemonize(), comment out the following lines
# Close filehandles
# open STDOUT, '/dev/null';
# open STDERR, 'STDOUT';
Log to a filename configured in an environemnt variable $ENV{MOJO_LOGFILE}
using loglevel $ENV{MOJO_LOGLEVEL}.
Defaults to '/tmp/koha-api.log' and loglevel of 'error'
Examples:
export MOJO_LOGFILE=/home/koha/koha-dev/var/log/kohaapi.mojo.log
export MOJO_LOGLEVEL=debug
Logging is done by Mojo::Log
http://www.mojolicio.us/perldoc/Mojo/Log
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Alex Arnaud alex.arn...@biblibre.com changed: What|Removed |Added Attachment #40132|0 |1 is obsolete|| --- Comment #59 from Alex Arnaud alex.arn...@biblibre.com --- Created attachment 40136 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40136action=edit Bug 12395: Save order line's creator New MySQL column: aqorders.createdby Creator's name is displayed on order's receive pages (acqui/orderreceive.pl and acqui/parcel.pl) On acqui/orderreceive.pl it replace the name of basket's creator On acqui/parcel.pl, to avoid adding more data in the table of pending orders, it is shown in a popup like MARC and Card views Test plan: 1/ Run updatedatabase.pl 2/ Create a new order and go to the receipt page (acqui/parcel.pl) 3/ Click on Order link in column More (previously View record) 4/ A javascript popup should appear with your name in it. Close the popup. 5/ Click on Receive link 6/ Your name should appear in front of Created by label, to the right of the page. Patch updated with use of atomic update. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Alex Arnaud alex.arn...@biblibre.com changed: What|Removed |Added Attachment #40133|0 |1 is obsolete|| --- Comment #60 from Alex Arnaud alex.arn...@biblibre.com --- Created attachment 40137 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40137action=edit Bug 12395: Add unit test to check created_by is correctly set Signed-off-by: Paola Rossi paola.ro...@cineca.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Alex Arnaud alex.arn...@biblibre.com changed: What|Removed |Added Attachment #40135|0 |1 is obsolete|| --- Comment #62 from Alex Arnaud alex.arn...@biblibre.com --- Created attachment 40139 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40139action=edit Bug 12395: Display created_by even if firstname is missing on receiving On receiving orders, no name was displayed if the firstname of creator was not filled. The surname should be displayed. Signed-off-by: Paola Rossi paola.ro...@cineca.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14380] Overriding fine on renewal will cause duplicate fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14380 --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I think I disagree about the 'one line'. Once you renew the overdue process restarts and is not in any way related to the first one, I'd avoid mixing the data. It would make it really hard to see why the amount is as high as it is. With the 2 different due dates you get a clear clue. I see a renewal more like a new checkout - only that Koha doesn't treat a renewal as a new checkout as some other systems do (which is fine!). But I totally agree about the description being misused. I think we need to think about this a bit more and should note it as a use case/test case we need to test and make sure works properly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #40099|0 |1 is obsolete|| --- Comment #67 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 40141 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40141action=edit Bug 13799 - Adding the REST API as a Hypnotoad service, koha-api-daemon. After running make, the koha-api-daemon.sh -script should be in ../koha-dev/bin/koha-api-daemon.sh Link it to the init-directory and set up upstart triggers: ..$ ln -s /home/koha/koha-dev/bin/koha-api-daemon.sh /etc/init.d/koha-api-daemon ..$ update-rc.d koha-api-daemon defaults Start hypnotoad: ..$ service koha-api-daemon start Hypnotoad is now listening in 127.0.0.1:8080 and is preconfigured to be production ready. Hypnotoad config is in $KOHA_PATH/api/v1/hypnotoad.conf For more info, read the koha-api-daemon.sh -service -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13995] Proper Exception handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #64 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- (In reply to Robin Sheat from comment #63) How will that interact with Plack? Environment variables aren't the easiest thing to pass through to that at this stage. I think this will be overwritten by plack. I just created this system because there was no other system published in bugzilla for me to start building stuff on top of the Koha REST API. I think the big question is how to pass variables to Mojolicious app, without using env-variables. I don't know and the solution is good enough for me. What I would be worried of, is the redirection of STDERR and STDOUT to /dev/null in Mojo::Server::damonize(). Thus logging those streams from the service-script doesn't work, but it works when running Mojolicious directly from the terminal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #65 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Maybe we could add some of the open questions/topics to the wiki? The next dev meeting is supposed to be mostly about the RESTful API. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10063] Correct the documentation for the C4:Members sub: IsMemberBlocked
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10063] Correct the documentation for the C4:Members sub: IsMemberBlocked
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #39972|0 |1 is obsolete|| --- Comment #5 from M. Tompsett mtomp...@hotmail.com --- Created attachment 40145 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40145action=edit Bug 10063: Correct documentation of C4::Members::IsMemberBlocked Rephrased documentation a bit, replacing fine days with the more general term restriction. As IsDebarred checks for existing active restrictions. TEST PLAN - 1) apply patch 2) git diff origin/master -- do the changes make sense 3) perldoc C4::Members -- look for the IsMemberBlocked. -- Does it reflect current state 4) koha qa test tools Signed-off-by: Mark Tompsett mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add API routes for issues retrieval and renewal
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895
Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:
What|Removed |Added
Attachment #40104|0 |1
is obsolete||
--- Comment #3 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 40143
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40143action=edit
Bug 13895: Add API routes for issues retrieval and renewal
GET /borrowers/{borrowernumber}/issues
GET /borrowers/{borrowernumber}/issues/{itemnumber}
PUT /borrowers/{borrowernumber}/issues/{itemnumber}
+ unit tests in t/db_dependent/api/v1/borrowers/issues.t
Test plan:
1/ Go to http://api.yourlibrary/v1/doc and test the above routes with
different values for each parameter
2/ Try to renew the same issue (with PUT) until the maximum number of
renewals is reached (you should have a 403 error then)
3/ Run unit tests in t/db_dependent/api/v1/borrowers/issues.t
Depends on bugg 13799
FOLLOWUP 1:
--
Rebased t/db_dependent/api/v1/borrowers/issues.t because
C4::Circulation::AddIssue()
was changed to return a DBIx-object, by Bugg 13315 which should have nothing to
do
modifying AddIssue()-function.
Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi
Unit tests pass 100%
Tested the new API calls using Swagger2
Triggered error cases:
-Too many renewals.
-Item not checked out or checked out to the wrong borrower.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #12 from Winona Salesky wsale...@gmail.com --- These are all simple additions and can be added. I will have an amended patch up by tonight. Thanks for the feedback! -Winona (In reply to Nick Clemens from comment #11) This works as described and is an improvement so signing off. All below are just wishlist: Punctuation could be better, between fields is ';' would be nice to see as '|' as on others Also, 8xx fields seems to be ending in ':' regardless of field ending in record Would also be nice to have some indication between author/title in the 8xx, maybe title in italics? (And apologies for mis-attached patch earlier) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14387] New: Merge reference selection has no effect when merging authorities.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14387 Bug ID: 14387 Summary: Merge reference selection has no effect when merging authorities. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: maxime.beaul...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl When merging authority records, the merge reference is always set to the first selected record. How to reproduce: 0 Create authorities/reindex if necessary. 1 Search for authorities 2 Click merge on two entries (Keep note of the CLICK order 12) 3 Select the second authority (authority 2) as merge reference 4 In the following page: The authid in the tabs are correct. The record data is wrong. First tab is authority 1, second is authority 2. The resulting record is generated using authority 1 as reference. A patch will follow. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #13 from Heather heather_hernan...@nps.gov --- (In reply to Winona Salesky from comment #12) These are all simple additions and can be added. I will have an amended patch up by tonight. Thanks for the feedback! -Winona (In reply to Nick Clemens from comment #11) This works as described and is an improvement so signing off. All below are just wishlist: Punctuation could be better, between fields is ';' would be nice to see as '|' as on others Also, 8xx fields seems to be ending in ':' regardless of field ending in record Would also be nice to have some indication between author/title in the 8xx, maybe title in italics? (And apologies for mis-attached patch earlier) An indication between author title in the 800 810 would be great, but I think that if the title were in italics, it would be the only italics in the display. Also, no other titles in displays are in italics, and some of the other bib systems (e.g., Worldcat.org) don't display titles in italics. The MARC21 format recommends a period/full stop between authors titles in most (or all) fields, and the author title would be hyperlinked clickable, right? So something like in our catalog, with the series hyperlinked, e.g. in this record, with the comma after Patrick replaced with a period/full stop? http://keys.bywatersolutions.com/cgi-bin/koha/opac-detail.pl?biblionumber=3286 Series: O'Brian, Patrick. Aubrey/Maturin novels: 1. --heather -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #65 from Alex Arnaud alex.arn...@biblibre.com --- What I could think of as enh: - create a view page for an order line that is still accessible after the basket has been closed (similar to suggestions) and show it there. Could ascqui/showorder.pl be this view page ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10063] Correct the documentation for the C4:Members sub: IsMemberBlocked
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10063 --- Comment #4 from M. Tompsett mtomp...@hotmail.com --- Comment on attachment 39972 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39972 Bug 10063: Correct documentation of C4::Members::IsMemberBlocked Review of attachment 39972: -- (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=10063attachment=39972) - ::: C4/Members.pm @@ +531,4 @@ FIXME: this needs to be split into two functions; a potential block based on the number of current overdue items could be orthogonal +to a block based on whether the patron has any restrictions. I'm not sure this FIXME is relevant any more. We have the Debarment function and surely there is a function in C4::Overdues which can be used to get the issues overdue count. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #64 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hm, I think it would have to be basket.pl currently - but we already got a lot of information there. I think it's not a blocker. What I could think of as enh: - create a view page for an order line that is still accessible after the basket has been closed (similar to suggestions) and show it there. - add colvis to the basket page, so the library can decide if it wants to display it or not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14387] Merge reference selection has no effect when merging authorities.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14387 --- Comment #1 from Maxime Beaulieu maxime.beaul...@inlibro.com --- Created attachment 40144 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40144action=edit Bug 14387 - Merge reference selection has no effect when merging authorities. This patch swaps the authority records according to the reference record selection. To TEST: Merge two authority records, select the second as merge reference. The reference authority is always the first. Apply the patch. Repeat previous steps, the authority is now merged using the selected reference record. modified: authorities/merge.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14387] Merge reference selection has no effect when merging authorities.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14387 Maxime Beaulieu maxime.beaul...@inlibro.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14386] New: Use 856 Ind. 2 to show links to full text and to related resources separately (MARC21)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14386 Bug ID: 14386 Summary: Use 856 Ind. 2 to show links to full text and to related resources separately (MARC21) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcha...@gmail.com Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Sometimes a record has a lot of links to catalog enrichments (cover, cover text, toc, abstract, etc.) and also a full text link. With not all links having a nice link text that can get pretty confusing to patrons. In the standard, indicator 2 tells you, which link should be the full text link and which are links to related resources. We should use those to show nice labels for each type. http://www.loc.gov/marc/bibliographic/bd856.html Second Indicator Relationship # - No information provided 0 - Resource 1 - Version of resource 2 - Related resource 8 - No display constant generated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14387] Merge reference selection has no effect when merging authorities.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14387 Maxime Beaulieu maxime.beaul...@inlibro.com changed: What|Removed |Added CC||eric.be...@inlibro.com, ||maxime.beaul...@inlibro.com ||, ||philippe.blo...@inlibro.com Assignee|gmcha...@gmail.com |maxime.beaul...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add API routes for issues retrieval and renewal
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added CC||olli-antti.kivila...@jns.fi Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10874] Incremental fine system for various types of documents and patron categories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10874 Amit amitddng...@gmail.com changed: What|Removed |Added CC||amitddng...@gmail.com Assignee|koha-b...@lists.koha-commun |amitddng...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10874] Incremental fine system for various types of documents and patron categories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10874 Amit amitddng...@gmail.com changed: What|Removed |Added CC||indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14054] 246 XSLT Improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14054 --- Comment #8 from Winona Salesky wsale...@gmail.com --- Anyone else have an opinion on the first indicator? Should 246 only display for ind1=1 or 0? Thanks! -Winona (In reply to Nick Clemens from comment #7) Looking very good! Going back to the initial bug filing, I think 246 2nd indicator should display for first indicator either 0 or 1. According to MARC the values are: First Indicator Note/added entry controller 0 - Note, no added entry 1 - Note, added entry 2 - No note, no added entry 3 - No note, added entry I don't know if 2 or 3 actually means you are not supposed to display the title at all, but I always prefer seeing it so am not rocking that boat unless someone else wants to chime in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Alex Arnaud alex.arn...@biblibre.com changed: What|Removed |Added CC||alex.arn...@biblibre.com --- Comment #63 from Alex Arnaud alex.arn...@biblibre.com --- (In reply to Katrin Fischer from comment #54) Starting on this... - QA script OK - Code review OK --- 1) New test is failing for me: not ok 8 - Koha::Acquisition::Order-insert set created_by to logged in user if not given # Failed test 'Koha::Acquisition::Order-insert set created_by to logged in user if not given' # at t/db_dependent/Acquisition/NewOrder.t line 91. # got: undef # expected: '42' # Looks like you failed 1 test of 8. Katrin, this typically occurs when created_by key is missing in Koha/Schema/Result/Aqorder.pm. Did you run misc/devel/update_dbix_class_files.pl ? 2) Why only display the order line creator during the receive process, but not on the order pages? We can only see the basket creator there. I'm not sur to understand where you want to add the creator again. Is it in basket.pl ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10874] Incremental fine system for various types of documents and patron categories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10874 --- Comment #3 from Amit amitddng...@gmail.com --- I would like to work on this feature will try to complete this feature in next release of Koha (3.22). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14387] Merge reference selection has no effect when merging authorities.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14387 Maxime Beaulieu maxime.beaul...@inlibro.com changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10874] Incremental fine system for various types of documents and patron categories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10874 --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Amit, there are currently some other patches pending about fines/overdues - some information to the related bugs can be found on the wiki: http://wiki.koha-community.org/wiki/Overdue_Notice_Enhancement Could you maybe add some description on how you want to add this feature and where it would be configured? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3333] item status for not for loan by item type / item is different
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id= David Cook dc...@prosentient.com.au changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #7 from David Cook dc...@prosentient.com.au --- (In reply to Owen Leonard from comment #3) It looks like the current exception is: - Staff client display - The item's item type is designated as not for loan - The item record itself has no not-for-loan status set In this case the item appears as Available. I think that Owen's comment here is still relevant as well - at least as of 3.14.5. I don't know if I should splinter that off into its own bug or attach another patch as well to bring the staff client into line with the OPAC? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5025] discrepancy between opac doc-head-open.inc and staff doc-head-open.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #5 from M. Tompsett mtomp...@hotmail.com --- I agree with the idea of moving title and /title out of two separate include files into the actual template file. Congratulations on such an undertaking, Aleisha. However, after looking over the 63 modified files, I found a few that I don't agree with the placement of /title. Given that this does not apply, and that there is yet no do it from the GUI test plan, I'll be submitting a patch that I'm happier with along with a full test plan including how to construct URLs to test. However, I need sleep before constructing the test plan. :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5025] discrepancy between opac doc-head-open.inc and staff doc-head-open.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Assignee|oleon...@myacpl.org |aleishaamo...@hotmail.com --- Comment #6 from M. Tompsett mtomp...@hotmail.com --- I'm updating the assigned to, so that Aleisha is aware of the status of this, since this is currently her patch here. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14393] New: Add collection code filter to inventory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 Bug ID: 14393 Summary: Add collection code filter to inventory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcha...@gmail.com Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org Add the ability to do inventory by collection code as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14394] Fix documentation of OpacHiddenItems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14394 --- Comment #1 from Aleisha Amohia aleishaamo...@hotmail.com --- Created attachment 40159 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40159action=edit WR230198: fix documentation of OpacHiddenItems The current documentation of OpacHiddenItems told people to go and read a file on the server, which most people don't have access to. This replaces it with a link to the wiki. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14394] Fix documentation of OpacHiddenItems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14394 Aleisha Amohia aleishaamo...@hotmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14389] Editing a syspref in a textarea does not enable the Save button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 --- Comment #4 from Liz Rea l...@catalyst.net.nz --- Hi Jesse, I just tried this with only 'input', and it seems to work in every way I'd expect it to, including the linux middle button paste - what do you think? Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3333] item status for not for loan by item type / item is different
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id= --- Comment #8 from David Cook dc...@prosentient.com.au --- It might be worthwhile to make a new bug or re-think how we're showing notforloan across the board... At the moment, the OPAC detail view relies on notforloan_per_itemtype which is set in C4::Items::GetItemsInfo() by checking itemtypes.notforloan directly. That should probably take item-level_itypes into account, I guess. So I would add notforloan_per_itemtype to the staff client, and set that based on item-level_itypes. Then make sure that the search results are honouring that as well... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14389] Editing a syspref in a textarea does not enable the Save button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 --- Comment #5 from Liz Rea l...@catalyst.net.nz --- actually forget I said anything :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14389] Editing a syspref in a textarea does not enable the Save button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 --- Comment #6 from Liz Rea l...@catalyst.net.nz --- oy. it's getting too late for me, comment 4 stands, actually. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14394] New: Fix documentation of OpacHiddenItems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14394 Bug ID: 14394 Summary: Fix documentation of OpacHiddenItems Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Developer documentation Assignee: gmcha...@gmail.com Reporter: aleishaamo...@hotmail.com QA Contact: testo...@bugs.koha-community.org Update to documentation for OpacHiddenItems syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14392] New: Inventory.pl contains call to internal sub C4::Reports::Guided::_get_column_defs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14392 Bug ID: 14392 Summary: Inventory.pl contains call to internal sub C4::Reports::Guided::_get_column_defs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcha...@gmail.com Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org I was just poking through inventory.pl and noticed the use of C4::Reports::Guided::_get_column_defs. I believe that one prefixes subs with _ when they're meant to be only used internally, so this isn't a good look. If this sub is more universal than its current use in C4::Reports::Guided, it should be broken out into a different helper object. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4925] Remove Smithsonian as a delivered z39.50 target
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4925 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #7 from M. Tompsett mtomp...@hotmail.com --- Oh sure. Make me go find other issues with this section of code too. :( -- Why are there ALTER TABLE's in the sample sql files?! Someone remind me to file a bug. Back to looking this over. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14388] add sorting to funds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12984 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hm, I am with Heather on the italics - what about he separator | Nick mentioned? For when the record is part of multiple series? I'd think it wouldn't happen often, but on the other hand... nothing is impossible I have learned. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14370] Use Restrictions in Circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14370 --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I'd not call it a bug if we never implemented it differently :) For me restricted doesn't imply 'no checkout' - then it would be the same as 'not for loan'. I think there should be a clear difference between the two fields, so we actually win something here. Be able to place on hold, but only checkout on-site maybe? With the difference between negative and positive values maybe? There is also another bug about this: bug 10591 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14389] New: Editing a syspref in a textarea does not ednable the Save button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Bug ID: 14389 Summary: Editing a syspref in a textarea does not ednable the Save button Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: mag...@libriotech.no QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com At least sometimes, editing a syspref in a textarea (like e.g. opaccredits) will not make the Save button active. I have observed this on 3.18.7. Others have possibly sighted it on master too. Workaround: Add and remove one char from a text input to activate the button. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14388] New: add sorting to funds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 Bug ID: 14388 Summary: add sorting to funds Change sponsored?: --- Product: Koha Version: master Hardware: All URL: cgi-bin/koha/acqui/acqui-home.pl OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org The list of funds on this page (cgi-bin/koha/acqui/acqui-home.pl) has no sorting in place. It should sort on fund name or code or something useful to help people find the fund they want. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4925] Remove Smithsonian as a delivered z39.50 target
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4925 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4925] Remove Smithsonian as a delivered z39.50 target
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4925 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #39966|0 |1 is obsolete|| --- Comment #8 from M. Tompsett mtomp...@hotmail.com --- Created attachment 40146 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40146action=edit Bug 4925: Remove Smithsonian as a delivered z39.50 target Removes the Smithsonian as a target installed with the sample data during installation. Also adds the newer LOC authority targets to files where they were missing. To test: - Verify the Smithsonian has been removed from all translated installers - Verify the files are still valid SQL and install correctly NOTE: There was tiny scope creep which included ensuring there were two Authority z39.50 servers as well. Text files properly reflect the removal. SQL 'source' of SQL files worked properly. Was able to Z39.50 search for all of the 'en'. Signed-off-by: Mark Tompsett mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14389] Editing a syspref in a textarea does not ednable the Save button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Magnus Enger mag...@libriotech.no changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jwea...@bywatersolutions.co |ity.org |m --- Comment #1 from Magnus Enger mag...@libriotech.no --- Jesse Weaver asked that this be assigned to him. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14380] Overriding fine on renewal will cause duplicate fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14380 Barton Chittenden bar...@bywatersolutions.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #4 from Barton Chittenden bar...@bywatersolutions.com --- (In reply to Katrin Fischer from comment #3) I think I disagree about the 'one line'. Once you renew the overdue process restarts and is not in any way related to the first one, I'd avoid mixing the data. It would make it really hard to see why the amount is as high as it is. With the 2 different due dates you get a clear clue. I see a renewal more like a new checkout - only that Koha doesn't treat a renewal as a new checkout as some other systems do (which is fine!). But I totally agree about the description being misused. I think we need to think about this a bit more and should note it as a use case/test case we need to test and make sure works properly. Katrin, After discussion with Kyle Hall, I agree with you assessment: Closing the first fine and creating a new fine on renewal is standard behavior for Koha. This still leaves the issue of the second Fine not being closed. I'm going to mark the ticket as RESOLVED/INVALID, and open a new ticket which specifically addresses the un-closed fine. I'll carry your comments regarding a test case forward to the new ticket. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12984] Improvement of the funds list view on acqui home
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12984 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14388 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14370] Use Restrictions in Circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14370 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14370] Use Restrictions in Circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14370 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- (In reply to Katrin Fischer from comment #1) This would be a change of behaviour - could we please make it optional? Maybe we can specify the values in a pref that should also block circulation. I know a library using this to indicate on-site checkouts - restricted being the reading room with a value != 0. I think it would be much more reasonable to say that any value less than 0 retains the current behavior. That would bring it in line with the behavior of other authorised values for items. To me that would be a much better solution than yet another system preference. It seems to me that they are taking advantage of a bug rather than a feature. Information like that should really belong in another field, but allowing circ of negative values seems like a good compromise to me. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14389] Editing a syspref in a textarea does not enable the Save button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Magnus Enger mag...@libriotech.no changed: What|Removed |Added Summary|Editing a syspref in a |Editing a syspref in a |textarea does not ednable |textarea does not enable |the Save button |the Save button -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14370] Use Restrictions in Circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14370 --- Comment #4 from Joy Nelson j...@bywatersolutions.com --- Not for loan items can be overridden at the time of checkout, if needed. Restricted items cannot be checked out ever (if value=1). So the intention seems clear from the code that if you are restricting an item, you are setting it to be 'circulation impossible'. I like the option of allowing for negative numbers that could be circulated, but positive numbers that actually do restrict. If you look at withdrawn, you can have multiple withdrawn values and ALL of them will prohibit circulation. Why allow an authorised value list to be used for restricted if you do not allow for additional values to work? . joy (In reply to Katrin Fischer from comment #3) I'd not call it a bug if we never implemented it differently :) For me restricted doesn't imply 'no checkout' - then it would be the same as 'not for loan'. I think there should be a clear difference between the two fields, so we actually win something here. Be able to place on hold, but only checkout on-site maybe? With the difference between negative and positive values maybe? There is also another bug about this: bug 10591 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14370] Use Restrictions in Circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14370 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Version|3.18|master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 Stefan Weil s...@weilnetz.de changed: What|Removed |Added CC||s...@weilnetz.de --- Comment #3 from Stefan Weil s...@weilnetz.de --- Created attachment 40147 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40147action=edit C4: Fix some typos (mostly in comments and documentation) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 Stefan Weil s...@weilnetz.de changed: What|Removed |Added Attachment #40148|Fix some typos in comments |Bug 14383: Fix some typos description|and documentation |in comments and ||documentation --- Comment #7 from Stefan Weil s...@weilnetz.de --- Comment on attachment 40148 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40148 Bug 14383: Fix some typos in comments and documentation Most of them were found and fixed using codespell. Signed-off-by: Stefan Weil s...@weilnetz.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #17 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I won't, because I like it :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 --- Comment #9 from Stefan Weil s...@weilnetz.de --- Created attachment 40150 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40150action=edit Bug 14383 admin: Fix some typos in comments and documentation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 --- Comment #12 from Stefan Weil s...@weilnetz.de --- There remain more than 500 files with typos found by codespell, but I won't be able to process them before end of this week. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12770] Notice template tool enhancement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770 Eivin Giske Skaaren ei...@sysmystic.com changed: What|Removed |Added CC||ei...@sysmystic.com --- Comment #5 from Eivin Giske Skaaren ei...@sysmystic.com --- I have tested this quite extensively both from a clean master and with patch 12769 installed. There is something that does not work as it should since the table is created and accountlines values are shown while itemaccountlines values are not shown. To be more specific none of the values in this part shows up: itemaccountlines tr td align=center style=border: 1px solid black; border-collapse: collapsebiblio.title/td td align=center style=border: 1px solid black; border-collapse: collapsebiblio.author/td td align=center style=border: 1px solid black; border-collapse: collapseitems.barcode/td td align=center style=border: 1px solid black; border-collapse: collapseitems.itemcallnumber/td td align=center style=border: 1px solid black; border-collapse: collapse$/td -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14370] Use Restrictions in Circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14370 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10591 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10591] Why do we allow holds on restricted items (952$5=Use restrictions)? Place a hold for reference?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10591 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14370 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #18 from Heather heather_hernan...@nps.gov --- (In reply to Katrin Fischer from comment #17) I won't, because I like it :) It is our secret!:) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 Stefan Weil s...@weilnetz.de changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14390] New: On renewal, the last fine is not marked as accounttype 'F' when item is checked in.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Bug ID: 14390 Summary: On renewal, the last fine is not marked as accounttype 'F' when item is checked in. Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: bar...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When an item with a fine is renewed, the old fine is closed (i.e. accounttype is set to 'F'). A new fine is created, with an updated description. The new find is not closed when the item is checked back in. select date, amount, description, accounttype, amountoutstanding, lastincrement, timestamp from accountlines where itemnumber = 35540 and borrowernumber = 24990\G *** 1. row *** date: 2015-05-05 amount: 0.50 description: O'Connor's annotated criminal codes plus. 05/04/2015 11:59 PM accounttype: F amountoutstanding: 0.50 lastincrement: 0.50 timestamp: 2015-06-08 12:42:27 *** 2. row *** date: 2015-06-08 amount: 4.50 description: O'Connor's annotated criminal codes plus. 05/26/2015 11:59 PM accounttype: FU amountoutstanding: 4.50 lastincrement: 0.50 timestamp: 2015-06-08 02:02:40 2 rows in set (0.00 sec) Looking in old_issues, you can see that the item was renewed, and that date_due does match the second description... only the first accountlines entry is marked woth accounttype 'F' on return, however. select date_due, returndate, lastreneweddate, renewals, timestamp, issuedate from old_issues where itemnumber = 35540 and borrowernumber = 24990\G *** 1. row *** date_due: 2015-05-26 23:59:00 returndate: 2015-06-08 12:42:27 lastreneweddate: 2015-05-05 00:00:00 renewals: 1 timestamp: 2015-06-08 12:42:27 issuedate: 2015-04-13 09:23:20 To replicate: 1) check out an item 2) let the item go overdue and start accruing fines 3) renew the item 4) let the item go overdue again. Note that a second accountlines entry has been added 5) return the item. Note that the new fine is set with accounttype 'FU'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12770] Notice template tool enhancement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770 Maxime Beaulieu maxime.beaul...@inlibro.com changed: What|Removed |Added CC||maxime.beaul...@inlibro.com Assignee|simith.dolive...@inlibro.co |maxime.beaul...@inlibro.com |m | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 --- Comment #4 from Stefan Weil s...@weilnetz.de --- Created attachment 40148 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40148action=edit Fix some typos in comments and documentation Most of them were found and fixed using codespell. Signed-off-by: Stefan Weil s...@weilnetz.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 Stefan Weil s...@weilnetz.de changed: What|Removed |Added Attachment #40147|C4: Fix some typos (mostly |Bug 14383 C4: Fix some description|in comments and |typos (mostly in comments |documentation) |and documentation) --- Comment #6 from Stefan Weil s...@weilnetz.de --- Comment on attachment 40147 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40147 Bug 14383 C4: Fix some typos (mostly in comments and documentation) Most of them were found and fixed using codespell. Fix also some related grammar issues. In C4/Serials.pm a variable was renamed to make future codespelling checks easier. Signed-off-by: Stefan Weil s...@weilnetz.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #16 from Heather heather_hernan...@nps.gov --- (In reply to Heather from comment #15) Yes--multiple series do happen! I like the idea of a pipe between series entries. Maybe it would look cleaner without a period/full stop at the end: Series: Hines, Jim C. Magic ex libris: 1 | Wizard essential codices: 342 | Fantasy reading group favorites: v. 45 The single series entry may still look fine without the period/full stop at the end: Series: O'Brian, Patrick. Aubrey/Maturin novels: 1 --heather P.S. Don't tell other catalogers I suggested eliminating the Very Traditional Period/Full Stop at the end of the series entry!:) ETA: I forgot to mention re. Also, 8xx fields seems to be ending in ':' regardless of field ending in record, that this looks OK to me. Traditionally there is a space, semi-colon, space between the title and the number, but the colon snug against the title followed by a space looks good--it's neat and clear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 Stefan Weil s...@weilnetz.de changed: What|Removed |Added Attachment #40149|acqui: Fix some typos in|Bug 14383 acqui: Fix some description|comments and documentation |typos in comments and ||documentation --- Comment #8 from Stefan Weil s...@weilnetz.de --- Comment on attachment 40149 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40149 Bug 14383 acqui: Fix some typos in comments and documentation Most of them were found and fixed using codespell. Signed-off-by: Stefan Weil s...@weilnetz.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 --- Comment #11 from Stefan Weil s...@weilnetz.de --- Created attachment 40152 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40152action=edit Bug 14383 etc/zebradb: Fix some typos in documentation and Bib-1 attribute set -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 --- Comment #10 from Stefan Weil s...@weilnetz.de --- Created attachment 40151 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40151action=edit Bug 14383 docs: Fix some typos in documentation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14390] On renewal, the last fine is not marked as accounttype 'F' when item is checked in.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Barton Chittenden bar...@bywatersolutions.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14380 Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | --- Comment #1 from Barton Chittenden bar...@bywatersolutions.com --- Assigning to Kyle Hall, per discussion with him. Kyle, please note Katrin's comments in the previous ticket: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14380#c3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 Stefan Weil s...@weilnetz.de changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14380] Overriding fine on renewal will cause duplicate fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14380 Barton Chittenden bar...@bywatersolutions.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14390 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #15 from Heather heather_hernan...@nps.gov --- Yes--multiple series do happen! I like the idea of a pipe between series entries. Maybe it would look cleaner without a period/full stop at the end: Series: Hines, Jim C. Magic ex libris: 1 | Wizard essential codices: 342 | Fantasy reading group favorites: v. 45 The single series entry may still look fine without the period/full stop at the end: Series: O'Brian, Patrick. Aubrey/Maturin novels: 1 --heather P.S. Don't tell other catalogers I suggested eliminating the Very Traditional Period/Full Stop at the end of the series entry!:) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 --- Comment #5 from Stefan Weil s...@weilnetz.de --- Created attachment 40149 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40149action=edit acqui: Fix some typos in comments and documentation Most of them were found and fixed using codespell. Signed-off-by: Stefan Weil s...@weilnetz.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #19 from Nick Clemens n...@quecheelibrary.org --- (In reply to Heather from comment #16) ETA: I forgot to mention re. Also, 8xx fields seems to be ending in ':' regardless of field ending in record, that this looks OK to me. Traditionally there is a space, semi-colon, space between the title and the number, but the colon snug against the title followed by a space looks good--it's neat and clear. I agree with that, but the case where there is no volume number I think the ':' looks a bit odd Italics was a radical idea, full stop does seem more reasonable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14389] Editing a syspref in a textarea does not enable the Save button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added CC||l...@catalyst.net.nz --- Comment #3 from Liz Rea l...@catalyst.net.nz --- Hi Jesse, I tested this, and the following action: highlighting everything, and deleting the contents of a syspref (this case, nologininstructions) the button didn't activate when I might have expected it to. I can get around it by adding and deleting a space in the syspref. Also, we're still stuck with the middle click paste from linux not triggering the save button, but that might be an even more distant edge case. Is this something we can fix? This patch is certainly an improvement over the current behaviour. Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Aleisha Amohia aleishaamo...@hotmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #1 from Aleisha Amohia aleishaamo...@hotmail.com --- Created attachment 40158 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40158action=edit Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories Changes the API for calling GetHiddenItems and all the places in the code that call it. This is to allow borrower categories to be passed in. Adds an OpacHiddenItemsExceptions syspref to allow certain borrower categories to be able to see items, even if they are marked hidden by OpacHiddenItems To test: 1) Make two borrowers, one in a category that should see everything (ie Adult), and another in a category that should only see certain things (ie Adult - exceptions) 2) Add the borrower that can see everything (the Adult) to OpacHiddenItemsExceptions 3) To the OpacHiddenItems syspref, add an item type (ensure that you have some records that fall under this type in your library). 4) Log in as the borrower that should only see certain things (Adult - exception) 5) Do a search, filtered to show records which are the item type that you specified in the OpacHiddenItems syspref. No records should show for this borrower as this item type is hidden to them. 6) Log in as the borrower that should see everything (Adult) 7) Do the same search. There should be results from this search, as this borrower category has been specified as an exception to the hidden items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14391] New: admin permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 Bug ID: 14391 Summary: admin permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com I think administration permissions should be like tools, each one should have its own permissions so you can allow catalogers access to some of the cataloging admin but not the system preferences for example. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14142] Holds queue viewer only displays first subtitle from marc keyword mappings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14142 Liz Rea wizzy...@gmail.com changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #7 from Liz Rea wizzy...@gmail.com --- Hi, This patch doesn't apply for 3.18. If you feel that it should be included, please resolve any issues and resubmit a patch for inclusion in 3.18.x. Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11559] Professional cataloger's interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559
Jesse Weaver jwea...@bywatersolutions.com changed:
What|Removed |Added
Attachment #38533|0 |1
is obsolete||
Attachment #38534|0 |1
is obsolete||
Attachment #38535|0 |1
is obsolete||
Attachment #38536|0 |1
is obsolete||
Attachment #38537|0 |1
is obsolete||
Attachment #38538|0 |1
is obsolete||
Attachment #38539|0 |1
is obsolete||
--- Comment #87 from Jesse Weaver jwea...@bywatersolutions.com ---
Created attachment 40153
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40153action=edit
Bug 11559 - Supporting changes for Rancor
* Extends login screen to pass along #hash
* Adds JSONP support to C4::Service
* Extends humanmsg to allow per-message classes
* Adds proper charset to results of svc/bib
Test plan:
1. C4/Auth.pm and .../intranet/.../auth.tt: verify that login/usage
works as expected, despite the change to pass on the fragment (...#blah)
from the URL.
2. C4/Service.pm and humanmsg.js: verify that editing system
preferences (the main user of these modules) works correctly despite
updates.
3. svc/bib: verify that records can be correctly downloaded with the
change of character set. This can be done in a Firebug/Chrome Devtools
console by running `$.get('/cgi-bin/koha/svc/bib/1')` and inspecting the
results (possibly replacing 1 with a different valid biblionumber).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
