[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #24 from Jonathan Druart jonathan.dru...@biblibre.com --- Sorry but: % git fetch origin % git checkout -b bug_13624 origin/master % git clean -f -d % git bz apply 13624 Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types 38290 - Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types 39920 - Bug 13624 - Tidying the atomicupdate file and kohastructure.sql Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types Applying: Bug 13624 - Tidying the atomicupdate file and kohastructure.sql fatal: sha1 information is lacking or useless (installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Please reupload the patches if they apply for you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com --- Comment #21 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Fixed some koha-qa complains (tabs) on some patches, added signs on all. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13699] DBD::mysql mysql_auto_reconnect attribute ceases to function after DBIx call[s]
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13699 Fridolin SOMERS fridolin.som...@biblibre.com changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #1 from Fridolin SOMERS fridolin.som...@biblibre.com --- Surely linked to Bug 14374 and Bug 14375 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #40149|0 |1 is obsolete|| --- Comment #17 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40280 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40280action=edit [SIGNED-OFF] Bug 14383: acqui: Fix some typos in comments and documentation Most of them were found and fixed using codespell. Signed-off-by: Stefan Weil s...@weilnetz.de http://bugs.koha-community.org/show_bug.cgi?id=14383 Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #40150|0 |1 is obsolete|| --- Comment #18 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40281 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40281action=edit [SIGNED-OFF] Bug 14383: admin: Fix some typos in comments and documentation Most of them were found and fixed using codespell. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #40152|0 |1 is obsolete|| --- Comment #20 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40283 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40283action=edit [SIGNED-OFF] Bug 14383: etc/zebradb: Fix some typos in documentation and Bib-1 attribute set All of them were found and fixed using codespell. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #40151|0 |1 is obsolete|| --- Comment #19 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40282 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40282action=edit [SIGNED-OFF] Bug 14383: docs: Fix some typos in documentation All of them were found and fixed using codespell. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14180] Make Always show checkouts immediately a global setting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14409] additem.pl no longer focuses on Cataloging search when loaded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14409 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14409] additem.pl no longer focuses on Cataloging search when loaded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14409 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14409] additem.pl no longer focuses on Cataloging search when loaded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14409 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 40284 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40284action=edit Bug 14409 - additem.pl no longer focuses on Cataloging search when loaded In Koha 3.16, additem.pl would focus on the cataloging search when the page was loaded. It no longer does this. Test Plan: 1) Apply this patch 2) Go to the item editor 3) Note the cataloging search is now focused on when the page loads -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12919] Automate collecting all records added and deleted from the catalogue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12919 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comments: 1/ perltidy new files 2/ Use pod2usage in pl scripts 3/ Write tests for new subroutines 4/ Be consistent with subroutine names (export_newrecords = export_new_records) Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13774] Add the unique anchors of news as links in the RSS for news in Opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13774 --- Comment #5 from Viktor Sarge viktor.sa...@regionhalland.se --- We plan to add the ability to pass the id of a news item to (for example) opac-main.pl and if that gets pushed it will likely be better to add this link instead of anchors. But it will still depend on 5010 i guess. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14409] New: additem.pl no longer focuses on Cataloging search when loaded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14409 Bug ID: 14409 Summary: additem.pl no longer focuses on Cataloging search when loaded Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl In Koha 3.16, additem.pl would focus on the cataloging search when the page was loaded. It no longer does this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #40128|0 |1 is obsolete|| --- Comment #13 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40276 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40276action=edit [SIGNED-OFF] Bug 14383: debian: Fix some trivial typos They were found and fixed using codespell. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Chris Cormack chr...@catalyst.net.nz Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #40129|0 |1 is obsolete|| --- Comment #14 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40277 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40277action=edit [SIGNED-OFF] Bug 14383: misc: Fix some typos in comments and documentation Most of them were found and fixed using codespell. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Chris Cormack chr...@catalyst.net.nz Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #40147|0 |1 is obsolete|| --- Comment #15 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40278 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40278action=edit [SIGNED-OFF] Bug 14383: C4: Fix some typos (mostly in comments and documentation) Most of them were found and fixed using codespell. Fix also some related grammar issues. In C4/Serials.pm a variable was renamed to make future codespelling checks easier. Signed-off-by: Stefan Weil s...@weilnetz.de http://bugs.koha-community.org/show_bug.cgi?id=14383 Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #40148|0 |1 is obsolete|| --- Comment #16 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40279 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40279action=edit [SIGNED-OFF] Bug 14383: Fix some typos in comments and documentation Most of them were found and fixed using codespell. Signed-off-by: Stefan Weil s...@weilnetz.de http://bugs.koha-community.org/show_bug.cgi?id=14383 Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14393] Add collection code filter to inventory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- David, In my dev installation, items.ccode is not mapped. Which makes the dropdown list populated with all my authorized values :) You certainly need to care about the value of AdvancedSearchTypes, you will have to propose item type too. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5025] discrepancy between opac doc-head-open.inc and staff doc-head-open.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5025] discrepancy between opac doc-head-open.inc and staff doc-head-open.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #40248|0 |1 is obsolete|| --- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 40275 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40275action=edit Bug 5025: discrepancy between opac doc-head-open.inc and staff doc-head-open.inc Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Tested most pages, inspected all of them. No errors Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5025] discrepancy between opac doc-head-open.inc and staff doc-head-open.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5025 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Assignee|aleishaamo...@hotmail.com |mtomp...@hotmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3309] Deleting authorized values when data exists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3309 Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #39662|0 |1 is obsolete|| --- Comment #94 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40292 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40292action=edit Bug 12017: 8 - Remove use of getAllLanguages from installer getAllLanguages is only used on installer/install.pl, and some tests. Result parameters are passed to C4/Install.pm, but its use is futile, language check on Installer.pm uses parameters that are not present on return value of getAllLanguages, and returned value fwk_code is undefined To test: 1. Apply the patch 2. Do translated install (eg using de-DE or es-ES) a. translate first, b. then create a new database, c. grant permissions, d. change koha-conf to use new db, e. reload staff, f. proceed to web install, g. select translated language, h. use marc21, i. finish, 3. Login and check that marc frameworks are translated The translated install must proceed without problems. Removed only the very first occurence of template parameter fwk_language because of it's null value. Signed-off-by: Julian FIOL julian.f...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #39660|0 |1 is obsolete|| --- Comment #92 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40290 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40290action=edit Bug 12017: 6 - Change syspref AdvancedSearchLanguages Bug 10986 introduces a way of limiting advanced search languages list. It's a good feature, but to fill the preference you need to list iso639_2 codes. And there is no way to get the list of all codes again as before, and language descriptions are taken from database. This patch changes that preference so it's now a Local syspref, to present an interface to set it's value. Also adds another syspref to control if language chooser is limited at all, recovering previous behavior. As per comments on Bug 10986 language list shows translated and native names and is ordered by iso639_2 code To test: 1. Apply the patch 2. Run updatedatabase.pl 3. Go to system preferences, Searching, new syspref LimitAdvancedSearchLanguages, on by default 4. Go to Local use sysprefs, AdvancedSearchLanguages is now here with interface to set it's values 5. Check language limit on advanced search on staff and opac (any theme) 6. Disable limit and chech language list 7. Enable limit and set different languages on syspref, check language list Signed-off-by: Julian FIOL julian.f...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #39664|0 |1 is obsolete|| --- Comment #96 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40294 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40294action=edit Bug 12017: 10 - Remove description from getLanguage This patch rewrites getLanguage function. This function is of not much use, but is rewrited to takes its data from language_rfc4646_to_iso639 table. To test: 1. Apply the patch 2. Only place that use this function is t/db_dependent/Languages.t so run the test and check that it pass 3. To compare the output pre and post patch you can run perl -e 'use C4::Languages; use Data::Dumper; $a = getLanguages(); print Dumper $a;' Signed-off-by: Julian FIOL julian.f...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #39663|0 |1 is obsolete|| --- Comment #95 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40293 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40293action=edit Bug 12017: 9 - Remove use of language_get_description function This patch removes every use of language_get_description function. This function retrieves lang names from database To test: 1. Functionality removed by this patch do not affect anything, because previous patches are only using rfc4646_subtag value, not values stored in database. 2. Removed import from Templates.pm, not used there Signed-off-by: Julian FIOL julian.f...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14163] Show all in acquisition confusing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14163 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #39709|0 |1 is obsolete|| --- Comment #6 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40310 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40310action=edit Bug 14163: Acq - receive shipment and order from staged: rename 'Show all' to 'Show inactive' 'Show all' in acquisition makes the inactive funds in the fund list box visible. This patch changes the text to 'Show inactive' to be more clear about the functionality. Patch changes 2 pages. To test: 1) Order from staged file - make sure you have uploaded a few records via the tools - create a new order using the 'From a staged file' option - select a file to order from - 'Add orders' - Verify the 'Select to import' tab now displayed the text 'Show inactive funds' and that it works as expected - Switch to the 'Default accounting details' tab - Verify the text there is also changed to 'Show inactive' and works like expected. 2) Receive shipment - receive a new shipment for a vendor with unreceived orders - Verify the label next to the fund list has changed to 'Show inactive' and works as expected. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Simple string change, no errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14163] Show all in acquisition confusing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14163 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added CC||bgkrie...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14316] Clarify meaning of record number in Batch record deletion tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14316 --- Comment #6 from Nicole C. Engard neng...@gmail.com --- (In reply to Jonathan Druart from comment #5) I need another pov here, record number is used in the legend of the fieldset on the same page. Moreover, it is also used on the Batch record modification page. When you're talking about modifying a 'record' that makes sense. But there is no 'record number' in Koha - there is biblionumber and/or authority id. So when people see 'record number' they're confused about what they're supposed to put there. Nicole -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Blocks||12017 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Depends on||14252 --- Comment #98 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- (In reply to Julian FIOL from comment #86) I wanted to add that this patch optimize the number of MySQL requests in a significant way : Thanks for keep testing :) A few changes: 1) Added 14252 as dependence, it's PQA and needs to be taken into account 2) Squashed Patch 5 and it's followup 3) Changed sub name getLanguages_iso - getLanguagesIso 4) Added Patch 11 to handle masthead lang changer from Bug 14252 I preserved Julian sings, but last patch needs one. And Jonathan wants another another sign from an additional tester... so if you want to test, best way is apply all patches from Bug 14252 and this one, then follow test plant from each patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #40276|0 |1 is obsolete|| Attachment #40277|0 |1 is obsolete|| Attachment #40278|0 |1 is obsolete|| Attachment #40279|0 |1 is obsolete|| Attachment #40280|0 |1 is obsolete|| Attachment #40281|0 |1 is obsolete|| Attachment #40282|0 |1 is obsolete|| Attachment #40283|0 |1 is obsolete|| --- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 40296 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40296action=edit Bug 14383: debian: Fix some trivial typos They were found and fixed using codespell. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Chris Cormack chr...@catalyst.net.nz Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 --- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 40297 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40297action=edit Bug 14383: misc: Fix some typos in comments and documentation Most of them were found and fixed using codespell. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Chris Cormack chr...@catalyst.net.nz Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Assignee|gmcha...@gmail.com |s...@weilnetz.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13392] New statistics wizard for suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Alex Arnaud alex.arn...@biblibre.com changed: What|Removed |Added Attachment #36345|0 |1 is obsolete|| --- Comment #31 from Alex Arnaud alex.arn...@biblibre.com --- Created attachment 40307 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40307action=edit Bug 13392: QA fixes 1/ Add tests descriptions 2/ Do not use Koha::I18N for suggestion statuses, and add statuses from SUGGEST_STATUS authorised values 3/ Use copyrightdate instead of publicationyear which seems to be unused 4/ Display free text filters if there is no values in corresponding authorised values list 5/ Rename 'Branch' to 'Library' and 'Reject reason' to 'Reason' Signed-off-by: Nicole Engard neng...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13392] New statistics wizard for suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Alex Arnaud alex.arn...@biblibre.com changed: What|Removed |Added Attachment #36343|0 |1 is obsolete|| --- Comment #29 from Alex Arnaud alex.arn...@biblibre.com --- Created attachment 40305 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40305action=edit Bug 13392: Add suggestions.ordereddate and suggestions.orderedby Those fields are updated when suggestion status is changed to 'ORDERED' and are displayed on suggestion/suggestion.pl page Signed-off-by: Nicole Engard neng...@bywatersolutions.com Patch updated: Use atomic update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13392] New statistics wizard for suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #32 from Alex Arnaud alex.arn...@biblibre.com --- Created attachment 40308 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40308action=edit [Follow-up] Bug 13392 - Fix QA failures: - Fix a perl warning in suggestions_stats.tt, - Replace term Acquisitions with Suggestions, - Add POD for GetBudgetDescendantsIds. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14163] Show all in acquisition confusing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14163 --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 40312 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40312action=edit Bug 14163: Acq - receive shipment and order from staged: rename 'Show all' to 'Show inactive' 'Show all' in acquisition makes the inactive funds in the fund list box visible. This patch changes the text to 'Show inactive' to be more clear about the functionality. Patch changes 2 pages. To test: 1) Order from staged file - make sure you have uploaded a few records via the tools - create a new order using the 'From a staged file' option - select a file to order from - 'Add orders' - Verify the 'Select to import' tab now displayed the text 'Show inactive funds' and that it works as expected - Switch to the 'Default accounting details' tab - Verify the text there is also changed to 'Show inactive' and works like expected. 2) Receive shipment - receive a new shipment for a vendor with unreceived orders - Verify the label next to the fund list has changed to 'Show inactive' and works as expected. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Simple string change, no errors. Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11011] rephrase in keyword in OPAC authority search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11011 --- Comment #7 from Nicole C. Engard neng...@gmail.com --- Sorry for my delay all - I think 'in the complete record' is a-ok. 'in keyword' is confusing and should just say 'keyword' if it's used, but I like 'in the complete record' :) Nicole -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #39665|0 |1 is obsolete|| --- Comment #97 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40295 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40295action=edit Bug 12017: 11 - Change masthead language switcher On top of Bug 14252 This patch adapt to new style masthead language switcher To test: 1) Apply the patch 2) Install and enable on opac some languages and sublanguages e.g. es-ES de-DE de-CH en-NZ 3) Check that masthead language switcher shows language description and region description for sublanguages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #39661|0 |1 is obsolete|| --- Comment #93 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40291 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40291action=edit Bug 12017: 7 - Remove function getFrameworkLanguages [ Note: From now on dependence on language descriptions in database is about to be removed, also some code cleaning.] This must be an old relic, not used anymore. To test: 1. Check use of getFrameworkLanguages egrep -Rl getFrameworkLanguages * No result save for definition file 2. Apply the patch 3. check again, no results Reason for removing this function is that it's not used and tries to send languages descriptions from database Signed-off-by: Julian FIOL julian.f...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 --- Comment #28 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 40302 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40302action=edit Bug 14383: docs: Fix some typos in documentation All of them were found and fixed using codespell. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 --- Comment #24 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 40298 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40298action=edit Bug 14383: C4: Fix some typos (mostly in comments and documentation) Most of them were found and fixed using codespell. Fix also some related grammar issues. In C4/Serials.pm a variable was renamed to make future codespelling checks easier. Signed-off-by: Stefan Weil s...@weilnetz.de http://bugs.koha-community.org/show_bug.cgi?id=14383 Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 --- Comment #25 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 40299 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40299action=edit Bug 14383: Fix some typos in comments and documentation Most of them were found and fixed using codespell. Signed-off-by: Stefan Weil s...@weilnetz.de http://bugs.koha-community.org/show_bug.cgi?id=14383 Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 --- Comment #27 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 40301 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40301action=edit Bug 14383: admin: Fix some typos in comments and documentation Most of them were found and fixed using codespell. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 --- Comment #26 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 40300 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40300action=edit Bug 14383: acqui: Fix some typos in comments and documentation Most of them were found and fixed using codespell. Signed-off-by: Stefan Weil s...@weilnetz.de http://bugs.koha-community.org/show_bug.cgi?id=14383 Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11804] there should not be both a circ-menu.tt and a circ-menu.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11804 --- Comment #6 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40316 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40316action=edit [SIGNED-OFF] Bug 11804: Remove unused circ-menu.tt The formerly used circ-menu.tt is no longer referenced in the templates and can be removed. To test: - Verify all tabs in the patron account still work as they should. - git grep circ-menu.tt Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com No problems on patron pages, no more circ-menu.tt No errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11804] there should not be both a circ-menu.tt and a circ-menu.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11804 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added CC||bgkrie...@gmail.com Attachment #39932|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 --- Comment #31 from Jonathan Druart jonathan.dru...@biblibre.com --- I have added a check in the QA script: commit 80c39304a2ae8186f0e75fa0af1055286449015d Add a spelling check for pl and tt files (using codespell) You will need to install codespell to make it works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14303] Fix item search CSV export - obsolete by and display of publication year for MARC21
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14303 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- (In reply to Marc Véron from comment #2) ... Signed-off-by: Marc Véron ve...@veron.ch Marc, you forgot to set to 'Signed Off' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 --- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com --- Thanks Frédéric for you reactivity! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11804] there should not be both a circ-menu.tt and a circ-menu.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11804 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #39655|0 |1 is obsolete|| --- Comment #87 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40285 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40285action=edit Bug 12017: 1 - Move language description out of database This patch adds identical copies of languages.inc file on include dirs, and modifies include files to process it. To test: 1. No change on current behavior must be observer, any page staff/opac Signed-off-by: Julian FIOL julian.f...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14316] Clarify meaning of record number in Batch record deletion tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14316 --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Nicole C. Engard from comment #6) (In reply to Jonathan Druart from comment #5) I need another pov here, record number is used in the legend of the fieldset on the same page. Moreover, it is also used on the Batch record modification page. When you're talking about modifying a 'record' that makes sense. But there is no 'record number' in Koha - there is biblionumber and/or authority id. So when people see 'record number' they're confused about what they're supposed to put there. Nicole Thanks for your answer, but I don't understand what you mean :) We have a Batch record modification and a Batch record deletion, on both you can play with biblio and authority records. This patch only affects 1 tool (deletion), to be consistent I propose to make the same change for the other one (modification). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14163] Show all in acquisition confusing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14163 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14163] Show all in acquisition confusing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14163 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #39501|0 |1 is obsolete|| Attachment #40310|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 40311 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40311action=edit Bug 14163: Acq order form: rename 'Show all' to 'Show inactive' On the order form there is a checkbox next to the fund list labelled 'show all'. Checking the checkbox will result in the inactive funds showing in the pull down list as well. The patch renames the label to 'Show inactive' to make the purpose more clear. To test: - Create a new order - Verify the label has changed as described above - Decide if the change makes sense Signed-off-by: tadeasm tadeas.mora...@gmail.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11011] rephrase in keyword in OPAC authority search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11011 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #40047|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 40309 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40309action=edit Bug 11011: Rephrasing 'in keyword' in OPAC authority search Using 'in the complete record' rather than 'in keyword'. I think this fits well as it seems that this means the search looks anywhere in the record. To test: 1) In the OPAC, click on Authority Search 2) Notice that in the drop-down menu for the 'Where:' field, there is an 'in keyword' option. 3) Apply patch 4) Now says 'in the complete record' Signed-off-by: Katrin Fischer katrin.fischer...@web.de Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11011] rephrase in keyword in OPAC authority search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11011 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14409] additem.pl no longer focuses on Cataloging search when loaded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14409 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14409] additem.pl no longer focuses on Cataloging search when loaded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14409 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #40284|0 |1 is obsolete|| --- Comment #2 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40315 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40315action=edit [SIGNED-OFF] Bug 14409 - additem.pl no longer focuses on Cataloging search when loaded In Koha 3.16, additem.pl would focus on the cataloging search when the page was loaded. It no longer does this. Test Plan: 1) Apply this patch 2) Go to the item editor 3) Note the cataloging search is now focused on when the page loads Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Focus on search box, no errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #39659|0 |1 is obsolete|| --- Comment #91 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40289 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40289action=edit Bug 12017: 5 - Change local use syspref type Language This patch changes local use syspref of type Language Currently this type of syspref is not used, and shows currently translated staff languages. It's values can't be changed. To make something useful, this kind of syspref is changed to show all langs and save iso639_2 codes. And they not use descriptions on database, only rfc4646 codes from templates. It's easy to add new kinds that save rfc4646 codes, or only show translated languages. To test: 1. Apply the patch 2. Go to system preferences, local use 3. Define a new syspref, any name/description, type 'Language', Save 4. New syspref is showed as a multiple selection of iso639_2 codes with current lang and native names. Check that 5. Select some values, save, check they are saved and restored 6. Edit, similar view, change values, save, check 7. Delete test syspref Values are stored as ',' separated values Verify in database Signed-off-by: Julian FIOL julian.f...@biblibre.com (Squashed followup) Bug 12017: followup to patch 5 Local use syspref of type language need to use a different variable to store languages, if not bottom language selector does not show. Also change multiple and selected attributes for XHTML compatibility, and a tab char To test: 1) Apply patch 5 and this one 2) On add/edit Language type Local use syspref, check bottom language selector shows up. Signed-off-by: Julian FIOL julian.f...@biblibre.com Changed sub name getLanguages_iso - getLanguagesIso -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #39656|0 |1 is obsolete|| --- Comment #88 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40286 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40286action=edit Bug 12017: 2 - Enable languages on web installer This patch modifies installer/step1.tt to use new language descriptions. Only parameter used is rfc4646 code. To test: 1. Do some fake translations, for example all langs for l in $(cd misc/translator/po; ls *-pref.po | sed 's/-pref.po//'); do mkdir koha-tmpl/intranet-tmpl/prog/$l; mkdir koha-tmpl/opac-tmpl/bootstrap/$l; mkdir koha-tmpl/opac-tmpl/prog/$l; mkdir koha-tmpl/opac-tmpl/ccsr/$l; done or make some lang dirs on intranet-tmpl/prog 2. Apply the patch 3. Edit your koha-conf.xml, change database name to a new name, create that database and grant access, reload staff page, log in with database user, you will be redirected to step1 of web installer. 4. Check names and codes for installed languages. Revert to your old database before proceed, but left dirs. Signed-off-by: Julian FIOL julian.f...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #39658|0 |1 is obsolete|| --- Comment #90 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40288 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40288action=edit Bug 12017: 4 - Change language changers This patch modifies language changers on staff/opac Only parameter used is rfc4646 To test: 1. Apply the patch 2. Reload staff and opac (prog/ccsr/bootstrap) 3. Check display of language changers 4. Do a real translation and check language change works Do not change language unless you did a real translation Only change in display is showing only regions for sublanguages. Signed-off-by: Julian FIOL julian.f...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #39657|0 |1 is obsolete|| --- Comment #89 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40287 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40287action=edit Bug 12017: 3 - Change lang display on sysprefs I18N This patch change the display of languages on sysprefs to set translated languages on I18N Only parameter used is rfc4646 subtag To test: 1. Apply the patch 2. Go to I18N syspref, look language descriptions Following steps are for next patch 3. Set a bunch of languages for staff/opac, save, reload Inlude vi-VN for which there is no current description in databasse 4. Set opaclanguagesdisplay to Allow Current display is preserved, native description for languages outside group, and script/region for language groups Only change is languages ordered by rfc4646 subtag Signed-off-by: Julian FIOL julian.f...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13392] New statistics wizard for suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Alex Arnaud alex.arn...@biblibre.com changed: What|Removed |Added Attachment #36344|0 |1 is obsolete|| --- Comment #30 from Alex Arnaud alex.arn...@biblibre.com --- Created attachment 40306 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40306action=edit Bug 13392: New statistics assistant for suggestions New sub C4::Budgets::GetBudgetDescendantsIds (with unit tests) Signed-off-by: Nicole Engard neng...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #40269|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 40313 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40313action=edit Bug 13904: Make unimarc_field_4XX displays usefull 200 subfield data When searching for multivolumes titles, UNIMARC 4xx field plugin displays the title of the biblios (200$a), without giving info about volumes (200 $h $i). It neither doesn't display $e (subtitle) info which could greatly help to disambiguate search result. The displayed title is supposed to link to a biblio record view (MARC / normal). It doesn't work. TO TEST: - On a UNIMARC Koha, add a new biblio record - Call the 4XX plugin from 461/463 field - Search for a biblio record which contains 200$e, and/or 200$h and/or 200$i subfields. - You get a result list, with two issues: 1. $a, $h $i aren't displayed 2. Biblio title is not a link - Apply the patch, and repeat previous steps. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com I got a link on fulltitle, but in 'ahie' order (not aehi) Fixed some tabs. Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #40054|0 |1 is obsolete|| --- Comment #2 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40314 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40314action=edit [SIGNED-OFF] Bug 14371 - Facets should be sorted by label (displayed) not title (link value) This patch changes one small line in search.pl to sort facets by: facet_label_value instead of facet_title_value To test: 1 - Perform a search with results in two branches e.g. Centerville (code CPL) and Fairfield (code FPL) 2 - Notice that branch facets appear correctly sorted 3 - Rename the branches Centervile-Zebra and Fairfeild-Aardvark (but don't change codes) 4 - Repeat original search 5 - Note that branch facets are no longer correctly sorted 6 - Apply patch 7 - Repeat search 8 - Facets should be correctly sorted 9 - Ensure there are no unintended consequences/regressions Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Work as described, no errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14411] New: items.itemnotes_nonpublic not created during upgrade
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14411 Bug ID: 14411 Summary: items.itemnotes_nonpublic not created during upgrade Change sponsored?: --- Product: Koha Version: 3.20 Hardware: Other OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcha...@gmail.com Reporter: ja...@mvwsd.org QA Contact: testo...@bugs.koha-community.org I recently upgraded our Koha install to 3.20 using the Debian packages. During the upgrade I received the following message: Please check each of your frameworks to ensure your non-public item notes are mapped to items.itemnotes_nonpublic. After doing so please have your administrator run misc/batchRebuildItemsTables.pl) Which seems pretty straightforward, however, the itemnotes_nonpublic field does not exist in my items table. I also receive a template error when checking out an item. Manually creating the itemnotes_nonpublic column resolves the template error on checkout. I upgraded two different servers and the column was not created on either server. I did have some problems with the items table during the upgrade. It was related to the change to the utf8_unicode collation so I am not sure if the field was not created in my items table because of those errors. I did not see any errors related to the itemnotes_nonpublic column during the upgrade. Also, I upgraded from 3.16 directly to 3.20 and I am running Debian Jessie It may be just an issue with my install but I wanted to report it in case it was a widespread issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9290] Restricting patron category for online purchase suggestion
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9290 --- Comment #1 from vinod vinod_librar...@rediffmail.com --- Some educational institutes only allow purchase suggestion by the faculty or some specific category of users like in Indian context. Similarly in public and other libraries children's may not be allowed for purchase suggestions or lower level of non technical/teaching staffs in special libraries. Hence this restriction is very much needed which is applicable for all libraries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383 --- Comment #29 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 40303 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40303action=edit Bug 14383: etc/zebradb: Fix some typos in documentation and Bib-1 attribute set All of them were found and fixed using codespell. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14383] Typos in various Koha files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14383
--- Comment #30 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 40304
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40304action=edit
Bug 14383: Fix POD error in C4/Ratings.pm
perl -e use Pod::Checker;podchecker('C4/Ratings.pm');
Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13392] New statistics wizard for suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Alex Arnaud alex.arn...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff CC||alex.arn...@biblibre.com --- Comment #33 from Alex Arnaud alex.arn...@biblibre.com --- I rebased patches on master / updated them to use atomic update and fix Katrin' QA comments. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- This change should also done at the OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- *be* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14409] additem.pl no longer focuses on Cataloging search when loaded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14409 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- It has been considered as a bug. Put in discussion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11804] there should not be both a circ-menu.tt and a circ-menu.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11804 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #40318|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 40319 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40319action=edit Bug 11804: Remove unused circ-menu.tt The formerly used circ-menu.tt is no longer referenced in the templates and can be removed. To test: - Verify all tabs in the patron account still work as they should. - git grep circ-menu.tt Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com No problems on patron pages, no more circ-menu.tt No errors Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11804] there should not be both a circ-menu.tt and a circ-menu.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11804 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14409] additem.pl no longer focuses on Cataloging search when loaded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14409 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13680 CC||n...@quecheelibrary.org --- Comment #6 from Nick Clemens n...@quecheelibrary.org --- I think a workaround to remove the need for a choice of where focus goes is the real solution, see bug 13680 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers test fails
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Status|Signed Off |Failed QA --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- Could you please detail the issue, I don't get it. You should also add the new deps to C4/Installer/PerlDependencies.pm Isn't it possible to use DateTime? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14409] additem.pl no longer focuses on Cataloging search when loaded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14409 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Kyle, did you manage to know when it has been introduced? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13680] Items list on edit items page separates add items form from header and sidebar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14409 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11804] there should not be both a circ-menu.tt and a circ-menu.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11804 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #40316|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 40318 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40318action=edit Bug 14409: Remove references to circ-menu.tt Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11804] there should not be both a circ-menu.tt and a circ-menu.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11804 --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 40320 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40320action=edit Bug 11804: Remove references to circ-menu.tt Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12372] feature request: debian/scripts/koha-mysql should be able to handle arbitrary mysql arguments.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12372 Barton Chittenden bar...@bywatersolutions.com changed: What|Removed |Added Attachment #40322|0 |1 is obsolete|| --- Comment #3 from Barton Chittenden bar...@bywatersolutions.com --- Created attachment 40323 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40323action=edit Bug 12372: koha-mysql: process any mysql args -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14411] items.itemnotes_nonpublic not created during upgrade
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14411 --- Comment #2 from Jon Aker ja...@mvwsd.org --- Thanks. It must have failed on my install due to the problems I had with the UTF8 conversion of the item table. I checked my deleteditems table and it does have that field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11620] Add dissertation-information index for non-UNIMARC installations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11620 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #39485|0 |1 is obsolete|| --- Comment #4 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40317 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40317action=edit [SIGNED-OFF] Bug 11620: Add dissertation-information index for MARC21 (502) Bug 11202 introduced a new index 'dissertation-information' for UNIMARC. This patch adds the index also for MARC21 installations. http://www.loc.gov/marc/bibliographic/bd502.html To test: - Apply patch - Copy files in etc/zebradb changed by this patch to your corresponding directory (koha-dev..) - Make sure you have records with 502 - Reindex - Verify you can search the field contents with dissertation-information= and diss= Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Can find by dissertation-information, No errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11194] Add a new index for Edition Statement of a MARC Record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #36979|0 |1 is obsolete|| --- Comment #4 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 40321 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40321action=edit [SIGNED-OFF] Bug 11194: Add a new index for Edition Statement of a MARC Record Adds the Edition Statement MARC-field as a sortable search index in Koha. This Field is also used by the MARC::Record-edition(). It is mapped to search keyword edition and it targets the following MARC-fields: UNIMARC: all 205-subfields concatenated MARC21 : all 250-subfields concatenated NORMARC: all 250-subfields concatenated After applying this patch a full biblio reindexing needs to be done to make old records searchable. New Biblios, and Biblios that are part of some operations (checkin/out/hold/...), are searchable. These generate good test data to test this feature without fully reindexing the search index. TEST PLAN: 0. Move the search index and search word definitions from the koha source code to the directory where Zebra uses them. This is most easiest to do by reinstalling Koha, but can be manually moved as well. 1. Find a record with some data in the Edition Statement -field. 2. Modify that Record and reindex it. 3. Search with the keyword edition='edition_statement' where edition_statement is the stuff you wrote in the MARC-field. 4. Observe the found record. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Tested on MARC21 and UNIMARC, works No errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11194] Add a new index for Edition Statement of a MARC Record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12372] feature request: debian/scripts/koha-mysql should be able to handle arbitrary mysql arguments.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12372 --- Comment #2 from Barton Chittenden bar...@bywatersolutions.com --- Created attachment 40322 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40322action=edit Bug 12372: koha-mysql: process any mysql args -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11620] Add dissertation-information index for non-UNIMARC installations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11620 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14409] additem.pl no longer focuses on Cataloging search when loaded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14409 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11905 --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Bug 11905 - when editing item, cursor is positioning in search box and not to item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11905] when editing item, cursor is positioning in search box and not to item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11905 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14409 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9290] Restricting patron category for online purchase suggestion
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9290 Amit amitddng...@gmail.com changed: What|Removed |Added CC||amitddng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Attachment #40314|0 |1 is obsolete|| --- Comment #5 from Nick Clemens n...@quecheelibrary.org --- Created attachment 40324 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40324action=edit Bug 14371 - Facets should be sorted by label (displayed) not title (link value) This patch changes one small line in catalogue/search.pl and opac/opac-search to sort facets by: facet_label_value instead of facet_title_value To test: 1 - Perform a search with results in two branches e.g. Centerville (code CPL) and Fairfield (code FPL) 2 - Notice that branch facets appear correctly sorted 3 - Rename the branches Centervile-Zebra and Fairfeild-Aardvark (but don't change codes) 4 - Repeat original search 5 - Note that branch facets are no longer correctly sorted 6 - Apply patch 7 - Repeat search 8 - Facets should be correctly sorted 9 - Test in both staff and opac search 10 - Ensure there are no unintended consequences/regressions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
