[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Failed QA --- Comment #31 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Moving to Failed QA to indicate there is something missing here still - please address! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9064] statistics.ccode specified inconsistently
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9064 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13930] Add supporting service svc/ncip for xnciptoolkit driver
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added CC||mi...@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10988] Allow login via Google OAuth2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 --- Comment #33 from M. Tompsett mtomp...@hotmail.com --- I have yet to test this, but I've been thinking about it, and the comments made in comment #24 in terms of Net::OAuth2 or something similar seem to be a concern for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10550] Fix database typo wthdrawn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10550 --- Comment #18 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Thx Nicholas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10455] remove redundant 'biblioitems.marc' field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 David Cook dc...@prosentient.com.au changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #5 from David Cook dc...@prosentient.com.au --- (In reply to Jonathan Druart from comment #4) biblioitems.marc is used by misc/cronjobs/MARC21_parse_test.pl. Does this script still used? I've never even heard of this script before, so I don't think that we use it. However, I suppose it's possible that someone uses it? Could we just remove the references to biblioitems.marc in this one script? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14389] Editing a syspref in a textarea does not enable the Save button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 --- Comment #13 from David Cook dc...@prosentient.com.au --- (In reply to David Cook from comment #12) I was thinking about this bug recently. I suppose it still won't work for WYSIWYG editors in some cases, but that's not a community concern (yet). I'll have to do some thinking on that one when I have time... Oh wait. Liz pointed out that it's on input and not on change. It might work for WYSIWYG editors as well! I'll look into this! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13769] Barcode showing blank in catalog/null in database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13769 mr.bnik...@gmail.com changed: What|Removed |Added CC||mr.bnik...@gmail.com --- Comment #2 from mr.bnik...@gmail.com --- What was the error? Now I am facing the same the problem. Please guide me -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13448] runreport.pl html email striping
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13448 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC||mtomp...@hotmail.com Severity|enhancement |minor --- Comment #2 from M. Tompsett mtomp...@hotmail.com --- This isn't an enhancement. It is fixing a behaviour broken in particular contexts. Changed to 'minor' bug fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13448] runreport.pl html email striping
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13448
--- Comment #3 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 34342
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34342
Bug 13448: Make Striping gmail/hotmail compatible
Review of attachment 34342:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=13448attachment=34342)
-
::: misc/cronjobs/runreport.pl
@@ +249,3 @@
while (my $line = $sth-fetchrow_arrayref) {
foreach (@$line) { defined($_) or $_ = ''; }# catch undef
values, replace w/ ''
+if ($count++ % 2 == 0) {
This is an ugly coding style!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13719] Make Koha::Objects store list of resultant objects on an as needed basis
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 --- Comment #8 from M. Tompsett mtomp...@hotmail.com --- On a positive note, the test plan worked, and a time prove -v t/db_dependent/Borrowers.t seemed to run a little faster on default data with the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14393] Add collection code filter to inventory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 --- Comment #5 from David Cook dc...@prosentient.com.au --- (In reply to Jonathan Druart from comment #4) David, In my dev installation, items.ccode is not mapped. Which makes the dropdown list populated with all my authorized values :) You certainly need to care about the value of AdvancedSearchTypes, you will have to propose item type too. Marked as Failed QA. I'm not sure what you mean by You certainly need to care about the value of AdvancedSearchTypes, you will have to propose item type too. Could you clarify? I'll look into the problem with the mapping in the meantime though :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14031] Itemnumber should be a numeric search in ccl.properties
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14031 --- Comment #6 from David Cook dc...@prosentient.com.au --- (In reply to Jonathan Druart from comment #4) Shouldn't we do the same for the biblionumber? biblionumber isn't indexed in MARC21, although the biblionumber is indexed as local-number in MARC21. It's indexed as numeric and word though, so I haven't encountered this problem with it before. I suppose it might be worthwhile having a larger discussion about what indexes should exist and how we index them... (as numeric, word, phrase, etc) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14031] Itemnumber should be a numeric search in ccl.properties
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14031 --- Comment #5 from David Cook dc...@prosentient.com.au --- (In reply to Jonathan Druart from comment #3) It does not work for UNIMARC, the itemnumber is not indexed. In that case, perhaps I should amend the name of the bug to be MARC21/NORMARC specific? Do you want itemnumber to be indexed in UNIMARC? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13719] Make Koha::Objects store list of resultant objects on an as needed basis
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #6 from M. Tompsett mtomp...@hotmail.com --- Couldn't this be a memory hog? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13448] runreport.pl html email striping
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13448 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #5 from M. Tompsett mtomp...@hotmail.com --- Marking as failed qa because: 1) coding style which has multiple side effects in a single statement, but more importantly, 2) Only generating table.../table, because of excessive cutting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13719] Make Koha::Objects store list of resultant objects on an as needed basis
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719
--- Comment #7 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 36022
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36022
Bug 13719 - Make Koha::Objects store list of resultant objects on an as needed
basis
Review of attachment 36022:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=13719attachment=36022)
-
Is there some default behaviour that I'm unaware of in terms of attempting to
access something past the boundary of a list?
::: Koha/Objects.pm
@@ +140,4 @@
sub next {
my ( $self ) = @_;
+my $object = $self-_objects()-[ $self-{_iterator}++ ];
No boundary check?!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10988] Allow login via Google OAuth2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988
--- Comment #34 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 40252
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40252
Bug 10988 - Allow login via Google OAuth2
Review of attachment 40252:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=10988attachment=40252)
-
::: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
@@ +78,4 @@
[% IF
Koha.Preference('casAuthentication') %]
[%# CAS authentication is too
complicated for modal window %]
lia
href=/cgi-bin/koha/opac-user.plLog in to your account/a/li
+[% ELSIF ( Koha.Preference('
GoogleOAuth2') == 1 ) %]
Space! Oops.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10988] Allow login via Google OAuth2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10988] Allow login via Google OAuth2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #40252|0 |1 is obsolete|| --- Comment #35 from M. Tompsett mtomp...@hotmail.com --- Created attachment 40442 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40442action=edit Bug 10988: Allow login via Google OAuth2 Adds googleoauth2 login to koha. Adds applicable system preferences Modifies templates to support oauth2 login failures changes the login links to use googleoauth2 when oauth2 is enabled. Test Plan: 0) Back up your database 1) Apply this patch 2) In your mysql client use your Koha database and execute: DELETE FROM systempreferences; SOURCE ~/kohaclone/installer/data/mysql/sysprefs.sql; -- Should be no errors. SELECT * FROM systempreferences LIKE 'GoogleOAuth%'; -- Should see 4 entries. QUIT; 3) Restore your database 4) Run ./installer/data/mysql/updatedatabase.pl; 5) In your mysql client use your Koha database and execute: SELECT * FROM systempreferences LIKE 'GoogleOAuth%'; -- Should see the same 4 entries. 6) Log into the staff client 7) Home - Koha administration - Global system preferences 8) - OPAC -- make sure your OPACBaseURL is set (e.g. https://opac.koha.ca) 9) - Administration -- There should be a 'Google OAuth2' section with the ability to set those 4 system preferences. 10) In a new tab, go to https://console.developers.google.com/project 11) Click 'Create Project' 12) Type in a project name that won't freak users out, like your library name (e.g. South Pole Library). 13) Click the 'Create' button. 14) Click the 'APIs auth' in the left frame. 15) Click 'Credentials' 16) Click 'Create new Client ID' 17) Select 'Web application' and click 'Configure consent screen'. 18) Select the Email Address. 19) Put it a meaningful string into the Product Name (e.g. South Pole Library Authentication) 20) Fill in the other fields as desired (or not) 21) Click 'Save' 22) Change the 'AUTHORIZED JAVASCRIPT ORIGINS' to your OPACBaseURL. (http://library.yourDNS.org) 23) Change the 'AUTHORIZED REDIRECT URIS' to point to the new googleoauth2 script (http://library.yourDNS.org/cgi-bin/koha/svc/googleoauth2) 24) Click 'Create Client ID' 25) Copy and paste the 'CLIENT ID' into the GoogleOAuth2ClientID system preference. 26) Copy and paste the 'CLIENT SECRET' into the GoogleOAuth2ClientSecret system preference. 27) Change the GoogleOAuth2 preference to 'Use'. 28) Click 'Save all Administration preferences' 29) In the OPAC, click 'Log in to your account'. -- You should get a confirmation request, if you are already logged in, OR a login screen if you are not. -- You need to have the primary email address set to one authenticated by Google in order to log in. 30) Run koha qa test tools NOTE: I don't like that it is specific to Google. I don't like that it does not use a library to do the authenticating portions. However, it is functional. Signed-off-by: Mark Tompsett mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14389] Editing a syspref in a textarea does not enable the Save button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 David Cook dc...@prosentient.com.au changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #12 from David Cook dc...@prosentient.com.au --- I was thinking about this bug recently. I suppose it still won't work for WYSIWYG editors in some cases, but that's not a community concern (yet). I'll have to do some thinking on that one when I have time... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13448] runreport.pl html email striping
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13448
--- Comment #4 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 34342
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34342
Bug 13448: Make Striping gmail/hotmail compatible
Review of attachment 34342:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=13448attachment=34342)
-
::: misc/cronjobs/runreport.pl
@@ -270,4 @@
my $email = Koha::Email-new();
my %mail;
if ($format eq 'html') {
-$message = htmlheadstyletr:nth-child(2n+1) {
background-color: #ccc;}/style/headbody$message/body/html;
It makes sense to remove the head.../head, but the
htmlbody$message/body/html should probably be left in tact. Otherwise,
you get just table.../table as your message.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hm, this would need good testing. I think you also need to make sure there is no problem with the way credits work. But it would be good to have! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
