[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #59 from Amit amitddng...@gmail.com --- Created attachment 40641 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40641action=edit Bug 6810 - Fix QA failures Bug 6810 - Fix QA failures - remove DateTime-now() - use Koha::DateUtils-dt_from_string; - use Pod2usage for the usage - use Modern::Perl - use branches table - Change letter code from MEMEXP to MEMBERSHIP_EXPIRY -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #60 from Amit amitddng...@gmail.com --- Created attachment 40642 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40642action=edit Bug 6810 - Fix QA failures MembershipExpiryDaysNotice system preferences arragned alphabetical order. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #61 from Amit amitddng...@gmail.com --- Created attachment 40643 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40643action=edit Bug 6810 - Fix QA failures Change letter code from MEMEXP to MEMBERSHIP_EXPIRY add branches.branchname in letter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit amitddng...@gmail.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit amitddng...@gmail.com changed: What|Removed |Added Attachment #40641|0 |1 is obsolete|| Attachment #40642|0 |1 is obsolete|| Attachment #40643|0 |1 is obsolete|| --- Comment #62 from Amit amitddng...@gmail.com --- Created attachment 40644 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40644action=edit Bug 6810 - Fix QA failures - remove DateTime-now() - use Koha::DateUtils-dt_from_string; - use Pod2usage for the usage - use Modern::Perl - use branches table - Change letter code from MEMEXP to MEMBERSHIP_EXPIRY -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #63 from Amit amitddng...@gmail.com --- Created attachment 40645 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40645action=edit Bug 6810 - Fix QA failures MembershipExpiryDaysNotice system preferences arragned alphabetical order. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #64 from Amit amitddng...@gmail.com --- Created attachment 40646 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40646action=edit Bug 6810 - Fix QA failures Change letter code from MEMEXP to MEMBERSHIP_EXPIRY add branches table branches.branchname in letter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #35916|0 |1 is obsolete|| --- Comment #40 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 40647 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40647action=edit [SIGNED OFF] Bug 8995: Show OpenURL links in OPAC search results Rebased on master + updated generated CSS file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14440] get_template_and_user can not have an empty template_name
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14440 --- Comment #25 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I think the last patch I attached should work for 3.18.x. But please double check before this is used! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #32 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Katrin Fischer from comment #31) Moving to Failed QA to indicate there is something missing here still - please address! :) Now working on this one again. Hope to get this further! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14440] get_template_and_user can not have an empty template_name
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14440 --- Comment #23 from Katrin Fischer katrin.fisc...@bsz-bw.de --- The patch for the ratings needs to be amended to work correctly on 3.18 - resolving the conflict and removing all the 'use' as in the patch will break the feature it looks like. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14440] get_template_and_user can not have an empty template_name
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14440 --- Comment #24 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 40648 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40648action=edit [3.18.x] Bug 14440: get_template_and_user can not have an empty template_name (opac-ratings.pl) Since Bug 14408, the method get_template_and_user can not have an empty template_name. Pages calling with an empty value should use C4::Auth::checkauth() This patch corrects opac/opac-ratings.pl Test plan : - Apply patch - Set sysopref OpacStarRatings to 'results and details' - Disable Javascipt on your browser (otherwise it will use ajax) - Login at OPAC - Go to a record - Click on a button left of 'Rate me' to choose a rating, ie 4 - Click on 'Rate me' = The page is reloaded and you see 'your rating: 4' - Loggout from OPAC - Try to access URL : http://serveur/cgi-bin/koha/opac-ratings.pl = You see the loggin page Signed-off-by: Indranil Das Gupta (L2C2 Technologies) indr...@gmail.com Signed-off-by: Tomas Cohen Arazi tomasco...@theke.io Signed-off-by: Katrin Fischer katrin.fisc...@bsz-bw.de Signed-off-by: Tomas Cohen Arazi tomasco...@unc.edu.ar Conflicts: opac/opac-ratings.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit amitddng...@gmail.com changed: What|Removed |Added Attachment #40121|0 |1 is obsolete|| Attachment #40646|0 |1 is obsolete|| --- Comment #65 from Amit amitddng...@gmail.com --- Created attachment 40649 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40649action=edit Bug-6810-Add-sample-notices Add Sample notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14467] New: Security updates break some Koha plugins
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14467 Bug ID: 14467 Summary: Security updates break some Koha plugins Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The new security updates break previously functioning plugins, most notably the cover flow plugin and the Ebsco EDS plugin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14431] Encoding issues - search in staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 Andreas Roussos arouss1...@gmail.com changed: What|Removed |Added CC||arouss1...@gmail.com --- Comment #6 from Andreas Roussos arouss1...@gmail.com --- I can confirm that applying the patch fixes the issue for me (searching for Greek characters was broken in the staff interface). FWIW I'm using koha 3.20 on Ubuntu 15.04 and my Encode.pm is at version 2.60. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14382] datepicker's dateFormat setting for reports is missing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14382
--- Comment #15 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 40611
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40611
Bug 14382: Non-ISO Date parameters generate empty reports.
Review of attachment 40611:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=14382attachment=40611)
-
::: reports/guided_reports.pl
@@ +755,4 @@
# if there are special regexp chars, we must \ them
$split[$i*2+1] =~ s/(\||\?|\.|\*|\(|\)|\%)/\\$1/g;
+if ($split[$i*2+1] =~ /|date/) {
+$quoted = substr(dt_from_string($quoted),0,10);
I blame Amit Gupta for showing me this mistake.
output_pref({ dt = (dt_from_string() + $days), dateformat = 'iso', dateonly
= 1 });
I should have used output_pref!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14463] Setting autobarcode to branchyymm00001 exports blank barcode labels
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14463 --- Comment #2 from Chris Nighswonger cnighswon...@foundations.edu --- You may read more about the TT font pathing foo here: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375#c69 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #39 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 40660 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40660action=edit Bug 14167 [QA Followup] - Add template and changes needed for packages Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Amended: upgraded DEBUG level to WARN in config file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #37 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 40658 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40658action=edit Bug 14167: [QA Follow-up] Adjust category handling in Koha::Logger The first patch makes the category parameter mandatory. This patch makes it optional, falling back to the current package. This is the expected log4perl model. It would not be necessary to pass the class name everywhere (check subclasses..) It also adds a delimiter between the interface and the class name. This allows you to add config lines like: log4perl.logger.opac.C4.Auth = DEBUG, OPAC log4perl.logger.intranet.C4.Circulation = TRACE, INTRANET The first line would make the logger more sensitive to C4::Auth log messages while staying at the WARN level for other messages, etc. The second line makes the trace visible from the renewal example. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12670] Show materials label instead of code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12670 --- Comment #16 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Julian, when you check-in or check-out an item with materials set, there is a little dialog box showing up with the text from the field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13853] Show waiting hold expiration date for waiting holds in holds ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13853] Show waiting hold expiration date for waiting holds in holds ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 --- Comment #10 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 40675 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40675action=edit Bug 13853 [QA Followup] - Add unit tests for branch getting methods -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13853] Show waiting hold expiration date for waiting holds in holds ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 --- Comment #9 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 40674 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40674action=edit Bug 13853: Add tests for is_waiting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #45 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Robin, What do you think of adding a line like create 660 [koha-instance-user] [koha-instance-group] to koha-common.logrotate ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #34 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 40653 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40653action=edit Bug 14167: Add a unit test for Koha::Logger Test plan: Run the test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11405] Inventory tool enhancements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405
--- Comment #32 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 40577
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40577
Bug 11405 [6] - Allow items with selected locations to be not be flagged as
Item should have been scanned if not scanned
Review of attachment 40577:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=11405attachment=40577)
-
::: C4/Items.pm
@@ +1164,4 @@
# Auth values
foreach (keys %$row) {
if
(defined($avmapping-{items.$_,.$row-{'frameworkcode'}.,.$row-{$_}})) {
+$row-{$_-code} = $row-{$_};
Though not required by PERL17 of the Coding Guidelines, a test would be nice.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14439] Typo in Bug 14408 regexp
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14439 --- Comment #10 from Fridolin SOMERS fridolin.som...@biblibre.com --- regexp is an old friend of mine ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7174] Authentication rewriting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174
--- Comment #9 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 40678
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40678
Bug 7174 - Authentication rewriting - LDAP Component - WIP
Review of attachment 40678:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=7174attachment=40678)
-
::: C4/Auth_with_ldap.pm
@@ +115,2 @@
sub checkpw_ldap {
+my ($userid, $password) = @_;
If we are rewriting, could we please hashref everything? :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #25 from M. Tompsett mtomp...@hotmail.com --- (In reply to Kyle M Hall from comment #24) Please provide a test plan. I'm assuming they followed comment #2, comment #13, and/or comment #20. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #24 from Kyle M Hall k...@bywatersolutions.com --- Please provide a test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7174] Authentication rewriting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 --- Comment #8 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 40680 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40680action=edit Bug 7174 - Authentication rewriting - Looking into generating a superuser and encapsulating it nicely. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11405] Inventory tool enhancements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 --- Comment #31 from M. Tompsett mtomp...@hotmail.com --- Comment on attachment 40572 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40572 Bug 11405 [1] - Warn of items possibly scanned out of order Review of attachment 40572: -- (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=11405attachment=40572) - ::: tools/inventory.pl @@ +373,5 @@ my @results; +@results = +$uploadbarcodes ? @items_with_problems + : $op ? @$inventorylist + : undef; Nested ? operators is ugly. Could we improve readability here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14467] Security updates break some Koha plugins
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14467 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14467] Security updates break some Koha plugins
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14467 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9942] Circulation module cannot anonymise if anonymity user is not set up correctly.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9942 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9942] Circulation module cannot anonymise if anonymity user is not set up correctly.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9942 --- Comment #6 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 40683 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40683action=edit Bug 9942 [QA Followup] - Add test and alert to returns.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9942] Circulation module cannot anonymise if anonymity user is not set up correctly.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9942 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #40394|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 40682 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40682action=edit [PASSED QA] Bug 9942: Make Koha fails if privacy is not respected If a patron has requested anonymity on returning items and the system is not correctly configured (AnonymousPatron no set or set to an inexistent patron), the application should take it into account and not fail quietly. This patch is quite radical: the script will die loudly if the privacy is not respected. To be care of the bad Software error, some checks are done in the updatedatabase to be sure the admin will be warned is something is wrong in the configuration. Test plan: 1/ Test the updatedatabase entry: a. Turn on OPACPrivacy and set AnonymousPatron to an existing patron = You will get a warning b. Turn on OPACPrivacy and set AnonymousPatron to 0 or '' = You will get a warning c. Turn on OPACPrivacy and set the privacy to 2 (Never) for at least 1 patron Turn off OPACPrivacy = You will get a warning d. In all other cases you will get no error 2/ Test the interface a. Turn on OPACPrivacy and set the privacy to 2 (Never) for a patron b. Now you can turn off OPACPrivacy or keep it on, behavior should be the same c. check an item out the patron d. Check the item in using the check out table = fail e. Check the item in using the Check in tab = fail (not gracefully). Note that the software error could appear on other pages too. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Updatedatabase works as described On staff, if don't have correct settings for anonymity it's impossible to check-in (with OPACPrivacy on) No errors Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #32683|0 |1 is obsolete|| --- Comment #66 from M. Tompsett mtomp...@hotmail.com --- Created attachment 40665 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40665action=edit [SIGNED-OFF] Bug-6810: Send membership expiry reminder notices. A new crontab based perl script to send membership expiry reminders. A system preference controls the number of days in advance of membership expiry that the notices will be sent on. To Test: 1) Create a new Patron and set membership expiry date 14 days from the date of registration. 2) Check your systemprefence ( MemExpDayNotice to 14 days default value) 3) Manual testing Run ( perl membership_expiry.pl -h) It would give you various option: This script prepares for membership expiry reminders to be sent to patrons. It queues them in the message queue, which is processed by the process_message_queue.pl cronjob. See the comments in the script for directions on changing the script. This script has the following parameters : -c Confirm and remove this help warning -n send No mail. Instead, all mail messages are printed on screen. Useful for testing purposes. -v verbose Do you wish to continue? (y/n) 4) Choose option for ex: perl membership_expiry.pl -c 5) Go to your koha database and check message_queue table you see some results. 6) Run (perl process_message_queue.pl) it will send email to those patron whose membership after 14 days from today. 7) Cron testing: (10 1 * * * $KOHA_CRON_PATH/membership_expiry.pl -c) 8) Set your 15 * * * * $KOHA_CRON_PATH/process_message_queue.pl 9) After running membership_expiry.pl, (process_message_queue.pl will send emails to those patron whose membership after 14 days from today). Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13851] Replace waiting holds logic in circulation.pl with Koha Objects
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13851 --- Comment #19 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 40669 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40669action=edit Bug 13851 [QA Followup] - Unit Tests Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #44 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Thanks for your quick signoff, Kyle. QA Comment: All issues mentioned before have been addressed in various follow-ups. An upgrade without a log4perl config file will no longer be a problem. Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14463] Setting autobarcode to branchyymm00001 exports blank barcode labels
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14463 --- Comment #4 from Chris Nighswonger cnighswon...@foundations.edu --- (In reply to Bernardo Gonzalez Kriegel from comment #3) (In reply to Lennon Mazonde from comment #0) Setting the autobarcode preference in Administration to generate barcodes in the form branchyymm1 exports blank barcode labels in the Label Creator (it prints out the digit/letters but not the barcode lines) ... [Thu Jun 25 15:24:52.560515 2015] [cgi:error] [pid 14148] [client 197.221.240.195:38832] AH01215: [Thu Jun 25 21:24:52 2015] label-create-pdf.pl: Use of uninitialized value in -e at /usr/share/koha/lib/C4/Creators/PDF.pm line 226., referer: http://staffdemo.muhachabooks.com/cgi-bin/koha/labels/label-print.pl Are you using EAN13 barcodes? I think that they can only be digits, perhaps your branch code is the culprit. From PDF::Reuse::Barcode page: EAN13 Creates EAN13 barcodes from a string of 12 or 13 digits. The check number (the 13:th digit) is calculated if not supplied. If there is given check number it is not controlled. Regardless, it will always die at the same point due to missing TTF paths in the configuration file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14463] Setting autobarcode to branchyymm00001 exports blank barcode labels
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14463 Chris Nighswonger cnighswon...@foundations.edu changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=8375 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14466] koha-stop-zebra does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14466 --- Comment #1 from Mirko Tietgen mi...@abunchofthings.net --- This also has the effect that other commands do not work. If I disable and delete an instance, the user is still in use (running daemon and zebrasrv), can't be deleted, the dead conf symlink remains in /etc/apache2/sites-enabled, apache goes crazy over it and tells me to install stuff, zombie apocalypse starts and it all has to be cleaned up manually. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger cnighswon...@foundations.edu changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14463 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #40120|0 |1 is obsolete|| Attachment #40122|0 |1 is obsolete|| Attachment #40180|0 |1 is obsolete|| --- Comment #67 from M. Tompsett mtomp...@hotmail.com --- Created attachment 40666 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40666action=edit Bug 6810: [SIGNED-OFF] Squashed Alex Arnaud's patches The following three patches were already signed off by Indranil and authored by Alex, so I squashed them for simplicity. -- Mark Tompsett Bug 6810 - Add new systempreference (MembershipExpiryDaysNotice) Bug 6810 - Fix QA failures - Use KohaDates to convert dateexpiry - remove MYSQL specifics methods for date handling in GetUpcomingMembershipExpires - make the script membership_expiry.pl write in Koha system logs - add tests Bug 6810 - Fix QA failures: - use Koha::DateUtils instead of Koha::Template::Plugin::KohaDates, - Add test with syspref MembershipExpiryDaysNotice equals 0 and undef, - fix (new) test failure (when MembershipExpiryDaysNotice is undef). Signed-off-by: Indranil Das Gupta (L2C2 Technologies) indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #40644|0 |1 is obsolete|| Attachment #40645|0 |1 is obsolete|| Attachment #40649|0 |1 is obsolete|| --- Comment #68 from M. Tompsett mtomp...@hotmail.com --- Created attachment 40667 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40667action=edit Bug 6810: Squashed Amit Gupta's patches Amit added these fixes which were not signed off yet, so I squashed them for simplicity. -- Mark Tompsett Bug 6810 - Fix QA failures - remove DateTime-now() - use Koha::DateUtils-dt_from_string; - use Pod2usage for the usage - use Modern::Perl - use branches table - Change letter code from MEMEXP to MEMBERSHIP_EXPIRY Bug 6810 - Fix QA failures - MembershipExpiryDaysNotice system preferences arragned alphabetical order. Bug 6810 - Add sample notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12670] Show materials label instead of code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12670 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #32765|0 |1 is obsolete|| --- Comment #14 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 40671 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40671action=edit Bug 12670: Show materials label instead of code Rebased on master + fixed issues when items.materials is not linked to AV list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13851] Replace waiting holds logic in circulation.pl with Koha Objects
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13851 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #40256|0 |1 is obsolete|| Attachment #40257|0 |1 is obsolete|| Attachment #40258|0 |1 is obsolete|| --- Comment #18 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 40668 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40668action=edit Bug 13851 - Replace waiting holds logic in circulation.pl with Koha Objects This is the original patch for bug 12892 and replaces the older style of fetching the holds data with Koha Objects. It will be used as a foundation for future features. Test Plan: 1) Apply this patch 2) Create a hold, set to waiting 3) Browse to circulation.pl for that patron 4) Note you see the list of waiting holds 5) Switch your logged in branch to a different branch 6) Note the Waiting at line is no longer emphasized. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Cathi Wiggins cwigg...@ci.arcadia.ca.us Signed-off-by: Megan Wianecki mwiane...@mplmain.mtpl.org Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14463] Setting autobarcode to branchyymm00001 exports blank barcode labels
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14463 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- (In reply to Lennon Mazonde from comment #0) Setting the autobarcode preference in Administration to generate barcodes in the form branchyymm1 exports blank barcode labels in the Label Creator (it prints out the digit/letters but not the barcode lines) ... [Thu Jun 25 15:24:52.560515 2015] [cgi:error] [pid 14148] [client 197.221.240.195:38832] AH01215: [Thu Jun 25 21:24:52 2015] label-create-pdf.pl: Use of uninitialized value in -e at /usr/share/koha/lib/C4/Creators/PDF.pm line 226., referer: http://staffdemo.muhachabooks.com/cgi-bin/koha/labels/label-print.pl Are you using EAN13 barcodes? I think that they can only be digits, perhaps your branch code is the culprit. From PDF::Reuse::Barcode page: EAN13 Creates EAN13 barcodes from a string of 12 or 13 digits. The check number (the 13:th digit) is calculated if not supplied. If there is given check number it is not controlled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13851] Replace waiting holds logic in circulation.pl with Koha Objects
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13851 --- Comment #20 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 40670 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40670action=edit Bug 13851: Fix typo in POD Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14463] Setting autobarcode to branchyymm00001 exports blank barcode labels
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14463
--- Comment #5 from Chris Nighswonger cnighswon...@foundations.edu ---
(In reply to Chris Nighswonger from comment #4)
Regardless, it will always die at the same point due to missing TTF paths in
the configuration file.
Here is the point of failure based on the log posted:
http://tinyurl.com/orn9pnr
The missing paths cause $ttf_path-{content} to not be initialized which causes
the '-e' to bork. There really should be a more graceful error handler in play
here.
Of course, there may be another issue at play here as well, and that may be
what Bernardo has pointed out.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #17 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 40677 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40677action=edit Bug 13517 [QA Followup] - Add unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7174] Authentication rewriting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 --- Comment #7 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 40678 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40678action=edit Bug 7174 - Authentication rewriting - LDAP Component - WIP -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13853] Show waiting hold expiration date for waiting holds in holds ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #40037|0 |1 is obsolete|| Attachment #40417|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 40673 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40673action=edit Bug 13853 - Show waiting hold expiration date for waiting holds in holds ajax datatable We should show the expiration date for waiting holds in the holds datatable that appears in circulation.pl and moremember.pl Test Plan: 1) Ensure ReservesMaxPickUpDelay is set 2) Place a hold on a record 3) Place a second hold and set it to waiting by checking it in 4) Place a third hold with an expiration date 5) View the holds tab on circulation.pl and moremember.pl 6) Note the first hold has no expiration date 7) Note the second hold has an expiration date of today + ReservesMaxPickUpDelay days 8) Note the thrid hold has an expiration date of whatever you set it to Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Cathi Wiggins cwigg...@ci.arcadia.ca.us Signed-off-by: Megan Wianecki mwiane...@mplmain.mtpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added CC|mi...@abunchofthings.net| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13853] Show waiting hold expiration date for waiting holds in holds ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 --- Comment #11 from Kyle M Hall k...@bywatersolutions.com --- In the table: Item is waiting here Item is waiting at Le Cannet Is it expected to have here in one case and the library name in the other case? Yes that is existing behavior and remains unchanged. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #40036|0 |1 is obsolete|| --- Comment #16 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 40676 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40676action=edit Bug 13517 - Show waiting date on reserve/request.pl The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl In addition, if the ReservesMaxPickUpDelay syspref is set, we should display the date when the waiting hold expires. Test Plan: 1) Apply this patch 2) Set ReservesMaxPickUpDelay to 7 3) Find a waiting hold 4) Browse to reserve/request.pl for that record 5) Notice the Item waiting message now has since waitingdate 6) Notice the expiration field now has the date of waitingdate + 7 days Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Cathi Wiggins cwigg...@ci.arcadia.ca.us Signed-off-by: Megan Wianecki mwiane...@mplmain.mtpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14465] Broken umlauts/diacritics in feedback of last checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14465] Broken umlauts/diacritics in feedback of last checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #40655|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 40679 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40679action=edit [PASSED QA][3.18.x] Bug 14465 - Broken umlauts/diacritics in feedback of last checkout This was tested in 3.18 after upgrading to the security release. The feedback on the last checkout information introcuded by bug 13315 has encoding problems in the displayed title (see screenshot). This is a really prominent place to display broken encoding. Test Plan: 1) Apply this patch 2) Check out an item with broken encoding 3) Note the title now displays properly Signed-off-by: Amit Gupta amit.gu...@informaticsglobal.com Signed-off-by: Katrin Fischer katrin.fisc...@bsz-bw.de We already put it in production... so this better works :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810
--- Comment #69 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 40667
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40667
Bug 6810: Squashed Amit Gupta's patches
Review of attachment 40667:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=6810attachment=40667)
-
::: C4/Members.pm
@@ +42,4 @@
use Koha::AuthUtils qw(hash_password);
use Koha::Database;
use Module::Load;
+use DateTime::Duration;
Why make it more complex here...
@@ +1491,4 @@
sub GetUpcomingMembershipExpires {
my $dbh = C4::Context-dbh;
+my $days = DateTime::Duration-new(days =
C4::Context-preference(MembershipExpiryDaysNotice) || 0);
and here...
@@ +1491,5 @@
sub GetUpcomingMembershipExpires {
my $dbh = C4::Context-dbh;
+my $days = DateTime::Duration-new(days =
C4::Context-preference(MembershipExpiryDaysNotice) || 0);
+my $dateexpiry = output_pref({ dt = (dt_from_string() + $days),
dateformat = 'iso', dateonly = 1 });
-- Why not keep the -add(days = $days):
my $dateexpiry = output_pref({ dt = (dt_from_string()-add( days = $days)),
dateformat = 'iso', dateonly = 1 });
-- dt_from_string passes back a DateTime object, just like DateTime-now().
-- Though, this gives me an idea to improve one of my patches. DOH!
@@ -1489,5 @@
sub GetUpcomingMembershipExpires {
my $dbh = C4::Context-dbh;
-my $days = C4::Context-preference(MembershipExpiryDaysNotice) || 0;
-my $dateexpiry = DateTime-now()-add(days = $days)-ymd();
... if the -add(days = $days) part was working here?
::: installer/data/mysql/de-DE/mandatory/sample_notices.sql
@@ +136,5 @@
INSERT INTO letter(module, code, branchcode, name, title, content,
message_transport_type)
+VALUES ('acquisition', 'ACQ_NOTIF_ON_RECEIV', '', 'Benachrichtigung bei
Zugang', 'Bestelltes Medium ist eingetroffen', 'Liebe/r
borrowers.firstname borrowers.surname,\n\nDie Bestellung
aqorders.ordernumber (biblio.title) ist eingetroffen und wird
bearbeitet.\n\nIhr Bibliotheksteam', 'email');
+
+INSERT INTO letter(module, code, branchcode, name, title, is_html, content)
Why did you exclude the message_transport_type?
Plus, if you added is_html to the INSERT above this one (and added the
appropriate default value of 0 in the VALUES list), you could have used commas,
instead of a whole new INSERT.
::: installer/data/mysql/en/mandatory/sample_notices.sql
@@ +155,5 @@
INSERT INTO letter(module, code, branchcode, name, title, content,
message_transport_type)
VALUES ('acquisition', 'ACQ_NOTIF_ON_RECEIV', '', 'Notification on
receiving', 'Order received', 'Dear borrowers.firstname
borrowers.surname,\n\n The order aqorders.ordernumber
(biblio.title) has been received.\n\nYour library.', 'email')
+
+INSERT INTO letter(module, code, branchcode, name, title, is_html, content)
As above.
::: installer/data/mysql/es-ES/mandatory/sample_notices.sql
@@ +150,5 @@
INSERT INTO letter(module, code, branchcode, name, title, content,
message_transport_type)
+VALUES ('acquisition', 'ACQ_NOTIF_ON_RECEIV', '', 'Notification on
receiving', 'Order received', 'Dear borrowers.firstname
borrowers.surname,\n\n The order aqorders.ordernumber
(biblio.title) has been received.\n\nYour library.', 'email');
+
+INSERT INTO letter(module, code, branchcode, name, title, is_html, content)
As above.
::: installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql
@@ +151,5 @@
INSERT INTO letter(module, code, branchcode, name, title, content,
message_transport_type)
+VALUES ('acquisition', 'ACQ_NOTIF_ON_RECEIV', '', 'Notification on
receiving', 'Order received', 'Dear borrowers.firstname
borrowers.surname,\n\n The order aqorders.ordernumber
(biblio.title) has been received.\n\nYour library.', 'email');
+
+INSERT INTO letter(module, code, branchcode, name, title, is_html, content)
As above.
::: installer/data/mysql/it-IT/necessari/notices.sql
@@ +148,5 @@
INSERT INTO letter(module, code, branchcode, name, title, content,
message_transport_type)
+VALUES ('acquisition', 'ACQ_NOTIF_ON_RECEIV', '', 'Notification on
receiving', 'Order received', 'Dear borrowers.firstname
borrowers.surname,\n\n The order aqorders.ordernumber
(biblio.title) has been received.\n\nYour library.', 'email');
+
+INSERT INTO letter(module, code, branchcode, name, title, is_html, content)
As above.
::: installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql
@@ +170,5 @@
INSERT INTO letter(module, code, branchcode, name, title, content,
message_transport_type)
+VALUES ('acquisition', 'ACQ_NOTIF_ON_RECEIV', '', 'Notification on
receiving', 'Order received', 'Dear borrowers.firstname
borrowers.surname,\n\n The order aqorders.ordernumber
(biblio.title) has been received.\n\nYour library.', 'email');
+
+INSERT INTO letter(module,
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #38 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 40659 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40659action=edit Bug 14167 - [DO_NOT_PUSH] Renewal example patch for logging This patch adds logging to the renewal process to test the first patch. Note to RM: Do not push this patch. Test plan: See the first patch. Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Amended the get call in light of the QA follow-up for category. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #40 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 40661 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40661action=edit Bug 14167 [QA Followup] - Embed default config into Koha::Logger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #42 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 40663 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40663action=edit [SIGNED-OFF] Bug 14167: Add a unit test for Koha::Logger Test plan: Run the test. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #43 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 40664 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40664action=edit Bug 14167 [QA Followup] - Tidy Koha/Logger.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12670] Show materials label instead of code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12670 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #15 from Julian Maurice julian.maur...@biblibre.com --- Katrin or Frédéric, could you be more specific about check-in and check-out messages? I don't see what you are talking about. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Amit amitddng...@gmail.com changed: What|Removed |Added Attachment #40666|0 |1 is obsolete|| Attachment #40667|0 |1 is obsolete|| --- Comment #70 from Amit amitddng...@gmail.com --- Created attachment 40685 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40685action=edit Bug 6810 - Add new systempreference (MembershipExpiryDaysNotice) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #71 from Amit amitddng...@gmail.com --- Created attachment 40686 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40686action=edit Bug 6810 - Fix QA failures -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14382] datepicker's dateFormat setting for reports is missing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14382 Amit amitddng...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 --- Comment #31 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 40692 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40692action=edit Bug 11882: (QA followup) fix capitalization errors Signed-off-by: Tomas Cohen Arazi tomasco...@unc.edu.ar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14382] datepicker's dateFormat setting for reports is missing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14382
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #40611|0 |1
is obsolete||
--- Comment #16 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40684
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40684action=edit
Bug 14382: Non-ISO Date parameters generate empty reports.
The issue is that SQL expects ISO dates, but the user may wish to view dates
according to the dateformat system preference.
By detecting a date preference, the non-ISO dates can be converted to ISO dates
before being stuffed back into the SQL query to be executed.
TEST PLAN
-
1) Add a report with date parameters.
-- I used 'Holds placed in date range' from
http://wiki.koha-community.org/wiki/SQL_Reports_Library
2) Set your dateformat to -MM-DD
3) Run the report
-- Note the SQL reads
... BETWEEN '{date formatted in -MM-DD}'...
-- If there is supposed to be data, there is some.
4) Set your dateformat to MM/DD/
5) Run the report
-- Note the SQL reads
... BETWEEN '{date formatted in MM/DD/}'...
-- If there is supposed to be data, there is none.
6) Apply patch
7) Repeat steps 2-5
-- The SQL will always read -MM-DD (ISO) format.
-- The report will have data, if there is some.
8) koha qa test tools.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14382] datepicker's dateFormat setting for reports is missing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14382 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #74 from Amit amitddng...@gmail.com --- Created attachment 40689 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40689action=edit Bug 6810 - Fix QA failures MembershipExpiryDaysNotice system preferences arragned alphabetical order -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #75 from Amit amitddng...@gmail.com --- Created attachment 40690 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40690action=edit Bug-6810-Add-sample-notices Review comments implemented -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14467] Security updates break some Koha plugins
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14467 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #3 from M. Tompsett mtomp...@hotmail.com --- (In reply to Kyle M Hall from comment #2) Note this patch requires a new module Cwd. I don't find any evidence that it has been packaged for Debian, however it is also marked as optional and only needed for the Plugins system. It's been a core module since at least Perl 5.8.8 as far as I can tell. http://perldoc.perl.org/5.8.8/index-modules-C.html -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14431] Encoding issues - search in staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #40504|0 |1 is obsolete|| CC||k...@bywatersolutions.com --- Comment #7 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 40693 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40693action=edit [PASSED QA] Bug 14431: FIX encoding issues in search (staff client) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14382] datepicker's dateFormat setting for reports is missing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14382 Amit amitddng...@gmail.com changed: What|Removed |Added Attachment #40684|0 |1 is obsolete|| --- Comment #17 from Amit amitddng...@gmail.com --- Created attachment 40691 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40691action=edit Bug 14382: Non-ISO Date parameters generate empty reports. Work perfectly!! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13739] KohaDates should display hours if they exists by default unless specified
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13739 --- Comment #5 from Kyle M Hall k...@bywatersolutions.com --- (In reply to Jonathan Druart from comment #4) Kyle, Before this patch, the plugin manages the as_due_date parameter. It's not with your patch. Marked as Failed QA. I'm not sure I'm following you. Can you explain what you mean a bit more and what you'd like to seem me change to get this to pass qa? Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC|mtomp...@hotmail.com| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #72 from Amit amitddng...@gmail.com --- Created attachment 40687 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40687action=edit Bug 6810 - Fix QA failures -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #73 from Amit amitddng...@gmail.com --- Created attachment 40688 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40688action=edit Bug 6810 - Fix QA failures - remove DateTime-now() - use Koha::DateUtils-dt_from_string; - use Pod2usage for the usage - use Modern::Perl - use branches table - Change letter code from MEMEXP to MEMBERSHIP_EXPIRY - review comments implemented -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out a reserved item.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #32 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Simith! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14467] Security updates break some Koha plugins
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14467 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 40681 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40681action=edit Bug 14467 - Security updates break some Koha plugins The new security updates break previously functioning plugins, most notably the cover flow plugin and the Ebsco EDS plugin. Test Plan: 1) Install and configure the cover flow plugin ( http://bywatersolutions.com/koha-plugins/ ) 2) Note that attempting to access coverflow.pl from the OPAC results in an error 3) Apply this patch 4) Note that coverflow.pl now output html again -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14467] Security updates break some Koha plugins
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14467 --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Note this patch requires a new module Cwd. I don't find any evidence that it has been packaged for Debian, however it is also marked as optional and only needed for the Plugins system. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14431] Encoding issues - search in staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #8 from Tomás Cohen Arazi tomasco...@gmail.com --- Please add a regression test in t/db_dependent/www/search_utf8.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added CC||n...@quecheelibrary.org --- Comment #4 from Nick Clemens n...@quecheelibrary.org --- The one minor thing I noted was that using the WYSIWYG Save button (diskette icon) the full page reloads as opposed to the nice message and quick save with the Koha button. Excellent feature! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Attachment #40509|0 |1 is obsolete|| --- Comment #3 from Nick Clemens n...@quecheelibrary.org --- Created attachment 40694 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40694action=edit [SIGNED OFF] Bug 11584 - Add wysiwyg editor to system preferences dealing with HTML This patch adds the ability to use a WYSIWYG editor for system preferences. The key files that I touch are: 1) admin/systempreferences.pl 2) koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt 3) koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt I also add: 4) koha-tmpl/intranet-tmpl/prog/en/includes/wysiwyg-systempreferences.inc and 5) koha-tmpl/intranet-tmpl/lib/tiny_mce/plugins/advimage This plugin is part of the TinyMCE distribution. It used to be in Koha, but then someone removed it. It's useful for preferences like opacheader though. -- _TEST PLAN_ Before applying: Note that there is no WYSIWYG editors for system preferences and that it's not an option when creating a new local system preference. Apply the patch. After applying: 1) Go to Global System Preferences 2) Go to Local use 3) Create a new system preference with a variable type of Htmlarea. 4) Click Save 5) Note that your system preference has a WYSIWYG editor instead of a textarea or some other type of input field. 6) Enter some content, bold it, insert images, etc. 7) Click Save 8) Reload the page 9) Note that your content is still there 10) Find koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref* 11) Change the type for opacheader from textarea to htmlarea 12) Reload the OPAC tab in Global System Preferences 13) Note that there is a WYSIWYG editor instead of a textarea for opacheader 14) Try different ways of changing the field's contents (e.g. typing with the keyboard, pasting content using the browser's paste option [note that browser security will probably prevent you using the context menu paste option], dragging text into the WYSIWYG editor box, etc.)** 15) Note that the preference says opacheader (modified) and the Save all OPAC preferences button has been enabled. 16) Click the save button and reload the page 17) Note that the content is there exactly as you entered it! 18) Try editing it again only using editor buttons (e.g. bold, link, etc) and note that the preference says opacheader (modified) and the save button has been enabled. 19) Look on the actual OPAC to see how your content has been rendered!*** *I opted not to edit any *.pref files with this commit as I think that's a separate step to actually adding the ability to use the WYSIWYG **If you're using anything except IE, this should work super well. If you're using IE, it'll probably only work for keyboard input and dragging text within the editor box but not from outside of it. IE has worse security, so you can probably paste using the context menu paste. ***While I think a WYSIWYG editor can be useful, there might be times where the content is displayed differently than it is in the editor because of higher level CSS and Javascript. Signed-off-by: Nick Clemens n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14387] Merge reference selection has no effect when merging authorities.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14387 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14387] Merge reference selection has no effect when merging authorities.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14387 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Attachment #40144|0 |1 is obsolete|| --- Comment #2 from Nick Clemens n...@quecheelibrary.org --- Created attachment 40695 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40695action=edit [SIGNED OFF] Bug 14387 - Merge reference selection has no effect when merging authorities. This patch swaps the authority records according to the refenrece record selection. To TEST: Merge two authority records, select the second as merge reference. The reference authority is always the first. Apply the patch. Repeat previous steps, the authority is now merged using the selected reference record. modified: authorities/merge.pl Signed-off-by: Nick Clemens n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added CC||n...@quecheelibrary.org --- Comment #13 from Nick Clemens n...@quecheelibrary.org --- Cleared a small conflict -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from checkin screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 --- Comment #1 from Jesse Weaver jwea...@bywatersolutions.com --- Created attachment 40697 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40697action=edit Bug 14464 - Add ability to cancel waiting holds from checkin screen Test plan: 1. Ensure that ExpireReservesMaxPickUpDelayCharge is set to 0. 2. Place a hold (doesn't matter whether it's a bib/item-level hold), then confirm the hold by checking it in. 3. Check in the item again, and hit Cancel. 4. The reserve in question should be cancelled. 5. Repeat steps 2-4 twice, once after setting ExpireReservesMaxPickUpDelayCharge to a nonzero value and again after clicking the Forgive fees for manually expired holds checkbox. A fine should only be applied when the syspref is enabled and the checkbox is not checked. Also, the checkbox should only appear after enabling the syspref. And finally, the checkbox should remember whether it is checked across multiple checkins, same as the Forgive overdue charges and Book drop mode checkboxes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from checkin screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 Jesse Weaver jwea...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Attachment #39621|0 |1 is obsolete|| --- Comment #12 from Nick Clemens n...@quecheelibrary.org --- Created attachment 40696 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40696action=edit Bug 14121: Silence warnings t/db_dependent/Auth_with_cas.t TEST PLAN - 1) $ prove t/db_dependent/Auth_with_cas.t -- CGI security warning 2) apply patch 3) $ prove t/db_dependent/Auth_with_cas.t -- no noise. 4) koha qa test tools Signed-off-by: Nick Clemens n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 --- Comment #14 from M. Tompsett mtomp...@hotmail.com --- (In reply to Nick Clemens from comment #13) Cleared a small conflict Thanks. Looks like a correct fix. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Blocks||14465 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14465] Broken umlauts/diacritics in feedback of last checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Depends on||13315 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #35 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Added two patches. See the commit messages. How do we proceed from here? Since the last two follow-ups add/change some more lines, I will first ask for a repeated signoff from Martin or Kyle. (But I still consider them as QA follow-ups.) If they agree (read: signoff), I will pass QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
