[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #17 from Nicole C. Engard neng...@gmail.com --- This looks like it's signed off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #3 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41036 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41036action=edit Bug 14544: Get rid of AddShelf -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #6 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41039 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41039action=edit Bug 14544: Move share routines to Koha::Virtualshelfshare and Koha::Virtualshelfshares -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #4 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41037 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41037action=edit Bug 14544: Get rid of DelShelf -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #2 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41035 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41035action=edit Bug 14544: Get rid of GetShelf -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #5 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41038 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41038action=edit Bug 14544: Get rid of ModShelf -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #8 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41041 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41041action=edit Bug 14544: Koha::Virtualshelfcontent[s] Get rid of AddToShelf and DelFromShelf -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #1 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41034 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41034action=edit Bug 14544: Add Koha::Virtualshelf and Koha::Virtualshelves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #7 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41040 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41040action=edit Bug 14544: Get rid of GetAllShelves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #9 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- Created attachment 41042 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41042action=edit Bug 14544: WIP - Get rid of GetShelves This does not work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Blocks||14544 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 [Bug 14544] Move the list related code to Koha::Virtualshelves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Status|ASSIGNED|In Discussion --- Comment #10 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- http://lists.koha-community.org/pipermail/koha-devel/2015-July/041641.html -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added Depends on||13019 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 [Bug 13019] Add base classes on which to build Koha objects -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #18 from Chris Cormack ch...@bigballofwax.co.nz --- (In reply to Nicole C. Engard from comment #17) This looks like it's signed off Hmm wrong bug by accident Nicole? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14524] Result list RSS feed broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #40978|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 41047 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41047action=edit [PASSED QA] Bug 14524: Don't escape query_cgi with uri According to the doc, we should not escape query_cgi with the uri filter: http://www.template-toolkit.org/docs/manual/Filters.html#section_uri Since query_cgi can contains something like: idx=kwq=42, we should not escape the char Test plan: 0/ Don't apply the patch 1/ Go on launch a search at the OPAC 2/ Click on the RSS icon 3/ You should arrive on opac-search.pl?idx%3Dkw%26q%3D42count=50sort_by=acqdate_dscformat=rss2 The has been escaped. 4/ Apply the patch 5/ Now you should get result and see an url correctly formatted. Signed-off-by: Chris Cormack chr...@catalyst.net.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14524] Result list RSS feed broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14524] Result list RSS feed broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14524] Result list RSS feed broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #41047|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14545] New: Typo in help file (stage-marc-import.tt)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14545 Bug ID: 14545 Summary: Typo in help file (stage-marc-import.tt) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Documentation Assignee: hector.hecax...@gmail.com Reporter: hector.hecax...@gmail.com QA Contact: testo...@bugs.koha-community.org Typo in help file from the new help in Koha 3.20, bug 14424: intranet-tmpl/prog/en/modules/help/tools/stage-marc-import.tt:28 It reads: (The match will look at the itemnumbers and barcodes to match on for items. Itemnumbers take precendence over barcodes), typo: precendence -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14489] Software error when trying to create new batch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14489 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added Version|unspecified |master CC||l...@catalyst.net.nz QA Contact||testo...@bugs.koha-communit ||y.org Assignee|ch...@bigballofwax.co.nz|gmcha...@gmail.com Component|Koha|Tools Group|Koha security | Product|Koha security |Koha --- Comment #4 from Liz Rea l...@catalyst.net.nz --- This is not a security bug. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14535] New: Late orders doensn't show orders with price = 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14535
Bug ID: 14535
Summary: Late orders doensn't show orders with price = 0
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Acquisitions
Assignee: koha-bugs@lists.koha-community.org
Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
If the price is unknown or the book is free, part of another deal or whatever,
the orders are entered with 0.00 as a price sometimes.
The problem is, that those orders won't ever show up in the late orders page,
although you might want to ask for them to be delivered. This is because of a
condition in the routine:
110 sub GetBooksellersWithLateOrders {
111 my ( $delay, $estimateddeliverydatefrom, $estimateddeliverydateto ) =
@_;
112 my $dbh = C4::Context-dbh;
117 my $query;
118 my @query_params = ();
119 my $dbdriver = C4::Context-config(db_scheme) || mysql;
120 $query =
121 SELECT DISTINCT aqbasket.booksellerid, aqbooksellers.name
122 FROM aqorders LEFT JOIN aqbasket ON
aqorders.basketno=aqbasket.basketno
123 LEFT JOIN aqbooksellers ON aqbasket.booksellerid = aqbooksellers.id
124 WHERE
125 ( datereceived = ''
126 OR datereceived IS NULL
127 OR aqorders.quantityreceived aqorders.quantity
128 )
129 AND aqorders.rrp 0
130 AND aqorders.ecost 0
131 AND aqorders.quantity - COALESCE(aqorders.quantityreceived,0)
0
132 AND aqbasket.closedate IS NOT NULL
133
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #16 from Eivin Giske Skaaren ei...@sysmystic.com --- Change in expected result: The date is not cleared anymore. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime-new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #28 from Jonathan Druart jonathan.dru...@bugs.koha-community.org --- We should have a look later at DateTime::Infinite http://search.cpan.org/~drolsky/DateTime-1.20/lib/DateTime/Infinite.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14536] New: PageObject-pattern base implementation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536
Bug ID: 14536
Summary: PageObject-pattern base implementation
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Test Suite
Assignee: ch...@bigballofwax.co.nz
Reporter: olli-antti.kivila...@jns.fi
QA Contact: gmcha...@gmail.com
This patch introduces:
-PageObject base class and example tests,
-a interactive debug script to drive PageObjects more easily.
--
PageObjects are used to make robust and reusable integration test components to
test various front-end features. PageObjects load a Selenium::Remote::Driver
implementation, phantomjs by default and use this to do scripted user actions
in the browser,
eg. clicking HTML-elements, accepting popup dialogs, entering text to input
fields.
PageObjects encapsulate those very low-level operations into clear and easily
usable actions or services, like doPasswordLogin().
PageObjects also seamlessly deal with navigation from one page to another, eg.
my $mainpage = t::lib::Page::Mainpage-new();
$mainpage-doPasswordLogin('admin', '1234')-gotoPatrons()-
searchPatrons({keywordSearch = Jane Doe});
PageObjects make doing integration tests so great!
You can google for the specifics of PageObject patterns and there are a ton of
great tutorials explaining their function.
-
Interactive debugger at misc/devel/interactiveWebDriverShell.pl loads the
desired PageObject with the needed parameters to the debugger context and makes
dynamic UserAgent scripting easy and fun!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13691] Add some selenium scripts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14536 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14536] PageObject-pattern base implementation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13691 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14290] Add a table foot to circulation matrix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added CC||l...@catalyst.net.nz Attachment #41019|0 |1 is obsolete|| --- Comment #11 from Liz Rea l...@catalyst.net.nz --- Comment on attachment 41019 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41019 Bug 14290 - fix number of columns in footer for 3.18 actually, i have something extra in here. one moment. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14495] WebDriver/WebTester Factory for easy generation of Web testing UserAgents.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14495 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #40818|0 |1 is obsolete|| --- Comment #5 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 41022 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41022action=edit Bug 14495 - WebDriver/WebTester Factory for easy generation of Web testing UserAgents. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14537] New: The system preference 'OverdueNoticeBcc' is mis-named.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14537 Bug ID: 14537 Summary: The system preference 'OverdueNoticeBcc' is mis-named. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: bar...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The system prefrerence 'OverdueNoticeBcc' seems, by its name, to imply that a BCC will be added to all overdue notices -- the description says that the address will be added to all notices. The behavior of the system follows the description, not the system preference name. The system preference should be re-named to NoticeBcc. See also * bug 12490 * discussion on the topic in #koha: http://irc.koha-community.org/koha/2015-07-16#i_1703637 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13995] Proper Exception handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Blocks||14536 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 [Bug 14536] PageObject-pattern base implementation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14495] WebDriver/WebTester Factory for easy generation of Web testing UserAgents.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14495 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Blocks||14536 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 [Bug 14536] PageObject-pattern base implementation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14536] PageObject-pattern base implementation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Depends on||13995, 13906, 14495 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 [Bug 13995] Proper Exception handling http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14495 [Bug 14495] WebDriver/WebTester Factory for easy generation of Web testing UserAgents. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Blocks||14536 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 [Bug 14536] PageObject-pattern base implementation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14536] PageObject-pattern base implementation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 --- Comment #1 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 41023 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41023action=edit Bug 14536 - PageObject-pattern base implementation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14538] New: POD for CalcFine is incomplete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14538 Bug ID: 14538 Summary: POD for CalcFine is incomplete Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Developer documentation Assignee: gmcha...@gmail.com Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org From reading the code it looks like CalcFine returns 4 values, while only 3 are documented (missing:chargeable_units). There is also a mismatch in names between the first and second paragraphs ($daycounttotal vs. $unitcount) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14538] POD for CalcFine is incomplete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14538 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13995] Proper Exception handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Blocks||14539 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 [Bug 14539] Introduction to castToObject(), aka. make a Koha::Object from various input types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14539] Introduction to castToObject(), aka. make a Koha::Object from various input types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 --- Comment #1 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 41025 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41025action=edit Bug 14539 - Introduction to castToObject(), aka. make a Koha::Object from various input types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13585] HEA - Cronjob Setup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585 Julian FIOL julian.f...@biblibre.com changed: What|Removed |Added CC||julian.f...@biblibre.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10148] 007/006 not filling in with existing values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10148 Zeno Tajoli z.taj...@cineca.it changed: What|Removed |Added CC||z.taj...@cineca.it --- Comment #2 from Zeno Tajoli z.taj...@cineca.it --- The bigger problem is on 007 for Electronic resource and Microform. The plugin can't handle existing values when positions 06,07,08 must to be worked together. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14290] Add a table foot to circulation matrix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 --- Comment #12 from Liz Rea l...@catalyst.net.nz --- Created attachment 41020 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41020action=edit Bug 14290 - fix number of columns in footer for 3.18 Jonathan pointed out that the smart rules table is slightly different in 3.20, this commit cleans it up for 3.18. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #40078|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14539] castToObject(), aka. make a Koha::Object from various input types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Assignee|gmcha...@gmail.com |olli-antti.kivila...@jns.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14530] 856$u URL checker ( check-url.pl ) complains about ftp based URLs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14530 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41026 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41026action=edit Bug 14530 - 856$u URL checker ( check-url.pl ) complains about ftp based URLs The script check-url.pl assumes that any URL not prefixed with http must be a relative URL. This is problematic as the URL could be prefixed with ftp as well. Any 856$u using an ftp url is given the error 400 URL Must be absolute. Since HTTP::Request cannot handle ftp urls, we should just skip them. I also noticed that check-url-quick.pl checks for prefixes with case insensitivity. That seems like a good idea so I've added that to check-url.pl Test Plan: 1) Apply this patch 2) Find or create a record with an ftp url in 865$u 3) Run check-url.pl 4) Note the ftp url is skipped 5) Run check-url-quick.pl 6) Note the ftp url is skipped -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14530] 856$u URL checker ( check-url.pl ) complains about ftp based URLs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14530 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #41014|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41015 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41015action=edit Bug 8483 - Add checkout classes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #9 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41016 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41016action=edit Bug 8483 - Add record and item related classes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #10 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41017 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41017action=edit Bug 8483 - Borrower reading history should include deleted items When showing a borrower's reading history, it'd be good to be able to include the deleted items also, as we have that information available. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Members/GetAllIssues.t 3) Verify old checkouts for deleted items show in reading history -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14496] Improving opac-detail.pl performances
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- CC||l...@catalyst.net.nz --- Comment #13 from Liz Rea l...@catalyst.net.nz --- Hi Julian, We weren't quite done here - still other versions this patch might go into. :) (So I'm reopening it) Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14496] Improving opac-detail.pl performances
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added Status|REOPENED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7923] Performance omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Bug 7923 depends on bug 14496, which changed state. Bug 14496 Summary: Improving opac-detail.pl performances http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14539] New: castToObject(), aka. make a Koha::Object from various input types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539
Bug ID: 14539
Summary: castToObject(), aka. make a Koha::Object from various
input types
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: gmcha...@gmail.com
Reporter: olli-antti.kivila...@jns.fi
QA Contact: testo...@bugs.koha-community.org
Currently Koha is like an archeological dig site, we have different layers of
dealing with various business objects.
We started with DBI and numerous ways of passing an HASH around. There is no
telling if it will be a List of column = values, or a reference to HASH, or a
HASH or just any of the business object's (eg. Borrower's) unique identifiers
(userid, cardnumber, borrowernumber).
Then DBIx came to the rescue and now we are need to learn DBI and DBIx and SQL
to do DB operatons in Koha. Migration to DBIx is on the way.
Finally we have Koha::Object and subclasses, which include and use the DBIx,
but those are not directly compatible, since Koha::Object is not a subclass of
DBIx::Class making life occasionally miserable.
Now we need to know 3 methods of DB accession.
I am really frustrated with all of those different layers of history, and
making things work nicely across all different programming patterns, I have had
great success in using a casting system, where we take any value and try to
make a Koha::Object-subclass out of it.
So we try to cast a Scalar or a reference of Koha::Object-implementation or
DBIx::ResultSet or HASH, to the desired Koha::Object-implementation.
This is a nice validation/entry function in any subroutine dealing with
business objects, making sure that we always have the correct implementation
of the same business object.
An example:
#Does this look familiar?
my $borrower = 1042; #A borrowernumber?
my $user = '121A0321312'; #A cardnumber? or userid?
my $borrower = {borrowernumber = 1043, cardnumber = '121A0321312', ...};
#HASH
my $borrower = Koha::Borrowers-find({borrowernumber = 1024});
my $borrower = $schema-resultset('Borrower')-find({borrowernumber = 1024});
#So when I call my subroutine with the $borrower I got using some function,
makeBorrowerHappy($borrower);
#Bad things most often happen.
#But if my makeBorrowerHappy()-function would cast its parameters to the
#correct type, there would be only merriment and fun!
sub makeBorrowerHappy {
my ($borrower) = @_;
$borrower = Koha::Borrowers::castToBorrower($borrower);
... #Do fun stuff!
}
#Whatever we throw at the subroutine, things just work (in theory)!
Even better, if the $borrower already is a DBIx-derivative or Koha::Borrower,
we don't even do anything, other than simple if statements. So minimally
expensive, maximally productive.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13995] Proper Exception handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995
Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:
What|Removed |Added
Attachment #40717|0 |1
is obsolete||
--- Comment #10 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 41018
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41018action=edit
Bug 13995 - Proper Exception handling
Koha has issues with propagating errors and exceptions from the business layer
to the front-end. Using a more sophisticated system of named Exceptions we can
send more formal signals towards the user.
Catching different types of Exceptions makes for a more concise handling of
errors.
Also throwing/catching Exceptions is a industry standard and for a good reason.
There is no point for Koha to lurk behind.
USAGE:
try {
Koha::Exception::BadSystemPreference-throw(error = 'Syspref
DisplayIconsXSLT is not a valid boolean');
} catch {
if (blessed($_) $_-isa('Koha::Exception::BadSystemPreference')) {
print $_-as_string();
warn $_-error, \n, $_-trace-as_string, \n;
}
else {
$_-rethrow();
}
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14290] Add a table foot to circulation matrix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 --- Comment #10 from Liz Rea l...@catalyst.net.nz --- Created attachment 41019 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41019action=edit Bug 14290 - fix number of columns in footer for 3.18 Jonathan pointed out that the smart rules table is slightly different in 3.20, this commit cleans it up for 3.18. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14536] PageObject-pattern base implementation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #6 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41013 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41013action=edit Bug 8483 - Borrower reading history should include deleted items TODO: Break patch into smaller parts, add unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #41013|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41014 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41014action=edit Bug 8483 - Add checkout classes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13691] Add some selenium scripts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #40819|0 |1 is obsolete|| --- Comment #13 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Comment on attachment 40819 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40819 Bug 13691 - PageObjectPattern implementation. Created a separate bug for the PageObject Pattern. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906
Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:
What|Removed |Added
Attachment #40072|0 |1
is obsolete||
--- Comment #5 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 41021
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41021action=edit
Bug 13906 - TestObjectFactory(ies) for Koha objects. Enable easy Test object
creation from HASHes or from preconfigured test groups.
Doing tests should be easy.
One biggest hindrance in doing tests is the difficulty of doing so in Koha.
We use a lot of hard-coded SQL, which occasionally requires quite a bit of
fiddling to get it right. Satisfying complex object dependency chains is hard.
For example, testing Overdue notice sending, one must create
-letters
-overuderules
-circulationrules
-borrowers
-biblios
-items
-issues (checkouts)
...
Also one must take care to clean up the database modifications afterward to
make
encapsulated tests which don't leak over other tests. This is especially so for
front-end testing.
TestObjectFactories significantly alleviate this pain, by offering
preconfigured
test object groups or enable creating test objects on demand.
They try to recover from errors, like when the previous test crashed and left
testing objects into the DB, preventing adding them again.
Also they store what object they created to 3 different levels of stashes to
facilitate complex test configurations, and they have the dignity to clean-up
the test contexts after testing has happened (if the script doesn't crash)!
USAGE:
use t::db_dependent::TestObjects::Borrowers::BorrowerFactory;
%#Setting up the test context
my $testContext = {};
my $password = '1234';
my $borrowerFactory =
t::db_dependent::TestObjects::Borrowers::BorrowerFactory-new();
my $borrowers = $borrowerFactory-createTestGroup([
{firstname = 'Olli-Antti',
surname= 'Kivi',
cardnumber = '1A01',
branchcode = 'CPL',
flags = '1', #superlibrarian, not exactly a very good way of
doing permission testing?
userid = 'mini_admin',
password = $password,
},
], undef, $testContext);
%#Test context set, starting testing:
eval {
... #Run your tests here
};
if ($@) { #Catch all leaking errors and gracefully terminate.
warn $@;
tearDown();
exit 1;
}
%#All tests done, tear down test context
tearDown();
done_testing;
sub tearDown {
t::db_dependent::TestObjects::ObjectFactory-tearDownTestContext($testContext);
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14495] WebDriver/WebTester Factory for easy generation of Web testing UserAgents.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14495 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Depends on||13995 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 [Bug 13995] Proper Exception handling -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13995] Proper Exception handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Blocks||14495 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14495 [Bug 14495] WebDriver/WebTester Factory for easy generation of Web testing UserAgents. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|olli-antti.kivila...@jns.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14539] Introduction to castToObject(), aka. make a Koha::Object from various input types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Depends on||13995 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 [Bug 13995] Proper Exception handling -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14539] Introduction to castToObject(), aka. make a Koha::Object from various input types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner h.meissner...@web.de changed: What|Removed |Added Attachment #41028|0 |1 is obsolete|| --- Comment #4 from Holger Meißner h.meissner...@web.de --- Created attachment 41029 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41029action=edit Bug 14395: Code changes This patch updates the calculation of 'No renewal before' to include the new syspref NoRenewalBeforePrecision. To test: 1) Switch syspref NoRenewalBeforePrecision to 'exact time'. 2) Check out an item with 'No renewal before' set to 1 hour. Confirm that you are unable to renew. Both staff client and OPAC user account should display that renewal is allowed exactly one hour before due. 3) Switch NoRenewalBeforePrecision to 'date'. Now the item should be renewable immediately. (Unless you test less than an hour before midnight) 4) Also test with unit set to days and other values. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14205] Deleting an Item/Record does not remove link to course reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- (In reply to Jonathan Druart from comment #2) Kyle, I think it makes sense to add this constraint, do you agree? Absolutely! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14496] Improving opac-detail.pl performances
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner h.meissner...@web.de changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540 --- Comment #1 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 41030 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41030action=edit Bug 14540 - Move member-flags.pl to PermissionsManager to better manage permissions for testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14496] Improving opac-detail.pl performances
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 --- Comment #14 from Julian FIOL julian.f...@biblibre.com --- Hi Liz, Ok, my bad :) But before changing its status to RESOLVED, it was in PUSHED TO STABLE. It may be not necessary changing it to NEED SIGNOFF, PUSHED TO STABLE should be fine ? Julian F. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #2 from Holger Meißner h.meissner...@web.de --- Created attachment 41027 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41027action=edit Bug 14395: Add new syspref NoRenewalBeforePrecision Currently the 'NoRenwalBefore' setting is based on the exact DateTime of the due date. This patch introduces a new global syspref for choosing if 'NoRenewalBefore' should instead be calculated based on date only. To test: 1) Apply patch, then run installer/data/mysql/updatedatabase.pl 2) Confirm that a new syspref NoRenewalBeforePrecision is available in administration. It should let you choose between 'date' (default) and 'exact time'. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #3 from Holger Meißner h.meissner...@web.de --- Created attachment 41028 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41028action=edit Bug 14395: Code changes This patch updates the calculation of 'No renewal before' to include the new syspref NoRenewalBeforePrecision. To test: 1) Switch syspref NoRenewalBeforePrecision to 'exact time'. 2) Check out an item with 'No renewal before' set to 1 hour. Confirm that you are unable to renew. Both staff client and OPAC user account should display that renewal is allowed exactly one hour after checkout. 3) Switch NoRenewalBeforePrecision to 'date'. Now the item should be renewable immediately. (Unless you test less than an hour before midnight) 4) Also test with unit set to days and other values. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14496] Improving opac-detail.pl performances
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14496] Improving opac-detail.pl performances
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14496 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14540] New: Move member-flags.pl to PermissionsManager to better manage permissions for testing.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540 Bug ID: 14540 Summary: Move member-flags.pl to PermissionsManager to better manage permissions for testing. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcha...@gmail.com Reporter: olli-antti.kivila...@jns.fi QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org Currently there is no nice way to grant/revoke permissions for Borrowers in Koha. This is a big problem when doing integration testing and when working with permissions using the future REST API. Currently we have one web-script, member-flags.pl, which deals with all permission-related things. Basically it always DELETEs all your permissions and then adds them again with some modifications. There is no internal API for creating permissions and this makes automated testing significantly harder. To create permissions for a test borrower, we must decrypt the arcane way of creating koha.borrowers.flags and add user_permissions with brittle SQL-queries. This makes for very messy test scripts, and quite frankly this is hardly ever done in Koha. Also the koha.borrowers.flags-column is pretty horrible. It is 19-bit binary array where each bit tells of the borrower has all permissions for the respective permission module. This is very difficult to calculate and the mechanism is hard to understand. This feature is also unnecessary, since we are always interested in having the specific permissions. We don't need to know if one Borrower has all the permissions for one module. Also what happens if more subpermissions are added to the module? Existing all-permission-holders lose their all-permissions-status? Instead we could have a nice internal API to work with permissions. My patch introduces a new database structure for permissions (not necessarily better), Koha::Object implementation of the DB structure, and most importantly, a Koha::Auth::PermissionManager which is a gateway to all permissions-related actions. This feature is well tested with unit tests and PageObject integration tests. See the tests for usage examples. Especially the t/db_dependent/Members/member-flags.t I hope you like it :) VOCABULARY: Module (permission_modules) = a module which consists of specific Permissions. Typically covers one Module in Koha. Permission (permission) = a specific Permission of a Module. Granting a Borrower the permission to do something. Borrower permission (borrower_permissions) = A specific Permission a specific Borrower has, eg. the permission to edit bibliographic records. TEST PLAN: -2. Note the permissions a bunch of borrowers has. -1. run updatedatabase.pl 0. Observe that those borrowers still have the same permissions. For modules which didn't have any subpermissions, a generic subpermission is added and the borrowers should have it if they had the existing module permission. Basic login: 1. Go to Koha staff client 2. Make a password login. 3. Browse to any other staff client pages to confirm that the session is active and login persists on other pages. Modify permissions: 1. Go to member-flags.pl (Home › Patrons › Set permissions) 2. Change your permissions. Save. 3. Go back to member-flags.pl 4. Observe that you see the same permissions you just set. Modify superlibrarian permission: 1. Go to member-flags.pl (Home › Patrons › Set permissions) 2. Give the superlibrarian-permission. Observe all other permissions vanishing. Save. 3. Go back to member-flags.pl 4. Observe that you see only the superlibrarian-permission active. 5. Observe that the superlibrarian permission is the only top-level permission which doesn't have any subpermissions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Blocks||14540 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540 [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14495] WebDriver/WebTester Factory for easy generation of Web testing UserAgents.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14495 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Blocks||14540 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540 [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14539] Introduction to castToObject(), aka. make a Koha::Object from various input types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Blocks||14540 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540 [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Assignee|gmcha...@gmail.com |olli-antti.kivila...@jns.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14536] PageObject-pattern base implementation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Blocks||14540 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540 [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Depends on||13995, 13906, 14495, 14536, ||14539 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 [Bug 13995] Proper Exception handling http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14495 [Bug 14495] WebDriver/WebTester Factory for easy generation of Web testing UserAgents. http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 [Bug 14536] PageObject-pattern base implementation http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 [Bug 14539] Introduction to castToObject(), aka. make a Koha::Object from various input types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13995] Proper Exception handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Blocks||14540 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540 [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 --- Comment #11 from Pedro Ferreira pedro.m.ferre...@mail.cm-portel.pt --- Hello in this demos http://koha-community.org/demo/ the marc21 demos do not suffer from the bug but the unimarc demos do suffer from the bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Severity|normal |major --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Upping severity as this deals with money. It's possible for a librarian to accidentally select the wrong tax rate due to this bug! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14542] Transliterate rule for all single quote forms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14542 Fridolin SOMERS fridolin.som...@biblibre.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |fridolin.som...@biblibre.co ||m QA Contact|fridolin.som...@biblibre.co |testo...@bugs.koha-communit |m |y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14541] New: Tax rate should not be forced to an arbitrary precision
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Bug ID: 14541 Summary: Tax rate should not be forced to an arbitrary precision Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The following is an example gstrate for a real library 0|.08625|.0863|.085|.09|.0825|.0875|.075|.07625 Note the .08625 and .0863 Both of those rates show up as 8.6% for the order line editor ( acqui/neworderempty.pl ). There is no reason to force these numbers to be rounded and in fact makes the label not match the value! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41031 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41031action=edit Bug 14541 - Tax rate should not be forced to an arbitrary precision The following is an example gstrate for a real library 0|.08625|.0863|.085|.09|.0825|.0875|.075|.07625 Note the .08625 and .0863 Both of those rates show up as 8.6% for the order line editor ( acqui/neworderempty.pl ). There is no reason to force these numbers to be rounded and in fact makes the label not match the value! Test Plan: 1) Set you gstrate pref to 0|.08625|.0863|.085|.09|.0825|.0875|.075|.07625 2) Edit an order line 3) Note that the tax rate pulldown lists 8.6% twice 4) Apply this patch 5) Refesh the page 6) Note the pulldown now lists the actual tax rate values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14542] Transliterate rule for all single quote forms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14542 Fridolin SOMERS fridolin.som...@biblibre.com changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |fridolin.som...@biblibre.co |y.org |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14542] New: Transliterate rule for all single quote forms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14542 Bug ID: 14542 Summary: Transliterate rule for all single quote forms Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org Single quotes in common language (not in programming) are usually ', but there is also the form ’. See https://fr.wikipedia.org/wiki/Apostrophe_%28typographie%29 This bug proposes to transliterate all forms into a space. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14544] New: Move the list related code to Koha::Virtualshelves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Bug ID: 14544 Summary: Move the list related code to Koha::Virtualshelves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Lists Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl There are some bugs in the list module which are not fixable easily, because of the (very) ugly C4::VirtualShelves::Page package. This module is completely stuck and there is no other way to rewrite it completely to make it move again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14539] Introduction to castToObject(), aka. make a Koha::Object from various input types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Summary|castToObject(), aka. make a |Introduction to |Koha::Object from various |castToObject(), aka. make a |input types |Koha::Object from various ||input types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13585] HEA - Cronjob Setup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585 --- Comment #5 from Julian FIOL julian.f...@biblibre.com --- Created attachment 41024 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41024action=edit Bug 13585 : Add a cronjob which send UsageStats monthly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14542] Transliterate rule for all single quote forms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14542 --- Comment #1 from Fridolin SOMERS fridolin.som...@biblibre.com --- Created attachment 41032 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41032action=edit Bug 14542 - Transliterate rule for all single quote forms Single quotes in common language (not in programming) are usually ', but there is also the form known as rsquo; in HTML. See https://fr.wikipedia.org/wiki/Apostrophe_%28typographie%29 This bug proposes to transliterate all forms into a space. Test plan : (I'll use the code rsquo; instead of the unicode character) - Without the patch - Create a record with title : Lrsquo;avion drsquo;argile - Index this record - Search for Lrsquo;avion drsquo;argile = You find the record - Search for L'avion d'argile = You do not find the record - Apply patch - Search for Lrsquo;avion drsquo;argile = You find the record - Search for L'avion d'argile = You find the record - Search for L avion d argile = You find the record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14543] New: Order lines updated that have a tax rate not in gist will have tax rate set to 0!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543 Bug ID: 14543 Summary: Order lines updated that have a tax rate not in gist will have tax rate set to 0! Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org If the tax rate for a given order line has been removed from the system preference gist, that tax rate will show in the pulldown as 0. If a librarian then saves the order line the original tax rate will be overwritten with 0%! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 41033 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41033action=edit Bug 14543 - Order lines updated that have a tax rate not in gist will have tax rate set to 0! If the tax rate for a given order line has been removed from the system preference gist, that tax rate will show in the pulldown as 0. If a librarian then saves the order line the original tax rate will be overwritten with 0%! Test Plan: 1) Find an order line 2) Remove the tax rate set for that order line from the syspref gist 3) Edit the order line 4) Note the tax rate is 0 5) Apply this patch 6) Edit the order line 7) Note the tax rate now displays with a warning -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14542] Transliterate rule for all single quote forms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14542 Fridolin SOMERS fridolin.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
