date:20150902

[Koha-bugs] [Bug 14707] Change UsageStatsCountry and UsageStatsLibraryType from free text to a dropdown list

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707

--- Comment #5 from Julian Maurice  ---
(In reply to Katrin Fischer from comment #4)
> Hm, UsageStatsLibraryType already is a drop down, without this patch for me?

Probably an error in the commit message, the patch only adds en empty choice
for UsageStatsLibraryType

> I am also a bit worried about the country, because how complete of a list
> can we get and where?

Even if we can't be sure we have the exhaustive list of countries, I think it
is still better than having all possible forms of USA counted as different
countries, not to mention spelling mistakes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

--- Comment #117 from Alex Arnaud  ---
Created attachment 42192
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42192=edit
Bug 14544 - Handle database error when creating a shelf with DB admin account

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6508] Enhancement: Additional Information on the Fines & Charges Tab in the Patron Details of Staff Client

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508

Joonas Kylmälä  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=3153

--- Comment #2 from Joonas Kylmälä  ---
Please, see also the bug 3153. Maybe we could refactor the code so that we
could  have the alert

Attention:
 Fees & Charges: Patron has Outstanding fees & charges of 2.00. 

in many places shown easily.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3153] 'maxoutstanding' syspref does not disallow placing holds on staff side

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3153

Joonas Kylmälä  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=6508

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown when created from Patron search

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown when created from Patron search

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #41085|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  
---
Created attachment 42193
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42193=edit
Bug 12525: Prevent adding several patron lists with the same name

If you add patron to a patron list, from the patron search result, a
list is created when you click on "Save".
The list is considered as new each time.

To reproduce:
1/ Launch a patron search
2/ Select 1 patron, and create a new list 'aaa'
3/ Select another patron and click Save again
2 lists are created

Test plan:
1/ Launch a patron search
2/ Select 1 patron, and create a new list 'aaa'
The dropdown list should be populated with this new list, and should be
selected
3/ Select another patron and click Save again
Only 1 list should be created

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14723] Additional delivery notes to messages

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

--- Comment #12 from Jonathan Druart  
---
Created attachment 42194
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42194=edit
Bug 14509: (follow-up) Reject invalid passwords

The members.js was not included in member-password.tt
And it cannot, there are specific code which cannot be used outside of
memberentry.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14763] show patron's age

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||j.kylm...@gmail.com

--- Comment #1 from Joonas Kylmälä  ---
I agree with you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #11 from Joonas Kylmälä  ---
(In reply to Katrin Fischer from comment #10)
> etc. is added correctly (or nothing would work). I can't think of any other
> fields right now that the import would change in the record.

Not change, but add. But I will look into the code soon.. and then we can be
sure.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are referred to an on-site checkout

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are referred to an on-site checkout

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #41444|0   |1
is obsolete||

--- Comment #17 from Jonathan Druart  
---
Created attachment 42195
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42195=edit
Bug 14470: Do not allow renew for on-site checkouts

At the opac, the renew checkbox should not be displayed if it's an
on-site checkout (same on the intranet).

On the way, this patch adds a specific message to the intranet if the
librarian try to renew an on-site checkout.
Indeed before this patch a renew was allowed if the barcode was scanned.

Test plan:
1/ Create an on-site checkout for a patron
2/ Confirm that the checkbox 'renew' is not displayed on the checkout
list tables
3/ At the OPAC, the renew should not be allowed (no checkbox)
4/ Try to check the item out to the same patron, confirm that you get a
specifig message to inform you the renew is not allowed for on-site
checkouts.

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14756] The format you asked for ('') is unrecognized.

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14756

Joonas Kylmälä  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #1 from Joonas Kylmälä  ---
There was a little typo in the master branch, bug fix is already in master.
Fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14435] The table saved_reports is never populated

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #9 from Joonas Kylmälä  ---
(In reply to Katrin Fischer from comment #7)
> 005 is a timestamp of the last change and the first positions of the leader
> that change are the record length - this change being caused by the other
> changes. 
> So I think Koha's current behaviour is correct and nothing needs to be
> changed on import. I think what we could do is catch an invalid itemtype
> code better, so it's easier to locate the problem.

What about the missing subfields/something? I don't know how much they will
have effect on how things work but I'll try to look into the code of the Edit
record feature and see if we should add those kind of things to this import
tool, too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14579] 'You are not logged in' should link to log in page

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579

--- Comment #9 from Jonathan Druart  
---
Liz, it's the same place as when you are logged in. What do you suggest?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #10 from Katrin Fischer  ---
Which missing subfields? 999 information with bilbionumber/biblioitemnumber
etc. is added correctly (or nothing would work). I can't think of any other
fields right now that the import would change in the record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6508] Enhancement: Additional Information on the Fines & Charges Tab in the Patron Details of Staff Client

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508

Joonas Kylmälä  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14497

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14497] Add warning to patron details page if patron's fines exceed noissuescharge

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14497

Joonas Kylmälä  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=6508
 CC||j.kylm...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown when created from Patron search

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

--- Comment #9 from Jonathan Druart  
---
Katrin, thanks for the catch! Weird, I was sure I had tested this one
correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #12 from Joonas Kylmälä  ---
(In reply to Joonas Kylmälä from comment #11)
> (In reply to Katrin Fischer from comment #10)
> > etc. is added correctly (or nothing would work). I can't think of any other
> > fields right now that the import would change in the record.
> 
> Not change, but add. But I will look into the code soon.. and then we can be
> sure.

Ok. authorities.pl and addbiblio.pl does the missing subfield adding as I
understood by reading the code quickly. The code starts at line 590 in
addbiblio.pl. Katrin, do you know by that info if that is something we need?
(if not, why do we have it in addbiblio.pl and authorities.pl?).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14197] Warning raised by TestBuilder

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197

--- Comment #14 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #13)
> Can I get a test plan please?

Katrin:
Run the test from the third patch with and without the two patches.
Compare the results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14702] Refactor GetReserveFee

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702

Joonas Kylmälä  changed:

   What|Removed |Added

  Attachment #42167|0   |1
is obsolete||

--- Comment #38 from Joonas Kylmälä  ---
Created attachment 42191
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42191=edit
Bug 14702: [QA Follow-up] More readable variable names, less queries

The names are much better now :)
Combined the queries for items and issues.
Only check the number of holds when needed.

Test plan:
Verify the changes here by running the unit test again.

Signed-off-by: Jonathan Druart 
Signed-off-by: Joonas Kylmälä 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3153] 'maxoutstanding' syspref does not disallow placing holds on staff side

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3153

Joonas Kylmälä  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |j.kylm...@gmail.com
 CC||j.kylm...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

--- Comment #118 from Jonathan Druart  
---
(In reply to Alex Arnaud from comment #117)
> Created attachment 42192 [details] [review]
> Bug 14544 - Handle database error when creating a shelf with DB admin account

I think this is not useful, the DB admin account should not be used for
anything else than create a first superlibrarian user.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Alex Arnaud  changed:

   What|Removed |Added

 CC||alex.arn...@biblibre.com

--- Comment #119 from Alex Arnaud  ---
(In reply to Jonathan Druart from comment #118)
> I think this is not useful, the DB admin account should not be used for
> anything else than create a first superlibrarian user.
It was the behavior before this patches. And, isn't it better to have a message
that says we can't created a shelf using db admin account instead of a
MySql/DBIX error ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14723] Additional delivery notes to messages

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

--- Comment #7 from Lari Taskula  ---
(In reply to Lari Taskula from comment #3)
> Created attachment 42074 [details] [review]
> Bug 14723: (follow-up) Example of handling custom SMS::Send Driver reports
> 
Patch moved to bug 14767.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14205] Deleting an Item/Record does not remove link to course reserve

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #41390|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 42190
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42190=edit
[PASSED QA] Bug 14205: Deleting an Item/Record does not remove link to course
reserve

A constraint is missing on the course_reserves.ci_id field.
This patch adds it and removes orphan rows.

Test plan:
0/ Don't apply the patch
1/ Login to Staff Site.
2/ Go to Course Reserves
3/ Create Course
4/ Add Reserve
5/ Go to item added (delete item/record)
6/ Refresh Course (see no items attached)
7/ Delete Course
8/ See course still listed in the courses (Not deleted)
9/ Apply the patch and execute the updatedatabase entry.
10/ Delete the Course
Note that the course has correctly been removed.

NOTE: Make sure to set the UseCourseReserves system preference to test.
  Tested before (problem existed) and after (problem solved) update.
  Dropped DB, web installed, and put in dummy data and retested.
  Problem solved.

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14205] Deleting an Item/Record does not remove link to course reserve

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14707] Change UsageStatsCountry and UsageStatsLibraryType from free text to a dropdown list

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707

--- Comment #6 from Katrin Fischer  ---
I have to admit... I don't see a better solution :) Translating all those
countries is a bit of a scary thought tho...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #7 from Barton Chittenden  ---
(In reply to Kyle M Hall from comment #3)
> (In reply to Katrin Fischer from comment #1)
> > Hm, this would need good testing. I think you also need to make sure there
> > is no problem with the way credits work. But it would be good to have!
> 
> Credits have a negative amount and amountoutstanding, so the query would
> definitely not affect credits.

Payments and credits have a negative amount and a *0* amountoutstanding.

As I understand accountlines, the account balance is calculated by summing the
amountoutstanding... so removing the records for credits and payments won't
affect the balance, but I'm concerned about partial payments: consider the case
of partial payments:

+-++---+---+++
| accountlines_id | borrowernumber | amount| amountoutstanding | date  
| description|
+-++---+---+++
|  10 |  1 |  6.00 |  3.00 | 2015-08-03
| test 5 |
|  11 |  1 |  3.00 |  0.00 | 2015-08-03
|  partial payment   |
+-++---+---+++

If we run cleanup_database.pl with a --fees 20, accountlines_id 11 will be
removed (0.00 amountoutstanding, date < 2015-08-13). but accountlines_id 10
won't be removed, because 3.00 amountoutstanding > 0. The borrower's
balance will remain at 3.00, (rather than the original 6.00), but the payment
record won't be there.

There's no way around this -- accountlines doesn't provide a way to determine
what a credit or debit was applied to.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

M. Tompsett  changed:

   What|Removed |Added

  Attachment #39025|0   |1
is obsolete||

--- Comment #66 from M. Tompsett  ---
Created attachment 42236
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42236=edit
bug_11213: Include XSLT processing for searchResults() test

* Added template paths to temp test dir, so XSLT templates can be picked
  up

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #40523|0   |1
is obsolete||

--- Comment #13 from Kyle M Hall  ---
Created attachment 42241
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42241=edit
[SIGNED-OFF] Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal

This patch adds the ability for a logged in user to pay fines and
fees from the OPAC via PayPal.

Test Plan:
 1) Apply this patch
 2) Create a paypal developer account
 3) Create two test accounts, a Personal account and a Business account
 4) Enable PayPal in Sandbox mode via the system preferences.
 5) Enter the business account API credentials into the new system
preferences.
 6) Create a new patron, add some fines/fees
 7) Log in as that patron in the OPAC
 8) Choose to pay via PayPal, log in as the sandbox Personal account
 9) Complete the transaction
10) Note the fee is now paid

Signed-off-by: Carol Corrales 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12885] Search fails with errors when HTML5 Media is enabled and url has plus (+) characters

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12885

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #5 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13972] Include fields from subscription and serial table in serial notification email

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13972

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #10 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

M. Tompsett  changed:

   What|Removed |Added

  Attachment #39027|0   |1
is obsolete||

--- Comment #68 from M. Tompsett  ---
Created attachment 42238
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42238=edit
bug_11213: GetItemsInfo() test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

M. Tompsett  changed:

   What|Removed |Added

  Attachment #39029|0   |1
is obsolete||

--- Comment #70 from M. Tompsett  ---
Created attachment 42240
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42240=edit
bug_11213: Check for $item->{itype} presence to avoid warning

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

M. Tompsett  changed:

   What|Removed |Added

  Attachment #39023|0   |1
is obsolete||

--- Comment #64 from M. Tompsett  ---
Created attachment 42234
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42234=edit
bug_11213: Changed XSLTParse4Display() interface

The list of biblio items is passed on now, instead of GetItemsInfo() being
called. This is because the callers already have the list ready, so the
GetItemsInfo() call is being duplicated unnecessarily.
Search::searchResults() builds items list from XML, and that one is
passed instead.

* XSLT::XSLTParse4Display()
- supply the items list as input param
- removed hidden items list param - hidden should not be in the items
  list
- changed buildKohaItemsNamespace() accordingly

* Items
- removed GetItemsLocationInfo()
- added sort_by input param to GetItemsInfo()
- VirtualShelves::Page::shelfpage() - replaced GetItemsLocationInfo() call
  with GetItemsInfo() call, passing order_by "cn_sort"

* catalogue/detail.pl, opac/opac-detail.pl, shelfpage()
- added items list to the XSLTParse4Display() call

* Search::searchResults()
- include all available info when building items lists
- added combined items list (available, on loan, other) to the
  XSLTParse4Display() call

To test:
This change is a noop, so following screens need to be checked against
any changes:
* Intranet:
- catalogue/search.pl (results)
- catalogue/detail.pl
- virtualshelves/shelves.pl
* Opac
- opac-search.pl (results, hidelostitems syspref on and off)
- opac-detail.pl
- opac-shelves.pl

The display should stay the same before and after patch. The speed
should increase though.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

M. Tompsett  changed:

   What|Removed |Added

  Attachment #39028|0   |1
is obsolete||

--- Comment #69 from M. Tompsett  ---
Created attachment 42239
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42239=edit
bug_11213: Added XSLTParse4Display() to Items test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

M. Tompsett  changed:

   What|Removed |Added

  Attachment #39026|0   |1
is obsolete||

--- Comment #67 from M. Tompsett  ---
Created attachment 42237
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42237=edit
bug_11213: C4::VirtualShelves::Page::shelf_contents()

* Extracted shelf items processing from shelfpage() into a separate sub
  shelf_contents() in order to be able to test it
* Added tests for shelf_contents() with XSLT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

M. Tompsett  changed:

   What|Removed |Added

  Attachment #39024|0   |1
is obsolete||

--- Comment #65 from M. Tompsett  ---
Created attachment 42235
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42235=edit
bug_11213: whitespace correction

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |vfernan...@keep.pt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13943] Cancelling the deletion process of an item deletes item anyway

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #18 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11247] Fix calls of TransformHtmlToXml

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #22 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks guys!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12965] can create an item type that already exists

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #6 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

--- Comment #71 from M. Tompsett  ---
(In reply to Marcel de Rooy from comment #63)
> If you submit what you applied here, we probably tackled it..

Hope this helps. I left the status as is, since you were the one to change it
last.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12824] Create a general purpose koha-config script?

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12824

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493

Vitor Fernandes  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14702] Refactor GetReserveFee

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702

Fiona Borthwick  changed:

   What|Removed |Added

 CC||fiona.borthwick@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14601] Cardnumber should not be required for patron import

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14601

--- Comment #7 from Danielle Elder  ---
(In reply to Jonathan Druart from comment #6)
> CCing Stéphane,
> I would like to get your opinion on this point.
> Do you have the same problem when you migrate/import patrons to Koha?

This is a real problem as the library wants to update several times a semester.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #12 from Barton Chittenden  ---
Created attachment 42246
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42246=edit
[SIGNED-OFF] Make purge_zero_balance_fees() delete fees with NULL balance.

Also, add notes to perldocs and usage that payments and
credits are not linked to fines and may be deleted
independently of the associated fine.

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to be visible

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

--- Comment #2 from Jesse Weaver  ---
Created attachment 42254
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42254=edit
Bug 13757 - Make patron attributes editable in the OPAC (1/2)

This patch adds an opac_editable property of borrower attribute types
that can be set in the interface.

Test plan:
  1. Repeat the following with a new and existing borrower attribute
 type:
  2. Verify that "Editable in OPAC" can only be checked if "Display in
 OPAC" is checked.
  3. Verify that this new property is correctly saved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

--- Comment #4 from Mason James  ---
Created attachment 42255
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42255=edit
pic: create range of holidays

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

--- Comment #3 from Mason James  ---
(In reply to Joonas Kylmälä from comment #2)
> (In reply to Mason James from comment #1)
> >1/ add a bunch of single_holidays to your test koha, (my table has 400 
> >holiday >rows)
> 
> Could you give some example table? It would be easier to test.

hmm, yes i could, but...

 you can quickly create a range of special/unique holidays in a few clicks
... from '2014-01-01' to '2016-01-01', would give you 730 holidays for testing

i'll attach a pic

> 
> >2/ add a loong circ rule for an itemtype (my rule has 140 days)
> 
> Do you mean loan period?

oops yes, thats what i mean :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14579] 'You are not logged in' should link to log in page

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579

Liz Rea  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14773

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14773] New: Move help link back out of the dropdown menu

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14773

Bug ID: 14773
   Summary: Move help link back out of the dropdown menu
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: l...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

14579 added some things to the login menu, but also moved the help link into
the dropdown which is an undesirable change. We shouldn't hide the help links
for the intranet, it should always be one click to get there. Right now it
takes two.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

--- Comment #5 from Mason James  ---
(In reply to Mason James from comment #3)
> (In reply to Joonas Kylmälä from comment #2)
> > (In reply to Mason James from comment #1)
> > >1/ add a bunch of single_holidays to your test koha, (my table has 400 
> > >holiday >rows)
> > 
> > Could you give some example table? It would be easier to test.
> 
> hmm, yes i could, but...
> 
>  you can quickly create a range of special/unique holidays in a few clicks
> ... from '2014-01-01' to '2016-01-01', would give you 730 holidays for
> testing
> 
> i'll attach a pic

mysql> select count(*)  from special_holidays where title = 'aaa' ;
+--+
| count(*) |
+--+
|  614 |
+--+
1 row in set (0.00 sec)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14678] Update Koha language codes to ISO 639-2 spec

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14678

--- Comment #2 from Irma Birchall  ---
http://library.fka.com.au/cgi-bin/koha/opac-search.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14766] Complete cataloguing plugin unimarc_field_4XX

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14766

Chris Cormack  changed:

   What|Removed |Added

  Attachment #42149|0   |1
is obsolete||

--- Comment #3 from Chris Cormack  ---
Created attachment 42263
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42263=edit
Bug 14766: Complete cataloguing plugin unimarc_field_4XX

Add subfields l, n and o for better UNIMARC compliance

Signed-off-by: Chris Cormack 

Note: I just did a code audit here, as I don't know enough about
UNIMARC to know if the 4XX fields should have these subfields.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14766] Complete cataloguing plugin unimarc_field_4XX

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14766

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14621] Messaging preferences table needs to be sorted

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621

Chris Cormack  changed:

   What|Removed |Added

  Attachment #41494|0   |1
is obsolete||

--- Comment #2 from Chris Cormack  ---
Created attachment 42266
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42266=edit
Bug 14621 - Messaging preferences table needs to be sorted

I have been working with messaging preferences and I noticed a weird issue in
Firefox on Ubuntu.

On messaging preferences page, the table is unsorted and the content in rows
are generated randomly
on every page refresh. When you select/deselect checkboxes and refresh the page
(without posting the changes),
Firefox will remember your choices. Now the issue is that when the table is
unsorted and the rows keep
changing on page refresh, Firefox has trouble remembering your choices. This
makes it appear as if the
checkboxes are magically changing values on each page refresh.

Here is a patch that prevents this problem by sorting the messaging settings.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14621] Messaging preferences table needs to be sorted

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #104 from Robin Sheat  ---
(In reply to Peter Zhao from comment #103)
> After I changed "uri_escape" to "uri_escape_utf8", ES can index and Opac can
> search Chinese in MARC21 structure.
> 
> But it does not work in UNIMARC structure. It shows messy code.

The code paths between MARC21 and UNIMARC shouldn't differ in ways that would
make a difference here. The only place where it comes up is determining that
XXXy goes into "author" or whatever.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Chris Cormack  changed:

   What|Removed |Added

  Attachment #41012|0   |1
is obsolete||

--- Comment #24 from Chris Cormack  ---
Created attachment 42259
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42259=edit
Bug 10067 - decreaseLoanHighHolds messes with specify due date

To test:

1. On a branch up to date with master: apply the patch.

2. Try to check out items both with and without holds.
(The decreaseLoanHighHolds function should be configured and kick in when
testing an item.

3. Expected results are:
The due date date field should be cleared after checkout if "Remember for
session"
is not selected. If it is selected then the chosen date should stay in the
field even
if the warning about reduced loan time for an item with too many holds is
displayed.
Also the correct due dates are shown in the table after a checkout.

Known limitation: Does not work too well when jumping between different parts
of the system as it relies on the values sent to the circulation.pl script.

Sponsored-by: Halland County Library

Refactored to both fix specific issue where date is changed
and still have the old behaviour with date kept intact.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7634] Permanent Location (shelving location) is NULL when Import MARC records tool is used

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

Chris Cormack  changed:

   What|Removed |Added

  Attachment #4|0   |1
is obsolete||

--- Comment #6 from Chris Cormack  ---
Created attachment 42260
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42260=edit
Bug 7634: Make the tests pass

This patch just fixed a master bug, if your database already has some
items.homebranch set to CPL

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7634] Permanent Location (shelving location) is NULL when Import MARC records tool is used

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

Chris Cormack  changed:

   What|Removed |Added

  Attachment #42224|0   |1
is obsolete||

--- Comment #8 from Chris Cormack  ---
Created attachment 42262
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42262=edit
Bug 7634: Prevent permanent_location to be set to NULL if not defined

The permanent_location is correctly filled when an item is added from
the cataloguing module (routine set_item_default_location from
cataloguing/additem.pl).
But when records are imported, this filled is not managed. It's only on
editing (_do_column_fixes_for_mod called from ModItem).

This patch set the permanent_location item fields to the location value for all
items created, even the imported ones.

Test plan:
0/ Do not apply this patch
1/ Import a record with items using the "Stage MARC for import" tool
2/ Check the values for the permanent_location in the items table.
They are set to NULL
3/ Apply this patch
4/ Repeat 2 and confirm that now the permanent_location values are set
to the location values.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7634] Permanent Location (shelving location) is NULL when Import MARC records tool is used

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

Chris Cormack  changed:

   What|Removed |Added

  Attachment #42223|0   |1
is obsolete||

--- Comment #7 from Chris Cormack  ---
Created attachment 42261
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42261=edit
\# Attachment to Bug 7634 - Permanent Location (shelving location) is NULL when
Import MARC records tool is used

Bug 7634: Add tests

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7634] Permanent Location (shelving location) is NULL when Import MARC records tool is used

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14774] New: Task Scheduler not working on Ubuntu/Apache2.4

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14774

Bug ID: 14774
   Summary: Task Scheduler not working on Ubuntu/Apache2.4
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Task Scheduler
  Assignee: gmcha...@gmail.com
  Reporter: l...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

The task scheduler uses At to schedule reports to be run later. It's doing
something weird in Ubuntu 14, Apache 2.4.

Scheduling a task on Debian/Apache 2.2 results in the job being added, and it
showing up in the web page. This doesn't happen on Ubuntu/Apache 2.4, it
returns a "Failed to add job."

It looks like Koha is asking atq for the list of current jobs (through
Schedule::At) and it's not getting a list back when run on Ubuntu/2.4. This all
works just fine in Debian/2.2.

in /var/spool/cron/atjobs we can see where jobs are added:

Failing job "Failed to add job", Ubuntu, Apache 2.4:
-- 1 daemon daemon 2.9K Sep  2 15:19 a0004a016e87ae

Successful job displays in the web page, Debian, Apache 2.2
-rwx-- 1 library-koha daemon 2.8K Sep  2 16:15 a00014016f1f52

When we ask for the euid/gid of the user when trying to add these failed jobs,
it seems like it should be OK:

uid: 1005, euid: 1005

Which corresponds to the uid given in /etc/passwd:
library-koha:x:1005:1005

As far as I can tell, those daemon:daemon no permissions jobs aren't actually
run - how could they, they have no executable permissions.

Pretty sure this bug isn't in Koha proper (the scheduler actually works just
fine in Debian/2.2), but some interaction or security thing in Ubuntu/Apache
2.4. It might be nice to figure out why it happens, so we can end run the
problem (or decide to scrap the At reliant scheduler, which is probably a
"should do" anyway).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

--- Comment #18 from Mason James  ---
sorry, i missed some questions here...

(In reply to Kyle M Hall from comment #8)
> Pardon my being late to reply to this, but could this be solved with a a
> screen message regex?
> 
> 

^ no that wont work, the glitchy '(1)' string is created within the Overdrive
app, and external to Koha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14472] Wrong ISSN search index in record matching rules

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14472] Wrong ISSN search index in record matching rules

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472

Chris Cormack  changed:

   What|Removed |Added

  Attachment #40840|0   |1
is obsolete||

--- Comment #10 from Chris Cormack  ---
Created attachment 42256
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42256=edit
Bug 14472 - Wrong ISSN search index in record matching rules

To Test
-
 1) Apply the patch
 2) Export some MARC bibliographic records from Koha
 3) Import those same MARC bibliographic records using the
"ISSN(022$a)" record matching rule.
 4) The incoming records should match perfectly
 5) Check the mysql tables (marc_matchers, matchpoints,
matcher_matchpoints, matchpoint_components,
matchpoint_component_norms) to make sure the values were
inserted as expected.
For new Koha installation
 1) create the koha database
 2) Go to the staff client page, and do a "fresh" install making
sure to select lots of optional marc 21 matching rules so
the .../marc21/optional/marc21_default_matching_rules.sql
gets triggered.
 3) Check the mysql tables (marc_matchers, matchpoints,
matcher_matchpoints, matchpoint_components,
matchpoint_component_norms) to make sure the values were
inserted as expected.

Bug 14472 - Added Atomic Update to fix wrong issn search index

- Fix comments

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14678] Update Koha language codes to ISO 639-2 spec

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14678

James  changed:

   What|Removed |Added

 CC||jb.austral...@gmail.com

--- Comment #1 from James  ---
Not all ISO 639.2 Language Codes are recognised by Koha, causing many languages
to not be searchable using the language filter.
FKA Children's Services in Melbourne, Australia provided multilingual resources
and currently can't search for over a third of the languages in their
collection.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #105 from Peter Zhao  ---
(In reply to Robin Sheat from comment #104)
> (In reply to Peter Zhao from comment #103)
> > After I changed "uri_escape" to "uri_escape_utf8", ES can index and Opac can
> > search Chinese in MARC21 structure.
> > 
> > But it does not work in UNIMARC structure. It shows messy code.
> 
> The code paths between MARC21 and UNIMARC shouldn't differ in ways that
> would make a difference here. The only place where it comes up is
> determining that XXXy goes into "author" or whatever.

The following are 3 records, Chinese words show messy code, English words show
correct, but they cannot search through Opac.

koha@koha:~$ curl -XGET 'http://localhost:9200/koha_biblios/_search?pretty=1' 
{
  "took" : 3,
  "timed_out" : false,
  "_shards" : {
"total" : 5,
"successful" : 5,
"failed" : 0
  },
  "hits" : {
"total" : 3,
"max_score" : 1.0,
"hits" : [ {
  "_index" : "koha_biblios",
  "_type" : "data",
  "_id" : "1",
  "_score" : 1.0,
  "_source":{"pubdate":"   
","subject":[["åºç£æ"],["åºç£æ"],["ç¥å¦"]],"author__facet":[["èµµçº¢å"]],"_id":"1","author":[["èµµçº¢å"]],"subject__facet":[["åºç£æ"],["åºç£æ"],["ç¥å¦"]],"record":[["LDR",null,null,"_","00261nam
 22001213 
4500"],["001",null,null,"_","1"],["005",null,null,"_","20150903102757.0"],["090","
"," ","a","1"],["100"," "," ","a","20150903du||y0chiy50 
ea"],["200"," ","
","a","åºç£æææ³å²","c","Peter","f","èµµçº¢å"],["600"," ","
","a","åºç£æ"],["601"," "," ","a","ç¥å¦"],["942"," ","
","c","BK"],["999"," ","
","c","1","d","1"]],"ta":"u","title":[["åºç£æææ³å²"],["Peter"]],"onloan":"0","Local-number":[["1"]]}
}, {
  "_index" : "koha_biblios",
  "_type" : "data",
  "_id" : "2",
  "_score" : 1.0,
  "_source":{"pubdate":"   
","subject":[["åºç£æ"],["åºç£æ"],["ç¥å¦"]],"author__facet":[["peter"]],"_id":"2","author":[["peter"]],"subject__facet":[["åºç£æ"],["åºç£æ"],["ç¥å¦"]],"record":[["LDR",null,null,"_","00257nam
 22001213 
4500"],["001",null,null,"_","2"],["005",null,null,"_","20150903105155.0"],["090","
"," ","a","2"],["100"," "," ","a","20150903du||y0chiy50 
ea"],["200"," "," ","a","åºç£æææ³å²","c","Peter","f","peter"],["600","
"," ","a","åºç£æ"],["601"," "," ","a","ç¥å¦"],["942"," ","
","c","BK"],["999"," ","
","c","2","d","2"]],"ta":"u","title":[["åºç£æææ³å²"],["Peter"]],"onloan":"0","Local-number":[["2"]]}
}, {
  "_index" : "koha_biblios",
  "_type" : "data",
  "_id" : "3",
  "_score" : 1.0,
  "_source":{"pubdate":"   
","subject":[["History"],["History"],["Christianity"]],"author__facet":[["Peter"]],"_id":"3","author":[["Peter"]],"subject__facet":[["History"],["History"],["Christianity"]],"record":[["LDR",null,null,"_","00259nam
 22001213 
4500"],["001",null,null,"_","3"],["005",null,null,"_","20150903125354.0"],["090","
"," ","a","3"],["100"," "," ","a","20150903du||y0frey50 
ba"],["200"," "," ","a","History of Christianity","f","Peter"],["600"," ","
","a","History"],["601"," "," ","a","Christianity"],["942"," ","
","c","BK"],["999"," "," ","c","3","d","3"]],"ta":"u","title":[["History of
Christianity"]],"onloan":"0","Local-number":[["3"]]}
} ]
  }
}
koha@koha:~$

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown when created from Patron search

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

Chris Cormack  changed:

   What|Removed |Added

  Attachment #42193|0   |1
is obsolete||

--- Comment #13 from Chris Cormack  ---
Created attachment 42258
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42258=edit
Bug 12525: Prevent adding several patron lists with the same name

If you add patron to a patron list, from the patron search result, a
list is created when you click on "Save".
The list is considered as new each time.

To reproduce:
1/ Launch a patron search
2/ Select 1 patron, and create a new list 'aaa'
3/ Select another patron and click Save again
2 lists are created

Test plan:
1/ Launch a patron search
2/ Select 1 patron, and create a new list 'aaa'
The dropdown list should be populated with this new list, and should be
selected
3/ Select another patron and click Save again
Only 1 list should be created

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown when created from Patron search

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

Chris Cormack  changed:

   What|Removed |Added

  Attachment #41084|0   |1
is obsolete||

--- Comment #12 from Chris Cormack  ---
Created attachment 42257
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42257=edit
Bug 12525: FIX patron lists dropdown is empty

On the patrons home page, the dropdown list is not populated.

Test plan:
1/ Go on the patrons home page (members/members-home.pl)
2/ Launch a search
3/ The dropdown list close to "Add selected patrons to" should contain
all your patron lists

NOTE: Initially tested with both which created lists.
  git reset --hard origin/master
  And then dropdown list was missing them.
  Applied just this one, and they were listed.

Signed-off-by: Mark Tompsett 
Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown when created from Patron search

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #103 from Peter Zhao  ---
(In reply to Peter Zhao from comment #98)
> ES Opac cannot support Chinese language? I try to search Chinese word in
> http://elasticsearch.koha.catalystdemo.net.nz/ and my ES, they also show
> "Software error".
> 
> Software error:
> 
> Can't escape \x{57FA}, try uri_escape_utf8() instead at
> /opt/kohaclones/elasticsearch/Koha/SearchEngine/Elasticsearch/QueryBuilder.
> pm line 217.
> 
> For help, please send mail to the webmaster ([no address given]), giving
> this error message and the time and date of the error. 
> 
> Software error:
> 
> Can't escape \x{57FA}, try uri_escape_utf8() instead at
> /home/koha/kohaes/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 217.
> 
> For help, please send mail to the webmaster (webmaster@koha), giving this
> error message and the time and date of the error.

After I changed "uri_escape" to "uri_escape_utf8", ES can index and Opac can
search Chinese in MARC21 structure.

But it does not work in UNIMARC structure. It shows messy code.

koha@koha:~$ curl -XGET 'http://localhost:9200/koha_biblios/_search?pretty=1' 
{
  "took" : 132,
  "timed_out" : false,
  "_shards" : {
"total" : 5,
"successful" : 5,
"failed" : 0
  },
  "hits" : {
"total" : 2,
"max_score" : 1.0,
"hits" : [ {
  "_index" : "koha_biblios",
  "_type" : "data",
  "_id" : "1",
  "_score" : 1.0,
  "_source":{"pubdate":"   
","subject":[["åºç£æ"],["åºç£æ"],["ç¥å¦"]],"author__facet":[["èµµçº¢å"]],"_id":"1","author":[["èµµçº¢å"]],"subject__facet":[["åºç£æ"],["åºç£æ"],["ç¥å¦"]],"record":[["LDR",null,null,"_","00261nam
 22001213 
4500"],["001",null,null,"_","1"],["005",null,null,"_","20150903102757.0"],["090","
"," ","a","1"],["100"," "," ","a","20150903du||y0chiy50 
ea"],["200"," ","
","a","åºç£æææ³å²","c","Peter","f","èµµçº¢å"],["600"," ","
","a","åºç£æ"],["601"," "," ","a","ç¥å¦"],["942"," ","
","c","BK"],["999"," ","
","c","1","d","1"]],"ta":"u","title":[["åºç£æææ³å²"],["Peter"]],"onloan":"0","Local-number":[["1"]]}
}, {
  "_index" : "koha_biblios",
  "_type" : "data",
  "_id" : "2",
  "_score" : 1.0,
  "_source":{"pubdate":"   
","subject":[["åºç£æ"],["åºç£æ"],["ç¥å¦"]],"author__facet":[["peter"]],"_id":"2","author":[["peter"]],"subject__facet":[["åºç£æ"],["åºç£æ"],["ç¥å¦"]],"record":[["LDR",null,null,"_","00257nam
 22001213 
4500"],["001",null,null,"_","2"],["005",null,null,"_","20150903105155.0"],["090","
"," ","a","2"],["100"," "," ","a","20150903du||y0chiy50 
ea"],["200"," "," ","a","åºç£æææ³å²","c","Peter","f","peter"],["600","
"," ","a","åºç£æ"],["601"," "," ","a","ç¥å¦"],["942"," ","
","c","BK"],["999"," ","
","c","2","d","2"]],"ta":"u","title":[["åºç£æææ³å²"],["Peter"]],"onloan":"0","Local-number":[["2"]]}
} ]
  }
}
koha@koha:~$

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651

Chris Cormack  changed:

   What|Removed |Added

  Attachment #42084|0   |1
is obsolete||

--- Comment #7 from Chris Cormack  ---
Created attachment 42265
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42265=edit
Bug 14651: Koha::Item->effective_itemtype fallback to bib-level

In some situations (bad migrations, old bugs that introduced bad data,
people having bib-level itypes for ages and switching to item level...)
the user ends with undex itype values for items.

The current code, if the user has item_level-itype set, just returns
undef. It should fallback to bib-level. In order to avoid hiding the problem
a warning is raised.

To test:
- Run the regression tets:
  $ prove t/db_dependent/Items.t
=> FAIL: tests fail.
- Apply the patch
- Run the tests again
=> SUCCESS: The tests now pass.
- Sign off :-D

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651

Chris Cormack  changed:

   What|Removed |Added

  Attachment #42083|0   |1
is obsolete||

--- Comment #6 from Chris Cormack  ---
Created attachment 42264
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42264=edit
Bug 14651: (regression test) fallback to bib-level if itype is undef

Koha::Item->effective_itemtype should fallback to biblio-level itemtype
even if item-level item types are set, in the case the item has no itemtype
set (bad migration, bad old code).

To test:
- Run
  $ prove t/db_dependent/Items.t
=> FAIL: Koha::Item->effective_itemtype doesn't work properly

Edit: Added a test for a warning when falling back as per QA request
and because it made a lot of sense :-D

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 444] Manual Credits does not support authorised values (Manual invoices do)

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=444

Irma Birchall  changed:

   What|Removed |Added

  Change sponsored?|--- |Seeking developer
 CC||i...@calyx.net.au

--- Comment #2 from Irma Birchall  ---
Hi Paul and others, 

Now that Manual Credit is available with two options of Credit Type : Credit or
Forgiven, I wonder if the support of Authorised Values is likely to be useful
for some libraries. 

It is a missing improvement but would it ever be used?

If you think that the answer is "rarely" should this bug/enhancement be closed?

Cheers, 
Irma

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

James  changed:

   What|Removed |Added

 CC||jb.austral...@gmail.com

--- Comment #6 from James  ---
Problem in testing, when trying to create holidays using patch the date format
is being read incorrectly resulting in the following message for a holiday
range ending on 26th November:

Software error:

The 'month' parameter ("26") to DateTime::new did not pass the 'an integer
between 1 and 12' callback
 at /usr/lib/perl5/DateTime.pm line 199
DateTime::new(undef, 'year', 2015, 'month', 26, 'day', 11) called at
/home/koha/src/tools/newHolidays.pl line 67

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

techservs...@gmail.com changed:

   What|Removed |Added

 CC||techservs...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #10 from Barton Chittenden  ---
Created attachment 42244
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42244=edit
[SIGNED-OFF] Add unit tests for purge_zero_balance_fees()

The function C4::Accounts::purge_zero_balance_fees() should delete rows
in accountlines where amountoutstanding is 0 and accountlines.date is
less than the current date minus '$days', i.e a number of days passed
to the function. Tests were added to prove the following:

* accountlines.amountoutstanding is 0, and date is set to CURRENT_DATE.
  The accountlines row should not be deleted. This is merely a sanity check,
  because difference between today's date and the fee date cannot be
  greater than $days.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding = 0
* accountlines.amountoutstanding is 0, and date is set to $days - 1
  days ago. The accountlines row should not be deleted.
* accountlines.amountoutstanding is 0, and date is set to $days
  days ago.  the accountlines row should not be deleted, because
  the difference must be *greater* than $days.
* accountlines.amountoutstanding is 0, and date is set to $days + 1
  days ago. The accountlines row *will* be deleted in this case.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding > 0.
  (3 tests). The accountlines row will never be deleted, because
  amountoutstanding is not 0.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding < 0.
  (3 testes) This tests credits. Again, the accountlines row will never
  be deleted, because amountoutstanding is not 0.

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #11 from Barton Chittenden  ---
Created attachment 42245
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42245=edit
[SIGNED-OFF] Add option --fees to /misc/cronjobs/cleanup_database.pl

This will call C4::Accounts::purge_zero_balance_fees to remove all rows
from accountlines which have 0 balance, and are more than DAYS old.

Test plan:

  Run: t/db_dependent/Accounts.t

If all unit tests pass, the --fees option to /misc/cronjobs/cleanup_database.pl
should act as documented, because it is a straight pass-through to
C4::Accounts::purge_zero_balance_fees().

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

   What|Removed |Added

  Attachment #41086|0   |1
is obsolete||
  Attachment #41087|0   |1
is obsolete||
  Attachment #41088|0   |1
is obsolete||
  Attachment #42242|0   |1
is obsolete||

--- Comment #9 from Barton Chittenden  ---
Created attachment 42243
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42243=edit
[SIGNED-OFF] Add function purge_zero_balance_fees to C4/Accounts.pm

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #8 from Barton Chittenden  ---
Created attachment 42242
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42242=edit
Make purge_zero_balance_fees() delete fees with NULL balance.

Also, add notes to perldocs and usage that payments and
credits are not linked to fines and may be deleted
independently of the associated fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

   What|Removed |Added

 CC||nkee...@washoecounty.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14601] Cardnumber should not be required for patron import

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14601

--- Comment #8 from Danielle Elder  ---
Katrin I read the bugs mentioned about missing cardnumber or empty string and
that would not be the case here. That patrons have cardnumbers already, we just
don't want to overwrite the existing cardnumber when importing/overwriting
based on a unique attribute (university ID) and want to leave out the
cardnumber column.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

--- Comment #4 from Jesse Weaver  ---
Created attachment 42253
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42253=edit
Bug 14607: (QA followup) Fix typo in shelfbrowser.inc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

Jesse Weaver  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13775] software error when choosing authority via plugin

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775

--- Comment #6 from Katrin Fischer  ---
Hm, sounds good to me!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14733] Prevent a record from having holds with duplicate priorities

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14733

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||ch...@bigballofwax.co.nz

--- Comment #4 from Chris Cormack  ---
This works, but it does have the side effect that in the staff interface where
it shows the priority when placing a reserve.

It will say Priority 1 for example

Then you save it, and now its priority 2 ... I think this will prompt bug
reports from Librarians. Do we care about that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14579] 'You are not logged in' should link to log in page

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579

--- Comment #10 from Liz Rea  ---
I'll make a different bug :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14717] Adding a new patron can end up with 0000-00-00 as the debarred date

2015-09-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

--- Comment #2 from Chris Cormack  ---
Ohh look an easily testable patch that fixes a major bug .. just waiting for
Global bug squash day :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 184 matches

Mail list logo