[Koha-bugs] [Bug 13995] Proper Exception handling

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Blocks||14698


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698
[Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a
database
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Depends on||13995


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995
[Bug 13995] Proper Exception handling
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14539] Introduction to castToObject(), aka. make a Koha::Object from various input types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Blocks||14698


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698
[Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a
database
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Depends on||14539


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539
[Bug 14539] Introduction to castToObject(), aka. make a Koha::Object from
various input types
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14012] Koha::FTP, a happy FTP-library to supercharge FTP operations.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14012

Olli-Antti Kivilahti  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |olli-antti.kivila...@jns.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12146] Add new ISO code column to currency sample files

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146
Bug 12146 depends on bug 9593, which changed state.

Bug 9593 Summary: Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

Koha Team Lyon 3  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #79 from Koha Team Lyon 3  ---
Sorry to be very late, I missed your question in comment 75.
The isocode had to furnished in currencies table in order the whole thing to
work whenever the prices string includes the isocode form.
If you are sure that all your prices will only use the symbol form, it's ok but
I doubt it could be always true. So I had made it required when entering data
in table currencies.
It could be left optionnal, but at least 2 things would have to be added :
1) Resetting an isocode column in the currencies table : now, you have to click
the edit button to be aware of the existence of an isocode parameter, I think
this column must appear anyway.
2) Indicating clearly in the legend that the isocode data is required for
prices string that include it.

Olivier Crouzet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

--- Comment #74 from Srdjan Jankovic  ---
Created attachment 42425
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42425=edit
Bug 11213: Fix mixing Koha::Database and C4::Context->dbh in test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Comment on attachment 42424
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42424
Bug 14377: This development will show 'Suppressed in OPAC' if the 942$n is set
to 1.

Hi Winona,

can you please use a class instead of an id for the result lists as the element
can show up there repeatedly?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #42398|0   |1
is obsolete||

--- Comment #8 from Olli-Antti Kivilahti  ---
Created attachment 42426
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42426=edit
Bug 14698 - AtomicUpdater - Keeps track of which updates have been applied to a
database

Fixed a missing PerlDependency.

TEST PLAN:

1. Run "perl installer/data/mysql/atomicupdate.pl --help"
2. Read the code.
3. git bz apply some bugs which introduce atomicupdates, or cook your own
4. Deploy the atomicupdates using the atomicupdate.pl-script.
5. Repeat steps 3-4 to your heart's content.
6+. Understand the code and come up with improvement ideas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Julian Maurice  changed:

   What|Removed |Added

  Attachment #41763|0   |1
is obsolete||

--- Comment #51 from Julian Maurice  ---
Created attachment 42428
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42428=edit
Bug 7957: Add unit tests for new subroutines

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Julian Maurice  changed:

   What|Removed |Added

  Attachment #41762|0   |1
is obsolete||

--- Comment #50 from Julian Maurice  ---
Created attachment 42427
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42427=edit
Bug 7957: Routing lists enhancements

Rebased on master
Call to AddReserve updated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Julian Maurice  changed:

   What|Removed |Added

  Attachment #41764|0   |1
is obsolete||

--- Comment #52 from Julian Maurice  ---
Created attachment 42429
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42429=edit
Bug 7957: Redirect after creating a new routing list

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #75 from Srdjan Jankovic  ---
I believe it is very wrong to mix KOha::Database and C4::Context->dbh based
tests. Those should be separated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #80 from Katrin Fischer  ---
I think it would be better to discuss any changes on a new bug report - as this
is already in released versions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906

Lari Taskula  changed:

   What|Removed |Added

  Attachment #42108|0   |1
is obsolete||

--- Comment #17 from Lari Taskula  ---
Created attachment 42430
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42430=edit
Bug 13906 - TestObjectFactoreis squashables

Fixed File::Fu::File version from PerlDependencies, 0.08 => 0.0.8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

--- Comment #76 from M. Tompsett  ---
I'm wondering if perhaps it should be something more like:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334#c0

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13805] Installer does not work under Plack

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #36706|0   |1
is obsolete||

--- Comment #11 from Tomás Cohen Arazi  ---
Created attachment 42431
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42431=edit
[SIGNED OFF] Bug 13805: Disable syspref cache - Plack

When going to the installer (without the DB structure), you have to log
twice before starting the installation.

Test plan:
0/ Create a new database and fill the database entry in the koha conf
with its name
1/ Go on the mainpage, you should be redirected to the installer
2/ Try to log in
Without this patch, you will get the login form again.
With this patch, you can start the installation

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13805] Installer does not work under Plack

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14721] OAI-PMH must return error when no results

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14721

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Tomás Cohen Arazi  ---
Patch pushed to master.

Goood job Frido!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14766] Complete cataloguing plugin unimarc_field_4XX

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14766

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #8 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Paul!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14760] Disabled courses display in the course reserves list for items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #5 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #16 from Tomás Cohen Arazi  ---
Patches pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14536] PageObject-pattern base implementation

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #42433|0   |1
is obsolete||

--- Comment #19 from Olli-Antti Kivilahti  ---
Created attachment 42435
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42435=edit
Bug 14536 - PageObject squashable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377

--- Comment #4 from Winona Salesky  ---
Created attachment 42436
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42436=edit
Bug 14377: This development will show 'Suppressed in OPAC' if the 942$n is set
to 1. Changed id="suppressed_opac" to class="suppressed_opac".

Test Plan:
1) Apply this patch
2) Ensure you are using the default XSLT setting for the staff view.
3) Find or create a record with MARC tags 942$n=1
4) Check for “Suppressed in OPAC” at the top of the results div and at the top
of the full record display.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #42432|0   |1
is obsolete||

--- Comment #20 from Olli-Antti Kivilahti  ---
Created attachment 42434
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42434=edit
Bug 14540 - Followup regression test for bad login

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14683] Unable to clear SMS number

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #11 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Joonas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14621] Messaging preferences table needs to be sorted

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #5 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Lari! And congratulations for your commit!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14791] New: Automatically attempt to resend failed notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Bug ID: 14791
   Summary: Automatically attempt to resend failed notices
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: la...@student.uef.fi
QA Contact: testo...@bugs.koha-community.org

Sometimes notices keep failing due to problems in network and they should be
resent. Last week in my local library we experienced some network trouble and
plenty of messages went into failed status. This can also be somewhat risky by
manual SQL queries in production environment. 

Bug 12426 introduces a subroutine C4::Letters::ResendMessage($message_id) for
resending failed messages.

Problem is that if we run this kind of feature as cronjob, we can end up in an
infinite loop of sending the same messages over and over again and they will
never be sent because of missing/invalid to_address or smsalertnumber. However,
Bug 14590 focuses on setting valid messaging preferences for all users. With
the feature presented in Bug 14590 we can assume that all notifications will
have proper messaging preferences. 

If we do not want to rely on Bug 14590:

Another option would be to track messages that we already attempted to resend.
We could try to resend each failed message for lets say 5 times each time
increasing the time between last attempt. Once the message has been attempted
to send 5 times, we will stop our attempts to resend it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14778] Get rid of DBIx::Connector

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14354] Only superlibrarian should see edit links for other branches' items in staff detail

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14354

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14526] MoveReserve should look at future holds too

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #19 from Tomás Cohen Arazi  ---
Patches pusehd to master.

Thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown when created from Patron search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #16 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14343] Links to results pages don't work in Receive Shipment list

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14343

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #10 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Lyon3 Team!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540

--- Comment #19 from Olli-Antti Kivilahti  ---
Created attachment 42432
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42432=edit
Bug 14540 - Followup regression test for bad login

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14536] PageObject-pattern base implementation

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #42136|0   |1
is obsolete||

--- Comment #18 from Olli-Antti Kivilahti  ---
Created attachment 42433
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42433=edit
Bug 14536 - PageObject squashable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14098] Regression in Marc Modification Templates

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #29 from Tomás Cohen Arazi  ---
Patches pushed to master.

Good job Jonathan!!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14779] reviewswaiting.pl paging is not working

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14779

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #4 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Blou!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14472] Wrong ISSN search index in record matching rules

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14472

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #14 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Amit!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14717] Prevent 0000-00-00 dates in patron data

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #42343|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14717] Prevent 0000-00-00 dates in patron data

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
  Attachment #42342|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14717] Prevent 0000-00-00 dates in patron data

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #42344|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #10 from Tomás Cohen Arazi  ---
Patches pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of a MARC Record

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #13 from Tomás Cohen Arazi  ---
I see problems with this patch:

- It forgets to add to queryparser.yml
- It adds to the QueryParser test code, but the numbers look weird.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||tomasco...@gmail.com

--- Comment #21 from Tomás Cohen Arazi  ---
Barton, there is no need to touch record.abs (not blocker) but you are missing
the queryparser.yaml file in your patchset.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14649] fund names not displayed in budget planning

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #15 from Tomás Cohen Arazi  ---
Patches pushed to master.

Good catch Jonathan and Frido!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14602] Fix failing t/Creators.t test, when using koha-shell

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #12 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Mason!

Note: I didn't reproduce the problem, but I agree with the change and it
doesn't break tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14726] Title not showing up on checkout summary

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14726

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Blou!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are referred to an on-site checkout

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #21 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14702] Refactor GetReserveFee

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #39 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10904] Limit patron update request management by branch

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply

--- Comment #32 from Tomás Cohen Arazi  ---
Could you please rebase and fix the small conflict ASAP?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13585] HEA - Cronjob Setup

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c
   |y.org   |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13585] HEA - Cronjob Setup

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |julian.f...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13585] HEA - Cronjob Setup

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #12 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11273] Barcode generation hbyymmincr (AutoBarcode) in acquisitions is broken

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11273

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #16 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14717] Prevent 0000-00-00 dates in patron data

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #12 from Tomás Cohen Arazi  ---
Patches pushed to master.

Good catch Chris!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Severity|normal  |enhancement
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Eivin Giske Skaaren  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #28 from Eivin Giske Skaaren  ---
I think the readability is not better when it is very inconsistent but I have
restored the original inconsistencies :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #81 from Tomás Cohen Arazi  ---
Patches pushed to master.

Good job Bernardo!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #50 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #42437|0   |1
is obsolete||

--- Comment #27 from Eivin Giske Skaaren  ---
Created attachment 42438
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42438=edit
Bug 10067 - decreaseLoanHighHolds messes with specify due date

To test:

1. On a branch up to date with master: apply the patch.

2. Try to check out items both with and without holds.
(The decreaseLoanHighHolds function should be configured and kick in when
testing an item.

3. Expected results are:
The due date date field should be cleared after checkout if "Remember for
session"
is not selected. If it is selected then the chosen date should stay in the
field even
if the warning about reduced loan time for an item with too many holds is
displayed.
Also the correct due dates are shown in the table after a checkout.

Known limitation: Does not work too well when jumping between different parts
of the system as it relies on the values sent to the circulation.pl script.

Sponsored-by: Halland County Library

Refactored to both fix specific issue where date is changed
and still have the old behaviour with date kept intact.

Rebase
Remove code whitespace cleanup

Remove one more code whitespace cleanup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14778] Get rid of DBIx::Connector

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com

--- Comment #11 from Tomás Cohen Arazi  ---
Jonathan. Everything looks good to me. Can we mark it "Needs signoff"? I added
Galen and Kyle to the CC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #42259|0   |1
is obsolete||

--- Comment #26 from Eivin Giske Skaaren  ---
Created attachment 42437
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42437=edit
Bug 10067 - decreaseLoanHighHolds messes with specify due date

To test:

1. On a branch up to date with master: apply the patch.

2. Try to check out items both with and without holds.
(The decreaseLoanHighHolds function should be configured and kick in when
testing an item.

3. Expected results are:
The due date date field should be cleared after checkout if "Remember for
session"
is not selected. If it is selected then the chosen date should stay in the
field even
if the warning about reduced loan time for an item with too many holds is
displayed.
Also the correct due dates are shown in the table after a checkout.

Known limitation: Does not work too well when jumping between different parts
of the system as it relies on the values sent to the circulation.pl script.

Sponsored-by: Halland County Library

Refactored to both fix specific issue where date is changed
and still have the old behaviour with date kept intact.

Rebase
Remove code whitespace cleanup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are referred to an on-site checkout

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470

--- Comment #22 from bondiurbano  ---
Thanks to all!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

--- Comment #77 from Srdjan Jankovic  ---
(In reply to M. Tompsett from comment #76)
> I'm wondering if perhaps it should be something more like:
> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334#c0

In general I second the idea. I would have done it in a slightly different way
(global $schema and only one txn_begin), but that's not important. Would that
guarantee safe mixing with modules that use Koha::Database?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not functional

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

--- Comment #11 from Marc Véron  ---
(In reply to bondiurbano from comment #10)
> Created attachment 42444 [details]
> Selection links are missing

Thanks for testing, bondiurbano.

I suppose you wanted to create pateron cards, not labels?

This problem is already described in: 
Bug 14123 - Patroncard: Patron search for batch no longer has Select / Select
All / Add selected
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14123

See attachment 14123: 
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38773

However, our bug 14781 is about creating labels, not patron cards:
Tools > Labels home > Manage label

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14123] Patroncard: Patron search for batch no longer has Select / Select All / Add selected

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14123

Marc Véron  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14744

--- Comment #6 from Marc Véron  ---
(In reply to Shane Sammons from comment #4)
(...)
> Another thing I wanted to add, as it might be related to this bug, is when
> we do edit batch and tried adding anyone with an apostrophe (like O'Leary)
> in the name would not add at all. 
(...)
For the apostrophe (quote) problem, see Bug 14744 as well, it could be related.
(it's about picking a patron from a datatable).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14744] Cannot select guarantor when quote in one of the fields

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744

Marc Véron  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14123

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #8 from bondiurbano  ---
Created attachment 42445
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42445=edit
Selection links are missing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|Medium patch|Large patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #16 from David Cook  ---
Created attachment 42446
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42446=edit
Bug 10662 - Build OAI-PMH Harvesting Client

This patch set adds an OAI-PMH harvesting client to Koha.

It provides a user interface (UI) for defining external
servers from which to harvest records using the OAI-PMH
protocol.

After it downloads records, it checks the harvest database
to see if it needs to add a new record, update an
existing record, or delete a record in Koha.

_TEST PLAN_

1) Apply all patches
2) Run updatedatabase.pl (to apply the atomic update)

3) Go to Administration > OAI-PMH servers
4) Click "New OAI-PMH server target"
5) At a minimum, include a valid "Base URL" and a valid "Metadata prefix".
6) Click "Test HTTP and OAI-PMH parameters"
7) If successful, continue with this plan. If unsuccessful, address
the warning messages displayed in red before testing the parameters
again.

8) At this point, you might want to choose a preferred granularity.
All OAI-PMH servers must support -MM-DD according to the spec,
but in practice this isn't always the case, so you may need to choose
a more particular granularity (note that this support isn't tested
using the "Test" button).
9) You may also want to choose a "From" and "Until" range, at least
for the purposes of testing, so that you don't accidentally try
downloading thousands or millions of records. (You may also
want to download by "Set".)

10) You must set the "Active" parameter to "Active" from "Inactive"
for the harvester to work on this server target.
11) Optionally, you may provide a path to a XSLT to transform
the incoming data. There is a parameter called "identifier"
which is passed to the XSLT engine. This contains the unique
OAI-PMH identifier for a record. You may wish to add this to the
MARC, especially for the sake of provenance. (You may also
want to strip 952, 942, and 999 fields, as well as $9 subfields
from incoming records. You may also try the magic "default" keyword
here which uses a XSLT I've already written and linked in the
backend.)

12) Choose the MARC framework you would like to use (although
Default is fine as well).

13) Optionally, you may wish to include a "Original system field".
At this time, this has no real purpose. However, in the future,
it may be used for linking downloaded holdings records with
their original parent record. (e.g. the 004 of a holdings record
would link to the 001 of the bibliographic record). This field
uses the format of 001 or 999$c with the dollar sign as a subfield
delimiter.

14) Click Save
15) You will now see a table containing your entry; click "View".
16) All the numbers on the following screen should be 0.

--

17) Set your environmental variables for KOHA_CONF and PERL5LIB
18) Run "perl /misc/cronjobs/oai/oai_harvester.pl -d -v" to download
your records (NOTE: This downloader will run as long as it needs to,
so try to only download a few records. Ctrl+C will stop the harvest
if it gets out of control.)
19) Revisit the web app as per step #15
20) It should now say "Harvested records waiting to be imported: X"
with X being higher than 0.
21) Run "perl /misc/cronjobs/oai/oai_harvester.pl -i -v" to import
these records into Koha.
22) The terminal output should indicate the result of the import.
This should also be reflected by the webapp as per step #15
(e.g. "Koha records created from harvested records: X").

--

Now, there are a few different scenarios to try:

If you control the OAI-PMH repository, try editing a record you've
downloaded, and try downloading records again (it might be necessary to
change your "From" entry as this should be auto-updated after each
harvest), and seeing if your Koha record is updated. If your repository
also supports deleted records, try deleting a record that you've
already imported into Koha. Koha should get a deletion notice
and delete the record from Koha (unless it has items attached).

If you delete a record from Koha, but that record still exists
upstream, you'll still download updates for that record,
but an error will be generated when trying to import into Koha.
Each record in this "error" state will be recorded in the "View"
section of the UI as "Harvested records in an error state: X".
(In the future, I might make it so that the record gets re-added,
or add more configuration options to control this behaviour.)

If you want to reset the respository harvest (ie delete all
your existing harvested records and re-harvest a repository),
click "Reset repository harvest" in the "View" screen of
the OAI-PMH server target. If errors are encountered while
deleting an existing harvest, it should display hyperlinks
to the problem records for manual intervention.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list

[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #18 from David Cook  ---
Created attachment 42448
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42448=edit
Bug 10662 - DBIx::Class ResultSets for Testing

This patch adds the DBIx::Class ResultSets for testing. These are
necessary in order for the main OAI-PMH harvester patch to work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook  changed:

   What|Removed |Added

  Attachment #42446|0   |1
is obsolete||

--- Comment #17 from David Cook  ---
Created attachment 42447
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42447=edit
Bug 10662 - Build OAI-PMH Harvesting Client

This patch set adds an OAI-PMH harvesting client to Koha.

It provides a user interface (UI) for defining external
servers from which to harvest records using the OAI-PMH
protocol.

After it downloads records, it checks the harvest database
to see if it needs to add a new record, update an
existing record, or delete a record in Koha.

_TEST PLAN_

1) Apply all patches
2) Run updatedatabase.pl (to apply the atomic update)

3) Go to Administration > OAI-PMH servers
4) Click "New OAI-PMH server target"
5) At a minimum, include a valid "Base URL" and a valid "Metadata prefix".
6) Click "Test HTTP and OAI-PMH parameters"
7) If successful, continue with this plan. If unsuccessful, address
the warning messages displayed in red before testing the parameters
again.

8) At this point, you might want to choose a preferred granularity.
All OAI-PMH servers must support -MM-DD according to the spec,
but in practice this isn't always the case, so you may need to choose
a more particular granularity (note that this support isn't tested
using the "Test" button).
9) You may also want to choose a "From" and "Until" range, at least
for the purposes of testing, so that you don't accidentally try
downloading thousands or millions of records. (You may also
want to download by "Set".)

10) You must set the "Active" parameter to "Active" from "Inactive"
for the harvester to work on this server target.
11) Optionally, you may provide a path to a XSLT to transform
the incoming data. There is a parameter called "identifier"
which is passed to the XSLT engine. This contains the unique
OAI-PMH identifier for a record. You may wish to add this to the
MARC, especially for the sake of provenance. (You may also
want to strip 952, 942, and 999 fields, as well as $9 subfields
from incoming records. You may also try the magic "default" keyword
here which uses a XSLT I've already written and linked in the
backend.)

12) Choose the MARC framework you would like to use (although
Default is fine as well).

13) Optionally, you may wish to include a "Original system field".
At this time, this has no real purpose. However, in the future,
it may be used for linking downloaded holdings records with
their original parent record. (e.g. the 004 of a holdings record
would link to the 001 of the bibliographic record). This field
uses the format of 001 or 999$c with the dollar sign as a subfield
delimiter.

14) Click Save
15) You will now see a table containing your entry; click "View".
16) All the numbers on the following screen should be 0.

--

17) Set your environmental variables for KOHA_CONF and PERL5LIB
18) Run "perl /misc/cronjobs/oai/oai_harvester.pl -d -v" to download
your records (NOTE: This downloader will run as long as it needs to,
so try to only download a few records. Ctrl+C will stop the harvest
if it gets out of control.)
19) Revisit the web app as per step #15
20) It should now say "Harvested records waiting to be imported: X"
with X being higher than 0.
21) Run "perl /misc/cronjobs/oai/oai_harvester.pl -i -v" to import
these records into Koha.
22) The terminal output should indicate the result of the import.
This should also be reflected by the webapp as per step #15
(e.g. "Koha records created from harvested records: X").

--

Now, there are a few different scenarios to try:

If you control the OAI-PMH repository, try editing a record you've
downloaded, and try downloading records again (it might be necessary to
change your "From" entry as this should be auto-updated after each
harvest), and seeing if your Koha record is updated. If your repository
also supports deleted records, try deleting a record that you've
already imported into Koha. Koha should get a deletion notice
and delete the record from Koha (unless it has items attached).

If you delete a record from Koha, but that record still exists
upstream, you'll still download updates for that record,
but an error will be generated when trying to import into Koha.
Each record in this "error" state will be recorded in the "View"
section of the UI as "Harvested records in an error state: X".
(In the future, I might make it so that the record gets re-added,
or add more configuration options to control this behaviour.)

If you want to reset the respository harvest (ie delete all
your existing harvested records and re-harvest a repository),
click "Reset repository harvest" in the "View" screen of
the OAI-PMH server target. If errors are 

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

bondiurbano  changed:

   What|Removed |Added

 CC||cost...@gmail.com

--- Comment #7 from bondiurbano  ---
Also "Select", "Select all", "Select none" checkbox and links are missing. See
attached image.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook  changed:

   What|Removed |Added

   Priority|P1 - high   |P3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not functional

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

bondiurbano  changed:

   What|Removed |Added

 CC||cost...@gmail.com

--- Comment #10 from bondiurbano  ---
Created attachment 42444
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42444=edit
Selection links are missing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #19 from David Cook  ---
Hi all!

I've finally got something up for testing, so please everyone take some time to
test it out. So much has changed since I first started working on this back in
2013, but hopefully it should provide all the functionality that you need.

I'm sure that the user interface could use more attention, so I'd love to
receive feedback on that.

I'd also love to hear back about how the feature works. The key component is
the "oai_harvester.pl" cronjob, which will be set up by a system administrator.
I don't think there's much that a web user can do to affect that, although I
have seen other bugs talking about giving web users control over scheduling
tasks. I think web users controlling scheduling would be outside the scope of
this bug.

Unlike the "Staged MARC Management", there is currently no way of un-importing
and re-importing. You can only "reset repository harvest", which will delete
all currently harvested records and allow you to schedule a new re-harvest.
While I originally was going to leverage the "Staged MARC Management" code, I
decided that giving web users control over selectively un-importing and
re-importing batches of records harvested via OAI-PMH could be really
problematic. That is, you might un-import a batch which deletes 10 records,
import a new batch which contains those 10 records, then try to re-import an
earlier batch of those 10 records. Even if the (optional) record matching rules
were set up perfectly, your Koha records would be wrong; they'd be for an older
version of the upstream record. I decided that once a record was added to Koha
- all further updates and deletions should be automatic. And if a record was
deleted from Koha (other than by "resetting the harvest"), then it could not be
re-added; it will instead generate an error (since you can't currently
"undelete" a bibliographic record or re-add it with the same biblionumber).
However, I'm happy to discuss options for handling records that have been
deleted from Koha. There is code that checks if the record has been deleted in
Koha, so it would be trivial to add a new record with a new biblionumber,
although I'd have to update some other code which expects a unique OAI-PMH
identifier to be tied to only 1 Koha biblionumber whereas in this case it would
have 2 or more.

In fact, I'm happy to discuss every part of this code. 

Some of you might be interested in improving performance. At the moment, the
"oai_harvester.pl" runs synchronously, which means that first all the records
need to be downloaded into the database, and then all the records need to be
processed and imported into Koha. For initial imports or large imports, this
takes hours. However, I've recently gained a lot of experience using POE (Perl
Object Environment). Using POE, I could presumably write an asynchronous
program which could import records as they're received, rather than waiting for
the entire harvest to complete. Unfortunately, POE was removed from Koha's
dependencies in the past year or so, but I don't think it would be problematic
to add it to the dependencies once again. 

--

Despite me posting these patches, the work isn't done yet. 

A keen observer will note that there is a lack of consistency in naming. I
sometimes say "oai_client", "oai_server", "oai_target", "oai repository". It's
not always exactly clear what I mean, even though I know what I mean. I want to
be clear in differentiating this feature from Koha's OAI-PMH server as well. I
would be receptive to comments about preferred terminology in both the backend
and the web app.

Additionally, I also need to do the following:

1) Add unit tests
2) Revise the embedded POD in the code
3) Add help pages (and possibly hints/tips in the templates for web users)

I'm going to hold off on these 3 tasks for the moment until we get further into
the testing. Otherwise they'll just need to be revised again after more code
iterations. (That said, it would have been smart to have written unit tests
from the beginning as I built up the code. Alas. Next time.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Katrin Fischer  changed:

   What|Removed |Added

Summary|Make patron attributes  |Make patron attributes
   |editable in the opac if set |editable in the opac if set
   |to be visible   |to 'editable in OPAC'
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14785] Allow On Shelf Holds is not Available in 3.20

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14785

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---
Hi Jerwyn - it's not been removed, but improved :) Instead of one global
setting it's now part of the circulation conditions as a new options there that
you can set differently for each rule.

The visibility of the "place hold" button in the result list has been affected,
but will hopefully be restored at some point (see bug 5786)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds system preferences to the Circulation Matrix

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||14792


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14792
[Bug 14792] Fix visibility check for 'place holds' link in OPAC result list
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14792] New: Fix visibility check for 'place holds' link in OPAC result list

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14792

Bug ID: 14792
   Summary: Fix visibility check for 'place holds' link in OPAC
result list
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, srd...@catalyst.net.nz,
tomasco...@gmail.com

The 'place hold' link shows, even when no items are holdable. 
This is a side effect of the changes from 5786 and should be fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14792] Fix visibility check for 'place holds' link in OPAC result list

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14792

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||5786


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786
[Bug 5786] Move AllowOnShelfHolds and OpacItemHolds system preferences to the
Circulation Matrix
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de,
   ||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10005] inventory checks items in without warning

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005

--- Comment #6 from Katrin Fischer  ---
I've added a missing .
The patch would be a little nicer, if there was a nice message for 'already on
loan' - but this works, as it no longer checks the item in.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10005] inventory checks items in without warning

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #41435|0   |1
is obsolete||

--- Comment #7 from Katrin Fischer  ---
Created attachment 42443
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42443=edit
[PASSED QA] Bug 10005: Inventory - Add an option to not check in items

The inventory tools automatically check in items, this patch adds it as
an option.

Test plan:
1/ Check an item out, fill a file with its barcode, and use this file in
the inventory tools.
2/ Check the new checkbox and confirm that the item is not checked in
3/ Repeat again and don't check it, the behavior should be the same as before
this patch.

Signed-off-by: Jason Robb 
Signed-off-by: Katrin Fischer 
Added a missing .
Patch works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10005] inventory checks items in without warning

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||katrin.fisc...@bsz-bw.de

--- Comment #17 from Katrin Fischer  ---
I have some problems with the conflict in the test files - can you please take
a look? If I just fix the number of tests, I get some output like this:

bumblebee:~/kohaclone (14155-ilsdi|AM 1/1) $ perl t/db_dependent/Reserves.t 
1..71
ok 1 - use C4::Reserves;
"my" variable $title masks earlier declaration in same scope at
t/db_dependent/Reserves.t line 85.
"my" variable $title masks earlier declaration in same scope at
t/db_dependent/Reserves.t line 98.
"my" variable $bibitemnum masks earlier declaration in same scope at
t/db_dependent/Reserves.t line 98.
...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14597] Reverting a batch where a record overlaid is now deleted record will fail

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14597

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13548] "High Holds" does not behave correctly when decreaseLoanHighHoldsValue is set to 0.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13548

Eivin Giske Skaaren  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |ei...@sysmystic.com
   |ity.org |
 CC||ei...@sysmystic.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2310] Omnibus: Delete grayed out w/out explanation

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8723] holds don't transfer when moving items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723

--- Comment #18 from Katrin Fischer  ---
I confirmed the linktracker update works correctly, to test:
- Activate TrackClicks
- Catalog an URL each in 856 and in 952$u
- Open each link in the OPAC
- Move item
- Check linktracker table: item link will have moved, record level link did not

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8723] holds don't transfer when moving items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723

--- Comment #21 from Katrin Fischer  ---
Created attachment 42441
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42441=edit
[PASSED QA] Bug 8723: Update hold_fill_targets, tmp_holdsqueue and linktracker
tables

Same as previous patch for 3 other tables.

Test plan:
Same as before but the hold should exist to the 3 tables before the
move.

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8723] holds don't transfer when moving items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8723] holds don't transfer when moving items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723

--- Comment #20 from Katrin Fischer  ---
Created attachment 42440
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42440=edit
[PASSED QA] Bug 8723: Update the reserves table for item-level holds

If an item is moved from a biblio to another, the holds should be
updated too.

See discussion on the bug report for more information.

Test plan:
1/ Place a item-level hold on biblio1
2/ Move the item to biblio2
3/ Confirm that the hold still exists and point to the biblio2

This patch should not change the existing behavior for bib-level holds.

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8723] holds don't transfer when moving items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #41078|0   |1
is obsolete||
  Attachment #41079|0   |1
is obsolete||
  Attachment #41080|0   |1
is obsolete||

--- Comment #19 from Katrin Fischer  ---
Created attachment 42439
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42439=edit
[PASSED QA] Bug 8723: Cover the existing behavior

This patch cover the MoveItemFromBiblio subroutine

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12146] Add new ISO code column to currency sample files

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146
Bug 12146 depends on bug 9593, which changed state.

Bug 9593 Summary: Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13548] "High Holds" does not behave correctly when decreaseLoanHighHoldsValue is set to 0.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13548

--- Comment #1 from Eivin Giske Skaaren  ---
Created attachment 42442
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42442=edit
Bug 13548: "High Holds" does not behave correctly when
decreaseLoanHighHoldsValue is set to 0.

This solves the problem since there was a boolean check that evaluated to false
because of the 0.

To test:

1. Apply patch.
2. Enable decreaseLoanHighHolds and set decreaseLoanHighHoldsValue to 0.
3. Check out an item without holds and see that the behaviour is now correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/