[Koha-bugs] [Bug 14817] Encoding issues in columns.def

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #2 from Josef Moravec  ---
The patch works as expected for me, but there is another place to fix: 

https://github.com/Koha-Community/Koha/blob/master/C4/Reports/Guided.pm#L875

And there is used this routine from Reports::Guided

https://github.com/Koha-Community/Koha/blob/master/tools/inventory.pl#L37
https://github.com/Koha-Community/Koha/blob/master/tools/inventory.pl#L374

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

--- Comment #91 from Jonathan Druart  
---
Created attachment 42578
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42578=edit
Bug 12252: Add tests for EmbedItemsInMarcBiblio

Signed-off-by: Jonathan Druart 

Signed-off-by: Signed-off-by: Gaetan Boisson 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|Small patch |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

--- Comment #94 from Jonathan Druart  
---
Created attachment 42581
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42581=edit
Bug 12252: (follow-up) Include item data only in extended mode

Fix perlcritic error.

Signed-off-by: Signed-off-by: Gaetan Boisson 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

--- Comment #90 from Jonathan Druart  
---
Created attachment 42577
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42577=edit
Bug 12252 - include item data in OAI-PMH ListRecords result

Same in spirit to the other patch, this also includes the item detail in
ListRecords.

Test plan:
* Fetch a URL like:
http://koha/cgi-bin/koha/oai.pl?verb=ListRecords=marcxml
* Verify that there are 952 entries in the returned records where
  appropriate.

Signed-off-by: Frederic Demians 

ListRecords OAI verb returns a list of records including items in 952/995 which
are not hidden based on OpacHiddenItems syspref.

Signed-off-by: Jonathan Druart 

Signed-off-by: Signed-off-by: Gaetan Boisson 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14245] RIS in unimarc flavour is still deficient

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14245

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14245] RIS in unimarc flavour is still deficient

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14245

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #39366|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 42572
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42572=edit
Bug 14245: Problems with RIS export in unimarc

Variable $itype is used an all C4/Ris.pm to switch
between marc falvors, but is local and not passed along
as argument.

As a quick solution, is defined as global

To test:
1) On UNIMARC setup, export a record as RIS,
check that author (and other fields) are displayed
incorrectly

2) Apply the patch

3) Export again, improved results

4) Run t/Ris.t

There are other problems in this script, needs maintenance
(e.g. no Modern::Perl friendly)

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

--- Comment #89 from Jonathan Druart  
---
Created attachment 42576
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42576=edit
Bug 12252 - OAI-PMH items respect OpacHiddenItems

This allows the OAI-PMH service to not provide item information when
there is a rule that would supress it in OpacHiddenItems.

Test plan:
* Find an OAI-PMH URL that shows you some items.
* Add an entry to OpacHiddenItems that would block that.
* Check that it's blocked.

Signed-off-by: Frederic Demians 

Tested, playing with OpacHiddenItems. GetRecord OAI verb returns a record
complying with OpacHiddenItems rules, for example without items from a specific
library.

Signed-off-by: Jonathan Druart 

Signed-off-by: Signed-off-by: Gaetan Boisson 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #42018|0   |1
is obsolete||
  Attachment #42019|0   |1
is obsolete||
  Attachment #42020|0   |1
is obsolete||
  Attachment #42021|0   |1
is obsolete||
  Attachment #42022|0   |1
is obsolete||
  Attachment #42023|0   |1
is obsolete||
  Attachment #42314|0   |1
is obsolete||

--- Comment #88 from Jonathan Druart  
---
Created attachment 42575
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42575=edit
Bug 12252 - OAI-PMH result includes item data

GetRecord for OAI-PMH was pulling the MARCXML directly from the
database. Now it uses GetMarcBiblio and includes the item data with it,
making it more generally useful.

Test plan:
* Run an OAI-PMH query, for example:
http://koha/cgi-bin/koha/oai.pl?verb=GetRecord=KOHA-OAI-TEST:52=marcxml
  to fetch biblionumber 52
* Note that it doesn't include the 952 data
* Apply the patch
* Do the same thing, but this time see that the 952 data is at the
  bottom of the MARCXML.

Note:
* This patch also includes a small tidy-up in C4::Biblios to group
  things semantically a bit better, so I don't spend ages looking for a
  function that was staring me in the face all along again.

Signed-off-by: David Cook 

Works as described. Simple yet useful patch.

Signed-off-by: Jonathan Druart 

Signed-off-by: Frederic Demians 

952/995 item fields are back in response to GetRecord OAI verb.

Signed-off-by: Jonathan Druart 

Signed-off-by: Signed-off-by: Gaetan Boisson 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

--- Comment #92 from Jonathan Druart  
---
Created attachment 42579
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42579=edit
Bug 12252: (qa-follow-up) Remove perlcritic error

Signed-off-by: Signed-off-by: Gaetan Boisson 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #14 from Katrin Fischer  ---
Hm not sure if I understand the browser history problem. Why would a link in
the notices table to resend (with old fashioned reload or Ajax) not work?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252

--- Comment #93 from Jonathan Druart  
---
Created attachment 42580
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42580=edit
Bug 12252 Include item data only in extended mode

Previous patches attached to this bug have been refactored to merge bug
3206 and bug 13568 features. So OAI server must be carrefully tested to
ensure that there is no regression in this area: deleted records and
resumption token.

This last patch fixed the way items are returned. They are returned only
if OAI server operates in extended mode, and specifically for format
having the parameter include_item set to 1 (true). For example this
configuration file set via OAI-PMH:ConfFile syspref will return items:

Signed-off-by: Signed-off-by: Gaetan Boisson 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10128] Encoding problem when Search for an Authority to add to a bib record with non-latin characters the data re filled in form looks bad but the results good

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10128

Josef Moravec  changed:

   What|Removed |Added

 Resolution|--- |MOVED
 CC||josef.mora...@gmail.com
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14831] New: How to link the Koha catalog into our website

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14831

Bug ID: 14831
   Summary: How to link the Koha catalog into our website
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: mr.bnik...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Hi 


SEVERITY :  CRITICAL / URGENT / HIGH PRIORITY

Subject : Linking of the Koha catalog to the public webpage. 


   We have installed KOHA in our LAN and now we want to link the catalog to
the public webpage. So please guide us , how to link the catalogs to our public
webpage where users can see the available information using catalogs but they
shouldn't be able to edit the information.


We will be waiting for the support from you.


Thank you & Regards
Nikhilesh Reddy
9030064642

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14831] How to link the Koha catalog into our website

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14831

mr.bnik...@gmail.com changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14817] Encoding issues in columns.def

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817

--- Comment #4 from Jonathan Druart  
---
Thanks for the catch Josef, I haven't checked this area I thought it called the
same subroutine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14817] Encoding issues in columns.def

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817

--- Comment #3 from Jonathan Druart  
---
Created attachment 42571
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42571=edit
Bug 14817: (follow-up) Fix encoding issues in columns.def

Follow-up for reports.

Test plan:
1/ Use a translated template (fr-FR or ar-Arab)
2/ Go on the report guided page, step 3
3/ The field names should be correctly encoded.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14832] New: Encoding issues when exporting in RIS

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832

Bug ID: 14832
   Summary: Encoding issues when exporting in RIS
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

I have found this issue when testing bug 14245.

To reproduce:
Make sure you have non ASCII chars in the title and the authors.
Export the record in RIS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14245] RIS in unimarc flavour is still deficient

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14245

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14832

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #22 from Jonathan Druart  
---
The script does not accept --fees 0, is it expected?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14778] Get rid of DBIx::Connector

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

--- Comment #15 from Fridolin SOMERS  ---
(In reply to Jonathan Druart from comment #14)
> (In reply to Fridolin SOMERS from comment #13)
> > Great patch, but in this case C4::Context depends on C4::Database and
> > C4::Database depends on C4::Context :(
> > Should we move database handler method to C4::Database ?
> > I know it will change a lot of code but isn't it more logical ?
> 
> Yes of course it is.
> But I would like to get this one into master and then provide a huge change
> to correct all occurrences.

Oki, we are on the same page then.
I'll try it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14832] Encoding issues when exporting in RIS

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Lari Taskula  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #13 from Lari Taskula  ---
(In reply to Katrin Fischer from comment #12)
> I think it could be very useful for a library to be able to resent messages
> that don't have a "failed" status - for example: the library has typoed in
> the email address. In this cases the email is sent, but bounced back to the
> library's email address (email account doesn't exist at this provider etc.)
> and it's up to the library to correct the email address. But the status will
> be sent.
> I have been asked a lot if there is a way to trigger a notice again - which
> is why I filed this bug :)

That's a very good point. For some reason I had been ignoring this :) With the
current patch it is a bit risky, however. As Jonathan mentioned problems with
browser history,

(In reply to Jonathan Druart from comment #9)
> Note that ResendNotice only resends failed messages. This will avoid to
> resend already sent messages (using an url from the browser history for
> instance).

I suggest we change the method of request from GET and make it via AJAX calls
to avoid problems caused by browser history. I have been working on REST API
for Notices and have done all basic operations including resend. It would be
nice to see this feature use the REST API via AJAX calls. Any support for this
idea?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527

--- Comment #26 from Pedro Ferreira  ---
any news how to solve the problem...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14723] Additional delivery notes to messages

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Lari Taskula  changed:

   What|Removed |Added

  Attachment #42553|0   |1
is obsolete||

--- Comment #16 from Lari Taskula  ---
Created attachment 42574
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42574=edit
Bug 14723 - Additional delivery notes to messages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10407] allow MARCXML records to be imported via Koha's GUI

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14829] Wrong shortcuts in module "cataloging"

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14832] Encoding issues when exporting in RIS

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832

--- Comment #3 from Jonathan Druart  
---
Note: I don't get the issue on a MARC21 DB.
But the patch does not seem to break the RIS export for this DB.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14829] Wrong shortcuts in module "cataloging"

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829

--- Comment #1 from Jonathan Druart  
---
Created attachment 42570
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42570=edit
Bug 14829: Fix shortcuts in the cataloging and patron modules

In these 2 modules, the shortcuts alt+q, alt+r and alt+u don't work as
in other modules.
The tab are not "built" in the correct order and the id returned to
select the correct tab is wrong.

Test plan:
Go on the circ home page (circ/circulation-home.pl), the patron home
page (members/members-home.pl) and the cataloging home page
(cataloguing/addbooks.pl).
On these 3 pages, without this patch, the shortcuts select different
tabs.
With this patch, the issue is fixed for all of them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14829] Wrong shortcuts in module "cataloging"

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Patch complexity|--- |Trivial patch
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
Version|3.20|master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14832] Encoding issues when exporting in RIS

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832

--- Comment #2 from Jonathan Druart  
---
Does not seem to have been introduced by bug 11944, this affect 3.18.x also.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11528] TrackClicks feature messes up proxied EBSCO e-books links?

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11528

Charles Quain  changed:

   What|Removed |Added

 CC||c...@interleaf.ie

--- Comment #4 from Charles Quain  ---
EBSCO have given me this temporary link to create test urls:
http://search.ebscohost.com/login.aspx?authtype=uid=koha15=test2015=ehost=e000muk

Click on a thumbnail and go to the full display for the record. Then click on
the "permalink" option at the right of the screen to get an url that you can
put into an 856 tag for testing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11528] TrackClicks feature messes up proxied EBSCO e-books links?

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11528

--- Comment #5 from Katrin Fischer  ---
Could the problem be bug 14441? I think there is a problem with links
containing ampersands (&).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4990] reintegrate overdues email in overdue list

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4990

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14832] Encoding issues when exporting in RIS

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832

--- Comment #1 from Jonathan Druart  
---
Created attachment 42573
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42573=edit
Bug 14832: Fix encoding issues when exporting in RIS

Test plan:
1/ Make sure you have non ASCII chars in the title and the authors.
2/ Export the record in RIS
You should not see any encoding problems.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14597] Reverting a batch where a record overlaid is now deleted record will fail

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14597

Jonathan Druart  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com,
   ||ro...@catalyst.net.nz,
   ||srd...@catalyst.net.nz,
   ||tomasco...@gmail.com

--- Comment #9 from Jonathan Druart  
---
Ccing people involved in the Logger discussion to get their opinions, please
see comments 6-8.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #16 from Jonathan Druart  
---
(In reply to Lari Taskula from comment #13)

> I suggest we change the method of request from GET and make it via AJAX
> calls to avoid problems caused by browser history. I have been working on
> REST API for Notices and have done all basic operations including resend. It
> would be nice to see this feature use the REST API via AJAX calls. Any
> support for this idea?

(In reply to Katrin Fischer from comment #15)
> Mostly asking because the REST API is not there yet - it would be nice if
> this small but great improvement would not be blocked by the bigger
> development.

Exactly what I was going to answer :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #17 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #14)
> Hm not sure if I understand the browser history problem. Why would a link in
> the notices table to resend (with old fashioned reload or Ajax) not work?

Clicking on the resend link, will call
/cgi-bin/koha/script.pl?op=resend_id=42 (or equivalent).
If you don't limit the resend to fail messages, a user could unexpectedly
recall this url, and resend again the message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||julian.maur...@biblibre.com

--- Comment #48 from Jonathan Druart  
---
Julian, could I get your signoff on this one please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #49 from Jonathan Druart  
---
Created attachment 42584
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42584=edit
Bug 14321: QA Fix

Remove QA errors (keys on reference is experimental).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #21 from Jonathan Druart  
---
(In reply to Lari Taskula from comment #19)
> But here we are very optimistic and excited about the REST API. I think it
> is a great opportunity to keep pushing it forward by making features already
> dependant on it. To use this nice feature you would need to use the REST API
> - great way to encourage other people to check it out and learn about it :)

I personally just mark these patches as BLOCKED since the base is not
accepted/validated/etc.
It just makes me think "this work will have to rebase for ages".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14833] New: Bad encoding in table header in sql / guided report

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14833

Bug ID: 14833
   Summary: Bad encoding in table header in sql / guided report
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: gmcha...@gmail.com
  Reporter: josef.mora...@gmail.com
QA Contact: testo...@bugs.koha-community.org

There is bug in running reports. 

1. Create report with some uf8 characters in columns names, for example.

SELECT b.cardnumber AS "Číslo průkazky", b.firstname AS "Křestní jméno",
b.surname AS "Příjmení", bb.author AS "Autor", bb.title AS "Název"
FROM borrowers b JOIN issues i ON b.borrowernumber = i.borrowernumber 
JOIN items it ON i.itemnumber = it.itemnumber
JOIN biblio bb ON bb.biblionumber = it.biblionumber

(It's in Czech, I apologize ;-) )

2. Run the report and you see, that columns names are bad encoded. 

3. Try to download the report, csv and tab file has the same problem, but ODF
file is OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #15 from Katrin Fischer  ---
Mostly asking because the REST API is not there yet - it would be nice if this
small but great improvement would not be blocked by the bigger development.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #50 from Marcel de Rooy  ---
Jonathan: Thanks for looking into this one!

> +sub DESTROY {
> +}
> This is not really useful.
Agreed. Removing it.

> +# **  HELPER ROUTINES / CLASS METHODS
> Should be part of POD.
Right!

> +sub _fh {
> I don't understand the usefulness of this method.
Hm. I am not sure anymore, but this routine may have had some more lines in
development. But it still contains a test if (a) then a->b, so I want to keep
it in order to not repeat this test a few times. Keeps the code more readable
at the calling spots.

> +$self->{files}->{$filename}->{errcode} = 3; #no rootdir
> Please avoid that and use readable error code. "no_rootdir" would be perfect.
I hope that is not a blocker for you :) and prefer to leave it as-is now..

> +$p= $rec->{permanent}? $self->{rootdir}: $self->{tmpdir};
> +$p.= '/';
> +$p.= $rec->{dir}. '/'. $rec->{hashvalue}. '_'. $rec->{filename};
> It would be better to use File::Spec::catfile
OK. Adjusting it.

> +my $i = $dbh->last_insert_id(undef, undef, 'uploaded_files', undef);
> last_insert_id is mysql specific.
> It would have been better to create the Koha::UploadFile[s] based on 
> Koha::Object[s] to avoid and write sql queries.
Could be true, but that is a too large rewrite operation at this moment.
We could do that on a new report at some point in time. Some day we hope to not
have anything mysql specific anymore?

> +sub _lookup {
> +my ( $self, $params ) = @_;
> +my $dbh = C4::Context->dbh;
> +my $sql = qq|
> Variable interpolations should not be allowed in SQL queries.
Which line do you exactly refer to now?
Probably the WHERE id IN ($params->{id}) line later on.
Note that the id variable is only allowed to be of the form 1,2,3,4 by the
regex directly preceding it. If you persist here, I could rebuild it in the
form ?,?,? here and first count the number of id's..

Will continue with your second comment now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #51 from Marcel de Rooy  ---
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload.tt
> I don't really like the structure of this file. You have to jump in the file 
> to know what is next.
> Is it a new proposal for template files?
No, it is not a new proposal or so. This could be a matter of taste, but this
template reads much easier to me than the long blocks of text with horrible
indentation that we already have in Koha. Note that most of us prefer to use
subroutines in code instead of one large block. This is more or less the same.
It may be quite easy to copy the blocks to their corresponding places, but for
me it will not enhance readability.
Since this is just using normal TT directives, it should not be considered imo
in terms of new format, guidelines, etc.
If you still insist, I will remove the blocks.. 

::: tools/upload-file.pl
> +sub upload_pars {
> Maybe a quick comment would be useful here.
Added a small comment.

> ::: tools/upload.pl
> Please execute perltidy on new file.
OK. Will do that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14831] How to link the Koha catalog into our website

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14831

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Owen Leonard  ---
This system is for reporting bugs in Koha, not for support requests.

The first place to go for help is the manual:

http://koha-community.org/documentation/

Support requests can also be made on the Koha mailing list, on IRC, or by
contracting with a support vendor. All these options are linked to here:
http://koha-community.org/support/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #42588|0   |1
is obsolete||

--- Comment #57 from Marcel de Rooy  ---
Created attachment 42590
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42590=edit
Bug 14321: [QA Follow-up] Changes for Upload.pm and upload-file.pl

Based on QA comments, this patch does the following:
[1] Destroy an empty DESTROY.
[2] Promote some comment lines to POD.
[3] Use File::Spec->catfile in sub _full_fname.
[4] Remove variable interpolation from a sql query.
[5] Add a comment in upload-file.pl.

Signed-off-by: Marcel de Rooy 
Run the unit test again, and uploaded a file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14829] Wrong shortcuts in module "cataloging"

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829

Josef Moravec  changed:

   What|Removed |Added

  Attachment #42570|0   |1
is obsolete||

--- Comment #3 from Josef Moravec  ---
Created attachment 42585
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42585=edit
Bug 14829: Fix shortcuts in the cataloging and patron modules

In these 2 modules, the shortcuts alt+q, alt+r and alt+u don't work as
in other modules.
The tab are not "built" in the correct order and the id returned to
select the correct tab is wrong.

Test plan:
Go on the circ home page (circ/circulation-home.pl), the patron home
page (members/members-home.pl) and the cataloging home page
(cataloguing/addbooks.pl).
On these 3 pages, without this patch, the shortcuts select different
tabs.
With this patch, the issue is fixed for all of them.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #15 from Jonathan Druart  
---
Tested on batchMod.pl:

1/ The "required" is before the select.
2/ After selecting a value, the description is truncated (see comment 9).

3/
(In reply to Owen Leonard from comment #9)
> Old: Tab to , type the first letters of the item you're looking for.
> Item is selected.
> 
> New: Tab to combobox, type the word you're looking for. Use arrow key to
> select the item you want.

Still valid.
Maybe something like
http://stackoverflow.com/questions/20989458/select2-open-dropdown-on-focus

4/ Add the new JS plugin to the about page.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #20 from Katrin Fischer  ---
Everyone is very excited - but woudl be good to have at least the base patches
in Koha first.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #46 from Jonathan Druart  
---
Comment on attachment 42559
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42559
Bug 14321: Introduce Koha::Upload

Review of attachment 42559:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14321=42559)
-

::: Koha/Upload.pm
@@ +211,5 @@
> +return @res;
> +}
> +
> +sub DESTROY {
> +}

This is not really useful.

@@ +213,5 @@
> +
> +sub DESTROY {
> +}
> +
> +# **  HELPER ROUTINES / CLASS METHODS 
> **

Should be part of POD.

@@ +260,5 @@
> +$self->{uid} = C4::Context->userenv->{number} if C4::Context->userenv;
> +$self->{public} = $params->{public}? 1: undef;
> +}
> +
> +sub _fh {

I don't understand the usefulness of this method.

@@ +274,5 @@
> +if( $self->{files}->{$filename} &&
> +$self->{files}->{$filename}->{errcode} ) {
> +#skip
> +} elsif( !$self->{temporary} && !$self->{rootdir} ) {
> +$self->{files}->{$filename}->{errcode} = 3; #no rootdir

Please avoid that and use readable error code. "no_rootdir" would be perfect.

@@ +311,5 @@
> +my $p;
> +if( ref $rec ) {
> +$p= $rec->{permanent}? $self->{rootdir}: $self->{tmpdir};
> +$p.= '/';
> +$p.= $rec->{dir}. '/'. $rec->{hashvalue}. '_'. $rec->{filename};

It would be better to use File::Spec::catfile

@@ +351,5 @@
> +$self->{public},
> +$self->{temporary}? 0: 1,
> +);
> +$dbh->do( $sql, undef, @pars );
> +my $i = $dbh->last_insert_id(undef, undef, 'uploaded_files', undef);

last_insert_id is mysql specific.
It would have been better to create the Koha::UploadFile[s] based on
Koha::Object[s] to avoid and write sql queries.

@@ +358,5 @@
> +
> +sub _lookup {
> +my ( $self, $params ) = @_;
> +my $dbh = C4::Context->dbh;
> +my $sql = qq|

Variable interpolations should not be allowed in SQL queries.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||6874


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874
[Bug 6874] Attach files to bibliographic records
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6874] Attach files to bibliographic records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||14321


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321
[Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #23 from Katrin Fischer  ---
Hi Misilo, I think failed will only cover a really small percentage. I think
making it work for all status using a POST could be a little nicer.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #42589|0   |1
is obsolete||

--- Comment #58 from Marcel de Rooy  ---
Created attachment 42591
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42591=edit
Bug 14321: [QA Follow-up] Perltidy upload.pl

Run perltidy -pro=xt/perltidyrc on tools/upload.pl.
No other changes.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #18 from Jonathan Druart  
---
So AJAX call or via POST could solved the issue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14829] Wrong shortcuts in module "cataloging"

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829

Michael Kuhn  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #2 from Michael Kuhn  ---
I applied the patch manually in the files "cataloging-search.inc" and
"patron-search.inc" of directory
"/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/de-DE/includes" and the
patch works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #47 from Jonathan Druart  
---
Comment on attachment 42560
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42560
Bug 14321: Integrate Upload.pm into Koha

Review of attachment 42560:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14321=42560)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload.tt
@@ +1,1 @@
> +[% INCLUDE 'doc-head-open.inc' %]

I don't really like the structure of this file. You have to jump in the file to
know what is next.
Is it a new proposal for template files?

::: tools/upload-file.pl
@@ +82,3 @@
>  }
>  
> +sub upload_pars {

Maybe a quick comment would be useful here.

::: tools/upload.pl
@@ +1,1 @@
> +#!/usr/bin/perl

Please execute perltidy on new file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14245] RIS in unimarc flavour is still deficient

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14245

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #42572|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 42586
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42586=edit
Bug 14245: Problems with RIS export in unimarc

Variable $itype is used an all C4/Ris.pm to switch
between marc falvors, but is local and not passed along
as argument.

As a quick solution, is defined as global

To test:
1) On UNIMARC setup, export a record as RIS,
check that author (and other fields) are displayed
incorrectly

2) Apply the patch

3) Export again, improved results

4) Run t/Ris.t

There are other problems in this script, needs maintenance
(e.g. no Modern::Perl friendly)

Signed-off-by: Victor do Rosário 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #22 from Tom Misilo  ---
Would a possible compromise be, accept as is without using the REST API and
without being able to resend failed messages? With the understanding that a new
bug # be created that enhances this one by using the REST API? That way the
functionality libraries have been looking for more then a year is added.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #56 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #52)
> (In reply to Marcel de Rooy from comment #50)
> > > +sub _lookup {
> > > +my ( $self, $params ) = @_;
> > > +my $dbh = C4::Context->dbh;
> > > +my $sql = qq|
> > > Variable interpolations should not be allowed in SQL queries.
> > Which line do you exactly refer to now?
> 
> It's general:
>   my $query = "SELECT [...]"
> should be
>   my $query = 'SELECT [...]'
> or
>   my $query = qq|SELECT [...]
> should be
>   my $query = q|SELECT [...]

OK. Clear. Will add that. Note that there were no variables..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #42584|0   |1
is obsolete||

--- Comment #53 from Marcel de Rooy  ---
Created attachment 42587
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42587=edit
Bug 14321: QA Fix

Remove QA errors (keys on reference is experimental).

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #55 from Marcel de Rooy  ---
Created attachment 42589
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42589=edit
Bug 14321: [QA Follow-up] Perltidy upload.pl

Run perltidy -pro=xt/perltidyrc on tools/upload.pl.
No other changes.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #54 from Marcel de Rooy  ---
Created attachment 42588
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42588=edit
Bug 14321: [QA Follow-up] Changes for Upload.pm and upload-file.pl

Based on QA comments, this patch does the following:
[1] Destroy an empty DESTROY.
[2] Promote some comment lines to POD.
[3] Use File::Spec->catfile in sub _full_fname.
[4] Add a comment in upload-file.pl.

Signed-off-by: Marcel de Rooy 
Run the unit test again, and uploaded a file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #19 from Lari Taskula  ---
Katrin,

As Jonathan mentioned, AJAX would work fine but (with current patch) the
following link 

cgi-bin/koha/members/notices.pl?borrowernumber=1=4

would stay in your browser history. Let's imagine we clicked the link and the
message was resent perfectly fine and we want to forget about it. But since
it's in the browser history, a staff member can accidentally get back on this
page by using the address bar, without realizing that this will resend the
message once again.

And yes, I understand your concern - it is very problematic that it would be
blocked by the REST API since it's not there yet. So what would be the point to
use it for such a small feature?

But here we are very optimistic and excited about the REST API. I think it is a
great opportunity to keep pushing it forward by making features already
dependant on it. To use this nice feature you would need to use the REST API -
great way to encourage other people to check it out and learn about it :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14817] Encoding issues in columns.def

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817

Josef Moravec  changed:

   What|Removed |Added

  Attachment #42524|0   |1
is obsolete||

--- Comment #5 from Josef Moravec  ---
Created attachment 42582
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42582=edit
Bug 14817: Fix encoding issues in columns.def

Test plan:
1/ Use a translated template (fr-FR or ar-Arab)
2/ Go on the tools/import_patrons.pl page
3/ The field names in the "default values" block should be correctly
encoded.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14817] Encoding issues in columns.def

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817

Josef Moravec  changed:

   What|Removed |Added

  Attachment #42571|0   |1
is obsolete||

--- Comment #6 from Josef Moravec  ---
Created attachment 42583
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42583=edit
Bug 14817: (follow-up) Fix encoding issues in columns.def

Follow-up for reports.

Test plan:
1/ Use a translated template (fr-FR or ar-Arab)
2/ Go on the report guided page, step 3
3/ The field names should be correctly encoded.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14817] Encoding issues in columns.def

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #52 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #50)
> > +sub _lookup {
> > +my ( $self, $params ) = @_;
> > +my $dbh = C4::Context->dbh;
> > +my $sql = qq|
> > Variable interpolations should not be allowed in SQL queries.
> Which line do you exactly refer to now?

It's general:
  my $query = "SELECT [...]"
should be
  my $query = 'SELECT [...]'
or
  my $query = qq|SELECT [...]
should be
  my $query = q|SELECT [...]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14368] Add discharges history

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14368

Matthias Meusburger  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14782] can't search by username anymore

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14782

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #8 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Katrina and Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14801] Fix Reserves.t

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14801

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #9 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8723] holds don't transfer when moving items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #22 from Tomás Cohen Arazi  ---
Patches pushed to master.

Good job Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14197] Warning raised by TestBuilder

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #17 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13622] Display a datetime without time in a notice

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #24 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Jonathan and Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14640] 'Cancel Hold' check box on check-out confirmation does not cancel the hold when item is checked out.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14640

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #6 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Jonathan and Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14368] Add discharges history

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14368

--- Comment #15 from Matthias Meusburger  ---
Created attachment 42598
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42598=edit
Bug 14368 [Follow-up]: Add filter on borrower when displaying discharges
history on borrower's page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14368] Add discharges history

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14368

--- Comment #13 from Matthias Meusburger  ---
(In reply to Tomás Cohen Arazi from comment #12)

> - There's a bug on the unit test you introduce for lifting the discharge,
> because it should look like:
> 
> ok( ! Koha::Borrower::Discharge::is_discharged({ borrowernumber =>
> $borrowernumber }),
> 'The patron is not discharged after the restriction has been lifted'
> );
> 
> And you will notice it fails :/

Indeed. Misuse of DelDebarment. Fixed in the follow-up.

> 
> - There's a problem with Koha::Borrower::Discharge::discharge (not
> introduced by your patch, but affects the beaviour): it overwrites the
> already defined discharges... so no history! Heh.

Hmm, the sql patch introducing discharge_id in the discharges table and the
following part of the patch should prevent this behavior, shouldn't it ?


-my $discharge = $rs->search({ borrower => $borrowernumber });
+my $discharge = $rs->search({ borrower => $borrowernumber }, { order_by =>
{ -desc => 'needed' }, rows => 1 });

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14805] No idea to disallow the deletion of multiple patron card batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #42522|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14805] No idea to disallow the deletion of multiple patron card batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14813] Encoding issues when editing the help

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14813

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #5 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560

--- Comment #37 from Kyle M Hall  ---
Created attachment 42596
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42596=edit
Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to
Check Out Books - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10005] inventory checks items in without warning

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #8 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14805] No idea to disallow the deletion of multiple patron card batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805

--- Comment #2 from Marc Véron  ---
Created attachment 42592
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42592=edit
[Signed-off] Bug 14805: Allow the user to delete multiple batches

Allows the user to delete multiple patron card batches.

Test plan:

1. Add first some 20 batches
2. Go to the edit page of some X batch by first selecting from the
   batch list the batch you want to edit and then after that by clicking
   edit.
3. Delete one batch by selecting one batch and then clicking delete.
4. Select 0 batches and click delete, notice you cannot delete.
5. Select 0 batches and click edit, notice you cannot edit.
6. Select 2 batches and click edit, notice you cannot edit.
7. Apply patch
8. Check that steps from 2-6 work like they worked before.
   (and add more batches so that you have ~20 of them)
9. Select 2 batches and click delete. Make sure they are deleted.
10. Try to figure out some anomalies this patch might have caused.

Sponsored-by: Vaara-kirjastot

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #28 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13781] Relative's checkouts table is missing one column heading

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
Summary|Relative's checkouts|Relative's checkouts table
   |tableis missing one column  |is missing one column
   |heading |heading

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560

--- Comment #38 from Kyle M Hall  ---
Created attachment 42597
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42597=edit
Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to
Check Out Books - Unit Test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #20004|0   |1
is obsolete||
  Attachment #20005|0   |1
is obsolete||
  Attachment #20006|0   |1
is obsolete||

--- Comment #36 from Kyle M Hall  ---
Created attachment 42595
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42595=edit
Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to
Check Out Books

Add checks in C4::ILS::Patron and C4::ILS::Transaction::Renew to make sure the
patron
is below the noissuescharge system pref for issues and OPACFineNoRenewals for
renewals.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7634] Permanent Location (shelving location) is NULL when Import MARC records tool is used

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #14 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14141] Changing the Library for a notice duplicates the notice instead of updating it

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14368] Add discharges history

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14368

--- Comment #14 from Matthias Meusburger  ---
Created attachment 42593
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42593=edit
Bug 14368 [Follow-up]: Fix tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14597] Reverting a batch where a record overlaid is now deleted record will fail

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14597

--- Comment #10 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #8)
> IMO this is really not a good idea.
> I would prefer to see this logger question moved somewhere else and let this
> patch continues this way without it.
> 
> (Just to say, my logger proposal allowed you to display a "caller", which
> permit to know where we are).

I'm not sure what you mean by that. I may be out of the loop. Yes, we could
dump the caller into the logs, but setting the category allows us to utilize
the strengths of log4perl where we can redirect parts of the log to other
files, set up email alerts, use syslog, log to a db, etc. If we don't specify
our categories well then we can't take advantage of any of the features of
log4perl.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #19 from Kyle M Hall  ---
Created attachment 42594
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42594=edit
Bug 11622 [QA Followup] - Use Modern::Perl and ditch utf8 pragma

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #20 from Kyle M Hall  ---
> 1/ use strict;use warnings; should be replaced with use Modern::Perl;
> 2/ You are using the utf8 pragma but there is no need of it, you don't have
> non-ASCII characters in the file.

I see what you mean. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6756] Patron anonymizing tool reports false success

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6756

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #11 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10904] Limit patron update request management by branch

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10904] Limit patron update request management by branch

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904

--- Comment #34 from Kyle M Hall  ---
Created attachment 42600
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42600=edit
Bug 10904 [QA Followup] - would like to limit patron update request management
by branch

Signed-off-by: Kyle M Hall 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/