[Koha-bugs] [Bug 14100] Generic solution for language overlay
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #24 from Katrin Fischer--- Argh... late evening QA'ing... error: The following untracked working tree files would be overwritten by merge: installer/data/mysql/atomicupdate/Bug_14100-add_table_localization.sql Sorry! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- +100! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place document delivery / article requests in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hallchanged: What|Removed |Added Depends on||13696 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 [Bug 13696] Add support for Font Awesome icons in Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14937] Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937 Marjorie Barry-Vilachanged: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Marc Véronchanged: What|Removed |Added CC||ve...@veron.ch --- Comment #12 from Marc Véron --- Some testing from my part: If I put an additional blank after the 1 in 942n, the record is suppressed in OPAC (with syspref 'OpacSuppression set to 'Hide'), but the message does not show up on the staff detail view. If I then add the normalize-space function to the XSL as described in comment #11 the message appears. If I have use the authorized value YesNo, it does not work. I tweaked the xsl to display the 942nvalue, and it is Yes instead of 1 As Katrin mentioned on IRC this is a problem, because the auhorized values are translated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Kyle M Hallchanged: What|Removed |Added Blocks||14610 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 [Bug 14610] Add ability to place document delivery / article requests in Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #139 from Robin Sheat--- (In reply to Jonathan Druart from comment #123) > You have updated the structure in the elasticsearch_mapping.sql file, so no > need to remove the unique key and add the label field in the last > updatedatabase entry. > Not a big deal anyway :) Oh, yes. That should have been removed. (In reply to Jonathan Druart from comment #125) > I know you are now agreeing completely with Koha::Object[s] and how it has > been implemented. > But I think we need to have an homogeneous code, and all new classes in the > Koha namespace should follow the same directions. > I would please you to have a look at bug 14828 (and the see also ones), > which introduces the Koha::ItemType[s] classes as well and rewrites the > admin/itemtypes.pl script, to see how easy it is to use it. > To avoid future conflicts and don't play to a race against each other we > should agree on this kind of decisions now. Sure, that's fine. Consistency is generally better than reinventing everything. (In reply to Jonathan Druart from comment #135) > In the last patch I suggest to display the facet terms in the same order as > ES build them (i.e. most used first). While I've added this, in general I'm avoiding changing of behaviour too much. We can always remove it later if it's decided we don't want it (and personally, I think it'll be better.) All these patches are added. Thanks Jonathan! FYI, I'm looking into the notforloan stuff at the moment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #140 from Katrin Fischer--- sorting facets by number of use sounds better to me than alphabetic - maybe a good change :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14962] Temp Shelving Location
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #6 from Katrin Fischer--- Maybe this could work like the course reserves? The former location is stored separate from the item data until the item is moved back -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14100] Generic solution for language overlay
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #25 from Jonathan Druart--- (In reply to Katrin Fischer from comment #24) > Argh... late evening QA'ing... > error: The following untracked working tree files would be overwritten by > merge: > installer/data/mysql/atomicupdate/Bug_14100-add_table_localization.sql > Sorry! You need remove the file before applying the patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #14 from Katrin Fischer--- Hm, I think 0/1 as the description is not very friendly for the cataloger and might lead to some confusion. Another suggestion: We could use the mechanism that makes system preferences available in the XSLT. We could create a variable to store the description that matches the authorised value category linked to 942$n for the value 1. And then base the check on that. Does that make sense? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #13 from Marc Véron--- Workaround and/or possible solution: I created an authorized value category ONE_ZERO and gave it 0 / 1 for the values and for all descriptions. Then I linked it with 942 n. Display of suppression message is fine. And it displays 1 or 0 correctly while editing 942 n for records that formerly had YES_NO values. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14100] Generic solution for language overlay
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #26 from Katrin Fischer--- Yep, I missed that my workspace wasn't clean. I will fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #15 from Winona Salesky--- This would work for me. I'm afraid I am still using learning the ins and outs of Koha, and did not realize there were other possible values to 942$n. -Winona (In reply to Katrin Fischer from comment #14) > Hm, I think 0/1 as the description is not very friendly for the cataloger > and might lead to some confusion. Another suggestion: We could use the > mechanism that makes system preferences available in the XSLT. We could > create a variable to store the description that matches the authorised value > category linked to 942$n for the value 1. And then base the check on that. > Does that make sense? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14951] Remove C4::Dates from plugins/*.pl files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14951 Joonas Kylmälächanged: What|Removed |Added Attachment #43096|0 |1 is obsolete|| --- Comment #2 from Joonas Kylmälä --- Created attachment 43100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43100=edit Bug 14951 - Remove C4::Dates from plugins/*.pl files I didn't see any dependencies for the Dates module. Also tested to load the plugins pages This patch removes C4::Dates from: - plugins/plugins-home.pl - plugins/run.pl C4::Dates seem not to be used here, removed. For testing refer to: http://manual.koha-community.org/3.20/en/pluginsystem.html http://manual.koha-community.org/3.20/en/pluginsystem.html Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14951] Remove C4::Dates from plugins/*.pl files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14951 Joonas Kylmälächanged: What|Removed |Added CC||j.kylm...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 Joonas Kylmälächanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 Joonas Kylmälächanged: What|Removed |Added Attachment #43094|0 |1 is obsolete|| --- Comment #2 from Joonas Kylmälä --- Created attachment 43101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43101=edit Bug 14949 - Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl Test plan works, code looks good. Bug to remove C4::Dates from - admin/smart-rules.pl - admin/categorie.pl To test: - Apply patch - Go to Home > Administration > Circulation and fine rules (smart-rules.pl) - Edit or add a rule - Verify that 'Hard due date' displays and saves fine - Go to Home > Administration > Patron categories - Edit or add a category - Verify that 'Until date' displays and saves fine Note: The date picker does not warn about wrong date formats as e.g. while editing patrons, but that is not in the scope of this bug Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14950] Remove C4::Dates from tools/batchMod.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 --- Comment #3 from Marc Véron--- (In reply to Joonas Kylmälä from comment #2) > What is the comment "FIXME: iso dates don't have commas!" about? split ',', > $today_iso doesn't work? Or is the comment about that Koha uses a comma > instead of -? I do not really know what the author of tis comment intended. But the comment now is obsolete because the code changed to get the values to replace , MM and DD -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Joonas Kylmälächanged: What|Removed |Added CC||j.kylm...@gmail.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #34 from Jonathan Druart--- (In reply to Chris Cormack from comment #33) > I agree with Marc that we need to also waen the users to close the browser, > as I can confirm that this fix doesn't work for Firefox What version are you using? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #31 from Jonathan Druart--- (In reply to Jonathan Druart from comment #25) > Comment on attachment 42919 [details] [review] > [PASSED QA] Bug 14522 - Use Koha::Cache for accessing single_holidays() > > Review of attachment 42919 [details] [review]: > - > > It seems we were here at the same time :) > > I have also tried to reproduce the time reduction, without success. > A script I have used is coming... It would have been good to have a script to highlight the time reduction of this caching. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14944] show error in frameworks/cataloging if upload path not set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14944 --- Comment #1 from Marcel de Rooy--- (In reply to Nicole C. Engard from comment #0) > It would be nice if when you were allowing file uploads via marc you were > warned on the frameworks editor that your upload path is not set. Right now > it only warns you in about koha, and most people don't look there. It would > also be helpful if it shows on the cataloging editor. Are you sure? If I upload a file without this entry in koha-conf, I get this warning: Your koha-conf.xml does not contain a valid upload_path. Nice in yellow :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 Jonathan Druartchanged: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 --- Comment #22 from Jonathan Druart--- Created attachment 43104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43104=edit Bug 10020: Remove code related to ethnicity This is a(nother) vestige of Koha (2.2?). This patch removes unused code related to the 'ethnicity'. In detail: There is no way to fill the ethnicity table. There is no way to fill the borrowers.ethnicity and borrowers.ethnotes. BUT if borrowers.ethnicity exists, the value is displayed on members/moremember.pl (and only here). Test plan: Apply this patch and confirm there is no regression on adding/updating/deleting patrons. Note that you don't see the ethnicity value on the moremember.pl page even if a patron has it. Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 Jonathan Druartchanged: What|Removed |Added Attachment #38400|0 |1 is obsolete|| Attachment #38401|0 |1 is obsolete|| --- Comment #21 from Jonathan Druart --- Created attachment 43103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43103=edit Bug 10020: Remove DB table and fields related to ethnicity This patch remove the ethnicity table and the ethnicity and ethnotes fields from the 3 tables: borrowers, deletedborrowers and borrower_modifications IF no data exist. Test plan: 0/ Apply this patch and update the Koha::Schema (misc/devel/update_dbix_class_files.pl). 1/ Make sure the ethnicity has at least 1 entry 2/ Launch the updatedb entry and confirm you get a warning message and the DB structure is not updated. 3/ truncate the ethnicity table and fill ethnicity (or ethnotes) for at least 1 row of the borrowers table. 4/ Launch the updatedb entry and confirm you get a warning message and the DB structure is not updated. 5/ Make sure the ethnicity table is empty as well as the ethniciy and the ethnotes fields of borrowers, deletedborrowers and borrower_modifications 6/ Launch the updatedb entry and confirm you don't get the warning message and the DB structure is updated (ie. table and fields dropped). Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14841] Columns settings on checkouts table have 2 bugs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 Joonas Kylmälächanged: What|Removed |Added Attachment #42635|0 |1 is obsolete|| --- Comment #4 from Joonas Kylmälä --- Created attachment 43102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43102=edit Bug 14841: Columns settings are not taken into account for checkout table / moremember There is a typo member vs members in the template when retrieving the existing settings. So that all columns are displayed, even the ones which are hidden (sort_order, due_date_unformatted, etc.) Test plan: 0/ Does not apply this patch 1/ Go on the columns config page and check some fields not to display by default for Patrons > moremember > issues-table 2/ Go on the patron detail page (with checkouts), click on the "show/hide columns" button (top right of the table). Confirm that the config is not taken into account and that it's ugly (hidden columns are displayed) 3/ Apply this patch 4/ Everything should be fine now :) Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14841] Columns settings on checkouts table have 2 bugs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 Joonas Kylmälächanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14841] Columns settings on checkouts table have 2 bugs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 Joonas Kylmälächanged: What|Removed |Added Attachment #42636|0 |1 is obsolete|| --- Comment #5 from Joonas Kylmälä --- Created attachment 43105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43105=edit Bug 14841: Fine column is not manage by columns settings Bug 9481 added the "Fine" columns to the checkouts table and bug 13492 added the columns settings to these table. They overlapped each others in the bugs queue. Test plan: Confirm that you are able to hide/show the "Fine" columns on both checkouts table. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14950] Remove C4::Dates from tools/batchMod.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 --- Comment #4 from Joonas Kylmälä--- (In reply to Marc Véron from comment #3) > (In reply to Joonas Kylmälä from comment #2) > > What is the comment "FIXME: iso dates don't have commas!" about? split ',', > > $today_iso doesn't work? Or is the comment about that Koha uses a comma > > instead of -? > > I do not really know what the author of tis comment intended. But the > comment now is obsolete because the code changed to get the values to > replace , MM and DD Yes, it's obsolete now. I was reading the git diff in the wrong way and thought that you put the comment there ! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14950] Remove C4::Dates from tools/batchMod.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 Joonas Kylmälächanged: What|Removed |Added CC||j.kylm...@gmail.com --- Comment #2 from Joonas Kylmälä --- What is the comment "FIXME: iso dates don't have commas!" about? split ',', $today_iso doesn't work? Or is the comment about that Koha uses a comma instead of -? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14950] Remove C4::Dates from tools/batchMod.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 Joonas Kylmälächanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14950] Remove C4::Dates from tools/batchMod.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 Joonas Kylmälächanged: What|Removed |Added Attachment #43095|0 |1 is obsolete|| --- Comment #5 from Joonas Kylmälä --- Created attachment 43106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43106=edit Bug 14950 - Remove C4::Dates from tools/batchMod.pl Test plan worked. Code looks good. This patch removes C4::Dates from tools/batchMod.pl To test: - In MARC bibliographic Default framework, define a default value for one of the in Tag 952 Subfield struture, e.g. for subfield x Non-public note. You can define it under 'Advancde constraints'. Define the value similar to the following: Year: Month:MM Day:DD - Got to Home > Tools > Batch item modification - Enter one ore more barcodes you want to modify - Check checkbox 'Populate fields with defautl values from defautl framework - Click 'Continue' - Verify on the follwing screen that the field in Edit form is populated as appropriate (in our example 'x - Non public note') - Clcik 'Save' - Verify that the items are updated as appropriate Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 --- Comment #6 from Martin Renvoize--- On the debian front, Robin is your man there.. it's always good to get some extra feedback on our packaging approach. Are you on the Koha IRC channel yet.. that's probably your best place to start getting involved? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #49 from Jonathan Druart--- Created attachment 43109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43109=edit Bug 14739: Adapt wording in breadcrumbs if a new batch is created Don't display "Manage batch number 0" but "Create new batch" Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 --- Comment #8 from Mike Gabriel--- (In reply to Martin Renvoize from comment #6) > On the debian front, Robin is your man there.. it's always good to get some > extra feedback on our packaging approach. Are you on the Koha IRC channel > yet.. that's probably your best place to start getting involved? Showing up on IRC now (my nick is around 24/7, nick is: sunweaver)... Mike -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 --- Comment #5 from Martin Renvoize--- Hi Mike, Great to have some new blood on board; I totally agree that the Auth_with_ldap code needs a major rethink and would support such a piece of work. It's great to have your insight regarding best/worst practice's in the LDAP space and i'd be OK with deprecating some feature and clarifying the code.. though we'de need a good strong DEPRECATION warning because not all koha users are as technically able as yourself and may not be following current bets practice.. That's why it's always hard to get rid of some of these ldap related features. It might also be worth you taking a little look at bug 8993 as it was a piece of work aimed at re-working the LDAP code. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #48 from Jonathan Druart--- Created attachment 43108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43108=edit Bug 14739: Fix plack compatibility perlcritic raised "Declare variables outside of the condition" Works as expected Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Jonathan Druartchanged: What|Removed |Added Attachment #43062|0 |1 is obsolete|| Attachment #43063|0 |1 is obsolete|| --- Comment #47 from Jonathan Druart --- Created attachment 43107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43107=edit Bug 14739 - Add several patrons to a new batch will create a new batch per patron added This patch changes the functionality of adding patrons to patroncard batches. Instead of using only the patron search, there is now a textarea which can either be manually populated with borrowernumbers, or can be populated using the patron-search To test: 1 - Create a new patron batch 2 - Click the add items button, if there is no data in the borrowrnumber form you should get a popup 3 - Add items to batch using the popup, borrowernumbers should populate to the form 4 - Click add items again and items should be added to a new batch 5 - Create a new batch 6 - Manually enter invalid borrowernumbers to the form 7 - Click add items, batch should return empty 8 - Manually enter valid borrowernumber 9 - Click add items, batch should be updated 10 - Edit an existing batch and confirm add items works as above 11 - Create a new label batch 12 - Click add items with no data, popup item search should appear 13 - Adding items by checking boxes or using 'Add' button - they should populate the text box on the edit batch page 14 - When adding using form the 'Enter by itemnumber' button should be marked automatically 15 - Submit items and confirm they are added to batch 16 - Create a new batch, enter by barcode manually and check 'Enter by itemnumber" 17 - Click add items, no items should be added 18 - Repopulate form with barcodes, check 'Enter by barcode' 19 - Click add items, items should be added correctly 20 - Test various combinations of radio buttons and numbers and using form or not Signed-off-by: Barton Chittenden Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14100] Generic solution for language overlay
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #22 from Jonathan Druart--- Created attachment 43111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43111=edit Bug 14100: (follow-up) Language overlay for item types Display the translated description for item types in the following pages: > admin/smart-rules.pl > catalogue/detail.pl > catalogue/itemsearch.pl > catalogue/moredetail.pl > reports/acquisitions_stats.pl > reports/bor_issues_top.pl > reports/cat_issues_top.pl > reports/catalogue_out.pl > reports/catalogue_stats.pl > reports/issues_avg_stats.pl > reports/issues_stats.pl > reports/itemslost.pl > reports/manager.pl > reports/reserves_stats.pl > suggestion/suggestion.pl > tools/export.pl > Opac: > opac-detail.pl > opac-MARCdetail.pl > opac-search.pl Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14100] Generic solution for language overlay
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #23 from Jonathan Druart--- conflict on kohastructure.sql fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14100] Generic solution for language overlay
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Jonathan Druartchanged: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14100] Generic solution for language overlay
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Jonathan Druartchanged: What|Removed |Added Attachment #42525|0 |1 is obsolete|| Attachment #42526|0 |1 is obsolete|| --- Comment #21 from Jonathan Druart --- Created attachment 43110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43110=edit Bug 14100: Generic solution for language overlay - Item types Test plan: 1/ update the Schema (misc/devel/update_dbix_class_files.pl) 2/ Translate templates for some languages (es-DE, de-DE for instance) 3/ Enable them in the pref (search for 'lang') for the staff interface 4/ Go on the item type admin page (admin/itemtypes.pl) 5/ Edit one 6/ Click on the 'translate for other languages' link 7/ You are now on the interface to translate the item type's description in the languages you want. So translate some :) 8/ Go back on the item type list view (admin/itemtypes.pl) 9/ You should see the original description (non translated) 10/ Switch the language 11/ You should see the translated description in the correct language. If the description is non translated, the original description is displayed. 12/ On the different page where the item type is displayed, confirm that the translated description appears. Think further / Todo: 1/ Update all occurrences of the item type's description (DONE) 2/ Implement for authorised values 3/ Implement for syspref value (at least textarea) 4/ Implement for branch names 5/ Centralize all the translation on a single page in the admin area ... N/ Implement a webservice to centralize all the translations and give the ability to sync the item types/authorised values description with the rest of the world (push and pull). Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5456] Create a link to opac-ics.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 Marc Véronchanged: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12769] Notice fee management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Paul Poulainchanged: What|Removed |Added CC||claire.hernandez@biblibre.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12769] Notice fee management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Paul Poulainchanged: What|Removed |Added CC|corinne.flacher-david@bibli | |bre.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Joonas Kylmälächanged: What|Removed |Added CC||j.kylm...@gmail.com --- Comment #2 from Joonas Kylmälä --- In the file orderreceive.pl there is code depending to Dates.pm: line 207: date => format_date($order->{entrydate}), Otherwise the patch looks good! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10363] There is no package for authorised values.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #85 from Jonathan Druart--- Created attachment 43113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43113=edit Bug 13636: Change wording added vs inserted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10363] There is no package for authorised values.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #86 from Jonathan Druart--- Created attachment 43114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43114=edit Bug 10363: (follow-up) DB update - change in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10363] There is no package for authorised values.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druartchanged: What|Removed |Added Attachment #41345|0 |1 is obsolete|| --- Comment #84 from Jonathan Druart --- Created attachment 43112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43112=edit Bug 10363: FIX regression - prevent duplicate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10363] There is no package for authorised values.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druartchanged: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10363] There is no package for authorised values.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #87 from Jonathan Druart--- (In reply to Katrin Fischer from comment #82) > Sorry, but I still see the duplicate bug - last patch doesn't seem to work? > > Try changing an existing values description, you will receive: > "This authorized value already exists." > The change is not saved. It was not exactly the same issue, good catch. Should be fixed now. > Some small note for someone returning to this: I like 'added' better than > 'inserted' in the error messages, as it matches the other terminology in > Koha better. Fixed. (In reply to Katrin Fischer from comment #83) > Hm, I think we are also missing a kohastructure.sql change here? Added. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 --- Comment #7 from Mike Gabriel--- (In reply to Martin Renvoize from comment #5) > It might also be worth you taking a little look at bug 8993 as it was a > piece of work aimed at re-working the LDAP code. The patches in #8993 look indeed promising. I will need some time to review and get back to you via #8993 or here (depends where it fits best). Mike -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 --- Comment #7 from Julian Maurice--- Created attachment 43115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43115=edit Bug 14788: Add unit tests for GetTopIssues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Julian Mauricechanged: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14953] Adlibris (Swedish supplier) cover image support
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14953 Martin Perssonchanged: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Martin Perssonchanged: What|Removed |Added CC||xarra...@gmail.com Assignee|mag...@libriotech.no|xarra...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14666] adds fixed_fines for overdues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 --- Comment #3 from Fridolin SOMERS--- Created attachment 43116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43116=edit Bug 14666 - add fixed_fines for overdues - Add a overduerules.fixed_fineX for the 3 levels - Add a column "Fixed fines" in the tools/overduerules.pl page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14666] adds fixed_fines for overdues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Fridolin SOMERSchanged: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14666] adds fixed_fines for overdues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Fridolin SOMERSchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #123 from Jonathan Druart--- Robin, just retried now with and everything works fine. Not sure where did it come from, but it looks to be fixed! Just got: Upgrade to XXX done (Bug 12478 - set up elasticsearch tables) DBD::mysql::db do failed: Can't DROP 'index_name_2'; check that column/key exists at installer/data/mysql/updatedatabase.pl line 10967.DBD::mysql::db do failed: Duplicate column name 'label' at installer/data/mysql/updatedatabase.pl line 10970. Upgrade to XXX done (Bug 12478/14899 - DB Changes to the elasticsearch tables) when updating the DB. You have updated the structure in the elasticsearch_mapping.sql file, so no need to remove the unique key and add the label field in the last updatedatabase entry. Not a big deal anyway :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 --- Comment #24 from David Cook--- Created attachment 43151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43151=edit Bug 14861 - [ALTERNATE] Accession date comparison does not work in advanced search _Test plan_ Prerequisites: Make sure that you have an item with a valid dateaccessioned, and that the bib is indexed in zebra. For the purposes of explanation, I'm going to use the date '2011-09-07' 1) Go to advanced search in the staff client and choose 'Acquisition date (-mm-dd)' 2) Enter 2011-09-07 (or the date of your choice). 3) Click the search button - you should get your item in the search results. 4) Return to the advanced search screen and select Acquisition date again. 5) Enter a start and end date in the text field separated by ' - '. For example: 2011-09-01 - 2011-09-30 6) Click the search button -- this will return no results. 7) Apply the patch and copy etc/zebradb/ccl.properties to whatever directory is specified by the koha-conf.xml referenced by $KOHA_CONF. 8) Try the search again -- this will return the expected results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 David Cookchanged: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14005] Fix wording of previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14005 Liz Reachanged: What|Removed |Added CC||l...@catalyst.net.nz --- Comment #4 from Liz Rea --- I am pretty sure that the todaysIssuesDefaultSortOrder preference is actually reversed in meaning. Latest to earliest (according to the preference) Today's checkouts 10/06/2015 14:29 10/06/2015 14:30 10/06/2015 14:36 10/06/2015 14:39 Earliest to latest 10/06/2015 14:39 10/06/2015 14:36 10/06/2015 14:30 10/06/2015 14:29 This doesn't seem right to me? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véronchanged: What|Removed |Added Depends on||14961 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14961 [Bug 14961] Remove C4::Dates from files reports/*_stats.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14961] Remove C4::Dates from files reports/*_stats.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14961 Marc Véronchanged: What|Removed |Added Blocks||14870 Patch complexity|--- |Medium patch Assignee|gmcha...@gmail.com |ve...@veron.ch Status|NEW |Needs Signoff Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14961] New: Remove C4::Dates from files reports/*_stats.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14961 Bug ID: 14961 Summary: Remove C4::Dates from files reports/*_stats.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: ve...@veron.ch QA Contact: testo...@bugs.koha-community.org Remove C4::Dates from following files: - reports/acquisitions_stats.pl - reports/borrowers_stats.pl - reports/reserves_stats.pl - reports/serials_stats.pl - reports/issues_avg_stats.pl - reports/issues_stats.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14962] New: Temp Shelving Location
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 Bug ID: 14962 Summary: Temp Shelving Location Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Would like to see a new location field added to the items table, like TEMPLOC. This field would be ignored if blank, but if populated it's data would be used instead of the data in the LOCATION field. The idea is, if you are placing items in a temporary location, like a display, you can actually list the location, but not loose the permanent location. Then, when it comes time to move the item back to its regular location, you can simply clear the TEMPLOC field. Christopher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14962] Temp Shelving Location
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 David Cookchanged: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- Doesn't this already exist with the "location" field? If you're losing the permanent location, it could be that there's a bug... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14961] Remove C4::Dates from files reports/*_stats.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14961 --- Comment #1 from Marc Véron--- Created attachment 43150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43150=edit Bug 14961 - Remove C4::Dates from files reports/*_stats.pl Remove C4::Dates from following files: - reports/acquisitions_stats.pl - reports/borrowers_stats.pl - reports/reserves_stats.pl - reports/serials_stats.pl - reports/issues_avg_stats.pl - reports/issues_stats.pl To test: - Go to Home > Reports - Verify that following reports work as before: - Other > Average loan time - Statistic wizards - Acquisitions - Patrons - Circulation - Serials - Holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 David Cookchanged: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 --- Comment #23 from David Cook--- (In reply to Jonathan Druart from comment #22) > Yep, if it works, let's do it for all date indexes :) I suppose I should clarify this a bit... In ccl.properties, we create the following mapping: "st-date-normalized 4=5" This associates a CCL qualifier name with a Bib-1 structure attribute. Internally in Zebra, the Bib-1 attribute "4=5" is mapped to the Date "d" register. http://www.indexdata.com/zebra/doc/querymodel-zebra.html#querymodel-pqf-apt-mapping If we search "biblio-zebra-indexdefs.xsl" for MARC21, we find that "Date-of-acquisition" is actually the only index defined in the Date "d" register. It's a little better for UNIMARC, as it also has "onloan" added to the "d" register. What that means is that "st-date-normalized" can really only be used for "Date-of-acquisition" with MARC21/NORMARC, and "Date-of-acquisition" and "onloan" for UNIMARC. -- Of course, there are lots of other MARC fields where we store ISO formatted dates, but we put them in the "w" register, so that they can be found using "kw,wrdl" queries it seems. We probably under-use the various registers available. The only index using the "y" register is "pubdate" in MARC21. UNIMARC has a few more although I'm not sure whether they're used correctly as I'm not familiar with the format. The "y" register is only suitable for "" strings. The only way to access the "y" register is by using "st-year" as well. "st-numeric" accesses the "n" register which seems to be relied upon a lot in Koha. -- In any case, I'll add a patch to add "r=o" to "st-date-normalized", even though it will only really affect the advanced search for acquisition date (and any CCL queries that are formed by hand). In the future, we could look at adding other indexes to the "d" register if necessary... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14962] Temp Shelving Location
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #5 from David Cook--- (In reply to Katrin Fischer from comment #4) > I think a lot of libraries use the collection with something unrelated to > the location in the library - for example it could be a special donation > they want to highlight, that was shelved with the other books. > > I think the rotating collection an item belongs to is currently not visible > in the OPAC, but might be something that could be added. A problem might be > searching for it - that would be easier to solve if it was a field in the > item record. Hm. Fair enough. I suppose my concern is that there are already 43 columns in the items table, and we're running out of conventional subfield codes in the 952. I suppose we could start using capital letters or any of the other interesting things available in the following range: [\dA-Za-z!"#$%&'()*+,-./:;<=>?{}_^`~\[\]\\]{1} (http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14962] Temp Shelving Location
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #2 from Christopher Brannon--- (In reply to David Cook from comment #1) > Doesn't this already exist with the "location" field? Sort of, but it is tied in with the PROC and CART features. How would you retain the permanent location, the temp location of the display, and the PROC/CART locations? I guess if you didn't want the item going back to display, that would work, but what if you have a special holiday or themed collection residing somewhere for a while? After the first time out it goes back to its permanent location. Christopher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14962] Temp Shelving Location
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #3 from David Cook--- (In reply to Christopher Brannon from comment #2) > (In reply to David Cook from comment #1) > > Doesn't this already exist with the "location" field? > > Sort of, but it is tied in with the PROC and CART features. How would you > retain the permanent location, the temp location of the display, and the > PROC/CART locations? > > I guess if you didn't want the item going back to display, that would work, > but what if you have a special holiday or themed collection residing > somewhere for a while? After the first time out it goes back to its > permanent location. > > Christopher Ahh, I see what you're saying. I've always found items in Koha to be a bit funny/confusing. There's a permanent_location, location, ccode (collection code). Personally, I would think the collection would be synonymous with shelving location, and that location would be more like "status" (in processing, on cart, on shelf, etc). If anything, I would think it would make more sense to have ccode and location/status. Maybe permanent_ccode if you wanted to designate the "true" collection for an item, and then have an ability to add it to temporary collections without losing track of the original collection. -- You might also be able to use the rotating collections feature: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Once upon a time, I worked at a multilingual library where we had books in 29 different languages each with their own set of collections. Every so often, a small rotating collection would be created from some of these books, it would be sent around the province (in Canada) to other libraries before returning home to our library where the books would go back to their original collection. In this case, you wouldn't have to transfer the collection to another library. You could use it as a temporary collection. That's theoretical though. I haven't used this feature in Koha... worth experimenting or talking to Kyle Hall about it, I imagine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14962] Temp Shelving Location
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- I think a lot of libraries use the collection with something unrelated to the location in the library - for example it could be a special donation they want to highlight, that was shelved with the other books. I think the rotating collection an item belongs to is currently not visible in the OPAC, but might be something that could be added. A problem might be searching for it - that would be easier to solve if it was a field in the item record. Hm. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #19 from David Cook--- Probably won't have time to test this one actually... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #34 from Kyle M Hall--- Created attachment 43118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43118=edit Bug 5144 [QA Followup] - Add unit test -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14956] C4::Dates from files opac/*.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #1 from Marc Véron--- Created attachment 43123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43123=edit Bug 14956 - C4::Dates from files opac/*.pl Remove C4::Dates from files: - opac/opac-memberentry.pl - opac/opac-reserve.pl - opac/opac-search-history.pl - opac/opac-showreviews.pl - opac/opac-suggestions.pl - opac/opac-serial-issues.pl - opac/opac-alert-subscribe.pl - opac/opac-ics.pl To test: - Apply patch - Verify, that self registration and holds work as before - Verify that tabs in catalog item detail work and display as before - For serials: Verify that subscriptions work as before. It is a little bit hidden, in tab Subscriptions, then 'More details', then tab 'Brief history', button 'Subscribe to email notificatin on new issues' - For ics: Can not be tested at the moment, not yet used (Bug 5456), pls. have a look at the code changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14956] C4::Dates from files opac/*.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc Véronchanged: What|Removed |Added Assignee|gmcha...@gmail.com |ve...@veron.ch Status|NEW |Needs Signoff Patch complexity|--- |Small patch Blocks||14870 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 Jonathan Druartchanged: What|Removed |Added Depends on||13789 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789 [Bug 13789] facets with accented utf-8 characters generate double encoded links -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13789] facets with accented utf-8 characters generate double encoded links
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789 Jonathan Druartchanged: What|Removed |Added Blocks||14955 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 [Bug 14955] "Show more" link contains double encoded characters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14955] New: "Show more" link contains double encoded characters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 Bug ID: 14955 Summary: "Show more" link contains double encoded characters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Searching Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14560] Introduce a way of handling Rameau composed authorities, without breaking normal workflow
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14560 --- Comment #7 from Matthias Meusburger--- Created attachment 43124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43124=edit Bug 14560 [Follow-up]: QA: Add debug warnings and get biblionumber with GetMarcFromKohaField -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Marc Véronchanged: What|Removed |Added Attachment #43064|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hallchanged: What|Removed |Added Blocks||14695 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 [Bug 14695] Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14956] New: C4::Dates from files opac/*.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Bug ID: 14956 Summary: C4::Dates from files opac/*.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: ve...@veron.ch QA Contact: testo...@bugs.koha-community.org C4::Dates from files: - opac/opac-memberentry.pl - opac/opac-reserve.pl - opac/opac-search-history.pl - opac/opac-showreviews.pl - opac/opac-suggestions.pl - opac/opac-serial-issues.pl - opac/opac-alert-subscribe.pl - opac/opac-ics.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #124 from Jonathan Druart--- I have found an encoding bug on the "Show more" link, it will be fixed by bug 14955. Already exists on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hallchanged: What|Removed |Added Attachment #42792|0 |1 is obsolete|| Attachment #42848|0 |1 is obsolete|| Attachment #43118|0 |1 is obsolete|| --- Comment #35 from Kyle M Hall --- Created attachment 43119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43119=edit Bug 5144 [QA Followup] - Add unit test -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #36 from Kyle M Hall--- Created attachment 43120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43120=edit Bug 5144 - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message Signed-off-by: David Kuhn -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #37 from Kyle M Hall--- The updates to the unit tests in the first patch do not actually test the new functionality. Those changes were necessary to keep the tests from failing not that the patron hold limit of one per record is enforced by AddReserve. I've attached a new follow up that adds a unit test to specifically test this. I have reworked the patches to split the unit tests into a separate patch for easier testing. (In reply to Jonathan Druart from comment #33) > Kyle, I don't understand how the changes you introduced in the tests for > AddReserve highlight your changes in the subroutine. > > It would be better to first submit a patch to fix the issue then to clean > some stuffs (indentation, replacement with Koha::Objects, etc.) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hallchanged: What|Removed |Added Attachment #43121|0 |1 is obsolete|| Attachment #43122|0 |1 is obsolete|| --- Comment #40 from Kyle M Hall --- Created attachment 43125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43125=edit Bug 5144 - Add unit test -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #41 from Kyle M Hall--- Created attachment 43126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43126=edit Bug 5144 - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message Signed-off-by: David Kuhn -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 --- Comment #1 from Jonathan Druart--- Created attachment 43117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43117=edit Bug 14955: Don't double encode chars in the "Show more" link Bug 13789 has fixed this issue for the facet links (select/unselect) but not for the "Show more" facets link. This patch reuses the "url" variable, generated for the facets, for these links. A new "local_url" variable is used to build links for each entry. Test plan (for OPAC and intranet): - Search for a very common term - Filter the results using facets - You should get more than 5 entries for a facet and 1 selected: Author author 1 author 2 [x] # Selected author 3 author 4 author 5 Show more # you see this link if there is 5+ values for this facet - Click on the Show more link Without this patch, the url contains double-encoded characters and you will certainly don't get any results With this patch, you should get results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 Jonathan Druartchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3719] Create syspref to allow sites to rename OPAC Cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3719 Madhukara Mchanged: What|Removed |Added CC||librar...@iipr.in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hallchanged: What|Removed |Added Depends on||5144 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #39 from Kyle M Hall--- Created attachment 43122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43122=edit Bug 5144 - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message Signed-off-by: David Kuhn -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hallchanged: What|Removed |Added Attachment #43119|0 |1 is obsolete|| Attachment #43120|0 |1 is obsolete|| --- Comment #38 from Kyle M Hall --- Created attachment 43121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43121=edit Bug 5144 - Add unit test -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véronchanged: What|Removed |Added Depends on||14956 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 [Bug 14956] C4::Dates from files opac/*.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/