[Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #18 from Jonathan Druart  
---
(In reply to Marc Véron from comment #17)
> Jonathan, is it OK to switch back to Signed-off with the followup?

Yes because the following is still wrong:
$template->param( IMPOSSIBLE=>1, INVALID_DATE=>$datedue )

Test plan:
Set and force an invalid date for the due date and confirm you get a warning
with the invalid date displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030

--- Comment #4 from M. Tompsett  ---
Comment on attachment 43601
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43601
Bug 15030 - Certain values in serials' items are lost on next edit

Review of attachment 43601:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=15030=43601)
-

::: C4/Items.pm
@@ +2944,4 @@
>  if (   $tagslib->{$tag}->{$subfield}->{kohafield} eq 
> 'items.itemcallnumber'
>  && $defaultvalues
>  && $defaultvalues->{'callnumber'} ) {
> +if( $itemrecord and $defaultvalues and not 
> $itemrecord->subfield($tag,$subfield) ){

YIKES! Nice find.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #5 from M. Tompsett  ---
$ git grep -l labels_t
I think Russian and Ukrainian are broken as well.
Please submit follow ups for those, so I can just sign off everyone
accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #5 from M. Tompsett  ---
Okay... this modifies a routine in C4/Items.pm
There is no test coverage directly for PrepareItemrecordDisplay.
However, there is some in t/db_dependent/Serials.t
I would recommend adding a test there to validate your changes as a separate
commit. This would allow the test to run before applying the other patches
(expecting failure), and after applying them (expecting passing).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14964] Email notices will be queued for patrons with no email address

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14964

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #6 from M. Tompsett  ---
I cringe at the lack of test coverage for C4::Message. *sigh*

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15073] FeeOnChangePatronCategory in wrong place

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15073

--- Comment #1 from Nicole C. Engard  ---
Created attachment 44124
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44124=edit
Bug 15073: Move FeeOnChangePatronCategory

This patch moves the FeeOnChangePatronCategory system
preference so that it's in a more logical place. Also
a few typos were fixed.

To test:

* Go to System Preferences
* Go to Patrons
* Find FeeOnChangePatronCategory and confirm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15074] build-git-snapshot does not work in Jessie (can't build with source format '3.0 (native)')

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15074

Mirko Tietgen  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #1 from Mirko Tietgen  ---
Nevermind, was probably caused by the version name I chose. It's not supposed
to have something like -1 in there.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13294] Subscription and Holding tab interaction.

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13294

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

--- Comment #110 from Héctor Eduardo Castro Avalos  
---
(In reply to Frédéric Demians from comment #109)

> Somehwhere in the process, I take a look at the code, spend time on it,
> trying
> to figure out how it works, how it has been done. Testing and QAing is all
> about that.
> 
> I have mixed feeling, when I find duplicated code (for example). In
> opac/opac-
> export.pl and catalog/export.pl:

> Or in Koha::Crosswalk::DublinCore.pm, line 242, you get:
> Is it valid?

> How will you extend the semantic of the produced metadata with
> MARC::Crosswalk::Dublincore? If you want more than the 15 DC elements,
> doesn't
> it mean that you need a mean to improve, granularize the way Koha MARC record
> is transformed. The current DC exported from Koha is not that good because
> (1)
> it doesn't work for Unimarc, (2) it doesn't allow each library to tweak the
> transformation from MARC to DC (the way it's done by OAI server).

> It's far beyond the scope of this patch. Open a new bug if you want, and name
> it Semantic-Koha, or Sekoa.

Yes, you're right Frédéric. I'm just a librarian trying to improve.

Let me propose another patch with your suggestion, using the xslts for
transforming the marc flavors.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053

--- Comment #8 from M. Tompsett  ---
Comment on attachment 44125
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44125
Bug 15053: Fix fr-FR, ru-RU and uk-UK sample creator data

Review of attachment 44125:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=15053=44125)
-

Same for both RU and UK files.

::: installer/data/mysql/ru-RU/optional/print_labels.sql
@@ -17,5 @@
> -LOCK TABLES `labels_conf` WRITE;
> -/*!4 ALTER TABLE `labels_conf` DISABLE KEYS */;
> -INSERT INTO `labels_conf` 
> -(id,barcodetype,title,subtitle,itemtype,barcode,dewey,classification,subclass,itemcallnumber,author,issn,isbn,startlabel,
> -printingtype,formatstring,layoutname,guidebox,active,fonttype,ccode,callnum_split)

Why remove the fields list completely? It would have been good to keep updated.

@@ -21,5 @@
> -printingtype,formatstring,layoutname,guidebox,active,fonttype,ccode,callnum_split)
> -VALUES 
> -(5,'CODE39',2,0,3,0,0,0,0,4,1,0,0,1,'BIBBAR','библио-запись и 
> штрих-код',1,1,NULL,NULL,NULL,NULL),
> -(6,'CODE39',2,0,0,0,0,3,4,0,1,0,3,1,'BAR','переменный',1,1,NULL,NULL,NULL,NULL),
> -(7,'CODE39',1,NULL,NULL,NULL,NULL,NULL,NULL,NULL,2,NULL,NULL,1,'PATCRD','Карточки
>  идентификации посетителей',1,NULL,NULL,NULL,NULL,NULL);

This last one looks strange, but why not keep the strange data?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5979] OPAC : using OPACISBD systempreference to display link

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979

--- Comment #15 from Alex Arnaud  ---
Created attachment 44126
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44126=edit
Bug 5979 - OPAC ISBD view has its own syspref

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14209] opacserialdefaulttab ignored with bibs having items <1 or >50

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14209

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13697] Syspref to not add a fee when a patron changes to a category with enrolment fee

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697

Nicole C. Engard  changed:

   What|Removed |Added

 Blocks||15073


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15073
[Bug 15073] FeeOnChangePatronCategory in wrong place
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15073] New: FeeOnChangePatronCategory in wrong place

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15073

Bug ID: 15073
   Summary: FeeOnChangePatronCategory in wrong place
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: major
  Priority: P5 - low
 Component: System Administration
  Assignee: neng...@gmail.com
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Depends on: 13697

The FeeOnChangePatronCategory preference needs to be moved to a more logical
place.


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697
[Bug 13697] Syspref to not add a fee when a patron  changes to a category with
enrolment fee
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15074] New: build-git-snapshot does not work in Jessie (can't build with source format '3.0 (native)')

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15074

Bug ID: 15074
   Summary: build-git-snapshot does not work in Jessie (can't
build with source format '3.0 (native)')
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mi...@abunchofthings.net
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

On Jessie, build-git-snapshot dies with

> dpkg-source: error: can't build with source format '3.0 (native)': native 
> package version may not have a revision"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5979] OPAC : using OPACISBD systempreference to display link

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #10327|0   |1
is obsolete||

--- Comment #14 from Alex Arnaud  ---
Created attachment 44123
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44123=edit
Bug 5979 - Follow up: using OPACISBD systempreference to display link

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053

--- Comment #7 from Bernardo Gonzalez Kriegel  ---
(In reply to M. Tompsett from comment #5)
> $ git grep -l labels_t
> I think Russian and Ukrainian are broken as well.
> Please submit follow ups for those, so I can just sign off everyone
> accordingly.

Uploaded some kind of fix for ru and uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #44007|0   |1
is obsolete||

--- Comment #6 from Bernardo Gonzalez Kriegel  ---
Created attachment 44125
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44125=edit
Bug 15053: Fix fr-FR, ru-RU and uk-UK sample creator data

Fixes other sample creators data

To test:
1 ) Apply the patch
2) Remove sample creator date
delete from creator_layouts; delete from creator_templates; delete from
printers_profile
3) Load fr-FR/2-Optionel/sample_labels.sql
or ru-RU/optional/print_labels.sql
or uk-UA/optional/print_labels.sql

Without the patch this files can't be loaded
Test all of them

In case of ru and uk I removed a patron card layout

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15073] FeeOnChangePatronCategory in wrong place

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15073

Nicole C. Engard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5979] OPAC : using OPACISBD systempreference to display link

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979

Alex Arnaud  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #16 from Alex Arnaud  ---
Syspref OPACISBD is now a textarea so it's possible to have a different
template in staff and opac.

I didn't add a "OPACviewISBD", empty OPACISBD is enough for disable ISBD view
in opac.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13697] Syspref to not add a fee when a patron changes to a category with enrolment fee

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697

--- Comment #13 from Nicole C. Engard  ---
All better: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15073

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131

--- Comment #25 from Jonathan Druart  
---
(In reply to Liz Rea from comment #24)
> Jonathan, do you think we should change the height on that greybox across
> the board for the label and patron card creators?
> 
> It kinda feels like the right thing to do.
> 
> Liz

Indeed, to be consistent it would be good to reduce them too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131

--- Comment #26 from Liz Rea  ---
cool I'll probably have a poke at that one unless you've already started on it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14722] Refactor the export tool

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722

--- Comment #17 from Fridolin SOMERS  ---
Is the script "misc/exportauth.pl" then obsolete ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15059] Line break in html attribute

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059

Fridolin SOMERS  changed:

   What|Removed |Added

  Attachment #44042|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931

--- Comment #11 from Jonathan Druart  
---
Created attachment 44104
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44104=edit
Bug 14931 - (Follow-up) Validate date entry in contracts

Go to Home > Acquisitions, search for an active vendor and view the vendor
- Click on 'Contracts' at the left
  (admin/aqcontract.pl)
- Create and edit contracts and verify that it works OK.
  (Note: there is no help for this page, see Bug 14929)

Amended for comment #7  25.10.2015 / mv

Signed-off-by: Jesse Weaver 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #43302|0   |1
is obsolete||
  Attachment #44101|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart  
---
Created attachment 44103
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44103=edit
Bug 14931 - Remove C4::Dates from files admin/aq*.pl

This patch removes C4::Dates from:

- admin/aqbudgets.pl
- admin/aqplan.pl
- admin/aqcontract.pl

To test:

- Apply patch

- Go to Home > Adminstration > Budgets > All funds
  (admin/aqbudgets.pl)
- Verify that everything displays as before

- Edit one of the funds and click on 'Planning - Plan by months'
  (admin/aqplan.pl)
- Verify that planning works as before

- Go to Home > Acquisitions, search for an active vendor and view the vendor
- Click on 'Contracts' at the left
  (admin/aqcontract.pl)
- Create and edit contracts and verify that it works OK.
  (Note: there is no help for this page, see Bug 14929)

Signed-off-by: Hector Castro 
Works as advertised. Tested with dateformat syspref
Dates in planning by months not needed to be on iso format, aqplan.pl
uses instead Date::Calc

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931

--- Comment #12 from Jonathan Druart  
---
Created attachment 44105
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44105=edit
Bug 14931: (qa followu-up) small improvements

- Avoid 1 call to dt_from_string in some cases
- Do not use $_

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13671] Search returning empty

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13671

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #5 from Liz Rea  ---
I just saw this happen moving from 3.14 -> 3.20 - I'm sure I've solved it
before but for the life of me I can't remember what I did.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13671] Search returning empty

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13671

--- Comment #6 from Liz Rea  ---
I just saw this happen moving from 3.14 -> 3.20 - I'm sure I've solved it
before but for the life of me I can't remember what I did.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13671] Search returning empty

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13671

--- Comment #8 from Liz Rea  ---
I just saw this happen moving from 3.14 -> 3.20 - I'm sure I've solved it
before but for the life of me I can't remember what I did.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13671] Search returning empty

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13671

--- Comment #9 from Liz Rea  ---
jesus, sorry about that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13671] Search returning empty

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13671

--- Comment #7 from Liz Rea  ---
I just saw this happen moving from 3.14 -> 3.20 - I'm sure I've solved it
before but for the life of me I can't remember what I did.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #42337|0   |1
is obsolete||

--- Comment #66 from Alex Arnaud  ---
Created attachment 44114
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44114=edit
Bug 9223: Add SupportsAuthorizedValues syspref (followup 1)

Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #42336|0   |1
is obsolete||

--- Comment #65 from Alex Arnaud  ---
Created attachment 44113
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44113=edit
Bug 9223: Multiple values of AdvancedSearchTypes in suggestions

Suggestion form uses C4::Koha::GetSupportList to get a list of supports that
can come from itemtypes or authoritized values LOC or CCODE.
C4::Koha::GetSupportList uses AdvancedSearchTypes syspref like it has only one
value. But this syspref can contain several values separated by a pipe.

This patch introduces a new syspref SupportsAuthorizedValues to select wich
authorized values category that represents the physical support (itemtypes by
default, loc or ccode). These authorized values will be used in suggestion
management, known as 'document type'.
(Note that database field is still 'itemtype').

Test plan :
---
- Set SupportsAuthorizedValues with itemtypes or loc or ccode
- Get to suggestion form (OPAC or intranet)
- Look at "Document type" combobox, it must contains descriptions of selected
authorized values
- Save the suggestion
- Get to intranet suggestions management
- Organize suggestions by document type
=> your suggestion must appear in a tab with its document type description

Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

--- Comment #70 from Alex Arnaud  ---
Created attachment 44118
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44118=edit
Bug 9223 - Fix QA issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #44111|0   |1
is obsolete||

--- Comment #69 from Alex Arnaud  ---
Created attachment 44117
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44117=edit
Bug 9223 [Follow-up] add unit tests for GetSupportList and GetSupportName
subroutine

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #42339|0   |1
is obsolete||

--- Comment #68 from Alex Arnaud  ---
Created attachment 44116
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44116=edit
Bug 9223 [Follow-up] change the way syspref SuggestionsUseValues is added: Use
the new worflow (atomic update)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #42338|0   |1
is obsolete||

--- Comment #67 from Alex Arnaud  ---
Created attachment 44115
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44115=edit
Bug 9223 [Follow-up] Multiple values of AdvancedSearchTypes in suggestions

This follow-up implements some things I think will improve on the
previous patches:

- Change the system preference name to "SuggestionsUseValues"
- Change the description of the preference to "Suggestions can be
  submitted using the following authorized values:"
- Move the new preference to the OPAC tab so that it is grouped with
  other suggestions-related preferences.
- Add the option offer no itemtype/collection code chooser on the
  submission form.
- Display the correct label on the submission form depending on the
  value of the SuggestionsUseValues preference.

To test, apply this patch on top of the previous ones. Test submission
of purchase suggestions through the OPAC and staff client with the
SuggestionsUseValues preference set to all the various choices: item
type, collection code, shelving location, and 'none.' The suggestion
forms should look correct and work correctly.

HOWEVER, neither the previous patches nor mine address the problem of
the suggestions management page's "organize by" option, which is
hard-coded to work with item types. Whether or not my patch is
acceptable this issue will need to be addressed.

Signed-off-by: Olli-Antti Kivilahti 

  Tested the TEST PLAN. With ccode, itype, none, loc.
  On both OPAC and SC.
  Making a code review, but it is hard during the hackfest.
  Morbid lack of any kind of unit test!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015)

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333

Zeno Tajoli  changed:

   What|Removed |Added

  Attachment #43774|0   |1
is obsolete||

--- Comment #10 from Zeno Tajoli  ---
Created attachment 44129
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44129=edit
[SIGN-OFF] followup - Fix labels

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015)

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333

Zeno Tajoli  changed:

   What|Removed |Added

  Attachment #43773|0   |1
is obsolete||

--- Comment #8 from Zeno Tajoli  ---
Created attachment 44128
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44128=edit
Update MARC21 frameworks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10744] ExpireReservesMaxPickUpDelay has minor workflow conflicts with hold(s) over report

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 CC||olli-antti.kivila...@jns.fi
   Assignee|koha-b...@lists.koha-commun |olli-antti.kivila...@jns.fi
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053

--- Comment #10 from Bernardo Gonzalez Kriegel  ---

> > -(5,'CODE39',2,0,3,0,0,0,0,4,1,0,0,1,'BIBBAR','библио-запись и 
> > штрих-код',1,1,NULL,NULL,NULL,NULL),
> > -(6,'CODE39',2,0,0,0,0,3,4,0,1,0,3,1,'BAR','переменный',1,1,NULL,NULL,NULL,NULL),
> > -(7,'CODE39',1,NULL,NULL,NULL,NULL,NULL,NULL,NULL,2,NULL,NULL,1,'PATCRD','Карточки
> >  идентификации посетителей',1,NULL,NULL,NULL,NULL,NULL);

From this I only removed the last one, patron card data, 1 & 2 in my patch are
equivalent to 5 & 6


(1,'CODE39',1,'BIBBAR','библио-запись и
штрих-код',0,1,'TR',7,'POINT',0,'L','title, author, itemcallnumber',
'', 'Labels'),
(2,'CODE39',1,'BAR','переменный',0,1,'TR',3,'POINT',0,'L','','','Labels');

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015)

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333

Zeno Tajoli  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #9 from Zeno Tajoli  ---
Test the patch and it is OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053

--- Comment #11 from M. Tompsett  ---
Wow... That error in comment #1 was hard to notice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015)

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333

Zeno Tajoli  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it
  Attachment #44128|Update MARC21 frameworks|[SIGN-OFF] Update MARC21
description||frameworks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15063] Update MARC21 es-ES frameworks to Update 21 (September 2015)

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15063

Zeno Tajoli  changed:

   What|Removed |Added

  Attachment #44127|Update MARC21 es-ES |[SIGN-OFF] Update MARC21
description|frameworks to Update 21 |es-ES frameworks to Update
   ||21

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12620] Proxy Add-on for Koha z39.50

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620

--- Comment #2 from Galen Charlton  ---
Depending on the nature of the proxy involved, it may not be necessary to use
YAZProxy. In particular, the YAZ toolkit supports a special connection syntax
to direct Z39.50 and SRU traffic through a proxy.

For example, suppose you have a Squid proxy running on localhost and listening
on port 210, and further suppose that the proxy is configured to allow
connecting to the target Z39.50 server(s).  In that case, with yaz-client you
can do something like this:

yaz-client connect:localhost:3128,tcp:lx2.loc.gov:210/LCDB

and that will get you a proxied Z39.50 connection to the Library of Congress.

As another example, the following would open a proxied connection to the GBV
(Gemeinsame Bibliotheksverbund) SRU server:

yaz-client connect:localhost:3128,http://sru.gbv.de:80/gvk

Translating that to Koha, a system preference or a new column in the
z3950servers table could be added to specify a proxy to use.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015)

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333

Zeno Tajoli  changed:

   What|Removed |Added

  Attachment #43983|0   |1
is obsolete||

--- Comment #11 from Zeno Tajoli  ---
Created attachment 44130
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44130=edit
[SIGN-OFF] followup 2 - split line to ease translation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13146] Improve GetRecordValue function by caching field mapping

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13146

--- Comment #7 from Frédéric Demians  ---
(In reply to Jonathan Druart from comment #3)
> Frédéric, It would be great to provide a couple of tests to confirm the
> patch does not introduce any regressions.

Done.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13146] Improve GetRecordValue function by caching field mapping

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13146

--- Comment #6 from Frédéric Demians  ---
Created attachment 44133
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44133=edit
Bug 13146 Improve GetRecordValue function by caching field mapping

GetRecordValue function is called each time a specific field mapping is
required. For example, bug 12692 display biblio record subtitle for each hold
awaiting pickup or overdue. As it is implemented now, GetRecordValue queries
directly the fieldmapping table to determine in which tag/letter a field has to
be searched. It means, that the same mapping are requested over and over.

This patch uses Koha cache system to store a complete data structure
representing the field mapping.

TO TEST:

(1) Look at the code! and check that Koha caching system is properly used.

(2) Find out a Koha function where subtitle field mapping is used. Make you
choice: sending a basket, tag list, overdues with fines, renew item, etc.

(3) Note that the display of subtitle field hasn't changed.

(4) If you really want to see how less queries are sent to MySQL with this
patch, you have to monitor your MySQL log files!

Suggestion to do it on a Debian box:

- In MySQL client: SHOW VARIABLES LIKE "general_log%";
  It gives you MySQL log file path. Usually, /var/run/mysqld/mysqld.log
- Enable log, with: SET GLOBAL general_log = 'ON';
- Display a page displaying the subtitle field
- Compare request send with/withouth this patch. Without the patch, you
  will see plenty of query like that:

  SELECT fieldcode, subfieldcode FROM fieldmapping

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13146] Improve GetRecordValue function by caching field mapping

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13146

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #32749|0   |1
is obsolete||

--- Comment #5 from Frédéric Demians  ---
Created attachment 44132
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44132=edit
Bug 13146 UT

Run the test before applying the second patch:

  prove -v t/db_dependent/FieldMapping.t

Apply the 2nd patch, and redo the test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053

--- Comment #12 from M. Tompsett  ---
Any logic with printers_profile should be placed BEFORE the creators_layout and
creators_templates logic in:

installer/data/mysql/de-DE/optional/sample_creator_data.sql
installer/data/mysql/en/optional/sample_creator_data.sql
installer/data/mysql/es-ES/optional/sample_creator_data.sql
installer/data/mysql/it-IT/necessari/sample_creator_data.sql
installer/data/mysql/nb-NO/2-Valgfritt/sample_creator_data.sql

to completely avoid errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10744] ExpireReservesMaxPickUpDelay has minor workflow conflicts with hold(s) over report

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744

--- Comment #1 from Olli-Antti Kivilahti  ---
Created attachment 44134
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44134=edit
Bug 10744 - ExpireReservesMaxPickUpDelay has minor workflow conflicts with
hold(s) over report

Initial commit.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954

--- Comment #10 from Jonathan Druart  
---
Comment on attachment 44077
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44077
Bug 14954 - Remove C4::Dates from holiday related files in folder tools

Review of attachment 44077:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14954=44077)
-

Looking at the patch, some changes smell false.
I might be wrong.

::: C4/Calendar.pm
@@ +707,5 @@
>  
>  sub addDate {
>  my ($self, $startdate, $offset) = @_;
> +$startdate = eval { output_pref( { dt => dt_from_string( $startdate ), 
> dateonly => 1, dateformat => 'iso' } ); };
> +my ( $year, $month, $day) = split( "-", $startdate );

$startdate is already a dt!

@@ +730,5 @@
>   } else { ## ($daysMode eq 'Days') 
>  ($year, $month, $day) = ::Calc::Add_Delta_Days($year, $month, 
> $day, $offset );
>  }
> +my $date_ret = sprintf(ISO_DATE_FORMAT,$year,$month,$day);
> +$date_ret =  eval { output_pref( { dt => dt_from_string( $date_ret), 
> dateonly => 1, dateformat => 'iso' } ); };

This looks wrong, $date_ret is not in the pref format (what dt_from_string is
expecting).
There is a fallback on iso, but when you know the format is iso, you have to
provide it.

@@ +736,3 @@
>  }
>  
>  =head2 daysBetween

This subroutine is not used anywhere, prefer to remove it before this patch.

::: tools/holidays.pl
@@ +49,3 @@
>  # if the url has an invalid date default to 'now.'
> +$calendardate = output_pref( { dt => $calendarinput_dt, dateonly => 1 } );
> +$keydate = output_pref( { dt => $calendarinput_dt, dateonly => 1, dateformat 
> => 'iso' } );

That's not what it was done before.

@@ +132,4 @@
>  my $single_holidays = $calendar->get_single_holidays();
>  my @holidays;
>  foreach my $yearMonthDay (keys %$single_holidays) {
> +my $holidaydate = eval { dt_from_string( 
> $single_holidays->{$yearMonthDay}{date} ) };

specify iso.

@@ +136,4 @@
>  my %holiday;
>  %holiday = (KEY => $yearMonthDay,
>  DATE_SORT => $single_holidays->{$yearMonthDay}{date},
> +DATE => output_pref( { dt => $holidaydate, dateonly => 1, 
> dateformat => 'iso' } ),

before the output was "syspref"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053

--- Comment #9 from Bernardo Gonzalez Kriegel  ---

> Why remove the fields list completely? It would have been good to keep
> updated.
> 

Table names have changed.
Column names have changed.
There is a different number of columns now.
This is really old data

> This last one looks strange, but why not keep the strange data?

Because that data need to be fixed to be loaded.
I'm in other things right now, that's the reason I don't fix them in the first
place, only french data in which I simply added a couple of columns.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15063] Update MARC21 es-ES frameworks to Update 21 (September 2015)

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15063

Zeno Tajoli  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||z.taj...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15063] Update MARC21 es-ES frameworks to Update 21 (September 2015)

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15063

--- Comment #2 from Zeno Tajoli  ---
Created attachment 44127
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44127=edit
Update MARC21 es-ES frameworks to Update 21

Patch test and all is OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15063] Update MARC21 es-ES frameworks to Update 21 (September 2015)

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15063

Zeno Tajoli  changed:

   What|Removed |Added

  Attachment #43988|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903

Marc Véron  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #20 from Marc Véron  ---
Hi Jonathan,

I amended the patch.

However, I can not trigger the message. The datepicker does not allow to enter
wrong dates (field is readonly).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903

Marc Véron  changed:

   What|Removed |Added

  Attachment #44096|0   |1
is obsolete||

--- Comment #19 from Marc Véron  ---
Created attachment 44131
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44131=edit
Bug 14903 - (followup)Remove C4::Dates from circ/circulation.pl

Follow up to fix QA issues from comment #15
...and amended for comment #18

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15068] Get rid of warnings in members/summary-print.pl

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #3 from M. Tompsett  ---
(In reply to Marc Véron from comment #1)
> - Use of uninitialized value in addition (+)
>   at /usr/share/kohaclone/members/summary-print.pl line 87
> 
> - Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison (<=>)
> at /usr/share/kohaclone/members/summary-print.pl line 103
> 
...
> - Go to a detail page with a member who has a lot of fines
...
And items checked out, potentially overdue.

Triggering 47 and 61 is easy with the sample data after creating some fines on
a user. Having difficulty triggering 87, which I feel will also trigger 103, if
I have something checked out, but working on multiple bugs at once is hard. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8937] Translation process removes CDATA in HTML

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8937

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10154] Add Call number in the filter of most circulated items

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154

--- Comment #3 from Eivin Giske Skaaren  ---
Created attachment 44135
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44135=edit
Bug 10154 Add Call number in the filter of most circulated items

This patch adds call number, collection code and shelving location to the
filter.

To test:

It is of course a prerequisite to have items in the DB with the correct MARC
fields
and that they have been checked out etc. to get a valid result when testing.

1. Apply patch to koha synced to master.
2. Go to /cgi-bin/koha/reports/cat_issues_top.pl
3. Select filters, the new ones are Call number, Collection code and Shelving
location
4. Hit submit.

Expected result:
The filters chosen will be printed under "Filtered on".
A table with the result is shown.

For manual verification here is some SQL to run:

SELECT DISTINCT biblio.title, COUNT(biblio.biblionumber) AS RANK,
biblio.biblionumber AS ID, itemcallnumber as CALLNUM, ccode as CCODE, location
as LOC FROM `old_issues`
  LEFT JOIN items USING(itemnumber)
  LEFT JOIN biblio USING(biblionumber)
  LEFT JOIN biblioitems USING(biblionumber)
  LEFT JOIN borrowers USING(borrowernumber)
  WHERE 1 AND biblioitems.itemtype like 'BK' AND itemcallnumber
like '005.2/762' AND ccode like 'NFIC' AND location like 'CART' AND
borrowers.categorycode like 'PT' group by biblio.biblionumber order by RANK
DESC;

Put in your valid values in the WHERE clause for the values in the single
quotes ''.

Sponsored-by: Halland county library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10154] Add Call number in the filter of most circulated items

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15075] New: Patron searches default parameters

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15075

Bug ID: 15075
   Summary: Patron searches default parameters
 Change sponsored?: ---
   Product: Koha
   Version: 3.18
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: je...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When we are browsing our patron names by letter is it possible filter that by
our home library? When we click on the filter it no longer browses by letter,
and if you click on the letter it loses the library filter. Also, when I search
for a patron who has more than one word in their last name in the circulation
search box it comes up with no results. Example: White Bear. It works if you
are in the patron screen but not from the main search box.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10154] Add Call number in the filter of most circulated items

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154

Eivin Giske Skaaren  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15062] Holds queue with Transport Cost Matrix will transfer item even if transfers disabled

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15062

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954

Marc Véron  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954

--- Comment #11 from Marc Véron  ---
Created attachment 44136
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44136=edit
Bug 14954 - (followup) Remove C4::Dates from holiday related files

Followup for comment #10

To test:
- Go to Home > Tools > Calendar
- Add, edit, delete the different types of holidays and exceptions
- git grep 'C4::Calendar' and test such files
- git grep daysBetween to make sure that this sub is not used
- prove t/Calendar.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15068] Get rid of warnings in members/summary-print.pl

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068

--- Comment #4 from Marc Véron  ---
(In reply to M. Tompsett from comment #3)
> (In reply to Marc Véron from comment #1)
> > - Use of uninitialized value in addition (+)
> >   at /usr/share/kohaclone/members/summary-print.pl line 87
> > 
> > - Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison (<=>)
> > at /usr/share/kohaclone/members/summary-print.pl line 103
> > 
> ...
> > - Go to a detail page with a member who has a lot of fines
> ...
> And items checked out, potentially overdue.
> 
> Triggering 47 and 61 is easy with the sample data after creating some fines
> on a user. Having difficulty triggering 87, which I feel will also trigger
> 103, if I have something checked out, but working on multiple bugs at once
> is hard. :)

- 87 is due to items with no replacementprice (NULL in db)
- 103 triggers with multiple checkouts with due dates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14998] Remove C4::Dates from installer and maintenance folders

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #4 from M. Tompsett  ---
(In reply to Marc Véron from comment #3)
> - Verify that the file is no longer used

While it isn't used as far as I can tell. Does a date get placed in description
still? If so, this script may still be handy to keep.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15059] Line break in html attribute

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059

--- Comment #5 from Fridolin SOMERS  ---
(In reply to Jonathan Druart from comment #3)
> Please provide a fix on top of bug 14955

Super, Bug 14955 fixes the facets includes.
This patch will only fix branchoverdues.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931

--- Comment #13 from Jonathan Druart  
---
Created attachment 44107
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44107=edit
Bug 14931: Fix test xt/author/valid_templates complaining on opac-topissues.tt

undef error - Undefined subroutine ::Languages::getlanguage called at
C4/Koha.pm line 250.

Test plan:
prove xt/author/valid-templates.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14100] Generic solution for language overlay

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100

--- Comment #62 from Jonathan Druart  
---
Created attachment 44108
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44108=edit
Bug 14100: Fix test xt/author/valid_templates complaining on opac-topissues.tt

undef error - Undefined subroutine ::Languages::getlanguage called at
C4/Koha.pm line 250.

Test plan:
prove xt/author/valid-templates.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #44107|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15059] Line break in html attribute

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059

--- Comment #6 from Fridolin SOMERS  ---
(In reply to Fridolin SOMERS from comment #5)
> (In reply to Jonathan Druart from comment #3)
> > Please provide a fix on top of bug 14955
> 
> Super, Bug 14955 fixes the facets includes.
> This patch will only fix branchoverdues.tt

In this case, this bug can be tested without bug 14955.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14100] Generic solution for language overlay

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100

--- Comment #63 from Jonathan Druart  
---
Created attachment 44109
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44109=edit
Bug 14100: Fix t/db_dependent/Items.t

prove t/db_dependent/Items.t
Undefined subroutine ::Languages::getlanguage called at C4/Items.pm line
1304.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15059] Line break in html attribute

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059

--- Comment #4 from Fridolin SOMERS  ---
Created attachment 44106
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44106=edit
Bug 15059 - Line break in html attribute in branchoverdues.tt

In circ/branchoverdues.tt, there is a line break inside href attribute.
This generates an attribute with a lot of spaces %20.

Test plan :
- at intranet go to ciculation module
- click on "Overdues with fines"
- look at links "Phone", "Notice" and "Considered lost"
=> Without patch the URL contains a lot of spaces
=> With patch the URL is correct

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15059] Line break in html attribute

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955

Marc Véron  changed:

   What|Removed |Added

  Attachment #43382|0   |1
is obsolete||

--- Comment #8 from Marc Véron  ---
Created attachment 44110
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44110=edit
Bug 14955: Don't double encode chars in the "Show more" link

Bug 13789 has fixed this issue for the facet links (select/unselect) but
not for the "Show more" facets link.

This patch reuses the "url" variable, generated for the facets, for
these links. A new "local_url" variable is used to build links for each
entry.

Test plan (for OPAC and intranet):
- Search for a very common term
- Filter the results using facets
- You should get more than 5 entries for a facet and 1 selected:
Author
 author 1
 author 2 [x] # Selected
 author 3
 author 4
 author 5
 Show more # you see this link if there is 5+ values for this facet
- Click on the Show more link
Without this patch, the url contains double-encoded characters and you
will certainly don't get any results
With this patch, you should get results.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131

--- Comment #27 from Jonathan Druart  
---
(In reply to Liz Rea from comment #26)
> cool I'll probably have a poke at that one unless you've already started on
> it.

I don't :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

--- Comment #109 from Frédéric Demians  ---
> Have you tested the patch?

Yes. My questions are not related to your patch WUI and result, but to your
implementation, your goals.

Somehwhere in the process, I take a look at the code, spend time on it, trying
to figure out how it works, how it has been done. Testing and QAing is all
about that.

I have mixed feeling, when I find duplicated code (for example). In opac/opac-
export.pl and catalog/export.pl:

SWITCH:
for ($recommendation) {
if (/^simple-dc-rdf/) {
($error,$marc) = marc2dcxml($marc, $recommendation, 0,
1, undef, undef, $resource_url , $formats);
$format = "dublin-core." . $formats;
last SWITCH; }
if (/^dc-rdf/) {
($error,$marc) = marc2dcxml($marc, $recommendation, 1,
1, undef, undef, $resource_url, $formats);
$format = "dublin-core." . $formats;
last SWITCH; }
if (/^dc-xml/) {
($error,$marc) = marc2dcxml($marc, $recommendation, $qualifier,
1, $root_element, $xsischemalocation, undef, undef);
$format = "dublin-core.xml";
last SWITCH; }
if (/^oai-dc/) {
($error,$marc) = marc2dcxml($marc, $recommendation);
$format = "dublin-core.xml";
last SWITCH; }
if (/^srw_dc/) {
($error,$marc) = marc2dcxml($marc, $recommendation);
$format = "dublin-core.xml";
last SWITCH; }
}


Or in Koha::Crosswalk::DublinCore.pm, line 242, you get:

if ( exists $self->{xsi_schemaLocation} ) {
$dataxml{'xsi_schemaLocation'} = $self->{xsi_schemaLocation};
}
if ( exists $self->{xsi_schemaLocation} ) {
$dataxml{'opt_namespace'} = $self->{opt_namespace};
}
if ( exists $self->{xsi_schemaLocation} ) {
$dataxml{'opt_namespace_url'} = $self->{opt_namespace_url};
}

Is it valid?

> With this module (Koha::Crosswalk::DublinCore) I can support more metada
> than the simple 15 DC elements (Element Set Version 1.1). This Simple DC is
> used for OAI and SRW in xml format. But also i can reproduce this other
> guidelines/recommendations:

How will you extend the semantic of the produced metadata with
MARC::Crosswalk::Dublincore? If you want more than the 15 DC elements, doesn't
it mean that you need a mean to improve, granularize the way Koha MARC record
is transformed. The current DC exported from Koha is not that good because (1)
it doesn't work for Unimarc, (2) it doesn't allow each library to tweak the
transformation from MARC to DC (the way it's done by OAI server).

> And RDF::Trine can serialize multiple rdf formats (rdf-json, rdf-xml,
> nquads, nquads-canonical, turtle) also give us the opportunity of storing
> the triples in databases; with RDF::Query we can perform queries with SPARQL

It's far beyond the scope of this patch. Open a new bug if you want, and name
it Semantic-Koha, or Sekoa.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #42340|0   |1
is obsolete||

--- Comment #63 from Alex Arnaud  ---
Created attachment 44111
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44111=edit
Bug 9223 [Follow-up] add unit tests for GetSupportList and GetSupportName
subroutine

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15059] Line break in html attribute

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059

Marc Véron  changed:

   What|Removed |Added

  Attachment #44106|0   |1
is obsolete||

--- Comment #7 from Marc Véron  ---
Created attachment 44112
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44112=edit
Bug 15059 - Line break in html attribute in branchoverdues.tt

In circ/branchoverdues.tt, there is a line break inside href attribute.
This generates an attribute with a lot of spaces %20.

Test plan :
- at intranet go to ciculation module
- click on "Overdues with fines"
- look at links "Phone", "Notice" and "Considered lost"
=> Without patch the URL contains a lot of spaces
=> With patch the URL is correct

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15059] Line break in html attribute

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

--- Comment #64 from Alex Arnaud  ---
Fixed last patch.

A rebase against master is coming soon

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14722] Refactor the catalogue export tool (command-line tools/export.pl does not work anymore. Use misc/export_catalogue.pl instead)

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722

Paul Poulain  changed:

   What|Removed |Added

Summary|Refactor the export tool|Refactor the catalogue
   ||export tool (command-line
   ||tools/export.pl does not
   ||work anymore. Use
   ||misc/export_catalogue.pl
   ||instead)
 CC||paul.poul...@biblibre.com
   Severity|enhancement |new feature

--- Comment #18 from Paul Poulain  ---
Updating title and importance to have the release notes automatically filled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14100] Generic solution for language overlay

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100

--- Comment #64 from Jonathan Druart  
---
Created attachment 44119
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44119=edit
Bug 14100: Fix Search.t tests

So, this one is VERY weird, let me try to explain what I have
understood.

Bisecting using run prove t/db_dependent/Search.t, I have found that the
following commit make the test fail:
  commit 0f63f89f66e40cc01ef02da3654fcfb404c9001d
Bug 14100: Generic solution for language overlay - Item types
The error is
  DBI bind_columns: invalid number of arguments: got handle + 0, expected
handle + between 1 and -1
  Usage: $h->bind_columns(\$var1 [, \$var2, ...]) at
/usr/lib/i386-linux-gnu/perl5/5.20/DBI.pm line 2065.

Note that the interface (admin/itemtypes.pl) which calls the same
subroutine with the same parameter (style => 'array') works great.

The problem comes from the change in C4::Search::searchResults, if I
only apply the change done to this subroutine on 0f63f89f^1, I reproduce
the issue.

Looking closely at how %itemtypes is built, we could actually call
GetItemTypes with the style => 'hash' to get exactly what we want.
The following piece prove it for you:
use Test::More;
use C4::Koha;
my $i = GetItemTypes;
my $j = GetItemTypes(style => 'array');
my %itemtypes;
for my $itemtype ( @$j ) {
$itemtypes{ $itemtype->{itemtype} } = $itemtype;
}
is_deeply( \%itemtypes, $i);

So changing the code accordingly and just forget this last hour...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15072] Breadcrumbs and titles inconsistent in Label creator

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072

--- Comment #5 from Marc Véron  ---
Created attachment 44120
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44120=edit
Bug 14722: CSV is only available for biblio records

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15072] Breadcrumbs and titles inconsistent in Label creator

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #44120|0   |1
is obsolete||

--- Comment #6 from Marc Véron  ---
Comment on attachment 44120
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44120
Bug 14722: CSV is only available for biblio records

Sorry, i messed something whil trying to attach multiple patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #44008|0   |1
is obsolete||
  Attachment #44100|0   |1
is obsolete||

--- Comment #9 from Jonathan Druart  
---
Created attachment 44121
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44121=edit
Bug 14977 - Remove C4::Dates from files t/db_dependent/*.t

This patch removes C4::Dates from following files:

-  t/db_dependent/Budgets.t
-  t/db_dependent/Holds.t
-  t/db_dependent/Koha_template_plugin_KohaDates.t
-  t/db_dependent/Log.t
-  t/db_dependent/NewsChannels.t

To test:
- First run all tests above
- Apply patch
- Then run tests again. The results should be the same.
  (Note: I get 2 fails with NewsChannels.t, they are the same with
   and without patch).

Signed-off-by: Bernardo Gonzalez Kriegel 

NewsChanell pass for me before patch, no after.
Followup follows :)
Rest of tests pass

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977

--- Comment #10 from Jonathan Druart  
---
Created attachment 44122
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44122=edit
Bug 14977 - Followup to fix issue with NewsChannels.t

The problem was that get_opac_new returns dates already syspref-formatted.

To test:
- Apply patch
- Verify that t/db_dependent/NewsChannels.t does not fail.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t

2015-10-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/