[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Robin Sheat  changed:

   What|Removed |Added

 CC||ro...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960

Marc Véron  changed:

   What|Removed |Added

  Attachment #43310|0   |1
is obsolete||

--- Comment #5 from Marc Véron  ---
Created attachment 0
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=0=edit
Bug 14960 - Remove C4::Dates from files in misc/cronjobs

This patch removes C4::Dates from following files:

- misc/cronjobs/batch_anonymise.pl
- misc/cronjobs/cleanup_database.pl
- misc/cronjobs/gather_print_notices.pl
- misc/cronjobs/serialsUpdate.pl
- misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
-  misc/cronjobs/overdue_notices.pl
-  misc/cronjobs/staticfines.pl

To test:
- Carefully review code changes.
- Verify that the cronjobs behave as before.

Amended to make patch apply ( 04.11.2015 / mv   :-)  )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15124] Allow SIP2 passwordless operation

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15124

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Hm, I am surprised by this as we have libraries operating self checks without a
pin/password entry from the user.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #61 from Robin Sheat  ---
Would URI::Escape work, which is already a Koha dependency?

https://metacpan.org/pod/URI::Escape

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #60 from Robin Sheat  ---
(In reply to Kyle M Hall from comment #1)
> Created attachment 24753 [details] [review]
> Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal
> 
> This patch adds the ability for a logged in user to pay fines and
> fees from the OPAC via PayPal.

Kyle, if you're adding a dependency, you need to read this:

http://wiki.koha-community.org/wiki/Building_Debian_Dependencies/Dependency_Guidelines

or the email equivalent that went out in May: 

http://lists.koha-community.org/pipermail/koha-devel/2015-May/041464.html

This won't be able to go into master until I package URL::Encode and Debian
allows it to be added, which may (or may not) take some time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985

--- Comment #4 from Marc Véron  ---
Hmm, signed-off but no signed-off patch attached?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #43285|0   |1
is obsolete||

--- Comment #6 from Brendan Gallagher  ---
Created attachment 44439
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44439=edit
Remove C4::Dates from files in folder C4/*.pm (part one)

This patch removes C4::Dates from following files in folder C4:

- C4/Members.pm
- C4/Reserves.pm
- C4/Search.pm
- C4/Utils/DataTables.pm
- C4/Utils/DataTables/Members.pm
- C4/VirtualShelves/Page.pm

To test:
 -run tests as appropriate,
- have a close look at the code changes
- try to find regressions

http://bugs.koha-community.org/show_bug.cgi?id=14985

Signed-off-by: Brendan Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870

Marc Véron  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #5 from Marc Véron  ---
As of today depending on:

Need Sign-off:
14954
14946
14960
14969

Signed-off
14985
14965
14998
14956

I switch to "Needs sign-off"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m

--- Comment #5 from Brendan Gallagher  ---
Marc - my fault - got distracted half way through the sign-off - I will send a
patch up in a minute

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #24 from Katrin Fischer  ---
Hi Tom, this patch has missed the feature slush, which means it was not 'passed
QA' by a certain date. It won't be included in 3.22.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969

Marc Véron  changed:

   What|Removed |Added

  Attachment #43182|0   |1
is obsolete||

--- Comment #4 from Marc Véron  ---
Created attachment 1
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=1=edit
Bug 14969 - Remove C4::Dates from serials/*.pl files

Bug to remove C4::Dates from files:

- serials/acqui-search-result.pl
- serials/checkexpiration.pl
- serials/routing-preview.pl
- serials/routing.pl
- serials/serial-issues.pl
- serials/serials-collection.pl
- serials/serials-edit.pl
- serials/showpredictionpattern.pl
- serials/subscription-add.pl
- serials/subscription-detail.pl
- serials/subscription-history.pl
- serials/subscription-renew.pl

To test:
- Go to Home > Serials
- Add, edit serials and routing lists with focus on date entry and display
- Verify that information for serials on item detail pages look fine in OPAC
  and staff client as well
- Try to find regressions

Amended to make it apply ( serials/checkexpiration.pl )  04.11.2015 / mv

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15103] Import Borrowers Performance Improvement

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15103

cnorthcott.w...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15103] Import Borrowers Performance Improvement

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15103

--- Comment #2 from cnorthcott.w...@gmail.com ---
Created attachment 3
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3=edit
Bug 15103: Import Borrowers Performance Improvement

Improves the performance of importing borrowers in batches from file
by by switching out resultset calls for more direct SQL queries and
using hash lookups instead of repeated DB lookups.

Test Plan:
1) Prepare NTYprof
(http://wiki.koha-community.org/wiki/Profiling_with_Devel::NYTProf)
   or procure a stopwatch (stopwatch will be simpler but less accurate).
2) Download the PatronDataCSV1.csv and PatronDataCSV2.csv attachements from
   the bug page or organise your own csv's with data for 1000 or more
   patrons to import.
3) Navigate to Home > Tools > Import Patrons in the Koha Intranet
   (http://demo-intra.mykoha.co.nz/cgi-bin/koha/tools/import_borrowers.pl)
4) Click the "Browse..." button and select PatronDataCSV1.csv or your
equilient.
5) If you are using a stopwatch, prepare your stopwatch so that you will
   start counting seconds from the point you click the button in the next
   step.
6) Scroll to the bottom of the page and click the "Import" button
(simultaneously
   start your stopwatch if using one)
7) When the page appears showing completion of the import, stop your stopwatch
   and check the time or navigate to the folder you have set NYTProf to output.
8) Record the runtime. This is the pre-optimisation time.
9) Apply this patch.
9) Repeat steps 2-7 of this testplan with the patch applied and use the
   PatronDataCSV2.csv this time around. This will yield the post-optimisation
   time.
10) Compare the pre-optimisation time and post optimisation time. The second
post-optimisation time should be faster.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14532] koha-dump shouldn't back backup Zebra indexes by default

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14532] koha-dump shouldn't back backup Zebra indexes by default

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #41098|0   |1
is obsolete||

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 2
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2=edit
Bug 14532: Add --exclude-indexes switch to koha-dump

This patch changes the default behaviour of koha-dump to make the inclusion
of Zebra indexes on the dump optional. It does so by introducing a new option
switch that allows to have the previous behaviour in place.

To test:
- Run
  $ koha-dump your_instance
- Save a copy of the dump files
- Apply the patch / extract the koha-dump script
- Run the new one:
  $ koha-dump your_instance
=> SUCCESS: Verify the contents of the dump are the same
   (i.e. it includes /var/lib/koha/your_instance)
- Run with the new switch:
  $ koha-dump --exclude-indexes your_instance
=> SUCCESS: The dump does not contain stuff from /var/lib/koha/your_instance
- Go through the rest of the new option switches
  -h | --help
  -q | --quiet
=> SUCCESS: They work as expected.
- Sign off :-D

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15104] Batch Record Modification Performance Improvement

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15104

cnorthcott.w...@gmail.com changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15104] Batch Record Modification Performance Improvement

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15104

--- Comment #2 from cnorthcott.w...@gmail.com ---
Created attachment 6
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6=edit
Bug 15104: Batch Record Modification Performance Improvement

Performance improvements to speed of the Modify Records by decreasing
unnecessary
progress reporting of success messages and data fetching while logging.

Test Plan:
1) Prepare NTYprof
(http://wiki.koha-community.org/wiki/Profiling_with_Devel::NYTProf)
   or procure a stopwatch (stopwatch will be simpler but less accurate).
2) Ensure you have a decent number of records in your Koha system (>500) if you
are
   lacking records to modify in your database you can import some from files
   found here: http://wiki.koha-community.org/wiki/Free_sample_MARC_data
3) Prepare a file with biblionumbers to modify. You can create a file
containing
   all record  called ItemBarcodes.txt in the current folder using the
   following command from the machine running Koha:
   echo 'select biblionumber from biblio' | sudo koha-mysql kohadev >>
BiblioNums.txt
4) Navigate to Home > Tools > MARC modification templates in the Koha Intranet.
5) Create a new template called ModRec1.
6) Add a new action using:
   Select 'Add/Update' from the drop down box and in the field(s) boxes enter
'090'
   (in the first box) and 'a' (in the second box) and 'Mod1' in the value
field.
   Then click 'Add Action'
7) Create a new template called ModRec2.
8) Add a new action using:
   Select 'Add/Update' from the drop down box and in the field(s) boxes enter
'090'
   (in the first box) and 'a' (in the second box) and 'Mod2' in the value
field.
   Then click 'Add Action'
9) Navigate to Home > Tools > Batch Modify Records in the Koha Intranet
10) Click the 'Browse...' button and select BiblioNums.txt or your equilient.
11) Select ModRec1 under Use MARC Modification Template.
12) Click the 'Continue' button and scroll to the bottom of the page.
13) If you are using a stopwatch, prepare your stopwatch so that you will
   start counting seconds from the point you click the button in the next
   step.
14) Click the 'Modify Selected Records' button (simultaneously start your
stopwatch if using one)
15) When the page appears showing completion of the change, stop your stopwatch
and check the time or navigate to the folder you have set NYTProf to
output.
16) Record the runtime. This is the pre-optimisation time.
17) If this is the pre-patch test then you should see lots of messages like:
"The biblio  has successfully been modified."
If this is the post-patch test then you should see only:
"All records have successfully been modified!"
and a link to do another record modification.
18) Apply this patch.
19) Repeat steps 9-12 of this testplan with the patch applied, replacing
ModRec1
in step 11 with ModRec2. This will yield the post-optimisation time. If you
are using NYTProf you will need to apply the -d:NYTProf shebang to the file
again.
20) Compare the pre-optimisation time and post optimisation time. The second
post-optimisation time should be faster.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15103] Import Borrowers Performance Improvement

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15103

--- Comment #3 from cnorthcott.w...@gmail.com ---
Created attachment 4
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4=edit
CSV file containing patron data for import

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15103] Import Borrowers Performance Improvement

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15103

--- Comment #4 from cnorthcott.w...@gmail.com ---
Created attachment 5
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5=edit
CSV file containing patron data for import

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15107] Batch Patron Deletion (Trash) Performance Improvement

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15107

--- Comment #1 from cnorthcott.w...@gmail.com ---
Created attachment 7
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7=edit
Bug 15107: Batch Patron Deletion (Trash) Performance Improvement

Batch Patron Modification has a fairly long run/load time. I have attempted
to improve the runtime of the Batch Patron Modification tool by switching
out more expensive resultset calls for faster more direct SQL queries.

Test Plan:
1) Prepare NTYprof
(http://wiki.koha-community.org/wiki/Profiling_with_Devel::NYTProf)
   or procure a stopwatch (stopwatch will be simpler but less accurate).
2) Ensure you have a decent number of patrons in your Koha system (>500) if you
are
   lacking patrons to modify in your database you can import 1000 using the
   PatronDataCSV.csv attachement and the Import Patrons tool before moving to
   step 3.
4) Navigate to Home > Tools > Batch Patrons Deletion in the Koha Intranet
5) Check the box beside the "Verify you want to delete patrons" box
6) Under "who have not borrowed since" enter todays date
7) You should get a message saying:
   "1000 patrons will be deleted
0 checkout history will be anonymized"
If not please go back to step 2 and import patrons using the
PatronDataCSV.csv
8) Select the radio button option beside "Move these patrons to the trash"
9) If you are using a stopwatch, prepare your stopwatch so that you will
   start counting seconds from the point you click the button in the next
   step.
10) Click the "Finsh" button (simultaneously start your stopwatch if using one)
11) When the page appears showing completion of the change, stop your stopwatch
and check the time or navigate to the folder you have set NYTProf to
output.
12) Record the runtime. This is the pre-optimisation time.
13) Apply this patch.
14) Repeat steps 2-12 of this testplan with the patch applied. This will yield
the post-optimisation time.
15) Compare the pre-optimisation time and post optimisation time. The second
post-optimisation time should be faster.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15107] Batch Patron Deletion (Trash) Performance Improvement

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15107

--- Comment #2 from cnorthcott.w...@gmail.com ---
Created attachment 8
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8=edit
Patron data to import for testing

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15107] Batch Patron Deletion (Trash) Performance Improvement

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15107

cnorthcott.w...@gmail.com changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14157] EnhancedMessagingPreferences and Notices tab

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15123] Acquisition: Better context for "Transferred from..." to avoid ambiguity in translation

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15123

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14202] Unexpected parameter for window.open in marc21_linking_section plugin

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14202

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #41004|0   |1
is obsolete||

--- Comment #2 from Frédéric Demians  ---
Created attachment 44451
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44451=edit
Bug 14202: Unexpected parameter for window.open in marc21_linking_section.pl

The builder of this plugin includes a window.open call with the name
parameter: \"marc21_field_7\"+ event.data.id +\"\"
Note that this is not the name of the new window.
This trivial patch adjusts this unusual name by tag_editor like other
plugins.

Test plan:
Attach marc21_linking_section to 773$9.
Click on the Tag editor button.
If it opens, it still works :)
Note that the name of the popup is still:
Koha > Cataloguing > plugin for links

Signed-off-by: Fredreic Demians 
  Plugin still working, with a valid pop-pup window id.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15092] item type descriptions not showing if no logo

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15092] item type descriptions not showing if no logo

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #44366|0   |1
is obsolete||

--- Comment #10 from Katrin Fischer  ---
Created attachment 44453
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44453=edit
[PASSED QA] Bug 15092: (followup) Descriptions not show for search categories

If we have some item types in search categories, description
is not show in opac advanced search

To test:
1) Add some item type to a search category
2) Go to OPAC > Advanced search
empty description for that category
3) Apply the patch
4) Repeat 2), description must be present

Signed-off-by: Marc Véron 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15092] item type descriptions not showing if no logo

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092

--- Comment #11 from Katrin Fischer  ---
This is better, but still one small glitch - if you have no OPAC description
set, it should fall back to the staff description like we usually do. But maybe
this should go on a separate bug, so this can go in as is as fixing the bigger
problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15123] Acquisition: Better context for "Transferred from..." to avoid ambiguity in translation

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15123

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #44357|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 9
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9=edit
[SIGNED-OFF]Bug 15123: Acquisition: Better context for "Transferred from..." to
avoid ambiguity in translation

This patch moves the word "basket" out of the  tags to have a better context
for translation.

To test:
- Transfer an order from one basket to another basket
- Verify that "basket" is detached from the strings "Transferred to" rsp
  "Transferred from" by th  tag (See screenshot)
- Apply patch
- Verify that the word "basket" is now otuside the  tags

Signed-off-by: Hector Castro 
Works as advertised. Tested with es-ES

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14157] EnhancedMessagingPreferences and Notices tab

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157

Marc Véron  changed:

   What|Removed |Added

  Attachment #44437|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 44450
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44450=edit
Bug 14157 : Notices tab in the patron record should not depend on
EnhancedMessagingPreferences to display

Overdue and Hold notices can be sent even if EnhancedMessagingPreference is set
to "Don't Allow", so Notices tab have to be visible in all cases.

Test plan :
  - without patch :
- set EnhancedMessagingPreference to "Don't Allow" and go to patron record
: there is no Notices tab
- set EnhancedMessagingPreference to "Allow" and og to patron record :
there is a Notices tab

  - apply this patch :
- go to patron record, you cas see a Notices tab
- change the value of EnhanceMessagingPreferences, Notices tab is always
visible.

Followed test plan, works as expected
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15092] item type descriptions not showing if no logo

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092

Katrin Fischer  changed:

   What|Removed |Added

   Severity|blocker |critical
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15130] useless unitialization warnings when updating authorities

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15130

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #44428|0   |1
is obsolete||

--- Comment #2 from Frédéric Demians  ---
Created attachment 44452
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44452=edit
Bug 15130 useless unitialization warnings when updating authorities

Signed-off-by: Frederic Demians 
  Fixes a trivial coding error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15130] useless unitialization warnings when updating authorities

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15130

Frédéric Demians  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14202] Unexpected parameter for window.open in marc21_linking_section plugin

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14202

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955

--- Comment #13 from Katrin Fischer  ---
I still have a bit of a problem reproducing the issue, but I can verify the
change in the URL now and things seem to work like they should. Also trusting
the other testers here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #10 from Katrin Fischer  ---
Hm, wondering - why not remove the semicolon from the search term as we do in
other places?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not functional

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not functional

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #44002|0   |1
is obsolete||

--- Comment #15 from Katrin Fischer  ---
Created attachment 44459
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44459=edit
[PASSED QA] Bug 14781 - Creation of barcode types 2of5 not functional

This patch fixes the rendering of "COOP2of5" or "Industrial2of5" barcodes in
the label creator module.

To test:
- Create a label layout with COOP2of5 barcode type
- Create labels (make sure that the items's barcode values are numeric only!)
- Export batch and download PDF.

Without patch:
- No barcodes rendered
With patch
- Barcodes should render as expected. Test for both barcode types.

Signed-off-by: Bernardo Gonzalez Kriegel 
Works as described, tested both formats.
Non digit barcode is not printed.

No koha-qa errors, no t/ & xt/ errors

Signed-off-by: Katrin Fischer 
Note: To be printed, barcode should be numerical.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15129] Koha::object for issuing rules

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15120] runreport.pl doesn't allow custom subjects anymore

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15120

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #44351|0   |1
is obsolete||

--- Comment #2 from Frédéric Demians  ---
Created attachment 44461
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44461=edit
Bug 15120 - runreport.pl cronjob doesn't allow custom subjects anymore

To test, well do something like

misc/cronjobs/runreport.pl --subject="My fancy subject!"
--to=y...@youraddress.com 1
where 1 is the number of your favourite saved report.

Success is your email arrives with the subject "My fancy subject!" Failure is
(with --subject defined) you get either the description of the report, or "Koha
saved report" as the subject. This is success without --subject defined.

Signed-off-by: Frederic Demians 
  Bug repeatable and fixed by this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15120] runreport.pl doesn't allow custom subjects anymore

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15120

Frédéric Demians  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15112] Make greybox consistent size across label and patron card creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15112

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #44365|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 44460
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44460=edit
[PASSED QA] bug 15112 - Make greybox consistent size across label/card creator

Also fixes minor issue with buttons stacking on patroncards/edit-batch
and labels/label-manage

To test:

Export a batch every way you can:

multiple together from label/label-manage
individual items from labels/label-edit-batch
selected items from labels/label-edit-batch
export full batch from labels/label-edit-batch

multiple together from patroncards/manage
individual cards from patroncards/manage
individual cards from patroncards/edit-batch
selected cards from patroncards/edit-batch
export full batch from patroncards/edit-batch

Also notice that before this patch, the delete and export buttons
were stacking on the table rows, and  that now they are not doing
that anymore. It may take a force refresh to see the behaviour and
the change.

Signed-off-by: Marc Véron 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15112] Make greybox consistent size across label and patron card creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15112

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14157] EnhancedMessagingPreferences and Notices tab

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14157] EnhancedMessagingPreferences and Notices tab

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #44450|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 44457
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44457=edit
[PASSED QA] Bug 14157 : Notices tab in the patron record should not depend on
EnhancedMessagingPreferences to display

Overdue and Hold notices can be sent even if EnhancedMessagingPreference is set
to "Don't Allow", so Notices tab have to be visible in all cases.

Test plan :
  - without patch :
- set EnhancedMessagingPreference to "Don't Allow" and go to patron record
: there is no Notices tab
- set EnhancedMessagingPreference to "Allow" and og to patron record :
there is a Notices tab

  - apply this patch :
- go to patron record, you cas see a Notices tab
- change the value of EnhanceMessagingPreferences, Notices tab is always
visible.

Followed test plan, works as expected
Signed-off-by: Marc Véron 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15129] Koha::object for issuing rules

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15129

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #2 from Marc Véron  ---
Testing with "All libraries" selected.

Test 1:
---
- In dropdown box select a patron category that not yet has a rule
  e.g. Teacher (T)
- Fill in some fields
- Click "Save"
Result: New row with values for this category, values saved OK


Test 2:
--
- Click on "Edit" for a I want to change (at the right)
- Fill in and/or change some fields
- Save

Result for editing category from Test 1:
DBIx::Class::Row::update_or_insert(): Duplicate entry '*-T-*' for key 'PRIMARY'
at /usr/share/kohaclone/Koha/Object.pm line 109

Same error with other categories, e.g. for Juvenile (J)
DBIx::Class::Row::update_or_insert(): Duplicate entry '*-J-*' for key 'PRIMARY'
at /usr/share/kohaclone/Koha/Object.pm line 109

Same error while editing "All"
DBIx::Class::Row::update_or_insert(): Duplicate entry '*-*-*' for key 'PRIMARY'
at /usr/share/kohaclone/Koha/Object.pm line 109

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15133] runreport.pl badly encode accented characters

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15133

Frédéric Demians  changed:

   What|Removed |Added

 Depends on||15120


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15120
[Bug 15120] runreport.pl doesn't allow custom subjects anymore
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15120] runreport.pl doesn't allow custom subjects anymore

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15120

Frédéric Demians  changed:

   What|Removed |Added

 Blocks||15133


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15133
[Bug 15133] runreport.pl badly encode accented characters
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15098] Itemtype description missing from facets for itypes in a search group

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15098

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15098] Itemtype description missing from facets for itypes in a search group

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15098

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #44368|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 44455
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44455=edit
[PASSED QA] Bug 15098: Itemtype description missing from facets for itypes in a
search group

This patch adds a second variable to hold item types info
just for facets.

In case we have an item type in a search category, it's description
is removed from GetItemTypesCategorized, which is good for advanced
search, but no for facets

A second var is needed which holds all item type info.

To test:
On top of Bug 15092 patches (no really needed, but I write this on top
of them)
1) Add an item type to a search group
2) Do a search in opac, in facets will see only item type code,
no description, for that item type
3) Apply the patch
4) Repeat search, now description must be present

Followed test plan including translated descriptions. Works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15123] Acquisition: Better context for "Transferred from..." to avoid ambiguity in translation

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15123

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15123] Acquisition: Better context for "Transferred from..." to avoid ambiguity in translation

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15123

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #9|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 44456
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44456=edit
[PASSED QA] Bug 15123: Acquisition: Better context for "Transferred from..." to
avoid ambiguity in translation

This patch moves the word "basket" out of the  tags to have a better context
for translation.

To test:
- Transfer an order from one basket to another basket
- Verify that "basket" is detached from the strings "Transferred to" rsp
  "Transferred from" by th  tag (See screenshot)
- Apply patch
- Verify that the word "basket" is now otuside the  tags

Signed-off-by: Hector Castro 
Works as advertised. Tested with es-ES

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15083] acqui/currency.pl is unused

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15083

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15083] acqui/currency.pl is unused

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15083

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #44158|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 44458
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44458=edit
[PASSED QA] Bug 15083: Remove acqui/currency.pl

This script has scary FIXMEs and can be removed.
It is never called from Koha code.
On the way, this patch remove the C4::Budgets::ModCurrencies subroutine,
which was only called from this script.

Test plan:
  git grep 'acqui/currency.pl
and
  git grep ModCurrencies
should not return anything.

Signed-off-by: Bernardo Gonzalez Kriegel 
No more ModeCurrencies, no call to acqui/currency.pl
No errors

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15133] New: runreport.pl badly encode accented characters

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15133

Bug ID: 15133
   Summary: runreport.pl badly encode accented characters
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: gmcha...@gmail.com
  Reporter: frede...@tamil.fr
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

/misc/cronjobs/runreport.pl send badly encoded email in text/csv (ok in HTML):
both subject & message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #44110|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 44454
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44454=edit
[PASSED QA] Bug 14955: Don't double encode chars in the "Show more" link

Bug 13789 has fixed this issue for the facet links (select/unselect) but
not for the "Show more" facets link.

This patch reuses the "url" variable, generated for the facets, for
these links. A new "local_url" variable is used to build links for each
entry.

Test plan (for OPAC and intranet):
- Search for a very common term
- Filter the results using facets
- You should get more than 5 entries for a facet and 1 selected:
Author
 author 1
 author 2 [x] # Selected
 author 3
 author 4
 author 5
 Show more # you see this link if there is 5+ values for this facet
- Click on the Show more link
Without this patch, the url contains double-encoded characters and you
will certainly don't get any results
With this patch, you should get results.

Signed-off-by: Marc Véron 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14157] EnhancedMessagingPreferences and Notices tab

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157

--- Comment #5 from Katrin Fischer  ---
Hm, I see it also checkes for "sentnotices".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14157] EnhancedMessagingPreferences and Notices tab

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14157

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
This is a small change in behaviour, but as we have no preference for
"UsesOverdueNotices" it's a quick fix. The tab can still be hidden with jQuery.
It would be nice to have a follow up adding an id to the element, to make it
even easier.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15112] Make greybox consistent size across label and patron card creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15112

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14939] OAI Server classes must be modularized

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #44371|0   |1
is obsolete||

--- Comment #8 from Frédéric Demians  ---
Created attachment 44438
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44438=edit
Bug 14939 Modularize OAI Server existing classes

Koha OAI server has been done in one unique .pl file because there
wasn't any object model or rules in the Koha project when it has been
coded. This patch modularized existing classes, putting each class in a
separate file in Koha::OAI::Server namespace. UT begining.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15092] item type descriptions not showing if no logo

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Blocks||15098


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15098
[Bug 15098] Itemtype description missing from facets for itypes in a search
group
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15098] Itemtype description missing from facets for itypes in a search group

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15098

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |bgkrie...@gmail.com
   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff
 Depends on||15092


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092
[Bug 15092] item type descriptions not showing if no logo
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15112] Make greybox consistent size across label and patron card creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15112

Marc Véron  changed:

   What|Removed |Added

  Attachment #44304|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 44365
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44365=edit
bug 15112 - Make greybox consistent size across label/card creator

Also fixes minor issue with buttons stacking on patroncards/edit-batch
and labels/label-manage

To test:

Export a batch every way you can:

multiple together from label/label-manage
individual items from labels/label-edit-batch
selected items from labels/label-edit-batch
export full batch from labels/label-edit-batch

multiple together from patroncards/manage
individual cards from patroncards/manage
individual cards from patroncards/edit-batch
selected cards from patroncards/edit-batch
export full batch from patroncards/edit-batch

Also notice that before this patch, the delete and export buttons
were stacking on the table rows, and  that now they are not doing
that anymore. It may take a force refresh to see the behaviour and
the change.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15112] Make greybox consistent size across label and patron card creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15112

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15124] Allow SIP2 passwordless operation

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15124

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15124] New: Allow SIP2 passwordless operation

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15124

Bug ID: 15124
   Summary: Allow SIP2 passwordless operation
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: SIP2
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

Some SIP self check machines allow the use of a "passwordless" mode where the
patron does not need to enter a pin or password to use the SC. Koha cannot
handle this situation. Koha will assume an empty password field is an invalid
password unless the patron's password is NULL in the database.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14805] Allow the deletion of multiple patron card batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #19 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Joonas and Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15081] TestBuilder should not handle the transaction

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081

--- Comment #7 from Kyle M Hall  ---
Created attachment 44388
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44388=edit
[PASSED QA] Bug 15081: (followup) Make test files using TestBuilder handle
their transactions

This trivial patch introduces the code needed on the test files so they handle
the DB transaction instead of relying on the (removed) transaction
started/rolled back
by TestBuilder.

Tested all of the files before and after applying the patch, resultes are the
same.
(Pass exept of t/db_dependent/Barcodes_ValueBuilder.t, this has the same
error).
Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15081] TestBuilder should not handle the transaction

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081

--- Comment #8 from Kyle M Hall  ---
Created attachment 44389
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44389=edit
Bug 15081 [QA Followup] - Fix issue with Barcodes_ValueBuilder.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #14 from Josef Moravec  ---
I have this setup:
First day of week monday
Date format dd/mm/


When I try to add a range holiday from 01/01/2015 to 10/01/2015 and I end with
this days set close:

01/01/2015
02/01/2015
03/01/2015
04/01/2015
05/01/2015
06/01/2015
07/01/2015
08/01/2015
09/01/2015
10/01/2015
01/11/2015
02/11/2015
03/11/2015
04/11/2015
24/12/2015
25/12/2015
26/12/2015
27/12/2015
28/12/2015
29/12/2015
30/12/2015
31/12/2015

The dates for exceptions are formatted in ISO, not in right date format (see
attachment)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15036] Closeing and reopening a basket should not alter status of completed orders

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15036

--- Comment #4 from Katrin Fischer  ---
Koha Team Lyon3 - is this a 'sign off'? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #151 from Kyle M Hall  ---
Created attachment 44400
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44400=edit
Bug 11431 [QA Followup] - Unit Tests

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #158 from Kyle M Hall  ---
Created attachment 44409
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44409=edit
Bug 11431 [QA Followup] - Add ability to edit audio alerts

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #156 from Kyle M Hall  ---
Created attachment 44407
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44407=edit
Bug 11431 [QA Followup] - Always allow audio alerts for audio alerts editor
page

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #155 from Kyle M Hall  ---
Created attachment 44405
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44405=edit
Bug 11431 [QA Followup] - Fix alter precedences on delete

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #149 from Kyle M Hall  ---
Created attachment 44398
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44398=edit
Bug 11431 - Update UsageStats.pm

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #154 from Kyle M Hall  ---
Created attachment 44404
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44404=edit
Bug 11431 [QA Followup] - Hard code list of sounds for security

The sounds directory is no longer available for listing for security.
It is better and safer to hard code the list of sounds.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #152 from Kyle M Hall  ---
Created attachment 44401
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44401=edit
Bug 11431 [QA Followup] - Simplify audio_alert_id to just id

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Julian Maurice  changed:

   What|Removed |Added

  Attachment #43995|0   |1
is obsolete||

--- Comment #230 from Julian Maurice  ---
Created attachment 44381
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44381=edit
Bug 13799: Allow to set Mojolicious secret in $KOHA_CONF

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Julian Maurice  changed:

   What|Removed |Added

  Attachment #44185|0   |1
is obsolete||

--- Comment #233 from Julian Maurice  ---
Created attachment 44384
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44384=edit
Bug 13799: Rename t/.../v1/borrowers.t to t/.../v1/patrons.t

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Julian Maurice  changed:

   What|Removed |Added

  Attachment #43997|0   |1
is obsolete||

--- Comment #232 from Julian Maurice  ---
Created attachment 44383
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44383=edit
Bug 13799: Reword 'borrower' to 'patron'

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Julian Maurice  changed:

   What|Removed |Added

  Attachment #43996|0   |1
is obsolete||

--- Comment #231 from Julian Maurice  ---
Created attachment 44382
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44382=edit
Bug 13799: Change 'required' value type from string to boolean

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Julian Maurice  changed:

   What|Removed |Added

  Attachment #44285|0   |1
is obsolete||

--- Comment #239 from Julian Maurice  ---
Comment on attachment 44285
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44285
Bug 13799: Update dependencies

Patch moved to bug 15126

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15126] REST API: Use newer version of Swagger2

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126

--- Comment #4 from Julian Maurice  ---
Created attachment 44386
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44386=edit
Dependency tree for Swagger2 0.60

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Julian Maurice  changed:

   What|Removed |Added

  Attachment #43999|0   |1
is obsolete||

--- Comment #236 from Julian Maurice  ---
Comment on attachment 43999
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43999
[PASSED QA] Bug 13799 - Followup: Refactor spec file

Patch moved to bug 15126

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Julian Maurice  changed:

   What|Removed |Added

  Attachment #44000|0   |1
is obsolete||

--- Comment #237 from Julian Maurice  ---
Comment on attachment 44000
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44000
[PASSED QA] Bug 13799: Followup of "Followup: Refactor spec file"

Patch moved to bug 15126

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Julian Maurice  changed:

   What|Removed |Added

  Attachment #44001|0   |1
is obsolete||

--- Comment #238 from Julian Maurice  ---
Comment on attachment 44001
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44001
[PASSED QA] Bug 13799: Followup of "Followup: x-mojo-controller deprecation"

Patch moved to bug 15126

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15127] (Plack on packages) plack.psgi should check for changed files

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15127

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords||rel_3_22_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11678] Gather print notices: send files by email

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #17 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Julian and Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9303] relative's checkouts in the opac

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Patch doesn't apply

--- Comment #256 from Tomás Cohen Arazi  ---
I'm sorry, could you please rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15081] TestBuilder should not handle the transaction

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15081] TestBuilder should not handle the transaction

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #44284|0   |1
is obsolete||
  Attachment #44286|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall  ---
Created attachment 44387
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44387=edit
[PASSED QA] Bug 15081: Take transaction handling out from TestBuilder

This patch removes transaction handling code from TestBuilder.
It fixes the TestBuilder.t to handle the transaction on its own.

Verify that t/db_dependent/TestBuilder.t passes.

Followed test plan, TestBuilder.t passes
Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954

--- Comment #15 from Josef Moravec  ---
Created attachment 44390
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44390=edit
Exception dates formatted in ISO

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15036] Closeing and reopening a basket should not alter status of completed orders

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15036

Koha Team Lyon 3  changed:

   What|Removed |Added

 CC||k...@univ-lyon3.fr

--- Comment #3 from Koha Team Lyon 3  ---
Without the patch : 
I have added a new baskest with 2 orders, closed this basket, received one of
the order. Orders status for this basket are "complete" and "ordered". I have
re-opened the basket : ordered status are both "new".

With the patch : 
I redone exactly the same stages, but afer reopening the basket, ordered status
are  "complete" and "ordered".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10744] ExpireReservesMaxPickUpDelay has minor workflow conflicts with hold(s) over report

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744

--- Comment #3 from Olli-Antti Kivilahti  ---
Created attachment 44414
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44414=edit
Bug 10744 - ExpireReservesMaxPickUpDelay works with hold(s) over report

Hold(s) over -report at circ/waitingreserves.pl doesn't work because
ExpireReservesMaxPickup removes reserves from the koha.reserves-table to the
koha.old_reserves-table.

This patch adds a new column koha.reserves.pickupexpired telling when/if the
reserve has got it's pickup duration expired.

This date is used to pull old reserves to the waitingreserves-view.

syspref 'PickupExpiredHoldsOverReportDuration' controls how many days after
expiration old reserves are displayed on the report, and the values respect
Koha::Calendar holidays

Web tests included.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14723] Additional delivery notes to messages

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #44367|0   |1
is obsolete||

--- Comment #20 from Olli-Antti Kivilahti  ---
Created attachment 44413
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44413=edit
Bug 14723 - Additional delivery notes to messages - fixed missing kohastructure

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #157 from Kyle M Hall  ---
Created attachment 44408
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44408=edit
Bug 11431 [QA Followup] - Update help

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11431] Add additional sound options for warnings

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

--- Comment #159 from Kyle M Hall  ---
Created attachment 44411
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44411=edit
Bug 11431: QA follow-up: Typo in help file / variable name

Fixes the variable name to avoid a double-up that made it
impossible to turn off the sounds in general. If AudioAlerts
are turned off, they will only work on the audio administration
page now so you can set up and test the different sounds there.

Also fixes a little typo in the help file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/