date:20151228

[Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem)

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #46012|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 46013
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46013=edit
[PASSED QA] Bug 15431: svc/checkouts dies due to undefined variable (13024
merge problem)

When bug 13024 was merged into 3.20.x, a bug was introduced by replacing the
old way to fetch itemtype descriptions with the newer (3.22+).

To test:
- Perform a checkout on a patron
- Check so all checkouts are shown immediately
=> FAIL: It keeps loading forever. The logs show the svc/checkouts script died
- Apply the patch
- Reload page
=> SUCCESS: It loads the circ information correctly
- Sign off :-D

Regards

Signed-off-by: Frédéric Demians 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem)

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||aleishaamo...@hotmail.com

--- Comment #16 from Aleisha Amohia  ---
Applying: bug 12446 - Enable adult patrons to have a guarantor
/home/vagrant/kohaclone/.git/rebase-apply/patch:456: trailing whitespace.
#recover all data from guarantor address phone ,fax... 
/home/vagrant/kohaclone/.git/rebase-apply/patch:468: trailing whitespace.
B_city B_state B_zipcode B_country B_email B_phone)) {  
fatal: sha1 information is lacking or useless (C4/Utils/DataTables/Members.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 bug 12446 - Enable adult patrons to have a guarantor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9949] Tidy up the intranet set up and fix a potential security issue when running from git

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949

--- Comment #13 from Mason James  ---
(In reply to Marc Véron from comment #12)
> Is this bug still valid?

Hi, yes, i think so ^

Chris, can you recall the commands to regenerate the 1st patch? (16993) , it's
got a bunch of conflict errors now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9949] Tidy up the intranet set up and fix a potential security issue when running from git

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949

--- Comment #14 from Chris Cormack  ---
(In reply to Mason James from comment #13)
> (In reply to Marc Véron from comment #12)
> > Is this bug still valid?
> 
> Hi, yes, i think so ^
> 
> Chris, can you recall the commands to regenerate the 1st patch? (16993) ,
> it's got a bunch of conflict errors now

Just a bunch of git mv

Then editing the config files

And yes, this is still valid and a major reason why you should never run from a
git checkout for production.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #46003|0   |1
is obsolete||

--- Comment #42 from Aleisha Amohia  ---
Created attachment 46015
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46015=edit
Bug 12528 - fix problem when insert OPACEnhancedMessagingPreferences

Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15428] New: Different timeout preference for opac and intranet

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428

Bug ID: 15428
   Summary: Different timeout preference for opac and intranet
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Authentication
  Assignee: gmcha...@gmail.com
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

See also bug 1627.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1627] Separate sessions for OPAC and intranet

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1627

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #6 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #5)
> I think closing this one would be ok - but there is an open issue: because
> we only have one session, it's not possible to set different time out times
> - the same pref is used for both staff and OPAC. It could still be desirable
> to separate the sessions to make this possible.

I opened bug 15428 for this specific enhancement request.
Closing this bug now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0' is given

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015

--- Comment #14 from Marc Véron  ---
Hi Marcel, a question: Can you reproduce / confirm the problem as described in
comment #11?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0' is given

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015

Marc Véron  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12670] Show materials label instead of code

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12670

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #18 from Jonathan Druart  
---
CONFLICT (content): Merge conflict in circ/circulation.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14770] Use $9 in GetMarcSeries to build search link

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14770

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
Tests are missing for the changes in C4::Biblio::GetMarcSeries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14495] WebDriver/WebTester Factory for easy generation of Web testing UserAgents.

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14495

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |BLOCKED
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15405] XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15405

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #45960|0   |1
is obsolete||

--- Comment #12 from Marcel de Rooy  ---
Created attachment 45993
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45993=edit
Bug 15405 - XML paths to zebra libraries is wrong for 64-bit installs on
non-Debian linux Adjusts the modulePath to search in the well-known location
for 64 bit systems. Required for at least Fedora.

Test plan:
Without this patch, doing a zebra reindex on a fedora-based install will cause
errors like this:
15:10:47-01/05 zebraidx(16108) [warn] No such record type:
dom./etc/koha/zebradb/biblios/etc/dom-config.xml
With this patch, reindexing should just work.

Signed-off-by: Chris Cormack 
I have tested this doesn't break on debian/ubuntu systems, someone with a non
debian system will need to test it on that

Signed-off-by: Bob Ewart bob-ew...@bobsown.com
It works on openSUSE Leap 42.1

Signed-off-by: Marcel de Rooy 
Just noting that the debian zebra files already contain much more paths here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15405] XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15405

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15405] XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15405

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15376] Edit invoices: Can not change Shipping cost.

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15376

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||m.de.r...@rijksmuseum.nl

--- Comment #7 from Marcel de Rooy  ---
I followed the test plan. And can (also) change the shipping cost for an
invoice without shipment date in current master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15423] Batch checkout dateformat error

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15423

Marc Véron  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15429

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15429] sub _parseletter should not change referenced values

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15429

Marc Véron  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15423

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #45840|0   |1
is obsolete||

--- Comment #28 from Jonathan Druart  
---
Created attachment 45997
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45997=edit
Bug 15049: (followup) Add warning about "No active currency"

Fix translatibiity issues and use include in admin/aqplan.tt as well.
See comment #24

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #45778|0   |1
is obsolete||

--- Comment #26 from Jonathan Druart  
---
Created attachment 45995
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45995=edit
Bug 15049: Add warning about "No active currency" to Acquisitions start page

If no active currency is defined, Acquisitions does not work properly and
software
can occur while receiving.
This patch adds the warning message about missing active currency to Home >
Acquisitions

To test:
- Apply patch
- Go to Home > Administration > Currencies & Exchange Rates > Currencies
- Make sure that no active currency is set
- Go to Home > Acquisitions
- Verify that a warning displays:
  - If user has at least permission for parameters_remaining_perissions,
the warning should display a link to Currencies and exchange rates
(currency.pl)
  - If the user has no permission to edit the Currencies and exchange rates,
no link is displayed.
- Set an active currency
- Veryfy that the warning no longer displays

(Amended to remove superfluous line / mv)

Signed-off-by: Bernardo Gonzalez Kriegel 
Work as described. No errors

Signed-off-by: JM Broust 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #45779|0   |1
is obsolete||

--- Comment #27 from Jonathan Druart  
---
Created attachment 45996
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45996=edit
Bug 15049: (Signed off) Hide currency but preserv alert

This follow up hides currency, but the alert pops
if no currency is active.

To test:
1) Apply the patch
2) Unset any active currency
3) Alert must show on Acquisitons home
4) Set a currency active, no currency display on Acqui home
5) Check that currency IS displayed on /cgi-bin/koha/admin/aqbudgets.pl
or /cgi-bin/koha/admin/aqbudgetperiods.pl

Amended for better translation

Currency does / does not display as described in test plan.
Signed-off-by: Marc Véron 

Signed-off-by: JM Broust 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11590] Restrict the actions for the DB user

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11590] Restrict the actions for the DB user

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #40963|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11590] Restrict the actions for the DB user

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|jonathan.dru...@bugs.koha-c |koha-b...@lists.koha-commun
   |ommunity.org|ity.org
 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14573

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14791] Automatically attempt to resend failed notices

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12426

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14791

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0' is given

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #13 from Marcel de Rooy  ---
if ( ( @$barcodes == 0 )  && ( ! @$barcodes eq '0')  && ( $print eq 'maybe' ) )

I agree with Jonathan. This code needs to be adjusted.
If $barcodes == [ '0'], the second test cannot be true since @$barcodes will be
1.

Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12421] no way to get back to search results from overdrive results

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12421

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
The html filter should be used for both lines I would say.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288

--- Comment #24 from Marc Véron  ---
Search for better wording for 400 / 402:

See: https://tools.ietf.org/html/rfc2616#section-10.4

10.4.1 400 Bad Request
   The request could not be understood by the server due to malformed
   syntax. The client SHOULD NOT repeat the request without
   modifications.

10.4.2 401 Unauthorized
   The request requires user authentication. (...)

10.4.3 402 Payment Required
   This code is reserved for future use.

10.4.4 403 Forbidden
   The server understood the request, but is refusing to fulfill it.
   Authorization will not help (...)


10.4.5 404 Not Found
   The server has not found anything matching the Request-URI. (...)
   This status code is commonly used when the server does not wish to
   reveal exactly why the request has been refused, or when no other
   response is applicable.


10.5.1 500 Internal Server Error
   The server encountered an unexpected condition which prevented it
   from fulfilling the request.


Porposals for the template:

400 (New wording):
The request could not be understood by the server due to malformed
syntax.

401 (no changes to patch):
You are trying to access a link that you're not authorized to see.
Try logging in to the catalog.

402 (remove):
It seems that 402 is not used (git grep '402.pl')
Can be removed.

403 (no changes to patch):
You are forbidden for some reason to see this page.

404 (no changes to patch):
You made use of an external link to a catalog item that is no longer
available.
You followed an outdated link e.g. from a search engine or a bookmark.
You tried to access a page that needs authentification.
An internal link in our catalog home page is broken and the page does not
exist.

405:
An internal error occurred while processing your request.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15188] remove_unused_authorities.pl will delete all authorities if zebra is not running

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188

--- Comment #4 from Jonathan Druart  
---
Same behavior with 1.30

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12952] Log koha actions to syslog too

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12952

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Needs Signoff   |RESOLVED

--- Comment #9 from Jonathan Druart  
---
We have Koha::Logger (bug 14167) now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15429] sub _parseletter should not change referenced values

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15429

--- Comment #1 from Marc Véron  ---
Created attachment 45994
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45994=edit
Bug 15429 - sub _parseletter should not change referenced values

In C4/Letters.pm, sub _parseletter changes values that are passed by
reference. E.g. patron's expiry date can change from iso format to
syspref format, leading to strange behaviour in the calling routines
(see Bug 15423).

This patch makes sub _parseletter work on a copy of the referenced values.

(Submitted to get feedback - is this the way to go?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15429] sub _parseletter should not change referenced values

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15429

--- Comment #2 from Marc Véron  ---
To reproduce an issue with strange value changes (patron's expiry date) see Bug
15423.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8643] Add important constraint to marc subfields

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643

--- Comment #23 from Jonathan Druart  
---
Comment on attachment 45835
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45835
[SIGNED-OFF] Bug 8643: Removed the use of CGI::checkbox for "Important"
subfield and duplicate authorized tag

Review of attachment 45835:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=8643=45835)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt
@@ -111,4 @@
>   />
>  [% END %]
>  
> -Authorized value: [% 
> authorised_value %] (if you select a value here, the indicators will be 
> limited to the authorized value list)

Why do you remove this line?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15188] remove_unused_authorities.pl will delete all authorities if zebra is not running

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
Why don't you just check that the zebra daemon is running?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0' is given

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015

Marc Véron  changed:

   What|Removed |Added

  Attachment #45873|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14719] Regression tests for members/statistics.pl

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14719

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Needs Signoff   |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing.

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Needs Signoff   |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0' is given

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015

--- Comment #16 from Marc Véron  ---
Created attachment 45999
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45999=edit
Bug 14015 - Checkout: Fix software error if barcode '0' is given

To reproduce the bug:
- Go to Home > Circulation > Checkouts > [a patron]
- Enter 0 (zero) in barcode field and hit Enter

Result:
Software error
  Can't use string ("1") as a HASH ref while "strict refs" in use
  at /usr/share/kohaclone/circ/circulation.pl line 473

To test:
- Apply patch
- Repeat steps above
- Verify that the sofware error is gone and that you get a
  message as with other invalid barcodes.
- Test with other values: '00', '000', existing barcode,
  and a barcode that does not exist
- Test with empty barcode (for printing slip)
- Search for regressions

This patch implements Jonathan's solution (see comment #15)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0' is given

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0' is given

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #45999|0   |1
is obsolete||

--- Comment #17 from Marcel de Rooy  ---
Created attachment 46000
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46000=edit
Bug 14015 - Checkout: Fix software error if barcode '0' is given

To reproduce the bug:
- Go to Home > Circulation > Checkouts > [a patron]
- Enter 0 (zero) in barcode field and hit Enter

Result:
Software error
  Can't use string ("1") as a HASH ref while "strict refs" in use
  at /usr/share/kohaclone/circ/circulation.pl line 473

To test:
- Apply patch
- Repeat steps above
- Verify that the sofware error is gone and that you get a
  message as with other invalid barcodes.
- Test with other values: '00', '000', existing barcode,
  and a barcode that does not exist
- Test with empty barcode (for printing slip)
- Search for regressions

This patch implements Jonathan's solution (see comment #15)

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14654] Add desk filter in Holds awaiting pickup list

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14654

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15429] New: sub _parseletter should not change referenced values

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15429

Bug ID: 15429
   Summary: sub _parseletter should not change referenced values
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org

In C4/Letters.pm, sub _parseletter changes values that are passed by reference.
E.g. patron's expiry date can change from iso format to syspref format,leading
to strange behaviour in the calling routines (see Bug 15423).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15423] Batch checkout dateformat error

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15423

--- Comment #5 from Marc Véron  ---
With Bug 15429 applied I can no longe reproduce the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049

--- Comment #29 from Jonathan Druart  
---
Created attachment 45998
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45998=edit
Bug 15049: Simplify code in aqplan.tt

There was no need to duplicate this code in the template.
The only change with before this patch is that the "Currency = CUR"
and "Each cell contain both actual and estimated values." are now
displayed on 2 lines instead of 1.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8643] Add important constraint to marc subfields

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #24 from Jonathan Druart  
---
QA comments:
1/ You have to deal with the items' fields too. I can mark a 995/952 field as
important, but the behavior is not implemented when adding items.
2/ If a field is marked as important and mandatory, there are 2 stars (1 red
and 1 black), is it the expected behavior? Maybe the importance of a field can
be ignored if it is also marked as mandatory.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #17 from Jonathan Druart  
---
CONFLICT (content): Merge conflict in virtualshelves/sendshelf.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #25 from Jonathan Druart  
---
CONFLICT (content): Merge conflict in serials/subscription-add.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0' is given

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #46000|0   |1
is obsolete||

--- Comment #18 from Jonathan Druart  
---
Created attachment 46001
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46001=edit
Bug 14015 - Checkout: Fix software error if barcode '0' is given

To reproduce the bug:
- Go to Home > Circulation > Checkouts > [a patron]
- Enter 0 (zero) in barcode field and hit Enter

Result:
Software error
  Can't use string ("1") as a HASH ref while "strict refs" in use
  at /usr/share/kohaclone/circ/circulation.pl line 473

To test:
- Apply patch
- Repeat steps above
- Verify that the sofware error is gone and that you get a
  message as with other invalid barcodes.
- Test with other values: '00', '000', existing barcode,
  and a barcode that does not exist
- Test with empty barcode (for printing slip)
- Search for regressions

This patch implements Jonathan's solution (see comment #15)

Signed-off-by: Marcel de Rooy 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0' is given

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11759] Batch checkout

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||14015


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015
[Bug 14015] Checkout: Fix software error if barcode '0' is given
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0' is given

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||11759


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759
[Bug 11759] Batch checkout
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Failed QA

--- Comment #23 from Marcel de Rooy  ---
imo the argument of adjusted error templates is not really valid; as Chris and
Katrin already pointed out, this holds for any template.
So I would not oppose these changes.
But I think the new template text needs more attention. Two examples. Perhaps
check text changes with a native speaker?

400: Koha is pointed an invalid link.
Is this valid English?
402: Same string.
These are separate http status codes. They should not have the same message.

Could you try to keep close to the original messages for http statuses?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1"

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Needs Signoff   |Failed QA

--- Comment #2 from Kyle M Hall  ---
Please provide a test plan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0' is given

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #12 from Marcel de Rooy  ---
> Go to Home > Circulation > Checkouts > [a patron]

This was quite confusing actually.
It is: Go to Home > Patrons > [enter patron] > Check out

Back to SO

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14015] Checkout: Fix software error if barcode '0' is given

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015

--- Comment #15 from Jonathan Druart  
---
Marc,
Try with only this change:

diff --git a/circ/circulation.pl b/circ/circulation.pl
index f16475e..fa62dcc 100755
--- a/circ/circulation.pl
+++ b/circ/circulation.pl
@@ -88,7 +88,9 @@ if (!C4::Context->userenv && !$branch){
 }

 my $barcodes = [];
-if ( my $barcode = $query->param('barcode') ) {
+my $barcode =  $query->param('barcode');
+# Barcode given by user could be '0'
+if ( $barcode || $barcode eq '0' ) {
 $barcodes = [ $barcode ];
 } else {
 my $filefh = $query->upload('uploadfile');
@@ -215,12 +217,13 @@ if( $onsite_checkout && !$duedatespec_allow ) {
 }

It will work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
CONFLICT (content): Merge conflict in opac/opac-user.pl
CONFLICT (content): Merge conflict in C4/Circulation.pm

Tests are missing for the new subroutine.

GetIssues which takes issue_id is more a GetIssue subroutine, don't you think?

Why are you doing an ajax request? It won't work if the user does not have
javascript enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14573] Correcting messages on OPAC error pages so they make more sense

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14573

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15288

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15430] New: MARC21: Abbreviated names missing ending . in XSLT views

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15430

Bug ID: 15430
   Summary: MARC21: Abbreviated names missing ending . in XSLT
views
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

Example: 

A person's second name is abbreviated:
100 $aHuber, Peter M.

This will display as: 
von Huber, Peter M 

Our XSLT is too greedy in removing the . at the end of fields in this case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15423] Batch checkout dateformat error

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15423

Marc Véron  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #7 from Marc Véron  ---


*** This bug has been marked as a duplicate of bug 15429 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15429] sub _parseletter should not change referenced values

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15429

Marc Véron  changed:

   What|Removed |Added

 CC||cost...@gmail.com

--- Comment #3 from Marc Véron  ---
*** Bug 15423 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9060] Data update for nb-NO webinstaller

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9060

Magnus Enger  changed:

   What|Removed |Added

   Severity|normal  |minor
Summary|Add additional sample data  |Data update for nb-NO
   |to Norwegian installer  |webinstaller

--- Comment #1 from Magnus Enger  ---
Repurposing this. It's been a long time since I checked the files for the nb-NO
webinstaller were up to date.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1"

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277

Barton Chittenden  changed:

   What|Removed |Added

  Attachment #46002|0   |1
is obsolete||

--- Comment #4 from Barton Chittenden  ---
Created attachment 46005
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46005=edit
Test data

Query for test data:

select
biblionumber,
title,
ExtractValue( marcxml,
'//datafield[@tag=521][@ind1=0]/subfield[@code="a"]' ) as 'Reading grade
level',
ExtractValue( marcxml,
'//datafield[@tag=521][@ind1=1]/subfield[@code="a"]' ) as 'Interest age level',
ExtractValue( marcxml,
'//datafield[@tag=521][@ind1=2]/subfield[@code="a"]' ) as 'Interest grade
level',
ExtractValue( marcxml,
'//datafield[@tag=521][@ind1=8]/subfield[@code="a"]' ) as 'Lexile number'
from
biblioitems
inner join biblio using (biblionumber)
where
biblionumber in ( 86147 , 88090 , 89886 , 90198 , 90669 , 221316 ,
221317 , 221318 , 221319 , 221320 )


+--+--+-++--++
| biblionumber | title| Reading grade level | Interest age
level | Interest grade level | Lexile number  |
+--+--+-++--++
|86147 | Laura Ingalls Wilder | 5.0 4. 6.1  | 7-11.
 | 5-8 2-6. | Lexile 780 780 |
|88090 | Poppleton forever| 1.  | 4-7. 
 | P-3. | Lexile 410 410 |
|89886 | The music of dolphins| 6.  | 11-13.   
 | 5-9. | 560|
|90198 | Worth| 4.5.| 9-12.
 | 4-7. | T 830  |
|90669 | Monday with a mad genius | 3.8.| 6-9. 
 | 1-4. | 590 590|
|   221316 | Persian cats /   | 0.5.| 4-8. 
 | K-3 0-2. | 580|
|   221317 | Maine coon cats /| 0.5.| 4-8. 
 | K-3 0-2. | 600|
|   221318 | Calico cats /| 0.5.| 4-8. 
 | K-3 0-2. | 510|
|   221319 | Scottish fold cats / | 0.5.| 4-8. 
 | K-3 0-2. | 550|
|   221320 | Siamese cats /   | 0.5.| 4-8. 
 | K-3 0-2. | 480|
+--+--+-++--++

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15429] sub _parseletter should not change referenced values

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15429

Marc Véron  changed:

   What|Removed |Added

 Depends on||15432


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15432
[Bug 15432] t/db_dependent/Letters.t depends on external data/configuration
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15432] t/db_dependent/Letters.t depends on external data/configuration

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15432

Marc Véron  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Blocks||15429
 Status|NEW |Needs Signoff


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15429
[Bug 15429] sub _parseletter should not change referenced values
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem)

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15431] svc/checkouts dies due to undefined variable (13024 merge problem)

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 46004
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46004=edit
Bug 15431: svc/checkouts dies due to undefined variable (13024 merge problem)

When bug 13024 was merged into 3.20.x, a bug was introduced by replacing the
old way to fetch itemtype descriptions with the newer (3.22+).

To test:
- Perform a checkout on a patron
- Check so all checkouts are shown immediately
=> FAIL: It keeps loading forever. The logs show the svc/checkouts script died
- Apply the patch
- Reload page
=> SUCCESS: It loads the circ information correctly
- Sign off :-D

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12099] process_message_queue.pl tells it sends print mails even if it doesn't.

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12099

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Needs Signoff   |Failed QA

--- Comment #3 from Jonathan Druart  
---
I don't think this is relevant, please detail the need.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

--- Comment #41 from Bouzid  ---
Created attachment 46003
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46003=edit
Bug 12528 - fix problem when insert OPACEnhancedMessagingPreferences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528

Bouzid  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15188] remove_unused_authorities.pl will delete all authorities if zebra is not running

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188

--- Comment #6 from Jonathan Druart  
---
Have a look at about.pl
 94 my $errZebraConnection = C4::Context->Zconn("biblioserver",0)->errcode();

This could do the trick correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15430] MARC21: Abbreviated names missing ending . in XSLT views

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15430

--- Comment #1 from Katrin Fischer  ---
I think the problem is in SubfieldSelect in the Utils file.

It's hard to come up with a good condition for when to keep the . and when to
remove it. Something that could work in most cases: if the . is preceded by a
space and a capital letter (' [A-Z]'), then keep it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14573] Correcting messages on OPAC error pages so they make more sense

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14573

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1"

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277

--- Comment #3 from Barton Chittenden  ---
Created attachment 46002
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46002=edit
Test data containing 521 8  $b Lexile $a 530

Test data.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15431] New: svc/checkouts dies due to undefined variable (13024 merge problem)

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15431

Bug ID: 15431
   Summary: svc/checkouts dies due to undefined variable (13024
merge problem)
 Change sponsored?: ---
   Product: Koha
   Version: 3.20
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When bug 13024 was merged into 3.20.x, a bug was introduced by replacing the
old way to fetch itemtype descriptions with the newer (3.22+).

To reproduce:
- Perform a checkout on a patron
- Check so all checkouts are shown immediately
=> FAIL: It keeps loading forever. The logs show the svc/checkouts script died

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15188] remove_unused_authorities.pl will delete all authorities if zebra is not running

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15188

--- Comment #5 from Alex Arnaud  ---
(In reply to Jonathan Druart from comment #3)
> Why don't you just check that the zebra daemon is running?

Because:
- it would depend on system command to get the pid that could not be installed.
- the daemon could run on a remote server.
- also, it seems that we have the same problem if zebra is running with nothing
indexed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15432] t/db_dependent/Letters.t depends on external data/configuration

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15432

--- Comment #1 from Marc Véron  ---
Created attachment 46006
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46006=edit
Bug 15432: t/db_dependent/Letters.t depends on external data/configuration

To test:

- Set system preference LetterLog to 'Don't log'
- prove t/db_dependent/Letters.t
- Result: Fails on test 62 - Successfully sent claim
- Apply patch
- Test again
- Result: Pass OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1"

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277

Barton Chittenden  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #5 from Barton Chittenden  ---
== TO TEST ==

Set-up:

Add the following branch codes:  CES, EBE, PSM, SES, TCE, UES.
Add itemtype BOOK

Import data from attachment 46005.

Re-index, search for 'title Laura Ingalls Wilder'. This should return
biblionumber 86147.

Add the following to intranetuserjs

$(document).ready(function(){
//add lexile to search pull downs
$("select[name='idx']").append("Lexile score (e.g. 600 or 550-650
)");
$("select[name='idx']").append("Interest Age Level");
$("select[name='idx']").append("Interest Grade Level");
$("select[name='idx']").append("+Reading Grade Level");
});

Test plan:

1/ Go to advanced search, select 'Lexile score'. Search for 600 . Search will
fail
2/ Go to advanced search, select 'Lexile score'. Search for 500-599 . Search
will fail
3/ Go to advanced search, select 'Reading grade level'. Search for 1 . Search
will fail
4/ Go to advanced search, select 'Interest age level'. Search for 4-8 . Search
will fail
5/ Go to advanced search, select 'Interest grade level'. Search for 1-4 .
Search will fail
6/ Apply patch.
7/ Go to advanced search, select 'Lexile score'. Search for 600 . 
   Search will return
   Title: 'Maine coon cats'
8/ Go to advanced search, select 'Lexile score'. Search for 500-599 . 
   Search will return
   Title: 'The music of dolphins', 'Monday with a mad genius', 'Persian cats',
'Calico cats', ' Scottish fold cats'
9/ Go to advanced search, select 'Reading grade level'. Search for 1 . 
   Search will return
   Title: 'Poppleton forever'
10/ Go to advanced search, select 'Interest age level'. Search for 4-8 . 
   Search will return
   Title: 'Maine coon cats', 'Siamese cats', 'Persian cats', 'Calico cats',
'Scottish fold cats'
11/ Go to advanced search, select 'Interest grade level'. Search for 1-4 . 
   Search will return 
   Title: 'Monday with a mad genius'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13742] Object accessor for overduerules- and overduerules_transport_types-tables.

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13742

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Needs Signoff   |ASSIGNED

--- Comment #3 from Jonathan Druart  
---
What is suppose to do this patch?
It depends on bug 4171 which does not have patches attached.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15432] New: t/db_dependent/Letters.t depends on external data/configuration

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15432

Bug ID: 15432
   Summary: t/db_dependent/Letters.t depends on external
data/configuration
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org

To reproduce:
- Set system preference LetterLog to 'Don't log'
- prove t/db_dependent/Letters.t
- Result: Fails on test 62 - Successfully sent claim
- Set system preference LetterLog to 'Log
- Test again
- Result: Pass OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15423] Batch checkout dateformat error

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15423

--- Comment #6 from bondiurbano  ---
Issue resolved applying patch described in bug #15429.

Tested in 3.22.1

Thanks Marc!

(Should I change the status of this bug to RESOLVED?)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15432] t/db_dependent/Letters.t depends on external data/configuration

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15432

Marc Véron  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |ve...@veron.ch
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12549] Hard coded font Paths ( DejaVu ) cause problems for non-Debian systems

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12549

Federico  changed:

   What|Removed |Added

 CC||federicol...@tiscali.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15405] XML paths to zebra libraries is wrong for 64-bit installs on non-Debian linux

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15405

Federico  changed:

   What|Removed |Added

 CC||federicol...@tiscali.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11569] Typo in userpermissions.sql

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11569

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14480] Warns when modifying patron

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14480

--- Comment #7 from Jonathan Druart  
---
See comment 2 for the correct way to fix it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15235] Add column filters to checkouts table

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15235

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |julian.maur...@biblibre.com
   |ity.org |
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Needs Signoff   |BLOCKED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14555] Warns in opac-search.pl

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14555

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Needs Signoff   |ASSIGNED

--- Comment #6 from Jonathan Druart  
---
Please provide a more detailed test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14555] Warns in opac-search.pl

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14555

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|mar...@bugs.koha-community. |aleishaamo...@hotmail.com
   |org.xinxidi.net |
   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15342] Performance 3.22 - Omnibus

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15429] sub _parseletter should not change referenced values

2015-12-28 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15429

Marc Véron  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #4 from Marc Véron  ---
Switching to "Needs Signoff"

Test plan:
Reproduce without this patch:
- Try to repruduce issue in Bug 15423 (comment #2)
- make sure that patron with batch checkout permissionhas nothing checked out
- Go to batch checkout
- enter 2 valid barcodes
- Then enter a line with one space character
- Then enter one more empty line or a barcode
Example:
e.g.
1
2

3
('empty' line contains one space character)

Expected result:
Software error
The given date (13/05/2022 00:00) does not match the date format (iso) at
/usr/share/kohaclone/Koha/DateUtils.pm line 153.

- If not yet done, apply patch 15432
- prove -v t/db_dependent/Letters.t
Expected Result: OK

Test with patch:
- apply patch
- try to reproduce software error above

Expected result: No software error, checkouts OK

- prove -v t/db_dependent/Letters.t
Expected result: OK


(Note: I did not manage to create a test to reproduce Bug 15423 in Letters.t)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 141 matches

Mail list logo